Re: [PATCH v2] doc: add maintainer book

2017-11-24 Thread Greg Kroah-Hartman
On Sat, Nov 25, 2017 at 08:44:19AM +1100, Tobin C. Harding wrote: > There is currently very little documentation in the kernel on maintainer > level tasks. In particular there are no documents on creating pull > requests to submit to Linus. > > Quoting Greg Kroah-Hartman on LKML: > > Anyway,

About GPL license compliance of Tesla Model S, Linux kernel 4.4

2017-11-24 Thread Geunsik Lim
Hi All, I want to talk about a potential GPL misuse of the Linux open source that is used by Tesla Model S. Some months ago, I have read that a version information of Linux kernel that is deployed into the commercial self-driving car such as Tesla Model S via (1) the twitter web page of Tesla CEO

[PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-11-24 Thread Linus Lüssing
So far any changes with ebtables will reset the state of limit rules, leading to spikes in traffic. This is especially noticeable if changes are done frequently, for instance via a daemon. This patch fixes this by bailing out from (re)setting if the limit rule was initialized before. When sending

[PATCH resend] mm/page_alloc: fix comment is __get_free_pages

2017-11-24 Thread JianKang Chen
From: Jiankang Chen __get_free_pages will return an 64bit address in 64bit System like arm64 or x86_64. And this comment really confuse new bigenner of mm. Signed-off-by: Jiankang Chen --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/

[PATCH 1/4] staging: ccree: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during sys_init_dir() should be removed in sys_free_dir() Signed-off-by: Arvind Yadav --- drivers/staging/ccree/ssi_sysfs.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c i

[PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during ldlm_setup() should be removed in ldlm_cleanup(). Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c b/drivers/s

[PATCH 4/4] staging: most: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during dim2_sysfs_probe() should be removed in dim2_sysfs_destroy(). Signed-off-by: Arvind Yadav --- drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/most/hdm-dim2/dim2_sysfs.c b/drivers/staging/most/hdm-d

[PATCH 0/4] Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
Arvind Yadav (4): [PATCH 1/4] staging: ccree: Remove a attribute group from a kobject [PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject [PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject [PATCH 4/4] staging: most: Remove a attribute group

[PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject

2017-11-24 Thread Arvind Yadav
All attribute group created during class_procfs_init() should be removed. if class_procfs_init() will fail and also in class_procfs_clean(). Signed-off-by: Arvind Yadav --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

[PATCH] mm/page_alloc: fix comment is __get_free_pages

2017-11-24 Thread JianKang Chen
From: c00426987 __get_free_pages will return an 64bit address in 64bit System like arm64 or x86_64. And this comment really confuse new bigenner of mm. reported-by: Hanjun Guo Signed-off-by: Chen Jiankang --- mm/page_alloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t

2017-11-24 Thread Mike Snitzer
On Fri, Nov 24, 2017 at 2:36 AM, Reshetova, Elena wrote: >> On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote: >> > } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) { >> > r = upgrade_mode(dd, mode, t->md); >> > if (r) >> > ret

[PATCH] usbhid: add quirk for another PIXART OEM mouse used by HP

2017-11-24 Thread Dave Young
This mouse keep disconnecting in runleve 3 like below, add it needs the quirk to mute the anoying messages. [ 111.230555] usb 2-2: USB disconnect, device number 6 [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd [ 112.941594] usb 2-2: New USB device found, idVendor=03f0,

Re: [PATCH 2/2] clocksource: sprd: Add timer driver for Spreadtrum SC9860 platform

2017-11-24 Thread kbuild test robot
Hi Baolin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH v2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread Dan Carpenter
On Sat, Nov 25, 2017 at 02:29:36AM +0100, ishraq.i.ash...@gmail.com wrote: > + > + ret = 0; > + Sorry, I wasn't clear before. When I said don't initialize "ret" to zero, I just meant that in that specific case we initialized "ret" and then immediately reassigned it with: ret = some_f

[PATCH v2] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-24 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. So make the function return void. Fix these checkpatch.pl error: ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces requir

Re: [PATCH 2/2] clocksource: sprd: Add timer driver for Spreadtrum SC9860 platform

2017-11-24 Thread kbuild test robot
Hi Baolin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread Dan Carpenter
Thanks for doing this. This needs to be folded in with the earlier patch you send and then resend it as a V2 patch. https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb I added Johannes to the CC list again because this is sort of his fault... To be honest, I'

Re: [PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-24 Thread Joe Perches
On Sat, 2017-11-25 at 09:45 +0530, Arvind Yadav wrote: > Here, The function pdc_hardware_init always return zero. So it is not > necessary to check its return value. > > Fix these checkpatch.pl error: > > ERROR: space prohibited after that '~' (ctx:WxW) > + mask &= ~ (1 << (6 + ATA_SH

[PATCH] pata_pdc2027x: Remove unnecessary error check and coding style error.

2017-11-24 Thread Arvind Yadav
Here, The function pdc_hardware_init always return zero. So it is not necessary to check its return value. Fix these checkpatch.pl error: ERROR: space prohibited after that '~' (ctx:WxW) + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA)); ERROR: spaces required around that '?' (ctx:VxW) +

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Dave Hansen
On 11/24/2017 08:09 PM, Dave Hansen wrote: > Doesn't this stack trace mean we started C-code page fault handing on > the sysenter stack? Seems like we missed a switch to the process stack. ... and probably a KAISER switch to the kernel CR3.

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Dave Hansen
On 11/24/2017 12:22 PM, Ingo Molnar wrote: > [8.831002] RIP: 0010:page_fault+0x11/0x60 > [8.831002] RSP: :ff0e7fc8 EFLAGS: 00010046 > [8.831002] RAX: 819d4d77 RBX: 0001 RCX: > 819d4d77 > [8.831002] RDX: 0003 RSI: 0010

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-24 Thread Theodore Ts'o
On Fri, Nov 24, 2017 at 08:51:02AM -0800, Andi Kleen wrote: > > I think e2fsck can fix this quite easily, and there really isn't > > an easy way to revert to the old method if the large xattr feature > > is enabled. If you are willing to run a new kernel, you should also > > be willing to run a ne

[f2fs-dev] [PATCH] f2fs: remove an excess variable

2017-11-24 Thread LiFan
Remove the variable page_idx which no one would miss. Signed-off-by: Fan li --- fs/f2fs/data.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index b0781ed..1a9 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1198,7 +1198,6 @@ stat

[PATCH v2 2/2] x86: disable IRQs before changing CR4

2017-11-24 Thread Nadav Amit
CR4 changes need to be performed while IRQs are disabled in order to update the CR4 shadow and the actual register atomically. Actually, they are needed regardless of CR4 shadowing, since CR4 are performed in a read-modify-write manner. Currently, however, this is not the case, as can be experienc

[PATCH v2 0/2] x86: disable IRQs during CR4 changes

2017-11-24 Thread Nadav Amit
CR4 needs to be updated atomically with its shadow value, as CR4 updates are performed in read-modify-write fashion which are based on the shadow value. If CR4 is changed between the read and the write, CR4 might not be updated correctly. For this to happen, CR4 needs to be rewritten by an interru

[PATCH v2 1/2] x86: refactor CR4 setting and shadow write

2017-11-24 Thread Nadav Amit
Refactor the write to CR4 and its shadow value. This is done in preparation for the addition of an assertion to check that IRQs are disabled during CR4 update. No functional change. Cc: Andy Lutomirski Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Signed-off-by

Re: [PATCH v2] KVM: X86: Fix softlockup when get the current kvmclock timestamp

2017-11-24 Thread kbuild test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on kvm/linux-next] [also build test WARNING on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 0/5] Consolidate init_task handling

2017-11-24 Thread Linus Torvalds
On Fri, Nov 24, 2017 at 5:31 AM, David Howells wrote: > > It doesn't seem useful to have the init_task in a header file rather than > in a normal source file. We could consolidate init_task handling instead. > Do want to do this? If so, this is probably something we'd want to do at > the end of

Re: [x86/mm/kaiser] a6c70b8b30: WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller

2017-11-24 Thread Fengguang Wu
On Fri, Nov 24, 2017 at 03:02:33PM +0100, Ingo Molnar wrote: * kernel test robot wrote: FYI, we noticed the following commit (built with gcc-6): commit: a6c70b8b30bf35045d14e352bfd1eb16aaee906f ("x86/mm/kaiser: Prepare assembly for entry/exit CR3 switching") https://git.kernel.org/cgit/lin

[PATCH v2] x86/mce: add support SRAO reported via CMC check

2017-11-24 Thread Xie XiuQi
In Intel SDM Volume 3B (253669-063US, July 2017), SRAO could be reported either via MCE or CMC: In cases when SRAO is signaled via CMCI the error signature is indicated via UC=1, PCC=0, S=0. Type(*1) UC EN PCC S AR Signaling --

Re: [PATCH] mm,madvise: bugfix of madvise systemcall infinite loop under special circumstances.

2017-11-24 Thread 郭雪楠
Yes , your modification is much better! thanks. 在 2017/11/24 21:08, Michal Hocko 写道: On Fri 24-11-17 20:51:29, 郭雪楠 wrote: Sorry,I explained wrong before. But,I've tested using trinity in DAX mode,and I'am sure it has possibility of triggering an soft lockup. I have encountered the problem of e

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-24 Thread Andi Kleen
> Sure, but not many people are going to be running a 4.14 kernel with > a 2007 system. It's not just root, but any disk. People could well have 10 year old disks. > Could you please run the updated find command to see > whether this is an isolated case, or if it is a common case: > > find / -

[PATCH v2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks private WEXT IOCTL calls of this driver as these are not invoked through ndo_do_ioctl interface anymore. As a result hostapd stops working with this driver. In this patch this problem is solved b

Re: [PATCH 20/23] x86, kaiser: add a function to check for KAISER being enabled

2017-11-24 Thread Eduardo Valentin
On Wed, Nov 22, 2017 at 04:35:18PM -0800, Dave Hansen wrote: > > From: Dave Hansen > > Currently, all of the checks for KAISER are compile-time checks. > > Runtime checks are needed for turning it on/off at runtime. > > Add a function to do that. > > Signed-off-by: Dave Hansen > Cc: Moritz L

Re: [PATCH 21/23] x86, kaiser: un-poison PGDs at runtime

2017-11-24 Thread Eduardo Valentin
On Wed, Nov 22, 2017 at 04:35:21PM -0800, Dave Hansen wrote: > > From: Dave Hansen > > With KAISER Kernel PGDs that map userspace are "poisoned" with > the NX bit. This ensures that if a kernel->user CR3 switch is > missed, userspace crashes instead of running in an unhardened > state. > > Thi

Re: [PATCH v2 2/2] ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture

2017-11-24 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2 2/2] ASoC: fsl_ssi: add 20-bit sample format for AC'97 and use it for capture

2017-11-24 Thread kbuild test robot
Hi Maciej, Thank you for the patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v4.14 next-20171124] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-24 Thread Finn Thain
On Fri, 24 Nov 2017, Greg Kroah-Hartman wrote: > > > > > > But what happens when the bus code is unloaded if it is built as a > > > module? The devices will be removed then. Or they should be. > > > > > > > This bus driver is not a module. > > It can not be built as a module ever? > That'

[PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-24 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Apply changes suggested by Dan Carpenter --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 1052 1 file changed, 536 insertions(+), 516 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_d

Re: [PATCH 22/43] x86/mm/kaiser: Prepare assembly for entry/exit CR3 switching

2017-11-24 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Ingo Molnar wrote: > @@ -1288,6 +1308,8 @@ ENTRY(error_entry) >* from user mode due to an IRET fault. >*/ > SWAPGS > + /* We have user CR3. Change to kernel CR3. */ > + SWITCH_TO_KERNEL_CR3 scratch_reg=%rax > > .Lerror_entry_from_usermode_after

Re: [PATCH] This patch is used ... [trimmed overly long subject]

2017-11-24 Thread Thomas Gleixner
Tim, Your patch looks good, but your patch description needs some care: Please do not write full sentences in the subject line. The subject line should be a short and precise information about the patch. The format is: [PATCH] subsystem: Short precise description. in this case: [

Re: [PATCH] x86/xen: support early interrupts in xen pv guests

2017-11-24 Thread Thomas Gleixner
On Fri, 24 Nov 2017, Andy Lutomirski wrote: > On Fri, Nov 24, 2017 at 12:52 AM, Juergen Gross wrote: > > Sorry, Andy, forgot to Cc: you... > > > > On 24/11/17 09:42, Juergen Gross wrote: > >> Add early interrupt handlers activated by idt_setup_early_handler() to > >> the handlers supported by Xen

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Ingo Molnar
* Andy Lutomirski wrote: > > Note that if *any* of those 4 padding sequences is removed, the kernel > > starts > > crashing again. Also note that the exact size of the padding appears to be > > not > > material - it could be larger as well, i.e. it's not an alignment bug I > > think. > > >

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Andy Lutomirski
> On Nov 24, 2017, at 3:09 PM, Ingo Molnar wrote: > > > * Ingo Molnar wrote: > >> >> * Ingo Molnar wrote: >> >>> This is a repost of the latest entry-stack plus Kaiser bits from Andy >>> Lutomirski >>> (v3 series from today) and Dave Hansen (kaiser-414-tipwip-20171123 version), >>> on to

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-24 Thread James Bottomley
On Fri, 2017-11-24 at 15:03 -0700, Andreas Dilger wrote: > On Nov 24, 2017, at 9:51 AM, Andi Kleen wrote: > > > > > > > > > > We checked old kernels, and old e2fsprogs, and didn't see any > > > cases > > > where fast (<= 60 chars) symlinks were created using external > > > blocks. > > > It seem

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > This is a repost of the latest entry-stack plus Kaiser bits from Andy > > Lutomirski > > (v3 series from today) and Dave Hansen (kaiser-414-tipwip-20171123 version), > > on top of latest tip:x86/urgent (12a78d43de76). > > > > This version

Re: XArray documentation

2017-11-24 Thread Matthew Wilcox
On Fri, Nov 24, 2017 at 11:02:41PM +0100, Martin Steigerwald wrote: > I like this. > > I bet I may not be able help much further with it other than to possibly > proofread it tomorrow. > > Thank you for considering my suggestion. Not at all; your feedback has significantly improved this documen

[PATCH] [media] v4l: mt9v032: Disable clock on error paths

2017-11-24 Thread Alexey Khoroshilov
mt9v032_power_on() leaves clk enabled in case of errors, but it is not expected by its callers. There is a similar problem in mt9v032_registered(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/i2c/mt9v032.c | 21 +

Re: regression: 4.13 cannot follow symlinks on some ext3 fs

2017-11-24 Thread Andreas Dilger
On Nov 24, 2017, at 9:51 AM, Andi Kleen wrote: > >> We checked old kernels, and old e2fsprogs, and didn't see any cases >> where fast (<= 60 chars) symlinks were created using external blocks. >> It seems that _something_ did create them, and it would be good to >> figure that out so we can deter

Re: XArray documentation

2017-11-24 Thread Martin Steigerwald
Matthew Wilcox - 24.11.17, 22:18: > On Fri, Nov 24, 2017 at 07:01:31PM +0100, Martin Steigerwald wrote: > > > The XArray is an abstract data type which behaves like an infinitely > > > large array of pointers. The index into the array is an unsigned long. > > > A freshly-initialised XArray contain

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Ingo Molnar
* Ingo Molnar wrote: > > That's weird and definitely not intentional. > > Btw., can you reproduce the crash by disabling CONFIG_DEBUG_ENTRY with > CONFIG_KAISER=y? I've attached a .config that triggers the crash on bootup on just about any hardware, before even hitting user-space. So I think

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Ingo Molnar
* Andy Lutomirski wrote: > On Fri, Nov 24, 2017 at 12:22 PM, Ingo Molnar wrote: > > > > * Ingo Molnar wrote: > > > >> This is a repost of the latest entry-stack plus Kaiser bits from Andy > >> Lutomirski > >> (v3 series from today) and Dave Hansen (kaiser-414-tipwip-20171123 > >> version), >

[PATCH v2] doc: add maintainer book

2017-11-24 Thread Tobin C. Harding
There is currently very little documentation in the kernel on maintainer level tasks. In particular there are no documents on creating pull requests to submit to Linus. Quoting Greg Kroah-Hartman on LKML: Anyway, this actually came up at the kernel summit / maintainer meeting a few weeks

Re: [PATCH 0/4] staging: lustre: fixed some signedness warns from sparse

2017-11-24 Thread Tobin C. Harding
On Fri, Nov 24, 2017 at 04:02:09PM +0300, Dan Carpenter wrote: > On Fri, Nov 24, 2017 at 09:20:20AM +1100, Tobin C. Harding wrote: > > My current favourite review of all time was done by you on a what was > > at the time a pretty hard patch for me. It was > > > > Nope > > > > Wow... I know

Re: [PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2017-11-24 Thread Rolf Eike Beer
Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 24 Nov 2017 22:22:06 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/video/fbdev/stifb.c

Re: [RFC] doc: add maintainer book

2017-11-24 Thread Tobin C. Harding
On Fri, Nov 24, 2017 at 11:02:49AM -0800, Dan Williams wrote: > On Tue, Nov 21, 2017 at 2:39 PM, Tobin C. Harding wrote: > > There is currently very little documentation in the kernel on maintainer > > level tasks. In particular there are no documents on creating pull > > requests to submit to Lin

RE: [PATCH 1/3] perf bench futex: benchmark only online CPUs

2017-11-24 Thread James Yang
> -Original Message- > From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > Sent: Friday, November 24, 2017 1:09 PM > To: Davidlohr Bueso > Cc: James Yang ; Kim Phillips ; > Peter Zijlstra ; Ingo Molnar ; > Alexander Shishkin ; Jiri Olsa > ; Namhyung Kim ; Thomas Gleixner > ; Darren H

[PATCH] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 22:22:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/stifb.c | 4 +--- 1 file changed, 1 insertion(+),

Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

2017-11-24 Thread David Howells
Eric Biggers wrote: > if (dest_keyring) { > - construct_get_dest_keyring(&dest_keyring); Actually, I think I have the order of these lines inverted. construct_get_dest_keyring() can actually return without setting dest_keyring to anything. This didn't used to b

Re: [PATCH net] net: dsa: fix 'increment on 0' warning

2017-11-24 Thread Florian Fainelli
On 11/24/2017 08:36 AM, Vivien Didelot wrote: > Setting the refcount to 0 when allocating a tree to match the number of > switch devices it holds may cause an 'increment on 0; use-after-free', > if CONFIG_REFCOUNT_FULL is enabled. > > To fix this, do not decrement the refcount of a newly allocat

Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

2017-11-24 Thread David Howells
Eric Biggers wrote: > > > - construct_get_dest_keyring(&dest_keyring); > > > > This will break. construct_get_dest_keyring() does other things than just > > getting a ref on whatever dest_keyring points to. > > > > Not if dest_keyring is non-NULL (i.e. explicitly specified), w

Re: XArray documentation

2017-11-24 Thread Matthew Wilcox
On Fri, Nov 24, 2017 at 07:01:31PM +0100, Martin Steigerwald wrote: > > The XArray is an abstract data type which behaves like an infinitely > > large array of pointers. The index into the array is an unsigned long. > > A freshly-initialised XArray contains a NULL pointer at every index. > > Yes,

Re: [crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Andy Lutomirski
On Fri, Nov 24, 2017 at 12:22 PM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> This is a repost of the latest entry-stack plus Kaiser bits from Andy >> Lutomirski >> (v3 series from today) and Dave Hansen (kaiser-414-tipwip-20171123 version), >> on top of latest tip:x86/urgent (12a78d43de76)

[PATCH 4/4] video: udlfb: Delete an unnecessary return statement in two functions

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 21:36:39 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions. Signed-off-by: Markus Elfring --- driver

Re: [PATCH v3 0/4] platform/x86: intel_telemetry: Fix logs and formatting

2017-11-24 Thread Andy Shevchenko
On Fri, Nov 24, 2017 at 3:34 PM, Souvik Kumar Chakravarty wrote: > This patchset fixes https://bugzilla.kernel.org/show_bug.cgi?id=197833, and > other issues related to telemetry counters. It also cleans up formatting > and removes redundant code. > > It is rebased on top of the TESTING branch. >

[PATCH 3/4] video: udlfb: Improve a size determination in dlfb_alloc_urb_list()

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 21:30:37 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 2/4] video: udlfb: Return an error code only as a constant in dlfb_realloc_framebuffer()

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 21:22:25 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/video/fbdev/udlf

[PATCH 1/4] video: udlfb: Delete an error message for a failed memory allocation in two functions

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 21:12:54 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/udlfb.c | 8 ++-- 1 file changed, 2 insertio

[PATCH 0/4] video-UDLFB: Adjustments for five function implementations

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 21:45:54 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Delete an error message for a failed memory allocation in two functions Return an error code only as a constant in dlfb_realloc_fr

Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring

2017-11-24 Thread Eric Biggers
On Fri, Nov 24, 2017 at 03:52:05PM +, David Howells wrote: > Eric Biggers wrote: > > > - construct_get_dest_keyring(&dest_keyring); > > This will break. construct_get_dest_keyring() does other things than just > getting a ref on whatever dest_keyring points to. > Not if

[ANNOUNCE] v4.14.1-rt3

2017-11-24 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v4.14.1-rt3 patch set. Changes since v4.14.1-rt2: - The "memcontrol Prevent scheduling while atomic in cgroup code" caused harm in a 4.4-RT kernel. Uppon investigation it turned out that the patch was no longer required and reverting would av

[crash] PANIC: double fault, error_code: 0x0

2017-11-24 Thread Ingo Molnar
* Ingo Molnar wrote: > This is a repost of the latest entry-stack plus Kaiser bits from Andy > Lutomirski > (v3 series from today) and Dave Hansen (kaiser-414-tipwip-20171123 version), > on top of latest tip:x86/urgent (12a78d43de76). > > This version is pretty well tested, at least on the usu

Re: [PATCH 1/3] net: core: export dev_alloc_name_ns

2017-11-24 Thread David Miller
From: Rasmus Villemoes Date: Tue, 21 Nov 2017 01:34:37 +0100 > dev_alloc_name_ns and dev_get_valid_name now do exactly the same > thing. Let's expose this functionality as dev_alloc_name_ns > (obviously, a core function like this won't return an invalid > name...). > > Signed-off-by: Rasmus Vill

Re: [PATCH net-next 00/12] rxrpc: Fixes and improvements

2017-11-24 Thread David Miller
From: David Howells Date: Fri, 24 Nov 2017 14:37:39 + > Is it too late for this to go to Linus in this merge window? These look predominantly like fixes so I'll pull this in. Thanks.

Re: XArray documentation

2017-11-24 Thread Matthew Wilcox
On Fri, Nov 24, 2017 at 11:48:49AM -0800, Shakeel Butt wrote: > Adding on to Martin's questions. Basically what is the motivation > behind it? It seems like a replacement for radix tree, so, it would be > good to write why radix tree was not good enough or which use cases > radix tree could not sol

[PATCH] video/fbdev/vt8500lcdfb: Delete an error message for a failed memory allocation in vt8500lcd_probe()

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 20:42:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/vt8500lcdfb.c | 4 +--- 1 file changed, 1 insertio

Re: XArray documentation

2017-11-24 Thread Shakeel Butt
On Fri, Nov 24, 2017 at 10:01 AM, Martin Steigerwald wrote: > Hi Matthew. > > Matthew Wilcox - 24.11.17, 18:03: >> On Fri, Nov 24, 2017 at 05:50:41PM +0100, Martin Steigerwald wrote: >> > Matthew Wilcox - 24.11.17, 02:16: >> > > == >> > > XArray >> > > == >> > > >> > > Overview >> > >

[PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_probe()

2017-11-24 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 24 Nov 2017 20:22:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/wm8505fb.c | 4 +--- 1 file changed, 1 insertion(+

Re: [PATCH v4] x86/mm/kasan: Teach KASAN about the cpu_entry_area

2017-11-24 Thread Andy Lutomirski
On Fri, Nov 24, 2017 at 9:21 AM, Andrey Ryabinin wrote: > From: Andy Lutomirski > > The cpu_entry_area will contain stacks. Make sure that KASAN has > appropriate shadow mappings for them. LGTM. I'll update my tree, and Ingo can pick it up as a replacement if he wants.

Re: [PATCH v5 01/11] intel_sgx: updated MAINTAINERS

2017-11-24 Thread Jarkko Sakkinen
On Fri, Nov 17, 2017 at 01:54:22PM -0800, Darren Hart wrote: > On Mon, Nov 13, 2017 at 09:45:18PM +0200, Jarkko Sakkinen wrote: > > Signed-off-by: Jarkko Sakkinen > > --- > > MAINTAINERS | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2d3d7

Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on the entry stack

2017-11-24 Thread Andy Lutomirski
On Fri, Nov 24, 2017 at 10:25 AM, Borislav Petkov wrote: > On Fri, Nov 24, 2017 at 06:23:40PM +0100, Ingo Molnar wrote: >> From: Andy Lutomirski >> >> When we start using an entry trampoline, a #GP from userspace will >> be delivered on the entry stack, not on the task stack. Fix the >> espfix64

Re: [PATCH 14/43] x86/asm/64: Return to userspace from the trampoline stack

2017-11-24 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:42PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > By itself, this is useless. It gives us the ability to run some final > code before exit that cannnot run on the kernel stack. This could > include a CR3 switch a la KAISER or some kernel stack erasing, for

Re: perf test LLVM & clang 6 failing

2017-11-24 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 24, 2017 at 04:16:52PM +0100, Daniel Borkmann escreveu: > [ +Yonghong ] > > On 11/24/2017 03:47 PM, Arnaldo Carvalho de Melo wrote: > > FYI, just noticed, recently updated clang to version 6, from its > > upstream git repo. > > Do you recall what was your LLVM version prior to this wh

Re: [PATCH 1/3] perf bench futex: benchmark only online CPUs

2017-11-24 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 24, 2017 at 07:32:49AM -0800, Davidlohr Bueso escreveu: > On Thu, 23 Nov 2017, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Nov 23, 2017 at 12:09:48PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Nov 22, 2017 at 06:25:28PM -0600, Kim Phillips escreveu: > > > > From: James Y

Re: [RFC] doc: add maintainer book

2017-11-24 Thread Dan Williams
On Tue, Nov 21, 2017 at 2:39 PM, Tobin C. Harding wrote: > There is currently very little documentation in the kernel on maintainer > level tasks. In particular there are no documents on creating pull > requests to submit to Linus. > > Quoting Greg Kroah-Hartman on LKML: > > Anyway, this actua

Re: [PATCH 13/43] x86/asm/64: Use a percpu trampoline stack for IDT entries

2017-11-24 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:41PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > Historically, IDT entries from usermode have always gone directly > to the running task's kernel stack. Rearrange it so that we enter on > a percpu trampoline stack and then manually switch to the task's sta

Re: [PATCH] net-sysfs: export gso_max_size attribute

2017-11-24 Thread Eric Dumazet
On Fri, 2017-11-24 at 11:43 -0700, David Ahern wrote: > On 11/24/17 11:32 AM, Eric Dumazet wrote: > > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: > > > On 11/22/17 5:30 PM, Solio Sarabia wrote: > > > > The netdevice gso_max_size is exposed to allow users fine- > > > > control > > > > on >

Re: [PATCH] schedule: use unlikely()

2017-11-24 Thread Mikulas Patocka
On Fri, 24 Nov 2017, Ingo Molnar wrote: > * Mikulas Patocka wrote: > > > A small patch for schedule(), so that the code goes straght in the common > > case. > > > > Signed-off-by: Mikulas Patocka > > > > --- > > include/linux/blkdev.h |2 +- > > kernel/sched/core.c|2 +- > > 2

Re: [PATCH RFC 1/2] sched: Minimize the idle cpu selection race window.

2017-11-24 Thread Mike Galbraith
On Fri, 2017-11-24 at 11:26 +0100, Uladzislau Rezki wrote: > > I guess there is misunderstanding here. The main goal is not to cover > pinned case, for sure. I was thinking more about below points: > > - Extend a claim_wake_up logic for making an ILB/NO_HZ decision more > predictable (that is g

Re: [PATCH] net-sysfs: export gso_max_size attribute

2017-11-24 Thread David Ahern
On 11/24/17 11:32 AM, Eric Dumazet wrote: > On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: >> On 11/22/17 5:30 PM, Solio Sarabia wrote: >>> The netdevice gso_max_size is exposed to allow users fine-control >>> on >>> systems with multiple NICs with different GSO buffer sizes, and >>> where >

Re: [PATCH] net-sysfs: export gso_max_size attribute

2017-11-24 Thread Eric Dumazet
On Fri, 2017-11-24 at 10:14 -0700, David Ahern wrote: > On 11/22/17 5:30 PM, Solio Sarabia wrote: > > The netdevice gso_max_size is exposed to allow users fine-control > > on > > systems with multiple NICs with different GSO buffer sizes, and > > where > > the virtual devices like bridge and veth,

Re: [PATCH 12/43] x86/espfix/64: Stop assuming that pt_regs is on the entry stack

2017-11-24 Thread Borislav Petkov
On Fri, Nov 24, 2017 at 06:23:40PM +0100, Ingo Molnar wrote: > From: Andy Lutomirski > > When we start using an entry trampoline, a #GP from userspace will > be delivered on the entry stack, not on the task stack. Fix the > espfix64 #DF fixup to set up #GP according to TSS.SP0, rather than > ass

Re: [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 15:54:59, Andrea Reale wrote: > On Fri 24 Nov 2017, 16:43, Michal Hocko wrote: > > On Fri 24-11-17 14:49:17, Andrea Reale wrote: > > > Hi Rafael, > > > > > > On Fri 24 Nov 2017, 15:39, Rafael J. Wysocki wrote: > > > > On Fri, Nov 24, 2017 at 11:22 AM, Andrea Reale > > > > wrote:

Re: v4.14-rc{4,7} null pointer dereference in event_sched_out()

2017-11-24 Thread Mark Rutland
On Fri, Nov 24, 2017 at 06:10:56PM +, Mark Rutland wrote: > On Wed, Nov 15, 2017 at 06:00:20PM +, Will Deacon wrote: > > On Mon, Oct 30, 2017 at 04:23:15PM +, Mark Rutland wrote: > > > As a heads-up, while fuzzing arm64 v4.14-rc{4,7} with Syzkaller, I hit a > > > KASAN splat in event_sc

Re: v4.14-rc{4,7} null pointer dereference in event_sched_out()

2017-11-24 Thread Mark Rutland
On Wed, Nov 15, 2017 at 06:00:20PM +, Will Deacon wrote: > On Mon, Oct 30, 2017 at 04:23:15PM +, Mark Rutland wrote: > > As a heads-up, while fuzzing arm64 v4.14-rc{4,7} with Syzkaller, I hit a > > KASAN splat in event_sched_out(): > > > > [ 133.225742] > > ==

Re: XArray documentation

2017-11-24 Thread Martin Steigerwald
Hi Matthew. Matthew Wilcox - 24.11.17, 18:03: > On Fri, Nov 24, 2017 at 05:50:41PM +0100, Martin Steigerwald wrote: > > Matthew Wilcox - 24.11.17, 02:16: > > > == > > > XArray > > > == > > > > > > Overview > > > > > > > > > The XArray is an array of ULONG_MAX entries. Each entr

[PATCH 01/43] x86/decoder: Add new TEST instruction pattern

2017-11-24 Thread Ingo Molnar
From: Masami Hiramatsu The kbuild test robot reported this build warning: Warning: arch/x86/tools/test_get_len found difference at :8103dd2c Warning: 8103dd82: f6 09 d8 testb $0xd8,(%rcx) Warning: objdump says 3 bytes, but insn_get_length() says 2 Warning: decoded and c

[PATCH 03/43] x86/dumpstack: Add get_stack_info() support for the SYSENTER stack

2017-11-24 Thread Ingo Molnar
From: Andy Lutomirski get_stack_info() doesn't currently know about the SYSENTER stack, so unwinding will fail if we entered the kernel on the SYSENTER stack and haven't fully switched off. Teach get_stack_info() about the SYSENTER stack. With future patches applied that run part of the entry c

[PATCH 04/43] x86/gdt: Put per-cpu GDT remaps in ascending order

2017-11-24 Thread Ingo Molnar
From: Andy Lutomirski We currently have CPU 0's GDT at the top of the GDT range and higher-numbered CPUs at lower addresses. This happens because the fixmap is upside down (index 0 is the top of the fixmap). Flip it so that GDTs are in ascending order by virtual address. This will simplify a fu

Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket

2017-11-24 Thread Trond Myklebust
On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers infinite stream of the following > output > on console. The program is unkillable and this effectively brings the > machine down: > > > ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup

  1   2   3   4   5   6   >