Re: [PATCH v3] scripts/package: snap-pkg target

2017-11-28 Thread Jim Davis
On Tue, Nov 28, 2017 at 10:14 AM, Paolo Pisati wrote: > On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis wrote: >> >> With this patch applied to the 4.14 kernel source, and running make >> snap-pkg on a Ubuntu 16.04 VM with the latest 16.04 kernel config >> file, I ran into >> >> Traceback (most recent

[RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

2017-11-28 Thread Maran Wilson
For certain applications it is desirable to rapidly boot a KVM virtual machine. In cases where legacy hardware and software support within the guest is not needed, Qemu should be able to boot directly into the uncompressed Linux kernel binary without the need to run firmware. There already exists

Re: [PATCH 08/11] trace-cmd: Making start,extract,stream,profile separate funcs

2017-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2017 20:34:22 +0200 Vladislav Valtchev wrote: > On Tue, 2017-11-28 at 12:14 -0500, Steven Rostedt wrote: > > As everything is doing both init_common_record_context() and > > parse_record_options() why not just move the > > init_common_record_context() into parse_record_option

[PATCH] drm/ttm: Use a static string instead of an array of char *

2017-11-28 Thread Joe Perches
Make the object a bit smaller by using a simple string instead of a format string and array of char *. $ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o* textdata bss dec hex filename 8820 2164136 131723374 drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

2017-11-28 Thread Jason Gunthorpe
On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: > On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: > > On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > > I could resubmit just the series, or you could just pick the 4 driver > > > patches from patchwo

Re: [kernel-hardening] Re: [PATCH v5 next 5/5] net: modules: use request_module_cap() to load 'netdev-%s' modules

2017-11-28 Thread Theodore Ts'o
On Tue, Nov 28, 2017 at 01:16:59PM +0100, Geo Kozey wrote: > > Userspace can be configured in a way which is compatible with those > changes being on the same as it can be configured to work with > selinux. That means on distro level or sysadmin level it's a > valuable tool. It's better than nothi

[PATCH] scripts: Add ppc64le support for checkstack.pl

2017-11-28 Thread Breno Leitao
64-bit ELF v2 ABI specification for POWER describes, on section "General Stack Frame Requirements", that the stack should use the following instructions when compiled with backchain: mflr r0 std r0, 16(r1) stdu r1, -XX(r1) Where XX is the frame size for that function, and this is the value

Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state

2017-11-28 Thread Andy Shevchenko
On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer wrote: > On 2017-11-28 05:57 PM, Darren Hart wrote: >> On Tue, Nov 28, 2017 at 04:17:58PM +0100, Michel Dänzer wrote: >>> We were always checking bit 0 (which represents the docked state) >>> regardless of the mask. >>> >>> Fixes the "tablet mode" sta

[PATCH] regulator: lp8788: make various char arrays static const, shrinks object size

2017-11-28 Thread Colin King
From: Colin Ian King Don't populate the read-only arrays b1_name and b2_name on the stack but instead make them static and constify them. Makes the object code smaller by over 260 bytes: Before: textdata bss dec hex filename 69612256 092172401 drivers/reg

Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

2017-11-28 Thread Mika Westerberg
On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote: > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding > virtual interrupt numbers for keyboard/touchpa/touchscreen controllers > in ACPI tables, they will also update BIOS version number from 1.0 > to 1.1. Let's limit th

Re: [PATCH v3] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

2017-11-28 Thread Geert Uytterhoeven
Hi Nick, On Tue, Nov 28, 2017 at 7:18 PM, Nick Desaulniers wrote: > Thanks for merging Chris' patch, and sorry for taking so long to respond. > > On Wed, Nov 22, 2017 at 8:24 PM, Masahiro Yamada > wrote: >> Linus suggests to move compiler flag testing to Kconfig. > > Do you have an LKML link for

Re: [RFC 1/2] of: overlay: add whitelist

2017-11-28 Thread Alan Tull
On Tue, Nov 28, 2017 at 9:15 AM, Rob Herring wrote: > On Mon, Nov 27, 2017 at 02:58:03PM -0600, Alan Tull wrote: >> Add simple whitelist. When an overlay is submitted, if any target in >> the overlay is not in the whitelist, the overlay is rejected. Drivers >> that support dynamic configuration

Re: [PATCH V14 00/24] mmc: Add Command Queue support

2017-11-28 Thread Ulf Hansson
[...] >>> While we should look at changing blk-mq to give better workqueue >>> performance, >>> a bigger gain is likely to be made by adding a new host API to enable the >>> next already-prepared request to be issued directly from within ->done() >>> callback of the current request. > > I assume

Re: [PATCH 2/2 v8] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Yang Shi
On 11/28/17 11:20 AM, Waiman Long wrote: On 11/28/2017 02:13 PM, Yang Shi wrote: Sorry for the typo, it should be v2 in the subject. Yang On 11/28/17 11:12 AM, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cau

Re: [PATCH 2/2 v8] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Waiman Long
On 11/28/2017 02:13 PM, Yang Shi wrote: > Sorry for the typo, it should be v2 in the subject. > > Yang > > > On 11/28/17 11:12 AM, Yang Shi wrote: >> There are nested loops on debug objects free path, sometimes it may take >> over hundred thousands of loops, then cause soft lockup with >> !CONFIG_P

Re: [PATCH V14 00/24] mmc: Add Command Queue support

2017-11-28 Thread Ulf Hansson
Linus, Adrian, On 28 November 2017 at 10:42, Linus Walleij wrote: > On Tue, Nov 21, 2017 at 2:42 PM, Adrian Hunter > wrote: > >> Here is V14 of the hardware command queue patches without the software >> command queue patches, now using blk-mq and now with blk-mq support for >> non-CQE I/O. >> >

[PATCH] block: DAC960: make various char arrays static const, shrinks object size

2017-11-28 Thread Colin King
From: Colin Ian King Don't populate the read-only arrays ReadCacheStatus, WriteCacheStatus and SenseErrors on the stack but instead make them static and constify them. Makes the object code smaller by over 540 bytes: Before: textdata bss dec hex filename 151673 32984 96

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2017 20:57:13 +0200 Vladislav Valtchev wrote: > On Tue, 2017-11-28 at 13:30 -0500, Steven Rostedt wrote: > > On Tue, 28 Nov 2017 20:17:46 +0200 > > Vladislav Valtchev wrote: > > > > > Since that code was profile-specific, I put it in trace_profile(), > > > without 'if' statemen

[PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

2017-11-28 Thread Dmitry Torokhov
As Google/Intel will fix the BIOS/Coreboot issues with hardcoding virtual interrupt numbers for keyboard/touchpa/touchscreen controllers in ACPI tables, they will also update BIOS version number from 1.0 to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ numbers on Strago boards to

Re: [PATCH 08/13] dt-bindings: mips: Add bindings for Microsemi SoCs

2017-11-28 Thread Florian Fainelli
On 11/28/2017 07:26 AM, Alexandre Belloni wrote: > Add bindings for Microsemi SoCs. Currently only Ocelot is supported. > > Signed-off-by: Alexandre Belloni > --- > Cc: Rob Herring > Cc: devicet...@vger.kernel.org > > Documentation/devicetree/bindings/mips/mscc.txt | 6 ++ > 1 file changed

Re: [PATCH 2/2 v8] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Yang Shi
Sorry for the typo, it should be v2 in the subject. Yang On 11/28/17 11:12 AM, Yang Shi wrote: There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: s

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Mon, Nov 27, 2017 at 06:18:34PM +0100, Djalal Harouni wrote: ... > After a discussion with Rusty Russell [1], the suggestion was to pass > the capability from request_module() to security_kernel_module_request() > for 'netdev-%s' modules that need CAP_NET_ADMIN, and after review from > Kees Coo

Re: KASAN: stack-out-of-bounds Write in sha3_final

2017-11-28 Thread Eric Biggers
On Tue, Nov 28, 2017 at 05:24:00AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 0c86a6bd85ff0629cd2c5141027fc1c8bb6cde9c > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console ou

[PATCH 2/2 v8] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT

2017-11-28 Thread Yang Shi
There are nested loops on debug objects free path, sometimes it may take over hundred thousands of loops, then cause soft lockup with !CONFIG_PREEMPT occasionally, like below: NMI watchdog: BUG: soft lockup - CPU#15 stuck for 22s! [stress-ng-getde:110342] Modules linked in: binfmt_misc(E) tcp_di

Re: KASAN: slab-out-of-bounds Write in sha3_final

2017-11-28 Thread Eric Biggers
On Tue, Nov 28, 2017 at 05:24:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6fc478f80f6809cc4b1a4230f47a62d3b7378dc0 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

[PATCH 1/2 v2] lib: debugobjects: export max loops counter

2017-11-28 Thread Yang Shi
Currently max chain counter is exported to debugfs, it just record the counter of inner loop, however, there might be significant iterations of external loop then it may take significant amount of time to finish all of the checks. This may cause lockup on !CONFIG_PREEMPT kernel build occasionally.

Re: [PATCH v6 06/11] intel_sgx: driver for Intel Software Guard Extensions

2017-11-28 Thread Sean Christopherson
> diff --git a/arch/x86/include/asm/sgx_arch.h b/arch/x86/include/asm/sgx_arch.h > new file mode 100644 > index ..515676031006 > --- /dev/null > +++ b/arch/x86/include/asm/sgx_arch.h > @@ -0,0 +1,268 @@ [...] > + > +#ifndef _ASM_X86_SGX_ARCH_H > +#define _ASM_X86_SGX_ARCH_H Still mis

Sending 802.1Q packets using AF_PACKET socket on filtered bridge forwards with wrong MAC addresses

2017-11-28 Thread Brandon Carpenter
While attempting to send ARP DAD packets on a bridge device, I noticed that hosts attached to the bridge ports were not responding. After digging in with tcpdump/wireshark, I noticed that the MAC addresses of the packets (the first 12 bytes of the Ethernet frame) were wrong and were an exact duplic

[PATCH v2] KEYS: add missing permission check for request_key() destination

2017-11-28 Thread Eric Biggers
From: Eric Biggers When the request_key() syscall is not passed a destination keyring, it links the requested key (if constructed) into the "default" request-key keyring. This should require Write permission to the keyring. However, there is actually no permission check. This can be abused to

Re: [RFC patch 7/7] timekeeping: Hack to use fine grained timestamps during boot

2017-11-28 Thread Mark Salyzyn
On 11/28/2017 10:43 AM, Prarit Bhargava wrote: On 11/23/2017 07:58 AM, Petr Mladek wrote: On Wed 2017-11-15 19:15:38, Thomas Gleixner wrote: For demonstration purposes only. Add a disgusting hack to work around the fact that high resolution clock MONOTONIC accessors are not available during e

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Linus Torvalds
On Tue, Nov 28, 2017 at 11:00 AM, Alan Cox wrote: > > The notation in question has been standard in tools like lint since the > end of the 1970s Yes. That said, maybe one option would be to annotate the "case:" and "default:" statements if that makes people happier. IOW, we could do something l

Re: ALSA: nm256: Fine-tuning for three function implementations

2017-11-28 Thread SF Markus Elfring
>> Examples: >> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe() >> https://lkml.org/lkml/2017/11/18/266 >> https://patchwork.kernel.org/patch/10064945/ >> >> https://lkml.kernel.org/r/ > > This is no trivial patch. Why do you find this one more challenging now than a s

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

2017-11-28 Thread Leon Romanovsky
On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: > On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: > > On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > > I could resubmit just the series, or you could just pick the 4 driver > > > patches from patchwo

Re: [PATCH] KEYS: add missing permission check for request_key() destination

2017-11-28 Thread Eric Biggers
On Tue, Nov 28, 2017 at 10:13:01AM +, David Howells wrote: > Eric Biggers wrote: > > > + if (do_perm_check) { > > + ret = key_permission(make_key_ref(dest_keyring, 1), > > +KEY_NEED_WRITE); > > dest_keyring may be NULL at th

'perf test BPF' failing, libbpf regression wrt "basic API for BPF obj name"

2017-11-28 Thread Arnaldo Carvalho de Melo
So, I had 'perf test BPF' failing in perf/core, at first thought it was due to an update I had made to clang, but then I noticed that with perf/urgent it works, so something else, did a bisection and got to: [acme@jouet linux]$ git bisect bad 88cda1c9da02c8aa31e1d5dcf22e8a35cc8c19f2 is the first b

Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches

2017-11-28 Thread Peter Zijlstra
On Tue, Nov 28, 2017 at 10:13:30AM -0800, Dave Hansen wrote: > Thanks for looking at this, Peter. I've been resisting doing this for a > bit and it's an embarrassingly small amount of code. Right, well, its not complete yet, and it might be complete crap :-) > On 11/28/2017 08:39 AM, Peter Zijls

Re: [PATCH 11/11] trace-cmd: Introducing get_trace_cmd_type()

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 13:32 -0500, Steven Rostedt wrote: > On Tue, 28 Nov 2017 12:17:49 -0500 > Steven Rostedt wrote: > > > Never mind. This is dependent. I pulled in patch 9 and 10 though. I'll > > do some tests and push out the lastest so you can rebase on top of that. > > I did a push to mast

Re: [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t

2017-11-28 Thread Mike Snitzer
On Tue, Nov 28 2017 at 5:07am -0500, Reshetova, Elena wrote: > > > On Fri, Nov 24, 2017 at 2:36 AM, Reshetova, Elena > > wrote: > > >> On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote: > > >> > } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) { > > >> >

Re: [PATCH V14 17/24] mmc: block: blk-mq: Add support for direct completion

2017-11-28 Thread Ulf Hansson
[...] > > diff --git a/drivers/mmc/core/queue.h b/drivers/mmc/core/queue.h > index 1d7d3b0afff8..c4271fa54f1a 100644 > --- a/drivers/mmc/core/queue.h > +++ b/drivers/mmc/core/queue.h > @@ -103,6 +103,7 @@ struct mmc_queue { > boolwaiting; > struct work_struct

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Alan Cox
> I have no idea who came up with that brilliant idea of parsing comments in > the code. It's so simple to make this parser completely fail that it's not Stephen Johnson (author of the V7 portable C compiler), which is where it's from (the lint tool). He also wrote yacc so he does know a bit about

Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int()

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 12:05 -0500, Steven Rostedt wrote: > > Couple of things. > > 1) A change like this should always be directly before the patch that > requires it. This is patch 5, and it's not until patch 8 that this > change is required. Please keep them next to each other. This should > ha

[PATCH] mtd: mtdswap: make array 'name' static const, shrinks object size

2017-11-28 Thread Colin King
From: Colin Ian King Don't populate the read-only array 'name' on the stack but instead make it static and constify it. Makes the object code smaller by 35 bytes: Before: textdata bss dec hex filename 26304 352 31100797c drivers/mtd/mtdswap.o After: tex

Re: [RFC PATCH] arch, mm: introduce arch_tlb_gather_mmu_exit

2017-11-28 Thread Will Deacon
On Thu, Nov 23, 2017 at 10:02:36AM +0100, Michal Hocko wrote: > From: Michal Hocko > > 5a7862e83000 ("arm64: tlbflush: avoid flushing when fullmm == 1") has > introduced an optimization to not flush tlb when we are tearing the > whole address space down. Will goes on to explain > > : Basically,

Re: [PATCH v7 1/5] add infrastructure for tagging functions as error injectable

2017-11-28 Thread Jonathan Corbet
On Wed, 22 Nov 2017 16:23:30 -0500 Josef Bacik wrote: > From: Josef Bacik > > Using BPF we can override kprob'ed functions and return arbitrary > values. Obviously this can be a bit unsafe, so make this feature opt-in > for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in >

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 13:30 -0500, Steven Rostedt wrote: > On Tue, 28 Nov 2017 20:17:46 +0200 > Vladislav Valtchev wrote: > > > Since that code was profile-specific, I put it in trace_profile(), > > without 'if' statements, clearly. > > This is all about balancing. You were able to remove one if

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-28 Thread Boris Ostrovsky
On 11/28/2017 04:12 AM, Christian König wrote: > > > How about the attached patch? It limits the newly added MMIO space to > the upper 256GB of the address space. That should still be enough for > most devices, but we avoid both issues with Xen dom0 as most likely > problems with memory hotplug as

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Gustavo A. R. Silva
Quoting Thomas Gleixner : On Tue, 28 Nov 2017, Thomas Gleixner wrote: +CC Linus. On Tue, 28 Nov 2017, Thomas Gleixner wrote: > On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > > Quoting Thomas Gleixner : > > > > To be honest, such comments annoy me during a code review especially when >

RE: [Intel-wired-lan] [PATCH] fm10k: mark PM functions as __maybe_unused

2017-11-28 Thread Singh, Krishneil K
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of Keller, Jacob E > Sent: Wednesday, October 11, 2017 3:20 PM > To: Arnd Bergmann ; Kirsher, Jeffrey T > > Cc: Kwan, Ngai-mint ; net...@vger.kernel.org; > Florian Westphal ; linux-kernel

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

2017-11-28 Thread Bart Van Assche
On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: > On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > I could resubmit just the series, or you could just pick the 4 driver > > patches from patchworks whatever is easiest. > > I marked them in patchworks, but can you re

Re: [PATCH 01/17] drm/sun4i: Refactor DE2 code

2017-11-28 Thread Jernej Škrabec
Hi! Dne torek, 28. november 2017 ob 16:54:42 CET je Maxime Ripard napisal(a): > Hi, > > On Mon, Nov 27, 2017 at 09:57:34PM +0100, Jernej Skrabec wrote: > > Since the time initial DE2 driver was written, some knowledge was gained > > what setting are really necessary and what most of the magic val

Re: [RFC patch 7/7] timekeeping: Hack to use fine grained timestamps during boot

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Prarit Bhargava wrote: > On 11/23/2017 07:58 AM, Petr Mladek wrote: > > On Wed 2017-11-15 19:15:38, Thomas Gleixner wrote: > >> For demonstration purposes only. > >> > >> Add a disgusting hack to work around the fact that high resolution clock > >> MONOTONIC accessors are not a

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Thomas Gleixner wrote: +CC Linus. > On Tue, 28 Nov 2017, Thomas Gleixner wrote: > > > On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > > > Quoting Thomas Gleixner : > > > > > To be honest, such comments annoy me during a code review especially > > > > > when > > > > > the

Re: [RFC patch 7/7] timekeeping: Hack to use fine grained timestamps during boot

2017-11-28 Thread Prarit Bhargava
On 11/23/2017 07:58 AM, Petr Mladek wrote: > On Wed 2017-11-15 19:15:38, Thomas Gleixner wrote: >> For demonstration purposes only. >> >> Add a disgusting hack to work around the fact that high resolution clock >> MONOTONIC accessors are not available during early boot and return stale >> time st

[PATCH 2/2] locking/core: Remove break_lock field when CONFIG_GENERIC_LOCKBREAK=y

2017-11-28 Thread Will Deacon
When CONFIG_GENERIC_LOCKBEAK=y, locking structures grow an extra int break_lock field which is used to implement raw_spin_is_contended() by setting the field to 1 when waiting on a lock and clearing it to zero when holding a lock. However, there are a few problems with this approach: - There is

[PATCH 0/2] Fix boot regression for s390 and remove break_lock

2017-11-28 Thread Will Deacon
Hi all, The following two patches do the following: 1. Fix boot breakage reported on s390 caused by a8a217c22116 2. Kill off the break_lock field entirely, since it's not actually that useful I didn't go the whole hog and remove CONFIG_GENERIC_LOCKBREAK, since the "do something differen

[PATCH 1/2] locking/core: Fix deadlock during boot on systems with GENERIC_LOCKBREAK

2017-11-28 Thread Will Deacon
Commit a8a217c22116 ("locking/core: Remove {read,spin,write}_can_lock()") removed the definition of raw_spin_can_lock, causing the GENERIC_LOCKBREAK spin_lock routines to poll the break_lock field when waiting on a lock. This has been reported to cause a deadlock during boot on s390, because the b

Re: [PATCH v3 2/5] drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove

2017-11-28 Thread Brian Norris
Hi Nickey, On Tue, Nov 28, 2017 at 07:20:03PM +0800, Nickey Yang wrote: > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our Other reviews have suggested this might be described as "SoC glue driver", not "parent dr

Re: [PATCH 1/2] mm: NUMA stats code cleanup and enhancement

2017-11-28 Thread Andi Kleen
Vlastimil Babka writes: > > I'm worried about the "for_each_possible..." approach here and elsewhere > in the patch as it can be rather excessive compared to the online number > of cpus (we've seen BIOSes report large numbers of possible CPU's). IIRC Even if they report a few hundred extra readin

Re: [PATCH 10/13] MIPS: mscc: add ocelot dtsi

2017-11-28 Thread Florian Fainelli
On 11/28/2017 07:26 AM, Alexandre Belloni wrote: > Add a device tree include file for the Microsemi Ocelot SoC. > > Signed-off-by: Alexandre Belloni > --- > + ahb { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > +

Re: general protection fault in af_alg_free_areq_sgls

2017-11-28 Thread Eric Biggers
On Tue, Nov 28, 2017 at 10:10:55AM +0100, Stephan Mueller wrote: > > diff --git a/crypto/af_alg.c b/crypto/af_alg.c > > index 358749c38894..415a54ced4d6 100644 > > --- a/crypto/af_alg.c > > +++ b/crypto/af_alg.c > > @@ -672,14 +672,15 @@ void af_alg_free_areq_sgls(struct af_alg_async_req > > *areq)

Re: [PATCH] hwmon: (pmbus/lm25066) Default coefficients for low current limit

2017-11-28 Thread Rob Lippert
On Mon, Nov 27, 2017 at 8:26 PM, Guenter Roeck wrote: > On 11/27/2017 04:28 PM, Robert Lippert wrote: >> >> There seems to be no way to detect the value of the CL/GAIN pin >> from the device using PMBus. >> >> Low current mode seems to be recommended (from LM5066 datasheet) for >> improved current

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

2017-11-28 Thread Jason Gunthorpe
On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > > >If you treat all unmarked patches (without mentioning in cover letter or > >subject title) as targeted to for-next, it will make your life much more > >easier than trying to pick each patch alone. As an outcome, it will make

Re: [PATCH 1/2] i40iw: remove unused 'timeval' struct member

2017-11-28 Thread Shiraz Saleem
On Mon, Nov 27, 2017 at 04:38:09AM -0700, Arnd Bergmann wrote: > There is a stale entry in i40iw_cm_tcp_context that apparently > was copied from the 'nes' driver but never used in i40iw. > I'm trying to kill off all users of timeval as part of the > y2038-safety work, so let's just remove this one

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Thomas Gleixner wrote: > On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > > Quoting Thomas Gleixner : > > > > To be honest, such comments annoy me during a code review especially > > > > when > > > > the fallthrough is so obvious as in this case. There might be cases > > >

Re: ALSA: nm256: Fine-tuning for three function implementations

2017-11-28 Thread Takashi Iwai
On Tue, 28 Nov 2017 18:15:34 +0100, SF Markus Elfring wrote: > > >> Do you want that I point any other patch out which you could find > >> easier to handle again? > > > > Only if they got tested and/or got reviewed by others. > > Would you find any of the following update suggestions trivial eno

Re: [PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

2017-11-28 Thread Will Deacon
On Tue, Nov 21, 2017 at 11:44:13AM +0800, Chen Feng wrote: > With kaslr and kasan enable both, I got the follow issue. > > [ 16.130523s]kasan: reg->base = 1, phys_end =1c000,start = > 4000, end = ffc0 > [ 16.142517s]___alloc_bootmem_nopanic:257 > [ 16.148

Re: [PATCH 08/11] trace-cmd: Making start,extract,stream,profile separate funcs

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 12:14 -0500, Steven Rostedt wrote: > As everything is doing both init_common_record_context() and > parse_record_options() why not just move the > init_common_record_context() into parse_record_options(). If you need > to do something special (like set events = 1 for p

Re: [PATCH] arm64: fix missing 'const' qualifiers

2017-11-28 Thread Will Deacon
On Sat, Nov 25, 2017 at 12:41:27PM +0300, Yury Norov wrote: > It was discovered during LTO-enabled compilation with gcc/ld.bfd. What was discovered? Could you provide a bit more information in the changelog, please? I'm happy to take this as a fix if it's actually fixing something. Will

Re: [PATCH 11/11] trace-cmd: Introducing get_trace_cmd_type()

2017-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2017 12:17:49 -0500 Steven Rostedt wrote: > Never mind. This is dependent. I pulled in patch 9 and 10 though. I'll > do some tests and push out the lastest so you can rebase on top of that. I did a push to master on k.org. Please rebase on top of that. It includes patches you have

Re: [PATCH v6 04/11] x86: define IA32_FEATUE_CONTROL.SGX_LC

2017-11-28 Thread Sean Christopherson
On Tue, 2017-11-28 at 09:16 -0800, Sean Christopherson wrote: > On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote: > > > > When IA32_FEATURE_CONTROL.SGX_LC identifies that the root key for > > enclave signatures can be configured either by the OS or pre-boot > > firmware. > > > > If this t

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-28 Thread Steven Rostedt
On Tue, 28 Nov 2017 20:17:46 +0200 Vladislav Valtchev wrote: > Since that code was profile-specific, I put it in trace_profile(), > without 'if' statements, clearly. This is all about balancing. You were able to remove one if statement, but required two function calls by all others. -- Steve

Re: [Lkft-triage] [PATCH 4.14 000/193] 4.14.3-stable review

2017-11-28 Thread Naresh Kamboju
On 28 November 2017 at 15:54, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.3 release. > There are 193 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Respo

Re: [PATCH 4.4 00/96] 4.4.103-stable review

2017-11-28 Thread Nathan Chancellor
On Tue, Nov 28, 2017 at 11:22:09AM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.103 release. > There are 96 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > Quoting Thomas Gleixner : > > > To be honest, such comments annoy me during a code review especially when > > > the fallthrough is so obvious as in this case. There might be cases where > > > its worth to document because it's non obvious, but docum

[PATCH] gpio: gpio-stmpe: make various char arrays static const, shrinks object size

2017-11-28 Thread Colin King
From: Colin Ian King Don't populate the read-only arrays edge_det_values, rise_values and fall_values on the stack but instead make them static and constify them. Makes the object code smaller by over 240 bytes: Before: textdata bss dec hex filename 95252520 192 1

Re: [PATCH v2] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset

2017-11-28 Thread Jakub Kicinski
On Tue, 28 Nov 2017 15:23:00 +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 27, 2017 at 12:35:44PM -0800, Jakub Kicinski wrote: > > Recent commit moved the implementation of debugfs_real_fops() > > out of the header file. The declaration, however, is only > > provided if CONFIG_DEBUG_FS is set. A

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Gustavo A. R. Silva
Quoting Thomas Gleixner : On Tue, 28 Nov 2017, Thomas Gleixner wrote: On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > Quoting Thomas Gleixner : > > > On Mon, 27 Nov 2017, Gustavo A. R. Silva wrote: > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we

Re: [PATCH] drm/bridge/synopsis: stop clobbering drvdata

2017-11-28 Thread Brian Norris
Hi Laurent, On Tue, Nov 28, 2017 at 02:51:46PM +0200, Laurent Pinchart wrote: > Hi Brian, > > Thank you for the patch. > > I'd mention dw-mipi-dsi in the subject line as the directory contains the dw- > hdmi driver as well that this patch doesn't touch. Yep. Does it need another tag in the subj

Re: [PATCH v3] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

2017-11-28 Thread Nick Desaulniers
Hi Masahiro, Thanks for merging Chris' patch, and sorry for taking so long to respond. On Wed, Nov 22, 2017 at 8:24 PM, Masahiro Yamada wrote: > Linus suggests to move compiler flag testing to Kconfig. Do you have an LKML link for context? On Wed, Nov 15, 2017 at 6:32 PM, Masahiro Yamada wrot

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Thomas Gleixner wrote: > On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > > Quoting Thomas Gleixner : > > > > > On Mon, 27 Nov 2017, Gustavo A. R. Silva wrote: > > > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > > where we are expecting t

Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()

2017-11-28 Thread Vladislav Valtchev
On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote: > > Is there a reason that init_instance() isn't called in > init_common_record_context()? > Hi Steven, init_instance() has been put into init_common_record_context() later, in patch 8, "Making start,extract,stream,profile separate funcs"

Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Tommi Rantala
On 28.11.2017 16:58, David Miller wrote: From: Tommi Rantala Date: Tue, 28 Nov 2017 14:53:15 +0200 - - if (unlikely(msg_user(hdr) == LINK_CONFIG)) { - err = tipc_udp_rcast_disc(b, skb); - if (err) - goto rcu_out; + } else { +

Re: [PATCH 11/21] x86/dumpstack: Handle stack overflow on all stacks

2017-11-28 Thread Josh Poimboeuf
On Mon, Nov 27, 2017 at 09:29:26PM -0800, Andy Lutomirski wrote: > On Mon, Nov 27, 2017 at 8:29 PM, Josh Poimboeuf wrote: > > On Mon, Nov 27, 2017 at 11:26:30AM -0800, Linus Torvalds wrote: > >> On Mon, Nov 27, 2017 at 2:45 AM, Ingo Molnar wrote: > >> > From: Andy Lutomirski > >> > > >> > We cur

Re: [PATCH] staging: irda: annotate irlan_seq_start() and irlan_seq_stop() for sparse

2017-11-28 Thread Andrii
On 11/28/2017 3:05 PM, Greg KH wrote: On Tue, Nov 28, 2017 at 02:45:25PM +0200, Andrii Vladyka wrote: Annotate rcu_read_lock in irlan_seq_start() and rcu_read_unlock in irlan_seq_stop() for sparse Signed-off-by: Andrii Vladyka https://e.mail.ru/compose?To=tu...@mail.ru>> Something went really

Re: [PATCH v4] ARM: dts: imx6qdl-nitrogen6x: Add SPI NOR partitions

2017-11-28 Thread Fabio Estevam
On Tue, Nov 28, 2017 at 3:49 PM, Otavio Salvador wrote: > This adds the partitions definition for the SPI NOR to provide > backward compatibility with the documented[1] layout used with > Boundary Devices BSP. > > 1. https://boundarydevices.com/boot-flash-access-linux/ > > It exports to Linux: > >

Re: [PATCH 15/24] x86/mm: Allow flushing for future ASID switches

2017-11-28 Thread Dave Hansen
Thanks for looking at this, Peter. I've been resisting doing this for a bit and it's an embarrassingly small amount of code. On 11/28/2017 08:39 AM, Peter Zijlstra wrote: > @@ -220,7 +221,21 @@ For 32-bit we have the following conventions - kernel is > built with > .macro SWITCH_TO_USER_CR3 scr

[PATCH] scsi: wd719x: make card_types static const, shrinks object size

2017-11-28 Thread Colin King
From: Colin Ian King Don't populate the read-only array card_types on the stack but instead make it static and constify it. Makes the object code smaller by over 110 bytes: Before: textdata bss dec hex filename 256255752 0 313777a91 drivers/scsi/wd719x.o Aft

Re: [PATCH 0/5] add printk specifier %px, unique identifier

2017-11-28 Thread Linus Torvalds
On Tue, Nov 28, 2017 at 10:04 AM, Linus Torvalds wrote: > > If we really get failures, we can do that. Anyway, it's pushed out now so people can test whatever workflows they have. As mentioned, I doubt anybody cares. That file is already conditional on CONFIG_STACKTRACE, and while that may be so

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Thomas Gleixner
On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > Quoting Thomas Gleixner : > > > On Mon, 27 Nov 2017, Gustavo A. R. Silva wrote: > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > case 0: > > >

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread SF Markus Elfring
>> Additional improvement possibilities can be taken into account >> after corresponding software development discussions, can't they? > > Sure, but that is in contrary to all you replies. Where do you see a contradiction in this case? > I guess you are familiar with Documentation/process/submi

Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state

2017-11-28 Thread Michel Dänzer
On 2017-11-28 05:57 PM, Darren Hart wrote: > On Tue, Nov 28, 2017 at 04:17:58PM +0100, Michel Dänzer wrote: >> We were always checking bit 0 (which represents the docked state) >> regardless of the mask. >> >> Fixes the "tablet mode" state always being reported the same as the >> docked state, whic

Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs

2017-11-28 Thread Gustavo A. R. Silva
Quoting Thomas Gleixner : On Mon, 27 Nov 2017, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. case 0: if (!n--) break; *args++ = regs->bx

Re: [PATCH 0/5] add printk specifier %px, unique identifier

2017-11-28 Thread Linus Torvalds
On Tue, Nov 28, 2017 at 9:41 AM, Joe Perches wrote: > > Perhaps if there are really tools that parse this > the [] should be kept the same too. If we really get failures, we can do that. But since the width is already different on 32-bit and 64-bit, I seriously doubt there are any tools that wou

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

2017-11-28 Thread Greg KH
On Tue, Nov 28, 2017 at 05:37:53PM +, Mark Brown wrote: > On Tue, Nov 28, 2017 at 06:28:38PM +0100, Greg KH wrote: > > On Tue, Nov 28, 2017 at 05:12:23PM +, Mark Brown wrote: > > > > I think it's reasonable to ask for userspace, I'm querying why it needs > > > to specifically be Android. >

Re: perf test LLVM & clang 6 failing

2017-11-28 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 28, 2017 at 02:55:53PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Nov 27, 2017 at 01:45:21PM -0800, Matthias Kaehlcke escreveu: > > El Mon, Nov 27, 2017 at 01:57:56PM -0600 Josh Poimboeuf ha dit: > > > On Mon, Nov 27, 2017 at 04:34:25PM -0300, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH 1/1] kasan: fix livelock in qlist_move_cache

2017-11-28 Thread Dmitry Vyukov
On Tue, Nov 28, 2017 at 6:56 PM, Dmitry Vyukov wrote: > On Tue, Nov 28, 2017 at 12:30 PM, Zhouyi Zhou wrote: >> Hi, >>By using perf top, qlist_move_cache occupies 100% cpu did really >> happen in my environment yesterday, or I >> won't notice the kasan code. >>Currently I have difficulty

Re: [PATCH 1/1] kasan: fix livelock in qlist_move_cache

2017-11-28 Thread Dmitry Vyukov
On Tue, Nov 28, 2017 at 12:30 PM, Zhouyi Zhou wrote: > Hi, >By using perf top, qlist_move_cache occupies 100% cpu did really > happen in my environment yesterday, or I > won't notice the kasan code. >Currently I have difficulty to let it reappear because the frontend > guy modified some us

Re: perf test LLVM & clang 6 failing

2017-11-28 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 27, 2017 at 01:45:21PM -0800, Matthias Kaehlcke escreveu: > El Mon, Nov 27, 2017 at 01:57:56PM -0600 Josh Poimboeuf ha dit: > > > On Mon, Nov 27, 2017 at 04:34:25PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Nov 27, 2017 at 11:11:56AM -0800, Yonghong Song escreveu: > > > > On

Re: [PATCH] IB/core: Use PTR_ERR_OR_ZERO()

2017-11-28 Thread Leon Romanovsky
On Tue, Nov 28, 2017 at 04:18:07PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/infiniband/core/uverbs_cmd.c:1156:1-3: WARNING: PTR_ERR_OR_ZERO can > be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.coc

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 12:17:16PM -0500, w...@redhat.com wrote: > From: Wei Xu > > Matthew found a roughly 40% tcp throughput regression with commit > c67df11f(vhost_net: try batch dequing from skb array) as discussed > in the following thread: > https://www.mail-archive.com/netdev@vger.kernel.o

<    1   2   3   4   5   6   7   8   9   10   >