Re: PI futexes + lock stealing woes

On Wed, Nov 29, 2017 at 11:56:05AM -0600, Julia Cartwright wrote: > Hey Thomas, Peter- > > Gratian and I have been debugging into a nasty and difficult race w/ > futexes seemingly the culprit. The original symptom we were seeing > was a seemingly spurious -EDEADLK from a futex(LOCK_PI)

Re: PI futexes + lock stealing woes

On Wed, Nov 29, 2017 at 11:56:05AM -0600, Julia Cartwright wrote: > Hey Thomas, Peter- > > Gratian and I have been debugging into a nasty and difficult race w/ > futexes seemingly the culprit. The original symptom we were seeing > was a seemingly spurious -EDEADLK from a futex(LOCK_PI)

Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb

On Thu, Nov 30, 2017 at 6:14 PM, wrote: > From: Tyler Baker > > Build the imx7d-sbc-iot-imx7 device tree blob. > > Signed-off-by: Tyler Baker > --- > arch/arm/boot/dts/Makefile | 1 + > 1 file

[PATCH tip/core/rcu 13/20] rcutorture: Simplify functions.sh include path

From: SeongJae Park Inclusions of 'functions.sh' from 'kvm-test-1-run.sh' and 'kvm-recheck*.sh' use its absolute path. Because the directory containing 'functions.sh' is already in PATH, the full path is unnecessary. This commit therefore simplifies the inclusions to use

Re: [PATCH 2/8] ARM: dts: imx7: build imx7d-sbc-iot-imx7 dtb

On Thu, Nov 30, 2017 at 6:14 PM, wrote: > From: Tyler Baker > > Build the imx7d-sbc-iot-imx7 device tree blob. > > Signed-off-by: Tyler Baker > --- > arch/arm/boot/dts/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >

[PATCH tip/core/rcu 13/20] rcutorture: Simplify functions.sh include path

From: SeongJae Park Inclusions of 'functions.sh' from 'kvm-test-1-run.sh' and 'kvm-recheck*.sh' use its absolute path. Because the directory containing 'functions.sh' is already in PATH, the full path is unnecessary. This commit therefore simplifies the inclusions to use the short relative

[PATCH tip/core/rcu 08/20] rcutorture/kvm.sh: Remove unused variable, `alldone`

From: SeongJae Park The variable `alldone` is defined but not used within an awk script. This commit therefore removes it. Fixes:53954671033d ("rcutorture: Do better bin packing") Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 08/20] rcutorture/kvm.sh: Remove unused variable, `alldone`

From: SeongJae Park The variable `alldone` is defined but not used within an awk script. This commit therefore removes it. Fixes:53954671033d ("rcutorture: Do better bin packing") Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- tools/testing/selftests/rcutorture/bin/kvm.sh

[PATCH tip/core/rcu 06/20] rcutorture/configinit: Fix build directory error message

From: SeongJae Park The 'configinit.sh' script checks the format of optional argument for the build directory, printing an error message if the format is not valid. However, the error message uses the wrong variable, indicating an empty string even though the user entered a

[PATCH tip/core/rcu 04/20] torture: Reduce #ifdefs for preempt_schedule()

This commit adds a torture_preempt_schedule() that is nothingness in !PREEMPT builds and is preempt_schedule() otherwise. Then torture_preempt_schedule() is used to eliminate several ugly #ifdefs, both in rcutorture and in locktorture. Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 06/20] rcutorture/configinit: Fix build directory error message

From: SeongJae Park The 'configinit.sh' script checks the format of optional argument for the build directory, printing an error message if the format is not valid. However, the error message uses the wrong variable, indicating an empty string even though the user entered a non-empty (but

[PATCH tip/core/rcu 04/20] torture: Reduce #ifdefs for preempt_schedule()

This commit adds a torture_preempt_schedule() that is nothingness in !PREEMPT builds and is preempt_schedule() otherwise. Then torture_preempt_schedule() is used to eliminate several ugly #ifdefs, both in rcutorture and in locktorture. Signed-off-by: Paul E. McKenney ---

Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts

On Thu, Nov 30, 2017 at 6:14 PM, wrote: > + { > + fsl,spi-num-chipselects = <1>; Please remove this property. It is no longer used. > + dvicape@39 { > + compatible = "sil164_simple"; This compatible string does not exist. > + { > +

Re: [PATCH 1/8] ARM: dts: imx7d-sbc-iot: add initial iot gateway dts

On Thu, Nov 30, 2017 at 6:14 PM, wrote: > + { > + fsl,spi-num-chipselects = <1>; Please remove this property. It is no longer used. > + dvicape@39 { > + compatible = "sil164_simple"; This compatible string does not exist. > + { > + pinctrl-names =

[PATCH tip/core/rcu 15/20] torture: Place all torture-test modules in one MAINTAINERS group

There is some confusion about where patches to kernel/torture.c and kernel/locking/locktorture.c should be sent. This commit therefore updates MAINTAINERS appropriately. Reported-by: Peter Zijlstra Signed-off-by: Paul E. McKenney Acked-by:

[PATCH tip/core/rcu 15/20] torture: Place all torture-test modules in one MAINTAINERS group

There is some confusion about where patches to kernel/torture.c and kernel/locking/locktorture.c should be sent. This commit therefore updates MAINTAINERS appropriately. Reported-by: Peter Zijlstra Signed-off-by: Paul E. McKenney Acked-by: Peter Zijlstra (Intel) --- MAINTAINERS | 22

[PATCH] Kconfig: Make STRICT_DEVMEM default-y on x86 and arm64

Distros have been shipping with CONFIG_STRICT_DEVMEM=y for years now. It is probably time to flip this default for x86 and arm64. Signed-off-by: Kees Cook --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig.debug

[PATCH] Kconfig: Make STRICT_DEVMEM default-y on x86 and arm64

Distros have been shipping with CONFIG_STRICT_DEVMEM=y for years now. It is probably time to flip this default for x86 and arm64. Signed-off-by: Kees Cook --- lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index

[PATCH tip/core/rcu 11/20] rcutorture/kvm-recheck-*: Improve result directory readability check

From: SeongJae Park The kvm-recheck-(lock|rcu|rcuperf).sh scripts check whether the user-specified results directory exists. If not, it prints out error message that says the specified directory is unreadable. To make the message more precise, this commit adds a

[PATCH tip/core/rcu 09/20] rcutorture/kvm.sh: Use consistent help text for --qemu-args

From: SeongJae Park The '--qemu-args' option's help text is wrongly copied from '--qemu-cmd' option and its argument type description message format is inconsistent with other arguments. This commit fixes the usage and type messages to be consistent with others. Fixes:

[PATCH tip/core/rcu 11/20] rcutorture/kvm-recheck-*: Improve result directory readability check

From: SeongJae Park The kvm-recheck-(lock|rcu|rcuperf).sh scripts check whether the user-specified results directory exists. If not, it prints out error message that says the specified directory is unreadable. To make the message more precise, this commit adds a readability check. Fixes:

[PATCH tip/core/rcu 09/20] rcutorture/kvm.sh: Use consistent help text for --qemu-args

From: SeongJae Park The '--qemu-args' option's help text is wrongly copied from '--qemu-cmd' option and its argument type description message format is inconsistent with other arguments. This commit fixes the usage and type messages to be consistent with others. Fixes: e9ce640001c6

[PATCH tip/core/rcu 19/20] torture: Eliminate torture_runnable and perf_runnable

The purpose of torture_runnable is to allow rcutorture and locktorture to be started and stopped via sysfs when they are built into the kernel (as in not compiled as loadable modules). However, the 0444 permissions for both instances of torture_runnable prevent this use case from ever being put

[PATCH tip/core/rcu 19/20] torture: Eliminate torture_runnable and perf_runnable

The purpose of torture_runnable is to allow rcutorture and locktorture to be started and stopped via sysfs when they are built into the kernel (as in not compiled as loadable modules). However, the 0444 permissions for both instances of torture_runnable prevent this use case from ever being put

[PATCH tip/core/rcu 12/20] rcutorture: Simplify logging

From: SeongJae Park Both the 'kvm.sh' and 'kvm-test-1-run.sh' scripts log messages by printing the message to 'stdout' and then also printing it into the log file. Generation of the message thus occurs twice, once for 'stdout' and once for the log file. Moreover, many of

[PATCH tip/core/rcu 12/20] rcutorture: Simplify logging

From: SeongJae Park Both the 'kvm.sh' and 'kvm-test-1-run.sh' scripts log messages by printing the message to 'stdout' and then also printing it into the log file. Generation of the message thus occurs twice, once for 'stdout' and once for the log file. Moreover, many of the messages contain

[PATCH tip/core/rcu 0/20] Torture-test updates for v4.16

Hello! This series contains torture-test updates: 1. Suppress CPU stall warnings during shutdown ftrace dump. 2. Prepare scripting for shift from %p to %pK because NULL-pointers printout changes. 3. Change printk() %p to %pK. 4. Reduce #ifdefs for

[PATCH tip/core/rcu 0/20] Torture-test updates for v4.16

Hello! This series contains torture-test updates: 1. Suppress CPU stall warnings during shutdown ftrace dump. 2. Prepare scripting for shift from %p to %pK because NULL-pointers printout changes. 3. Change printk() %p to %pK. 4. Reduce #ifdefs for

Re: [PATCH v2 6/8] drm/i915: Add function to output Aksv over GMBUS

On Fri, Dec 01, 2017 at 02:17:19PM -0500, Sean Paul wrote: > On Fri, Dec 1, 2017 at 2:06 PM, Ville Syrjälä > wrote: > > On Fri, Dec 01, 2017 at 12:20:28PM -0500, Sean Paul wrote: > >> Once the Aksv is available in the PCH, we need to get it on the wire to > >> the

Re: [PATCH v2 6/8] drm/i915: Add function to output Aksv over GMBUS

On Fri, Dec 01, 2017 at 02:17:19PM -0500, Sean Paul wrote: > On Fri, Dec 1, 2017 at 2:06 PM, Ville Syrjälä > wrote: > > On Fri, Dec 01, 2017 at 12:20:28PM -0500, Sean Paul wrote: > >> Once the Aksv is available in the PCH, we need to get it on the wire to > >> the receiver via DDC. The hardware

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +//

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

On 12/01/2017 11:49 AM, Philippe Ombredanne wrote: David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +

Re: [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver

Checked against 3bf98755f9c670c5c10ca05cba22848d65117cb2 (CHROMIUM: iio: accel: Add cros_ec_accel_legacy driver) Fixup f2b141a242e59017dbc774dc916748670a41da0b (FIXUP: CHROMIUM: iio: accel: Add cros_ec_accel_legacy driver) is required for devices with secondary Embedded Controllers. Gwendal. On

Re: [PATCH v5 3/3] platform/chrome: Register cros_ec_accel_legacy driver

Checked against 3bf98755f9c670c5c10ca05cba22848d65117cb2 (CHROMIUM: iio: accel: Add cros_ec_accel_legacy driver) Fixup f2b141a242e59017dbc774dc916748670a41da0b (FIXUP: CHROMIUM: iio: accel: Add cros_ec_accel_legacy driver) is required for devices with secondary Embedded Controllers. Gwendal. On

RE: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

> -Original Message- > From: Geert Uytterhoeven [mailto:ge...@linux-m68k.org] > Sent: Wednesday, November 29, 2017 2:48 AM > To: Nikolova, Tatyana E ; Roland Dreier > ; Jason Gunthorpe ; Doug > Ledford

RE: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

> -Original Message- > From: Geert Uytterhoeven [mailto:ge...@linux-m68k.org] > Sent: Wednesday, November 29, 2017 2:48 AM > To: Nikolova, Tatyana E ; Roland Dreier > ; Jason Gunthorpe ; Doug > Ledford > Cc: Arnd Bergmann ; linux-r...@vger.kernel.org; linux- > ker...@vger.kernel.org;

[PATCH tip/core/rcu 18/21] genetlink: Remove smp_read_barrier_depends() from comment

Now that smp_read_barrier_depends() has been de-emphasized, the less said about it, the better. Signed-off-by: Paul E. McKenney Cc: Thomas Gleixner Cc: Mark Rutland Cc: Kate Stewart Cc: Ingo

[PATCH tip/core/rcu 08/21] seqlock: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), so this patch removes the now-redundant smp_read_barrier_depends() from raw_read_seqcount_latch(). Signed-off-by: Paul E. McKenney Cc: Peter Zijlstra Cc: Ingo Molnar ---

[PATCH tip/core/rcu 18/21] genetlink: Remove smp_read_barrier_depends() from comment

Now that smp_read_barrier_depends() has been de-emphasized, the less said about it, the better. Signed-off-by: Paul E. McKenney Cc: Thomas Gleixner Cc: Mark Rutland Cc: Kate Stewart Cc: Ingo Molnar Cc: Philippe Ombredanne Cc: Greg Kroah-Hartman --- include/linux/genetlink.h | 3 +-- 1

[PATCH tip/core/rcu 08/21] seqlock: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), so this patch removes the now-redundant smp_read_barrier_depends() from raw_read_seqcount_latch(). Signed-off-by: Paul E. McKenney Cc: Peter Zijlstra Cc: Ingo Molnar --- include/linux/seqlock.h | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH tip/core/rcu 12/21] lib/assoc_array: Remove smp_read_barrier_depends()

Now that smp_read_barrier_depends() is implied by READ_ONCE(), the several smp_read_barrier_depends() calls may be removed from lib/assoc_array.c. This commit makes this change and marks the READ_ONCE() calls that head address dependencies. Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 12/21] lib/assoc_array: Remove smp_read_barrier_depends()

Now that smp_read_barrier_depends() is implied by READ_ONCE(), the several smp_read_barrier_depends() calls may be removed from lib/assoc_array.c. This commit makes this change and marks the READ_ONCE() calls that head address dependencies. Signed-off-by: Paul E. McKenney Cc: Jonathan Corbet

[PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

Now that both smp_read_barrier_depends() and read_barrier_depends() are being de-emphasized, warn if any are added. Signed-off-by: Paul E. McKenney Cc: Andy Whitcroft Cc: Joe Perches --- scripts/checkpatch.pl | 6 ++ 1 file

[PATCH tip/core/rcu 19/21] netlink: Remove smp_read_barrier_depends() from comment

Now that smp_read_barrier_depends() has been de-emphasized, the less said about it, the better. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc:

[PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

Now that both smp_read_barrier_depends() and read_barrier_depends() are being de-emphasized, warn if any are added. Signed-off-by: Paul E. McKenney Cc: Andy Whitcroft Cc: Joe Perches --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl

[PATCH tip/core/rcu 19/21] netlink: Remove smp_read_barrier_depends() from comment

Now that smp_read_barrier_depends() has been de-emphasized, the less said about it, the better. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Florian Westphal Cc: Cc: --- include/linux/netfilter/nfnetlink.h | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH tip/core/rcu 17/21] doc: De-emphasize smp_read_barrier_depends

This commit keeps only the historical and low-level discussion of smp_read_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/RCU/Design/Requirements/Requirements.html | 3 ++- Documentation/RCU/rcu_dereference.txt | 6 +-

[PATCH tip/core/rcu 17/21] doc: De-emphasize smp_read_barrier_depends

This commit keeps only the historical and low-level discussion of smp_read_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/RCU/Design/Requirements/Requirements.html | 3 ++- Documentation/RCU/rcu_dereference.txt | 6 +- Documentation/RCU/whatisRCU.txt

[PATCH tip/core/rcu 15/21] keyring: Remove now-redundant smp_read_barrier_depends()

Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney Cc: David Howells

[PATCH tip/core/rcu 15/21] keyring: Remove now-redundant smp_read_barrier_depends()

Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney Cc: David Howells Cc: James Morris Cc: "Serge E. Hallyn"

[PATCH tip/core/rcu 04/21] fs/dcache: Use release-acquire for name/length update

The code in __d_alloc() carefully orders filling in the NUL character of the name (and the length, hash, and the name itself) with assigning of the name itself. However, prepend_name() does not order the accesses to the ->name and ->len fields, other than on TSO systems. This commit therefore

[PATCH tip/core/rcu 04/21] fs/dcache: Use release-acquire for name/length update

The code in __d_alloc() carefully orders filling in the NUL character of the name (and the length, hash, and the name itself) with assigning of the name itself. However, prepend_name() does not order the accesses to the ->name and ->len fields, other than on TSO systems. This commit therefore

[PATCH tip/core/rcu 09/21] uprobes: Remove now-redundant smp_read_barrier_depends()

Now that READ_ONCE() implies smp_read_barrier_depends(), the get_xol_area() and get_trampoline_vaddr() no longer need their smp_read_barrier_depends() calls, which this commit removes. While we are here, convert the corresponding smp_wmb() to an smp_store_release(). Signed-off-by: Paul E.

[PATCH tip/core/rcu 09/21] uprobes: Remove now-redundant smp_read_barrier_depends()

Now that READ_ONCE() implies smp_read_barrier_depends(), the get_xol_area() and get_trampoline_vaddr() no longer need their smp_read_barrier_depends() calls, which this commit removes. While we are here, convert the corresponding smp_wmb() to an smp_store_release(). Signed-off-by: Paul E.

[PATCH tip/core/rcu 13/21] mm/ksm: Remove now-redundant smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in get_ksm_page() is now redundant. This commit removes it and updates the comments. Signed-off-by: Paul E. McKenney Cc: Andrew Morton Cc: Andrea

[PATCH tip/core/rcu 13/21] mm/ksm: Remove now-redundant smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in get_ksm_page() is now redundant. This commit removes it and updates the comments. Signed-off-by: Paul E. McKenney Cc: Andrew Morton Cc: Andrea Arcangeli Cc: Minchan Kim Cc: Michal Hocko Cc: "Kirill

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

This is not required. Looking with dmidecode, Glimmer reports: ... BIOS Information Vendor: coreboot Version: Google_Glimmer.5216.198.19 ... Therefore, the first entry of cros_ec_lpc_dmi_table will match. Gwendal. On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

This is not required. Looking with dmidecode, Glimmer reports: ... BIOS Information Vendor: coreboot Version: Google_Glimmer.5216.198.19 ... Therefore, the first entry of cros_ec_lpc_dmi_table will match. Gwendal. On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande wrote: > This

[PATCH tip/core/rcu 16/21] drivers/infiniband: Remove now-redundant smp_read_barrier_depends()

The smp_read_barrier_depends() does nothing at all except on DEC Alpha, and no current DEC Alpha systems use Infiniband: lkml.kernel.org/r/20171023085921.jwbntptn6ictbnvj@tower This commit therefore makes Infiniband depend on !ALPHA and removes the now-ineffective invocations of

[PATCH tip/core/rcu 16/21] drivers/infiniband: Remove now-redundant smp_read_barrier_depends()

The smp_read_barrier_depends() does nothing at all except on DEC Alpha, and no current DEC Alpha systems use Infiniband: lkml.kernel.org/r/20171023085921.jwbntptn6ictbnvj@tower This commit therefore makes Infiniband depend on !ALPHA and removes the now-ineffective invocations of

[PATCH tip/core/rcu 14/21] netfilter: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso

[PATCH tip/core/rcu 14/21] netfilter: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc:

[PATCH tip/core/rcu 11/21] tracepoint: Remove smp_read_barrier_depends() from comment

The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), whose use should be quite restricted. This commit updates the comment to instead mention the smp_store_release() and rcu_dereference_sched() that the current code actually uses. Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

Because READ_ONCE() now implies read_barrier_depends(), the read_barrier_depends() in next_desc() is now redundant. This commit therefore removes it and the related comments. Signed-off-by: Paul E. McKenney Cc: "Michael S. Tsirkin" Cc: Jason Wang

[PATCH tip/core/rcu 11/21] tracepoint: Remove smp_read_barrier_depends() from comment

The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), whose use should be quite restricted. This commit updates the comment to instead mention the smp_store_release() and rcu_dereference_sched() that the current code actually uses. Signed-off-by: Paul E. McKenney Cc: Ingo

[PATCH tip/core/rcu 21/21] drivers/vhost: Remove now-redundant read_barrier_depends()

Because READ_ONCE() now implies read_barrier_depends(), the read_barrier_depends() in next_desc() is now redundant. This commit therefore removes it and the related comments. Signed-off-by: Paul E. McKenney Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Cc: Cc: --- drivers/vhost/vhost.c | 7

[PATCH tip/core/rcu 02/21] mn10300: READ_ONCE() now implies smp_read_barrier_depends()

Given that READ_ONCE() now implies smp_read_barrier_depends(), there is no need for the open-coded smp_read_barrier_depends() in mn10300_serial_receive_interrupt() and mn10300_serial_poll_get_char(). This commit therefore removes them, but replaces them with comments calling out that carrying

[PATCH tip/core/rcu 02/21] mn10300: READ_ONCE() now implies smp_read_barrier_depends()

Given that READ_ONCE() now implies smp_read_barrier_depends(), there is no need for the open-coded smp_read_barrier_depends() in mn10300_serial_receive_interrupt() and mn10300_serial_poll_get_char(). This commit therefore removes them, but replaces them with comments calling out that carrying

[PATCH tip/core/rcu 01/21] doc: READ_ONCE() now implies smp_barrier_depends()

This commit updates an example in memory-barriers.txt to account for the fact that READ_ONCE() now implies smp_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

[PATCH tip/core/rcu 01/21] doc: READ_ONCE() now implies smp_barrier_depends()

This commit updates an example in memory-barriers.txt to account for the fact that READ_ONCE() now implies smp_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH tip/core/rcu 10/21] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

Queued spinlocks are not used by DEC Alpha, and furthermore operations such as READ_ONCE() and release/relaxed RMW atomics are being changed to imply smp_read_barrier_depends(). This commit therefore removes the now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(), and

Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state

On Tue, Nov 28, 2017 at 9:41 PM, Michel Dänzer wrote: > On 2017-11-28 08:30 PM, Andy Shevchenko wrote: >> On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer wrote: >>> On 2017-11-28 05:57 PM, Darren Hart wrote: Merged in 4.15-rc1 >>> >>> AFAIK commits

[PATCH tip/core/rcu 10/21] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

Queued spinlocks are not used by DEC Alpha, and furthermore operations such as READ_ONCE() and release/relaxed RMW atomics are being changed to imply smp_read_barrier_depends(). This commit therefore removes the now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(), and

Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state

On Tue, Nov 28, 2017 at 9:41 PM, Michel Dänzer wrote: > On 2017-11-28 08:30 PM, Andy Shevchenko wrote: >> On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer wrote: >>> On 2017-11-28 05:57 PM, Darren Hart wrote: Merged in 4.15-rc1 >>> >>> AFAIK commits without >>> >>> Cc:

[PATCH tip/core/rcu 05/21] percpu: READ_ONCE() now implies smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), this commit removes the now-redundant smp_read_barrier_depends() following the READ_ONCE() in __ref_is_percpu(). Signed-off-by: Paul E. McKenney Acked-by: Tejun Heo Cc: Christoph Lameter

[PATCH tip/core/rcu 05/21] percpu: READ_ONCE() now implies smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), this commit removes the now-redundant smp_read_barrier_depends() following the READ_ONCE() in __ref_is_percpu(). Signed-off-by: Paul E. McKenney Acked-by: Tejun Heo Cc: Christoph Lameter --- include/linux/percpu-refcount.h | 6 +++---

[PATCH tip/core/rcu 06/21] rcu: Adjust read-side accessor comments for READ_ONCE()

Now that READ_ONCE() implies smp_read_barrier_depends(), the commit updates now-misleading comments to account for this change. Signed-off-by: Paul E. McKenney --- include/linux/rcupdate.h | 23 +++ 1 file changed, 11 insertions(+), 12

[PATCH tip/core/rcu 03/21] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the

[PATCH tip/core/rcu 06/21] rcu: Adjust read-side accessor comments for READ_ONCE()

Now that READ_ONCE() implies smp_read_barrier_depends(), the commit updates now-misleading comments to account for this change. Signed-off-by: Paul E. McKenney --- include/linux/rcupdate.h | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH tip/core/rcu 03/21] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the

[PATCH tip/core/rcu 0/21] De-emphasize {smp_,}read_barrier_depends

Hello! Now that READ_ONCE() includes smp_read_barrier_depends(), almost nothing else needs to, the exceptions being DEC Alpha architecture-specific code and of course READ_ONCE() itself. This series therefore removes smp_read_barrier_depends() and read_barrier_depends() from elsewhere, as they

[PATCH tip/core/rcu 0/21] De-emphasize {smp_,}read_barrier_depends

Hello! Now that READ_ONCE() includes smp_read_barrier_depends(), almost nothing else needs to, the exceptions being DEC Alpha architecture-specific code and of course READ_ONCE() itself. This series therefore removes smp_read_barrier_depends() and read_barrier_depends() from elsewhere, as they

[PATCH tip/core/rcu 07/21] rtnetlink: Update now-misleading smp_read_barrier_depends() comment

Now that READ_ONCE() implies smp_read_barrier_depends(), update the rtnl_dereference() header comment accordingly. Signed-off-by: Paul E. McKenney Cc: "David S. Miller" Cc: Vladislav Yasevich Cc: Mark Rutland

[PATCH tip/core/rcu 07/21] rtnetlink: Update now-misleading smp_read_barrier_depends() comment

Now that READ_ONCE() implies smp_read_barrier_depends(), update the rtnl_dereference() header comment accordingly. Signed-off-by: Paul E. McKenney Cc: "David S. Miller" Cc: Vladislav Yasevich Cc: Mark Rutland Cc: David Ahern Cc: Vlad Yasevich --- include/linux/rtnetlink.h | 3 +-- 1 file

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

Checked against 7412f0a0d90ee6ddbad4cde794f88f1489422f3a (CHROMIUM: platform/chrome: Support MKBP protocol over ACPI) Reviewed-by: Gwendal Grignou On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande wrote: > From: Enric Balletbo i Serra

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: > On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0 +/*

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

Checked against 7412f0a0d90ee6ddbad4cde794f88f1489422f3a (CHROMIUM: platform/chrome: Support MKBP protocol over ACPI) Reviewed-by: Gwendal Grignou On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande wrote: > From: Enric Balletbo i Serra > > Commit 12278dc7c572 ("platform/chrome: cros_ec_lpc: Add

Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

David, Greg, On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote: > On 11/30/2017 11:53 PM, Philippe Ombredanne wrote: [...] --- /dev/null +++ b/arch/mips/cavium-octeon/resource-mgr.c @@ -0,0 +1,371 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Resource manager for

Re: [PATCH 0/4] add support of pinctrl to MT7622 SoC

On Tue, Nov 28, 2017 at 4:49 AM, wrote: > From: Sean Wang > > The patchset adds support for pinctrl on MT7622 SoC. It would be good if the other Mediatek driver authors, Honzhou, Yingjoe, Biao and Maoguang could review this patch set. Yours,

Re: [PATCH 0/4] add support of pinctrl to MT7622 SoC

On Tue, Nov 28, 2017 at 4:49 AM, wrote: > From: Sean Wang > > The patchset adds support for pinctrl on MT7622 SoC. It would be good if the other Mediatek driver authors, Honzhou, Yingjoe, Biao and Maoguang could review this patch set. Yours, Linus Walleij

Re: [PATCH] bpf: Fix compile warnings when !CONFIG_BPF_SYSCALL

On Fri, 1 Dec 2017 12:06:05 -0700 Jason Gunthorpe wrote: > Such as: > > In file included from ./include/trace/events/xdp.h:10:0, > from ./include/linux/bpf_trace.h:6, > from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29: >

Re: [PATCH] bpf: Fix compile warnings when !CONFIG_BPF_SYSCALL

On Fri, 1 Dec 2017 12:06:05 -0700 Jason Gunthorpe wrote: > Such as: > > In file included from ./include/trace/events/xdp.h:10:0, > from ./include/linux/bpf_trace.h:6, > from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29: > ./include/trace/events/xdp.h:94:17:

[PATCH tip/core/rcu 4/6] tracing, rcu: Hide trace event rcu_nocb_wake when not used

From: "Steven Rostedt (VMware)" The trace event rcu_nocb_wake is only used when CONFIG_RCU_NOCB_CPU is defined. But the trace event is defined regardless. As defined trace events take up memory, it is a waste to have it defined when not used. Surround the trace event with an

[PATCH tip/core/rcu 4/6] tracing, rcu: Hide trace event rcu_nocb_wake when not used

From: "Steven Rostedt (VMware)" The trace event rcu_nocb_wake is only used when CONFIG_RCU_NOCB_CPU is defined. But the trace event is defined regardless. As defined trace events take up memory, it is a waste to have it defined when not used. Surround the trace event with an #ifdef to have it

[PATCH tip/core/rcu 3/6] rcu: Change printk() %p to %pK

This commit changes the %p printk() in rcutorture to %pK. This could be considered irrelevant, given that any user able to start rcutorture could inflict far heavier damage on the system, but it doesn't hurt to change it and doing so avoids script-generated noise. Reported-by: Tobin C. Harding

[PATCH tip/core/rcu 3/6] rcu: Change printk() %p to %pK

This commit changes the %p printk() in rcutorture to %pK. This could be considered irrelevant, given that any user able to start rcutorture could inflict far heavier damage on the system, but it doesn't hurt to change it and doing so avoids script-generated noise. Reported-by: Tobin C. Harding

[PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK

This commit changes the %p printk() in rcutorture to %pK. This could be considered irrelevant, given that any user able to start rcutorture could inflict far heavier damage on the system, but it doesn't hurt to change it and doing so avoids script-generated noise. Reported-by: Tobin C. Harding

[PATCH tip/core/rcu 5/6] rcu: Add comment giving debug strategy for double call_rcu()

The following statement has for some reason proven non-intuitive: WARN_ON_ONCE(rcu_segcblist_empty(>cblist) != (count == 0)); This commit therefore adds a comment that states that this warning usually triggers in response to a double call_rcu(), which is sort of like a double free. The

[PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK

This commit changes the %p printk() in rcutorture to %pK. This could be considered irrelevant, given that any user able to start rcutorture could inflict far heavier damage on the system, but it doesn't hurt to change it and doing so avoids script-generated noise. Reported-by: Tobin C. Harding

[PATCH tip/core/rcu 5/6] rcu: Add comment giving debug strategy for double call_rcu()

The following statement has for some reason proven non-intuitive: WARN_ON_ONCE(rcu_segcblist_empty(>cblist) != (count == 0)); This commit therefore adds a comment that states that this warning usually triggers in response to a double call_rcu(), which is sort of like a double free. The

<    1   2   3   4   5   6   7   8   9   10   >