Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Willy Tarreau wrote: > On Wed, Jan 10, 2018 at 08:31:28AM +0100, Ingo Molnar wrote: > > > > * Borislav Petkov wrote: > > > > > Oh, and you've built the kernel with the option to be able to disable > > > PTI so it's not like you haven't seen it already. > > > >

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Willy Tarreau wrote: > On Wed, Jan 10, 2018 at 08:31:28AM +0100, Ingo Molnar wrote: > > > > * Borislav Petkov wrote: > > > > > Oh, and you've built the kernel with the option to be able to disable > > > PTI so it's not like you haven't seen it already. > > > > In general in many corporate

Re: [patches] [PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

On Wed, Jan 10, 2018 at 08:43:54AM +0100, Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 03:38:09PM +0800, Alan Kao wrote: > > -LDFLAGS_vmlinux := > > +ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > > + LDFLAGS_vmlinux := --no-relax > > +else > > + LDFLAGS_vmlinux := > > +endif > > Why not: > >

Re: [patches] [PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

On Wed, Jan 10, 2018 at 08:43:54AM +0100, Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 03:38:09PM +0800, Alan Kao wrote: > > -LDFLAGS_vmlinux := > > +ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > > + LDFLAGS_vmlinux := --no-relax > > +else > > + LDFLAGS_vmlinux := > > +endif > > Why not: > >

Re: [PATCH v2 3/4] clk: Show symbolic clock flags in debugfs

Hi Stephen, On Wed, Jan 10, 2018 at 3:02 AM, Stephen Boyd wrote: > On 01/03, Geert Uytterhoeven wrote: >> Currently the virtual "clk_flags" file in debugfs shows the numeric >> value of the top-level framework flags for the specified clock. >> Hence the user must manually

Re: [PATCH v2 3/4] clk: Show symbolic clock flags in debugfs

Hi Stephen, On Wed, Jan 10, 2018 at 3:02 AM, Stephen Boyd wrote: > On 01/03, Geert Uytterhoeven wrote: >> Currently the virtual "clk_flags" file in debugfs shows the numeric >> value of the top-level framework flags for the specified clock. >> Hence the user must manually interpret these values.

[PATCH v2] f2fs: handle newly created page when revoking inmem pages

When committing inmem pages is successful, we revoke already committed blocks in __revoke_inmem_pages() and finally replace the committed ones with the old blocks using f2fs_replace_block(). However, if the committed block was newly created one, the address of the old block is NEW_ADDR and

[PATCH v2] f2fs: handle newly created page when revoking inmem pages

When committing inmem pages is successful, we revoke already committed blocks in __revoke_inmem_pages() and finally replace the committed ones with the old blocks using f2fs_replace_block(). However, if the committed block was newly created one, the address of the old block is NEW_ADDR and

Re: [RFC git branches] rseq and membarrier against v4.15-rc7

g). > > Those with time on their hands and interested to test those branches can fetch > them at: > > https://git.kernel.org/pub/scm/linux/kernel/git/rseq/linux-rseq.git/ > > tags: > v4.15-rc7-rseq-20180109 > v4.15-rc7-membarrier-20180109 > > Feedback is welco

Re: [RFC git branches] rseq and membarrier against v4.15-rc7

eir hands and interested to test those branches can fetch > them at: > > https://git.kernel.org/pub/scm/linux/kernel/git/rseq/linux-rseq.git/ > > tags: > v4.15-rc7-rseq-20180109 > v4.15-rc7-membarrier-20180109 > > Feedback is welcome, although I really hope those involved

Re: BUG: soft lockup (2)

On Fri, Jan 05, 2018 at 09:47:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > e1915c8195b38393005be9b74bfa6a3a367c83b3 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

Re: BUG: soft lockup (2)

On Fri, Jan 05, 2018 at 09:47:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > e1915c8195b38393005be9b74bfa6a3a367c83b3 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

Re: [patches] [PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

On Wed, Jan 10, 2018 at 03:38:09PM +0800, Alan Kao wrote: > -LDFLAGS_vmlinux := > +ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > + LDFLAGS_vmlinux := --no-relax > +else > + LDFLAGS_vmlinux := > +endif Why not: LDFLAGS_vmlinux := ifeq ($(CONFIG_DYNAMIC_FTRACE),y) LDFLAGS_vmlinux += --no-relax endif

Re: [patches] [PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

On Wed, Jan 10, 2018 at 03:38:09PM +0800, Alan Kao wrote: > -LDFLAGS_vmlinux := > +ifeq ($(CONFIG_DYNAMIC_FTRACE),y) > + LDFLAGS_vmlinux := --no-relax > +else > + LDFLAGS_vmlinux := > +endif Why not: LDFLAGS_vmlinux := ifeq ($(CONFIG_DYNAMIC_FTRACE),y) LDFLAGS_vmlinux += --no-relax endif

Re: [PATCH] Fix: membarrier: add missing preempt off around smp_call_function_many

* Mathieu Desnoyers wrote: > Hi Linus, > > Can you pick up this straightforward fix please ? Let me know whether > I need to re-send the patch if for some reason the original post is > too far back in your inbox. The fix looks much more reasonable than previous

Re: [PATCH] Fix: membarrier: add missing preempt off around smp_call_function_many

* Mathieu Desnoyers wrote: > Hi Linus, > > Can you pick up this straightforward fix please ? Let me know whether > I need to re-send the patch if for some reason the original post is > too far back in your inbox. The fix looks much more reasonable than previous attempts: I'll pick it up into

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

From: Shawn Lin Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin Reviewed-by: Brian Norris Signed-off-by: Caesar Wang --- Changes in v2: -

[PATCH v2 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy

From: Shawn Lin Just use the API instead of open-coding it, no functional change intended. Signed-off-by: Shawn Lin Reviewed-by: Brian Norris Signed-off-by: Caesar Wang --- Changes in v2: - As Brian commented on https://patchwork.kernel.org/patch/10139891/, changed the note and added to

Re: [PATCH][next] IB/mlx5: remove redundant assignment of mdev

On Tue, Jan 09, 2018 at 03:55:43PM +, Colin King wrote: > From: Colin Ian King > > The initial assignment to mdev is redundant as mdev is re-assigned > later and the first assigned value is never read. Remove this > redundant assignment. > > Cleans up clang warning:

Re: [PATCH 04/18] arm: implement nospec_ptr()

On 2018/1/10 10:04, Laura Abbott wrote: > On 01/05/2018 05:10 PM, Dan Williams wrote: >> From: Mark Rutland >> >> This patch implements nospec_ptr() for arm, following the recommended >> architectural sequences for the arm and thumb instruction sets. >> > Fedora picked up

Re: [PATCH][next] IB/mlx5: remove redundant assignment of mdev

On Tue, Jan 09, 2018 at 03:55:43PM +, Colin King wrote: > From: Colin Ian King > > The initial assignment to mdev is redundant as mdev is re-assigned > later and the first assigned value is never read. Remove this > redundant assignment. > > Cleans up clang warning: >

Re: [PATCH 04/18] arm: implement nospec_ptr()

On 2018/1/10 10:04, Laura Abbott wrote: > On 01/05/2018 05:10 PM, Dan Williams wrote: >> From: Mark Rutland >> >> This patch implements nospec_ptr() for arm, following the recommended >> architectural sequences for the arm and thumb instruction sets. >> > Fedora picked up the series and it fails

[PATCH 3/6] riscv/ftrace: Add dynamic function graph tracer support

Once the function_graph tracer is enabled, a filtered function has the following call sequence: * ftracer_caller ==> on/off by ftrace_make_call/ftrace_make_nop * ftrace_graph_caller * ftrace_graph_call ==> on/off by ftrace_en/disable_ftrace_graph_caller * prepare_ftrace_return

[PATCH 3/6] riscv/ftrace: Add dynamic function graph tracer support

Once the function_graph tracer is enabled, a filtered function has the following call sequence: * ftracer_caller ==> on/off by ftrace_make_call/ftrace_make_nop * ftrace_graph_caller * ftrace_graph_call ==> on/off by ftrace_en/disable_ftrace_graph_caller * prepare_ftrace_return

[PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

Now recordmcount.pl recognizes RISC-V object files. For the mechanism to work, we have to disable the linker relaxation. This is because relaxation happens after the script records offsets of _mcount call sites, resulting in a unreliable record. Cc: Greentime Hu

[PATCH 1/6] riscv/ftrace: Add RECORD_MCOUNT support

Now recordmcount.pl recognizes RISC-V object files. For the mechanism to work, we have to disable the linker relaxation. This is because relaxation happens after the script records offsets of _mcount call sites, resulting in a unreliable record. Cc: Greentime Hu Signed-off-by: Alan Kao ---

[PATCH 6/6] riscv/ftrace: Add HAVE_FUNCTION_GRAPH_RET_ADDR_PTR support

When doing unwinding in the function walk_stackframe, the pc now receives the address from calling ftrace_graph_ret_addr instead of manual calculation. Note that the original expression, pc = frame->ra - 4 is buggy if the instruction at the return address happened to be a compressed

[PATCH 6/6] riscv/ftrace: Add HAVE_FUNCTION_GRAPH_RET_ADDR_PTR support

When doing unwinding in the function walk_stackframe, the pc now receives the address from calling ftrace_graph_ret_addr instead of manual calculation. Note that the original expression, pc = frame->ra - 4 is buggy if the instruction at the return address happened to be a compressed

[PATCH 2/6] riscv/ftrace: Add dynamic function tracer support

We now have dynamic ftrace with the following added items: * ftrace_make_call, ftrace_make_nop (in kernel/ftrace.c) The two functions turns any recorded call site of filtered functions into a call to ftrace_caller or nops * ftracce_update_ftrace_func (in kernel/ftrace.c) turns the nops at

[PATCH 4/6] riscv/ftrace: Add ARCH_SUPPORTS_FTRACE_OPS support

Cc: Greentime Hu Signed-off-by: Alan Kao --- arch/riscv/include/asm/ftrace.h | 1 + arch/riscv/kernel/mcount-dyn.S | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h index

[PATCH 5/6] riscv/ftrace: Add DYNAMIC_FTRACE_WITH_REGS support

Cc: Greentime Hu Signed-off-by: Alan Kao --- arch/riscv/Kconfig | 1 + arch/riscv/kernel/ftrace.c | 17 ++ arch/riscv/kernel/mcount-dyn.S | 124 + 3 files changed, 142 insertions(+)

[PATCH 2/6] riscv/ftrace: Add dynamic function tracer support

We now have dynamic ftrace with the following added items: * ftrace_make_call, ftrace_make_nop (in kernel/ftrace.c) The two functions turns any recorded call site of filtered functions into a call to ftrace_caller or nops * ftracce_update_ftrace_func (in kernel/ftrace.c) turns the nops at

[PATCH 4/6] riscv/ftrace: Add ARCH_SUPPORTS_FTRACE_OPS support

Cc: Greentime Hu Signed-off-by: Alan Kao --- arch/riscv/include/asm/ftrace.h | 1 + arch/riscv/kernel/mcount-dyn.S | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h index acf0c7d001f3..429a6a156645 100644 ---

[PATCH 5/6] riscv/ftrace: Add DYNAMIC_FTRACE_WITH_REGS support

Cc: Greentime Hu Signed-off-by: Alan Kao --- arch/riscv/Kconfig | 1 + arch/riscv/kernel/ftrace.c | 17 ++ arch/riscv/kernel/mcount-dyn.S | 124 + 3 files changed, 142 insertions(+) diff --git a/arch/riscv/Kconfig

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

On Wed, Jan 10, 2018 at 08:31:28AM +0100, Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > Oh, and you've built the kernel with the option to be able to disable > > PTI so it's not like you haven't seen it already. > > In general in many corporate environments requiring

[PATCH 0/6] Add dynamic ftrace support for RISC-V platforms

This patch set includes the building blocks of dynamic ftraces features for RISC-V machines. Alan Kao (6): riscv/ftrace: Add RECORD_MCOUNT support riscv/ftrace: Add dynamic function tracer support riscv/ftrace: Add dynamic function graph tracer support riscv/ftrace: Add

[PATCH v2 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

Hi Kishon, Since the Shawn isn't available, I take over this series patches for now. As the original bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [ 2.375333] rockchip_emmc_phy_power: caldone

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

On Wed, Jan 10, 2018 at 08:31:28AM +0100, Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > Oh, and you've built the kernel with the option to be able to disable > > PTI so it's not like you haven't seen it already. > > In general in many corporate environments requiring kernel reboots or

[PATCH 0/6] Add dynamic ftrace support for RISC-V platforms

This patch set includes the building blocks of dynamic ftraces features for RISC-V machines. Alan Kao (6): riscv/ftrace: Add RECORD_MCOUNT support riscv/ftrace: Add dynamic function tracer support riscv/ftrace: Add dynamic function graph tracer support riscv/ftrace: Add

[PATCH v2 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs

Hi Kishon, Since the Shawn isn't available, I take over this series patches for now. As the original bug had tracked on https://issuetracker.google.com/71561742. In some cases, the mmc phy power on failed during booting up. The log as below: ... [ 2.375333] rockchip_emmc_phy_power: caldone

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

From: Shawn Lin It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu Signed-off-by: Caesar Wang ---

[PATCH v2 1/2] phy: rockchip-emmc: retry calpad busy trimming

From: Shawn Lin It turns out that 5us isn't enough for all cases, so let's retry some more times to wait for caldone. Signed-off-by: Shawn Lin Tested-by: Ziyuan Xu Signed-off-by: Caesar Wang --- Changes in v2: - print the return valut with regmap_read_poll_timeout failing.

Re: [PATCH 3/3] mmc: sdhci: fix o2 eMMC init bug and add support for hardware tuning

On 28/12/17 12:00, ernest.zhang wrote: > In some case of eMMC used as boot device, the eMMC signaling voltage is > fixed to 1.8v, bios can set o2 sd host controller register 0x308 bit4 to > let host controller skip try 3.3.v signaling voltage in eMMC initialize > process. > O2 sd host controller

Re: [PATCH 3/3] mmc: sdhci: fix o2 eMMC init bug and add support for hardware tuning

On 28/12/17 12:00, ernest.zhang wrote: > In some case of eMMC used as boot device, the eMMC signaling voltage is > fixed to 1.8v, bios can set o2 sd host controller register 0x308 bit4 to > let host controller skip try 3.3.v signaling voltage in eMMC initialize > process. > O2 sd host controller

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Borislav Petkov wrote: > Oh, and you've built the kernel with the option to be able to disable > PTI so it's not like you haven't seen it already. In general in many corporate environments requiring kernel reboots or kernel rebuilds limits the real-world usability of any

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Borislav Petkov wrote: > Oh, and you've built the kernel with the option to be able to disable > PTI so it's not like you haven't seen it already. In general in many corporate environments requiring kernel reboots or kernel rebuilds limits the real-world usability of any kernel feature we

[GIT PULL] sound fixes for 4.15-rc8

Linus, please pull sound fixes for v4.15-rc8 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-4.15-rc8 The topmost commit is 900498a34a3ac9c611e9b425094c8106bdd7dc1c sound fixes for 4.15-rc8 A

Re: [RFC PATCH v2 3/6] x86/pti: add a per-cpu variable pti_disable

On Wed, Jan 10, 2018 at 08:19:51AM +0100, Ingo Molnar wrote: > > * Willy Tarreau wrote: > > > +#ifdef CONFIG_PAGE_TABLE_ISOLATION > > + this_cpu_write(pti_disable, > > + next_p->mm && next_p->mm->context.pti_disable); > > +#endif > > Another pet peeve, please

[GIT PULL] sound fixes for 4.15-rc8

Linus, please pull sound fixes for v4.15-rc8 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-4.15-rc8 The topmost commit is 900498a34a3ac9c611e9b425094c8106bdd7dc1c sound fixes for 4.15-rc8 A

Re: [RFC PATCH v2 3/6] x86/pti: add a per-cpu variable pti_disable

On Wed, Jan 10, 2018 at 08:19:51AM +0100, Ingo Molnar wrote: > > * Willy Tarreau wrote: > > > +#ifdef CONFIG_PAGE_TABLE_ISOLATION > > + this_cpu_write(pti_disable, > > + next_p->mm && next_p->mm->context.pti_disable); > > +#endif > > Another pet peeve, please write: > > > +

Re: [PATCH 0/2] pinctrl: meson: use one uniform 'function' name

On Wed, 2018-01-10 at 10:12 +0800, Yixun Lan wrote: > > On 01/08/18 16:52, Jerome Brunet wrote: > > On Mon, 2018-01-08 at 15:33 +0800, Yixun Lan wrote: > > > These two patches are general improvement for meson pinctrl driver. > > > It make the two pinctrl trees (ee/ao) to share one uniform

Re: [PATCH 0/2] pinctrl: meson: use one uniform 'function' name

On Wed, 2018-01-10 at 10:12 +0800, Yixun Lan wrote: > > On 01/08/18 16:52, Jerome Brunet wrote: > > On Mon, 2018-01-08 at 15:33 +0800, Yixun Lan wrote: > > > These two patches are general improvement for meson pinctrl driver. > > > It make the two pinctrl trees (ee/ao) to share one uniform

Re: [PATCH] f2fs: handle newly created page when revoking inmem pages

Hi Chao, > Original intention here is to recover status to the timing before > committing atomic write. As at that timing blkaddr in dnode should be > cur->old_addr(NEW_ADDR), so we need to change to call:   > f2fs_update_data_blkaddr(, NEW_ADDR); Ok, I'll change NULL_ADDR to NEW_ADDR. Thanks,  

Re: [PATCH] f2fs: handle newly created page when revoking inmem pages

Hi Chao, > Original intention here is to recover status to the timing before > committing atomic write. As at that timing blkaddr in dnode should be > cur->old_addr(NEW_ADDR), so we need to change to call:   > f2fs_update_data_blkaddr(, NEW_ADDR); Ok, I'll change NULL_ADDR to NEW_ADDR. Thanks,  

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Borislav Petkov wrote: > On Tue, Jan 09, 2018 at 01:26:57PM -0800, Andy Lutomirski wrote: > > 2.Turning off PTI is, in general, a terrible idea. It totally breaks > > any semblance of a security model on a Meltdown-affected CPU. So I > > think we should require CAP_SYS_RAWIO

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Borislav Petkov wrote: > On Tue, Jan 09, 2018 at 01:26:57PM -0800, Andy Lutomirski wrote: > > 2.Turning off PTI is, in general, a terrible idea. It totally breaks > > any semblance of a security model on a Meltdown-affected CPU. So I > > think we should require CAP_SYS_RAWIO *and* that the

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

On Wed, Jan 10, 2018 at 08:15:10AM +0100, Ingo Molnar wrote: > > + /* The "pti_disable" mm attribute is mirrored into this per-cpu var */ > > + cmpb$0, PER_CPU_VAR(pti_disable) > > + jne .Lend_\@ > > Could you please do this small change for future iterations: > > s/per-cpu >

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

On Wed, Jan 10, 2018 at 08:15:10AM +0100, Ingo Molnar wrote: > > + /* The "pti_disable" mm attribute is mirrored into this per-cpu var */ > > + cmpb$0, PER_CPU_VAR(pti_disable) > > + jne .Lend_\@ > > Could you please do this small change for future iterations: > > s/per-cpu >

Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support

On Wed, 10 Jan 2018 14:45:07 +0900 Namhyung Kim wrote: > On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote: > > Hi, > > > > This is V8 of the inter-event tracing patchset, addressing input from > > V7. > > > > These changes address Namhyung's most recent comments

Re: [PATCH v8 00/37] tracing: Inter-event (e.g. latency) support

On Wed, 10 Jan 2018 14:45:07 +0900 Namhyung Kim wrote: > On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote: > > Hi, > > > > This is V8 of the inter-event tracing patchset, addressing input from > > V7. > > > > These changes address Namhyung's most recent comments (thanks, > >

Re: [RFC PATCH v2 3/6] x86/pti: add a per-cpu variable pti_disable

* Willy Tarreau wrote: > +#ifdef CONFIG_PAGE_TABLE_ISOLATION > + this_cpu_write(pti_disable, > +next_p->mm && next_p->mm->context.pti_disable); > +#endif Another pet peeve, please write: > + this_cpu_write(pti_disable, next_p->mm && >

Re: [RFC PATCH v2 3/6] x86/pti: add a per-cpu variable pti_disable

* Willy Tarreau wrote: > +#ifdef CONFIG_PAGE_TABLE_ISOLATION > + this_cpu_write(pti_disable, > +next_p->mm && next_p->mm->context.pti_disable); > +#endif Another pet peeve, please write: > + this_cpu_write(pti_disable, next_p->mm && >

Re: [RFC PATCH v2 5/6] x86/entry/pti: avoid setting CR3 when it's already correct

On Wed, Jan 10, 2018 at 08:16:24AM +0100, Ingo Molnar wrote: > > * Willy Tarreau wrote: > > > + /* if we're already on the kernel PGD, we don't switch */ > > +* If we're already on the kernel PGD, we don't switch, > > +* If we saved a kernel context on entry, we didn't

Re: [RFC][PATCHv6 00/12] printk: introduce printing kernel thread

On Tue, 9 Jan 2018 14:53:56 -0800 Tejun Heo wrote: > Hello, Steven. > > On Tue, Jan 09, 2018 at 05:47:50PM -0500, Steven Rostedt wrote: > > > Maybe it can break out eventually but that can take a really long > > > time. It's OOM. Most of userland is waiting for reclaim.

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-06 7:21 GMT+09:00 Marc Herbert : > On 04/01/2018 09:21, Masahiro Yamada wrote: >> (+CC Michal's new address) >> >> 2017-12-19 10:26 GMT+09:00 Marc Herbert : >>> As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 >>>

Re: [RFC PATCH v2 5/6] x86/entry/pti: avoid setting CR3 when it's already correct

On Wed, Jan 10, 2018 at 08:16:24AM +0100, Ingo Molnar wrote: > > * Willy Tarreau wrote: > > > + /* if we're already on the kernel PGD, we don't switch */ > > +* If we're already on the kernel PGD, we don't switch, > > +* If we saved a kernel context on entry, we didn't switch the CR3,

Re: [RFC][PATCHv6 00/12] printk: introduce printing kernel thread

On Tue, 9 Jan 2018 14:53:56 -0800 Tejun Heo wrote: > Hello, Steven. > > On Tue, Jan 09, 2018 at 05:47:50PM -0500, Steven Rostedt wrote: > > > Maybe it can break out eventually but that can take a really long > > > time. It's OOM. Most of userland is waiting for reclaim. There > > > isn't all

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-06 7:21 GMT+09:00 Marc Herbert : > On 04/01/2018 09:21, Masahiro Yamada wrote: >> (+CC Michal's new address) >> >> 2017-12-19 10:26 GMT+09:00 Marc Herbert : >>> As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 >>> silentoldconfig has become a misnomer. It has become an

Re: [RFC PATCH v2 5/6] x86/entry/pti: avoid setting CR3 when it's already correct

* Willy Tarreau wrote: > + /* if we're already on the kernel PGD, we don't switch */ > + * If we're already on the kernel PGD, we don't switch, > + * If we saved a kernel context on entry, we didn't switch the CR3, It's hard enough to read assembly code, please use

Re: [RFC PATCH v2 5/6] x86/entry/pti: avoid setting CR3 when it's already correct

* Willy Tarreau wrote: > + /* if we're already on the kernel PGD, we don't switch */ > + * If we're already on the kernel PGD, we don't switch, > + * If we saved a kernel context on entry, we didn't switch the CR3, It's hard enough to read assembly code, please use consistent

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

* Willy Tarreau wrote: > When a syscall returns to userspace with pti_disable set, it means the > current mm is configured to disable page table isolation (PTI). In this > case, returns from kernel to user will not switch the CR3, leaving it > to the kernel one which already maps

Re: [RFC PATCH v2 6/6] x86/entry/pti: don't switch PGD on when pti_disable is set

* Willy Tarreau wrote: > When a syscall returns to userspace with pti_disable set, it means the > current mm is configured to disable page table isolation (PTI). In this > case, returns from kernel to user will not switch the CR3, leaving it > to the kernel one which already maps both user and

Re: [PATCH] x86/retpoline: Fix NOSPEC_JMP for tip

On Tue, 2018-01-09 at 16:39 -0800, Linus Torvalds wrote: > On Tue, Jan 9, 2018 at 4:31 PM, Andi Kleen > wrote: > > > > > > The following patch fixes it for me. Something doesn't > > seem to work with ALTERNATIVE_2. It adds only a few bytes > > more code, so seems

Re: [PATCH] x86/retpoline: Fix NOSPEC_JMP for tip

On Tue, 2018-01-09 at 16:39 -0800, Linus Torvalds wrote: > On Tue, Jan 9, 2018 at 4:31 PM, Andi Kleen > wrote: > > > > > > The following patch fixes it for me. Something doesn't > > seem to work with ALTERNATIVE_2. It adds only a few bytes > > more code, so seems acceptable. > Ugh. It's kind of

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Andy Lutomirski wrote: > On Tue, Jan 9, 2018 at 6:54 AM, Willy Tarreau wrote: > > On Tue, Jan 09, 2018 at 03:51:57PM +0100, Borislav Petkov wrote: > >> On Tue, Jan 09, 2018 at 03:36:53PM +0100, Willy Tarreau wrote: > >> > I see and am not particularly against

Re: [patch v7 3/3] platform/mellanox: mlxreg-hotplug: modify to use regmap intreface

Hi Vadim, I love your patch! Yet something to improve: [auto build test ERROR on platform-drivers-x86/for-next] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [RFC PATCH v2 2/6] x86/arch_prctl: add ARCH_GET_NOPTI and ARCH_SET_NOPTI to enable/disable PTI

* Andy Lutomirski wrote: > On Tue, Jan 9, 2018 at 6:54 AM, Willy Tarreau wrote: > > On Tue, Jan 09, 2018 at 03:51:57PM +0100, Borislav Petkov wrote: > >> On Tue, Jan 09, 2018 at 03:36:53PM +0100, Willy Tarreau wrote: > >> > I see and am not particularly against this, but what use case do you >

Re: [patch v7 3/3] platform/mellanox: mlxreg-hotplug: modify to use regmap intreface

Hi Vadim, I love your patch! Yet something to improve: [auto build test ERROR on platform-drivers-x86/for-next] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v1 6/8] perf util: Allocate time slices buffer according to number of comma

Previously we use a magic number 10 to limit the number of time slices. It's not very good. This patch creates a new function perf_time__range_alloc() to allocate time slices buffer. The number of buffer entries is determined by the number of comma in string but at least it will allocate one

[PATCH v1 6/8] perf util: Allocate time slices buffer according to number of comma

Previously we use a magic number 10 to limit the number of time slices. It's not very good. This patch creates a new function perf_time__range_alloc() to allocate time slices buffer. The number of buffer entries is determined by the number of comma in string but at least it will allocate one

[PATCH v1 4/8] perf util: Support no index time percent slice

Previously, the time percent slice needs an index to specify which one the user wants. While it may be easy for using if the index can be omitted. So with this patch, for example, perf report --stdio --time 10%/1 should be equivalent to perf report --stdio --time 10% Signed-off-by: Jin Yao

[PATCH v1 2/8] perf script: Improve error msg when no first/last sample time found

The following message will be returned to user when executing 'perf script --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to

[PATCH v1 4/8] perf util: Support no index time percent slice

Previously, the time percent slice needs an index to specify which one the user wants. While it may be easy for using if the index can be omitted. So with this patch, for example, perf report --stdio --time 10%/1 should be equivalent to perf report --stdio --time 10% Signed-off-by: Jin Yao ---

[PATCH v1 2/8] perf script: Improve error msg when no first/last sample time found

The following message will be returned to user when executing 'perf script --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to

[PATCH v1 8/8] perf script: Remove the time slices number limitation

Previously it was only allowed to use at most 10 time slices in 'perf script --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf script --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-off-by: Jin Yao

[PATCH v1 8/8] perf script: Remove the time slices number limitation

Previously it was only allowed to use at most 10 time slices in 'perf script --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf script --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-off-by: Jin Yao ---

[PATCH v1 7/8] perf report: Remove the time slices number limitation

Previously it was only allowed to use at most 10 time slices in 'perf report --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf report --stdio --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-off-by: Jin Yao

[PATCH v1 3/8] perf util: Improve error checking for time percent input

The command line like 'perf report --stdio --time 1abc%/1' could be accepted by perf. It looks not very good. This patch uses strtod() to replace original atof() and check the entire string. Now for the same command line, it would return error message "Invalid time string". root@skl:/tmp# perf

[PATCH v1 7/8] perf report: Remove the time slices number limitation

Previously it was only allowed to use at most 10 time slices in 'perf report --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf report --stdio --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-off-by: Jin Yao

[PATCH v1 3/8] perf util: Improve error checking for time percent input

The command line like 'perf report --stdio --time 1abc%/1' could be accepted by perf. It looks not very good. This patch uses strtod() to replace original atof() and check the entire string. Now for the same command line, it would return error message "Invalid time string". root@skl:/tmp# perf

[PATCH v1 5/8] perf report: Add an indication of what time slices are used

Add a time slices indication to the perf report header. For example, # perf report --stdio --time 10% # Total Lost Samples: 0 # # Samples: 9K of event 'cycles:ppp' (time slices: 10%) # Event count (approx.): 8951288803 Signed-off-by: Jin Yao ---

[PATCH v1 5/8] perf report: Add an indication of what time slices are used

Add a time slices indication to the perf report header. For example, # perf report --stdio --time 10% # Total Lost Samples: 0 # # Samples: 9K of event 'cycles:ppp' (time slices: 10%) # Event count (approx.): 8951288803 Signed-off-by: Jin Yao --- tools/perf/builtin-report.c | 3 +++

[PATCH v1 1/8] perf report: Improve error msg when no first/last sample time found

The following message will be returned to user when executing 'perf report --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to

[PATCH v1 1/8] perf report: Improve error msg when no first/last sample time found

The following message will be returned to user when executing 'perf report --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enabled, needs to

[PATCH v1 0/8] perf: Follow-up patches to improve time slice

It's follow-up patches to improve the perf time slice feature (perf report/script --time xxx) 1. Improve the error message perf report: Improve error msg when no first/last sample time found perf script: Improve error msg when no first/last sample time found 2. Fix an issue that illegal

[PATCH v1 0/8] perf: Follow-up patches to improve time slice

It's follow-up patches to improve the perf time slice feature (perf report/script --time xxx) 1. Improve the error message perf report: Improve error msg when no first/last sample time found perf script: Improve error msg when no first/last sample time found 2. Fix an issue that illegal

Re: RFC(V3): Audit Kernel Container IDs

On 2018-01-09 11:18, Simo Sorce wrote: > On Tue, 2018-01-09 at 07:16 -0500, Richard Guy Briggs wrote: > > Containers are a userspace concept. The kernel knows nothing of them. > > > > The Linux audit system needs a way to be able to track the container > > provenance of events and actions.

Re: RFC(V3): Audit Kernel Container IDs

On 2018-01-09 11:18, Simo Sorce wrote: > On Tue, 2018-01-09 at 07:16 -0500, Richard Guy Briggs wrote: > > Containers are a userspace concept. The kernel knows nothing of them. > > > > The Linux audit system needs a way to be able to track the container > > provenance of events and actions.

[PATCH 5/6] kconfig: remove redundant input_mode test for check_conf() loop

check_conf() never increments conf_cnt for listnewconfig, so conf_cnt is always zero. In other words, conf_cnt is not zero, "input_mode != listnewconfig" is met. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 5/6] kconfig: remove redundant input_mode test for check_conf() loop

check_conf() never increments conf_cnt for listnewconfig, so conf_cnt is always zero. In other words, conf_cnt is not zero, "input_mode != listnewconfig" is met. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

  1   2   3   4   5   6   7   8   9   10   >