[PATCH 5/7] Input: psmouse - add support for 2nd wheel on A4Tech Dual-Scroll wheel mice

2018-01-19 Thread Dmitry Torokhov
From: Stephen Lyons This Far-Eastern company's PS/2 mice use a deviant format for the data relating to movement of the scroll wheels for, at least, their dual wheel mice, such as their "Optical GreatEye Wheelmouse" model "WOP-35". This product has five "buttons" (one of

[PATCH 2/7] Input: psmouse - clean up code

2018-01-19 Thread Dmitry Torokhov
- switch to using BIT() macros - use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - use sign_extend32() when extracting wheel data. - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by:

[PATCH 1/7] Input: psmouse - create helper for reporting standard buttons/motion

2018-01-19 Thread Dmitry Torokhov
Many protocol driver re-implement code to parse buttons or motion data from the standard PS/2 protocol. Let's split the parsing into separate functions and reuse them in protocol drivers. Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/alps.c | 30 +++---

[PATCH 5/7] Input: psmouse - add support for 2nd wheel on A4Tech Dual-Scroll wheel mice

2018-01-19 Thread Dmitry Torokhov
From: Stephen Lyons This Far-Eastern company's PS/2 mice use a deviant format for the data relating to movement of the scroll wheels for, at least, their dual wheel mice, such as their "Optical GreatEye Wheelmouse" model "WOP-35". This product has five "buttons" (one of which is the click

[PATCH 3/7] Input: logips2pp - clean up code

2018-01-19 Thread Dmitry Torokhov
- switch to using BIT() macros - use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - use sign_extend32() when extracting wheel data. - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by:

[PATCH 3/7] Input: logips2pp - clean up code

2018-01-19 Thread Dmitry Torokhov
- switch to using BIT() macros - use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - use sign_extend32() when extracting wheel data. - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by:

[PATCH 4/7] Input: lifebook - clean up code

2018-01-19 Thread Dmitry Torokhov
- use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/lifebook.c |

[PATCH 4/7] Input: lifebook - clean up code

2018-01-19 Thread Dmitry Torokhov
- use u8 instead of unsigned char for byte data - use input_set_capability() instead of manipulating capabilities bits directly - do not abuse -1 as error code, propagate errors from various calls. Signed-off-by: Dmitry Torokhov --- drivers/input/mouse/lifebook.c | 50

[PATCH 0/7] psmouse assorted cleanups

2018-01-19 Thread Dmitry Torokhov
Hi, Just a few cleanups to psmouse code: BIT(), sign_extend(), u8 for data, etc. Plus a patch from Stephen Lyons to handle A4Tech mice with 2 scroll wheels. Thanks. Dmitry Torokhov (6): Input: psmouse - create helper for reporting standard buttons/motion Input: psmouse - clean up code

[PATCH 0/7] psmouse assorted cleanups

2018-01-19 Thread Dmitry Torokhov
Hi, Just a few cleanups to psmouse code: BIT(), sign_extend(), u8 for data, etc. Plus a patch from Stephen Lyons to handle A4Tech mice with 2 scroll wheels. Thanks. Dmitry Torokhov (6): Input: psmouse - create helper for reporting standard buttons/motion Input: psmouse - clean up code

Re: [PATCH 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-01-19 Thread Rob Herring
On Mon, Jan 15, 2018 at 04:13:59AM +0100, Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer > --- > .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 > ++ > .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +--- > 2

Re: [PATCH 4/6] dt-bindings: gpio: Add binding for Wii GPIO controller

2018-01-19 Thread Rob Herring
On Mon, Jan 15, 2018 at 04:13:59AM +0100, Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer > --- > .../bindings/gpio/nintendo,hollywood-gpio.txt | 27 > ++ > .../devicetree/bindings/powerpc/nintendo/wii.txt | 9 +--- > 2 files changed, 28

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

2018-01-19 Thread dbasehore .
On Fri, Jan 19, 2018 at 1:22 AM, Marc Zyngier wrote: > On 18/01/18 23:33, Brian Norris wrote: >> Hi, >> >> On Sat, Jan 13, 2018 at 06:10:52PM +, Marc Zyngier wrote: >>> On Fri, 12 Jan 2018 21:24:18 +, >>> Derek Basehore wrote: Some platforms power off GIC

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

2018-01-19 Thread dbasehore .
On Fri, Jan 19, 2018 at 1:22 AM, Marc Zyngier wrote: > On 18/01/18 23:33, Brian Norris wrote: >> Hi, >> >> On Sat, Jan 13, 2018 at 06:10:52PM +, Marc Zyngier wrote: >>> On Fri, 12 Jan 2018 21:24:18 +, >>> Derek Basehore wrote: Some platforms power off GIC logic in S3, so we need

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/20 07:45, Benjamin Poirier wrote: [...] > > > > I'm of the mind that we need to cut down on the code thrash. This > > driver is supposed to have been in a "maintenance" mode for the last > > year or so as there aren't being any new parts added is my > > understanding. As-is I don't

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/20 07:45, Benjamin Poirier wrote: [...] > > > > I'm of the mind that we need to cut down on the code thrash. This > > driver is supposed to have been in a "maintenance" mode for the last > > year or so as there aren't being any new parts added is my > > understanding. As-is I don't

Re: [mm 4.15-rc8] Random oopses under memory pressure.

2018-01-19 Thread Linus Torvalds
On Fri, Jan 19, 2018 at 2:12 PM, Al Viro wrote: > On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: >> >> We *should* be careful about it. I guess sparse could be made to warn, >> but I'm afraid that we have so many of these things that a warning >> isn't

Re: [mm 4.15-rc8] Random oopses under memory pressure.

2018-01-19 Thread Linus Torvalds
On Fri, Jan 19, 2018 at 2:12 PM, Al Viro wrote: > On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: >> >> We *should* be careful about it. I guess sparse could be made to warn, >> but I'm afraid that we have so many of these things that a warning >> isn't reasonable. > > You mean

Re: [PATCH 0/3] exec: Pin stack limit during exec

2018-01-19 Thread Kees Cook
On Tue, Jan 9, 2018 at 12:23 PM, Kees Cook wrote: > Attempts to solve problems with the stack limit changing during exec > continue to be frustrated[1][2]. In addition to the specific issues > around the Stack Clash family of flaws, Andy Lutomirski pointed out[3] > other

Re: [PATCH 0/3] exec: Pin stack limit during exec

2018-01-19 Thread Kees Cook
On Tue, Jan 9, 2018 at 12:23 PM, Kees Cook wrote: > Attempts to solve problems with the stack limit changing during exec > continue to be frustrated[1][2]. In addition to the specific issues > around the Stack Clash family of flaws, Andy Lutomirski pointed out[3] > other places during exec where

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/19 08:22, Alexander Duyck wrote: > On Fri, Jan 19, 2018 at 5:36 AM, Benjamin Poirier > wrote: > > On 2018/01/19 17:59, Benjamin Poirier wrote: > >> On 2018/01/18 07:51, Alexander Duyck wrote: > >> > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier

Re: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-01-19 Thread Benjamin Poirier
On 2018/01/19 08:22, Alexander Duyck wrote: > On Fri, Jan 19, 2018 at 5:36 AM, Benjamin Poirier > wrote: > > On 2018/01/19 17:59, Benjamin Poirier wrote: > >> On 2018/01/18 07:51, Alexander Duyck wrote: > >> > On Wed, Jan 17, 2018 at 10:50 PM, Benjamin Poirier > >> > wrote: > >> > > It was

Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote: > Add the DPI/RGB input pixel clock in mandatory properties > because it really offers a better preciseness for timing > computations. > Note: Fix also the DSI panel example where "ref" & "pclk" > clocks were swapped. > >

Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote: > Add the DPI/RGB input pixel clock in mandatory properties > because it really offers a better preciseness for timing > computations. > Note: Fix also the DSI panel example where "ref" & "pclk" > clocks were swapped. > >

Re: [PATCH v2 15/16] pwm: add documentation for pwm push-pull mode

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:23:02PM +0200, Claudiu Beznea wrote: > Add documentation for PWM push-pull mode. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 8 +++- > Documentation/pwm.txt | 18

Re: [PATCH v2 15/16] pwm: add documentation for pwm push-pull mode

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:23:02PM +0200, Claudiu Beznea wrote: > Add documentation for PWM push-pull mode. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 8 +++- > Documentation/pwm.txt | 18 ++ > 2 files

Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Dmitry Torokhov
On Fri, Jan 19, 2018 at 02:26:20PM -0800, Randy Dunlap wrote: > On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > > Let's explicitly document bit numbers with BIT() macro. > > > > Signed-off-by: Dmitry Torokhov > > Makes sense, but something should > #include Indeed,

Re: [PATCH v2 11/16] pwm: add documentation for PWM modes

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:58PM +0200, Claudiu Beznea wrote: > Add documentation for PWM normal and complementary modes. This and the previous patch can be combined. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 17

Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Dmitry Torokhov
On Fri, Jan 19, 2018 at 02:26:20PM -0800, Randy Dunlap wrote: > On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > > Let's explicitly document bit numbers with BIT() macro. > > > > Signed-off-by: Dmitry Torokhov > > Makes sense, but something should > #include Indeed, I'll add it, thanks. > >

Re: [PATCH v2 11/16] pwm: add documentation for PWM modes

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:58PM +0200, Claudiu Beznea wrote: > Add documentation for PWM normal and complementary modes. This and the previous patch can be combined. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 17 ++-- >

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Florian Fainelli
On 01/19/2018 02:06 PM, kbuild test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread Florian Fainelli
On 01/19/2018 02:06 PM, kbuild test robot wrote: > Hi Florian, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: >

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.15-rc8] [cannot apply to linuxtv-media/master next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-19 Thread kbuild test robot
Hi Jacopo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.15-rc8] [cannot apply to linuxtv-media/master next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH v2 10/16] pwm: Add PWM modes

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:57PM +0200, Claudiu Beznea wrote: > Define a macros for PWM modes to be used by device tree sources. > > Signed-off-by: Claudiu Beznea > --- > include/dt-bindings/pwm/pwm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [PATCH v2 10/16] pwm: Add PWM modes

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:57PM +0200, Claudiu Beznea wrote: > Define a macros for PWM modes to be used by device tree sources. > > Signed-off-by: Claudiu Beznea > --- > include/dt-bindings/pwm/pwm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/dt-bindings/pwm/pwm.h

Re: [PATCH v2 02/16] pwm: pxa: update documentation regarding pwm-cells

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:49PM +0200, Claudiu Beznea wrote: > pwm-cells should be at least 2 to provide channel number and period value. > > Cc: Mike Dunn > Signed-off-by: Claudiu Beznea > --- >

Re: [PATCH v2 02/16] pwm: pxa: update documentation regarding pwm-cells

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 04:22:49PM +0200, Claudiu Beznea wrote: > pwm-cells should be at least 2 to provide channel number and period value. > > Cc: Mike Dunn > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/pwm/pxa-pwm.txt | 6 +++--- > 1 file changed, 3

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-19 Thread Gustavo A. R. Silva
Quoting Felix Kuehling : Looks good. This change is Reviewed-by: Felix Kuehling Thanks Felix. -- Gustavo

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-19 Thread Gustavo A. R. Silva
Quoting Felix Kuehling : Looks good. This change is Reviewed-by: Felix Kuehling Thanks Felix. -- Gustavo

Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Randy Dunlap
On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > Let's explicitly document bit numbers with BIT() macro. > > Signed-off-by: Dmitry Torokhov Makes sense, but something should #include per Documentation/process/submit-checklist.rst Rule #1: 1) If you use a facility

Re: [PATCH 3/7] Input: libps2 - use BIT() for bitmask constants

2018-01-19 Thread Randy Dunlap
On 01/19/2018 11:41 AM, Dmitry Torokhov wrote: > Let's explicitly document bit numbers with BIT() macro. > > Signed-off-by: Dmitry Torokhov Makes sense, but something should #include per Documentation/process/submit-checklist.rst Rule #1: 1) If you use a facility then #include the file that

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Jakub Kicinski
On Fri, 19 Jan 2018 14:17:45 +, Roman Gushchin wrote: > > Looks good, thanks Roman! > > Would you mind updating the map names as well? It seems the > > BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > Here is the patch. Thank you for following up, would you

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Jakub Kicinski
On Fri, 19 Jan 2018 14:17:45 +, Roman Gushchin wrote: > > Looks good, thanks Roman! > > Would you mind updating the map names as well? It seems the > > BPF_MAP_TYPE_CPUMAP is missing from the list in map.c. > > Hello, Quentin! > > Here is the patch. Thank you for following up, would you

Re: [PATCH] selftests: bpf: update .gitignore with missing generated files

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 01:36 AM, Shuah Khan wrote: > Update .gitignore with missing generated files. > > Signed-off-by: Shuah Khan Applied to bpf-next, thanks Shuah!

Re: [PATCH] selftests: bpf: update .gitignore with missing generated files

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 01:36 AM, Shuah Khan wrote: > Update .gitignore with missing generated files. > > Signed-off-by: Shuah Khan Applied to bpf-next, thanks Shuah!

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 03:37 PM, Quentin Monnet wrote: > 2018-01-19 14:17 UTC+ ~ Roman Gushchin >> On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: > > [...] > >>> Looks good, thanks Roman! >>> Would you mind updating the map names as well? It seems the >>>

Re: [PATCH bpf-next] bpftool: recognize BPF_PROG_TYPE_CGROUP_DEVICE programs

2018-01-19 Thread Daniel Borkmann
On 01/19/2018 03:37 PM, Quentin Monnet wrote: > 2018-01-19 14:17 UTC+ ~ Roman Gushchin >> On Mon, Jan 15, 2018 at 07:32:01PM +, Quentin Monnet wrote: > > [...] > >>> Looks good, thanks Roman! >>> Would you mind updating the map names as well? It seems the >>> BPF_MAP_TYPE_CPUMAP is

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-19 Thread Felix Kuehling
Looks good. This change is Reviewed-by: Felix Kuehling Regards,   Felix On 2018-01-18 07:39 PM, Gustavo A. R. Silva wrote: > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. > > This issue was detected with the help of Coccinelle. > >

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-19 Thread Felix Kuehling
Looks good. This change is Reviewed-by: Felix Kuehling Regards,   Felix On 2018-01-18 07:39 PM, Gustavo A. R. Silva wrote: > Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Randy Dunlap
On 01/19/2018 01:17 PM, Icenowy Zheng wrote: > 在 2018年1月20日星期六 CST 上午5:14:09,Rob Herring 写道: >> On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: >>> Add binding documentation for Allwinner V3s CSI. >>> >>> Signed-off-by: Yong Deng >>> --- >>> >>>

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Randy Dunlap
On 01/19/2018 01:17 PM, Icenowy Zheng wrote: > 在 2018年1月20日星期六 CST 上午5:14:09,Rob Herring 写道: >> On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: >>> Add binding documentation for Allwinner V3s CSI. >>> >>> Signed-off-by: Yong Deng >>> --- >>> >>>

Re: [mm 4.15-rc8] Random oopses under memory pressure.

2018-01-19 Thread Al Viro
On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: > On Fri, Jan 19, 2018 at 4:55 AM, Matthew Wilcox wrote: > > > > So really we should be casting 'b' and 'a' to uintptr_t to be fully > > compliant with the spec. > > That's an unnecessary technicality. > > Any

Re: [mm 4.15-rc8] Random oopses under memory pressure.

2018-01-19 Thread Al Viro
On Fri, Jan 19, 2018 at 10:42:18AM -0800, Linus Torvalds wrote: > On Fri, Jan 19, 2018 at 4:55 AM, Matthew Wilcox wrote: > > > > So really we should be casting 'b' and 'a' to uintptr_t to be fully > > compliant with the spec. > > That's an unnecessary technicality. > > Any compiler that doesn't

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-19 Thread Randy Dunlap
tion(+), 1 deletion(-) --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-19 Thread Randy Dunlap
esas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union ceu_sd->asd.match.fwnode.fwnode = Signed-off-by: Randy Dunlap --- drivers/media/platform/renesas-ceu.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20180119.orig/d

[GIT PULL] SCSI fixes for 4.15-rc8

2018-01-19 Thread James Bottomley
One fix for SAS attached SATA CD-ROMs.  It turns out that the libata handling of CD devices relies on the SCSI error handler, so disable async aborts (which don't start the error handler) for these devices. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

[GIT PULL] SCSI fixes for 4.15-rc8

2018-01-19 Thread James Bottomley
One fix for SAS attached SATA CD-ROMs.  It turns out that the libata handling of CD devices relies on the SCSI error handler, so disable async aborts (which don't start the error handler) for these devices. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git

Re: [PATCH v3 1/5] bindings: regulator: added support for suspend states

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 06:18:21PM +0800, Chunyan Zhang wrote: > Some systems need to set regulators to specific states when they enter > low power modes, especially around CPUs. There are many of these modes > depending on the particular runtime state. > > Currently the regulator consumers are

Re: [PATCH v3 1/5] bindings: regulator: added support for suspend states

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 06:18:21PM +0800, Chunyan Zhang wrote: > Some systems need to set regulators to specific states when they enter > low power modes, especially around CPUs. There are many of these modes > depending on the particular runtime state. > > Currently the regulator consumers are

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/20180120-044006 config: x86_64-randconfig-x002-201802 (attached as

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

2018-01-19 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-stmmac-Fix-reception-of-Broadcom-switches-tags/20180120-044006 config: x86_64-randconfig-x002-201802 (attached as

Re: BUG: unable to handle kernel paging request in memset_erms (2)

2018-01-19 Thread Andrew Morton
On Fri, 19 Jan 2018 13:58:01 -0800 syzbot wrote: > Hello, > > syzbot hit the following crash on mmots commit > 2164355612187e55e8d60a28d2cc6b2337841a7e (Fri Jan 19 01:07:54 2018 +) > pci: test for unexpectedly disabled bridges > > So

Re: BUG: unable to handle kernel paging request in memset_erms (2)

2018-01-19 Thread Andrew Morton
On Fri, 19 Jan 2018 13:58:01 -0800 syzbot wrote: > Hello, > > syzbot hit the following crash on mmots commit > 2164355612187e55e8d60a28d2cc6b2337841a7e (Fri Jan 19 01:07:54 2018 +) > pci: test for unexpectedly disabled bridges > > So far this crash happened 2 times on mmots. > C

Re: [PATCH v4 1/3] trace-cmd: Make read_proc() to return int status via OUT arg

2018-01-19 Thread Steven Rostedt
On Fri, 19 Jan 2018 16:58:02 -0500 Steven Rostedt wrote: > Just to let you know. I accepted all three of your patches. I have one > comment, (and changed this myself). Anyway, Great job so far! I think I'm all set to start getting trace-cmd 2.7 out now. Unfortunately, I

Re: [PATCH v4 1/3] trace-cmd: Make read_proc() to return int status via OUT arg

2018-01-19 Thread Steven Rostedt
On Fri, 19 Jan 2018 16:58:02 -0500 Steven Rostedt wrote: > Just to let you know. I accepted all three of your patches. I have one > comment, (and changed this myself). Anyway, Great job so far! I think I'm all set to start getting trace-cmd 2.7 out now. Unfortunately, I don't think I'll be

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-19 Thread Rasmus Villemoes
On 2018-01-19 15:54, Arnd Bergmann wrote: > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not used > [-Werror=unused-function] > > This

Re: [PATCH] NFSD: hide unused svcxdr_dupstr()

2018-01-19 Thread Rasmus Villemoes
On 2018-01-19 15:54, Arnd Bergmann wrote: > There is now only one caller left for svcxdr_dupstr() and this is inside > of an #ifdef, so we can get a warning when the option is disabled: > > fs/nfsd/nfs4xdr.c:241:1: error: 'svcxdr_dupstr' defined but not used > [-Werror=unused-function] > > This

Re: [PATCH v4 1/3] trace-cmd: Make read_proc() to return int status via OUT arg

2018-01-19 Thread Steven Rostedt
Just to let you know. I accepted all three of your patches. I have one comment, (and changed this myself). On Tue, 16 Jan 2018 21:53:41 +0200 "Vladislav Valtchev (VMware)" wrote: > file and then parse it as an integer using strtol(). Then, it makes the > function

Re: [PATCH v4 1/3] trace-cmd: Make read_proc() to return int status via OUT arg

2018-01-19 Thread Steven Rostedt
Just to let you know. I accepted all three of your patches. I have one comment, (and changed this myself). On Tue, 16 Jan 2018 21:53:41 +0200 "Vladislav Valtchev (VMware)" wrote: > file and then parse it as an integer using strtol(). Then, it makes the > function This line is 80 characters.

[PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

2018-01-19 Thread Alexey Khoroshilov
If clk_get() fails, device_remove_file() looks inappropriate. The error path, where all crypto_register fail, misses resource deallocations. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

[PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

2018-01-19 Thread Alexey Khoroshilov
If clk_get() fails, device_remove_file() looks inappropriate. The error path, where all crypto_register fail, misses resource deallocations. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/crypto/picoxcell_crypto.c | 27

Re: [PATCH 1/3] dt-bindings: phy: phy-rockchip-typec: add usb3 otg reset

2018-01-19 Thread Rob Herring
On Thu, Jan 18, 2018 at 09:47:50AM -0800, Brian Norris wrote: > On Thu, Jan 18, 2018 at 06:20:09PM +0100, Enric Balletbo Serra wrote: > > As Brian said commit 06c47e6286d5 'usb: dwc3: of-simple: Add support > > to get resets for the device' introduced the support to get the resets > > from

Re: [PATCH 1/3] dt-bindings: phy: phy-rockchip-typec: add usb3 otg reset

2018-01-19 Thread Rob Herring
On Thu, Jan 18, 2018 at 09:47:50AM -0800, Brian Norris wrote: > On Thu, Jan 18, 2018 at 06:20:09PM +0100, Enric Balletbo Serra wrote: > > As Brian said commit 06c47e6286d5 'usb: dwc3: of-simple: Add support > > to get resets for the device' introduced the support to get the resets > > from

[PATCH v2] smc: return booleans instead of integers

2018-01-19 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix function using_ipsec as suggested by Ursula Braun. - Update subject

[PATCH v2] smc: return booleans instead of integers

2018-01-19 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix function using_ipsec as suggested by Ursula Braun. - Update subject line. net/smc/smc.h | 4

Re: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures for free running counters

2018-01-19 Thread Peter Zijlstra
On Fri, Jan 19, 2018 at 12:24:17PM -0800, Andi Kleen wrote: > > Oh, think a bit more. > > I think we cannot do the same thing as we did for CPU PMU's fixed counters. > > > > The counters here are free running counters. They cannot be start/stop. > > Yes free running counter have completely

Re: [PATCH V5 4/8] perf/x86/intel/uncore: add new data structures for free running counters

2018-01-19 Thread Peter Zijlstra
On Fri, Jan 19, 2018 at 12:24:17PM -0800, Andi Kleen wrote: > > Oh, think a bit more. > > I think we cannot do the same thing as we did for CPU PMU's fixed counters. > > > > The counters here are free running counters. They cannot be start/stop. > > Yes free running counter have completely

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

2018-01-19 Thread Tony Lindgren
* Suman Anna [180119 20:23]: > On 01/16/2018 05:22 PM, Tony Lindgren wrote: > > The RSTST registers mostly tell the device internal reset reason > > like watchdog reset for an accelerator. I'm not sure how the > > API for those would look like, do you have some ideas? > > There

Re: [PATCH] reset: ti-rstctrl: use the reset-simple driver

2018-01-19 Thread Tony Lindgren
* Suman Anna [180119 20:23]: > On 01/16/2018 05:22 PM, Tony Lindgren wrote: > > The RSTST registers mostly tell the device internal reset reason > > like watchdog reset for an accelerator. I'm not sure how the > > API for those would look like, do you have some ideas? > > There are multiple

[PATCH] IPMMU-VMSA: Delete an error message for a failed memory allocation in ipmmu_probe()

2018-01-19 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 19 Jan 2018 22:22:38 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] IPMMU-VMSA: Delete an error message for a failed memory allocation in ipmmu_probe()

2018-01-19 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 19 Jan 2018 22:22:38 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iommu/ipmmu-vmsa.c | 4 +--- 1 file changed, 1 insertion(+),

Re: [PATCH v4 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 02:27:52PM +1300, Chris Packham wrote: > The aurora cache on the Marvell Armada-XP SoC supports ECC protection > for the L2 data arrays. Add a "marvell,ecc-enable" device tree property > which can be used to enable this. > > Signed-off-by: Chris Packham

Re: [PATCH v4 5/8] ARM: l2x0: add marvell,ecc-enable property for aurora

2018-01-19 Thread Rob Herring
On Fri, Jan 12, 2018 at 02:27:52PM +1300, Chris Packham wrote: > The aurora cache on the Marvell Armada-XP SoC supports ECC protection > for the L2 data arrays. Add a "marvell,ecc-enable" device tree property > which can be used to enable this. > > Signed-off-by: Chris Packham >

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

2018-01-19 Thread Arnd Bergmann
On Fri, Jan 19, 2018 at 10:03 PM, Serge Semin wrote: > > Actually the provided patch is the best solution I could come up with. > The thing is, that the methods can't be changed. Those functions are > the part of the NTB API methods used by many drivers. So basically they

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

2018-01-19 Thread Arnd Bergmann
On Fri, Jan 19, 2018 at 10:03 PM, Serge Semin wrote: > > Actually the provided patch is the best solution I could come up with. > The thing is, that the methods can't be changed. Those functions are > the part of the NTB API methods used by many drivers. So basically they > are like

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

2018-01-19 Thread Serge Semin
On Sat, Jan 20, 2018 at 12:03:10AM +0300, Serge Semin wrote: > On Fri, Jan 19, 2018 at 09:42:17PM +0100, Arnd Bergmann wrote: > > On Fri, Jan 19, 2018 at 6:30 PM, Serge Semin > > wrote: > > > Sparse is whining about the u32 and

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

2018-01-19 Thread Serge Semin
On Sat, Jan 20, 2018 at 12:03:10AM +0300, Serge Semin wrote: > On Fri, Jan 19, 2018 at 09:42:17PM +0100, Arnd Bergmann wrote: > > On Fri, Jan 19, 2018 at 6:30 PM, Serge Semin > > wrote: > > > Sparse is whining about the u32 and __le32 mixed usage in the > > > driver. > > > > > >

Re: [PATCH v1 1/4] dt-bindings: pwm: binding allwinner sun8i R40/V40/T3.

2018-01-19 Thread Rob Herring
On Thu, Jan 11, 2018 at 07:31:57PM +0800, hao_zhang wrote: > This patch adds allwinner R40, V40, T3 pwm binding documents. > > Signed-off-by: hao_zhang > --- > Documentation/devicetree/bindings/pwm/pwm-sun8i.txt | 18 ++ > 1 file changed, 18 insertions(+) >

Re: [PATCH v1 1/4] dt-bindings: pwm: binding allwinner sun8i R40/V40/T3.

2018-01-19 Thread Rob Herring
On Thu, Jan 11, 2018 at 07:31:57PM +0800, hao_zhang wrote: > This patch adds allwinner R40, V40, T3 pwm binding documents. > > Signed-off-by: hao_zhang > --- > Documentation/devicetree/bindings/pwm/pwm-sun8i.txt | 18 ++ > 1 file changed, 18 insertions(+) > create mode 100644

Re: [PATCH v2 1/2] dt-bindings: pinctrl: Add Qualcomm SDM845 TLMM binding

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 10:00:03PM -0800, Bjorn Andersson wrote: > This adds the DeviceTree binding for the Qualcomm SDM845 TLMM block. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Added qspi related functions > >

Re: [PATCH v2 1/2] dt-bindings: pinctrl: Add Qualcomm SDM845 TLMM binding

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 10:00:03PM -0800, Bjorn Andersson wrote: > This adds the DeviceTree binding for the Qualcomm SDM845 TLMM block. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v1: > - Added qspi related functions > > .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 176

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Icenowy Zheng
在 2018年1月20日星期六 CST 上午5:14:09,Rob Herring 写道: > On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > > Add binding documentation for Allwinner V3s CSI. > > > > Signed-off-by: Yong Deng > > --- > > > > .../devicetree/bindings/media/sun6i-csi.txt| 59 > >

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Icenowy Zheng
在 2018年1月20日星期六 CST 上午5:14:09,Rob Herring 写道: > On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > > Add binding documentation for Allwinner V3s CSI. > > > > Signed-off-by: Yong Deng > > --- > > > > .../devicetree/bindings/media/sun6i-csi.txt| 59 > > ++ 1

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Rob Herring
On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/sun6i-csi.txt| 59 > ++ > 1 file changed, 59 insertions(+) >

Re: [PATCH v5 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-01-19 Thread Rob Herring
On Thu, Jan 11, 2018 at 11:03:43AM +0800, Yong Deng wrote: > Add binding documentation for Allwinner V3s CSI. > > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/sun6i-csi.txt| 59 > ++ > 1 file changed, 59 insertions(+) > create mode 100644

Re: [PATCH v3 5/9] doc: dt-bindings: Add doc for the Ingenic TCU timers driver

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 11:48:34PM +0100, Paul Cercueil wrote: > Add documentation about how to properly use the Ingenic TCU > (Timer/Counter Unit) timers driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > .../devicetree/bindings/timer/ingenic,tcu.txt |

Re: [PATCH v3 5/9] doc: dt-bindings: Add doc for the Ingenic TCU timers driver

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 11:48:34PM +0100, Paul Cercueil wrote: > Add documentation about how to properly use the Ingenic TCU > (Timer/Counter Unit) timers driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > .../devicetree/bindings/timer/ingenic,tcu.txt | 35 >

Re: [PATCH v3 4/9] doc: dt-bindings: Add doc for the Ingenic TCU clocks driver

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 11:48:33PM +0100, Paul Cercueil wrote: > Add documentation about how to properly use the Ingenic TCU > (Timer/Counter Unit) clocks driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > .../bindings/clock/ingenic,tcu-clocks.txt |

Re: [PATCH v3 4/9] doc: dt-bindings: Add doc for the Ingenic TCU clocks driver

2018-01-19 Thread Rob Herring
On Wed, Jan 10, 2018 at 11:48:33PM +0100, Paul Cercueil wrote: > Add documentation about how to properly use the Ingenic TCU > (Timer/Counter Unit) clocks driver from devicetree. > > Signed-off-by: Paul Cercueil > --- > .../bindings/clock/ingenic,tcu-clocks.txt | 36 >

<    1   2   3   4   5   6   7   8   9   10   >