[PATCH tip-pti 1/2] x86/entry: remove SAVE_C_REGS_EXCEPT_* macros

2018-02-06 Thread Dominik Brodowski
The macros which save all but specific registers have been unused for a long time. Remove them and the SAVE_C_REGS_HELPER macro, but instead provide the SAVE_C_REGS macro directly. Signed-off-by: Dominik Brodowski diff --git a/arch/x86/entry/calling.h

[PATCH tip-pti 1/2] x86/entry: remove SAVE_C_REGS_EXCEPT_* macros

2018-02-06 Thread Dominik Brodowski
The macros which save all but specific registers have been unused for a long time. Remove them and the SAVE_C_REGS_HELPER macro, but instead provide the SAVE_C_REGS macro directly. Signed-off-by: Dominik Brodowski diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h index

[PATCH tip-pti 2/2] x86/entry: interleave XOR register clearing with PUSH/MOV instructions

2018-02-06 Thread Dominik Brodowski
Same as is done for syscalls, interleave XOR with PUSH or MOV instructions for exceptions/interrupts, in order to minimize the cost of the additional instructions required for register clearing. Signed-off-by: Dominik Brodowski diff --git a/arch/x86/entry/calling.h

[PATCH tip-pti 2/2] x86/entry: interleave XOR register clearing with PUSH/MOV instructions

2018-02-06 Thread Dominik Brodowski
Same as is done for syscalls, interleave XOR with PUSH or MOV instructions for exceptions/interrupts, in order to minimize the cost of the additional instructions required for register clearing. Signed-off-by: Dominik Brodowski diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h

[GIT PULL] perf fixes

2018-02-06 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: 59410f5ac70a0949a6f06ba43eecb8f99be31291 Merge tag 'perf-urgent-for-mingo-4.16-20180205' of

[GIT PULL] perf fixes

2018-02-06 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: 59410f5ac70a0949a6f06ba43eecb8f99be31291 Merge tag 'perf-urgent-for-mingo-4.16-20180205' of

RE: [PATCH 1/2 v2] tpm: cmd_ready command can be issued only after granting locality

2018-02-06 Thread Winkler, Tomas
> > On Sun, Jan 28, 2018 at 09:17:53PM +, Winkler, Tomas wrote: > > > > > > > > On Sun, Jan 28, 2018 at 09:51:00AM +0200, Tomas Winkler wrote: > > > > > > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h index > > > > bcdd3790e94d..06639fb6ab85 100644 > > > > +++ b/include/linux/tpm.h

RE: [PATCH 1/2 v2] tpm: cmd_ready command can be issued only after granting locality

2018-02-06 Thread Winkler, Tomas
> > On Sun, Jan 28, 2018 at 09:17:53PM +, Winkler, Tomas wrote: > > > > > > > > On Sun, Jan 28, 2018 at 09:51:00AM +0200, Tomas Winkler wrote: > > > > > > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h index > > > > bcdd3790e94d..06639fb6ab85 100644 > > > > +++ b/include/linux/tpm.h

Re: [PATCH v2 0/3] Update blocked load

2018-02-06 Thread Peter Zijlstra
On Tue, Feb 06, 2018 at 08:23:04PM +0100, Vincent Guittot wrote: > This patchset applies on top of Peter's sched/esting branch minus the last 2 > commit: > 56eb46798b33 ("sched: Clean up nohz enter/exit") So what will update the blocked load after we wake from a total idle? I don't see anything

Re: [PATCH v2 0/3] Update blocked load

2018-02-06 Thread Peter Zijlstra
On Tue, Feb 06, 2018 at 08:23:04PM +0100, Vincent Guittot wrote: > This patchset applies on top of Peter's sched/esting branch minus the last 2 > commit: > 56eb46798b33 ("sched: Clean up nohz enter/exit") So what will update the blocked load after we wake from a total idle? I don't see anything

[PATCH 2/2] drm/tilcdc: panel: Use common error handling code in of_get_panel_info()

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 22:10:11 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 2/2] drm/tilcdc: panel: Use common error handling code in of_get_panel_info()

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 22:10:11 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 12 +--- 1 file changed, 5 insertions(+), 7

[PATCHv2 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When

[PATCHv2 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When validating such a master

[PATCH] Update rf_type_definition

2018-02-06 Thread l4stpr0gr4m
From: Kangmin Park enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h is different from enum tag_HAL_RF_Type_Definition on rtl8723bs/include/HalVerDef.h So, update them to be the same reference from enum rf_type on rtlwifi/wifi.h which recent version. As a result,

Re: [PATCH 0/7] objtool: retpoline validation

2018-02-06 Thread David Woodhouse
On Thu, 2018-02-01 at 10:16 -0800, Tim Chen wrote: > On 02/01/2018 08:51 AM, David Woodhouse wrote: > > No, we just need to set IBRS before doing it. The same applies to any > > EFI runtime calls, APM and all kinds of other random crap that calls > > into firmware. I'm not sure why those aren't

[PATCH] Update rf_type_definition

2018-02-06 Thread l4stpr0gr4m
From: Kangmin Park enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h is different from enum tag_HAL_RF_Type_Definition on rtl8723bs/include/HalVerDef.h So, update them to be the same reference from enum rf_type on rtlwifi/wifi.h which recent version. As a result, ODM_RF_TYPE_E needs to

Re: [PATCH 0/7] objtool: retpoline validation

2018-02-06 Thread David Woodhouse
On Thu, 2018-02-01 at 10:16 -0800, Tim Chen wrote: > On 02/01/2018 08:51 AM, David Woodhouse wrote: > > No, we just need to set IBRS before doing it. The same applies to any > > EFI runtime calls, APM and all kinds of other random crap that calls > > into firmware. I'm not sure why those aren't

[PATCH 1/2] drm/tilcdc: Delete an error message for a failed memory allocation in seven functions

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 21:51:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] drm/tilcdc: Delete an error message for a failed memory allocation in seven functions

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 21:51:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 4 +---

[PATCH 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When

[PATCH 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When validating such a master

[PATCH 0/2] GPU-DRM-TILCDC: Adjustments for seven function implementations

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 22:17:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in seven functions Use common error handling

[PATCH 0/2] GPU-DRM-TILCDC: Adjustments for seven function implementations

2018-02-06 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 6 Feb 2018 22:17:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in seven functions Use common error handling code in of_get_panel_info()

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 09:27 PM, Tim Harvey wrote: > v4l2-compliance test results: > - with the following kernel patches: >v4l2-subdev: clear reserved fields > . v4l2-subdev: without controls return -ENOTTY > > v4l2-compliance SHA : b2f8f9049056eb6f9e028927dacb2c715a062df8 > Media Driver Info:

Re: [PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 09:27 PM, Tim Harvey wrote: > v4l2-compliance test results: > - with the following kernel patches: >v4l2-subdev: clear reserved fields > . v4l2-subdev: without controls return -ENOTTY > > v4l2-compliance SHA : b2f8f9049056eb6f9e028927dacb2c715a062df8 > Media Driver Info:

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +- 1 file changed, 1

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

2018-02-06 Thread Artem Savkov
Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov ---

[PATCH 0/2] sun4i_ss_prng fixes

2018-02-06 Thread Artem Savkov
IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6

[PATCH 0/2] sun4i_ss_prng fixes

2018-02-06 Thread Artem Savkov
IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 6

[PATCH 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When

[PATCH 1/1] KEYS: encrypted: fix buffer overread in valid_master_desc()

2018-02-06 Thread Jin Qian
From: Eric Biggers commit 794b4bc292f5d31739d89c0202c54e7dc9bc3add upstream With the 'encrypted' key type it was possible for userspace to provide a data blob ending with a master key description shorter than expected, e.g. 'keyctl add encrypted desc "new x" @s'. When validating such a master

Re: [STABLE 4.9.y PATCH 0/9] Backport of KVM Speculation Control support

2018-02-06 Thread Woodhouse, David
On Tue, 2018-02-06 at 19:01 +0100, Paolo Bonzini wrote: > On 06/02/2018 18:29, David Woodhouse wrote: > > I've put together a linux-4.9.y branch at  > > http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > >  > > Most of it is fairly straightforward, apart from the

Re: [STABLE 4.9.y PATCH 0/9] Backport of KVM Speculation Control support

2018-02-06 Thread Woodhouse, David
On Tue, 2018-02-06 at 19:01 +0100, Paolo Bonzini wrote: > On 06/02/2018 18:29, David Woodhouse wrote: > > I've put together a linux-4.9.y branch at  > > http://git.infradead.org/retpoline-stable.git/shortlog/refs/heads/linux-4.9.y > >  > > Most of it is fairly straightforward, apart from the

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 10:03 PM, Tim Harvey wrote: > On Tue, Feb 6, 2018 at 12:38 PM, Hans Verkuil wrote: >> On 02/06/2018 09:27 PM, Tim Harvey wrote: >>> Add support for the TDA1997x HDMI receivers. >>> >>> Cc: Hans Verkuil >>> Signed-off-by: Tim Harvey

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 10:03 PM, Tim Harvey wrote: > On Tue, Feb 6, 2018 at 12:38 PM, Hans Verkuil wrote: >> On 02/06/2018 09:27 PM, Tim Harvey wrote: >>> Add support for the TDA1997x HDMI receivers. >>> >>> Cc: Hans Verkuil >>> Signed-off-by: Tim Harvey >>> --- >> >> >> >>> +static int

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Jeff Kirsher
On Tue, 2018-02-06 at 13:01 -0800, Alexander Duyck wrote: > On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe > wrote: > > Update documentation on how to enable ixgb and ixgb DCB. > > Simply remove NETDEV_1 and replace it with the new used kconfig > > names. > > Minor typo

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Jeff Kirsher
On Tue, 2018-02-06 at 13:01 -0800, Alexander Duyck wrote: > On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe > wrote: > > Update documentation on how to enable ixgb and ixgb DCB. > > Simply remove NETDEV_1 and replace it with the new used kconfig > > names. > > Minor typo in the patch

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

RE: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb

2018-02-06 Thread Alexey Brodkin
Hi Bartosz, > -Original Message- > From: Bartosz Golaszewski [mailto:b...@bgdev.pl] > Sent: Tuesday, February 6, 2018 7:02 PM > To: Alexey Brodkin > Cc: linux-kernel@vger.kernel.org; mark.rutl...@arm.com; > vineet.gup...@synopsys.com; robh...@kernel.org; >

RE: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb

2018-02-06 Thread Alexey Brodkin
Hi Bartosz, > -Original Message- > From: Bartosz Golaszewski [mailto:b...@bgdev.pl] > Sent: Tuesday, February 6, 2018 7:02 PM > To: Alexey Brodkin > Cc: linux-kernel@vger.kernel.org; mark.rutl...@arm.com; > vineet.gup...@synopsys.com; robh...@kernel.org; > devicet...@vger.kernel.org;

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Tim Harvey
On Tue, Feb 6, 2018 at 12:38 PM, Hans Verkuil wrote: > On 02/06/2018 09:27 PM, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil >> Signed-off-by: Tim Harvey >> --- > > > >> +static int

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Tim Harvey
On Tue, Feb 6, 2018 at 12:38 PM, Hans Verkuil wrote: > On 02/06/2018 09:27 PM, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> >> Cc: Hans Verkuil >> Signed-off-by: Tim Harvey >> --- > > > >> +static int tda1997x_get_dv_timings_cap(struct v4l2_subdev *sd, >> +

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread Andy Lutomirski
On Tue, Feb 6, 2018 at 8:52 PM, David Woodhouse wrote: > On Tue, 2018-02-06 at 12:32 -0800, Guenter Roeck wrote: >> >> > >> Feedback, anyone ? >> >> I understand that there is no love for the ABI differences between clang >> and gcc, but that doesn't help me. Even if the patch

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread Andy Lutomirski
On Tue, Feb 6, 2018 at 8:52 PM, David Woodhouse wrote: > On Tue, 2018-02-06 at 12:32 -0800, Guenter Roeck wrote: >> >> > >> Feedback, anyone ? >> >> I understand that there is no love for the ABI differences between clang >> and gcc, but that doesn't help me. Even if the patch is unacceptable >>

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Alexander Duyck
On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe wrote: > Update documentation on how to enable ixgb and ixgb DCB. > Simply remove NETDEV_1 and replace it with the new used kconfig names. Minor typo in the patch description. I assume you mean "ixgb and ixgbe DCB". Also

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Alexander Duyck
On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe wrote: > Update documentation on how to enable ixgb and ixgb DCB. > Simply remove NETDEV_1 and replace it with the new used kconfig names. Minor typo in the patch description. I assume you mean "ixgb and ixgbe DCB". Also you might want to

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:49 PM, Andy Lutomirski wrote: > > Can you use @cc to make an asm statement that outputs both the masked > array index and the "if" condition? I can never remember the syntax, > but something like: Yes. Although I'd actually suggest just using an "asm

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:49 PM, Andy Lutomirski wrote: > > Can you use @cc to make an asm statement that outputs both the masked > array index and the "if" condition? I can never remember the syntax, > but something like: Yes. Although I'd actually suggest just using an "asm goto" if we really

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

2018-02-06 Thread David Woodhouse
On Tue, 2018-02-06 at 15:45 -0500, tedheadster wrote: > > If that is correct (and I might be wrong), then I am up to date and I > am still getting the following in /proc/cpuinfo on my Pentium 4M i686: > > bugs  : cpu_meltdown spectre_v1 spectre_v2 That's expected for now. The CPUs we exempt are

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

2018-02-06 Thread David Woodhouse
On Tue, 2018-02-06 at 15:45 -0500, tedheadster wrote: > > If that is correct (and I might be wrong), then I am up to date and I > am still getting the following in /proc/cpuinfo on my Pentium 4M i686: > > bugs  : cpu_meltdown spectre_v1 spectre_v2 That's expected for now. The CPUs we exempt are

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread David Woodhouse
On Tue, 2018-02-06 at 12:32 -0800, Guenter Roeck wrote: > > >  > Feedback, anyone ? > > I understand that there is no love for the ABI differences between clang > and gcc, but that doesn't help me. Even if the patch is unacceptable > as-is, I would like to have some feedback to get an idea if I

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread David Woodhouse
On Tue, 2018-02-06 at 12:32 -0800, Guenter Roeck wrote: > > >  > Feedback, anyone ? > > I understand that there is no love for the ABI differences between clang > and gcc, but that doesn't help me. Even if the patch is unacceptable > as-is, I would like to have some feedback to get an idea if I

RE: [PATCH v2] tpm: add longer timeouts for creation commands.

2018-02-06 Thread Winkler, Tomas
> > On Sun, Jan 28, 2018 at 10:17:39AM +0200, Tomas Winkler wrote: > > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve > > generation of crypto keys which can be a computationally intensive task. > > The timeout is set to 3min. > > > > Signed-off-by: Tomas Winkler

RE: [PATCH v2] tpm: add longer timeouts for creation commands.

2018-02-06 Thread Winkler, Tomas
> > On Sun, Jan 28, 2018 at 10:17:39AM +0200, Tomas Winkler wrote: > > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve > > generation of crypto keys which can be a computationally intensive task. > > The timeout is set to 3min. > > > > Signed-off-by: Tomas Winkler > > This is

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Andy Lutomirski
On Tue, Feb 6, 2018 at 8:42 PM, Linus Torvalds wrote: > On Tue, Feb 6, 2018 at 12:37 PM, Dan Williams > wrote: >> >> Are there any compilers that would miscompile: >> >> mask = 0 - (index < size); >> >> That might be a way to improve

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Andy Lutomirski
On Tue, Feb 6, 2018 at 8:42 PM, Linus Torvalds wrote: > On Tue, Feb 6, 2018 at 12:37 PM, Dan Williams > wrote: >> >> Are there any compilers that would miscompile: >> >> mask = 0 - (index < size); >> >> That might be a way to improve the assembly. > > Sadly, that is *very* easy to

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

2018-02-06 Thread Jacek Anaszewski
On 02/06/2018 03:02 AM, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: >> >>> *** if brightness=0, led off >>> *** else apply brightness if next timer <--- timer is stop, and will >>> never apply new setting >>> ** otherwise set

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

2018-02-06 Thread Jacek Anaszewski
On 02/06/2018 03:02 AM, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: >> >>> *** if brightness=0, led off >>> *** else apply brightness if next timer <--- timer is stop, and will >>> never apply new setting >>> ** otherwise set

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

2018-02-06 Thread tedheadster
On Tue, Feb 6, 2018 at 2:24 PM, tedheadster wrote: > On Tue, Feb 6, 2018 at 2:17 PM, David Woodhouse wrote: >> On Tue, 2018-02-06 at 11:13 -0800, Guenter Roeck wrote: >>> On Tue, Feb 06, 2018 at 07:10:27PM +, David Woodhouse wrote: >>> > >>> > >>>

Re: [BUG] x86 : i486 reporting to be vulnerable to Meltdown/Spectre_V1/Spectre_V2

2018-02-06 Thread tedheadster
On Tue, Feb 6, 2018 at 2:24 PM, tedheadster wrote: > On Tue, Feb 6, 2018 at 2:17 PM, David Woodhouse wrote: >> On Tue, 2018-02-06 at 11:13 -0800, Guenter Roeck wrote: >>> On Tue, Feb 06, 2018 at 07:10:27PM +, David Woodhouse wrote: >>> > >>> > >>> > >>> > On Tue, 2018-02-06 at 11:02 -0800,

Re: [PATCH 3/3] fs : ext2: super: fixed '==' instead '=' braces,whitespace coding style issue.

2018-02-06 Thread Randy Dunlap
On 02/06/2018 12:33 PM, devesh.pradh...@gmail.com wrote: > From: devesh pradhan > > fixed coding style issue. I think there is more here than coding style fixes. Also, did you do any testing after making these changes? > Signed-off-by: devesh pradhan

Re: [PATCH 3/3] fs : ext2: super: fixed '==' instead '=' braces,whitespace coding style issue.

2018-02-06 Thread Randy Dunlap
On 02/06/2018 12:33 PM, devesh.pradh...@gmail.com wrote: > From: devesh pradhan > > fixed coding style issue. I think there is more here than coding style fixes. Also, did you do any testing after making these changes? > Signed-off-by: devesh pradhan > --- > fs/ext2/super.c | 59 >

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:42 PM, Linus Torvalds wrote: > > Sadly, that is *very* easy to miscompile. Side note: don't read email, go watch the falcon heavy takeoff. Linus

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:42 PM, Linus Torvalds wrote: > > Sadly, that is *very* easy to miscompile. Side note: don't read email, go watch the falcon heavy takeoff. Linus

[PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Corentin Labbe
Update documentation on how to enable ixgb and ixgb DCB. Simply remove NETDEV_1 and replace it with the new used kconfig names. Signed-off-by: Corentin Labbe --- Documentation/networking/ixgb.txt | 3 ++- Documentation/networking/ixgbe.txt | 7 --- 2 files changed,

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:37 PM, Dan Williams wrote: > > Are there any compilers that would miscompile: > > mask = 0 - (index < size); > > That might be a way to improve the assembly. Sadly, that is *very* easy to miscompile. In fact, I'd be very surprised indeed if

[PATCH] Documentation: networking: Update ixgb kconfig select documentation

2018-02-06 Thread Corentin Labbe
Update documentation on how to enable ixgb and ixgb DCB. Simply remove NETDEV_1 and replace it with the new used kconfig names. Signed-off-by: Corentin Labbe --- Documentation/networking/ixgb.txt | 3 ++- Documentation/networking/ixgbe.txt | 7 --- 2 files changed, 6 insertions(+), 4

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Linus Torvalds
On Tue, Feb 6, 2018 at 12:37 PM, Dan Williams wrote: > > Are there any compilers that would miscompile: > > mask = 0 - (index < size); > > That might be a way to improve the assembly. Sadly, that is *very* easy to miscompile. In fact, I'd be very surprised indeed if any compiler worth its

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

2018-02-06 Thread Greg KH
On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > From: Jin Qian > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > to v4.4 to prevent virt_to_page on highmem. > > ext4_encrypted_follow_link uses kmap() for cpage > caddr = kmap(cpage);

Re: [PATCHv2 1/1] ext4: don't put symlink in pagecache into highmem

2018-02-06 Thread Greg KH
On Tue, Feb 06, 2018 at 11:09:37AM -0800, Jin Qian wrote: > From: Jin Qian > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > to v4.4 to prevent virt_to_page on highmem. > > ext4_encrypted_follow_link uses kmap() for cpage > caddr = kmap(cpage); > >

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 09:27 PM, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > +static int tda1997x_get_dv_timings_cap(struct v4l2_subdev *sd, > +

Re: [PATCH v8 5/7] media: i2c: Add TDA1997x HDMI receiver driver

2018-02-06 Thread Hans Verkuil
On 02/06/2018 09:27 PM, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > +static int tda1997x_get_dv_timings_cap(struct v4l2_subdev *sd, > +struct v4l2_dv_timings_cap *cap) > +{ > +

[PATCH v2] IB/cxgb3: remove cxio_dbg.c

2018-02-06 Thread Corentin Labbe
cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups") 10 years after, we could remove it. Signed-off-by: Corentin Labbe Acked-by: Steve Wise --- Changes since v1: - Remove also all DEBUG code as suggested by Joe Perches

[PATCH v2] IB/cxgb3: remove cxio_dbg.c

2018-02-06 Thread Corentin Labbe
cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups") 10 years after, we could remove it. Signed-off-by: Corentin Labbe Acked-by: Steve Wise --- Changes since v1: - Remove also all DEBUG code as suggested by Joe Perches drivers/infiniband/hw/cxgb3/Kconfig| 9 --

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Dan Williams
On Tue, Feb 6, 2018 at 12:26 PM, Linus Torvalds wrote: > On Tue, Feb 6, 2018 at 11:48 AM, Dan Williams > wrote: >> >> Just to clarify, when you say "this patch" you mean: >> >> 2fbd7af5af86 x86/syscall: Sanitize syscall table

Re: [PATCH v4 07/10] x86: narrow out of bounds syscalls to sys_read under speculation

2018-02-06 Thread Dan Williams
On Tue, Feb 6, 2018 at 12:26 PM, Linus Torvalds wrote: > On Tue, Feb 6, 2018 at 11:48 AM, Dan Williams > wrote: >> >> Just to clarify, when you say "this patch" you mean: >> >> 2fbd7af5af86 x86/syscall: Sanitize syscall table de-references >> under speculation >> >> ...not this early

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

2018-02-06 Thread Rob Herring
On Fri, Jan 26, 2018 at 4:18 PM, Stephen Boyd wrote: > On 01/25, Rajendra Nayak wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> new file mode 100644 >> index ..b97f99e6f4b4 >> --- /dev/null >>

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

2018-02-06 Thread Rob Herring
On Fri, Jan 26, 2018 at 4:18 PM, Stephen Boyd wrote: > On 01/25, Rajendra Nayak wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi >> new file mode 100644 >> index ..b97f99e6f4b4 >> --- /dev/null >> +++

Re: [PATCH v3 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-06 Thread Marc Zyngier
On Tue, 06 Feb 2018 18:09:04 +, Lina Iyer wrote: > > From : Archana Sathyakumar > > The Power Domain Controller (PDC) on QTI SoCs like SDM845 houses an > interrupt controller along with other domain control functions to handle > interrupt related functions like

Re: [PATCH v3 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-06 Thread Marc Zyngier
On Tue, 06 Feb 2018 18:09:04 +, Lina Iyer wrote: > > From : Archana Sathyakumar > > The Power Domain Controller (PDC) on QTI SoCs like SDM845 houses an > interrupt controller along with other domain control functions to handle > interrupt related functions like handle falling edge or active

RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-06 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Monday, February 5, 2018 10:18 AM > To: Darren Hart > Cc: platform-driver-...@vger.kernel.org; AceLan Kao

RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

2018-02-06 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Monday, February 5, 2018 10:18 AM > To: Darren Hart > Cc: platform-driver-...@vger.kernel.org; AceLan Kao > ;

[PATCH 3/3] fs : ext2: super: fixed '==' instead '=' braces,whitespace coding style issue.

2018-02-06 Thread devesh . pradhan1
From: devesh pradhan fixed coding style issue. Signed-off-by: devesh pradhan --- fs/ext2/super.c | 59 ++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git

[PATCH 3/3] fs : ext2: super: fixed '==' instead '=' braces,whitespace coding style issue.

2018-02-06 Thread devesh . pradhan1
From: devesh pradhan fixed coding style issue. Signed-off-by: devesh pradhan --- fs/ext2/super.c | 59 ++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 554c98b8a93a..cb80bcb693a9

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread Guenter Roeck
On Fri, Feb 02, 2018 at 03:30:40PM -0800, Guenter Roeck wrote: > clang has its own set of compiler options for retpoline support. > Also, the thunks required by C code have their own function names. > > For 64-bit builds, there is only a single thunk, which is easy > to support. Support for

Re: [RFC] x86/retpoline: Add clang support for 64-bit builds

2018-02-06 Thread Guenter Roeck
On Fri, Feb 02, 2018 at 03:30:40PM -0800, Guenter Roeck wrote: > clang has its own set of compiler options for retpoline support. > Also, the thunks required by C code have their own function names. > > For 64-bit builds, there is only a single thunk, which is easy > to support. Support for

Re: [PATCH 1/2] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

2018-02-06 Thread Rob Herring
On Thu, Jan 25, 2018 at 10:32 AM, Rajendra Nayak wrote: > Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/qcom/Makefile| 1 + >

Re: [PATCH 1/2] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

2018-02-06 Thread Rob Herring
On Thu, Jan 25, 2018 at 10:32 AM, Rajendra Nayak wrote: > Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/qcom/Makefile| 1 + > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 13 ++ >

[PATCH v8 2/7] media: v4l-ioctl: fix pad for VIDIOC_DV_TIMIGNS_CAP

2018-02-06 Thread Tim Harvey
Signed-off-by: Tim Harvey --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 7961499..5f3670d 100644 ---

[PATCH v8 2/7] media: v4l-ioctl: fix pad for VIDIOC_DV_TIMIGNS_CAP

2018-02-06 Thread Tim Harvey
Signed-off-by: Tim Harvey --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 7961499..5f3670d 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++

[PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-06 Thread Tim Harvey
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver. I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q/IMX6DL which uses the TDA19971 with 16bits connected to the IMX6 CSI and single-lane I2S audio providing 2-channel audio. For this configuration I've tested both

[PATCH v8 0/7] TDA1997x HDMI video reciver

2018-02-06 Thread Tim Harvey
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver. I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q/IMX6DL which uses the TDA19971 with 16bits connected to the IMX6 CSI and single-lane I2S audio providing 2-channel audio. For this configuration I've tested both

[PATCH v8 4/7] media: dt-bindings: Add bindings for TDA1997X

2018-02-06 Thread Tim Harvey
Acked-by: Rob Herring Acked-by: Sakari Ailus Signed-off-by: Tim Harvey --- v6: - replace copyright with SPDX tag - added Rob's ack v5: - added Sakari's ack v4: - move include/dt-bindings/media/tda1997x.h to bindings patch -

[PATCH v8 4/7] media: dt-bindings: Add bindings for TDA1997X

2018-02-06 Thread Tim Harvey
Acked-by: Rob Herring Acked-by: Sakari Ailus Signed-off-by: Tim Harvey --- v6: - replace copyright with SPDX tag - added Rob's ack v5: - added Sakari's ack v4: - move include/dt-bindings/media/tda1997x.h to bindings patch - clarify port node details v3: - fix typo v2: - add vendor

Re: [PATCH v7 04/24] mm: Dont assume page-table invariance during faults

2018-02-06 Thread Matthew Wilcox
On Tue, Feb 06, 2018 at 05:49:50PM +0100, Laurent Dufour wrote: > From: Peter Zijlstra > > One of the side effects of speculating on faults (without holding > mmap_sem) is that we can race with free_pgtables() and therefore we > cannot assume the page-tables will stick

Re: [PATCH v7 04/24] mm: Dont assume page-table invariance during faults

2018-02-06 Thread Matthew Wilcox
On Tue, Feb 06, 2018 at 05:49:50PM +0100, Laurent Dufour wrote: > From: Peter Zijlstra > > One of the side effects of speculating on faults (without holding > mmap_sem) is that we can race with free_pgtables() and therefore we > cannot assume the page-tables will stick around. > > Remove the

<    1   2   3   4   5   6   7   8   9   10   >