[PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()

2018-02-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 15 Feb 2018 22:15:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] sata_dwc_460ex: Delete an error message for a failed memory allocation in sata_dwc_port_start()

2018-02-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 15 Feb 2018 22:15:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/ata/sata_dwc_460ex.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH v13 7/8] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx

2018-02-15 Thread Tim Harvey
On Thu, Feb 15, 2018 at 10:36 AM, Hans Verkuil wrote: > On 15/02/18 18:55, Tim Harvey wrote: >> The GW54xx has a front-panel microHDMI connector routed to a TDA19971 >> which is connected the the IPU CSI when using IMX6Q. > > I assume that this and the next patch go through

Re: [PATCH v13 7/8] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx

2018-02-15 Thread Tim Harvey
On Thu, Feb 15, 2018 at 10:36 AM, Hans Verkuil wrote: > On 15/02/18 18:55, Tim Harvey wrote: >> The GW54xx has a front-panel microHDMI connector routed to a TDA19971 >> which is connected the the IPU CSI when using IMX6Q. > > I assume that this and the next patch go through another subsystem for

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-15 Thread Andrew Lunn
On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > _port_ is being used as index to array port_hwtstamp before verifying > it is a non-negative number and a valid index at line 209 and 258: > > if (port < 0 || port >= mv88e6xxx_num_ports(chip)) > > Fix this by checking _port_

Re: [PATCH v2] net: dsa: mv88e6xxx: hwtstamp: fix potential negative array index read

2018-02-15 Thread Andrew Lunn
On Thu, Feb 15, 2018 at 12:31:39PM -0600, Gustavo A. R. Silva wrote: > _port_ is being used as index to array port_hwtstamp before verifying > it is a non-negative number and a valid index at line 209 and 258: > > if (port < 0 || port >= mv88e6xxx_num_ports(chip)) > > Fix this by checking _port_

[PATCH v2 2/4] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved SMCA bank type

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Currently, bank 4 is reserved on Fam17h, so we chose not to initialize bank 4 in the smca_banks array. This means that when we check if a bank is initialized, like during boot or resume, we will see that bank 4 is not initialized and try to initialize

[PATCH v2 2/4] x86/MCE/AMD, EDAC/mce_amd: Enumerate Reserved SMCA bank type

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Currently, bank 4 is reserved on Fam17h, so we chose not to initialize bank 4 in the smca_banks array. This means that when we check if a bank is initialized, like during boot or resume, we will see that bank 4 is not initialized and try to initialize it. This will cause a

[PATCH v2 3/4] x86/MCE/AMD: Get address from already initialized block

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam The block address is saved after the block is initialized when threshold_init_device() is called. Use the saved block address, if available, rather than trying to rediscover it. This will avoid a call trace, when resuming from suspend, due to the

[PATCH v2 3/4] x86/MCE/AMD: Get address from already initialized block

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam The block address is saved after the block is initialized when threshold_init_device() is called. Use the saved block address, if available, rather than trying to rediscover it. This will avoid a call trace, when resuming from suspend, due to the rdmsr_safe_on_cpu() call in

[PATCH v2 1/4] x86/MCE/AMD: Redo function to get SMCA bank type

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Pass the bank number to smca_get_bank_type() since that's all we need. Also, we should compare the bank number to the size of the smca_banks array not the number of bank types. Bank types are reused for multiple banks, so the number of types can be

Re: [RFC PATCH V2 00/22] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-02-15 Thread Mike Kravetz
On 02/15/2018 12:39 PM, Reinette Chatre wrote: > On 2/14/2018 10:31 AM, Reinette Chatre wrote: >> On 2/14/2018 10:12 AM, Mike Kravetz wrote: >>> On 02/13/2018 07:46 AM, Reinette Chatre wrote: Adding MM maintainers to v2 to share the new MM change (patch 21/22) that enables large

[PATCH v2 1/4] x86/MCE/AMD: Redo function to get SMCA bank type

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Pass the bank number to smca_get_bank_type() since that's all we need. Also, we should compare the bank number to the size of the smca_banks array not the number of bank types. Bank types are reused for multiple banks, so the number of types can be different from the number

Re: [RFC PATCH V2 00/22] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-02-15 Thread Mike Kravetz
On 02/15/2018 12:39 PM, Reinette Chatre wrote: > On 2/14/2018 10:31 AM, Reinette Chatre wrote: >> On 2/14/2018 10:12 AM, Mike Kravetz wrote: >>> On 02/13/2018 07:46 AM, Reinette Chatre wrote: Adding MM maintainers to v2 to share the new MM change (patch 21/22) that enables large

[PATCH v2 4/4] x86/MCE/AMD: Carve out SMCA get_block_address() code

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Carve out the SMCA code in get_block_address() into a separate helper function. No functional change. Signed-off-by: Yazen Ghannam --- v1->v2: * New in this series. arch/x86/kernel/cpu/mcheck/mce_amd.c | 59

[PATCH v2 4/4] x86/MCE/AMD: Carve out SMCA get_block_address() code

2018-02-15 Thread Yazen Ghannam
From: Yazen Ghannam Carve out the SMCA code in get_block_address() into a separate helper function. No functional change. Signed-off-by: Yazen Ghannam --- v1->v2: * New in this series. arch/x86/kernel/cpu/mcheck/mce_amd.c | 59 1 file changed, 33

[PATCH] disable sparse warnings about unknown attributes

2018-02-15 Thread Luc Van Oostenryck
Currently, sparse issues warnings on code using an attribute it doesn't know about. One of the problem with this is that these warnings have no value for the developer, it's just noise for him. At best these warnings tell something about some deficiencies of sparse itself but not about a

[PATCH] disable sparse warnings about unknown attributes

2018-02-15 Thread Luc Van Oostenryck
Currently, sparse issues warnings on code using an attribute it doesn't know about. One of the problem with this is that these warnings have no value for the developer, it's just noise for him. At best these warnings tell something about some deficiencies of sparse itself but not about a

Re: [PATCH v2 4/8] clk: migrate the count of orphaned clocks at init

2018-02-15 Thread Heiko Stübner
Am Mittwoch, 14. Februar 2018, 14:43:36 CET schrieb Jerome Brunet: > The orphan clocks reparents should migrate any existing count from the > orphan clock to its new acestor clocks, otherwise we may have > inconsistent counts in the tree and end-up with gated critical clocks > > Assuming we have

Re: [PATCH v2 4/8] clk: migrate the count of orphaned clocks at init

2018-02-15 Thread Heiko Stübner
Am Mittwoch, 14. Februar 2018, 14:43:36 CET schrieb Jerome Brunet: > The orphan clocks reparents should migrate any existing count from the > orphan clock to its new acestor clocks, otherwise we may have > inconsistent counts in the tree and end-up with gated critical clocks > > Assuming we have

Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

2018-02-15 Thread Arnd Bergmann
On Thu, Feb 15, 2018 at 5:43 PM, Greg KH wrote: > On Thu, Feb 15, 2018 at 04:37:10PM +0100, Arnd Bergmann wrote: >> On Thu, Feb 15, 2018 at 6:43 AM, Greg KH wrote: >> > On Wed, Feb 14, 2018 at 11:12:24PM +0100, Arnd Bergmann wrote: >> >> On

Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

2018-02-15 Thread Arnd Bergmann
On Thu, Feb 15, 2018 at 5:43 PM, Greg KH wrote: > On Thu, Feb 15, 2018 at 04:37:10PM +0100, Arnd Bergmann wrote: >> On Thu, Feb 15, 2018 at 6:43 AM, Greg KH wrote: >> > On Wed, Feb 14, 2018 at 11:12:24PM +0100, Arnd Bergmann wrote: >> >> On Wed, Dec 6, 2017 at 4:08 PM, Dave Hansen >> >> wrote:

Re: [PATCH] linux/nospec.h: allow index argument to have const-qualified type

2018-02-15 Thread Linus Torvalds
On Thu, Feb 15, 2018 at 11:52 AM, Rasmus Villemoes wrote: > > This way, we can allow index to have const-qualified type, which will in > some cases avoid the need for introducing a local copy of index of > non-const qualified type. Ack. That said, looking at this

Re: [PATCH] linux/nospec.h: allow index argument to have const-qualified type

2018-02-15 Thread Linus Torvalds
On Thu, Feb 15, 2018 at 11:52 AM, Rasmus Villemoes wrote: > > This way, we can allow index to have const-qualified type, which will in > some cases avoid the need for introducing a local copy of index of > non-const qualified type. Ack. That said, looking at this header file, I find a couple of

Re: [PATCH v4 00/17] arm64: Add SMCCC v1.1 support and CVE-2017-5715 (Spectre variant 2) mitigation

2018-02-15 Thread Jon Masters
Hi Marc, all, On 02/06/2018 12:56 PM, Marc Zyngier wrote: > ARM has recently published a SMC Calling Convention (SMCCC) > specification update[1] that provides an optimised calling convention > and optional, discoverable support for mitigating CVE-2017-5715. ARM > Trusted Firmware (ATF) has

Re: [PATCH v4 00/17] arm64: Add SMCCC v1.1 support and CVE-2017-5715 (Spectre variant 2) mitigation

2018-02-15 Thread Jon Masters
Hi Marc, all, On 02/06/2018 12:56 PM, Marc Zyngier wrote: > ARM has recently published a SMC Calling Convention (SMCCC) > specification update[1] that provides an optimised calling convention > and optional, discoverable support for mitigating CVE-2017-5715. ARM > Trusted Firmware (ATF) has

Re: [PATCH RFC v2 4/6] x86: Disable PTI on compatibility mode

2018-02-15 Thread Nadav Amit
Andy Lutomirski wrote: > On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: >> Based on the understanding that there should be no way for userspace to >> address the kernel-space from compatibility mode, disable it while >> running in compatibility mode as

Re: [PATCH RFC v2 4/6] x86: Disable PTI on compatibility mode

2018-02-15 Thread Nadav Amit
Andy Lutomirski wrote: > On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: >> Based on the understanding that there should be no way for userspace to >> address the kernel-space from compatibility mode, disable it while >> running in compatibility mode as long as the 64-bit code segment of the

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 20:51 +, Steven Rostedt wrote: On Thu, 15 Feb 2018 20:41:18 + Lina Iyer wrote: >--- a/drivers/soc/qcom/Makefile >+++ b/drivers/soc/qcom/Makefile >@@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 >+CFLAGS_trace-rpmh.o := -I$(src) I did

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 20:51 +, Steven Rostedt wrote: On Thu, 15 Feb 2018 20:41:18 + Lina Iyer wrote: >--- a/drivers/soc/qcom/Makefile >+++ b/drivers/soc/qcom/Makefile >@@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 >+CFLAGS_trace-rpmh.o := -I$(src) I did this here.. Needs to

[PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

2018-02-15 Thread Moritz Fischer
From: Moritz Fischer Add 'timeout' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 1 file

[PATCH 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

2018-02-15 Thread Moritz Fischer
From: Moritz Fischer Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- drivers/power/reset/gpio-poweroff.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

2018-02-15 Thread Moritz Fischer
From: Moritz Fischer Add 'timeout' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

2018-02-15 Thread Moritz Fischer
From: Moritz Fischer Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- drivers/power/reset/gpio-poweroff.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 20:41:18 + Lina Iyer wrote: > >--- a/drivers/soc/qcom/Makefile > >+++ b/drivers/soc/qcom/Makefile > >@@ -1,4 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > >+CFLAGS_trace-rpmh.o := -I$(src) > I did this here.. Needs to be: CFLAGS_rpmh-rsc.o

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 20:41:18 + Lina Iyer wrote: > >--- a/drivers/soc/qcom/Makefile > >+++ b/drivers/soc/qcom/Makefile > >@@ -1,4 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > >+CFLAGS_trace-rpmh.o := -I$(src) > I did this here.. Needs to be: CFLAGS_rpmh-rsc.o You need to use the C

Re: [PATCH RFC v2 1/6] x86: Skip PTI when disable indication is set

2018-02-15 Thread Nadav Amit
Andy Lutomirski wrote: > On Thu, Feb 15, 2018 at 4:35 PM, Nadav Amit wrote: >> If PTI is disabled, we do not want to switch page-tables. On entry to >> the kernel, this is done based on CR3 value. On return, do it according >> to per core indication. >> >> To

Re: [PATCH RFC v2 1/6] x86: Skip PTI when disable indication is set

2018-02-15 Thread Nadav Amit
Andy Lutomirski wrote: > On Thu, Feb 15, 2018 at 4:35 PM, Nadav Amit wrote: >> If PTI is disabled, we do not want to switch page-tables. On entry to >> the kernel, this is done based on CR3 value. On return, do it according >> to per core indication. >> >> To be on the safe side, avoid

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread Matthew Wilcox
On Thu, Feb 15, 2018 at 09:49:00AM -0600, Christopher Lameter wrote: > On Thu, 15 Feb 2018, Matthew Wilcox wrote: > > What if ... on startup, slab allocated a MAX_ORDER page for itself. > > It would then satisfy its own page allocation requests from this giant > > page. If we start to run low on

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread Matthew Wilcox
On Thu, Feb 15, 2018 at 09:49:00AM -0600, Christopher Lameter wrote: > On Thu, 15 Feb 2018, Matthew Wilcox wrote: > > What if ... on startup, slab allocated a MAX_ORDER page for itself. > > It would then satisfy its own page allocation requests from this giant > > page. If we start to run low on

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread David Rientjes
On Thu, 15 Feb 2018, Michal Hocko wrote: > > When the amount of kernel > > memory is well bounded for certain systems, it is better to aggressively > > reclaim from existing MIGRATE_UNMOVABLE pageblocks rather than eagerly > > fallback to others. > > > > We have additional patches that help

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread David Rientjes
On Thu, 15 Feb 2018, Michal Hocko wrote: > > When the amount of kernel > > memory is well bounded for certain systems, it is better to aggressively > > reclaim from existing MIGRATE_UNMOVABLE pageblocks rather than eagerly > > fallback to others. > > > > We have additional patches that help

Re: [PATCH][V2] rtc: tx4939: avoid unintended sign extension on a 24 bit shift

2018-02-15 Thread Alexandre Belloni
On 15/02/2018 at 19:36:14 +, Colin King wrote: > From: Colin Ian King > > The shifting of buf[5] by 24 bits to the left will be promoted to > a 32 bit signed int and then sign-extended to an unsigned long. If > the top bit of buf[5] is set then all then all the

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Nadav Amit
Dave Hansen wrote: > On 02/15/2018 11:53 AM, Andy Lutomirski wrote: >>> --- a/arch/x86/include/asm/tlbflush.h >>> +++ b/arch/x86/include/asm/tlbflush.h >>> @@ -319,6 +319,12 @@ static inline void set_cpu_pti_disable(unsigned short >>> disable) >>>

Re: [PATCH][V2] rtc: tx4939: avoid unintended sign extension on a 24 bit shift

2018-02-15 Thread Alexandre Belloni
On 15/02/2018 at 19:36:14 +, Colin King wrote: > From: Colin Ian King > > The shifting of buf[5] by 24 bits to the left will be promoted to > a 32 bit signed int and then sign-extended to an unsigned long. If > the top bit of buf[5] is set then all then all the upper bits sec > end up as

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Nadav Amit
Dave Hansen wrote: > On 02/15/2018 11:53 AM, Andy Lutomirski wrote: >>> --- a/arch/x86/include/asm/tlbflush.h >>> +++ b/arch/x86/include/asm/tlbflush.h >>> @@ -319,6 +319,12 @@ static inline void set_cpu_pti_disable(unsigned short >>> disable) >>>WARN_ON_ONCE(preemptible()); >>> >>>

Re: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule

2018-02-15 Thread Paul Moore
On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs wrote: > Signed-off-by: Richard Guy Briggs > --- > kernel/auditfilter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I realize this is an RFC patchset, but considering recent patchsets I feel

Re: [RFC PATCH 2/3] fixup! audit: remove arch_f pointer from struct audit_krule

2018-02-15 Thread Paul Moore
On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs wrote: > Signed-off-by: Richard Guy Briggs > --- > kernel/auditfilter.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I realize this is an RFC patchset, but considering recent patchsets I feel some clarification might be helpful

TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-15 Thread Oleksandr Natalenko
Hello. I've faced an issue with a limited TCP bandwidth between my laptop and a server in my 1 Gbps LAN while using BBR as a congestion control mechanism. To verify my observations, I've set up 2 KVM VMs with the following parameters: 1) Linux v4.15.3 2) virtio NICs 3) 128 MiB of RAM 4) 2

TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-15 Thread Oleksandr Natalenko
Hello. I've faced an issue with a limited TCP bandwidth between my laptop and a server in my 1 Gbps LAN while using BBR as a congestion control mechanism. To verify my observations, I've set up 2 KVM VMs with the following parameters: 1) Linux v4.15.3 2) virtio NICs 3) 128 MiB of RAM 4) 2

Re: [RFC PATCH 1/3] audit: remove arch_f pointer from struct audit_krule

2018-02-15 Thread Paul Moore
On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs wrote: > The arch_f pointer was added to the struct audit_krule in commit: > e54dc2431d740a79a6bd013babade99d71b1714f ("audit signal recipients") > > This is only used on addition and deletion of rules which isn't time >

Re: [RFC PATCH 1/3] audit: remove arch_f pointer from struct audit_krule

2018-02-15 Thread Paul Moore
On Mon, Feb 12, 2018 at 7:29 AM, Richard Guy Briggs wrote: > The arch_f pointer was added to the struct audit_krule in commit: > e54dc2431d740a79a6bd013babade99d71b1714f ("audit signal recipients") > > This is only used on addition and deletion of rules which isn't time > critical and the arch

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
Hi Steve, On Thu, Feb 15 2018 at 17:35 +, Lina Iyer wrote: Log sent RPMH requests and interrupt responses in FTRACE. Cc: Steven Rostedt Signed-off-by: Lina Iyer --- drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/rpmh-rsc.c | 6 +++

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
Hi Steve, On Thu, Feb 15 2018 at 17:35 +, Lina Iyer wrote: Log sent RPMH requests and interrupt responses in FTRACE. Cc: Steven Rostedt Signed-off-by: Lina Iyer --- drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/rpmh-rsc.c | 6 +++ drivers/soc/qcom/trace-rpmh.h | 89

Re: [RFC PATCH V2 00/22] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-02-15 Thread Reinette Chatre
On 2/14/2018 10:31 AM, Reinette Chatre wrote: > On 2/14/2018 10:12 AM, Mike Kravetz wrote: >> On 02/13/2018 07:46 AM, Reinette Chatre wrote: >>> Adding MM maintainers to v2 to share the new MM change (patch 21/22) that >>> enables large contiguous regions that was created to support large Cache

Re: [RFC PATCH V2 00/22] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-02-15 Thread Reinette Chatre
On 2/14/2018 10:31 AM, Reinette Chatre wrote: > On 2/14/2018 10:12 AM, Mike Kravetz wrote: >> On 02/13/2018 07:46 AM, Reinette Chatre wrote: >>> Adding MM maintainers to v2 to share the new MM change (patch 21/22) that >>> enables large contiguous regions that was created to support large Cache

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 19:57 +, Steven Rostedt wrote: On Thu, 15 Feb 2018 10:35:00 -0700 Lina Iyer wrote: @@ -298,6 +303,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int m, int n, write_tcs_reg(drv, RSC_DRV_CMD_MSGID, m, n + i, msgid);

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 19:57 +, Steven Rostedt wrote: On Thu, 15 Feb 2018 10:35:00 -0700 Lina Iyer wrote: @@ -298,6 +303,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int m, int n, write_tcs_reg(drv, RSC_DRV_CMD_MSGID, m, n + i, msgid);

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 9:19 AM, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the

Re: [PATCH 1/3] locking/ww_mutex: cleanup lock->ctx usage in amdgpu

2018-02-15 Thread Alex Deucher
On Thu, Feb 15, 2018 at 9:19 AM, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex internals by

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Dave Hansen
On 02/15/2018 11:53 AM, Andy Lutomirski wrote: >> --- a/arch/x86/include/asm/tlbflush.h >> +++ b/arch/x86/include/asm/tlbflush.h >> @@ -319,6 +319,12 @@ static inline void set_cpu_pti_disable(unsigned short >> disable) >> WARN_ON_ONCE(preemptible()); >> >>

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Dave Hansen
On 02/15/2018 11:53 AM, Andy Lutomirski wrote: >> --- a/arch/x86/include/asm/tlbflush.h >> +++ b/arch/x86/include/asm/tlbflush.h >> @@ -319,6 +319,12 @@ static inline void set_cpu_pti_disable(unsigned short >> disable) >> WARN_ON_ONCE(preemptible()); >> >>

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 20:24 +, Thomas Gleixner wrote: On Thu, 15 Feb 2018, Lina Iyer wrote: On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: > On Fri, 9 Feb 2018, Lina Iyer wrote: > > +enum pdc_irq_config_bits { > > + PDC_POLARITY_LOW= 0, > > + PDC_FALLING_EDGE

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Lina Iyer
On Thu, Feb 15 2018 at 20:24 +, Thomas Gleixner wrote: On Thu, 15 Feb 2018, Lina Iyer wrote: On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: > On Fri, 9 Feb 2018, Lina Iyer wrote: > > +enum pdc_irq_config_bits { > > + PDC_POLARITY_LOW= 0, > > + PDC_FALLING_EDGE

linux-next: change contact address for the sunxi tree?

2018-02-15 Thread Stephen Rothwell
Hi all, I noticed commit 0a815fc929e6 ("MAINTAINERS: update email address for Maxime Ripard") Should I change the contact address I have for Maxime as well? -- Cheers, Stephen Rothwell pgpgTHKVqekhg.pgp Description: OpenPGP digital signature

linux-next: change contact address for the sunxi tree?

2018-02-15 Thread Stephen Rothwell
Hi all, I noticed commit 0a815fc929e6 ("MAINTAINERS: update email address for Maxime Ripard") Should I change the contact address I have for Maxime as well? -- Cheers, Stephen Rothwell pgpgTHKVqekhg.pgp Description: OpenPGP digital signature

Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

2018-02-15 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > index b251d534b70d..758e35fa69ab 100644 > --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > @@ -321,7 +321,7 @@ static void mv88e6xxx_get_rxts(struct

Re: [PATCH][next] net: dsa: mv88e6xxx: avoid unintended sign extension on a 16 bit shift

2018-02-15 Thread Andrew Lunn
> diff --git a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > index b251d534b70d..758e35fa69ab 100644 > --- a/drivers/net/dsa/mv88e6xxx/hwtstamp.c > +++ b/drivers/net/dsa/mv88e6xxx/hwtstamp.c > @@ -321,7 +321,7 @@ static void mv88e6xxx_get_rxts(struct

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Thomas Gleixner
On Thu, 15 Feb 2018, Lina Iyer wrote: > On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: > > On Fri, 9 Feb 2018, Lina Iyer wrote: > > > +enum pdc_irq_config_bits { > > > + PDC_POLARITY_LOW= 0, > > > + PDC_FALLING_EDGE= 2, > > > + PDC_POLARITY_HIGH = 4, > > > +

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Thomas Gleixner
On Thu, 15 Feb 2018, Lina Iyer wrote: > On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: > > On Fri, 9 Feb 2018, Lina Iyer wrote: > > > +enum pdc_irq_config_bits { > > > + PDC_POLARITY_LOW= 0, > > > + PDC_FALLING_EDGE= 2, > > > + PDC_POLARITY_HIGH = 4, > > > +

Re: [RFC PATCH 0/3] Interface for higher order contiguous allocations

2018-02-15 Thread Reinette Chatre
Hi Mike, On 2/12/2018 2:20 PM, Mike Kravetz wrote: > These patches came out of the "[RFC] mmap(MAP_CONTIG)" discussions at: > http://lkml.kernel.org/r/21f1ec96-2822-1189-1c95-79a2bb491...@oracle.com > > One suggestion in that thread was to create a friendlier interface that > could be used by

Re: [RFC PATCH 0/3] Interface for higher order contiguous allocations

2018-02-15 Thread Reinette Chatre
Hi Mike, On 2/12/2018 2:20 PM, Mike Kravetz wrote: > These patches came out of the "[RFC] mmap(MAP_CONTIG)" discussions at: > http://lkml.kernel.org/r/21f1ec96-2822-1189-1c95-79a2bb491...@oracle.com > > One suggestion in that thread was to create a friendlier interface that > could be used by

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Lina Iyer
On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: On Fri, 9 Feb 2018, Lina Iyer wrote: +enum pdc_irq_config_bits { + PDC_POLARITY_LOW= 0, + PDC_FALLING_EDGE= 2, + PDC_POLARITY_HIGH = 4, + PDC_RISING_EDGE = 6, + PDC_DUAL_EDGE

Re: [PATCH v6 1/2] drivers: irqchip: pdc: Add PDC interrupt controller for QCOM SoCs

2018-02-15 Thread Lina Iyer
On Mon, Feb 12 2018 at 13:40 +, Thomas Gleixner wrote: On Fri, 9 Feb 2018, Lina Iyer wrote: +enum pdc_irq_config_bits { + PDC_POLARITY_LOW= 0, + PDC_FALLING_EDGE= 2, + PDC_POLARITY_HIGH = 4, + PDC_RISING_EDGE = 6, + PDC_DUAL_EDGE

Re: [BUG? NVME Linux-4.15] Dracut loops indefinitely with 4.15

2018-02-15 Thread Keith Busch
On Thu, Feb 15, 2018 at 02:49:56PM +0100, Julien Durillon wrote: > I opened an issue here: > https://github.com/dracutdevs/dracut/issues/373 for dracut. You can > read there how dracuts enters an infinite loop. > > TL;DR: in linux-4.14, trying to find the last "slave" of /dev/dm-0 > ends with a

Re: [BUG? NVME Linux-4.15] Dracut loops indefinitely with 4.15

2018-02-15 Thread Keith Busch
On Thu, Feb 15, 2018 at 02:49:56PM +0100, Julien Durillon wrote: > I opened an issue here: > https://github.com/dracutdevs/dracut/issues/373 for dracut. You can > read there how dracuts enters an infinite loop. > > TL;DR: in linux-4.14, trying to find the last "slave" of /dev/dm-0 > ends with a

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread Matthew Wilcox
On Thu, Feb 15, 2018 at 09:49:00AM -0600, Christopher Lameter wrote: > On Thu, 15 Feb 2018, Matthew Wilcox wrote: > > > What if ... on startup, slab allocated a MAX_ORDER page for itself. > > It would then satisfy its own page allocation requests from this giant > > page. If we start to run low

Re: [patch 1/2] mm, page_alloc: extend kernelcore and movablecore for percent

2018-02-15 Thread Matthew Wilcox
On Thu, Feb 15, 2018 at 09:49:00AM -0600, Christopher Lameter wrote: > On Thu, 15 Feb 2018, Matthew Wilcox wrote: > > > What if ... on startup, slab allocated a MAX_ORDER page for itself. > > It would then satisfy its own page allocation requests from this giant > > page. If we start to run low

[PATCH V3] nvme-pci: Fixes EEH failure on ppc

2018-02-15 Thread wenxiong
From: Wen Xiong With b2a0eb1a0ac72869c910a79d935a0b049ec78ad9(nvme-pci: Remove watchdog timer), EEH recovery stops working on ppc. After removing whatdog timer routine, when trigger EEH on ppc, we hit EEH in nvme_timeout(). We would like to check if pci channel is

[PATCH V3] nvme-pci: Fixes EEH failure on ppc

2018-02-15 Thread wenxiong
From: Wen Xiong With b2a0eb1a0ac72869c910a79d935a0b049ec78ad9(nvme-pci: Remove watchdog timer), EEH recovery stops working on ppc. After removing whatdog timer routine, when trigger EEH on ppc, we hit EEH in nvme_timeout(). We would like to check if pci channel is offline or not at the

Re: [PATCH 2/2] kernel/sofirq: consolidate common code in tasklet_action() + tasklet_hi_action()

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 18:20:42 +0100 Sebastian Andrzej Siewior wrote: > From: Ingo Molnar > > tasklet_action() + tasklet_hi_action() are almost identical. > Move the common code from both function into __tasklet_schedule_common() > and let both functions

Re: [PATCH 2/2] kernel/sofirq: consolidate common code in tasklet_action() + tasklet_hi_action()

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 18:20:42 +0100 Sebastian Andrzej Siewior wrote: > From: Ingo Molnar > > tasklet_action() + tasklet_hi_action() are almost identical. > Move the common code from both function into __tasklet_schedule_common() > and let both functions invoke it with different arguments. > >

Re: [PATCH 1/2] kernel/sofirq: consolidate common code in __tasklet_schedule() + _hi_

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 18:20:41 +0100 Sebastian Andrzej Siewior wrote: > -void __tasklet_schedule(struct tasklet_struct *t) > +static void __tasklet_schedule_common(struct tasklet_struct *t, > + struct tasklet_head *head, > +

Re: [PATCH 1/2] kernel/sofirq: consolidate common code in __tasklet_schedule() + _hi_

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 18:20:41 +0100 Sebastian Andrzej Siewior wrote: > -void __tasklet_schedule(struct tasklet_struct *t) > +static void __tasklet_schedule_common(struct tasklet_struct *t, > + struct tasklet_head *head, > +

Re: [PATCH RFC v2 4/6] x86: Disable PTI on compatibility mode

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: > Based on the understanding that there should be no way for userspace to > address the kernel-space from compatibility mode, disable it while > running in compatibility mode as long as the 64-bit code segment of the > user is

Re: [PATCH RFC v2 4/6] x86: Disable PTI on compatibility mode

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: > Based on the understanding that there should be no way for userspace to > address the kernel-space from compatibility mode, disable it while > running in compatibility mode as long as the 64-bit code segment of the > user is not used. > >

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 10:35:00 -0700 Lina Iyer wrote: > @@ -298,6 +303,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int > m, int n, > write_tcs_reg(drv, RSC_DRV_CMD_MSGID, m, n + i, msgid); > write_tcs_reg(drv, RSC_DRV_CMD_ADDR, m, n +

Re: [PATCH v2 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-02-15 Thread Steven Rostedt
On Thu, 15 Feb 2018 10:35:00 -0700 Lina Iyer wrote: > @@ -298,6 +303,7 @@ static void __tcs_buffer_write(struct rsc_drv *drv, int > m, int n, > write_tcs_reg(drv, RSC_DRV_CMD_MSGID, m, n + i, msgid); > write_tcs_reg(drv, RSC_DRV_CMD_ADDR, m, n + i, cmd->addr); >

[PATCH v3] rtc: isl12026: Add driver.

2018-02-15 Thread David Daney
The ISL12026 is a combination RTC and EEPROM device with I2C interface. The standard RTC driver interface is provided. The EEPROM is accessed via the NVMEM interface via the "eeprom0" directory in the sysfs entry for the device. Signed-off-by: David Daney --- Changes

[PATCH v3] rtc: isl12026: Add driver.

2018-02-15 Thread David Daney
The ISL12026 is a combination RTC and EEPROM device with I2C interface. The standard RTC driver interface is provided. The EEPROM is accessed via the NVMEM interface via the "eeprom0" directory in the sysfs entry for the device. Signed-off-by: David Daney --- Changes from v2: o More code

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: > As long as PTI is disabled, it is possible to use global pages, as long > as we remove them once PTI is enabled again. To do so, return the global > bit to __supported_pte_mask and disable global pages using CR4. > >

Re: [PATCH RFC v2 5/6] x86: Use global pages when PTI is disabled

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:36 PM, Nadav Amit wrote: > As long as PTI is disabled, it is possible to use global pages, as long > as we remove them once PTI is enabled again. To do so, return the global > bit to __supported_pte_mask and disable global pages using CR4. > > Signed-off-by: Nadav Amit

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

2018-02-15 Thread Moritz Fischer
On Thu, Feb 15, 2018 at 10:05:20AM +, Wu, Hao wrote: > > On Wed, Feb 14, 2018 at 3:03 PM, Moritz Fischer wrote: > > > > Hi Moritz, > > > > > HI Hao, > > > > > Hi Alan and Moritz > > Thanks a lot for the code review and comments. > > > > On Tue, Feb 13, 2018 at 05:24:36PM

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

2018-02-15 Thread Moritz Fischer
On Thu, Feb 15, 2018 at 10:05:20AM +, Wu, Hao wrote: > > On Wed, Feb 14, 2018 at 3:03 PM, Moritz Fischer wrote: > > > > Hi Moritz, > > > > > HI Hao, > > > > > Hi Alan and Moritz > > Thanks a lot for the code review and comments. > > > > On Tue, Feb 13, 2018 at 05:24:36PM +0800, Wu Hao

[PATCH] linux/nospec.h: allow index argument to have const-qualified type

2018-02-15 Thread Rasmus Villemoes
The last expression in a statement expression need not be a bare variable, quoting gcc docs The last thing in the compound statement should be an expression followed by a semicolon; the value of this subexpression serves as the value of the entire construct. and we already use that in e.g.

Re: [PATCH RFC v2 1/6] x86: Skip PTI when disable indication is set

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:35 PM, Nadav Amit wrote: > If PTI is disabled, we do not want to switch page-tables. On entry to > the kernel, this is done based on CR3 value. On return, do it according > to per core indication. > > To be on the safe side, avoid speculative skipping

[PATCH] linux/nospec.h: allow index argument to have const-qualified type

2018-02-15 Thread Rasmus Villemoes
The last expression in a statement expression need not be a bare variable, quoting gcc docs The last thing in the compound statement should be an expression followed by a semicolon; the value of this subexpression serves as the value of the entire construct. and we already use that in e.g.

Re: [PATCH RFC v2 1/6] x86: Skip PTI when disable indication is set

2018-02-15 Thread Andy Lutomirski
On Thu, Feb 15, 2018 at 4:35 PM, Nadav Amit wrote: > If PTI is disabled, we do not want to switch page-tables. On entry to > the kernel, this is done based on CR3 value. On return, do it according > to per core indication. > > To be on the safe side, avoid speculative skipping of page-tables >

[PATCH] i40e: check that pointer vsi is not null before dereferencing it

2018-02-15 Thread Colin King
From: Colin Ian King Function i40e_find_vsi_from_id can potentially return null, hence vsi may be null, so defensively check it is non-null before dereferencing it to check the seid. Fixes: e284fc280473 ("i40e: Add and delete cloud filter") Signed-off-by: Colin Ian

[PATCH] i40e: check that pointer vsi is not null before dereferencing it

2018-02-15 Thread Colin King
From: Colin Ian King Function i40e_find_vsi_from_id can potentially return null, hence vsi may be null, so defensively check it is non-null before dereferencing it to check the seid. Fixes: e284fc280473 ("i40e: Add and delete cloud filter") Signed-off-by: Colin Ian King ---

<    1   2   3   4   5   6   7   8   9   10   >