Re: [PATCH RESEND] x86: consider effective protection attributes in W+X check

2018-02-20 Thread Ingo Molnar
* Jan Beulich wrote: > I'll see what I can do; it's a pity that the change here, which had > been sent weeks ago and is a bug fix, hadn't gone in before that > other change (being more an improvement than a bug fix). When was it submitted, got a link or Message-ID of the previous submission? T

Re: [PATCH v3 4/4] x86/retpoline: Support retpoline build with Clang

2018-02-20 Thread Thomas Gleixner
On Mon, 19 Feb 2018, David Woodhouse wrote: Reviewed-by: Thomas Gleixner > +/* Clang doesn't have a way to turn it off per-function, yet. */ Is that going to happen in the foreseable future? Hmm, why am I asking, clang is going to break anyway once we require asm-gotos hard. Thanks, t

Re: [PATCH v3 3/4] Revert "x86/retpoline: Simplify vmexit_fill_RSB()"

2018-02-20 Thread Thomas Gleixner
On Mon, 19 Feb 2018, David Woodhouse wrote: > This reverts commit 1dde7415e99933bb7293d6b2843752cbdb43ec11. By putting > the RSB filling out of line and calling it, we waste one RSB slot for > returning from the function itself, which means one fewer actual function > call we can make if we're doi

Re: [PATCH RESEND] x86: consider effective protection attributes in W+X check

2018-02-20 Thread Ingo Molnar
* Jan Beulich wrote: > >>> On 20.02.18 at 09:10, wrote: > > * Jan Beulich wrote: > >> Using just the leaf page table entry flags would cause a false warning > >> in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry. > > > > Under what circumstances did you see false positive w

Re: [PATCH v3 2/4] x86/speculation: Support "Enhanced IBRS" on future CPUs

2018-02-20 Thread Thomas Gleixner
On Mon, 19 Feb 2018, David Woodhouse wrote: > diff --git a/arch/x86/include/asm/nospec-branch.h > b/arch/x86/include/asm/nospec-branch.h > index 0995c6a..34cbce3 100644 > --- a/arch/x86/include/asm/nospec-branch.h > +++ b/arch/x86/include/asm/nospec-branch.h > @@ -141,9 +141,16 @@ enum spectre_v2_

Re: [PATCH RESEND] x86: consider effective protection attributes in W+X check

2018-02-20 Thread Jan Beulich
>>> On 20.02.18 at 09:10, wrote: > * Jan Beulich wrote: >> Using just the leaf page table entry flags would cause a false warning >> in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry. > > Under what circumstances did you see false positive warnings? As explained in the 2-patc

Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A

2018-02-20 Thread Mathias Nyman
Hi On 19.02.2018 21:06, Kai-Heng Feng wrote: When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the xHC stops working: [ 549.114587] xhci_hcd :02:00.0: WARN: xHC CMD_RUN timeout [ 549.114608] suspend_common(): xhci_pci_suspend+0x0/0xc0 returns -110 [ 549.114638] xhci_hcd

[PATCH] mtd: nand: gpmi: fix edo mode for non fully ONFI compliant flashes

2018-02-20 Thread Manfred Schlaegl
In enable_edo_mode the timing mode feature is set according to previously read capabilities of the parameter page ("Timing mode support"). After the value was set, it is read back to provide a "double-check". If the "double check" fails, the whole function returns with an error, which leads to a ve

[PATCH] kconfig: clean-up reverse dependency help implementation

2018-02-20 Thread Masahiro Yamada
This commit splits out the special E_OR handling ('-' instead of '||') into a dedicated helper expr_print_revdev(). Restore the original expr_print() prior to commit 1ccb27143360 ("kconfig: make "Selected by:" and "Implied by:" readable"). This makes sense because: - We need to chop those expr

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-02-20 Thread Dmitry Vyukov
On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote: > On 19.02.2018 20:59, Dmitry Vyukov wrote: >> >> On Sat, Feb 3, 2018 at 1:15 PM, Xin Long wrote: > > On 1/30/18 1:57 PM, David Ahern wrote: >> >> On 1/30/18 1:08 PM, Daniel Borkmann wrote: >>> >>> On 01/30/2018 07:32 P

Re: [PATCH RESEND] x86: consider effective protection attributes in W+X check

2018-02-20 Thread Ingo Molnar
* Jan Beulich wrote: > Using just the leaf page table entry flags would cause a false warning > in case _PAGE_RW is clear or _PAGE_NX is set in a higher level entry. Under what circumstances did you see false positive warnings? > Hand through both the current entry's flags as well as the accum

Re: [RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

2018-02-20 Thread Andrzej Hajda
On 19.02.2018 15:28, Rob Herring wrote: > On Thu, Feb 15, 2018 at 11:39:15AM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to route other protocols,

RE: [lustre-devel] [PATCH 14/21] staging: lustre: fix assorted checkpatch errors

2018-02-20 Thread Eremin, Dmitry
Hello Neil, > diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c > b/drivers/staging/lustre/lustre/mdc/mdc_request.c > index ab48746ce433..bde27acb0dd3 100644 > --- a/drivers/staging/lustre/lustre/mdc/mdc_request.c > +++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c > @@ -1060,8 +106

Re: [PATCH v2] [media] Use common error handling code in 20 functions

2018-02-20 Thread Todor Tomov
Hi Markus, Thank you for the patch. On 19.02.2018 20:11, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 19 Feb 2018 18:50:40 +0100 > > Adjust jump targets so that a bit of exception handling can be better > reused at the end of these functions. > > This issue was partly detected

Re: [RFCv4 09/21] v4l2: add request API support

2018-02-20 Thread Alexandre Courbot
Hi Philippe, On Tue, Feb 20, 2018 at 4:36 PM, Philippe Ombredanne wrote: > On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot > wrote: >> Add a v4l2 request entity data structure that takes care of storing the >> request-related state of a V4L2 device ; in this case, its controls. >> >> Signed-o

Re: [PATCH 2/6] mfd: cros_ec: free IRQ automatically

2018-02-20 Thread Vincent Palatin
On Mon, Feb 19, 2018 at 11:40 PM, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > Free the IRQ we might have requested when removing the cros_ec device, > so we can unload and reload the driver properly. > > Signed-off-by: Vincent Palatin > Signed-off-by: Enric Balletbo i Serra > ---

<    4   5   6   7   8   9