Re: [PATCH 3/3] x86/microcode: Quiesce all threads before a microcode update.

2018-02-21 Thread Borislav Petkov
On Wed, Feb 21, 2018 at 12:13:08PM -0800, Raj, Ashok wrote: > This is ensuring no 2 cpus do ucode update at the same time. And that is a problem? We don't do any of that mutual exclusion for early loading. Why isn't it there a problem? > That's what we are doing here, but simply returning

Re: [PATCH 3/3] x86/microcode: Quiesce all threads before a microcode update.

2018-02-21 Thread Borislav Petkov
On Wed, Feb 21, 2018 at 12:13:08PM -0800, Raj, Ashok wrote: > This is ensuring no 2 cpus do ucode update at the same time. And that is a problem? We don't do any of that mutual exclusion for early loading. Why isn't it there a problem? > That's what we are doing here, but simply returning

[PATCH 045/100] rtc: mpc5121: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mpc5121.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 045/100] rtc: mpc5121: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mpc5121.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 046/100] rtc: mrst: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mrst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 046/100] rtc: mrst: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mrst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 039/100] rtc: max6902: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max6902.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 039/100] rtc: max6902: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max6902.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 038/100] rtc: m48t86: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m48t86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 049/100] rtc: mv: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 038/100] rtc: m48t86: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m48t86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 049/100] rtc: mv: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-mv.c

[PATCH 052/100] rtc: pcf2123: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2123.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 052/100] rtc: pcf2123: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2123.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 048/100] rtc: mt7622: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mt7622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 048/100] rtc: mt7622: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mt7622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 6/6] mfd: cros_ec_i2c: add ACPI module device table

2018-02-21 Thread Gwendal Grignou
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra wrote: > From: Wei-Ning Huang > > Add ACPI module device table for matching cros-ec devices to load the > cros_ec_i2c driver automatically. > > Signed-off-by: Wei-Ning Huang

[PATCH 050/100] rtc: nuc900: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-nuc900.c | 14 -- 1 file changed, 8 insertions(+), 6

Re: [PATCH 6/6] mfd: cros_ec_i2c: add ACPI module device table

2018-02-21 Thread Gwendal Grignou
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra wrote: > From: Wei-Ning Huang > > Add ACPI module device table for matching cros-ec devices to load the > cros_ec_i2c driver automatically. > > Signed-off-by: Wei-Ning Huang > Acked-by: Benson Leung > Signed-off-by: Enric Balletbo i Serra

[PATCH 050/100] rtc: nuc900: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-nuc900.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH 053/100] rtc: pcf2127: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2127.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 053/100] rtc: pcf2127: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf2127.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] KVM: SVM: Fix sparse: incorrect type in argument 1 (different base types)

2018-02-21 Thread Al Viro
On Wed, Feb 21, 2018 at 01:59:55PM -0600, Brijesh Singh wrote: > Sure, checking access_ok() does not guarantee that later > copy_from_user() will not fail. But it does eliminate one possible > reason for the failure. We are trying to validate most of the user > inputs before we invoke  SEV

Re: [PATCH] KVM: SVM: Fix sparse: incorrect type in argument 1 (different base types)

2018-02-21 Thread Al Viro
On Wed, Feb 21, 2018 at 01:59:55PM -0600, Brijesh Singh wrote: > Sure, checking access_ok() does not guarantee that later > copy_from_user() will not fail. But it does eliminate one possible > reason for the failure. We are trying to validate most of the user > inputs before we invoke  SEV

[PATCH 056/100] rtc: pic32: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pic32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 056/100] rtc: pic32: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pic32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 042/100] rtc: max8998: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 044/100] rtc: mcp795: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mcp795.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 042/100] rtc: max8998: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max8998.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 044/100] rtc: mcp795: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mcp795.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 055/100] rtc: pcf8523: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 055/100] rtc: pcf8523: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 054/100] rtc: pcf50633: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf50633.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 054/100] rtc: pcf50633: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf50633.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 041/100] rtc: max8997: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 041/100] rtc: max8997: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max8997.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 040/100] rtc: max6916: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max6916.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 040/100] rtc: max6916: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max6916.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 059/100] rtc: r9701: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-r9701.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 059/100] rtc: r9701: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-r9701.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 057/100] rtc: ps3: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ps3.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 057/100] rtc: ps3: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ps3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 062/100] rtc: rx8010: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 062/100] rtc: rx8010: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 058/100] rtc: r7301: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-r7301.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-21 Thread Emil Velikov
On 20 February 2018 at 13:12, Peter Zijlstra wrote: > On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote: >> amdgpu needs to verify if userspace sends us valid addresses and the simplest >> way of doing this is to check if the buffer object is locked with the

[PATCH 058/100] rtc: r7301: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-r7301.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/4] locking/ww_mutex: add ww_mutex_is_owned_by function v3

2018-02-21 Thread Emil Velikov
On 20 February 2018 at 13:12, Peter Zijlstra wrote: > On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote: >> amdgpu needs to verify if userspace sends us valid addresses and the simplest >> way of doing this is to check if the buffer object is locked with the ticket >> of the current

[PATCH 043/100] rtc: mc13xxx: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mc13xxx.c | 2 +- 1 file changed, 1

[PATCH 043/100] rtc: mc13xxx: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mc13xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 060/100] rtc: rp5c01: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rp5c01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 060/100] rtc: rp5c01: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rp5c01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 066/100] rtc: sc27xx: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sc27xx.c | 2 +- 1 file changed, 1

[PATCH 066/100] rtc: sc27xx: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sc27xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 068/100] rtc: starfire: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-starfire.c | 2 +- 1 file changed, 1

[PATCH 068/100] rtc: starfire: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-starfire.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 061/100] rtc: rx6110: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx6110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 069/100] rtc: sun6i: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 061/100] rtc: rx6110: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx6110.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 069/100] rtc: sun6i: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sun6i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 065/100] rtc: s5m: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s5m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 065/100] rtc: s5m: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s5m.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-s5m.c

[PATCH 074/100] rtc: xgene: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 064/100] rtc: s3c: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 074/100] rtc: xgene: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 064/100] rtc: s3c: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-s3c.c

[PATCH 063/100] rtc: rx8025: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8025.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 063/100] rtc: rx8025: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8025.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 071/100] rtc: tps6586x: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tps6586x.c | 2 +- 1 file changed, 1

[PATCH 071/100] rtc: tps6586x: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tps6586x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 073/100] rtc: wm831x: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-wm831x.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 073/100] rtc: wm831x: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-wm831x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 067/100] rtc: sh: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 067/100] rtc: sh: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sh.c

[PATCH 070/100] rtc: sunxi: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 070/100] rtc: sunxi: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sunxi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 072/100] rtc: tx4939: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tx4939.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 072/100] rtc: tx4939: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tx4939.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 086/100] rtc: rx4581: remove useless message

2018-02-21 Thread Alexandre Belloni
It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx4581.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH 083/100] rtc: tegra: stop validating rtc_time in .set_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time. It is not necessary to do it again in .set_time. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tegra.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 086/100] rtc: rx4581: remove useless message

2018-02-21 Thread Alexandre Belloni
It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx4581.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 083/100] rtc: tegra: stop validating rtc_time in .set_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time. It is not necessary to do it again in .set_time. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tegra.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c

[PATCH 084/100] rtc: abx80x: remove useless message

2018-02-21 Thread Alexandre Belloni
It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-abx80x.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff

[PATCH 084/100] rtc: abx80x: remove useless message

2018-02-21 Thread Alexandre Belloni
It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-abx80x.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 081/100] rtc: omap: stop validating rtc_time in .set_time and .set_alarm

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time or .set_alarm. It is not necessary to do it again. Also, rtc_time_to_tm never generates an invalid rtc_tm (it can be out of range though). Signed-off-by: Alexandre Belloni ---

[PATCH 081/100] rtc: omap: stop validating rtc_time in .set_time and .set_alarm

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time or .set_alarm. It is not necessary to do it again. Also, rtc_time_to_tm never generates an invalid rtc_tm (it can be out of range though). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-omap.c | 3 --- 1 file

[PATCH 082/100] rtc: spear: stop validating rtc_time in .set_time and .set_alarm

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time or .set_alarm. It is not necessary to do it again. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-spear.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff

[PATCH 082/100] rtc: spear: stop validating rtc_time in .set_time and .set_alarm

2018-02-21 Thread Alexandre Belloni
The RTC core is always validating the rtc_time struct before calling .set_time or .set_alarm. It is not necessary to do it again. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-spear.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-spear.c

[PATCH 076/100] rtc: isl12022: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl12022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 076/100] rtc: isl12022: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl12022.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 077/100] rtc: isl12022: remove useless indirection

2018-02-21 Thread Alexandre Belloni
isl12022_get_datetime and isl12022_set_datetime are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl12022.c | 16 1 file changed, 4 insertions(+), 12

[PATCH 077/100] rtc: isl12022: remove useless indirection

2018-02-21 Thread Alexandre Belloni
isl12022_get_datetime and isl12022_set_datetime are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl12022.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git

[PATCH 079/100] rtc: m41t93: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m41t93.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 079/100] rtc: m41t93: stop validating rtc_time in .read_time

2018-02-21 Thread Alexandre Belloni
The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-m41t93.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 089/100] rtc: rk808: remove useless debug message

2018-02-21 Thread Alexandre Belloni
At probe time, printing a message when the time is invalid doesn't have much value. Also, as the comment suggest, this is a leftover from development wherhe this was used to set the RTc to a default time. Signed-off-by: Alexandre Belloni ---

[PATCH 089/100] rtc: rk808: remove useless debug message

2018-02-21 Thread Alexandre Belloni
At probe time, printing a message when the time is invalid doesn't have much value. Also, as the comment suggest, this is a leftover from development wherhe this was used to set the RTc to a default time. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rk808.c | 11 --- 1 file

[PATCH 090/100] rtc: rk808: fix possible race condition

2018-02-21 Thread Alexandre Belloni
The probe function is not allowed to fail after registering the RTC because the following may happen: CPU0:CPU1: sys_load_module() do_init_module() do_one_initcall() cmos_do_probe() rtc_device_register() __register_chrdev() cdev->owner = struct

[PATCH 090/100] rtc: rk808: fix possible race condition

2018-02-21 Thread Alexandre Belloni
The probe function is not allowed to fail after registering the RTC because the following may happen: CPU0:CPU1: sys_load_module() do_init_module() do_one_initcall() cmos_do_probe() rtc_device_register() __register_chrdev() cdev->owner = struct

[PATCH 093/100] rtc: s35390a: remove useless indirection

2018-02-21 Thread Alexandre Belloni
s35390a_set_datetime, s35390a_get_datetime, s35390a_set_alarm and s35390a_read_alarm are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s35390a.c | 32

[PATCH 085/100] rtc: pm8xxx: remove useless message

2018-02-21 Thread Alexandre Belloni
It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pm8xxx.c | 6 -- 1 file changed, 6 deletions(-) diff --git

<    4   5   6   7   8   9   10   11   12   13   >