On Wed, Feb 21, 2018 at 12:13:08PM -0800, Raj, Ashok wrote:
> This is ensuring no 2 cpus do ucode update at the same time.
And that is a problem?
We don't do any of that mutual exclusion for early loading. Why isn't it
there a problem?
> That's what we are doing here, but simply returning
On Wed, Feb 21, 2018 at 12:13:08PM -0800, Raj, Ashok wrote:
> This is ensuring no 2 cpus do ucode update at the same time.
And that is a problem?
We don't do any of that mutual exclusion for early loading. Why isn't it
there a problem?
> That's what we are doing here, but simply returning
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mpc5121.c | 2 +-
1 file changed, 1 insertion(+),
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mpc5121.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mrst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mrst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max6902.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max6902.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-m48t86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-m48t86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-mv.c
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf2123.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf2123.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mt7622.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mt7622.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra
wrote:
> From: Wei-Ning Huang
>
> Add ACPI module device table for matching cros-ec devices to load the
> cros_ec_i2c driver automatically.
>
> Signed-off-by: Wei-Ning Huang
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-nuc900.c | 14 --
1 file changed, 8 insertions(+), 6
On Mon, Feb 19, 2018 at 2:46 PM, Enric Balletbo i Serra
wrote:
> From: Wei-Ning Huang
>
> Add ACPI module device table for matching cros-ec devices to load the
> cros_ec_i2c driver automatically.
>
> Signed-off-by: Wei-Ning Huang
> Acked-by: Benson Leung
> Signed-off-by: Enric Balletbo i Serra
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-nuc900.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf2127.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf2127.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Feb 21, 2018 at 01:59:55PM -0600, Brijesh Singh wrote:
> Sure, checking access_ok() does not guarantee that later
> copy_from_user() will not fail. But it does eliminate one possible
> reason for the failure. We are trying to validate most of the user
> inputs before we invoke SEV
On Wed, Feb 21, 2018 at 01:59:55PM -0600, Brijesh Singh wrote:
> Sure, checking access_ok() does not guarantee that later
> copy_from_user() will not fail. But it does eliminate one possible
> reason for the failure. We are trying to validate most of the user
> inputs before we invoke SEV
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pic32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pic32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mcp795.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max8998.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mcp795.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf8523.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf8523.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf50633.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pcf50633.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max8997.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max8997.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max6916.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-max6916.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-r9701.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-r9701.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-ps3.c | 2 +-
1 file changed, 1 insertion(+), 1
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-ps3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx8010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx8010.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-r7301.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 20 February 2018 at 13:12, Peter Zijlstra wrote:
> On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote:
>> amdgpu needs to verify if userspace sends us valid addresses and the simplest
>> way of doing this is to check if the buffer object is locked with the
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-r7301.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 20 February 2018 at 13:12, Peter Zijlstra wrote:
> On Tue, Feb 20, 2018 at 01:58:26PM +0100, Christian König wrote:
>> amdgpu needs to verify if userspace sends us valid addresses and the simplest
>> way of doing this is to check if the buffer object is locked with the ticket
>> of the current
rtc_time64_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mc13xxx.c | 2 +-
1 file changed, 1
rtc_time64_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-mc13xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rp5c01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rp5c01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time64_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sc27xx.c | 2 +-
1 file changed, 1
rtc_time64_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sc27xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-starfire.c | 2 +-
1 file changed, 1
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-starfire.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx6110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx6110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sun6i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-s5m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-s5m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-s5m.c
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-s3c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-s3c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-s3c.c
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx8025.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx8025.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tps6586x.c | 2 +-
1 file changed, 1
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tps6586x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-wm831x.c | 2 +-
1 file changed, 1 insertion(+),
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-wm831x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-sh.c
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-sunxi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tx4939.c | 2 +-
1 file changed, 1 insertion(+),
rtc_time_to_tm never generates an invalid tm. It is not necessary to
validate it. Also, the RTC core is always calling rtc_valid_tm after the
read_time callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tx4939.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
It is not necessary to print a message when the time is invalid as
userspace will already get an error (and an optional dev_dbg message).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx4581.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
The RTC core is always validating the rtc_time struct before calling
.set_time. It is not necessary to do it again in .set_time.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tegra.c | 4
1 file changed, 4 deletions(-)
diff --git
It is not necessary to print a message when the time is invalid as
userspace will already get an error (and an optional dev_dbg message).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rx4581.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
The RTC core is always validating the rtc_time struct before calling
.set_time. It is not necessary to do it again in .set_time.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-tegra.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
It is not necessary to print a message when the time is invalid as
userspace will already get an error (and an optional dev_dbg message).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-abx80x.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
It is not necessary to print a message when the time is invalid as
userspace will already get an error (and an optional dev_dbg message).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-abx80x.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
The RTC core is always validating the rtc_time struct before calling
.set_time or .set_alarm. It is not necessary to do it again.
Also, rtc_time_to_tm never generates an invalid rtc_tm (it can be out of
range though).
Signed-off-by: Alexandre Belloni
---
The RTC core is always validating the rtc_time struct before calling
.set_time or .set_alarm. It is not necessary to do it again.
Also, rtc_time_to_tm never generates an invalid rtc_tm (it can be out of
range though).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-omap.c | 3 ---
1 file
The RTC core is always validating the rtc_time struct before calling
.set_time or .set_alarm. It is not necessary to do it again.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-spear.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff
The RTC core is always validating the rtc_time struct before calling
.set_time or .set_alarm. It is not necessary to do it again.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-spear.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/rtc/rtc-spear.c
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-isl12022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-isl12022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
isl12022_get_datetime and isl12022_set_datetime are only used after casting
dev to an i2c_client. Remove that useless indirection.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-isl12022.c | 16
1 file changed, 4 insertions(+), 12
isl12022_get_datetime and isl12022_set_datetime are only used after casting
dev to an i2c_client. Remove that useless indirection.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-isl12022.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-m41t93.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-m41t93.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
At probe time, printing a message when the time is invalid doesn't have
much value. Also, as the comment suggest, this is a leftover from
development wherhe this was used to set the RTc to a default time.
Signed-off-by: Alexandre Belloni
---
At probe time, printing a message when the time is invalid doesn't have
much value. Also, as the comment suggest, this is a leftover from
development wherhe this was used to set the RTc to a default time.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-rk808.c | 11 ---
1 file
The probe function is not allowed to fail after registering the RTC because
the following may happen:
CPU0:CPU1:
sys_load_module()
do_init_module()
do_one_initcall()
cmos_do_probe()
rtc_device_register()
__register_chrdev()
cdev->owner = struct
The probe function is not allowed to fail after registering the RTC because
the following may happen:
CPU0:CPU1:
sys_load_module()
do_init_module()
do_one_initcall()
cmos_do_probe()
rtc_device_register()
__register_chrdev()
cdev->owner = struct
s35390a_set_datetime, s35390a_get_datetime, s35390a_set_alarm and
s35390a_read_alarm are only used after casting dev to an i2c_client. Remove
that useless indirection.
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-s35390a.c | 32
It is not necessary to print a message when the time is invalid as
userspace will already get an error (and an optional dev_dbg message).
Signed-off-by: Alexandre Belloni
---
drivers/rtc/rtc-pm8xxx.c | 6 --
1 file changed, 6 deletions(-)
diff --git
801 - 900 of 3312 matches
Mail list logo