Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

On Fri, Feb 23, 2018 at 02:22:43AM +, Al Viro wrote: > No. This is completely wrong. If somebody else has found the sucker > while we dropped the lock and even got around to playing with refcount, > they might have done more than that. > > In particular, they might have *dropped* their

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

Hi Hans, Sorry if I'm a little slow to follow up here. This hasn't been my top priority... On Mon, Feb 19, 2018 at 11:17:24AM +0100, Hans de Goede wrote: > On 16-02-18 18:59, Brian Norris wrote: > > On Fri, Feb 16, 2018 at 01:10:20PM +0100, Hans de Goede wrote: > > > Ok, I've asked the reporter

Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

On Fri, Feb 23, 2018 at 02:22:43AM +, Al Viro wrote: > No. This is completely wrong. If somebody else has found the sucker > while we dropped the lock and even got around to playing with refcount, > they might have done more than that. > > In particular, they might have *dropped* their

Re: [PATCH] Bluetooth: btusb: Restore QCA Rome suspend/resume fix with a "rewritten" version

Hi Hans, Sorry if I'm a little slow to follow up here. This hasn't been my top priority... On Mon, Feb 19, 2018 at 11:17:24AM +0100, Hans de Goede wrote: > On 16-02-18 18:59, Brian Norris wrote: > > On Fri, Feb 16, 2018 at 01:10:20PM +0100, Hans de Goede wrote: > > > Ok, I've asked the reporter

[git pull] drm fixes for v4.16-rc3

Hi Linus, A bunch of fixes for rc3, Exynos fixes for using monotonic timestamps, register definitions and removal of unused file ipu-v3 - minor changes, make some register arrays const+static, fix some leaks meson: fix for vsync atomic: fix for memory leak EDID parser: add quirks for some more

[git pull] drm fixes for v4.16-rc3

Hi Linus, A bunch of fixes for rc3, Exynos fixes for using monotonic timestamps, register definitions and removal of unused file ipu-v3 - minor changes, make some register arrays const+static, fix some leaks meson: fix for vsync atomic: fix for memory leak EDID parser: add quirks for some more

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

Hi Khalid, I love your patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on v4.16-rc2] [cannot apply to next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

Hi Khalid, I love your patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on v4.16-rc2] [cannot apply to next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] tee: correct max value for id allocation

Hi Jens, Any comments on this patch? Thanks, Peng On Mon, Jan 15, 2018 at 05:27:35PM +0800, Peng Fan wrote: >The privileged dev id range is [TEE_NUM_DEVICES / 2, TEE_NUM_DEVICES). >The non-privileged dev id range is [0, TEE_NUM_DEVICES / 2). > >So when finding a slot for them, need to use

Re: [PATCH] tee: correct max value for id allocation

Hi Jens, Any comments on this patch? Thanks, Peng On Mon, Jan 15, 2018 at 05:27:35PM +0800, Peng Fan wrote: >The privileged dev id range is [TEE_NUM_DEVICES / 2, TEE_NUM_DEVICES). >The non-privileged dev id range is [0, TEE_NUM_DEVICES / 2). > >So when finding a slot for them, need to use

[PATCH] x86/intel_rdt: Fix incorrect returned value when creating rdgroup sub-directory in resctrl file system

From: Wang Hui If no monitoring feature is detected because all monitoring features are disabled during boot time or there is no monitoring feature in hardware, creating rdtgroup sub-directory by "mkdir" command reports error: #mkdir /sys/fs/resctrl/p1 mkdir: cannot

[PATCH] x86/intel_rdt: Fix incorrect returned value when creating rdgroup sub-directory in resctrl file system

From: Wang Hui If no monitoring feature is detected because all monitoring features are disabled during boot time or there is no monitoring feature in hardware, creating rdtgroup sub-directory by "mkdir" command reports error: #mkdir /sys/fs/resctrl/p1 mkdir: cannot create directory

Re: [PATCH v2 3/3] mm/sparse: Optimize memmap allocation during sparse_init()

On 02/22/18 at 02:22pm, Dave Hansen wrote: > First of all, this is a much-improved changelog. Thanks for that! > > On 02/22/2018 01:11 AM, Baoquan He wrote: > > In sparse_init(), two temporary pointer arrays, usemap_map and map_map > > are allocated with the size of NR_MEM_SECTIONS. They are

Re: [PATCH v2 3/3] mm/sparse: Optimize memmap allocation during sparse_init()

On 02/22/18 at 02:22pm, Dave Hansen wrote: > First of all, this is a much-improved changelog. Thanks for that! > > On 02/22/2018 01:11 AM, Baoquan He wrote: > > In sparse_init(), two temporary pointer arrays, usemap_map and map_map > > are allocated with the size of NR_MEM_SECTIONS. They are

Re: [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

On 2/21/2018 6:48 PM, Stanislav Nijnikov wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Asutosh Das Sent: Wednesday, February 21, 2018 6:57 AM To: subha...@codeaurora.org; c...@codeaurora.org;

Re: [PATCH 5/9] scsi: ufs: add reference counting for scsi block requests

On 2/21/2018 6:48 PM, Stanislav Nijnikov wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Asutosh Das Sent: Wednesday, February 21, 2018 6:57 AM To: subha...@codeaurora.org; c...@codeaurora.org;

linux-next: manual merge of the staging tree with Linus' tree

Hi Greg, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/fsl-mc/bus/Kconfig between commit: 02b7b2844c2f ("staging: fsl-mc: fix build testing on x86") from Linus' tree and commit: 6bd067c48efe ("staging: fsl-mc: Move core bus out of staging") from the

linux-next: manual merge of the staging tree with Linus' tree

Hi Greg, Today's linux-next merge of the staging tree got a conflict in: drivers/staging/fsl-mc/bus/Kconfig between commit: 02b7b2844c2f ("staging: fsl-mc: fix build testing on x86") from Linus' tree and commit: 6bd067c48efe ("staging: fsl-mc: Move core bus out of staging") from the

Re: [PATCH 0/7] drm/virtio: Checkpatch cleanup for virtio

Patches 1 to 7 are: Reviewed-by: Gurchetan Singh On Thu, Feb 22, 2018 at 3:59 PM, Rodrigo Siqueira wrote: > This patchset fixes warnings and errors found by checkpatch.pl in the > drm/virtio: > > * Removes return from void function; >

Re: [PATCH 0/7] drm/virtio: Checkpatch cleanup for virtio

Patches 1 to 7 are: Reviewed-by: Gurchetan Singh On Thu, Feb 22, 2018 at 3:59 PM, Rodrigo Siqueira wrote: > This patchset fixes warnings and errors found by checkpatch.pl in the > drm/virtio: > > * Removes return from void function; > * Adds */ in block comments to separate line; > * Adds

Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

On Fri, Feb 23, 2018 at 12:50:23AM +0100, John Ogness wrote: > static struct dentry *dentry_kill(struct dentry *dentry) > __releases(dentry->d_lock) > { > - struct inode *inode = dentry->d_inode; > - struct dentry *parent = NULL; > + int saved_count = dentry->d_lockref.count;

Re: [PATCH v2 4/6] fs/dcache: Avoid the try_lock loops in dentry_kill()

On Fri, Feb 23, 2018 at 12:50:23AM +0100, John Ogness wrote: > static struct dentry *dentry_kill(struct dentry *dentry) > __releases(dentry->d_lock) > { > - struct inode *inode = dentry->d_inode; > - struct dentry *parent = NULL; > + int saved_count = dentry->d_lockref.count;

Re: [PATCH] cpufreq: mediatek: Convert pr_warn() to pr_debug()

On Thu, 2018-02-22 at 11:26 +0530, Viresh Kumar wrote: > With multi-platform build images, this shows a message on non mediatek > platforms, which is unnecessary. Convert pr_warn() to pr_debug() here. > > Signed-off-by: Viresh Kumar > --- >

Re: [PATCH] cpufreq: mediatek: Convert pr_warn() to pr_debug()

On Thu, 2018-02-22 at 11:26 +0530, Viresh Kumar wrote: > With multi-platform build images, this shows a message on non mediatek > platforms, which is unnecessary. Convert pr_warn() to pr_debug() here. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/mediatek-cpufreq.c | 2 +- > 1 file

Re: [PATCH 00/11] KASan for arm

On 2018/2/14 2:41 AM, Florian Fainelli [f.faine...@gmail.com] wrote: >Hi Abbott, > >Are you planning on picking up these patches and sending a second >version? I would be more than happy to provide test results once you >have something, this is very useful, thank you! >-- >Florian I'm sorry to

Re: [PATCH 00/11] KASan for arm

On 2018/2/14 2:41 AM, Florian Fainelli [f.faine...@gmail.com] wrote: >Hi Abbott, > >Are you planning on picking up these patches and sending a second >version? I would be more than happy to provide test results once you >have something, this is very useful, thank you! >-- >Florian I'm sorry to

[rcu:rcu/dev 27/27] kernel/rcu/tree_exp.h:461:16: error: implicit declaration of function 'ACCESS_ONCE'; did you mean '__READ_ONCE'?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev head: a57af56830b510f3dae7fa26313058c192f38f94 commit: a57af56830b510f3dae7fa26313058c192f38f94 [27/27] rcu: Parallelize expedited grace-period initialization config: i386-randconfig-x004-201807 (attached as

[rcu:rcu/dev 27/27] kernel/rcu/tree_exp.h:461:16: error: implicit declaration of function 'ACCESS_ONCE'; did you mean '__READ_ONCE'?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev head: a57af56830b510f3dae7fa26313058c192f38f94 commit: a57af56830b510f3dae7fa26313058c192f38f94 [27/27] rcu: Parallelize expedited grace-period initialization config: i386-randconfig-x004-201807 (attached as

linux-next: manual merge of the kvms390 tree with the nds32 tree

Hi all, Today's linux-next merge of the kvms390 tree got a conflict in: drivers/video/console/Kconfig between commit: 2312dbf7462b ("drivers/video/concole: add negative dependency for VGA_CONSOLE on nds32") from the nds32 tree and commit: 2f1ca75f69f3 ("s390/setup : enable display

linux-next: manual merge of the kvms390 tree with the nds32 tree

Hi all, Today's linux-next merge of the kvms390 tree got a conflict in: drivers/video/console/Kconfig between commit: 2312dbf7462b ("drivers/video/concole: add negative dependency for VGA_CONSOLE on nds32") from the nds32 tree and commit: 2f1ca75f69f3 ("s390/setup : enable display

Re: [PATCH v2 3/6] fs/dcache: Avoid the try_lock loop in d_delete()

On Fri, Feb 23, 2018 at 12:50:22AM +0100, John Ogness wrote: > The trylock loop can be avoided with functionality similar to > lock_parent(). The fast path tries the trylock first, which is likely > to succeed. In the contended case it attempts locking in the correct > order. This requires to

Re: [PATCH v2 3/6] fs/dcache: Avoid the try_lock loop in d_delete()

On Fri, Feb 23, 2018 at 12:50:22AM +0100, John Ogness wrote: > The trylock loop can be avoided with functionality similar to > lock_parent(). The fast path tries the trylock first, which is likely > to succeed. In the contended case it attempts locking in the correct > order. This requires to

Re: [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page

Hi KarimAllah, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/auto-latest] [also build test WARNING on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH 03/10] X86/nVMX: Update the PML table without mapping and unmapping the page

Hi KarimAllah, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/auto-latest] [also build test WARNING on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

On 2018年02月23日 01:46, Jesper Dangaard Brouer wrote: On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

On 2018年02月23日 01:46, Jesper Dangaard Brouer wrote: On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds

Re: [PATCH] srcu: remove never used variable

Thanks Paul's encouragement, I will keep studying SRCU code. On Fri, Feb 23, 2018 at 9:20 AM, Paul E. McKenney wrote: > On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: >> Thanks Paul for reviewing > > And thank you for your interest in SRCU! I am pretty

Re: [PATCH] srcu: remove never used variable

Thanks Paul's encouragement, I will keep studying SRCU code. On Fri, Feb 23, 2018 at 9:20 AM, Paul E. McKenney wrote: > On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: >> Thanks Paul for reviewing > > And thank you for your interest in SRCU! I am pretty sure that other > bugs still

Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

> From: Xiaofei Tan > > For some new boards with hip07 chipset we are required to > set PHY config registers differently. The hw property which > determines how to set these registers is in the PHY signal > attenuation readings. > > This patch add an devicetree property,

Re: [PATCH 1/8] dt-bindings: scsi: hisi_sas: add an property of signal attenuation

> From: Xiaofei Tan > > For some new boards with hip07 chipset we are required to > set PHY config registers differently. The hw property which > determines how to set these registers is in the PHY signal > attenuation readings. > > This patch add an devicetree property, signal-attenuation,

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

On 2018-02-23 08:11, Andrew Jeffery wrote: Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

On 2018-02-23 08:11, Andrew Jeffery wrote: Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

On Thu, Feb 15, 2018 at 04:46:44AM -0800, Matthew Wilcox wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

On Thu, Feb 15, 2018 at 04:46:44AM -0800, Matthew Wilcox wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

Hi Alexey, On 2018/2/23 3:45, Alexey Roslyakov wrote: cur_slot and num_slots has been removed from struct dw_mci in 42f989c002f2. Unfortunately, inline documentation was not updated so far. Fix @lock field documentation in Locking section. Move @mrq field of struct dw_mci_slot mention closer

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

Hi Alexey, On 2018/2/23 3:45, Alexey Roslyakov wrote: cur_slot and num_slots has been removed from struct dw_mci in 42f989c002f2. Unfortunately, inline documentation was not updated so far. Fix @lock field documentation in Locking section. Move @mrq field of struct dw_mci_slot mention closer

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

On Thu, Feb 15, 2018 at 12:06:08PM +, Mel Gorman wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is

Re: [PATCH v2 1/2] free_pcppages_bulk: do not hold lock when picking pages to free

On Thu, Feb 15, 2018 at 12:06:08PM +, Mel Gorman wrote: > On Thu, Jan 25, 2018 at 03:21:44PM +0800, Aaron Lu wrote: > > When freeing a batch of pages from Per-CPU-Pages(PCP) back to buddy, > > the zone->lock is held and then pages are chosen from PCP's migratetype > > list. While there is

[PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case.

Changed a variable name from camel to snake case to fix a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/hci_packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/hci_packet.h

[PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Since the testing for host endianness and in-driver conversion were removed in 77e8a50149a2, the gdm_endian struct contains only one member, and can therefore be simplified to a single u8 variable. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_endian.c | 24

[PATCH 2/4] Staging: gdm724x: hci: Changed camel-case to snake-case.

Changed a variable name from camel to snake case to fix a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/hci_packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h

[PATCH 3/4] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Since the testing for host endianness and in-driver conversion were removed in 77e8a50149a2, the gdm_endian struct contains only one member, and can therefore be simplified to a single u8 variable. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_endian.c | 24

[PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table().

Mostly this change just reverses the primary conditional so most of the code can be pulled back a tab, which fixes some code style warnings. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 22 +++--- 1 file changed, 11 insertions(+),

[PATCH 4/4] Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table().

Mostly this change just reverses the primary conditional so most of the code can be pulled back a tab, which fixes some code style warnings. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

[rcu] 11d88c8120: general_protection_fault:#[##]

FYI, we noticed the following commit (built with gcc-7): commit: 11d88c812043b17c016b8dbe931244f74f082281 ("rcu: Parallelize expedited grace-period initialization") https://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git rcu/dev in testcase: boot on test machine: qemu-system-x86_64

[rcu] 11d88c8120: general_protection_fault:#[##]

FYI, we noticed the following commit (built with gcc-7): commit: 11d88c812043b17c016b8dbe931244f74f082281 ("rcu: Parallelize expedited grace-period initialization") https://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git rcu/dev in testcase: boot on test machine: qemu-system-x86_64

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches wrote: > On Fri, 2018-02-16 at 21:22 +0100, Ulf Magnusson wrote: >> Hello, >> >> This patchset contains some improvements for the Kconfig help text check in >> scripts/checkconfig.pl: > > Seems sensible enough to me. > Signed-off-by:

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches wrote: > On Fri, 2018-02-16 at 21:22 +0100, Ulf Magnusson wrote: >> Hello, >> >> This patchset contains some improvements for the Kconfig help text check in >> scripts/checkconfig.pl: > > Seems sensible enough to me. > Signed-off-by: Joe Perches

[PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses.

Fix lines with a trailing open parenthesis, which is a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git

[PATCH 1/4] Staging: gdm724x: LTE: Fix trailing open parentheses.

Fix lines with a trailing open parenthesis, which is a coding style issue. Signed-off-by: Quytelda Kahja --- drivers/staging/gdm724x/gdm_lte.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_lte.c

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH 04/10] KVM: Introduce a new guest mapping API

Hi KarimAllah, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/auto-latest] [also build test ERROR on v4.16-rc2 next-20180222] [cannot apply to kvm/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [PATCH] srcu: remove never used variable

On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: > Thanks Paul for reviewing And thank you for your interest in SRCU! I am pretty sure that other bugs still remain. ;-) Thanx, Paul > Cheers > Zhouyi > > On Friday, February

Re: [PATCH] srcu: remove never used variable

On Fri, Feb 23, 2018 at 09:04:05AM +0800, Zhouyi Zhou wrote: > Thanks Paul for reviewing And thank you for your interest in SRCU! I am pretty sure that other bugs still remain. ;-) Thanx, Paul > Cheers > Zhouyi > > On Friday, February

[PATCH v2 2/2] ASoC: support ROHM BD28623 codec

This patch adds support of the ROHM BD28623MUV Class D speaker amplifier for Flat-panel TVs. This IC delivers an output power of 20W + 20W. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Fix lisence comment style - Use _cansleep() version for

[PATCH v2 2/2] ASoC: support ROHM BD28623 codec

This patch adds support of the ROHM BD28623MUV Class D speaker amplifier for Flat-panel TVs. This IC delivers an output power of 20W + 20W. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Fix lisence comment style - Use _cansleep() version for manipulating GPIO - Use ASoC component

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

On Sun, Feb 18, 2018 at 08:55:09PM +0100, Michał Kępień wrote: > > To avoid just having to review everything again in a few months ;-) I've > > queued > > up patches 1-5. I'll await comments to 6 and a respin of 7 based on > > feedback. > > Thanks, I think I will post v2 of the entire series

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

On Sun, Feb 18, 2018 at 08:55:09PM +0100, Michał Kępień wrote: > > To avoid just having to review everything again in a few months ;-) I've > > queued > > up patches 1-5. I'll await comments to 6 and a respin of 7 based on > > feedback. > > Thanks, I think I will post v2 of the entire series

[PATCH v2 0/2] ASoC: add support for ROHM BD28623 codec

This patch adds support for ROHM BD28623MUV class D speaker amplifier codec driver. This driver only refers information of HW specification document that can be derivered at website of ROHM. http://www.rohm.com/web/global/products/-/product/BD28623MUV --- Changes in v2: - Change gpio

[PATCH v2 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

This patch adds DT bindings documentation for ROHM BD28623MUV class D speaker amplifier. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Change gpio properties to optional - Change VCCA, VCCP-supply to mandatory ---

[PATCH v2 0/2] ASoC: add support for ROHM BD28623 codec

This patch adds support for ROHM BD28623MUV class D speaker amplifier codec driver. This driver only refers information of HW specification document that can be derivered at website of ROHM. http://www.rohm.com/web/global/products/-/product/BD28623MUV --- Changes in v2: - Change gpio

[PATCH v2 1/2] ASoC: add DT bindings documentation for ROHM BD28623 codec

This patch adds DT bindings documentation for ROHM BD28623MUV class D speaker amplifier. Signed-off-by: Katsuhiro Suzuki --- Changes in v2: - Change gpio properties to optional - Change VCCA, VCCP-supply to mandatory --- .../devicetree/bindings/sound/rohm,bd28623.txt | 29

Re: [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Sorry, it depends on the several patches I submitted earlier in that email thread, since they were in response to several suggestions for earlier patches. I will resend all of the patches in that thread as a consecutive patch series in response to this email to minimize confusion. Thank you,

Re: [PATCH 1/2] Staging: gdm724x: Simplify the struct gdm_endian to a variable.

Sorry, it depends on the several patches I submitted earlier in that email thread, since they were in response to several suggestions for earlier patches. I will resend all of the patches in that thread as a consecutive patch series in response to this email to minimize confusion. Thank you,

Re: [PATCH] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

Hi Evgeniy, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

Hi Evgeniy, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Proposal - how to make usbip more resistant to misconfiguration

Hi, I have found that the https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891036 is not the only one related to misconfiguration of the usbip driver and tools. A few weeks ago the similar bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878866 was discovered. It seems that the

Proposal - how to make usbip more resistant to misconfiguration

Hi, I have found that the https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891036 is not the only one related to misconfiguration of the usbip driver and tools. A few weeks ago the similar bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878866 was discovered. It seems that the

Re: [PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

On Thu, Feb 22, 2018 at 9:22 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 22 Feb 2018 21:45:47 +0100 > > Some local variables will be set to an appropriate value before usage. > Thus omit explicit initialisations

Re: [PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

On Thu, Feb 22, 2018 at 9:22 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 22 Feb 2018 21:45:47 +0100 > > Some local variables will be set to an appropriate value before usage. > Thus omit explicit initialisations at the beginning of these functions. > > Signed-off-by: Markus

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: > I only really posted this as a demo of a fix. I was hoping someone who > actually knows what they're doing in the kernel would pick it up and make it > proper. Whoops, sorry, I didn't realize that. But I don't see a problem with

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: > I only really posted this as a demo of a fix. I was hoping someone who > actually knows what they're doing in the kernel would pick it up and make it > proper. Whoops, sorry, I didn't realize that. But I don't see a problem with

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

> On 19 Feb 2018, at 12:39, Michal Hocko wrote: > > On Mon 19-02-18 12:14:26, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 08:26, Michal Hocko wrote: >>> >>> On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: From: "Robert M. Harris"

Re: [PATCH 1/1] mm, compaction: correct the bounds of __fragmentation_index()

> On 19 Feb 2018, at 12:39, Michal Hocko wrote: > > On Mon 19-02-18 12:14:26, Robert Harris wrote: >> >> >>> On 19 Feb 2018, at 08:26, Michal Hocko wrote: >>> >>> On Sun 18-02-18 16:47:55, robert.m.har...@oracle.com wrote: From: "Robert M. Harris" __fragmentation_index()

[PATCH] MIPS: boot: Define __ASSEMBLY__ for its.S build

The MIPS %.its.S compiler command did not define __ASSEMBLY__, which meant when compiler_types.h was added to kconfig.h, unexpected things appeared (e.g. struct declarations) which should not have been present. As done in the general %.S compiler command, __ASSEMBLY__ is now included here too.

[PATCH] MIPS: boot: Define __ASSEMBLY__ for its.S build

The MIPS %.its.S compiler command did not define __ASSEMBLY__, which meant when compiler_types.h was added to kconfig.h, unexpected things appeared (e.g. struct declarations) which should not have been present. As done in the general %.S compiler command, __ASSEMBLY__ is now included here too.

Re: [PATCH v2 0/6] fs/dcache: avoid trylock loops

On Thu, Feb 22, 2018 at 3:50 PM, John Ogness wrote: > > This patchset removes all trylock loops from within the dcache code. I'm not hating it. It may be because I got used (resigned?) to this from the discussion around the previous version. But it looks ok to me.

Re: [PATCH v2 0/6] fs/dcache: avoid trylock loops

On Thu, Feb 22, 2018 at 3:50 PM, John Ogness wrote: > > This patchset removes all trylock loops from within the dcache code. I'm not hating it. It may be because I got used (resigned?) to this from the discussion around the previous version. But it looks ok to me. But this is very much an area

Re: [PATCH] riscv: Implement free_initrd_mem.

On Tue, 20 Feb 2018 05:50:43 PST (-0800), s...@shealevy.com wrote: Signed-off-by: Shea Levy --- arch/riscv/mm/init.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index c77df8142be2..1c832b541e95 100644 ---

Re: [PATCH] riscv: Implement free_initrd_mem.

On Tue, 20 Feb 2018 05:50:43 PST (-0800), s...@shealevy.com wrote: Signed-off-by: Shea Levy --- arch/riscv/mm/init.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index c77df8142be2..1c832b541e95 100644 --- a/arch/riscv/mm/init.c +++

Re: [GIT PULL] SCSI fixes for 4.16-rc2

On Thu, Feb 22, 2018 at 11:28 AM, James Bottomley wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes When I pull that, I get something completely different from what you claim I should get. Much bigger, and a lot more commits.

Re: [GIT PULL] SCSI fixes for 4.16-rc2

On Thu, Feb 22, 2018 at 11:28 AM, James Bottomley wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes When I pull that, I get something completely different from what you claim I should get. Much bigger, and a lot more commits. Hmm? Dropped. Linus

Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is > correct) to get rid of DTC warnings like: > > arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg): > Node /soc/amba/pdma@1268 simple-bus

Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Fix the unit addresses of PDMA nodes in Exynos5410 (the reg property is > correct) to get rid of DTC warnings like: > > arch/arm/boot/dts/exynos5410-odroidxu.dtb: Warning (simple_bus_reg): > Node /soc/amba/pdma@1268 simple-bus

Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Typo in unit address of PPMU ACP caused DTC warnings: > > arch/arm/boot/dts/exynos4412-odroidu3.dtb: > Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae simple-bus unit > address format error, expected "106e" > > PPMU ACP

Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

On 2018년 02월 23일 04:11, Krzysztof Kozlowski wrote: > Typo in unit address of PPMU ACP caused DTC warnings: > > arch/arm/boot/dts/exynos4412-odroidu3.dtb: > Warning (simple_bus_reg): Node /soc/ppmu_acp@10ae simple-bus unit > address format error, expected "106e" > > PPMU ACP

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes

<    1   2   3   4   5   6   7   8   9   10   >