Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros

2018-03-24 Thread Larry Finger
On 03/23/2018 01:00 PM, Colin King wrote: From: Colin Ian King The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain typos and don't match the #if guard check. Defined them correctly. Cleans up clang warnings: warning: '__PHYDMKFREE_H__' is used as a

Re: [PATCH][next][V2] staging: r8822be: fix typos in header guard macros

2018-03-24 Thread Larry Finger
On 03/23/2018 01:00 PM, Colin King wrote: From: Colin Ian King The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain typos and don't match the #if guard check. Defined them correctly. Cleans up clang warnings: warning: '__PHYDMKFREE_H__' is used as a header guard here, followed by

Re: [PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

2018-03-24 Thread Larry Finger
On 03/23/2018 11:10 PM, Quytelda Kahja wrote: It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, bitshifting integers by 0 does nothing,

Re: [PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

2018-03-24 Thread Larry Finger
On 03/23/2018 11:10 PM, Quytelda Kahja wrote: It is neater and more consistent with the rest of the document to use the BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, bitshifting integers by 0 does nothing,

[PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

2018-03-24 Thread Pawel Dembicki
BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. The USB id is added to qmi_wwan.c to allow QMI communication with the BM806U. Tested on 4.14 kernel and OpenWRT. Signed-off-by: Pawel Dembicki ---

[PATCH] net: qmi_wwan: add BroadMobi BM806U 2020:2033

2018-03-24 Thread Pawel Dembicki
BroadMobi BM806U is an Qualcomm MDM9225 based 3G/4G modem. Tested hardware BM806U is mounted on D-Link DWR-921-C3 router. The USB id is added to qmi_wwan.c to allow QMI communication with the BM806U. Tested on 4.14 kernel and OpenWRT. Signed-off-by: Pawel Dembicki ---

[PATCH v2 5/8] cgroup: Factor out and expose cgroup_rstat_*() interface functions

2018-03-24 Thread Tejun Heo
>From 6139f87ac4a5650fed5c8be5611becbce96d7f1c Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Sat, 24 Mar 2018 13:39:36 -0700 cgroup_rstat is being generalized so that controllers can use it too. This patch factors out and exposes the following interface functions. *

[PATCH v2 5/8] cgroup: Factor out and expose cgroup_rstat_*() interface functions

2018-03-24 Thread Tejun Heo
>From 6139f87ac4a5650fed5c8be5611becbce96d7f1c Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Sat, 24 Mar 2018 13:39:36 -0700 cgroup_rstat is being generalized so that controllers can use it too. This patch factors out and exposes the following interface functions. * cgroup_rstat_updated():

Re: [PATCH 10/10] mm: Clear shrinker bit if there are no objects related to memcg

2018-03-24 Thread Vladimir Davydov
On Wed, Mar 21, 2018 at 04:23:01PM +0300, Kirill Tkhai wrote: > To avoid further unneed calls of do_shrink_slab() > for shrinkers, which already do not have any charged > objects in a memcg, their bits have to be cleared. > > This patch introduces new return value SHRINK_EMPTY, > which will be

Re: [PATCH 10/10] mm: Clear shrinker bit if there are no objects related to memcg

2018-03-24 Thread Vladimir Davydov
On Wed, Mar 21, 2018 at 04:23:01PM +0300, Kirill Tkhai wrote: > To avoid further unneed calls of do_shrink_slab() > for shrinkers, which already do not have any charged > objects in a memcg, their bits have to be cleared. > > This patch introduces new return value SHRINK_EMPTY, > which will be

[PATCH] sysctl: fix sizeof argument to match variable name

2018-03-24 Thread Randy Dunlap
From: Randy Dunlap Fix sizeof argument to be the same as the data variable name. Probably a copy/paste error. Mostly harmless since both variables are unsigned int. Fixes kernel bugzilla #197371: Possible access to unintended variable in "kernel/sysctl.c" line 1339

[PATCH] sysctl: fix sizeof argument to match variable name

2018-03-24 Thread Randy Dunlap
From: Randy Dunlap Fix sizeof argument to be the same as the data variable name. Probably a copy/paste error. Mostly harmless since both variables are unsigned int. Fixes kernel bugzilla #197371: Possible access to unintended variable in "kernel/sysctl.c" line 1339

[PATCH 03/44] perf annotate: Move cycles/IPC formatting width constants outside TUI

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo These will be used in --stdio2 so lets move it first to reduce noise in the following patches. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao

[PATCH 03/44] perf annotate: Move cycles/IPC formatting width constants outside TUI

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo These will be used in --stdio2 so lets move it first to reduce noise in the following patches. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[GIT PULL 00/44] perf/core improvements and fixes

2018-03-24 Thread Arnaldo Carvalho de Melo
Hi Ingo, Mostly a 'perf annotate' refactoring to allow reusing the TUI formatting routines in a --stdio2 mode for 'perf annotate' that at some point should replace --stdio, leaving that old code deprecated for a while, then ditching it. That will take a while yet because there is

[GIT PULL 00/44] perf/core improvements and fixes

2018-03-24 Thread Arnaldo Carvalho de Melo
Hi Ingo, Mostly a 'perf annotate' refactoring to allow reusing the TUI formatting routines in a --stdio2 mode for 'perf annotate' that at some point should replace --stdio, leaving that old code deprecated for a while, then ditching it. That will take a while yet because there is

[PATCH 09/44] perf annotate: Stop using a global config struct

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the TUI, that is interactive, its interesting to have a configuration that one can go on changing and then when moving from one symbol annotation to another symbol, the options set while browsing the first symbol to be kept. But since we're

[PATCH 07/44] perf annotate: Move compute_ipc() to annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI code, as it has nothing specific to that UI and should be used in the other output modes as well. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao

[PATCH 09/44] perf annotate: Stop using a global config struct

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the TUI, that is interactive, its interesting to have a configuration that one can go on changing and then when moving from one symbol annotation to another symbol, the options set while browsing the first symbol to be kept. But since we're trying to make this

[PATCH 07/44] perf annotate: Move compute_ipc() to annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI code, as it has nothing specific to that UI and should be used in the other output modes as well. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 08/44] perf annotate: Move nr_events from annotate_browser to annotation struct

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Paving the way to move more stuff out of TUI and into the generic annotation library. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc:

[PATCH 08/44] perf annotate: Move nr_events from annotate_browser to annotation struct

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Paving the way to move more stuff out of TUI and into the generic annotation library. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 10/44] perf annotate: Move pcnt_with() to the annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI code, since now all it touches is what is in 'struct annotation'. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri

[PATCH 10/44] perf annotate: Move pcnt_with() to the annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI code, since now all it touches is what is in 'struct annotation'. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

Re: [PATCH v3 1/4] bus: fsl-mc: move fsl_mc_command struct in a uapi header

2018-03-24 Thread kbuild test robot
Hi Ioana, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [cannot apply to linus/master v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 1/4] bus: fsl-mc: move fsl_mc_command struct in a uapi header

2018-03-24 Thread kbuild test robot
Hi Ioana, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [cannot apply to linus/master v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 12/44] perf annotate: Move max_jump_sources to struct annotation

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This is not useful only for the TUI, we'll want to somehow mark the --stdio2 lines with the most jump sources too. And moving this will allow us to change some function signatures from annotate_browser to ui_browser, reducing boilerplate. Cc:

[PATCH 11/44] perf annotate tui: Add browser__annotation() helper

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To reduce the boilerplate to get to the symbol being annotated from the struct browser ->priv area. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao

[PATCH 13/44] perf annotate: Move jumps_percent_color to ui_browser

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Since all it needs is in ui_browser and annotation structs members. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa

[PATCH 12/44] perf annotate: Move max_jump_sources to struct annotation

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This is not useful only for the TUI, we'll want to somehow mark the --stdio2 lines with the most jump sources too. And moving this will allow us to change some function signatures from annotate_browser to ui_browser, reducing boilerplate. Cc: Adrian Hunter Cc:

[PATCH 11/44] perf annotate tui: Add browser__annotation() helper

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To reduce the boilerplate to get to the symbol being annotated from the struct browser ->priv area. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 13/44] perf annotate: Move jumps_percent_color to ui_browser

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Since all it needs is in ui_browser and annotation structs members. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-9f8c2f9aetbibcw33d615...@git.kernel.org

[PATCH 15/44] perf annotate: Move mark_jump_targets from the TUI to the annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This also is not TUI specific, should be used in the upcoming --stdio2 mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa

[PATCH 16/44] perf annotate: Nuke struct browser_line

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The information in there are all related to things already moved to struct annotation, so move those members to struct annotation_line. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern

[PATCH 15/44] perf annotate: Move mark_jump_targets from the TUI to the annotation library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This also is not TUI specific, should be used in the upcoming --stdio2 mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-v827xec8z3hxrmgp7bwa6...@git.kernel.org

[PATCH 16/44] perf annotate: Nuke struct browser_line

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The information in there are all related to things already moved to struct annotation, so move those members to struct annotation_line. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 19/44] perf annotate: Introduce set_offsets() method out of TUI code

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo More non-strictly TUI code being moved to the UI neutral annotation library, to be used in the upcoming --stdio2 output mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc:

[PATCH 19/44] perf annotate: Introduce set_offsets() method out of TUI code

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo More non-strictly TUI code being moved to the UI neutral annotation library, to be used in the upcoming --stdio2 output mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 21/44] perf annotate: Move update_column_widths() to the generic lib

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Previous patch left it where it was to ease review, move it to its right place. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri

Re: [PATCH 09/10] mm: Iterate only over charged shrinkers during memcg shrink_slab()

2018-03-24 Thread Vladimir Davydov
On Wed, Mar 21, 2018 at 04:22:51PM +0300, Kirill Tkhai wrote: > Using the preparations made in previous patches, in case of memcg > shrink, we may avoid shrinkers, which are not set in memcg's shrinkers > bitmap. To do that, we separate iterations over memcg-aware and > !memcg-aware shrinkers, and

[PATCH 21/44] perf annotate: Move update_column_widths() to the generic lib

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Previous patch left it where it was to ease review, move it to its right place. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

Re: [PATCH 09/10] mm: Iterate only over charged shrinkers during memcg shrink_slab()

2018-03-24 Thread Vladimir Davydov
On Wed, Mar 21, 2018 at 04:22:51PM +0300, Kirill Tkhai wrote: > Using the preparations made in previous patches, in case of memcg > shrink, we may avoid shrinkers, which are not set in memcg's shrinkers > bitmap. To do that, we separate iterations over memcg-aware and > !memcg-aware shrinkers, and

[PATCH 20/44] perf annotate: Move the column widths from the TUI to generic lib

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This also will be used in other output formats, such as --stdio2. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa

[PATCH 20/44] perf annotate: Move the column widths from the TUI to generic lib

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This also will be used in other output formats, such as --stdio2. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-86h6ftebc62ij1rx8q9zk...@git.kernel.org

[PATCH 23/44] perf annotate: Introduce symbol__annotate2 method

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo That does all the extended boilerplate the TUI browser did, leaving the symbol__annotate() function to be used by the old --stdio output mode. Now the upcoming --stdio2 output mode should just use this one to set things up. Cc: Adrian Hunter

[PATCH 26/44] perf annotate: Introduce annotation_line__print_start() out of TUI code

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the --tui and --stdio2 cases using callbacks for print() and set_percent_color() end up being the easiest path, real GUI remains as an exercise. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

2018-03-24 Thread LEROY Christophe
Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Some functions prototypes were missing for the non-altivec code. Add the missing prototypes directly in

Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec

2018-03-24 Thread LEROY Christophe
Mathieu Malaterre a écrit : On Fri, Mar 23, 2018 at 1:19 PM, christophe leroy wrote: Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : Some functions prototypes were missing for the non-altivec code. Add the missing prototypes directly in xor_vmx, fix warnings treated as errors with

[PATCH 23/44] perf annotate: Introduce symbol__annotate2 method

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo That does all the extended boilerplate the TUI browser did, leaving the symbol__annotate() function to be used by the old --stdio output mode. Now the upcoming --stdio2 output mode should just use this one to set things up. Cc: Adrian Hunter Cc: Andi Kleen Cc:

[PATCH 26/44] perf annotate: Introduce annotation_line__print_start() out of TUI code

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For the --tui and --stdio2 cases using callbacks for print() and set_percent_color() end up being the easiest path, real GUI remains as an exercise. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan

[PATCH 32/44] perf annotate: Use the default annotation options for --stdio2

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo With an empty '[annotate]' section in ~/.perfconfig: # perf record -a --all-kernel -e '{cycles,instructions}:P' sleep 5 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 2.243 MB perf.data (5513 samples) ] #

[PATCH 28/44] perf annotate: Use a ops table for annotation_line__write()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To simplify the passing of arguments, the --stdio2 code will have to set all the fields with operations printing to stdout. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc:

[PATCH 32/44] perf annotate: Use the default annotation options for --stdio2

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo With an empty '[annotate]' section in ~/.perfconfig: # perf record -a --all-kernel -e '{cycles,instructions}:P' sleep 5 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 2.243 MB perf.data (5513 samples) ] # perf annotate

[PATCH 28/44] perf annotate: Use a ops table for annotation_line__write()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To simplify the passing of arguments, the --stdio2 code will have to set all the fields with operations printing to stdout. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 34/44] perf annotate: Introduce --ignore-vmlinux command line option

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This is already present in 'perf top', albeit undocumented (will fix), and is useful to use /proc/kcore instead of vmlinux and then get what is really in place, not what the kernel starts with, before alternatives, ftrace .text patching, etc, see

[PATCH 34/44] perf annotate: Introduce --ignore-vmlinux command line option

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This is already present in 'perf top', albeit undocumented (will fix), and is useful to use /proc/kcore instead of vmlinux and then get what is really in place, not what the kernel starts with, before alternatives, ftrace .text patching, etc, see the differences:

[PATCH 37/44] perf annotate: No need to calculate notes->start twice

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Since we already set notes->start to map__rip_2objdump(map, sym->start) in symbol__annotate2(), no need to calculate that address again in symbol__calc_lines(), just use notes->start. Cc: Adrian Hunter Cc: Andi Kleen

[PATCH 37/44] perf annotate: No need to calculate notes->start twice

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Since we already set notes->start to map__rip_2objdump(map, sym->start) in symbol__annotate2(), no need to calculate that address again in symbol__calc_lines(), just use notes->start. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa

[PATCH 40/44] perf python: Reference Py_None before returning it

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Petr Machata Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata Acked-by: Jiri Olsa

[PATCH 40/44] perf python: Reference Py_None before returning it

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Petr Machata Python None objects are handled just like all the other objects with respect to their reference counting. Before returning Py_None, its reference count thus needs to be bumped. Signed-off-by: Petr Machata Acked-by: Jiri Olsa Cc: Alexander Shishkin Cc: Namhyung Kim Cc:

[PATCH 0/4] staging: iio: tsl2x7x: move out of staging

2018-03-24 Thread Brian Masney
Here is a patch series to move the tsl2x7x driver out of staging and into mainline. Driver was tested using various TSL2X7X devices on a Raspberry Pi 2. Datasheet for the TSl2772: https://ams.com/eng/content/download/291503/1066377/file/TSL2772_DS000181_2-00.pdf Brian Masney (4): staging: iio:

[PATCH 0/4] staging: iio: tsl2x7x: move out of staging

2018-03-24 Thread Brian Masney
Here is a patch series to move the tsl2x7x driver out of staging and into mainline. Driver was tested using various TSL2X7X devices on a Raspberry Pi 2. Datasheet for the TSl2772: https://ams.com/eng/content/download/291503/1066377/file/TSL2772_DS000181_2-00.pdf Brian Masney (4): staging: iio:

[PATCH 4/4] staging: iio: tsl2x7x: move out of staging

2018-03-24 Thread Brian Masney
Move the tsl2x7x driver out of staging and into mainline. Signed-off-by: Brian Masney --- Note: I intentionally ran git format-patch with --no-renames since Jonathan likes to see the whole files in the email body for staging graduation patches. The #include "tsl2x7x.h"

[PATCH 4/4] staging: iio: tsl2x7x: move out of staging

2018-03-24 Thread Brian Masney
Move the tsl2x7x driver out of staging and into mainline. Signed-off-by: Brian Masney --- Note: I intentionally ran git format-patch with --no-renames since Jonathan likes to see the whole files in the email body for staging graduation patches. The #include "tsl2x7x.h" was changed to #include

[PATCH 2/4] staging: iio: tsl2x7x: move IIO_CHAN_INFO_CALIB{SCALE,BIAS} to IIO_LIGHT channel

2018-03-24 Thread Brian Masney
The IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_CALIBBIAS masks are currently associated with the IIO_INTENSITY channel but should be associated with the IIO_LIGHT channel since these values are used to calculate the lux. Directory listing of the sysfs attributes for a TSL2772 with this patch

[PATCH 2/4] staging: iio: tsl2x7x: move IIO_CHAN_INFO_CALIB{SCALE,BIAS} to IIO_LIGHT channel

2018-03-24 Thread Brian Masney
The IIO_CHAN_INFO_CALIBSCALE and IIO_CHAN_INFO_CALIBBIAS masks are currently associated with the IIO_INTENSITY channel but should be associated with the IIO_LIGHT channel since these values are used to calculate the lux. Directory listing of the sysfs attributes for a TSL2772 with this patch

[PATCH 41/44] perf annotate: Add "_local" to jump/offset validation routines

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because they all really check if we can access data structures/visual constructs where a "jump" instruction targets code in the same function, i.e. things like: __pthread_mutex_lock /usr/lib64/libpthread-2.26.so 1.95 │ mov

[PATCH 41/44] perf annotate: Add "_local" to jump/offset validation routines

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because they all really check if we can access data structures/visual constructs where a "jump" instruction targets code in the same function, i.e. things like: __pthread_mutex_lock /usr/lib64/libpthread-2.26.so 1.95 │ mov

[PATCH 1/4] staging: iio: tsl2x7x: use auto increment I2C protocol

2018-03-24 Thread Brian Masney
The hardware supports 16-bit ALS and proximity readings, however the datasheet recommends using the I2C auto increment protocol so that the correct high and low bytes are read even if the integration cycle ends between reading the lower and upper registers. More information about this protocol can

[PATCH 3/4] staging: iio: tsl2x7x: use either direction for IIO_EV_INFO_{ENABLE,PERIOD}

2018-03-24 Thread Brian Masney
The events IIO_EV_INFO_VALUE and IIO_EV_INFO_ENABLE currently have a falling and rising direction configured. There does not need to be a separate distinction so this patch changes these to use the either direction. Directory listing of event sysfs attributes for a TSL2772 with this patch applied:

[PATCH 1/4] staging: iio: tsl2x7x: use auto increment I2C protocol

2018-03-24 Thread Brian Masney
The hardware supports 16-bit ALS and proximity readings, however the datasheet recommends using the I2C auto increment protocol so that the correct high and low bytes are read even if the integration cycle ends between reading the lower and upper registers. More information about this protocol can

[PATCH 3/4] staging: iio: tsl2x7x: use either direction for IIO_EV_INFO_{ENABLE,PERIOD}

2018-03-24 Thread Brian Masney
The events IIO_EV_INFO_VALUE and IIO_EV_INFO_ENABLE currently have a falling and rising direction configured. There does not need to be a separate distinction so this patch changes these to use the either direction. Directory listing of event sysfs attributes for a TSL2772 with this patch applied:

[PATCH 43/44] perf annotate: Defer searching for comma in raw line till it is needed

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo That strchr() in jump__scnprintf() needs to be nuked somehow, as it, IIRC is already done in jump__parse() and if needed at scnprintf() time, should be stashed in the struct filled in parse() time. For now jus defer it to just before where it is

[PATCH 43/44] perf annotate: Defer searching for comma in raw line till it is needed

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo That strchr() in jump__scnprintf() needs to be nuked somehow, as it, IIRC is already done in jump__parse() and if needed at scnprintf() time, should be stashed in the struct filled in parse() time. For now jus defer it to just before where it is used. Cc: Adrian

[PATCH 39/44] perf annotate: Mark jumps to outher functions with the call arrow

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Things like this in _cpp_lex_token (gcc's cc1 program): cpp_named_operator2name@@Base+0xa72 Point to a place that is after the cpp_named_operator2name boundaries, i.e. in the ELF symbol table for cc1 cpp_named_operator2name is marked as

[PATCH 42/44] perf annotate: Support jumping from one function to another

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For instance: entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux 5.50 │ → callq do_syscall_64 14.56 │ mov0x58(%rsp),%rcx 7.44 │ mov0x80(%rsp),%r11 0.32 │ cmp%rcx,%r11

[PATCH 38/44] perf annotate: Pass function descriptor to its instruction parsing routines

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We need that to figure out if jumps have targets in a different function. E.g. _cpp_lex_token(), in /usr/libexec/gcc/x86_64-redhat-linux/5.3.1/cc1 has a line like this: jnec469be Cc: Adrian Hunter

[PATCH 35/44] perf report: Introduce --ignore-vmlinux command line option

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We've had this in 'perf top' for quite a while, useful if one wishes to force using /proc/kcore to do annotation using the patched kernel instead of the ELF image it started from, aka vmlinux. Cc: Adrian Hunter Cc: Andi

[PATCH 44/44] perf annotate: Use absolute addresses to calculate jump target offsets

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo These types of jumps were confusing the annotate browser: entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux Percent│81a00020: swapgs

[PATCH 44/44] perf annotate: Use absolute addresses to calculate jump target offsets

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo These types of jumps were confusing the annotate browser: entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux Percent│81a00020: swapgs

[PATCH 39/44] perf annotate: Mark jumps to outher functions with the call arrow

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Things like this in _cpp_lex_token (gcc's cc1 program): cpp_named_operator2name@@Base+0xa72 Point to a place that is after the cpp_named_operator2name boundaries, i.e. in the ELF symbol table for cc1 cpp_named_operator2name is marked as being 32-bytes long,

[PATCH 42/44] perf annotate: Support jumping from one function to another

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For instance: entry_SYSCALL_64 /lib/modules/4.16.0-rc5-00086-gdf09348f78dc/build/vmlinux 5.50 │ → callq do_syscall_64 14.56 │ mov0x58(%rsp),%rcx 7.44 │ mov0x80(%rsp),%r11 0.32 │ cmp%rcx,%r11 │ → jne

[PATCH 38/44] perf annotate: Pass function descriptor to its instruction parsing routines

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We need that to figure out if jumps have targets in a different function. E.g. _cpp_lex_token(), in /usr/libexec/gcc/x86_64-redhat-linux/5.3.1/cc1 has a line like this: jnec469be Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc:

[PATCH 35/44] perf report: Introduce --ignore-vmlinux command line option

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We've had this in 'perf top' for quite a while, useful if one wishes to force using /proc/kcore to do annotation using the patched kernel instead of the ELF image it started from, aka vmlinux. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc:

[PATCH 36/44] perf annotate browser: Add 'P' hotkey to dump annotation to file

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Just like we have in the histograms browser used as the main screen for 'perf top --tui' and 'perf report --tui', to print the current annotation to a file with a named composed by the symbol name and the ".annotation" suffix. Here is one example

[PATCH 36/44] perf annotate browser: Add 'P' hotkey to dump annotation to file

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Just like we have in the histograms browser used as the main screen for 'perf top --tui' and 'perf report --tui', to print the current annotation to a file with a named composed by the symbol name and the ".annotation" suffix. Here is one example of pressing 'A'

[PATCH 30/44] perf annotate: Introduce the --stdio2 output mode

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This uses the TUI augmented formatting routines, modulo interactivity. # perf annotate --ignore-vmlinux --stdio2 _raw_spin_lock_irqsave _raw_spin_lock_irqsave() /proc/kcore Event: cycles:ppp Percent Disassembly of section

[PATCH 29/44] perf annotate: Introduce annotation_line__filter()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI logic that allows toggling the presentation of source code lines. Will be used in the upcoming --stdio2 mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc:

[PATCH 18/44] perf annotate: Move nr_{asm_}entries to struct annotation

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo More non-TUI stuff. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim

[PATCH 31/44] perf annotate: Move the default annotate options to the library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo One more thing that goes from the TUI code to be used more widely, for instance it'll affect the default options used by: perf annotate --stdio2 Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern

[PATCH 30/44] perf annotate: Introduce the --stdio2 output mode

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This uses the TUI augmented formatting routines, modulo interactivity. # perf annotate --ignore-vmlinux --stdio2 _raw_spin_lock_irqsave _raw_spin_lock_irqsave() /proc/kcore Event: cycles:ppp Percent Disassembly of section load0:

[PATCH 29/44] perf annotate: Introduce annotation_line__filter()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Out of the TUI logic that allows toggling the presentation of source code lines. Will be used in the upcoming --stdio2 mode. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 18/44] perf annotate: Move nr_{asm_}entries to struct annotation

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo More non-TUI stuff. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-yd4g6q0rngq4i49hz6iym...@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 31/44] perf annotate: Move the default annotate options to the library

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo One more thing that goes from the TUI code to be used more widely, for instance it'll affect the default options used by: perf annotate --stdio2 Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan

[PATCH 27/44] perf annotate: Finish the generalization of annotate_browser__write()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We pass some more callbacks and all of annotate_browser__write() seems to be free of TUI code (except for some arrow constants, will fix). Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern

[PATCH 33/44] perf annotate: Add function header to --stdio2

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo # perf annotate --stdio2 _raw_spin_lock_irqsave _raw_spin_lock_irqsave() /lib/modules/4.16.0-rc4/build/vmlinux Event: anon group { cycles, instructions } 0.00 3.17 → callq __fentry__ 0.00 7.94push %rbx 7.69

[PATCH 25/44] perf ui browser: Add vprintf() method

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We'll need it for some callbacks for the upcoming annotation__line_print() routines. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc:

[PATCH 27/44] perf annotate: Finish the generalization of annotate_browser__write()

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We pass some more callbacks and all of annotate_browser__write() seems to be free of TUI code (except for some arrow constants, will fix). Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

[PATCH 33/44] perf annotate: Add function header to --stdio2

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo # perf annotate --stdio2 _raw_spin_lock_irqsave _raw_spin_lock_irqsave() /lib/modules/4.16.0-rc4/build/vmlinux Event: anon group { cycles, instructions } 0.00 3.17 → callq __fentry__ 0.00 7.94push %rbx 7.69 36.51 → callq

[PATCH 25/44] perf ui browser: Add vprintf() method

2018-03-24 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We'll need it for some callbacks for the upcoming annotation__line_print() routines. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jin Yao Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link:

<    1   2   3   4   5   6   7   >