[PATCH net-next 07/12] rxrpc: Fix checker warnings and errors

Fix various issues detected by checker. Errors: (*) rxrpc_discard_prealloc() should be using rcu_assign_pointer to set call->socket. Warnings: (*) rxrpc_service_connection_reaper() should be passing NULL rather than 0 to trace_rxrpc_conn() as the where argument. (*)

[PATCH net-next 07/12] rxrpc: Fix checker warnings and errors

Fix various issues detected by checker. Errors: (*) rxrpc_discard_prealloc() should be using rcu_assign_pointer to set call->socket. Warnings: (*) rxrpc_service_connection_reaper() should be passing NULL rather than 0 to trace_rxrpc_conn() as the where argument. (*)

[PATCH net-next 06/12] rxrpc: remove unused static variables

From: Sebastian Andrzej Siewior The rxrpc_security_methods and rxrpc_security_sem user has been removed in 648af7fca159 ("rxrpc: Absorb the rxkad security module"). This was noticed by kbuild test robot for the -RT tree but is also true for !RT. Reported-by: kbuild test

[PATCH net-next 06/12] rxrpc: remove unused static variables

From: Sebastian Andrzej Siewior The rxrpc_security_methods and rxrpc_security_sem user has been removed in 648af7fca159 ("rxrpc: Absorb the rxkad security module"). This was noticed by kbuild test robot for the -RT tree but is also true for !RT. Reported-by: kbuild test robot Signed-off-by:

[PATCH net-next 03/12] rxrpc: Fix Tx ring annotation after initial Tx failure

rxrpc calls have a ring of packets that are awaiting ACK or retransmission and a parallel ring of annotations that tracks the state of those packets. If the initial transmission of a packet on the underlying UDP socket fails then the packet annotation is marked for resend - but the setting of this

[PATCH net-next 03/12] rxrpc: Fix Tx ring annotation after initial Tx failure

rxrpc calls have a ring of packets that are awaiting ACK or retransmission and a parallel ring of annotations that tracks the state of those packets. If the initial transmission of a packet on the underlying UDP socket fails then the packet annotation is marked for resend - but the setting of this

[PATCH net-next 02/12] rxrpc: Fix a bit of time confusion

The rxrpc_reduce_call_timer() function should be passed the 'current time' in jiffies, not the current ktime time. It's confusing in rxrpc_resend because that has to deal with both. Pass the correct current time in. Note that this only affects the trace produced and not the functioning of the

[PATCH net-next 05/12] rxrpc: Fix resend event time calculation

From: Marc Dionne Commit a158bdd3 ("rxrpc: Fix call timeouts") reworked the time calculation for the next resend event. For this calculation, "oldest" will be before "now", so ktime_sub(oldest, now) will yield a negative value. When passed to nsecs_to_jiffies which

[PATCH net-next 04/12] rxrpc: Don't treat call aborts as conn aborts

If a call-level abort is received for the previous call to complete on a connection channel, then that abort is queued for the connection processor to handle. Unfortunately, the connection processor then assumes without checking that the abort is connection-level (ie. callNumber is 0) and

[PATCH net-next 05/12] rxrpc: Fix resend event time calculation

From: Marc Dionne Commit a158bdd3 ("rxrpc: Fix call timeouts") reworked the time calculation for the next resend event. For this calculation, "oldest" will be before "now", so ktime_sub(oldest, now) will yield a negative value. When passed to nsecs_to_jiffies which expects an unsigned value,

[PATCH net-next 04/12] rxrpc: Don't treat call aborts as conn aborts

If a call-level abort is received for the previous call to complete on a connection channel, then that abort is queued for the connection processor to handle. Unfortunately, the connection processor then assumes without checking that the abort is connection-level (ie. callNumber is 0) and

[PATCH net-next 02/12] rxrpc: Fix a bit of time confusion

The rxrpc_reduce_call_timer() function should be passed the 'current time' in jiffies, not the current ktime time. It's confusing in rxrpc_resend because that has to deal with both. Pass the correct current time in. Note that this only affects the trace produced and not the functioning of the

[PATCH net-next 00/12] rxrpc: Fixes and more traces

are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-20180330 and can also be found on this branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (10): rxrpc: Fix

[PATCH net-next 01/12] rxrpc: Fix firewall route keepalive

Fix the firewall route keepalive part of AF_RXRPC which is currently function incorrectly by replying to VERSION REPLY packets from the server with VERSION REQUEST packets. Instead, send VERSION REPLY packets to the peers of service connections to act as keep-alives 20s after the latest packet

[PATCH net-next 00/12] rxrpc: Fixes and more traces

are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next-20180330 and can also be found on this branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (10): rxrpc: Fix

[PATCH net-next 01/12] rxrpc: Fix firewall route keepalive

Fix the firewall route keepalive part of AF_RXRPC which is currently function incorrectly by replying to VERSION REPLY packets from the server with VERSION REQUEST packets. Instead, send VERSION REPLY packets to the peers of service connections to act as keep-alives 20s after the latest packet

[PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

From: Tal Gilboa Add pcie_bandwidth_available() to compute the bandwidth available to a device. This may be limited by the device itself or by a slower upstream link leading to the device. The available bandwidth at each link along the path is computed as: link_speed *

[PATCH v5 04/14] PCI: Add pcie_bandwidth_available() to compute bandwidth available to device

From: Tal Gilboa Add pcie_bandwidth_available() to compute the bandwidth available to a device. This may be limited by the device itself or by a slower upstream link leading to the device. The available bandwidth at each link along the path is computed as: link_speed * link_width * (1 -

[PATCH v5 14/14] PCI: Remove unused pcie_get_minimum_link()

From: Bjorn Helgaas In some cases pcie_get_minimum_link() returned misleading information because it found the slowest link and the narrowest link without considering the total bandwidth of the link. For example, if the path contained a 16 GT/s x1 link and a 2.5 GT/s x16

[PATCH v5 14/14] PCI: Remove unused pcie_get_minimum_link()

From: Bjorn Helgaas In some cases pcie_get_minimum_link() returned misleading information because it found the slowest link and the narrowest link without considering the total bandwidth of the link. For example, if the path contained a 16 GT/s x1 link and a 2.5 GT/s x16 link,

[PATCH v5 11/14] cxgb4: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest

[PATCH v5 13/14] ixgbe: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest

[PATCH v5 13/14] ixgbe: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest link without considering

[PATCH v5 11/14] cxgb4: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest link without considering

[PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest

[PATCH v5 12/14] fm10k: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest link without considering

[PATCH v5 10/14] bnxt_en: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest

[PATCH v5 10/14] bnxt_en: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest link without considering

[PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

From: Tal Gilboa Add pcie_print_link_status(). This logs the current settings of the link (speed, width, and total available bandwidth). If the device is capable of more bandwidth but is limited by a slower upstream link, we include information about the link that limits

[PATCH v5 07/14] net/mlx5: Report PCIe link properties with pcie_print_link_status()

From: Tal Gilboa Use pcie_print_link_status() to report PCIe link speed and possible limitations. Signed-off-by: Tal Gilboa [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas Reviewed-by: Tariq Toukan ---

[PATCH v5 05/14] PCI: Add pcie_print_link_status() to log link speed and whether it's limited

From: Tal Gilboa Add pcie_print_link_status(). This logs the current settings of the link (speed, width, and total available bandwidth). If the device is capable of more bandwidth but is limited by a slower upstream link, we include information about the link that limits the device's

[PATCH v5 07/14] net/mlx5: Report PCIe link properties with pcie_print_link_status()

From: Tal Gilboa Use pcie_print_link_status() to report PCIe link speed and possible limitations. Signed-off-by: Tal Gilboa [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas Reviewed-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/main.c |4 1 file changed, 4

[PATCH v5 06/14] net/mlx4_core: Report PCIe link properties with pcie_print_link_status()

From: Tal Gilboa Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Signed-off-by: Tal Gilboa Signed-off-by: Tariq Toukan [bhelgaas: changelog]

[PATCH v5 09/14] bnx2x: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest

[PATCH v5 06/14] net/mlx4_core: Report PCIe link properties with pcie_print_link_status()

From: Tal Gilboa Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Signed-off-by: Tal Gilboa Signed-off-by: Tariq Toukan [bhelgaas: changelog] Signed-off-by: Bjorn Helgaas ---

[PATCH v5 09/14] bnx2x: Report PCIe link properties with pcie_print_link_status()

From: Bjorn Helgaas Use pcie_print_link_status() to report PCIe link speed and possible limitations instead of implementing this in the driver itself. Note that pcie_get_minimum_link() can return misleading information because it finds the slowest link and the narrowest link without considering

[PATCH v5 08/14] net/mlx5e: Use pcie_bandwidth_available() to compute bandwidth

From: Tal Gilboa Use the new pci_bandwidth_available() function to calculate maximum available bandwidth through the PCI chain instead of computing it ourselves with mlx5e_get_pci_bw(). This is used to detect when the device is capable of more bandwidth than is available in

[PATCH v5 08/14] net/mlx5e: Use pcie_bandwidth_available() to compute bandwidth

From: Tal Gilboa Use the new pci_bandwidth_available() function to calculate maximum available bandwidth through the PCI chain instead of computing it ourselves with mlx5e_get_pci_bw(). This is used to detect when the device is capable of more bandwidth than is available in the current slot.

[PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

From: Tal Gilboa Add pcie_bandwidth_capable() to compute the max link bandwidth supported by a device, based on the max link speed and width, adjusted by the encoding overhead. The maximum bandwidth of the link is computed as: max_link_speed * max_link_width * (1 -

[PATCH v5 03/14] PCI: Add pcie_bandwidth_capable() to compute max supported link bandwidth

From: Tal Gilboa Add pcie_bandwidth_capable() to compute the max link bandwidth supported by a device, based on the max link speed and width, adjusted by the encoding overhead. The maximum bandwidth of the link is computed as: max_link_speed * max_link_width * (1 - encoding_overhead) The

[PATCH v5 02/14] PCI: Add pcie_get_width_cap() to find max supported link width

From: Tal Gilboa Add pcie_get_width_cap() to find the max link width supported by a device. Change max_link_width_show() to use pcie_get_width_cap(). Signed-off-by: Tal Gilboa [bhelgaas: return width directly instead of error and *width, don't export

[PATCH v5 00/14] Report PCI device link status

This is mostly Tal's work to reduce code duplication in drivers and unify the approach for reporting PCIe link speed/width and whether the device is being limited by a slower upstream link. This v5 series is based on Tal's v4 [1]. Changes since v4: - Added patches to replace uses of

[PATCH v5 02/14] PCI: Add pcie_get_width_cap() to find max supported link width

From: Tal Gilboa Add pcie_get_width_cap() to find the max link width supported by a device. Change max_link_width_show() to use pcie_get_width_cap(). Signed-off-by: Tal Gilboa [bhelgaas: return width directly instead of error and *width, don't export outside drivers/pci] Signed-off-by: Bjorn

[PATCH v5 00/14] Report PCI device link status

This is mostly Tal's work to reduce code duplication in drivers and unify the approach for reporting PCIe link speed/width and whether the device is being limited by a slower upstream link. This v5 series is based on Tal's v4 [1]. Changes since v4: - Added patches to replace uses of

[PATCH v5 01/14] PCI: Add pcie_get_speed_cap() to find max supported link speed

From: Tal Gilboa Add pcie_get_speed_cap() to find the max link speed supported by a device. Change max_link_speed_show() to use pcie_get_speed_cap(). Signed-off-by: Tal Gilboa [bhelgaas: return speed directly instead of error and *speed, don't export

[PATCH v5 01/14] PCI: Add pcie_get_speed_cap() to find max supported link speed

From: Tal Gilboa Add pcie_get_speed_cap() to find the max link speed supported by a device. Change max_link_speed_show() to use pcie_get_speed_cap(). Signed-off-by: Tal Gilboa [bhelgaas: return speed directly instead of error and *speed, don't export outside drivers/pci] Signed-off-by: Bjorn

Re: [PATCH v6 7/9] gpio: Add gpio driver for Actions OWL S900 SoC

On Wed, Mar 28, 2018 at 8:47 PM, Manivannan Sadhasivam wrote: > Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers > controlling the gpio shares the same register range with pinctrl block. > > GPIO registers are organized as 6 banks and each

Re: [PATCH v6 7/9] gpio: Add gpio driver for Actions OWL S900 SoC

On Wed, Mar 28, 2018 at 8:47 PM, Manivannan Sadhasivam wrote: > Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers > controlling the gpio shares the same register range with pinctrl block. > > GPIO registers are organized as 6 banks and each bank controls the > maximum of 32

[PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

From: Haiyang Zhang The variables, msg and data, have the same value. This patch removes the extra one. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-)

[PATCH net-next] hv_netvsc: Clean up extra parameter from rndis_filter_receive_data()

From: Haiyang Zhang The variables, msg and data, have the same value. This patch removes the extra one. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c

Re: [PATCH] rbd: remove VLA usage

On 03/30/2018 03:29 PM, Ilya Dryomov wrote: On Fri, Mar 30, 2018 at 9:17 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove the use of stack VLA. In this particular case, variable buf_size is replaced with a constant expression that can be

Re: [PATCH] rbd: remove VLA usage

On 03/30/2018 03:29 PM, Ilya Dryomov wrote: On Fri, Mar 30, 2018 at 9:17 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove the use of stack VLA. In this particular case, variable buf_size is replaced with a constant expression that can be computed at preprocessing

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

On Fri, 30 Mar 2018, Eric W. Biederman wrote: Davidlohr Bueso writes: I ran this on a 40-core (no ht) Westmere with two benchmarks. The first is Manfred's sysvsem lockunlock[1] program which uses _processes_ to, well, lock and unlock the semaphore. The options are a little

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

On Fri, 30 Mar 2018, Eric W. Biederman wrote: Davidlohr Bueso writes: I ran this on a 40-core (no ht) Westmere with two benchmarks. The first is Manfred's sysvsem lockunlock[1] program which uses _processes_ to, well, lock and unlock the semaphore. The options are a little unconventional, to

Re: [PATCH v1] kernel/trace:check the val against the available mem

On Fri, Mar 30, 2018 at 10:20:38AM -0400, Steven Rostedt wrote: > That said, it appears you are having issues that were caused by the > change by commit 848618857d2 ("tracing/ring_buffer: Try harder to > allocate"), where we replaced NORETRY with RETRY_MAYFAIL. The point of > NORETRY was to keep

Re: [PATCH v1] kernel/trace:check the val against the available mem

On Fri, Mar 30, 2018 at 10:20:38AM -0400, Steven Rostedt wrote: > That said, it appears you are having issues that were caused by the > change by commit 848618857d2 ("tracing/ring_buffer: Try harder to > allocate"), where we replaced NORETRY with RETRY_MAYFAIL. The point of > NORETRY was to keep

Re: omap4-droid4: voice call support was Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

Hi! > > > Would you mind sharing those hacks - I would like to play around with > > > ofonod as well. Maybe I can help with a way forward. > > > > Okay. Here's less hacky version of the hack, but still using AT > > commands. You still need to set up udev, as described in the other > > mail. > >

Re: omap4-droid4: voice call support was Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

Hi! > > > Would you mind sharing those hacks - I would like to play around with > > > ofonod as well. Maybe I can help with a way forward. > > > > Okay. Here's less hacky version of the hack, but still using AT > > commands. You still need to set up udev, as described in the other > > mail. > >

Re: [PATCH v1] kernel/trace:check the val against the available mem

Hi Steve, On Fri, Mar 30, 2018 at 12:10 PM, Steven Rostedt wrote: [..] >> > I wonder if I should have the ring buffer allocate groups of pages, to >> > avoid this. Or try to allocate with NORETRY, one page at a time, and >> > when that fails, allocate groups of pages with

Re: [PATCH v1] kernel/trace:check the val against the available mem

Hi Steve, On Fri, Mar 30, 2018 at 12:10 PM, Steven Rostedt wrote: [..] >> > I wonder if I should have the ring buffer allocate groups of pages, to >> > avoid this. Or try to allocate with NORETRY, one page at a time, and >> > when that fails, allocate groups of pages with RETRY_MAYFAIL, and that

Re: [PATCH 00/11] Use global pages with PTI

On Fri, 30 Mar 2018, Dave Hansen wrote: > On 03/30/2018 05:17 AM, Ingo Molnar wrote: > > BTW., the expectation on !PCID Intel hardware would be for global pages to > > help > > even more than the 0.6% and 1.7% you measured on PCID hardware: PCID > > already > > _reduces_ the cost of TLB

Re: [PATCH 00/11] Use global pages with PTI

On Fri, 30 Mar 2018, Dave Hansen wrote: > On 03/30/2018 05:17 AM, Ingo Molnar wrote: > > BTW., the expectation on !PCID Intel hardware would be for global pages to > > help > > even more than the 0.6% and 1.7% you measured on PCID hardware: PCID > > already > > _reduces_ the cost of TLB

Re: [PATCH] rbd: remove VLA usage

On Fri, Mar 30, 2018 at 9:17 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove the use of stack VLA. > > In this particular case, variable buf_size is replaced with a constant > expression that can be computed at preprocessing time. This avoids two

Re: [PATCH] rbd: remove VLA usage

On Fri, Mar 30, 2018 at 9:17 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove the use of stack VLA. > > In this particular case, variable buf_size is replaced with a constant > expression that can be computed at preprocessing time. This avoids two > VLA warnings. Also, as

[GIT] Networking

1) Fix RCU locking in xfrm_local_error(), from Taehee Yoo. 2) Fix return value assignments and thus error checking in iwl_mvm_start_ap_ibss(), from Johannes Berg. 3) Don't count header length twice in vti4, from Stefano Brivio. 4) Fix deadlock in rt6_age_examine_exception, from Eric

[GIT] Networking

1) Fix RCU locking in xfrm_local_error(), from Taehee Yoo. 2) Fix return value assignments and thus error checking in iwl_mvm_start_ap_ibss(), from Johannes Berg. 3) Don't count header length twice in vti4, from Stefano Brivio. 4) Fix deadlock in rt6_age_examine_exception, from Eric

Re: [PATCH 00/11] Use global pages with PTI

On 03/30/2018 05:17 AM, Ingo Molnar wrote: > BTW., the expectation on !PCID Intel hardware would be for global pages to > help > even more than the 0.6% and 1.7% you measured on PCID hardware: PCID already > _reduces_ the cost of TLB flushes - so if there's not even PCID then global > pages >

Re: [PATCH 00/11] Use global pages with PTI

On 03/30/2018 05:17 AM, Ingo Molnar wrote: > BTW., the expectation on !PCID Intel hardware would be for global pages to > help > even more than the 0.6% and 1.7% you measured on PCID hardware: PCID already > _reduces_ the cost of TLB flushes - so if there's not even PCID then global > pages >

Re: [PATCH] blktrace: fix comment in blktrace_api.h

On 3/30/18 1:32 PM, Souvik Banerjee wrote: > The `__u64 time` field of the blk_io_trace struct refers to > the time in nanoseconds, not in microseconds. It is set in > __blk_add_trace, which does the following: > > t->time = ktime_to_ns(ktime_get()); > > ktime_to_ns returns ktime_t in

Re: [PATCH] blktrace: fix comment in blktrace_api.h

On 3/30/18 1:32 PM, Souvik Banerjee wrote: > The `__u64 time` field of the blk_io_trace struct refers to > the time in nanoseconds, not in microseconds. It is set in > __blk_add_trace, which does the following: > > t->time = ktime_to_ns(ktime_get()); > > ktime_to_ns returns ktime_t in

Re: [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote: > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > This patch fixes the clang warning of extraneous parentheses, with the > > > following coccinelle script. > > > > > > @@ > > >

Re: [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote: > On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > > This patch fixes the clang warning of extraneous parentheses, with the > > > following coccinelle script. > > > > > > @@ > > >

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

Davidlohr Bueso writes: > I ran this on a 40-core (no ht) Westmere with two benchmarks. The first > is Manfred's sysvsem lockunlock[1] program which uses _processes_ to, > well, lock and unlock the semaphore. The options are a little > unconventional, to keep the "critical

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

Davidlohr Bueso writes: > I ran this on a 40-core (no ht) Westmere with two benchmarks. The first > is Manfred's sysvsem lockunlock[1] program which uses _processes_ to, > well, lock and unlock the semaphore. The options are a little > unconventional, to keep the "critical region small" and the

[PATCH] ARM: dts: qcom: pm8941: Add vadc nodes needed to estimate an ocv

vbat_sns is needed to estimate a fairly accurate on chip voltage and bat_therm is needed to produce an accurate percentage from the estimated ocv. Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-pm8941.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH] ARM: dts: qcom: pm8941: Add vadc nodes needed to estimate an ocv

vbat_sns is needed to estimate a fairly accurate on chip voltage and bat_therm is needed to produce an accurate percentage from the estimated ocv. Signed-off-by: Craig Tatlor --- arch/arm/boot/dts/qcom-pm8941.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git

WARNING: kmalloc bug in bfs_fill_super

Hello, syzbot hit the following crash on upstream commit 9dd2326890d89a5179967c947dab2bab34d7ddee (Fri Mar 30 17:29:47 2018 +) Merge tag 'ceph-for-4.16-rc8' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=71c6b5d68e91149fc8a4 So far

WARNING: kmalloc bug in bfs_fill_super

Hello, syzbot hit the following crash on upstream commit 9dd2326890d89a5179967c947dab2bab34d7ddee (Fri Mar 30 17:29:47 2018 +) Merge tag 'ceph-for-4.16-rc8' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=71c6b5d68e91149fc8a4 So far

[PATCH] spi: stm32: Fix error handling in stm32_spi_probe()

clk_get_rate() is below clk_prepare_enable(), so its error should lead to goto err_clk_disable, not to err_master_put. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1

[PATCH] spi: stm32: Fix error handling in stm32_spi_probe()

clk_get_rate() is below clk_prepare_enable(), so its error should lead to goto err_clk_disable, not to err_master_put. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

On Sat, 31 Mar 2018, Kai-Heng Feng wrote: > A user reported [1] that the Realtek ethernet r8169 stops working after S3 > since v4.15-rc6. The issue still exists in Linus' tree: > > [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not ready > [ 150.944101] do_IRQ: 3.37 No irq handler for

Re: Regression caused by commit bc976233a872, ethernet r8169 stops working after system S3

On Sat, 31 Mar 2018, Kai-Heng Feng wrote: > A user reported [1] that the Realtek ethernet r8169 stops working after S3 > since v4.15-rc6. The issue still exists in Linus' tree: > > [ 150.877998] IPv6: ADDRCONF(NETDEV_UP): enp1s0: link is not ready > [ 150.944101] do_IRQ: 3.37 No irq handler for

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

On Fri, Mar 30, 2018 at 02:47:05AM +, Sasha Levin wrote: > On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > >On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > >"./check -g auto" runs the full "expected to pass" regression test > >suite for all configured test

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

On Fri, Mar 30, 2018 at 02:47:05AM +, Sasha Levin wrote: > On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > >On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > >"./check -g auto" runs the full "expected to pass" regression test > >suite for all configured test

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

On Fri, Mar 30, 2018 at 12:46:42PM -0600, Logan Gunthorpe wrote: > > > On 29/03/18 07:58 PM, Jerome Glisse wrote: > > On Thu, Mar 29, 2018 at 10:25:52AM -0600, Logan Gunthorpe wrote: > >> > >> > >> On 29/03/18 10:10 AM, Christian König wrote: > >>> Why not? I mean the dma_map_resource() function

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

On Fri, Mar 30, 2018 at 12:46:42PM -0600, Logan Gunthorpe wrote: > > > On 29/03/18 07:58 PM, Jerome Glisse wrote: > > On Thu, Mar 29, 2018 at 10:25:52AM -0600, Logan Gunthorpe wrote: > >> > >> > >> On 29/03/18 10:10 AM, Christian König wrote: > >>> Why not? I mean the dma_map_resource() function

[PATCH] ethernet: hisilicon: hns: hns_dsaf_mac: Use generic eth_broadcast_addr

Rather than use an on-stack array to copy a broadcast address, use the generic eth_broadcast_addr function to save a trivial amount of object code. Signed-off-by: Joe Perches --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH] ethernet: hisilicon: hns: hns_dsaf_mac: Use generic eth_broadcast_addr

Rather than use an on-stack array to copy a broadcast address, use the generic eth_broadcast_addr function to save a trivial amount of object code. Signed-off-by: Joe Perches --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

>When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual >PCI bus to the guest, Hyper-V always provides unique PCI domain. > >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") >overrode unique domain with the serial number of the first device added

Re: [PATCH v5] PCI: hv: Make sure the bus domain is really unique

>When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual >PCI bus to the guest, Hyper-V always provides unique PCI domain. > >commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") >overrode unique domain with the serial number of the first device added

[PATCH] blktrace: fix comment in blktrace_api.h

The `__u64 time` field of the blk_io_trace struct refers to the time in nanoseconds, not in microseconds. It is set in __blk_add_trace, which does the following: t->time = ktime_to_ns(ktime_get()); ktime_to_ns returns ktime_t in nanoseconds, not microseconds. Signed-off-by: Souvik Banerjee

[PATCH] blktrace: fix comment in blktrace_api.h

The `__u64 time` field of the blk_io_trace struct refers to the time in nanoseconds, not in microseconds. It is set in __blk_add_trace, which does the following: t->time = ktime_to_ns(ktime_get()); ktime_to_ns returns ktime_t in nanoseconds, not microseconds. Signed-off-by: Souvik Banerjee

Re: [RESEND PATCH] crypto: Add zstd support

> On Mar 30, 2018, at 10:14 AM, Herbert Xu wrote: > > On Thu, Mar 22, 2018 at 01:32:30PM +0900, Sergey Senozhatsky wrote: >> On (03/21/18 15:49), Nick Terrell wrote: >>> depends on CONFIG_CRYPTO_ZSTD, which isn't defined until this patch is in >> >> Yikes! How come

Re: [RESEND PATCH] crypto: Add zstd support

> On Mar 30, 2018, at 10:14 AM, Herbert Xu wrote: > > On Thu, Mar 22, 2018 at 01:32:30PM +0900, Sergey Senozhatsky wrote: >> On (03/21/18 15:49), Nick Terrell wrote: >>> depends on CONFIG_CRYPTO_ZSTD, which isn't defined until this patch is in >> >> Yikes! How come I missed that... :) >> >>>

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

On Wed, 28 Mar 2018, Davidlohr Bueso wrote: On Fri, 23 Mar 2018, Eric W. Biederman wrote: Today the last process to update a semaphore is remembered and reported in the pid namespace of that process. If there are processes in any other pid namespace querying that process id with GETPID the

Re: [REVIEW][PATCH 11/11] ipc/sem: Fix semctl(..., GETPID, ...) between pid namespaces

On Wed, 28 Mar 2018, Davidlohr Bueso wrote: On Fri, 23 Mar 2018, Eric W. Biederman wrote: Today the last process to update a semaphore is remembered and reported in the pid namespace of that process. If there are processes in any other pid namespace querying that process id with GETPID the

[PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet,obd}

From: "John L. Hammond" Request dynamic minor allocation when registering /dev/lnet and /dev/obd. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-100086 Reviewed-on: https://review.whamcloud.com/29741

[PATCH] staging: lustre: libcfs: use dynamic minors for /dev/{lnet,obd}

From: "John L. Hammond" Request dynamic minor allocation when registering /dev/lnet and /dev/obd. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-100086 Reviewed-on: https://review.whamcloud.com/29741 Reviewed-by: Andreas Dilger Reviewed-by: Jian Yu

[PATCH] rbd: remove VLA usage

In preparation to enabling -Wvla, remove the use of stack VLA. In this particular case, variable buf_size is replaced with a constant expression that can be computed at preprocessing time. This avoids two VLA warnings. Also, as a consequence of the mentioned change, some code was slightly

[PATCH] rbd: remove VLA usage

In preparation to enabling -Wvla, remove the use of stack VLA. In this particular case, variable buf_size is replaced with a constant expression that can be computed at preprocessing time. This avoids two VLA warnings. Also, as a consequence of the mentioned change, some code was slightly

<    1   2   3   4   5   6   7   8   9   10   >