Re: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless -EEXIST error.

2018-04-18 Thread Michal Hocko
On Wed 18-04-18 23:07:12, Tetsuo Handa wrote: > >From 3f396857d23d4bf1fac4d4332316b5ba0af6d2f9 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Wed, 18 Apr 2018 23:00:53 +0900 > Subject: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless >

Re: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless -EEXIST error.

2018-04-18 Thread Michal Hocko
On Wed 18-04-18 23:07:12, Tetsuo Handa wrote: > >From 3f396857d23d4bf1fac4d4332316b5ba0af6d2f9 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Wed, 18 Apr 2018 23:00:53 +0900 > Subject: [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless > -EEXIST error. > > Commit

Re: WARNING: stack going in the wrong direction? ip=__schedule+0x489/0x830

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 01:49:41PM +0800, Fengguang Wu wrote: Hello, FYI this warning dates back to v4.16-rc5 . It's rather rare and often happen together with other errors. Sorry, that should be 0day didn't catch this particular WARNING. So it just occasionally show up in the context of

Re: WARNING: stack going in the wrong direction? ip=__schedule+0x489/0x830

2018-04-18 Thread Fengguang Wu
On Thu, Apr 19, 2018 at 01:49:41PM +0800, Fengguang Wu wrote: Hello, FYI this warning dates back to v4.16-rc5 . It's rather rare and often happen together with other errors. Sorry, that should be 0day didn't catch this particular WARNING. So it just occasionally show up in the context of

Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver

2018-04-18 Thread Stephen Boyd
Quoting David Collins (2018-03-22 18:30:06) > On 03/21/2018 12:07 PM, Stephen Boyd wrote: > > Quoting David Collins (2018-03-16 18:09:10) > >> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > >> index 097f617..e0ecd0a 100644 > >> --- a/drivers/regulator/Kconfig > >> +++

Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver

2018-04-18 Thread Stephen Boyd
Quoting David Collins (2018-03-22 18:30:06) > On 03/21/2018 12:07 PM, Stephen Boyd wrote: > > Quoting David Collins (2018-03-16 18:09:10) > >> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > >> index 097f617..e0ecd0a 100644 > >> --- a/drivers/regulator/Kconfig > >> +++

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 06:02:50PM +0900, Masami Hiramatsu wrote: > On Mon, 16 Apr 2018 21:07:47 -0700 > Joel Fernandes wrote: > > > With TRACE_IRQFLAGS, we call trace_ API too many times. We don't need > > to if local_irq_restore or local_irq_save didn't actually do anything.

Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

2018-04-18 Thread Namhyung Kim
On Wed, Apr 18, 2018 at 06:02:50PM +0900, Masami Hiramatsu wrote: > On Mon, 16 Apr 2018 21:07:47 -0700 > Joel Fernandes wrote: > > > With TRACE_IRQFLAGS, we call trace_ API too many times. We don't need > > to if local_irq_restore or local_irq_save didn't actually do anything. > > > > This

Re: cpu stopper threads and load balancing leads to deadlock

2018-04-18 Thread Mike Galbraith
On Wed, 2018-04-18 at 07:47 +0200, Mike Galbraith wrote: > On Tue, 2018-04-17 at 15:21 +0100, Matt Fleming wrote: > > Hi guys, > > > > We've seen a bug in one of our SLE kernels where the cpu stopper > > thread ("migration/15") is entering idle balance. This then triggers > > active load balance.

Re: cpu stopper threads and load balancing leads to deadlock

2018-04-18 Thread Mike Galbraith
On Wed, 2018-04-18 at 07:47 +0200, Mike Galbraith wrote: > On Tue, 2018-04-17 at 15:21 +0100, Matt Fleming wrote: > > Hi guys, > > > > We've seen a bug in one of our SLE kernels where the cpu stopper > > thread ("migration/15") is entering idle balance. This then triggers > > active load balance.

Re: 4.15.17 regression: bisected: timeout during microcode update

2018-04-18 Thread Vitezslav Samel
On Wed, Apr 18, 2018 at 06:53:30AM -0700, Raj, Ashok wrote: > On Wed, Apr 18, 2018 at 02:22:12PM +0200, Borislav Petkov wrote: > > On Wed, Apr 18, 2018 at 02:08:40PM +0200, Vitezslav Samel wrote: > > > I switched to firmware-in-kernel early loading and that works OK. > > firmware-in-kernel means

Re: 4.15.17 regression: bisected: timeout during microcode update

2018-04-18 Thread Vitezslav Samel
On Wed, Apr 18, 2018 at 06:53:30AM -0700, Raj, Ashok wrote: > On Wed, Apr 18, 2018 at 02:22:12PM +0200, Borislav Petkov wrote: > > On Wed, Apr 18, 2018 at 02:08:40PM +0200, Vitezslav Samel wrote: > > > I switched to firmware-in-kernel early loading and that works OK. > > firmware-in-kernel means

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 10:21:25PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > > The code defines macro

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 10:21:25PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > > The code defines macro

[PATCH v2 net 1/3] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so it's in theory (on extreme memory pressure) possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

[PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-18 Thread Michael S. Tsirkin
Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer Fixes: 9465a7a6f ("virtio_net: enable v1.0

[PATCH v2 net 1/3] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so it's in theory (on extreme memory pressure) possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

[PATCH v2 net 2/3] virtio_net: fix adding vids on big-endian

2018-04-18 Thread Michael S. Tsirkin
Programming vids (adding or removing them) still passes guest-endian values in the DMA buffer. That's wrong if guest is big-endian and when virtio 1 is enabled. Note: this is on top of a previous patch: virtio_net: split out ctrl buffer Fixes: 9465a7a6f ("virtio_net: enable v1.0

[PATCH v2 net 0/3] virtio: ctrl buffer fixes

2018-04-18 Thread Michael S. Tsirkin
Here are a couple of fixes related to the virtio control buffer. Lightly tested on x86 only. Michael S. Tsirkin (3): virtio_net: split out ctrl buffer virtio_net: fix adding vids on big-endian virtio_net: sparse annotation fix drivers/net/virtio_net.c | 68

[PATCH v2 net 0/3] virtio: ctrl buffer fixes

2018-04-18 Thread Michael S. Tsirkin
Here are a couple of fixes related to the virtio control buffer. Lightly tested on x86 only. Michael S. Tsirkin (3): virtio_net: split out ctrl buffer virtio_net: fix adding vids on big-endian virtio_net: sparse annotation fix drivers/net/virtio_net.c | 68

[PATCH v2 net 3/3] virtio_net: sparse annotation fix

2018-04-18 Thread Michael S. Tsirkin
offloads is a buffer in virtio format, should use the __virtio64 tag. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f84fe04..c5b11f2

[PATCH v2 net 3/3] virtio_net: sparse annotation fix

2018-04-18 Thread Michael S. Tsirkin
offloads is a buffer in virtio format, should use the __virtio64 tag. Signed-off-by: Michael S. Tsirkin --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f84fe04..c5b11f2 100644 ---

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > > address is in kernel space or

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 01:12:49PM +0800, Leo Yan wrote: > On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > > address is in kernel space or

Re: [PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 08:01:49AM +0300, Michael S. Tsirkin wrote: > When sending control commands, virtio net sets up several buffers for > DMA. The buffers are all part of the net device which means it's > actually allocated by kvmalloc so in theory (on extreme memory pressure) > it's possible

Re: [PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 08:01:49AM +0300, Michael S. Tsirkin wrote: > When sending control commands, virtio net sets up several buffers for > DMA. The buffers are all part of the net device which means it's > actually allocated by kvmalloc so in theory (on extreme memory pressure) > it's possible

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > > > > > > > > On 2018-04-15 05:19 AM, Julia Lawall

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > > Hi julia, > > > > > > > > On 2018-04-15 05:19 AM, Julia Lawall

Smatch check for Spectre stuff

2018-04-18 Thread Dan Carpenter
Several people have asked me to write this and I think one person was maybe working on writing it themselves... The point of this check is to find place which might be vulnerable to the Spectre vulnerability. In the kernel we have the array_index_nospec() macro which turns off speculation.

Smatch check for Spectre stuff

2018-04-18 Thread Dan Carpenter
Several people have asked me to write this and I think one person was maybe working on writing it themselves... The point of this check is to find place which might be vulnerable to the Spectre vulnerability. In the kernel we have the array_index_nospec() macro which turns off speculation.

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > address is in kernel space or not. But different architecture has > > different 'PAGE_OFFSET' so

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Leo Yan
On Wed, Apr 18, 2018 at 09:47:45PM -0700, Alexei Starovoitov wrote: > On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > > address is in kernel space or not. But different architecture has > > different 'PAGE_OFFSET' so

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

2018-04-18 Thread Nicholas Piggin
On Wed, 18 Apr 2018 15:11:24 +0200 Christophe LEROY wrote: > Le 18/04/2018 à 10:36, Mathieu Malaterre a écrit : > > Christophe, > > > > On Wed, Apr 18, 2018 at 8:34 AM, Christophe LEROY > > wrote: > >> > >> > >> Le 17/04/2018 à 19:10, Mathieu

Re: [PATCH] powerpc: Allow selection of CONFIG_LD_DEAD_CODE_DATA_ELIMINATION

2018-04-18 Thread Nicholas Piggin
On Wed, 18 Apr 2018 15:11:24 +0200 Christophe LEROY wrote: > Le 18/04/2018 à 10:36, Mathieu Malaterre a écrit : > > Christophe, > > > > On Wed, Apr 18, 2018 at 8:34 AM, Christophe LEROY > > wrote: > >> > >> > >> Le 17/04/2018 à 19:10, Mathieu Malaterre a écrit : > >>> > >>> On Tue, Apr 17,

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
This implements a misc character device named "qrtr-tun" for the purpose of allowing user space applications to implement endpoints in the qrtr network. This allows more advanced (and dynamic) testing of the qrtr code as well as opens up the ability of tunneling qrtr over a network or USB link.

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
This implements a misc character device named "qrtr-tun" for the purpose of allowing user space applications to implement endpoints in the qrtr network. This allows more advanced (and dynamic) testing of the qrtr code as well as opens up the ability of tunneling qrtr over a network or USB link.

[PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so in theory (on extreme memory pressure) it's possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

[PATCH net] virtio_net: split out ctrl buffer

2018-04-18 Thread Michael S. Tsirkin
When sending control commands, virtio net sets up several buffers for DMA. The buffers are all part of the net device which means it's actually allocated by kvmalloc so in theory (on extreme memory pressure) it's possible to get a vmalloc'ed buffer which on some platforms means we can't DMA there.

Re: [PATCH] soc: Unconditionally include qcom Makefile

2018-04-18 Thread Bjorn Andersson
On Wed 18 Apr 16:28 PDT 2018, Evan Green wrote: > From: Guenter Roeck > > Incoming Qualcomm changes for GENI, i2c [1], and cmd-db [2] are enabled > with COMPILE_TEST in drivers/soc/qcom. For this to work, the Makefile > in that directory has to be included unconditionally,

Re: [PATCH] soc: Unconditionally include qcom Makefile

2018-04-18 Thread Bjorn Andersson
On Wed 18 Apr 16:28 PDT 2018, Evan Green wrote: > From: Guenter Roeck > > Incoming Qualcomm changes for GENI, i2c [1], and cmd-db [2] are enabled > with COMPILE_TEST in drivers/soc/qcom. For this to work, the Makefile > in that directory has to be included unconditionally, rather than only > if

RE: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Long Li
> Subject: Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE > devices > > > Long, > > > Can you take a look at the following patch? > > >> > + max_sub_channels = > >> > +(num_cpus - 1) / storvsc_vcpus_per_sub_channel; > > What happens if num_cpus = 1? If

RE: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Long Li
> Subject: Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE > devices > > > Long, > > > Can you take a look at the following patch? > > >> > + max_sub_channels = > >> > +(num_cpus - 1) / storvsc_vcpus_per_sub_channel; > > What happens if num_cpus = 1? If

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Joe Perches
On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > Hi julia, > > > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > > On Wed, 11 Apr 2018, Joe Perches wrote: > >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Joe Perches
On Thu, 2018-04-19 at 06:40 +0200, Julia Lawall wrote: > > On Wed, 18 Apr 2018, Joe Perches wrote: > > > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > > Hi julia, > > > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > > On Wed, 11 Apr 2018, Joe Perches wrote: > >

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > address is in kernel space or not. But different architecture has > different 'PAGE_OFFSET' so this program cannot be used for all > platforms. > > This commit changes

Re: [PATCH bpf-next 4/5] samples/bpf: Refine printing symbol for sampleip

2018-04-18 Thread Alexei Starovoitov
On Thu, Apr 19, 2018 at 09:34:05AM +0800, Leo Yan wrote: > The code defines macro 'PAGE_OFFSET' and uses it to decide if the > address is in kernel space or not. But different architecture has > different 'PAGE_OFFSET' so this program cannot be used for all > platforms. > > This commit changes

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > >

Re: [PATCH] checkpatch: Add a --strict test for structs with bool member definitions

2018-04-18 Thread Julia Lawall
On Wed, 18 Apr 2018, Joe Perches wrote: > On Tue, 2018-04-17 at 17:07 +0800, yuank...@codeaurora.org wrote: > > Hi julia, > > > > On 2018-04-15 05:19 AM, Julia Lawall wrote: > > > On Wed, 11 Apr 2018, Joe Perches wrote: > > > > > > > On Thu, 2018-04-12 at 08:22 +0200, Julia Lawall wrote: > > >

Re: issues with suspend on Dell XPS 13 2-in-1

2018-04-18 Thread Pandruvada, Srinivas
On Wed, 2018-04-18 at 21:01 +, mario.limoncie...@dell.com wrote: > > > > > [...] > > > Srinivas, > > > > > > Do you know why Runtime PM is defaulting to disabled for all of > > > these > > > devices?  Is that a default kernel policy problem or a distro > > > policy > > > problem? > > > >

Re: issues with suspend on Dell XPS 13 2-in-1

2018-04-18 Thread Pandruvada, Srinivas
On Wed, 2018-04-18 at 21:01 +, mario.limoncie...@dell.com wrote: > > > > > [...] > > > Srinivas, > > > > > > Do you know why Runtime PM is defaulting to disabled for all of > > > these > > > devices?  Is that a default kernel policy problem or a distro > > > policy > > > problem? > > > >

linux-next: Tree for Apr 19

2018-04-18 Thread Stephen Rothwell
Hi all, Changes since 20180418: New tree: modules-fixes I have added a patch to the arm-current tree to fix build problems discovered overnight. The sound-asoc tree lost its build failure. Non-merge commits (relative to Linus' tree): 1055 1121 files changed, 36028 insertions(+), 19043

linux-next: Tree for Apr 19

2018-04-18 Thread Stephen Rothwell
Hi all, Changes since 20180418: New tree: modules-fixes I have added a patch to the arm-current tree to fix build problems discovered overnight. The sound-asoc tree lost its build failure. Non-merge commits (relative to Linus' tree): 1055 1121 files changed, 36028 insertions(+), 19043

Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance

2018-04-18 Thread Mukunda,Vijendar
On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote: Hi Vijendar, On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda wrote: With in ACP, There are three I2S controllers can be configured/enabled ( I2S SP, I2S MICSP, I2S BT). Default enabled I2S controller

Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance

2018-04-18 Thread Mukunda,Vijendar
On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote: Hi Vijendar, On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda wrote: With in ACP, There are three I2S controllers can be configured/enabled ( I2S SP, I2S MICSP, I2S BT). Default enabled I2S controller instance is I2S SP. This patch

Re: [PATCH 01/12] iscsi_tcp: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 01/12] iscsi_tcp: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 02/12] storsvc: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 02/12] storsvc: don't set a bounce limit

2018-04-18 Thread Martin K. Petersen
Christoph, > The default already is to never bounce, so the call is a no-op. Applied to 4.18/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: tg3 crashes under high load, when using 100Mbits

2018-04-18 Thread Siva Reddy Kallam
On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng wrote: > Hi Satish, > >> On 2018Mar21, at 00:57, Kai-Heng Feng wrote: >> >> Satish Baddipadige wrote: >> >>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy

Re: tg3 crashes under high load, when using 100Mbits

2018-04-18 Thread Siva Reddy Kallam
On Sat, Apr 14, 2018 at 9:17 PM, Kai-Heng Feng wrote: > Hi Satish, > >> On 2018Mar21, at 00:57, Kai-Heng Feng wrote: >> >> Satish Baddipadige wrote: >> >>> On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam >>> wrote: On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam wrote: >

Re: [PATCH 2/2] cpufreq: brcmstb-avs-cpufreq: prefer SCMI cpufreq if supported

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Jim Quinlan > > If the SCMI cpufreq driver is supported, we bail, so that the new > approach can be used. > > Signed-off-by: Jim Quinlan > Signed-off-by: Markus Mayer > --- >

Re: [PATCH 2/2] cpufreq: brcmstb-avs-cpufreq: prefer SCMI cpufreq if supported

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Jim Quinlan > > If the SCMI cpufreq driver is supported, we bail, so that the new > approach can be used. > > Signed-off-by: Jim Quinlan > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/brcmstb-avs-cpufreq.c | 16 > 1 file

Re: [PATCH 1/2] cpufreq: brcmstb-avs-cpufreq: remove development debug support

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Markus Mayer > > This debug code was helpful while developing the driver, but it isn't > being used for anything anymore. > > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/Kconfig.arm |

Re: [PATCH 1/2] cpufreq: brcmstb-avs-cpufreq: remove development debug support

2018-04-18 Thread Viresh Kumar
On 18-04-18, 08:56, Markus Mayer wrote: > From: Markus Mayer > > This debug code was helpful while developing the driver, but it isn't > being used for anything anymore. > > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/Kconfig.arm | 10 -- >

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-18 Thread Keerthy
On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: > On 4/11/18 9:53 PM, Keerthy wrote: >> From: Dave Gerlach >> >> After an RTC+DDR cycle we lose sram context so emif pm functions present >> in sram are lost. We can check if the first byte of the original

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-18 Thread Keerthy
On Thursday 12 April 2018 10:14 PM, santosh.shilim...@oracle.com wrote: > On 4/11/18 9:53 PM, Keerthy wrote: >> From: Dave Gerlach >> >> After an RTC+DDR cycle we lose sram context so emif pm functions present >> in sram are lost. We can check if the first byte of the original >> code in DDR

Re: [PATCH v11 0/4] set VSESR_EL2 by user space and support NOTIFY_SEI notification

2018-04-18 Thread gengdongjiu
James, > >> I do not know when it is merge-window. About the apply version, it does not >> have limited. > > 'git fetch' Linus' tree and look at the tags. 'v4.16' lost its '-rc' suffixes, > and there isn't a 'v4.17-rc1' yet, so we are still in the merge window. > > Linus sends a message to

Re: [PATCH v11 0/4] set VSESR_EL2 by user space and support NOTIFY_SEI notification

2018-04-18 Thread gengdongjiu
James, > >> I do not know when it is merge-window. About the apply version, it does not >> have limited. > > 'git fetch' Linus' tree and look at the tags. 'v4.16' lost its '-rc' suffixes, > and there isn't a 'v4.17-rc1' yet, so we are still in the merge window. > > Linus sends a message to

Re: [PATCH] scsi: mptfc: fix spelling mistake in macro names

2018-04-18 Thread Martin K. Petersen
Colin, > Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and > MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN Applied to 4.18/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptfc: fix spelling mistake in macro names

2018-04-18 Thread Martin K. Petersen
Colin, > Rename macros MPI_FCPORTPAGE0_SUPPORT_SPEED_UKNOWN and > MPI_FCPORTPAGE0_CURRENT_SPEED_UKNOWN to add in missing N in UNKNOWN Applied to 4.18/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] clk: aspeed: Support second reset register

2018-04-18 Thread Andrew Jeffery
On Thu, 19 Apr 2018, at 12:22, Joel Stanley wrote: > The ast2500 has an additional reset register that contains resets not > present in the ast2400. This enables support for this register, and adds > the one reset line that is controlled by it. > > Signed-off-by: Joel Stanley

Re: [PATCH] clk: aspeed: Support second reset register

2018-04-18 Thread Andrew Jeffery
On Thu, 19 Apr 2018, at 12:22, Joel Stanley wrote: > The ast2500 has an additional reset register that contains resets not > present in the ast2400. This enables support for this register, and adds > the one reset line that is controlled by it. > > Signed-off-by: Joel Stanley The duplication is

[PATCH 2/2] blkcg: init root blkcg_gq under lock

2018-04-18 Thread Jiang Biao
The initializing of q->root_blkg is currently outside of queue lock and rcu, so the blkg may be destroied before the initializing, which may cause dangling/null references. On the other side, the destroys of blkg are protected by queue lock or rcu. Put the initializing inside the queue lock and

[PATCH 2/2] blkcg: init root blkcg_gq under lock

2018-04-18 Thread Jiang Biao
The initializing of q->root_blkg is currently outside of queue lock and rcu, so the blkg may be destroied before the initializing, which may cause dangling/null references. On the other side, the destroys of blkg are protected by queue lock or rcu. Put the initializing inside the queue lock and

[PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue

2018-04-18 Thread Jiang Biao
The comment before blkg_create() in blkcg_init_queue() was moved from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but it does not suit for the new context. Signed-off-by: Jiang Biao Signed-off-by: Wen Yang CC: Tejun Heo

[PATCH 1/2] blkcg: small fix on comment in blkcg_init_queue

2018-04-18 Thread Jiang Biao
The comment before blkg_create() in blkcg_init_queue() was moved from blkcg_activate_policy() by commit ec13b1d6f0a0457312e615, but it does not suit for the new context. Signed-off-by: Jiang Biao Signed-off-by: Wen Yang CC: Tejun Heo CC: Jens Axboe --- block/blk-cgroup.c | 6 +- 1 file

[PATCH] net: hns: Avoid action name truncation

2018-04-18 Thread dann frazier
When longer interface names are used, the action names exposed in /proc/interrupts and /proc/irq/* maybe truncated. For example, when using the predictable name algorithm in systemd on a HiSilicon D05, I see: ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'

[PATCH] net: hns: Avoid action name truncation

2018-04-18 Thread dann frazier
When longer interface names are used, the action names exposed in /proc/interrupts and /proc/irq/* maybe truncated. For example, when using the predictable name algorithm in systemd on a HiSilicon D05, I see: ubuntu@d05-3:~$ grep enahisic2i0-tx /proc/interrupts | sed 's/.* //'

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:38:43PM -0700, Eric Dumazet wrote: > > > On 04/18/2018 10:55 AM, Michael S. Tsirkin wrote: > > > Imagine you want to pass some data to card. > > Natural thing is to just put it in a variable and start DMA. > > However DMA API disallows stack access nowdays, > > so

Re: [PATCH] net: don't use kvzalloc for DMA memory

2018-04-18 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 01:38:43PM -0700, Eric Dumazet wrote: > > > On 04/18/2018 10:55 AM, Michael S. Tsirkin wrote: > > > Imagine you want to pass some data to card. > > Natural thing is to just put it in a variable and start DMA. > > However DMA API disallows stack access nowdays, > > so

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Sean Wang
On Wed, 2018-04-18 at 20:18 -0700, Stephen Boyd wrote: > Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > > From: Sean Wang > > > > Add bindings to g3dsys providing necessary clock and reset control to > > Mali-450. > > > > Signed-off-by: Sean Wang

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Sean Wang
On Wed, 2018-04-18 at 20:18 -0700, Stephen Boyd wrote: > Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > > From: Sean Wang > > > > Add bindings to g3dsys providing necessary clock and reset control to > > Mali-450. > > > > Signed-off-by: Sean Wang > > --- > >

Re: [PATCH -next] user_namespace: Replace gotos with return statements

2018-04-18 Thread Eric W. Biederman
Marcos Paulo de Souza writes: > Found while inspecting the code that handles the setgroups procfs > file. What perchance might be the advantage of introducing multiple exits into proc_setgroups_write? I strongly suspect that if you look at the generated code it will

Re: [PATCH -next] user_namespace: Replace gotos with return statements

2018-04-18 Thread Eric W. Biederman
Marcos Paulo de Souza writes: > Found while inspecting the code that handles the setgroups procfs > file. What perchance might be the advantage of introducing multiple exits into proc_setgroups_write? I strongly suspect that if you look at the generated code it will be worse after your patch.

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-18 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > goto out; > } > > - if (dlen != ctemplate[i].outlen) { > + ilen = dlen; > + dlen =

Re: [PATCH] crypto: testmgr: Allow different compression results

2018-04-18 Thread Herbert Xu
On Wed, Apr 11, 2018 at 08:28:32PM +0200, Jan Glauber wrote: > > @@ -1362,7 +1373,17 @@ static int test_comp(struct crypto_comp *tfm, > goto out; > } > > - if (dlen != ctemplate[i].outlen) { > + ilen = dlen; > + dlen =

Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Martin K. Petersen
Long, > Can you take a look at the following patch? >> > + max_sub_channels = >> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel; What happens if num_cpus = 1? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] storvsc: Set up correct queue depth values for IDE devices

2018-04-18 Thread Martin K. Petersen
Long, > Can you take a look at the following patch? >> > + max_sub_channels = >> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel; What happens if num_cpus = 1? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

2018-04-18 Thread Herbert Xu
On Mon, Apr 09, 2018 at 11:42:31AM +0300, Gilad Ben-Yossef wrote: > > Please look again. The stub version of cc_is_hw_key() doing that is being > replaced in this patch. The point is that the existing mechanism was unused before and this is new code. So you can't really point to the stubbed-out

Re: [PATCH 2/2] crypto: ccree: enable support for hardware keys

2018-04-18 Thread Herbert Xu
On Mon, Apr 09, 2018 at 11:42:31AM +0300, Gilad Ben-Yossef wrote: > > Please look again. The stub version of cc_is_hw_key() doing that is being > replaced in this patch. The point is that the existing mechanism was unused before and this is new code. So you can't really point to the stubbed-out

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-04-18 Thread Eric Biggers
On Tue, Jan 02, 2018 at 03:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: KASAN: slab-out-of-bounds Write in tcp_v6_syn_recv_sock

2018-04-18 Thread Eric Biggers
On Tue, Jan 02, 2018 at 03:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 61233580f1f33c50e159c50e24d80ffd2ba2e06b > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 12:54:16AM +, Dey, Megha wrote: > > Yeah I think I misunderstood. I think what you mean is to remove mcryptd.c > completely and avoid the extra layer of indirection to call the underlying > algorithm, instead call it directly, correct? > > So currently we have 3

Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 12:54:16AM +, Dey, Megha wrote: > > Yeah I think I misunderstood. I think what you mean is to remove mcryptd.c > completely and avoid the extra layer of indirection to call the underlying > algorithm, instead call it directly, correct? > > So currently we have 3

RE: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-04-18 Thread Anson Huang
Anson Huang Best Regards! > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: Thursday, April 19, 2018 11:18 AM > To: Anson Huang ; Shawn Guo > > Cc: mark.rutl...@arm.com; devicet...@vger.kernel.org; >

RE: [PATCH V2 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock source

2018-04-18 Thread Anson Huang
Anson Huang Best Regards! > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: Thursday, April 19, 2018 11:18 AM > To: Anson Huang ; Shawn Guo > > Cc: mark.rutl...@arm.com; devicet...@vger.kernel.org; > mturque...@baylibre.com; linux-...@vger.kernel.org;

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: > > I don't want to do that - I just want the documentation to be correct > (or at least, not be blatantly incorrect). The function does not sleep, > and is safe to call with spin locks held. > Do we need to spell out when it can be

Re: [PATCH 2/6] rhashtable: remove incorrect comment on r{hl, hash}table_walk_enter()

2018-04-18 Thread Herbert Xu
On Thu, Apr 19, 2018 at 08:56:28AM +1000, NeilBrown wrote: > > I don't want to do that - I just want the documentation to be correct > (or at least, not be blatantly incorrect). The function does not sleep, > and is safe to call with spin locks held. > Do we need to spell out when it can be

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Stephen Boyd
Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > From: Sean Wang > > Add bindings to g3dsys providing necessary clock and reset control to > Mali-450. > > Signed-off-by: Sean Wang > --- > .../bindings/arm/mediatek/mediatek,g3dsys.txt

Re: [PATCH v1 2/4] dt-bindings: clock: mediatek: add g3dsys bindings

2018-04-18 Thread Stephen Boyd
Quoting sean.w...@mediatek.com (2018-04-18 03:24:54) > From: Sean Wang > > Add bindings to g3dsys providing necessary clock and reset control to > Mali-450. > > Signed-off-by: Sean Wang > --- > .../bindings/arm/mediatek/mediatek,g3dsys.txt | 30 > ++ Why isn't this

  1   2   3   4   5   6   7   8   9   10   >