Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 16:28 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : > >> > > >> > - kernel...@gmail.com wrote: > >> > > >> >> From: Wanpeng Li

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 16:28 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : > >> > > >> > - kernel...@gmail.com wrote: > >> > > >> >> From: Wanpeng Li > >> >> > >> >> MSB of CR3 is a reserved bit if the

Re: [PATCH] scsi: libosd: Remove VLA usage

2018-05-13 Thread Boaz Harrosh
On 03/05/18 01:55, Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1] this rearranges the > code to avoid a VLA warning under -Wvla (gcc doesn't recognize "const" > variables as not triggering VLA creation). Additionally cleans up variable > naming to avoid 80 character column

Re: [PATCH] scsi: libosd: Remove VLA usage

2018-05-13 Thread Boaz Harrosh
On 03/05/18 01:55, Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1] this rearranges the > code to avoid a VLA warning under -Wvla (gcc doesn't recognize "const" > variables as not triggering VLA creation). Additionally cleans up variable > naming to avoid 80 character column

Re: KASAN: use-after-free Read in corrupted

2018-05-13 Thread Dmitry Vyukov
On Sun, May 13, 2018 at 10:56 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:427fbe89261d Merge branch 'next' of git://git.kernel.org/p.. > git tree: upstream > console output:

Re: KASAN: use-after-free Read in corrupted

2018-05-13 Thread Dmitry Vyukov
On Sun, May 13, 2018 at 10:56 AM, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:427fbe89261d Merge branch 'next' of git://git.kernel.org/p.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=148eb01780 > kernel config:

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

2018-05-13 Thread Tariq Toukan
On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

2018-05-13 Thread Tariq Toukan
On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCH v3] mm: Change return type to vm_fault_t

2018-05-13 Thread Joe Perches
On Sat, 2018-05-12 at 19:51 -0700, Dan Williams wrote: > On Sat, May 12, 2018 at 12:14 PM, Souptick Joarder > wrote: > > > > It'd be nicer to realign the 2nd and 3rd arguments > > > > on the subsequent lines. > > > > > > > > vm_fault_t (*fault)(const struct

Re: [PATCH v3] mm: Change return type to vm_fault_t

2018-05-13 Thread Joe Perches
On Sat, 2018-05-12 at 19:51 -0700, Dan Williams wrote: > On Sat, May 12, 2018 at 12:14 PM, Souptick Joarder > wrote: > > > > It'd be nicer to realign the 2nd and 3rd arguments > > > > on the subsequent lines. > > > > > > > > vm_fault_t (*fault)(const struct vm_special_mapping *sm, > > > >

KASAN: use-after-free Read in corrupted

2018-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:427fbe89261d Merge branch 'next' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148eb01780 kernel config: https://syzkaller.appspot.com/x/.config?x=fcce42b221691ff9

KASAN: use-after-free Read in corrupted

2018-05-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:427fbe89261d Merge branch 'next' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148eb01780 kernel config: https://syzkaller.appspot.com/x/.config?x=fcce42b221691ff9

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 16:28 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : >> > >> > - kernel...@gmail.com wrote: >> > >> >> From: Wanpeng Li >> >> >> >> MSB of CR3 is a

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 16:28 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> 2018-05-13 15:53 GMT+08:00 Liran Alon : >> > >> > - kernel...@gmail.com wrote: >> > >> >> From: Wanpeng Li >> >> >> >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. >> >> It should be checked

Re: [PATCH] PM: docs: sleep-states: Fix a typo ("includig")

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 12:07:03 PM CEST Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer > --- > Documentation/admin-guide/pm/sleep-states.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] PM: docs: sleep-states: Fix a typo ("includig")

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 12:07:03 PM CEST Jonathan Neuschäfer wrote: > Signed-off-by: Jonathan Neuschäfer > --- > Documentation/admin-guide/pm/sleep-states.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/pm/sleep-states.rst >

Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 4:46:47 AM CEST Viresh Kumar wrote: > On 24-04-18, 15:14, Luc Van Oostenryck wrote: > > speedstep_detect_processor() is declared as returing an > > 'enum speedstep_processor' but use an 'int' in its definition. > > > > Fix this by using 'enum speedstep_processor' in

Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 4:46:47 AM CEST Viresh Kumar wrote: > On 24-04-18, 15:14, Luc Van Oostenryck wrote: > > speedstep_detect_processor() is declared as returing an > > 'enum speedstep_processor' but use an 'int' in its definition. > > > > Fix this by using 'enum speedstep_processor' in

Re: [PATCH v3 4/6] KVM: x86: hyperv: simplistic HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST,SPACE} implementation

2018-05-13 Thread Vitaly Kuznetsov
Radim Krčmář writes: > 2018-04-16 13:08+0200, Vitaly Kuznetsov: ... > >> +/* >> + * vcpu->arch.cr3 may not be up-to-date for running vCPUs so we >> + * can't analyze it here, flush TLB regardless of the specified >> + * address

Re: [PATCH v3 4/6] KVM: x86: hyperv: simplistic HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST,SPACE} implementation

2018-05-13 Thread Vitaly Kuznetsov
Radim Krčmář writes: > 2018-04-16 13:08+0200, Vitaly Kuznetsov: ... > >> +/* >> + * vcpu->arch.cr3 may not be up-to-date for running vCPUs so we >> + * can't analyze it here, flush TLB regardless of the specified >> + * address space. >> +

Re: [PATCH v3] PM / wakeup: use seq_open() to show wakeup stats

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 12:59:31 PM CEST Ganesh Mahendran wrote: > single_open() interface requires that the whole output must > fit into a single buffer. This will lead to timeout when > system memory is not in a good situation. > > This patch use seq_open() to show wakeup stats. This

Re: [PATCH v3] PM / wakeup: use seq_open() to show wakeup stats

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, April 25, 2018 12:59:31 PM CEST Ganesh Mahendran wrote: > single_open() interface requires that the whole output must > fit into a single buffer. This will lead to timeout when > system memory is not in a good situation. > > This patch use seq_open() to show wakeup stats. This

Re: [PATCH 0/3] PM / core: Clean up suspend/resume diagnostic messages

2018-05-13 Thread Rafael J. Wysocki
On Thursday, April 26, 2018 11:36:20 PM CEST Bjorn Helgaas wrote: > These are pretty minor cleanups to the suspend/resume diagnostic messages. > > The first two are trivial. The third may break scripts that parse dmesg > output. I looked at scripts/bootgraph.pl, and I don't think it is >

Re: [PATCH 0/3] PM / core: Clean up suspend/resume diagnostic messages

2018-05-13 Thread Rafael J. Wysocki
On Thursday, April 26, 2018 11:36:20 PM CEST Bjorn Helgaas wrote: > These are pretty minor cleanups to the suspend/resume diagnostic messages. > > The first two are trivial. The third may break scripts that parse dmesg > output. I looked at scripts/bootgraph.pl, and I don't think it is >

Re: [PATCH] cpufreq: s3c2440: fix spelling mistake: "divsiors" -> "divisors"

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, May 2, 2018 7:37:21 AM CEST Viresh Kumar wrote: > On 30-04-18, 15:48, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake in s3c_freq_dbg debug message text. > > > > Signed-off-by: Colin Ian King >

Re: [PATCH] cpufreq: s3c2440: fix spelling mistake: "divsiors" -> "divisors"

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, May 2, 2018 7:37:21 AM CEST Viresh Kumar wrote: > On 30-04-18, 15:48, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake in s3c_freq_dbg debug message text. > > > > Signed-off-by: Colin Ian King > > --- > > drivers/cpufreq/s3c2440-cpufreq.c | 2 +-

Re: [PATCH 2/2] KVM: X86: Fix loss of CR3_PCID_INVD bit when guest writes CR3

2018-05-13 Thread Wanpeng Li
2018-05-13 16:03 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> From: Wanpeng Li >> >> SDM volume 3, section 4.10.4: >> >> * MOV to CR3. The behavior of the instruction depends on the value of >> CR4.PCIDE: >> — If CR4.PCIDE = 1 and

Re: [PATCH 2/2] KVM: X86: Fix loss of CR3_PCID_INVD bit when guest writes CR3

2018-05-13 Thread Wanpeng Li
2018-05-13 16:03 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> From: Wanpeng Li >> >> SDM volume 3, section 4.10.4: >> >> * MOV to CR3. The behavior of the instruction depends on the value of >> CR4.PCIDE: >> — If CR4.PCIDE = 1 and bit 63 of the instruction’s source operand is

Re: [PATCH V5] cpufreq: intel_pstate: allow trace in passive mode

2018-05-13 Thread Rafael J. Wysocki
On Thursday, May 3, 2018 8:22:47 AM CEST Doug Smythies wrote: > Allow use of the trace_pstate_sample trace function > when the intel_pstate driver is in passive mode. > Since the core_busy and scaled_busy fields are not > used, and it might be desirable to know which path > through the driver was

Re: [PATCH V5] cpufreq: intel_pstate: allow trace in passive mode

2018-05-13 Thread Rafael J. Wysocki
On Thursday, May 3, 2018 8:22:47 AM CEST Doug Smythies wrote: > Allow use of the trace_pstate_sample trace function > when the intel_pstate driver is in passive mode. > Since the core_busy and scaled_busy fields are not > used, and it might be desirable to know which path > through the driver was

Re: [PATCH] tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation

2018-05-13 Thread Rafael J. Wysocki
On Friday, May 4, 2018 3:46:22 PM CEST Doug Smythies wrote: > Allow the user to override the default trace buffer memory allocation > by adding a command line option to override the default. > > The patch also: > > Adds a SIGINT (i.e. CTRL C exit) handler, > so that things can be cleaned up

Re: [PATCH] tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation

2018-05-13 Thread Rafael J. Wysocki
On Friday, May 4, 2018 3:46:22 PM CEST Doug Smythies wrote: > Allow the user to override the default trace buffer memory allocation > by adding a command line option to override the default. > > The patch also: > > Adds a SIGINT (i.e. CTRL C exit) handler, > so that things can be cleaned up

Re: [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph

2018-05-13 Thread Rafael J. Wysocki
On Tuesday, May 8, 2018 8:36:44 PM CEST Srinivas Pandruvada wrote: > On Tue, 2018-05-08 at 17:12 +0200, Juri Lelli wrote: > > P-state selection algorithm (powersave or performance) is selected by > > echoing the desired choice to scaling_governor sysfs attribute and > > not > > to scaling_cur_freq

Re: [PATCH] Documentation/admin-guide/pm/intel_pstate: fix Active Mode w/o HWP paragraph

2018-05-13 Thread Rafael J. Wysocki
On Tuesday, May 8, 2018 8:36:44 PM CEST Srinivas Pandruvada wrote: > On Tue, 2018-05-08 at 17:12 +0200, Juri Lelli wrote: > > P-state selection algorithm (powersave or performance) is selected by > > echoing the desired choice to scaling_governor sysfs attribute and > > not > > to scaling_cur_freq

Re: [PATCH] kernel/sched/cpufreq_schedutil: remove stale comment

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, May 9, 2018 10:41:54 AM CEST Viresh Kumar wrote: > On 09-05-18, 10:40, Juri Lelli wrote: > > After commit 794a56ebd9a57 ("sched/cpufreq: Change the worker kthread to > > SCHED_DEADLINE") schedutil kthreads are "ignored" for a clock frequency > > selection point of view, so the

Re: [PATCH] kernel/sched/cpufreq_schedutil: remove stale comment

2018-05-13 Thread Rafael J. Wysocki
On Wednesday, May 9, 2018 10:41:54 AM CEST Viresh Kumar wrote: > On 09-05-18, 10:40, Juri Lelli wrote: > > After commit 794a56ebd9a57 ("sched/cpufreq: Change the worker kthread to > > SCHED_DEADLINE") schedutil kthreads are "ignored" for a clock frequency > > selection point of view, so the

[PATCH 2/2] arm64: Clear the stack

2018-05-13 Thread Alexander Popov
Hello Mark, Thanks a lot for your reply! On 11.05.2018 19:13, Mark Rutland wrote: > On Fri, May 11, 2018 at 06:50:09PM +0300, Alexander Popov wrote: >> On 06.05.2018 11:22, Alexander Popov wrote: >>> On 04.05.2018 14:09, Mark Rutland wrote: >>> + stack_left = sp & (THREAD_SIZE - 1);

[PATCH 2/2] arm64: Clear the stack

2018-05-13 Thread Alexander Popov
Hello Mark, Thanks a lot for your reply! On 11.05.2018 19:13, Mark Rutland wrote: > On Fri, May 11, 2018 at 06:50:09PM +0300, Alexander Popov wrote: >> On 06.05.2018 11:22, Alexander Popov wrote: >>> On 04.05.2018 14:09, Mark Rutland wrote: >>> + stack_left = sp & (THREAD_SIZE - 1);

Re: [PATCH] swiotlb: Silent unwanted warning "buffer is full"

2018-05-13 Thread Jean Delvare
On Sat, 12 May 2018 12:02:40 +0200, Christoph Hellwig wrote: > Thanks. > > I manually applied this for 4.17-rc, as the mail unfortunately was > garbled. Sorry about that. Because of the umlauts in the Cc list, the mail was encoded as quoted-printable instead of 7bit. I guess this is what caused

Re: [PATCH] swiotlb: Silent unwanted warning "buffer is full"

2018-05-13 Thread Jean Delvare
On Sat, 12 May 2018 12:02:40 +0200, Christoph Hellwig wrote: > Thanks. > > I manually applied this for 4.17-rc, as the mail unfortunately was > garbled. Sorry about that. Because of the umlauts in the Cc list, the mail was encoded as quoted-printable instead of 7bit. I guess this is what caused

QEMU ATA hard disk not detected

2018-05-13 Thread Paul Menzel
Dear Linux folks, In QEMU 2.11 a disk is only detected by the AHCI driver and not by libata. On QEMU’s Standard PC (i440FX + PIIX, 1996), that causes an attached drive not to be detected as that machine doesn’t support AHCI. Here is the output with the machine Standard PC (Q35 + ICH9,

QEMU ATA hard disk not detected

2018-05-13 Thread Paul Menzel
Dear Linux folks, In QEMU 2.11 a disk is only detected by the AHCI driver and not by libata. On QEMU’s Standard PC (i440FX + PIIX, 1996), that causes an attached drive not to be detected as that machine doesn’t support AHCI. Here is the output with the machine Standard PC (Q35 + ICH9,

Re: [PATCH v3 0/3] mailbox: ACPI: Remove incorrect error message about parsing PCCT

2018-05-13 Thread Rafael J. Wysocki
On Tuesday, May 1, 2018 2:39:04 AM CEST Al Stone wrote: > This set of patches provide some cleanup in ACPI for minor issues > found while correcting a bogus error message (the first two patches), > and the correction for the error message itself (patch 3/3). Note > that patches 1/3 and 2/3 are

Re: [PATCH v3 0/3] mailbox: ACPI: Remove incorrect error message about parsing PCCT

2018-05-13 Thread Rafael J. Wysocki
On Tuesday, May 1, 2018 2:39:04 AM CEST Al Stone wrote: > This set of patches provide some cleanup in ACPI for minor issues > found while correcting a bogus error message (the first two patches), > and the correction for the error message itself (patch 3/3). Note > that patches 1/3 and 2/3 are

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 15:53 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> From: Wanpeng Li > >> > >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > >> It should be checked when

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > 2018-05-13 15:53 GMT+08:00 Liran Alon : > > > > - kernel...@gmail.com wrote: > > > >> From: Wanpeng Li > >> > >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > >> It should be checked when PCIDE bit is not set, however commit > >>

Re: general protection fault in __radix_tree_delete

2018-05-13 Thread Dmitry Vyukov
On Sun, Apr 29, 2018 at 7:00 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > cdface5209349930ae1b51338763c8e029971b97 (Sun Apr 29 03:07:21 2018 +) > Merge tag 'for_linus_stable' of >

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 15:53 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> From: Wanpeng Li >> >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. >> It should be checked when PCIDE bit is not set, however commit >>

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Wanpeng Li
2018-05-13 15:53 GMT+08:00 Liran Alon : > > - kernel...@gmail.com wrote: > >> From: Wanpeng Li >> >> MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. >> It should be checked when PCIDE bit is not set, however commit >> 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits

Re: general protection fault in __radix_tree_delete

2018-05-13 Thread Dmitry Vyukov
On Sun, Apr 29, 2018 at 7:00 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > cdface5209349930ae1b51338763c8e029971b97 (Sun Apr 29 03:07:21 2018 +) > Merge tag 'for_linus_stable' of > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 > syzbot dashboard

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-13 Thread Simon Horman
On Fri, May 11, 2018 at 12:00:02PM +0200, Jacopo Mondi wrote: > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > development board. > > Signed-off-by: Jacopo Mondi Hi Niklas, As you reviewed the rest of the series I'm wondering if you're planning

Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input

2018-05-13 Thread Simon Horman
On Fri, May 11, 2018 at 12:00:02PM +0200, Jacopo Mondi wrote: > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > development board. > > Signed-off-by: Jacopo Mondi Hi Niklas, As you reviewed the rest of the series I'm wondering if you're planning to review this patch too.

Re: [PATCH 2/2] KVM: X86: Fix loss of CR3_PCID_INVD bit when guest writes CR3

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > SDM volume 3, section 4.10.4: > > * MOV to CR3. The behavior of the instruction depends on the value of > CR4.PCIDE: > — If CR4.PCIDE = 1 and bit 63 of the instruction’s source operand is > 1, the > instruction

Re: [PATCH 2/2] KVM: X86: Fix loss of CR3_PCID_INVD bit when guest writes CR3

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > SDM volume 3, section 4.10.4: > > * MOV to CR3. The behavior of the instruction depends on the value of > CR4.PCIDE: > — If CR4.PCIDE = 1 and bit 63 of the instruction’s source operand is > 1, the > instruction is not required to

Re: [PATCH v5 03/23] iommu/vt-d: add a flag for pasid table bound status

2018-05-13 Thread Lu Baolu
Hi again, On 05/12/2018 04:53 AM, Jacob Pan wrote: > Adding a flag in device domain into to track whether a guest or > user PASID table is bound to a device. > > Signed-off-by: Jacob Pan > --- > include/linux/intel-iommu.h | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v5 03/23] iommu/vt-d: add a flag for pasid table bound status

2018-05-13 Thread Lu Baolu
Hi again, On 05/12/2018 04:53 AM, Jacob Pan wrote: > Adding a flag in device domain into to track whether a guest or > user PASID table is bound to a device. > > Signed-off-by: Jacob Pan > --- > include/linux/intel-iommu.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical

Re: [PATCH 1/2] KVM: X86: Fix CR3 reserve bits

2018-05-13 Thread Liran Alon
- kernel...@gmail.com wrote: > From: Wanpeng Li > > MSB of CR3 is a reserved bit if the PCIDE bit is not set in CR4. > It should be checked when PCIDE bit is not set, however commit > 'd1cd3ce900441 ("KVM: MMU: check guest CR3 reserved bits based on > its physical address width")'

Re: KASAN: null-ptr-deref Write in linear_transfer

2018-05-13 Thread Takashi Iwai
On Sun, 13 May 2018 09:36:36 +0200, Eric Biggers wrote: > > On Wed, Jan 10, 2018 at 10:58:43AM +0100, Takashi Iwai wrote: > > On Wed, 10 Jan 2018 09:08:00 +0100, > > Eric Biggers wrote: > > > > > > On Fri, Jan 05, 2018 at 02:58:02AM -0800, syzbot wrote: > > > > Hello, > > > > > > > > syzkaller

Re: KASAN: null-ptr-deref Write in linear_transfer

2018-05-13 Thread Takashi Iwai
On Sun, 13 May 2018 09:36:36 +0200, Eric Biggers wrote: > > On Wed, Jan 10, 2018 at 10:58:43AM +0100, Takashi Iwai wrote: > > On Wed, 10 Jan 2018 09:08:00 +0100, > > Eric Biggers wrote: > > > > > > On Fri, Jan 05, 2018 at 02:58:02AM -0800, syzbot wrote: > > > > Hello, > > > > > > > > syzkaller

Re: KASAN: null-ptr-deref Write in linear_transfer

2018-05-13 Thread Eric Biggers
On Wed, Jan 10, 2018 at 10:58:43AM +0100, Takashi Iwai wrote: > On Wed, 10 Jan 2018 09:08:00 +0100, > Eric Biggers wrote: > > > > On Fri, Jan 05, 2018 at 02:58:02AM -0800, syzbot wrote: > > > Hello, > > > > > > syzkaller hit the following crash on > > > 30a7acd573899fd8b8ac39236eff6468b195ac7d >

Re: KASAN: null-ptr-deref Write in linear_transfer

2018-05-13 Thread Eric Biggers
On Wed, Jan 10, 2018 at 10:58:43AM +0100, Takashi Iwai wrote: > On Wed, 10 Jan 2018 09:08:00 +0100, > Eric Biggers wrote: > > > > On Fri, Jan 05, 2018 at 02:58:02AM -0800, syzbot wrote: > > > Hello, > > > > > > syzkaller hit the following crash on > > > 30a7acd573899fd8b8ac39236eff6468b195ac7d >

Re: [PATCH v5 03/23] iommu/vt-d: add a flag for pasid table bound status

2018-05-13 Thread Lu Baolu
Hi, On 05/12/2018 04:53 AM, Jacob Pan wrote: > Adding a flag in device domain into to track whether a guest or typo: ^^info Best regards, Lu Baolu > user PASID table is bound to a device. > > Signed-off-by: Jacob Pan > --- >

Re: [PATCH v5 03/23] iommu/vt-d: add a flag for pasid table bound status

2018-05-13 Thread Lu Baolu
Hi, On 05/12/2018 04:53 AM, Jacob Pan wrote: > Adding a flag in device domain into to track whether a guest or typo: ^^info Best regards, Lu Baolu > user PASID table is bound to a device. > > Signed-off-by: Jacob Pan > --- > include/linux/intel-iommu.h |

Re: [PATCH v5 00/13] ALSA: hda/ca0132: Patch Series for Recon3Di and Sound Blaster Z Support

2018-05-13 Thread Takashi Iwai
On Tue, 08 May 2018 19:20:00 +0200, Connor McAdams wrote: > > This patchset adds support for the Sound Blaster Z and the Recon3Di. > > In order to figure out how to get these cards to work, I made a program called > QemuHDADump[1], which uses the trace function of qemu to see interactions with >

Re: [PATCH v5 00/13] ALSA: hda/ca0132: Patch Series for Recon3Di and Sound Blaster Z Support

2018-05-13 Thread Takashi Iwai
On Tue, 08 May 2018 19:20:00 +0200, Connor McAdams wrote: > > This patchset adds support for the Sound Blaster Z and the Recon3Di. > > In order to figure out how to get these cards to work, I made a program called > QemuHDADump[1], which uses the trace function of qemu to see interactions with >

Re: [PATCH v5 03/13] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ

2018-05-13 Thread Takashi Iwai
On Tue, 08 May 2018 19:20:03 +0200, Connor McAdams wrote: > > This patch adds iomapping for the region2 section of memory on the SBZ. > This memory region is used in later patches for setting inputs and > outputs. If the mapping fails, the quirk is changed back to QUIRK_NONE > to avoid attempts

Re: [PATCH v5 03/13] ALSA: hda/ca0132: Add PCI region2 iomap for SBZ

2018-05-13 Thread Takashi Iwai
On Tue, 08 May 2018 19:20:03 +0200, Connor McAdams wrote: > > This patch adds iomapping for the region2 section of memory on the SBZ. > This memory region is used in later patches for setting inputs and > outputs. If the mapping fails, the quirk is changed back to QUIRK_NONE > to avoid attempts

Re: [PATCH] ALSA: control: fix a redundant-copy issue

2018-05-13 Thread Takashi Iwai
On Sat, 05 May 2018 20:38:03 +0200, Wenwen Wang wrote: > > In snd_ctl_elem_add_compat(), the fields of the struct 'data' need to be > copied from the corresponding fields of the struct 'data32' in userspace. > This is achieved by invoking copy_from_user() and get_user() functions. The > problem

Re: [PATCH] ALSA: control: fix a redundant-copy issue

2018-05-13 Thread Takashi Iwai
On Sat, 05 May 2018 20:38:03 +0200, Wenwen Wang wrote: > > In snd_ctl_elem_add_compat(), the fields of the struct 'data' need to be > copied from the corresponding fields of the struct 'data32' in userspace. > This is achieved by invoking copy_from_user() and get_user() functions. The > problem

Re: [PATCH v2 7/7] ALSA: usb: add UAC3 BADD profiles support

2018-05-13 Thread Takashi Iwai
On Fri, 11 May 2018 17:36:36 +0200, Jorge wrote: > > > > On 04/05/18 02:24, Ruslan Bilovol wrote: > > Recently released USB Audio Class 3.0 specification > > contains BADD (Basic Audio Device Definition) document > > which describes pre-defined UAC3 configurations. > > > > BADD support is

Re: [PATCH v2 7/7] ALSA: usb: add UAC3 BADD profiles support

2018-05-13 Thread Takashi Iwai
On Fri, 11 May 2018 17:36:36 +0200, Jorge wrote: > > > > On 04/05/18 02:24, Ruslan Bilovol wrote: > > Recently released USB Audio Class 3.0 specification > > contains BADD (Basic Audio Device Definition) document > > which describes pre-defined UAC3 configurations. > > > > BADD support is

[GIT PULL] dma mapping fix for 4.17-rc5

2018-05-13 Thread Christoph Hellwig
Hi Linus, one trivial dma-mapping regression fix for you. Note that this has NOT been in linux-next as I didn't want to disturb the branch in there which has the 4.18 material. I've asked Stephen to add the for-linus branch in addition to for-next so that this doesn't happen again. In addition

[GIT PULL] dma mapping fix for 4.17-rc5

2018-05-13 Thread Christoph Hellwig
Hi Linus, one trivial dma-mapping regression fix for you. Note that this has NOT been in linux-next as I didn't want to disturb the branch in there which has the 4.18 material. I've asked Stephen to add the for-linus branch in addition to for-next so that this doesn't happen again. In addition

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-13 Thread Tariq Toukan
On 02/05/2018 4:31 PM, Tariq Toukan wrote: On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words,

[PATCH] remoteproc: Add APSS based Qualcomm ADSP PIL driver for SDM845

2018-05-13 Thread Rohit kumar
This adds Qualcomm ADSP PIL driver support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar Signed-off-by: RajendraBabu Medisetti Signed-off-by: Krishnamurthy Renu

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

2018-05-13 Thread Tariq Toukan
On 02/05/2018 4:31 PM, Tariq Toukan wrote: On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words,

[PATCH] remoteproc: Add APSS based Qualcomm ADSP PIL driver for SDM845

2018-05-13 Thread Rohit kumar
This adds Qualcomm ADSP PIL driver support for SDM845 with ADSP bootup and shutdown operation handled from Application Processor SubSystem(APSS). Signed-off-by: Rohit kumar Signed-off-by: RajendraBabu Medisetti Signed-off-by: Krishnamurthy Renu ---

another branch for linux-next

2018-05-13 Thread Christoph Hellwig
Hi Stephen, can you please add the for-linus branch of git://git.infradead.org/users/hch/dma-mapping.git to linux-next? You already carry the for-next branch, but it turns out I'll need another branch for late fixes so that for-next can remain unmerged and unrebased.

[PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-13 Thread Christophe JAILLET
When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Signed-off-by: Christophe JAILLET --- v1 -> v2: More places to update have been added to the patch --- drivers/infiniband/hw/mlx5/cq.c| 2 +-

another branch for linux-next

2018-05-13 Thread Christoph Hellwig
Hi Stephen, can you please add the for-linus branch of git://git.infradead.org/users/hch/dma-mapping.git to linux-next? You already carry the for-next branch, but it turns out I'll need another branch for late fixes so that for-next can remain unmerged and unrebased.

[PATCH v2] {net, IB}/mlx5: Use 'kvfree()' for memory allocated by 'kvzalloc()'

2018-05-13 Thread Christophe JAILLET
When 'kvzalloc()' is used to allocate memory, 'kvfree()' must be used to free it. Signed-off-by: Christophe JAILLET --- v1 -> v2: More places to update have been added to the patch --- drivers/infiniband/hw/mlx5/cq.c| 2 +-

Re: [Intel-wired-lan] [PATCH] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-05-13 Thread Neftin, Sasha
On 5/10/2018 21:42, Keller, Jacob E wrote: -Original Message- From: Benjamin Poirier [mailto:bpoir...@suse.com] Sent: Thursday, May 10, 2018 12:29 AM To: Kirsher, Jeffrey T Cc: Keller, Jacob E ; Achim Mildenberger

Re: [Intel-wired-lan] [PATCH] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-05-13 Thread Neftin, Sasha
On 5/10/2018 21:42, Keller, Jacob E wrote: -Original Message- From: Benjamin Poirier [mailto:bpoir...@suse.com] Sent: Thursday, May 10, 2018 12:29 AM To: Kirsher, Jeffrey T Cc: Keller, Jacob E ; Achim Mildenberger ; olouvig...@gmail.com; jaya...@goubiq.com; ehabk...@redhat.com;

Re: BUG: unable to handle kernel paging request in cgroup_mt_destroy_v1

2018-05-13 Thread Eric Biggers
On Wed, Jan 31, 2018 at 05:58:01PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3da90b159b146672f830bcd2489dd3a1f4e9e089 (Wed Jan 31 03:07:32 2018 +) > Merge tag 'f2fs-for-4.16-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs > >

Re: BUG: unable to handle kernel paging request in cgroup_mt_destroy_v1

2018-05-13 Thread Eric Biggers
On Wed, Jan 31, 2018 at 05:58:01PM -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 3da90b159b146672f830bcd2489dd3a1f4e9e089 (Wed Jan 31 03:07:32 2018 +) > Merge tag 'f2fs-for-4.16-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs > >

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-13 Thread Joel Fernandes
On Sat, May 12, 2018 at 11:04:43PM -0700, Joel Fernandes wrote: > On Thu, May 10, 2018 at 04:05:53PM +0100, Patrick Bellasi wrote: > > Schedutil updates for FAIR tasks are triggered implicitly each time a > > cfs_rq's utilization is updated via cfs_rq_util_change(), currently > > called by

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-13 Thread Joel Fernandes
On Sat, May 12, 2018 at 11:04:43PM -0700, Joel Fernandes wrote: > On Thu, May 10, 2018 at 04:05:53PM +0100, Patrick Bellasi wrote: > > Schedutil updates for FAIR tasks are triggered implicitly each time a > > cfs_rq's utilization is updated via cfs_rq_util_change(), currently > > called by

Re: KASAN: use-after-free Write in irq_bypass_register_consumer

2018-05-13 Thread Eric Biggers
On Thu, Apr 05, 2018 at 08:15:24PM -0700, Eric Biggers wrote: > On Mon, Jan 29, 2018 at 01:29:48PM +0800, Tianyu Lan wrote: > > > > > > On 1/27/2018 7:27 AM, Eric Biggers wrote: > > > On Sat, Dec 16, 2017 at 04:37:02PM +0800, Lan, Tianyu wrote: > > > > The root cause is that kvm_irqfd_assign()

Re: KASAN: use-after-free Write in irq_bypass_register_consumer

2018-05-13 Thread Eric Biggers
On Thu, Apr 05, 2018 at 08:15:24PM -0700, Eric Biggers wrote: > On Mon, Jan 29, 2018 at 01:29:48PM +0800, Tianyu Lan wrote: > > > > > > On 1/27/2018 7:27 AM, Eric Biggers wrote: > > > On Sat, Dec 16, 2017 at 04:37:02PM +0800, Lan, Tianyu wrote: > > > > The root cause is that kvm_irqfd_assign()

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-13 Thread Joel Fernandes
On Thu, May 10, 2018 at 04:05:53PM +0100, Patrick Bellasi wrote: > Schedutil updates for FAIR tasks are triggered implicitly each time a > cfs_rq's utilization is updated via cfs_rq_util_change(), currently > called by update_cfs_rq_load_avg(), when the utilization of a cfs_rq has > changed, and

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-13 Thread Joel Fernandes
On Thu, May 10, 2018 at 04:05:53PM +0100, Patrick Bellasi wrote: > Schedutil updates for FAIR tasks are triggered implicitly each time a > cfs_rq's utilization is updated via cfs_rq_util_change(), currently > called by update_cfs_rq_load_avg(), when the utilization of a cfs_rq has > changed, and

<    2   3   4   5   6   7