RE: [PATCH] kernfs: fix dentry unexpected skip

> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hatayama, Daisuke > Sent: Saturday, May 19, 2018 12:43 AM > To: 'gre...@linuxfoundation.org' > Cc: Okajima, Toshiyuki/岡嶋 寿行

RE: [PATCH] kernfs: fix dentry unexpected skip

> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hatayama, Daisuke > Sent: Saturday, May 19, 2018 12:43 AM > To: 'gre...@linuxfoundation.org' > Cc: Okajima, Toshiyuki/岡嶋 寿行 ; > linux-kernel@vger.kernel.org;

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > > > Signed-off-by: Joel Fernandes (Google) > >

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/rcu.h

[PATCH RESEND] platform/chrome: cros_ec_lpc: Add support for newer Google devices using custom coreboot firmware or stock SeaBIOS.

Custom coreboot firmware does not contain "Google_*" as BIOS version string; also, booting through stock SeaBIOS will present an empty BIOS version string to Linux. So the generic match at the top would not work. A previous patch added the "GOOGLE" match for DMI system vendor, but newer machines

[PATCH RESEND] platform/chrome: cros_ec_lpc: Add support for newer Google devices using custom coreboot firmware or stock SeaBIOS.

Custom coreboot firmware does not contain "Google_*" as BIOS version string; also, booting through stock SeaBIOS will present an empty BIOS version string to Linux. So the generic match at the top would not work. A previous patch added the "GOOGLE" match for DMI system vendor, but newer machines

Re: [PATCH v2 07/11] cpufreq: tegra20: Remove unnecessary parentheses

On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unnecessary parentheses as suggested by the checkpatch script. > > Signed-off-by: Dmitry Osipenko > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 07/11] cpufreq: tegra20: Remove unnecessary parentheses

On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unnecessary parentheses as suggested by the checkpatch script. > > Signed-off-by: Dmitry Osipenko > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Xen-devel][RFC 2/3] xen/grant-table: Extend API to work with DMA buffers

On 05/19/2018 01:19 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Andrushchenko --- drivers/xen/grant-table.c | 49

Re: [Xen-devel][RFC 2/3] xen/grant-table: Extend API to work with DMA buffers

On 05/19/2018 01:19 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Andrushchenko --- drivers/xen/grant-table.c | 49 +++ include/xen/grant_table.h | 7 ++ 2

Re: [PATCH v2 03/11] cpufreq: tegra20: Clean up included headers

On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unused/unneeded headers and sort them in the alphabet order. > > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/cpufreq/tegra20-cpufreq.c | 12 > 1 file changed, 4

Re: [PATCH v2 03/11] cpufreq: tegra20: Clean up included headers

On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unused/unneeded headers and sort them in the alphabet order. > > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/cpufreq/tegra20-cpufreq.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > >

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/19/2018 01:04 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko A commit message would be useful. Sure, v1 will have it Signed-off-by: Oleksandr Andrushchenko

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/19/2018 01:04 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko A commit message would be useful. Sure, v1 will have it Signed-off-by: Oleksandr Andrushchenko for (i = 0; i < nr_pages; i++) { -

Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 23:39 GMT+09:00 Sam Ravnborg : >> @@ -544,10 +530,10 @@ void conf_parse(const char *name) >> if (!modules_sym) >> modules_sym = sym_find( "n" ); >> >> - tmp = rootmenu.prompt->text; >> - rootmenu.prompt->text = _(rootmenu.prompt->text); >>

Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 23:39 GMT+09:00 Sam Ravnborg : >> @@ -544,10 +530,10 @@ void conf_parse(const char *name) >> if (!modules_sym) >> modules_sym = sym_find( "n" ); >> >> - tmp = rootmenu.prompt->text; >> - rootmenu.prompt->text = _(rootmenu.prompt->text); >> -

Re: [PATCH v4 07/31] kconfig: add built-in function support

Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...)

Re: [PATCH v4 07/31] kconfig: add built-in function support

Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...) >> >> This commit

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling delay of the irq_work

Re: [PATCH] cpufreq: Add Kryo CPU scaling driver

More comments after Russell's reply. On 19-05-18, 14:35, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > +

Re: [PATCH] cpufreq: Add Kryo CPU scaling driver

More comments after Russell's reply. On 19-05-18, 14:35, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > +

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-21 13:51 GMT+09:00 Randy Dunlap : > On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >>> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: Building nconf requires ncurses, but its presence is not

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-21 13:51 GMT+09:00 Randy Dunlap : > On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >>> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: Building nconf requires ncurses, but its presence is not checked. Check and configure necessary

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

On Thu, May 10, 2018 at 7:18 PM, Souptick Joarder wrote: > On Wed, Apr 25, 2018 at 10:29 AM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault and huge_fault >> handler. For now, this is just documenting that the >> function

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

On Thu, May 10, 2018 at 7:18 PM, Souptick Joarder wrote: > On Wed, Apr 25, 2018 at 10:29 AM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault and huge_fault >> handler. For now, this is just documenting that the >> function returns a VM_FAULT value rather than an errno. >>

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

On 05/20/2018 09:48 PM, Masahiro Yamada wrote: > 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >>> Building nconf requires ncurses, but its presence is not checked. >>> Check and configure necessary packages by a shell script like

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

On 05/20/2018 09:48 PM, Masahiro Yamada wrote: > 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >>> Building nconf requires ncurses, but its presence is not checked. >>> Check and configure necessary packages by a shell script like the >>> other GUI

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

On 05/20/2018 09:42 PM, Joel Fernandes wrote: > rcu_seq_snap may be tricky to decipher. Lets document how it works with > an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 33 - > 1 file

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

On 05/20/2018 09:42 PM, Joel Fernandes wrote: > rcu_seq_snap may be tricky to decipher. Lets document how it works with > an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 33 - > 1 file changed, 32 insertions(+),

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-21 8:41 GMT+09:00 Randy Dunlap : > On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >> Building nconf requires ncurses, but its presence is not checked. >> Check and configure necessary packages by a shell script like the >> other GUI frontends. >> >> Signed-off-by:

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-21 8:41 GMT+09:00 Randy Dunlap : > On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >> Building nconf requires ncurses, but its presence is not checked. >> Check and configure necessary packages by a shell script like the >> other GUI frontends. >> >> Signed-off-by: Masahiro Yamada >> ---

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

On 19-05-18, 14:45, ilia...@codeaurora.org wrote: > Hi Viresh, > > If I send patches in reply, it will produce new patches, instead of answers > in the thread. Please find below the file dump. There is one email from you which appears to be just fine and appears to be in reply to this thread

Re: [PATCH v8 10/15] cpufreq: Add Kryo CPU scaling driver

On 19-05-18, 14:45, ilia...@codeaurora.org wrote: > Hi Viresh, > > If I send patches in reply, it will produce new patches, instead of answers > in the thread. Please find below the file dump. There is one email from you which appears to be just fine and appears to be in reply to this thread

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

Hi. 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > s/environments/environment variables/ Will fix. > >> +* They will be written out to include/config/auto.conf.cmd >> +*/ >> + env_add(name, value); >> + >> + return xstrdup(value); >> +} >> + >>

Re: [PATCH v4 03/31] kconfig: reference environment variables directly and remove 'option env='

Hi. 2018-05-21 0:46 GMT+09:00 Ulf Magnusson : > s/environments/environment variables/ Will fix. > >> +* They will be written out to include/config/auto.conf.cmd >> +*/ >> + env_add(name, value); >> + >> + return xstrdup(value); >> +} >> + >> +void

[PATCH 07/30] staging: lustre: simplify capability dropping.

Lustre has a 'squash credentials' concept similar to the "anon_uid" for nfsd. When accessing a file with squashed credentials, we need to also drop capabilities. Linux has cap_drop_fs_set() and cap_drop_nfsd_set(). Rather than taking a completely different approach, this patch changes lustre to

[PATCH 07/30] staging: lustre: simplify capability dropping.

Lustre has a 'squash credentials' concept similar to the "anon_uid" for nfsd. When accessing a file with squashed credentials, we need to also drop capabilities. Linux has cap_drop_fs_set() and cap_drop_nfsd_set(). Rather than taking a completely different approach, this patch changes lustre to

Re: [PATCH v2 0/4] fixes, cleanups for rcu/dev

On Sun, May 20, 2018 at 09:32:47PM -0700, Joel Fernandes wrote: > Hi Paul, > > Here are some patches reworked with a few comments on few of the patches > from previous series: https://lkml.org/lkml/2018/5/13/296 > > 4/4 is a new addition which fixes a potential issue. > > Let me know what you

Re: [PATCH v2 0/4] fixes, cleanups for rcu/dev

On Sun, May 20, 2018 at 09:32:47PM -0700, Joel Fernandes wrote: > Hi Paul, > > Here are some patches reworked with a few comments on few of the patches > from previous series: https://lkml.org/lkml/2018/5/13/296 > > 4/4 is a new addition which fixes a potential issue. > > Let me know what you

[PATCH v3 0/4] fixes, cleanups for rcu/dev

Hi Paul, Here are some patches reworked with a few comments on few of the patches from previous series: https://lkml.org/lkml/2018/5/13/296 4/4 is a new addition which fixes a potential issue. Please disregard the v2, and consider this v3 instead, since that v2 was a pure patch generation mess.

[PATCH v3 0/4] fixes, cleanups for rcu/dev

Hi Paul, Here are some patches reworked with a few comments on few of the patches from previous series: https://lkml.org/lkml/2018/5/13/296 4/4 is a new addition which fixes a potential issue. Please disregard the v2, and consider this v3 instead, since that v2 was a pure patch generation mess.

[PATCH v3 3/4] rcu: Use better variable names in funnel locking loop

The funnel locking loop in rcu_start_this_gp uses rcu_root as a temporary variable while walking the combining tree. This causes a tiresome exercise of a code reader reminding themselves that rcu_root may not be root. Lets just call it rnp, and rename other variables as well to be more

[PATCH v3 3/4] rcu: Use better variable names in funnel locking loop

The funnel locking loop in rcu_start_this_gp uses rcu_root as a temporary variable while walking the combining tree. This causes a tiresome exercise of a code reader reminding themselves that rcu_root may not be root. Lets just call it rnp, and rename other variables as well to be more

[PATCH v3 2/4] rcu: Cleanup the variables used to request a new grace period

The 'c' variable was used previously to store the grace period that is being requested. However it is not very meaningful since the gp_seq conversions. This patch replaces it with gp_seq_req indicating that this is the grace period that was requested. Also updating tracing with the new name.

[PATCH v3 2/4] rcu: Cleanup the variables used to request a new grace period

The 'c' variable was used previously to store the grace period that is being requested. However it is not very meaningful since the gp_seq conversions. This patch replaces it with gp_seq_req indicating that this is the grace period that was requested. Also updating tracing with the new name.

[PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

rcu_seq_snap may be tricky to decipher. Lets document how it works with an example to make it easier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git

[PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

We acquire gp_seq_needed locklessly. To be safe, lets do the unlocking after the access. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index

[PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

rcu_seq_snap may be tricky to decipher. Lets document how it works with an example to make it easier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu.h | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h

[PATCH v3 4/4] rcu: Unlock non-start node only after accessing its gp_seq_needed

We acquire gp_seq_needed locklessly. To be safe, lets do the unlocking after the access. Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 879c67a31116..efbd21b2a1a6 100644 ---

[PATCH 26/30] staging: lustre: remove libcfs_all from ptlrpc

Some files didn't need it at all, others just needed one or two includes. Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/ptlrpc/errno.c |1 - drivers/staging/lustre/lustre/ptlrpc/events.c |2 +- drivers/staging/lustre/lustre/ptlrpc/llog_client.c |

[PATCH 27/30] staging: lustre: remove libcfs_all.h from fid, fld, obdclass

None of these files seem to nee libcfs_all.h Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/fid/fid_lib.c|1 - drivers/staging/lustre/lustre/fid/fid_request.c|1 - drivers/staging/lustre/lustre/fid/lproc_fid.c |1 -

[PATCH 30/30] staging: lustre: remove libcfs_all.h

In the remaining files that include libcfs_all.h, replace it with other include files as necessary, then remove libcfs_all.h Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_all.h | 88 drivers/staging/lustre/lnet/libcfs/debug.c

[PATCH 26/30] staging: lustre: remove libcfs_all from ptlrpc

Some files didn't need it at all, others just needed one or two includes. Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/ptlrpc/errno.c |1 - drivers/staging/lustre/lustre/ptlrpc/events.c |2 +- drivers/staging/lustre/lustre/ptlrpc/llog_client.c |2 --

[PATCH 27/30] staging: lustre: remove libcfs_all.h from fid, fld, obdclass

None of these files seem to nee libcfs_all.h Signed-off-by: NeilBrown --- drivers/staging/lustre/lustre/fid/fid_lib.c|1 - drivers/staging/lustre/lustre/fid/fid_request.c|1 - drivers/staging/lustre/lustre/fid/lproc_fid.c |1 -

[PATCH 30/30] staging: lustre: remove libcfs_all.h

In the remaining files that include libcfs_all.h, replace it with other include files as necessary, then remove libcfs_all.h Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_all.h | 88 drivers/staging/lustre/lnet/libcfs/debug.c |5 +

[PATCH 24/30] staging: lustre: remove libcfs_all.h from lustre/include/*.h

Instead of the catch-all libcfs_all.h, just include the files actually needed in different places. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_crypto.h|3 +++ .../staging/lustre/lustre/include/lprocfs_status.h |2 +-

[PATCH 24/30] staging: lustre: remove libcfs_all.h from lustre/include/*.h

Instead of the catch-all libcfs_all.h, just include the files actually needed in different places. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_crypto.h|3 +++ .../staging/lustre/lustre/include/lprocfs_status.h |2 +-

[PATCH 28/30] staging: lustre: remove remaining libcfs_all.h includes from lustre/lustre

Most of these aren't needed, a few can be simplified. Signed-off-by: NeilBrown --- .../staging/lustre/lustre/include/lustre_intent.h |2 ++ drivers/staging/lustre/lustre/ldlm/l_lock.c|1 - drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |1 -

[PATCH 25/30] staging: lustre: remove libcfs_all.h from remaining .h files.

Now no *.h files include libcfs_all.h - only *.c files. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_hash.h |3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h |1 - drivers/staging/lustre/lustre/fld/fld_internal.h |1 -

[PATCH 23/30] staging: lustre: remove libcfs_all.h from includes lustre/lnet

Some of these include files didn't need to include libcfs_all.h. A couple did so replace with just the base include files needed. Signed-off-by: NeilBrown --- drivers/staging/lustre/lnet/libcfs/tracefile.h |8 +++- drivers/staging/lustre/lnet/selftest/conrpc.h |1

[PATCH 29/30] staging: lustre: move all libcfs_all includes except in lustre/lnet/libcfs/

Again, most of these are not needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_string.h|2 ++ drivers/staging/lustre/lnet/lnet/lib-socket.c |1 - drivers/staging/lustre/lnet/lnet/nidstrings.c |5 -

[PATCH 25/30] staging: lustre: remove libcfs_all.h from remaining .h files.

Now no *.h files include libcfs_all.h - only *.c files. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_hash.h |3 +++ drivers/staging/lustre/lustre/fid/fid_internal.h |1 - drivers/staging/lustre/lustre/fld/fld_internal.h |1 -

[PATCH 23/30] staging: lustre: remove libcfs_all.h from includes lustre/lnet

Some of these include files didn't need to include libcfs_all.h. A couple did so replace with just the base include files needed. Signed-off-by: NeilBrown --- drivers/staging/lustre/lnet/libcfs/tracefile.h |8 +++- drivers/staging/lustre/lnet/selftest/conrpc.h |1 -

[PATCH 29/30] staging: lustre: move all libcfs_all includes except in lustre/lnet/libcfs/

Again, most of these are not needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_string.h|2 ++ drivers/staging/lustre/lnet/lnet/lib-socket.c |1 - drivers/staging/lustre/lnet/lnet/nidstrings.c |5 -

[PATCH 28/30] staging: lustre: remove remaining libcfs_all.h includes from lustre/lustre

Most of these aren't needed, a few can be simplified. Signed-off-by: NeilBrown --- .../staging/lustre/lustre/include/lustre_intent.h |2 ++ drivers/staging/lustre/lustre/ldlm/l_lock.c|1 - drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |1 -

[PATCH 18/30] staging: lustre: replace memory_presure funcitons by standard interfaces.

Use memalloc_noreclaim_save() and memalloc_noreclaim_restore(), and for testing, just directly test the flag in current->flags Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_prim.h | 31

[PATCH 21/30] staging: lustre: don't include libcfs.h in lnet/lib-lnet.h

We want to be more focused in what is included where. So we remove libcfs.h from where it isn't needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_debug.h |1 + .../lustre/include/linux/libcfs/libcfs_fail.h |3 +++

[PATCH 19/30] staging: lustre: discard libcfs_prim.h

This file no longer contains enough content to justify a separate file. So merge with libcfs.h. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h | 12 - .../lustre/include/linux/libcfs/libcfs_prim.h | 51 2 files

[PATCH 18/30] staging: lustre: replace memory_presure funcitons by standard interfaces.

Use memalloc_noreclaim_save() and memalloc_noreclaim_restore(), and for testing, just directly test the flag in current->flags Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_prim.h | 31 .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 11

[PATCH 21/30] staging: lustre: don't include libcfs.h in lnet/lib-lnet.h

We want to be more focused in what is included where. So we remove libcfs.h from where it isn't needed. Signed-off-by: NeilBrown --- .../lustre/include/linux/libcfs/libcfs_debug.h |1 + .../lustre/include/linux/libcfs/libcfs_fail.h |3 +++

[PATCH 19/30] staging: lustre: discard libcfs_prim.h

This file no longer contains enough content to justify a separate file. So merge with libcfs.h. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h | 12 - .../lustre/include/linux/libcfs/libcfs_prim.h | 51 2 files changed, 11

[PATCH 16/30] staging: lustre: move lnet_debug_log_upcall declaration to tracefile.h

Both files that use this variable include tracefile.h, and it seems a more suitable home for the declaration. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |5 - drivers/staging/lustre/lnet/libcfs/tracefile.h |5 + 2 files

[PATCH 22/30] staging: lustre: remove libcfs_all.h includes from lnet/klnd

Other smaller include files are sufficient. Signed-off-by: NeilBrown --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|1 - .../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 - .../lustre/lnet/klnds/socklnd/socklnd_lib.c|1 + 3 files changed, 1

[PATCH 22/30] staging: lustre: remove libcfs_all.h includes from lnet/klnd

Other smaller include files are sufficient. Signed-off-by: NeilBrown --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|1 - .../staging/lustre/lnet/klnds/socklnd/socklnd.h|1 - .../lustre/lnet/klnds/socklnd/socklnd_lib.c|1 + 3 files changed, 1 insertion(+), 2

[PATCH 16/30] staging: lustre: move lnet_debug_log_upcall declaration to tracefile.h

Both files that use this variable include tracefile.h, and it seems a more suitable home for the declaration. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |5 - drivers/staging/lustre/lnet/libcfs/tracefile.h |5 + 2 files changed, 5

[PATCH 17/30] staging: lustre: move RESV_PORT definitions to lnet/lib-lnet.h

These are network related on only used in lnet, so move to lib-lnet.h Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 .../staging/lustre/include/linux/lnet/lib-lnet.h |4 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 15/30] staging: lustre: make lnet_debugfs_symlink_def local to libcfs/modules.c

This type is only used in libcfs/module.c, so make it local to there. If any other module ever wanted to add its own symlinks, it would probably be easiest to export lnet_debugfs_root and just call debugfs_create_symlink as required. Signed-off-by: NeilBrown ---

[PATCH 17/30] staging: lustre: move RESV_PORT definitions to lnet/lib-lnet.h

These are network related on only used in lnet, so move to lib-lnet.h Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 .../staging/lustre/include/linux/lnet/lib-lnet.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 15/30] staging: lustre: make lnet_debugfs_symlink_def local to libcfs/modules.c

This type is only used in libcfs/module.c, so make it local to there. If any other module ever wanted to add its own symlinks, it would probably be easiest to export lnet_debugfs_root and just call debugfs_create_symlink as required. Signed-off-by: NeilBrown ---

[PATCH 20/30] staging: lustre: start moving includes out of libcfs.h

Lots of places include libcfs.h, and it includes lots of other include files. Many of these aren't needed in many places. It is tidier and better documentation to just include what is needed. So remove all the includes from libcfs.h and create libcfs_all.h which contains them. Then change

[PATCH 20/30] staging: lustre: start moving includes out of libcfs.h

Lots of places include libcfs.h, and it includes lots of other include files. Many of these aren't needed in many places. It is tidier and better documentation to just include what is needed. So remove all the includes from libcfs.h and create libcfs_all.h which contains them. Then change

[PATCH 13/30] staging: lustre: replace libcfs_register_ioctl with a blocking notifier_chain

libcfs allows other modules to register handlers for ioctls. The implementation it uses for this is nearly identical to a blocking notifier chain, so change to use that. The biggest difference is that the return value from notifier has a defined format, where libcfs_register_ioctl uses -EINVAL to

[PATCH 14/30] staging: lustre: clean up __LIBCFS_H macro

There is some confusion with names here - make it all uniform. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h

[PATCH 14/30] staging: lustre: clean up __LIBCFS_H macro

There is some confusion with names here - make it all uniform. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs.h

[PATCH 13/30] staging: lustre: replace libcfs_register_ioctl with a blocking notifier_chain

libcfs allows other modules to register handlers for ioctls. The implementation it uses for this is nearly identical to a blocking notifier chain, so change to use that. The biggest difference is that the return value from notifier has a defined format, where libcfs_register_ioctl uses -EINVAL to

[PATCH 12/30] staging: lustre: discard cfs_block_sigsinv()

cfs_block_sigsinv() and cfs_restore_sigs() are simple wrappers which save a couple of line of code and hurt readability for people not familiar with them. They aren't used often enough to be worthwhile, so discard them and open-code the functionality. The sigorsets() call isn't needed as or-ing

[PATCH 10/30] staging: lustre: discard CFS_TICK

This undocumented macro seems to represent "a small amount of time". Sometimes it is used as-is, some times it is multiplied by 5 for no obvious reason. It does not appear that there is any connection between the different places it is used - they all just want a short period for different

[PATCH 11/30] staging: lustre: move LERRCHKSUM() to libcfs_debug.h

This macro is only used for debug messages, so use it to the debug code. Also improve the documentation slightly. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |7 --- .../lustre/include/linux/libcfs/libcfs_debug.h |7 +++ 2

[PATCH 12/30] staging: lustre: discard cfs_block_sigsinv()

cfs_block_sigsinv() and cfs_restore_sigs() are simple wrappers which save a couple of line of code and hurt readability for people not familiar with them. They aren't used often enough to be worthwhile, so discard them and open-code the functionality. The sigorsets() call isn't needed as or-ing

[PATCH 10/30] staging: lustre: discard CFS_TICK

This undocumented macro seems to represent "a small amount of time". Sometimes it is used as-is, some times it is multiplied by 5 for no obvious reason. It does not appear that there is any connection between the different places it is used - they all just want a short period for different

[PATCH 11/30] staging: lustre: move LERRCHKSUM() to libcfs_debug.h

This macro is only used for debug messages, so use it to the debug code. Also improve the documentation slightly. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |7 --- .../lustre/include/linux/libcfs/libcfs_debug.h |7 +++ 2 files changed, 7

[PATCH 08/30] staging: lustre: discard cfs_cap_t, use kernel_cap_t

lustre only sends 32bits of capabilities in on-the-wire RPC calls. It current strips off higher bits and uses a 32bit cfs_cap_t throughout. Though there is a small memory cost, it is cleaner to use kernel_cap_t throughout and only truncate when marshalling data for RPC calls. So this patch

[PATCH 09/30] staging: lustre: discard LOWEST_BIT_SET()

This macro is only used once to test if a value is a power of two. So use is_power_of_2() instead and discard the macro. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |2 -- drivers/staging/lustre/lnet/lnet/lib-eq.c |2 +- 2

[PATCH 06/30] staging: lustre: remove current_pid() and current_comm()

Just use current->pid and current->comm directly, instead of having wrappers. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/curproc.h |4 drivers/staging/lustre/lnet/libcfs/debug.c |2 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c

[PATCH 08/30] staging: lustre: discard cfs_cap_t, use kernel_cap_t

lustre only sends 32bits of capabilities in on-the-wire RPC calls. It current strips off higher bits and uses a 32bit cfs_cap_t throughout. Though there is a small memory cost, it is cleaner to use kernel_cap_t throughout and only truncate when marshalling data for RPC calls. So this patch

[PATCH 09/30] staging: lustre: discard LOWEST_BIT_SET()

This macro is only used once to test if a value is a power of two. So use is_power_of_2() instead and discard the macro. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/libcfs.h |2 -- drivers/staging/lustre/lnet/lnet/lib-eq.c |2 +- 2 files changed, 1

[PATCH 06/30] staging: lustre: remove current_pid() and current_comm()

Just use current->pid and current->comm directly, instead of having wrappers. Signed-off-by: NeilBrown --- .../staging/lustre/include/linux/libcfs/curproc.h |4 drivers/staging/lustre/lnet/libcfs/debug.c |2 +- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |2 +-

[PATCH 03/30] staging: lustre: move files out of lustre/lnet/libcfs/linux/

There is no longer any value in having this separate subdirectory, so promote the files in it. Also tidy the Makefile a little to use the common "*-obj-y" macro name. This will allow individual files to be conditionally compiled. Signed-off-by: NeilBrown ---

[PATCH 03/30] staging: lustre: move files out of lustre/lnet/libcfs/linux/

There is no longer any value in having this separate subdirectory, so promote the files in it. Also tidy the Makefile a little to use the common "*-obj-y" macro name. This will allow individual files to be conditionally compiled. Signed-off-by: NeilBrown ---

  1   2   3   4   5   6   7   >