Re: [PATCH 0/2] x86/intel_rdt and perf/x86: Fix lack of coordination with perf

2018-08-06 Thread Reinette Chatre
Hi Peter, On 8/3/2018 11:37 AM, Reinette Chatre wrote: > On 8/3/2018 8:25 AM, Peter Zijlstra wrote: >> On Fri, Aug 03, 2018 at 08:18:09AM -0700, Reinette Chatre wrote: >>> You state that you understand what we are trying to do and I hope that I >>> convinced you that we are not able to accomplish

Re: [PATCH 0/2] x86/intel_rdt and perf/x86: Fix lack of coordination with perf

2018-08-06 Thread Reinette Chatre
Hi Peter, On 8/3/2018 11:37 AM, Reinette Chatre wrote: > On 8/3/2018 8:25 AM, Peter Zijlstra wrote: >> On Fri, Aug 03, 2018 at 08:18:09AM -0700, Reinette Chatre wrote: >>> You state that you understand what we are trying to do and I hope that I >>> convinced you that we are not able to accomplish

[PATCH v2] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

[PATCH v2] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 21:45:53, Michal Hocko wrote: > [CCing Greg - the email thread starts here > http://lkml.kernel.org/r/5e979605729c1...@google.com] now for real > > On Mon 06-08-18 12:12:02, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-08-06 Thread Bjorn Helgaas
On Mon, Aug 6, 2018 at 1:39 PM wrote: > > On 08/05/2018 02:06 AM, Tal Gilboa wrote: > > On 7/31/2018 6:10 PM, Alex G. wrote: > >> On 07/31/2018 01:40 AM, Tal Gilboa wrote: > >> [snip] > >> @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct > >> pci_dev *dev) > >>/*

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 21:45:53, Michal Hocko wrote: > [CCing Greg - the email thread starts here > http://lkml.kernel.org/r/5e979605729c1...@google.com] now for real > > On Mon 06-08-18 12:12:02, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch and the reproducer did

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-08-06 Thread Bjorn Helgaas
On Mon, Aug 6, 2018 at 1:39 PM wrote: > > On 08/05/2018 02:06 AM, Tal Gilboa wrote: > > On 7/31/2018 6:10 PM, Alex G. wrote: > >> On 07/31/2018 01:40 AM, Tal Gilboa wrote: > >> [snip] > >> @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct > >> pci_dev *dev) > >>/*

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
[CCing Greg - the email thread starts here http://lkml.kernel.org/r/5e979605729c1...@google.com] On Mon 06-08-18 12:12:02, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger > crash: OK, this is reassuring. Btw Greg has pointed out

Re: linux-next: manual merge of the tip tree with the rdma tree

2018-08-06 Thread Jason Gunthorpe
On Mon, Aug 06, 2018 at 02:53:31PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tip tree got a conflict in: > > drivers/infiniband/core/rdma_core.c > > between commit: > > 9867f5c6695f ("IB/uverbs: Convert 'bool exclusive' into an enum") > > from the rdma

Re: linux-next: manual merge of the tip tree with the rdma tree

2018-08-06 Thread Jason Gunthorpe
On Mon, Aug 06, 2018 at 02:53:31PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tip tree got a conflict in: > > drivers/infiniband/core/rdma_core.c > > between commit: > > 9867f5c6695f ("IB/uverbs: Convert 'bool exclusive' into an enum") > > from the rdma

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
[CCing Greg - the email thread starts here http://lkml.kernel.org/r/5e979605729c1...@google.com] On Mon 06-08-18 12:12:02, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger > crash: OK, this is reassuring. Btw Greg has pointed out

Re: linux-next: manual merge of the rdma tree with Linus' tree

2018-08-06 Thread Jason Gunthorpe
On Mon, Aug 06, 2018 at 12:01:31PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > drivers/infiniband/core/uverbs_main.c > > between commit: > > 1eb9364ce81d ("IB/uverbs: Fix ordering of ucontext check in > ib_uverbs_write") >

[PATCH v2] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

Re: linux-next: manual merge of the rdma tree with Linus' tree

2018-08-06 Thread Jason Gunthorpe
On Mon, Aug 06, 2018 at 12:01:31PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rdma tree got a conflict in: > > drivers/infiniband/core/uverbs_main.c > > between commit: > > 1eb9364ce81d ("IB/uverbs: Fix ordering of ucontext check in > ib_uverbs_write") >

[PATCH v2] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

Re: [alsa-devel] [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val

2018-08-06 Thread Takashi Iwai
On Mon, 06 Aug 2018 20:37:53 +0200, Pierre-Louis Bossart wrote: > > On 8/1/18 6:00 AM, Takashi Iwai wrote: > > On Wed, 01 Aug 2018 12:47:42 +0200, > > Colin King wrote: > >> > >> From: Colin Ian King > >> > >> Variable cfg_val is being assigned but is never used hence it is > >> redundant and

[PATCH v2] Staging: One Laptop Per Child: fix SPDX-License-Identifier issue

2018-08-06 Thread Arkadiusz Lis
Add SPDX-License-Identifier to the source files. Remove redundant, old license. Signed-off-by: Arkadiusz Lis --- drivers/staging/olpc_dcon/olpc_dcon.c| 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 5 + 3 files

Re: [alsa-devel] [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val

2018-08-06 Thread Takashi Iwai
On Mon, 06 Aug 2018 20:37:53 +0200, Pierre-Louis Bossart wrote: > > On 8/1/18 6:00 AM, Takashi Iwai wrote: > > On Wed, 01 Aug 2018 12:47:42 +0200, > > Colin King wrote: > >> > >> From: Colin Ian King > >> > >> Variable cfg_val is being assigned but is never used hence it is > >> redundant and

[PATCH v2] Staging: One Laptop Per Child: fix SPDX-License-Identifier issue

2018-08-06 Thread Arkadiusz Lis
Add SPDX-License-Identifier to the source files. Remove redundant, old license. Signed-off-by: Arkadiusz Lis --- drivers/staging/olpc_dcon/olpc_dcon.c| 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 5 + drivers/staging/olpc_dcon/olpc_dcon_xo_1_5.c | 5 + 3 files

Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
On Mon, Aug 6, 2018 at 10:09 PM Andrew Lunn wrote: >> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev) >> >> /* Scan all SPI devices of this controller for direct mapped devices */ >> for_each_available_child_of_node(pdev->dev.of_node, np) { >> +

Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
On Mon, Aug 6, 2018 at 10:09 PM Andrew Lunn wrote: >> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev) >> >> /* Scan all SPI devices of this controller for direct mapped devices */ >> for_each_available_child_of_node(pdev->dev.of_node, np) { >> +

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote: > > On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote: > >> Hi Chanwoo, > >> > >> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi

Re: WARNING in try_charge

2018-08-06 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+bab151e82a4e973fa...@syzkaller.appspotmail.com Tested on: commit: 116b181bb646 Add linux-next specific files for 20180803 git tree:

Re: WARNING in try_charge

2018-08-06 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+bab151e82a4e973fa...@syzkaller.appspotmail.com Tested on: commit: 116b181bb646 Add linux-next specific files for 20180803 git tree:

Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Andrew Lunn
> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev) > > /* Scan all SPI devices of this controller for direct mapped devices */ > for_each_available_child_of_node(pdev->dev.of_node, np) { > + struct orion_direct_acc *dacc; I would prefer

Re: [PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Andrew Lunn
> @@ -683,6 +683,7 @@ static int orion_spi_probe(struct platform_device *pdev) > > /* Scan all SPI devices of this controller for direct mapped devices */ > for_each_available_child_of_node(pdev->dev.of_node, np) { > + struct orion_direct_acc *dacc; I would prefer

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Andy Shevchenko
On Mon, Aug 6, 2018 at 7:42 PM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >> > Sent: 05 August 2018 11:26 >> > > static bool has_cap(u32 cap) >> > > { >> > > if ((interface->capability & cap) != 0) >> > > - return

Re: [PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-06 Thread Andy Shevchenko
On Mon, Aug 6, 2018 at 7:42 PM, Joe Perches wrote: > On Mon, 2018-08-06 at 16:41 +, David Laight wrote: >> From: Andy Shevchenko >> > Sent: 05 August 2018 11:26 >> > > static bool has_cap(u32 cap) >> > > { >> > > if ((interface->capability & cap) != 0) >> > > - return

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
The debugging patch was wrong but I guess I see it finally. It's a race : [ 72.901666] Memory cgroup out of memory: Kill process 6584 (syz-executor1) score 55 or sacrifice child : [ 72.917037] Killed process 6584 (syz-executor1) total-vm:37704kB, anon-rss:2140kB, file-rss:0kB,

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
The debugging patch was wrong but I guess I see it finally. It's a race : [ 72.901666] Memory cgroup out of memory: Kill process 6584 (syz-executor1) score 55 or sacrifice child : [ 72.917037] Killed process 6584 (syz-executor1) total-vm:37704kB, anon-rss:2140kB, file-rss:0kB,

[PATCH v3 0/6] Add support for MSCC Ocelot i2c

2018-08-06 Thread Alexandre Belloni
Hello, Because the designware IP was not able to handle the SDA hold time before version 1.11a, MSCC has its own implementation. Add support for it and then add i2c on ocelot boards. I would expect patches 1 to 4 to go through the i2c tree and 5-6 through the mips tree once patch 4 has been

[PATCH v3 0/6] Add support for MSCC Ocelot i2c

2018-08-06 Thread Alexandre Belloni
Hello, Because the designware IP was not able to handle the SDA hold time before version 1.11a, MSCC has its own implementation. Add support for it and then add i2c on ocelot boards. I would expect patches 1 to 4 to go through the i2c tree and 5-6 through the mips tree once patch 4 has been

[PATCH v3 5/6] MIPS: dts: mscc: Add i2c on ocelot

2018-08-06 Thread Alexandre Belloni
Ocelot has an i2c controller, add it. There is only one possible pinmux configuration so add it as well. Signed-off-by: Alexandre Belloni --- arch/mips/boot/dts/mscc/ocelot.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi

[PATCH v3 2/6] i2c: designware: move #ifdef CONFIG_OF to the top

2018-08-06 Thread Alexandre Belloni
Move the #ifdef CONFIG_OF section to the top of the file, after the ACPI section so functions defined there can be used in dw_i2c_plat_probe. Reviewed-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- drivers/i2c/busses/i2c-designware-platdrv.c | 16 1 file changed, 8

[PATCH v3 5/6] MIPS: dts: mscc: Add i2c on ocelot

2018-08-06 Thread Alexandre Belloni
Ocelot has an i2c controller, add it. There is only one possible pinmux configuration so add it as well. Signed-off-by: Alexandre Belloni --- arch/mips/boot/dts/mscc/ocelot.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi

[PATCH v3 2/6] i2c: designware: move #ifdef CONFIG_OF to the top

2018-08-06 Thread Alexandre Belloni
Move the #ifdef CONFIG_OF section to the top of the file, after the ACPI section so functions defined there can be used in dw_i2c_plat_probe. Reviewed-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- drivers/i2c/busses/i2c-designware-platdrv.c | 16 1 file changed, 8

[PATCH v3 1/6] i2c: designware: use generic table matching

2018-08-06 Thread Alexandre Belloni
Switch to device_get_match_data in probe to match the device specific data instead of using the acpi specific function. Suggested-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- Changes in v3: - removed unused variable - switched to uintptr_t for the cast

[PATCH v3 3/6] i2c: designware: allow IP specific sda_hold_time

2018-08-06 Thread Alexandre Belloni
Because some old designware IPs were not supporting setting an SDA hold time, vendors developed their own solution. Add a way for the final driver to provide its own SDA hold time handling. Signed-off-by: Alexandre Belloni Reviewed-by: Andy Shevchenko ---

[PATCH v3 1/6] i2c: designware: use generic table matching

2018-08-06 Thread Alexandre Belloni
Switch to device_get_match_data in probe to match the device specific data instead of using the acpi specific function. Suggested-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- Changes in v3: - removed unused variable - switched to uintptr_t for the cast

[PATCH v3 3/6] i2c: designware: allow IP specific sda_hold_time

2018-08-06 Thread Alexandre Belloni
Because some old designware IPs were not supporting setting an SDA hold time, vendors developed their own solution. Add a way for the final driver to provide its own SDA hold time handling. Signed-off-by: Alexandre Belloni Reviewed-by: Andy Shevchenko ---

[PATCH v3 6/6] MIPS: dts: mscc: enable i2c on ocelot_pcb123

2018-08-06 Thread Alexandre Belloni
Enable the i2c controller on ocelot PCB123. While there are no i2c devices on the board itself, it can be used to control the SFP transceivers. Signed-off-by: Alexandre Belloni --- arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v3 4/6] i2c: designware: add MSCC Ocelot support

2018-08-06 Thread Alexandre Belloni
The Microsemi Ocelot I2C controller is a designware IP. It also has a second set of registers to allow tweaking SDA hold time and spike filtering. Cc: Rob Herring Reviewed-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- .../bindings/i2c/i2c-designware.txt | 9 -

[PATCH v3 6/6] MIPS: dts: mscc: enable i2c on ocelot_pcb123

2018-08-06 Thread Alexandre Belloni
Enable the i2c controller on ocelot PCB123. While there are no i2c devices on the board itself, it can be used to control the SFP transceivers. Signed-off-by: Alexandre Belloni --- arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v3 4/6] i2c: designware: add MSCC Ocelot support

2018-08-06 Thread Alexandre Belloni
The Microsemi Ocelot I2C controller is a designware IP. It also has a second set of registers to allow tweaking SDA hold time and spike filtering. Cc: Rob Herring Reviewed-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- .../bindings/i2c/i2c-designware.txt | 9 -

[PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

[PATCH] spi: orion: cosmetics - alias long direct_access variables

2018-08-06 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dacc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel --- drivers/spi/spi-orion.c | 22 +++--- 1 file

Re: [PATCH 20/20] perf report: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:21PM +0200, Jiri Olsa escreveu: > Set annotation percent type from following choices: > global-period, local-period, global-hits, local-hits > > With following report option setup the percent type will be > passed to annotation browser: > > $ perf report

Re: [PATCH 20/20] perf report: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:21PM +0200, Jiri Olsa escreveu: > Set annotation percent type from following choices: > global-period, local-period, global-hits, local-hits > > With following report option setup the percent type will be > passed to annotation browser: > > $ perf report

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 02일 02:08, Matthias

Re: [PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

2018-08-06 Thread Matthias Kaehlcke
Hi Chanwoo, On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote: > > Hi Chanwoo, > > > > On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote: > >> Hi Matthias, > >> > >> On 2018년 08월 02일 02:08, Matthias

Re: [PATCH] vfs: fix statfs64() returning impossible EOVERFLOW for 64-bit f_files

2018-08-06 Thread Linus Torvalds
On Mon, Aug 6, 2018 at 10:06 AM Al Viro wrote: > > That leaves us with f_bsize and f_frsize (the latter defaulting to the > former). > Hugetlbfs can put greater than 4Gb values in there, for really huge pages. > And that's the only thing worth checking in there. > > So the whole

Re: [PATCH] vfs: fix statfs64() returning impossible EOVERFLOW for 64-bit f_files

2018-08-06 Thread Linus Torvalds
On Mon, Aug 6, 2018 at 10:06 AM Al Viro wrote: > > That leaves us with f_bsize and f_frsize (the latter defaulting to the > former). > Hugetlbfs can put greater than 4Gb values in there, for really huge pages. > And that's the only thing worth checking in there. > > So the whole

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 20:13:39, Michal Hocko wrote: > I simply do not see how this is possible. Let's try with the following > extended debugging patch. > > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > 116b181bb646afedd770985de20a68721bdb2648 > > diff --git

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-08-06 Thread Alex_Gagniuc
On 08/05/2018 02:06 AM, Tal Gilboa wrote: > On 7/31/2018 6:10 PM, Alex G. wrote: >> On 07/31/2018 01:40 AM, Tal Gilboa wrote: >> [snip] >> @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct >> pci_dev *dev) >>   /* Advanced Error Reporting */ >>  

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 20:13:39, Michal Hocko wrote: > I simply do not see how this is possible. Let's try with the following > extended debugging patch. > > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > 116b181bb646afedd770985de20a68721bdb2648 > > diff --git

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-08-06 Thread Alex_Gagniuc
On 08/05/2018 02:06 AM, Tal Gilboa wrote: > On 7/31/2018 6:10 PM, Alex G. wrote: >> On 07/31/2018 01:40 AM, Tal Gilboa wrote: >> [snip] >> @@ -2240,6 +2258,9 @@ static void pci_init_capabilities(struct >> pci_dev *dev) >>   /* Advanced Error Reporting */ >>  

Re: [PATCH 3/3] perf/x86/intel: Add quirk for Goldmont Plus

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:43AM -0700, kan.li...@linux.intel.com wrote: > +static bool intel_glk_counter_freezing_broken(int cpu) > case INTEL_FAM6_ATOM_GEMINI_LAKE: > + x86_add_quirk(intel_counter_freezing_quirk); We really should fix that ATOM naming instead of making it

Re: [PATCH 3/3] perf/x86/intel: Add quirk for Goldmont Plus

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:43AM -0700, kan.li...@linux.intel.com wrote: > +static bool intel_glk_counter_freezing_broken(int cpu) > case INTEL_FAM6_ATOM_GEMINI_LAKE: > + x86_add_quirk(intel_counter_freezing_quirk); We really should fix that ATOM naming instead of making it

Re: [alsa-devel] [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val

2018-08-06 Thread Pierre-Louis Bossart
On 8/1/18 6:00 AM, Takashi Iwai wrote: On Wed, 01 Aug 2018 12:47:42 +0200, Colin King wrote: From: Colin Ian King Variable cfg_val is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'cfg_val' set but not used

Re: [alsa-devel] [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val

2018-08-06 Thread Pierre-Louis Bossart
On 8/1/18 6:00 AM, Takashi Iwai wrote: On Wed, 01 Aug 2018 12:47:42 +0200, Colin King wrote: From: Colin Ian King Variable cfg_val is being assigned but is never used hence it is redundant and can be removed. Cleans up clang warning: warning: variable 'cfg_val' set but not used

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: > @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event > *event) > if (unlikely(event->attr.precise_ip)) > intel_pmu_pebs_disable(event); > > + /* > + * We could

Re: [PATCH 2/3] x86, perf: Add a separate Arch Perfmon v4 PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:42AM -0700, kan.li...@linux.intel.com wrote: > @@ -2044,6 +2056,14 @@ static void intel_pmu_disable_event(struct perf_event > *event) > if (unlikely(event->attr.precise_ip)) > intel_pmu_pebs_disable(event); > > + /* > + * We could

Re: [PATCH 19/20] perf annotate: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 06, 2018 at 04:26:25PM +0200, Jiri Olsa escreveu: > On Mon, Aug 06, 2018 at 10:49:12PM +0900, Namhyung Kim wrote: > > On Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa wrote: > > > The local/global keywords set if the percentage is computed > > > in the scope of the function (local)

Re: [PATCH 19/20] perf annotate: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 06, 2018 at 04:26:25PM +0200, Jiri Olsa escreveu: > On Mon, Aug 06, 2018 at 10:49:12PM +0900, Namhyung Kim wrote: > > On Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa wrote: > > > The local/global keywords set if the percentage is computed > > > in the scope of the function (local)

Re: [PATCH 19/20] perf annotate: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa escreveu: > Adding --percent-type option to set annotation percent type > from following choices: > global-period, local-period, global-hits, local-hits > > Examples: > $ perf annotate --percent-type period-local --stdio | head -1 >

Re: [PATCH 19/20] perf annotate: Add --percent-type option

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa escreveu: > Adding --percent-type option to set annotation percent type > from following choices: > global-period, local-period, global-hits, local-hits > > Examples: > $ perf annotate --percent-type period-local --stdio | head -1 >

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Julius Werner
Thanks for the quick fix! Reviewed-by: Julius Werner

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Julius Werner
Thanks for the quick fix! Reviewed-by: Julius Werner

Re: [PATCH 18/20] perf annotate: Display percent type in stdio output

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:19PM +0200, Jiri Olsa escreveu: > In following patches we will allow to switch percent type > even for stdio annotation outputs. Adding the percent type > value into the annotation outputs title. > > $ perf annotate --stdio >Percent | Sou ...

Re: [PATCH 18/20] perf annotate: Display percent type in stdio output

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:19PM +0200, Jiri Olsa escreveu: > In following patches we will allow to switch percent type > even for stdio annotation outputs. Adding the percent type > value into the annotation outputs title. > > $ perf annotate --stdio >Percent | Sou ...

Re: [PATCH 17/20] perf annotate: Make local period the default percent type

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:18PM +0200, Jiri Olsa escreveu: > Currently we display the percentages in annotation output > based on number of samples hits. Switching it to period > based percentage by default, because it corresponds more > to the time spent on the line. Thanks, tested, applied.

Re: [PATCH 17/20] perf annotate: Make local period the default percent type

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:18PM +0200, Jiri Olsa escreveu: > Currently we display the percentages in annotation output > based on number of samples hits. Switching it to period > based percentage by default, because it corresponds more > to the time spent on the line. Thanks, tested, applied.

Re: [PATCH 16/20] perf annotate: Add support to togle percent type

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:17PM +0200, Jiri Olsa escreveu: > Adding new key bindings to togle percent type/base > in annotation UI browser: Thanks, tested, nice! Applied. - Arnaldo

Re: [PATCH 16/20] perf annotate: Add support to togle percent type

2018-08-06 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 04, 2018 at 03:05:17PM +0200, Jiri Olsa escreveu: > Adding new key bindings to togle percent type/base > in annotation UI browser: Thanks, tested, nice! Applied. - Arnaldo

Re: WARNING in try_charge

2018-08-06 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in try_charge task=syz-executor4 pid=6578 invoked memcg oom killer. oom_victim=1 task=syz-executor6 pid=6576 charge for nr_pages=1 [ cut here ] task=syz-executor6 pid=6576

Re: WARNING in try_charge

2018-08-06 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: WARNING in try_charge task=syz-executor4 pid=6578 invoked memcg oom killer. oom_victim=1 task=syz-executor6 pid=6576 charge for nr_pages=1 [ cut here ] task=syz-executor6 pid=6576

Re: [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:41AM -0700, kan.li...@linux.intel.com wrote: > + if (++loops > 100) { > + static bool warned; > + > + if (!warned) { > + WARN(1, "perfevents: irq loop stuck!\n"); > + perf_event_print_debug(); > +

Re: [PATCH 1/3] perf/x86/intel: Factor out common code of PMI handler

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 10:23:41AM -0700, kan.li...@linux.intel.com wrote: > + if (++loops > 100) { > + static bool warned; > + > + if (!warned) { > + WARN(1, "perfevents: irq loop stuck!\n"); > + perf_event_print_debug(); > +

Re: [PATCH 2/4] trace: avoid calling cc-option -mrecord-mcount for every Makefile

2018-08-06 Thread Andi Kleen
On Mon, Aug 06, 2018 at 03:17:44PM +0200, Vasily Gorbik wrote: > Currently if CONFIG_FTRACE_MCOUNT_RECORD is enabled -mrecord-mcount > compiler flag support is tested for every Makefile. Good catch. Does it make a measurable compile time difference? > > Top 4 cc-option usages: > 511

Re: [PATCH 2/4] trace: avoid calling cc-option -mrecord-mcount for every Makefile

2018-08-06 Thread Andi Kleen
On Mon, Aug 06, 2018 at 03:17:44PM +0200, Vasily Gorbik wrote: > Currently if CONFIG_FTRACE_MCOUNT_RECORD is enabled -mrecord-mcount > compiler flag support is tested for every Makefile. Good catch. Does it make a measurable compile time difference? > > Top 4 cc-option usages: > 511

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
I simply do not see how this is possible. Let's try with the following extended debugging patch. #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 116b181bb646afedd770985de20a68721bdb2648 diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4603ad75c9a9..e2dfdf4361ba

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
I simply do not see how this is possible. Let's try with the following extended debugging patch. #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git 116b181bb646afedd770985de20a68721bdb2648 diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 4603ad75c9a9..e2dfdf4361ba

[PATCH] locks: add tracepoint in flock codepath

2018-08-06 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/locks.c | 1 + include/trace/events/filelock.h | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/locks.c b/fs/locks.c index e533623e2e99..6138a9bcd924 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -990,6 +990,7 @@

[PATCH] locks: add tracepoint in flock codepath

2018-08-06 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/locks.c | 1 + include/trace/events/filelock.h | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/locks.c b/fs/locks.c index e533623e2e99..6138a9bcd924 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -990,6 +990,7 @@

Re: [PATCH] of: thermal: Allow multiple devices to share cooling map

2018-08-06 Thread Eduardo Valentin
Hello, On Tue, Jul 17, 2018 at 04:24:16PM +0530, Viresh Kumar wrote: > A cooling map entry may now contain a list of phandles and their > arguments representing multiple devices which share the trip point. > > This patch updates the thermal OF core to parse them properly. I am mostly fine with

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Stephen Boyd
Quoting Brian Norris (2018-08-06 10:38:08) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > Now that the /firmware/coreboot node in DT is populated by the core DT > > platform code with commit 3aa0582fdb82 ("of: platform: populate > > /firmware/ node from

Re: [PATCH] of: thermal: Allow multiple devices to share cooling map

2018-08-06 Thread Eduardo Valentin
Hello, On Tue, Jul 17, 2018 at 04:24:16PM +0530, Viresh Kumar wrote: > A cooling map entry may now contain a list of phandles and their > arguments representing multiple devices which share the trip point. > > This patch updates the thermal OF core to parse them properly. I am mostly fine with

Re: [PATCH] firmware: coreboot: Let OF core populate platform device

2018-08-06 Thread Stephen Boyd
Quoting Brian Norris (2018-08-06 10:38:08) > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > Now that the /firmware/coreboot node in DT is populated by the core DT > > platform code with commit 3aa0582fdb82 ("of: platform: populate > > /firmware/ node from

Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 09:54:23AM -0700, Fubo Chen wrote: > On Mon, Aug 6, 2018 at 8:42 AM Peter Zijlstra wrote: > > > > On Mon, Aug 06, 2018 at 08:35:07AM -0700, Fubo Chen wrote: > > > On Thu, Jul 19, 2018 at 2:21 PM Peter Zijlstra > > > wrote: > > > > --- a/include/uapi/linux/perf_event.h >

Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)

2018-08-06 Thread Peter Zijlstra
On Mon, Aug 06, 2018 at 09:54:23AM -0700, Fubo Chen wrote: > On Mon, Aug 6, 2018 at 8:42 AM Peter Zijlstra wrote: > > > > On Mon, Aug 06, 2018 at 08:35:07AM -0700, Fubo Chen wrote: > > > On Thu, Jul 19, 2018 at 2:21 PM Peter Zijlstra > > > wrote: > > > > --- a/include/uapi/linux/perf_event.h >

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 19:44:10, Michal Hocko wrote: > On Mon 06-08-18 08:42:02, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > WARNING in try_charge > > > > Killed process 6410 (syz-executor5) total-vm:37708kB, anon-rss:2128kB, >

Re: WARNING in try_charge

2018-08-06 Thread Michal Hocko
On Mon 06-08-18 19:44:10, Michal Hocko wrote: > On Mon 06-08-18 08:42:02, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > WARNING in try_charge > > > > Killed process 6410 (syz-executor5) total-vm:37708kB, anon-rss:2128kB, >

Re: WARNING in try_charge

2018-08-06 Thread Dmitry Vyukov
On Mon, Aug 6, 2018 at 7:30 PM, Michal Hocko wrote: >> >> >> A much >> >> >> friendlier for user way to say this would be print a message at the >> >> >> point of misconfiguration saying what exactly is wrong, e.g. "pid $PID >> >> >> misconfigures cgroup /cgroup/path with mem.limit=0" without a

Re: WARNING in try_charge

2018-08-06 Thread Dmitry Vyukov
On Mon, Aug 6, 2018 at 7:30 PM, Michal Hocko wrote: >> >> >> A much >> >> >> friendlier for user way to say this would be print a message at the >> >> >> point of misconfiguration saying what exactly is wrong, e.g. "pid $PID >> >> >> misconfigures cgroup /cgroup/path with mem.limit=0" without a

Re: [PATCH 11/11] mm,sched: conditionally skip lazy TLB mm refcounting

2018-08-06 Thread Peter Zijlstra
On Fri, Aug 03, 2018 at 01:39:52PM -0400, Rik van Riel wrote: > > At the very least the Changelog needs to explain why we cannot do > > away with the swizzle now and how doing the swizzle without the > > refcounting is not completely broken (I think I see, but urgh). > > The changelog for

Re: [PATCH 11/11] mm,sched: conditionally skip lazy TLB mm refcounting

2018-08-06 Thread Peter Zijlstra
On Fri, Aug 03, 2018 at 01:39:52PM -0400, Rik van Riel wrote: > > At the very least the Changelog needs to explain why we cannot do > > away with the swizzle now and how doing the swizzle without the > > refcounting is not completely broken (I think I see, but urgh). > > The changelog for

Re: WARNING in try_charge

2018-08-06 Thread Dmitry Vyukov
On Mon, Aug 6, 2018 at 7:44 PM, Michal Hocko wrote: > On Mon 06-08-18 08:42:02, syzbot wrote: >> Hello, >> >> syzbot has tested the proposed patch but the reproducer still triggered >> crash: >> WARNING in try_charge >> >> Killed process 6410 (syz-executor5) total-vm:37708kB, anon-rss:2128kB, >>

Re: WARNING in try_charge

2018-08-06 Thread Dmitry Vyukov
On Mon, Aug 6, 2018 at 7:44 PM, Michal Hocko wrote: > On Mon 06-08-18 08:42:02, syzbot wrote: >> Hello, >> >> syzbot has tested the proposed patch but the reproducer still triggered >> crash: >> WARNING in try_charge >> >> Killed process 6410 (syz-executor5) total-vm:37708kB, anon-rss:2128kB, >>

<    1   2   3   4   5   6   7   8   9   10   >