[PATCH 23/44] perf annotate: Add PERCENT_PERIOD_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin

[PATCH 23/44] perf annotate: Add PERCENT_PERIOD_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin

[PATCH 22/44] perf annotate: Add PERCENT_PERIOD_LOCAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing local period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_LOCAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin

[PATCH 18/44] perf annotate: Rename hist to sym_hist in annotation__calc_percent

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We will need to bring in 'struct hists' variable in this scope, so it's better we do this rename first. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link:

[PATCH 22/44] perf annotate: Add PERCENT_PERIOD_LOCAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing local period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_LOCAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin

[PATCH 18/44] perf annotate: Rename hist to sym_hist in annotation__calc_percent

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We will need to bring in 'struct hists' variable in this scope, so it's better we do this rename first. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link:

[PATCH 21/44] perf annotate: Add PERCENT_HITS_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global hits percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_HITS_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc:

[PATCH 17/44] perf annotate: Rename local sample variables to data

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Based on previous rename, changing also the local variable names to fit properly. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-6-jo...@kernel.org

[PATCH 20/44] perf annotate: Switch struct annotation_data::percent to array

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa So we can hold multiple percent values for annotation line. The first member of this array is current local hits percent value (PERCENT_HITS_LOCAL index), so no functional change is expected. Adding annotation_data__percent function to return requested percent value from struct

[PATCH 19/44] perf annotate: Loop group events directly in annotation__calc_percent()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to bring in 'struct hists' object and for that we need 'struct perf_evsel' object in the scope. Switching the group data loop with the evsel group loop. It does the same thing, but it brings evsel object, that we can use later get the 'struct hists' object.

[PATCH 21/44] perf annotate: Add PERCENT_HITS_GLOBAL percent value

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding and computing global hits percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_HITS_GLOBAL index. At the moment it's not displayed, it's coming in following patches. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc:

[PATCH 17/44] perf annotate: Rename local sample variables to data

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Based on previous rename, changing also the local variable names to fit properly. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-6-jo...@kernel.org

[PATCH 20/44] perf annotate: Switch struct annotation_data::percent to array

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa So we can hold multiple percent values for annotation line. The first member of this array is current local hits percent value (PERCENT_HITS_LOCAL index), so no functional change is expected. Adding annotation_data__percent function to return requested percent value from struct

[PATCH 19/44] perf annotate: Loop group events directly in annotation__calc_percent()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to bring in 'struct hists' object and for that we need 'struct perf_evsel' object in the scope. Switching the group data loop with the evsel group loop. It does the same thing, but it brings evsel object, that we can use later get the 'struct hists' object.

[PATCH 12/44] perf bpf: Add 'syscall_enter' probe helper for syscall enter tracepoints

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Allowing one to hook into the syscalls:sys_enter_NAME tracepoints, an example is provided that hooks into the 'openat' syscall. Using it with the probe:vfs_getname probe into getname_flags to get the filename args as it is copied from userspace: # perf probe -l

[PATCH 13/44] perf annotate: Make symbol__annotate_fprintf2() local

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lkml.kernel.org/r/20180804130521.11408-2-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 16/44] perf annotate: Rename struct annotation_line::samples* to data*

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The name 'samples*' is little confusing because we have nested 'struct sym_hist_entry' under annotation_line struct, which holds 'nr_samples' as well. Also the holding struct name is 'annotation_data' so the 'data' name fits better. Signed-off-by: Jiri Olsa Cc: Alexander

[PATCH 15/44] perf annotate: Get rid of annotation__scnprintf_samples_period()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We have more current function tto get the title for annotation, which is hists__scnprintf_title. They both have same output as far as the annotation's header line goes. They differ in counting of the nr_samples, hists__scnprintf_title provides more accurate number based on the

[PATCH 14/44] perf annotate: Make annotation_line__max_percent static

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-3-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 12/44] perf bpf: Add 'syscall_enter' probe helper for syscall enter tracepoints

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Allowing one to hook into the syscalls:sys_enter_NAME tracepoints, an example is provided that hooks into the 'openat' syscall. Using it with the probe:vfs_getname probe into getname_flags to get the filename args as it is copied from userspace: # perf probe -l

[PATCH 13/44] perf annotate: Make symbol__annotate_fprintf2() local

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: https://lkml.kernel.org/r/20180804130521.11408-2-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 16/44] perf annotate: Rename struct annotation_line::samples* to data*

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The name 'samples*' is little confusing because we have nested 'struct sym_hist_entry' under annotation_line struct, which holds 'nr_samples' as well. Also the holding struct name is 'annotation_data' so the 'data' name fits better. Signed-off-by: Jiri Olsa Cc: Alexander

[PATCH 15/44] perf annotate: Get rid of annotation__scnprintf_samples_period()

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We have more current function tto get the title for annotation, which is hists__scnprintf_title. They both have same output as far as the annotation's header line goes. They differ in counting of the nr_samples, hists__scnprintf_title provides more accurate number based on the

[PATCH 14/44] perf annotate: Make annotation_line__max_percent static

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa There's no outside user of it. Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Stephane Eranian Link: http://lkml.kernel.org/r/20180804130521.11408-3-jo...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 11/44] perf tools: Drop unneeded bitmap_zero() calls

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Yury Norov bitmap_zero() is called after bitmap_alloc() in perf code. But bitmap_alloc() internally uses calloc() which guarantees that allocated area is zeroed. So following bitmap_zero is unneeded. Drop it. This happened because of confusing name for bitmap allocator. It should has name

[PATCH 11/44] perf tools: Drop unneeded bitmap_zero() calls

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Yury Norov bitmap_zero() is called after bitmap_alloc() in perf code. But bitmap_alloc() internally uses calloc() which guarantees that allocated area is zeroed. So following bitmap_zero is unneeded. Drop it. This happened because of confusing name for bitmap allocator. It should has name

[PATCH 10/44] perf vendor events arm64: Enable JSON events for eMAG

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Sean V Kelley This patch adds the Ampere Computing eMAG file. This platform follows the ARMv8 recommended IMPLEMENTATION DEFINED events, where applicable. Signed-off-by: Sean V Kelley Reviewed-by: John Garry Cc: Alexander Shishkin Cc: Ganapatrao Kulkarni Cc: Jiri Olsa Cc: Namhyung

[PATCH 10/44] perf vendor events arm64: Enable JSON events for eMAG

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Sean V Kelley This patch adds the Ampere Computing eMAG file. This platform follows the ARMv8 recommended IMPLEMENTATION DEFINED events, where applicable. Signed-off-by: Sean V Kelley Reviewed-by: John Garry Cc: Alexander Shishkin Cc: Ganapatrao Kulkarni Cc: Jiri Olsa Cc: Namhyung

[PATCH 09/44] perf report: Add GUI report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000 -- ls' to create the perf.data file. Use 'perf report' to display the auxiliary trace data. Output before: [root@s35lp76 perf]# ./perf report --stdio 0x128 [0x10]: failed to process type: 70

[PATCH 09/44] perf report: Add GUI report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000 -- ls' to create the perf.data file. Use 'perf report' to display the auxiliary trace data. Output before: [root@s35lp76 perf]# ./perf report --stdio 0x128 [0x10]: failed to process type: 70

[PATCH 08/44] perf report: Add raw report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000' to create the perf.data file. The event also has the symbolic name SF_CYCLES_BASIC_DIAG, using 'perf record -e SF_CYCLES_BASIC_DIAG' is equivalent. Use 'perf report -D' to display the auxiliary

[PATCH 08/44] perf report: Add raw report support for s390 auxiliary trace

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add support for s390 auxiliary trace support. Use 'perf record -e rbd000' to create the perf.data file. The event also has the symbolic name SF_CYCLES_BASIC_DIAG, using 'perf record -e SF_CYCLES_BASIC_DIAG' is equivalent. Use 'perf report -D' to display the auxiliary

[PATCH 07/44] perf auxtrace: Support for perf report -D for s390

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add initial support for s390 auxiliary traces using the CPU-Measurement Sampling Facility. Support and ignore PERF_REPORT_AUXTRACE_INFO records in the perf data file. Later patches will show the contents of the auxiliary traces. Setup the auxtrace queues and data

[PATCH 07/44] perf auxtrace: Support for perf report -D for s390

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Thomas Richter Add initial support for s390 auxiliary traces using the CPU-Measurement Sampling Facility. Support and ignore PERF_REPORT_AUXTRACE_INFO records in the perf data file. Later patches will show the contents of the auxiliary traces. Setup the auxtrace queues and data

[PATCH 06/44] perf trace: Use perf_evsel__sc_tp_{uint,ptr} for "id"/"args" handling syscalls:* events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now it looks just about the same as for the trace__sys_{enter,exit}. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-y59may7zx1eccnp4m3qm4...@git.kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 06/44] perf trace: Use perf_evsel__sc_tp_{uint,ptr} for "id"/"args" handling syscalls:* events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Now it looks just about the same as for the trace__sys_{enter,exit}. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-y59may7zx1eccnp4m3qm4...@git.kernel.org Signed-off-by: Arnaldo Carvalho de

[PATCH 05/44] perf trace: Setup struct syscall_tp for syscalls:sys_{enter,exit}_NAME events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Mapping "__syscall_nr" to "id" and setting up "args" from the offset of "__syscall_nr" + sizeof(u64), as the payload for syscalls:* is the same as for raw_syscalls:*, just the fields have different names. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc:

[PATCH 05/44] perf trace: Setup struct syscall_tp for syscalls:sys_{enter,exit}_NAME events

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Mapping "__syscall_nr" to "id" and setting up "args" from the offset of "__syscall_nr" + sizeof(u64), as the payload for syscalls:* is the same as for raw_syscalls:*, just the fields have different names. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc:

[PATCH 04/44] perf trace: Allow setting up a syscall_tp struct without a format_field

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To avoid having to ask libtraceevent to find a field by name when handling each tracepoint event, we setup a struct syscall_tp with a tp_field struct having an extractor function + the offset for the "id", "args" and "ret" raw_syscalls:sys_{enter,exit} tracepoints.

[PATCH 04/44] perf trace: Allow setting up a syscall_tp struct without a format_field

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo To avoid having to ask libtraceevent to find a field by name when handling each tracepoint event, we setup a struct syscall_tp with a tp_field struct having an extractor function + the offset for the "id", "args" and "ret" raw_syscalls:sys_{enter,exit} tracepoints.

[PATCH 03/44] perf trace: Rename some syscall_tp methods to raw_syscall

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because raw_syscalls have the field for the syscall number as 'id' while the syscalls:sys_{enter,exit}_NAME have it as __syscall_nr... Since we want to support both for being able to enable just a syscalls:sys_{enter,exit}_name instead of asking for

[PATCH 03/44] perf trace: Rename some syscall_tp methods to raw_syscall

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because raw_syscalls have the field for the syscall number as 'id' while the syscalls:sys_{enter,exit}_NAME have it as __syscall_nr... Since we want to support both for being able to enable just a syscalls:sys_{enter,exit}_name instead of asking for

[PATCH 02/44] perf trace: Use beautifiers on syscalls:sys_enter_ handlers

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We were using the beautifiers only when processing the raw_syscalls:sys_enter events, but we can as well use them for the syscalls:sys_enter_NAME events, as the layout is the same. Some more tweaking is needed as we're processing them straight away, i.e. there is

[PATCH 02/44] perf trace: Use beautifiers on syscalls:sys_enter_ handlers

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We were using the beautifiers only when processing the raw_syscalls:sys_enter events, but we can as well use them for the syscalls:sys_enter_NAME events, as the layout is the same. Some more tweaking is needed as we're processing them straight away, i.e. there is

[PATCH 01/44] perf trace: Associate vfs_getname()'ed pathname with fd returned from 'openat'

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When the vfs_getname() wannabe tracepoint is in place: # perf probe -l probe:vfs_getname(on getname_flags:73@acme/git/linux/fs/namei.c with pathname) # 'perf trace' will use it to get the pathname when it is copied from userspace to the kernel, right

[GIT PULL 00/44] perf/core improvements and fixes

2018-08-09 Thread Arnaldo Carvalho de Melo
:59:41 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.19-20180809 for you to fetch changes up to 6a9405b56c274024564f9014bba97b92c91b34d6: perf map: Optimize maps__fixup_overlappings() (2018-08-08 15:56

[PATCH 01/44] perf trace: Associate vfs_getname()'ed pathname with fd returned from 'openat'

2018-08-09 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When the vfs_getname() wannabe tracepoint is in place: # perf probe -l probe:vfs_getname(on getname_flags:73@acme/git/linux/fs/namei.c with pathname) # 'perf trace' will use it to get the pathname when it is copied from userspace to the kernel, right

[GIT PULL 00/44] perf/core improvements and fixes

2018-08-09 Thread Arnaldo Carvalho de Melo
:59:41 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.19-20180809 for you to fetch changes up to 6a9405b56c274024564f9014bba97b92c91b34d6: perf map: Optimize maps__fixup_overlappings() (2018-08-08 15:56

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
On Thu, 2018-08-09 at 10:55 -0400, Steven Rostedt wrote: > On Thu, 09 Aug 2018 09:51:37 -0500 > Tom Zanussi wrote: > > > Hi Steve, > > > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > > On Thu, 9 Aug 2018 09:34:10 -0500 > > > Tom Zanussi wrote: > > > > > > > From: Tom

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
On Thu, 2018-08-09 at 10:55 -0400, Steven Rostedt wrote: > On Thu, 09 Aug 2018 09:51:37 -0500 > Tom Zanussi wrote: > > > Hi Steve, > > > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > > On Thu, 9 Aug 2018 09:34:10 -0500 > > > Tom Zanussi wrote: > > > > > > > From: Tom

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 09 Aug 2018 09:51:37 -0500 Tom Zanussi wrote: > Hi Steve, > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > On Thu, 9 Aug 2018 09:34:10 -0500 > > Tom Zanussi wrote: > > > > > From: Tom Zanussi > > > > > > Hi, > > > > > > This is v3 of the hist trigger snapshot and

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 09 Aug 2018 09:51:37 -0500 Tom Zanussi wrote: > Hi Steve, > > On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > > On Thu, 9 Aug 2018 09:34:10 -0500 > > Tom Zanussi wrote: > > > > > From: Tom Zanussi > > > > > > Hi, > > > > > > This is v3 of the hist trigger snapshot and

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
Hi Steve, On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > On Thu, 9 Aug 2018 09:34:10 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Hi, > > > > This is v3 of the hist trigger snapshot and onchange additions > > patchset. It's rebased on top of the latest ftrace/core

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
Hi Steve, On Thu, 2018-08-09 at 10:47 -0400, Steven Rostedt wrote: > On Thu, 9 Aug 2018 09:34:10 -0500 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Hi, > > > > This is v3 of the hist trigger snapshot and onchange additions > > patchset. It's rebased on top of the latest ftrace/core

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread Jeff Layton
On Thu, 2018-08-09 at 09:00 -0400, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: > > That seems like a legit problem. > > > > One possible fix might be to have the waiter on (1,2) walk down the > > entire subtree and wake up any waiter that is waiting on a

Re: [PATCH 0/4] locks: avoid thundering-herd wake-ups

2018-08-09 Thread Jeff Layton
On Thu, 2018-08-09 at 09:00 -0400, J. Bruce Fields wrote: > On Wed, Aug 08, 2018 at 06:50:06PM -0400, Jeff Layton wrote: > > That seems like a legit problem. > > > > One possible fix might be to have the waiter on (1,2) walk down the > > entire subtree and wake up any waiter that is waiting on a

Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Jacek Anaszewski
Dan, On 08/09/2018 03:30 PM, Dan Murphy wrote: > Jacek and Pavel > > On 08/09/2018 07:09 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 08/08/2018 11:45 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 08/08/2018 04:09 PM, Jacek Anaszewski wrote: Hi Dan, On 08/08/2018 11:04 PM, Dan Murphy

Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver

2018-08-09 Thread Jacek Anaszewski
Dan, On 08/09/2018 03:30 PM, Dan Murphy wrote: > Jacek and Pavel > > On 08/09/2018 07:09 AM, Jacek Anaszewski wrote: >> Dan, >> >> On 08/08/2018 11:45 PM, Dan Murphy wrote: >>> Jacek >>> >>> On 08/08/2018 04:09 PM, Jacek Anaszewski wrote: Hi Dan, On 08/08/2018 11:04 PM, Dan Murphy

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 9 Aug 2018 09:34:10 -0500 Tom Zanussi wrote: > From: Tom Zanussi > > Hi, > > This is v3 of the hist trigger snapshot and onchange additions > patchset. It's rebased on top of the latest ftrace/core and adds a > few fixes to some handler/action problems I noticed while testing. Hi

Re: [Xen-devel] [PATCH] xen/netfront: don't cache skb_shinfo()

2018-08-09 Thread Wei Liu
On Thu, Aug 09, 2018 at 04:42:16PM +0200, Juergen Gross wrote: > skb_shinfo() can change when calling __pskb_pull_tail(): Don't cache > its return value. > > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu

Re: [PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Steven Rostedt
On Thu, 9 Aug 2018 09:34:10 -0500 Tom Zanussi wrote: > From: Tom Zanussi > > Hi, > > This is v3 of the hist trigger snapshot and onchange additions > patchset. It's rebased on top of the latest ftrace/core and adds a > few fixes to some handler/action problems I noticed while testing. Hi

Re: [Xen-devel] [PATCH] xen/netfront: don't cache skb_shinfo()

2018-08-09 Thread Wei Liu
On Thu, Aug 09, 2018 at 04:42:16PM +0200, Juergen Gross wrote: > skb_shinfo() can change when calling __pskb_pull_tail(): Don't cache > its return value. > > Cc: sta...@vger.kernel.org > Signed-off-by: Juergen Gross Reviewed-by: Wei Liu

[PATCH v3 4/4] clk: imx: add clock driver for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach Add driver for the Clock Control Module found on i.MX8MQ. This is largely based on the downstream driver from Anson Huang and Bai Ping at NXP, with only some small adaptions to mainline from me. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa ---

[PATCH v3 4/4] clk: imx: add clock driver for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach Add driver for the Clock Control Module found on i.MX8MQ. This is largely based on the downstream driver from Anson Huang and Bai Ping at NXP, with only some small adaptions to mainline from me. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa ---

[PATCH v3 1/4] dt-bindings: add binding for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach This adds the binding for the i.MX8MQ Clock Controller Module. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- .../devicetree/bindings/clock/imx8mq-clock.txt | 20 + include/dt-bindings/clock/imx8mq-clock.h | 629 + 2 files

[PATCH v3 3/4] clk: imx: add SCCG PLL type

2018-08-09 Thread Abel Vesa
From: Lucas Stach The SCCG is a new PLL type introduced on i.MX8. Add support for this. The driver currently misses the PLL lock check, as the preliminary documentation mentions lock configurations, but is quiet about where to find the actual lock status signal. Signed-off-by: Lucas Stach

[PATCH v3 1/4] dt-bindings: add binding for i.MX8MQ CCM

2018-08-09 Thread Abel Vesa
From: Lucas Stach This adds the binding for the i.MX8MQ Clock Controller Module. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- .../devicetree/bindings/clock/imx8mq-clock.txt | 20 + include/dt-bindings/clock/imx8mq-clock.h | 629 + 2 files

[PATCH v3 3/4] clk: imx: add SCCG PLL type

2018-08-09 Thread Abel Vesa
From: Lucas Stach The SCCG is a new PLL type introduced on i.MX8. Add support for this. The driver currently misses the PLL lock check, as the preliminary documentation mentions lock configurations, but is quiet about where to find the actual lock status signal. Signed-off-by: Lucas Stach

[PATCH v3 2/4] clk: imx: add fractional PLL output clock

2018-08-09 Thread Abel Vesa
From: Lucas Stach This is a new clock type introduced on i.MX8. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-frac-pll.c | 230 + drivers/clk/imx/clk.h | 3 + 3 files

[PATCH v3 2/4] clk: imx: add fractional PLL output clock

2018-08-09 Thread Abel Vesa
From: Lucas Stach This is a new clock type introduced on i.MX8. Signed-off-by: Lucas Stach Signed-off-by: Abel Vesa --- drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-frac-pll.c | 230 + drivers/clk/imx/clk.h | 3 + 3 files

[PATCH v3 0/4] Add i.MX8MQ clock driver

2018-08-09 Thread Abel Vesa
This is basically just a resend of the following patchset: https://www.spinics.net/lists/linux-clk/msg23141.html I've just updated the patchset and implemented Shawn's and Aisheng's comments. I hope I haven't missed any of their comments. Lucas Stach (4): dt-bindings: add binding for i.MX8MQ

[PATCH v3 0/4] Add i.MX8MQ clock driver

2018-08-09 Thread Abel Vesa
This is basically just a resend of the following patchset: https://www.spinics.net/lists/linux-clk/msg23141.html I've just updated the patchset and implemented Shawn's and Aisheng's comments. I hope I haven't missed any of their comments. Lucas Stach (4): dt-bindings: add binding for i.MX8MQ

Re: [PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 03:53 PM, zhouxianrong wrote: > The last partial object in last subpage of zspage should not be linked > in allocation list. Please expand the changelog. Why it should not be? What happens if it is? Kernel panic, data corruption or whatnot? So that people not familiar with zsmalloc

Re: [PATCH] zsmalloc: fix linking bug in init_zspage

2018-08-09 Thread Vlastimil Babka
On 08/09/2018 03:53 PM, zhouxianrong wrote: > The last partial object in last subpage of zspage should not be linked > in allocation list. Please expand the changelog. Why it should not be? What happens if it is? Kernel panic, data corruption or whatnot? So that people not familiar with zsmalloc

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-09 Thread Oleg Nesterov
I need to read this (hopefully final) version carefully. I'll try to do this before next Monday. just one note, On 08/09, Ravi Bangoria wrote: > > +static void delayed_uprobe_remove(struct uprobe *uprobe, struct mm_struct > *mm) > +{ > + struct list_head *pos, *q; > + struct

Re: [PATCH v8 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-09 Thread Oleg Nesterov
I need to read this (hopefully final) version carefully. I'll try to do this before next Monday. just one note, On 08/09, Ravi Bangoria wrote: > > +static void delayed_uprobe_remove(struct uprobe *uprobe, struct mm_struct > *mm) > +{ > + struct list_head *pos, *q; > + struct

[PATCH] arm:pmsa-v8: remove some extra semicolon

2018-08-09 Thread zhong jiang
There are some extra semicolon in pmsa-v8.c. So just remove them. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mm/pmsa-v8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/pmsa-v8.c b/arch/arm/mm/pmsa-v8.c index

[PATCH] arm:pmsa-v8: remove some extra semicolon

2018-08-09 Thread zhong jiang
There are some extra semicolon in pmsa-v8.c. So just remove them. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mm/pmsa-v8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/pmsa-v8.c b/arch/arm/mm/pmsa-v8.c index

[PATCH v3 3/7] tracing: Generalize hist trigger onmax and save action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The action refactor code allowed actions and handlers to be separated, but the existing onmax handler and save action code is still not flexible enough to handle arbitrary coupling. This change generalizes them and in the process makes additional handlers and actions easier to

[PATCH v3 3/7] tracing: Generalize hist trigger onmax and save action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The action refactor code allowed actions and handlers to be separated, but the existing onmax handler and save action code is still not flexible enough to handle arbitrary coupling. This change generalizes them and in the process makes additional handlers and actions easier to

[PATCH v3 4/7] tracing: Add conditional snapshot

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, tracing snapshots are context-free - they capture the ring buffer contents at the time the tracing_snapshot() function was invoked, and nothing else. Additionally, they're always taken unconditionally - the calling code can decide whether or not to take a snapshot,

Re: [PATCH 28/33] vfs: syscall: Add fsconfig() for configuring and managing a context [ver #11]

2018-08-09 Thread Miklos Szeredi
On Thu, Aug 9, 2018 at 4:24 PM, David Howells wrote: > Eric W. Biederman wrote: > >> First let me thank you for adding both FSCONFIG_CMD_CREATE and >> FSCONFIG_CMD_RECONFIGURE. Unfortunately the implementation is currently >> broken. So this patch gets my: >> >> This is broken in two specific

[PATCH v3 7/7] tracing: Add hist trigger onchange() handler

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for a hist:onchange($var) handler, similar to the onmax() handler but triggering whenever there's any change in $var, not just a max. Signed-off-by: Tom Zanussi --- Documentation/trace/histogram.txt | 97 +++

[PATCH v3 4/7] tracing: Add conditional snapshot

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, tracing snapshots are context-free - they capture the ring buffer contents at the time the tracing_snapshot() function was invoked, and nothing else. Additionally, they're always taken unconditionally - the calling code can decide whether or not to take a snapshot,

Re: [PATCH 28/33] vfs: syscall: Add fsconfig() for configuring and managing a context [ver #11]

2018-08-09 Thread Miklos Szeredi
On Thu, Aug 9, 2018 at 4:24 PM, David Howells wrote: > Eric W. Biederman wrote: > >> First let me thank you for adding both FSCONFIG_CMD_CREATE and >> FSCONFIG_CMD_RECONFIGURE. Unfortunately the implementation is currently >> broken. So this patch gets my: >> >> This is broken in two specific

[PATCH v3 7/7] tracing: Add hist trigger onchange() handler

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for a hist:onchange($var) handler, similar to the onmax() handler but triggering whenever there's any change in $var, not just a max. Signed-off-by: Tom Zanussi --- Documentation/trace/histogram.txt | 97 +++

[PATCH v3 5/7] tracing: Move hist trigger key printing into a separate function

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Future patches will want to print a histogram key outside a histogram - add and use hist_trigger_print_key() for that purpose. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff

[PATCH v3 5/7] tracing: Move hist trigger key printing into a separate function

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Future patches will want to print a histogram key outside a histogram - add and use hist_trigger_print_key() for that purpose. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff

[PATCH v3 6/7] tracing: Add snapshot action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for hist:handlerXXX($var).snapshot(), which will take a snapshot of the current trace buffer whenever handlerXXX is hit. As a first user, this also adds snapshot() action support for the onmax() handler i.e. hist:onmax($var).snapshot(). Signed-off-by: Tom Zanussi

[PATCH v3 6/7] tracing: Add snapshot action

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Add support for hist:handlerXXX($var).snapshot(), which will take a snapshot of the current trace buffer whenever handlerXXX is hit. As a first user, this also adds snapshot() action support for the onmax() handler i.e. hist:onmax($var).snapshot(). Signed-off-by: Tom Zanussi

[PATCH v3 2/7] tracing: Split up onmatch action data

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, the onmatch action data binds the onmatch action to data related to synthetic event generation. Since we want to allow the onmatch handler to potentially invoke a different action, and because we expect other handlers to generate synthetic events, we need to

[PATCH v3 1/7] tracing: Refactor hist trigger action code

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The hist trigger action code currently implements two essentially hard-coded pairs of 'actions' - onmax(), which tracks a variable and saves some event fields when a max is hit, and onmatch(), which is hard-coded to generate a synthetic event. These hardcoded pairs (track

[PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Hi, This is v3 of the hist trigger snapshot and onchange additions patchset. It's rebased on top of the latest ftrace/core and adds a few fixes to some handler/action problems I noticed while testing. v2->v3 changes: - fixed problem where trace actions were only being

[PATCH v3 2/7] tracing: Split up onmatch action data

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Currently, the onmatch action data binds the onmatch action to data related to synthetic event generation. Since we want to allow the onmatch handler to potentially invoke a different action, and because we expect other handlers to generate synthetic events, we need to

[PATCH v3 1/7] tracing: Refactor hist trigger action code

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi The hist trigger action code currently implements two essentially hard-coded pairs of 'actions' - onmax(), which tracks a variable and saves some event fields when a max is hit, and onmatch(), which is hard-coded to generate a synthetic event. These hardcoded pairs (track

[PATCH v3 0/7] tracing: Hist trigger snapshot and onchange additions

2018-08-09 Thread Tom Zanussi
From: Tom Zanussi Hi, This is v3 of the hist trigger snapshot and onchange additions patchset. It's rebased on top of the latest ftrace/core and adds a few fixes to some handler/action problems I noticed while testing. v2->v3 changes: - fixed problem where trace actions were only being

[PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet Having a specific cache for the fcall allocations helps speed up allocations a bit, especially in case of non-"round" msizes. The caches will automatically be merged if there are multiple caches of items with the same size so we do not need to try to share a cache

[PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet 'msize' is often a power of two, or at least page-aligned, so avoiding an overhead of two dozen bytes for each allocation will help the allocator do its work and reduce memory fragmentation. Suggested-by: Matthew Wilcox Signed-off-by: Dominique Martinet Reviewed-by:

[PATCH v3 2/2] net/9p: add a per-client fcall kmem_cache

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet Having a specific cache for the fcall allocations helps speed up allocations a bit, especially in case of non-"round" msizes. The caches will automatically be merged if there are multiple caches of items with the same size so we do not need to try to share a cache

[PATCH v3 1/2] net/9p: embed fcall in req to round down buffer allocs

2018-08-09 Thread Dominique Martinet
From: Dominique Martinet 'msize' is often a power of two, or at least page-aligned, so avoiding an overhead of two dozen bytes for each allocation will help the allocator do its work and reduce memory fragmentation. Suggested-by: Matthew Wilcox Signed-off-by: Dominique Martinet Reviewed-by:

<    2   3   4   5   6   7   8   9   10   11   >