Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Sebastian Gottschall
Am 15.08.2018 um 21:42 schrieb Linus Torvalds: On Wed, Aug 15, 2018 at 12:26 PM Guenter Roeck wrote: Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm. Grr. I think it's due mainly due to commit 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h"), which

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Sebastian Gottschall
Am 15.08.2018 um 21:42 schrieb Linus Torvalds: On Wed, Aug 15, 2018 at 12:26 PM Guenter Roeck wrote: Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm. Grr. I think it's due mainly due to commit 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h"), which

Re: [PATCH 4.17 00/97] 4.17.15-stable review

2018-08-15 Thread Dan Rue
On Tue, Aug 14, 2018 at 07:16:12PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.17.15 release. > There are 97 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.17 00/97] 4.17.15-stable review

2018-08-15 Thread Dan Rue
On Tue, Aug 14, 2018 at 07:16:12PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.17.15 release. > There are 97 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible

2018-08-15 Thread Stephen Boyd
Quoting Craig Tatlor (2018-08-11 09:24:50) > Add the compatible for SDM660. > This does not need clocks to do scm calls > > Signed-off-by: Craig Tatlor > --- > Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + > drivers/firmware/qcom_scm.c | 3 +++ > 2

Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible

2018-08-15 Thread Stephen Boyd
Quoting Craig Tatlor (2018-08-11 09:24:50) > Add the compatible for SDM660. > This does not need clocks to do scm calls > > Signed-off-by: Craig Tatlor > --- > Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 + > drivers/firmware/qcom_scm.c | 3 +++ > 2

Re: [PATCH v3 1/2] dt-bindings: i2c: npcm7xx: add binding for i2c controller

2018-08-15 Thread Rob Herring
On Tue, Aug 14, 2018 at 09:29:06PM +0300, Tali Perry wrote: > > Nuvoton NPCM7XX I2C Controller > NPCM7xx includes 16 I2C contollers. This driver operates the controller. s/contollers/controllers/ > This module also includes a slave mode, which will be submitted later on. > > Any feedback would

Re: [PATCH v3 1/2] dt-bindings: i2c: npcm7xx: add binding for i2c controller

2018-08-15 Thread Rob Herring
On Tue, Aug 14, 2018 at 09:29:06PM +0300, Tali Perry wrote: > > Nuvoton NPCM7XX I2C Controller > NPCM7xx includes 16 I2C contollers. This driver operates the controller. s/contollers/controllers/ > This module also includes a slave mode, which will be submitted later on. > > Any feedback would

Re: unregister_netdevice: waiting for DEV to become free (2)

2018-08-15 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:31130a16d459 Merge tag 'for-linus-4.19-rc1-tag' of git://g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1116b46c40 kernel config:

Re: unregister_netdevice: waiting for DEV to become free (2)

2018-08-15 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:31130a16d459 Merge tag 'for-linus-4.19-rc1-tag' of git://g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1116b46c40 kernel config:

Re: [PATCH v4 4/6] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-08-15 Thread Rob Herring
On Tue, 14 Aug 2018 19:50:18 +0300, Leonard Crestez wrote: > This is documented as "required" but won't be present in old dtbs. > > These resets are also present on other imx chips but right now only > imx7d implements them through the reset controller subsystem. > > Signed-off-by: Leonard

Re: [PATCH v4 4/6] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-08-15 Thread Rob Herring
On Tue, 14 Aug 2018 19:50:18 +0300, Leonard Crestez wrote: > This is documented as "required" but won't be present in old dtbs. > > These resets are also present on other imx chips but right now only > imx7d implements them through the reset controller subsystem. > > Signed-off-by: Leonard

[PATCH] gpio: 74x164: add lines-initial-states property

2018-08-15 Thread David Bauer
This adds the ability to define the initial state of each output line on device probe. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 + drivers/gpio/gpio-74x164.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH] gpio: 74x164: add lines-initial-states property

2018-08-15 Thread David Bauer
This adds the ability to define the initial state of each output line on device probe. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 + drivers/gpio/gpio-74x164.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

Re: [PATCH v4 3/6] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-08-15 Thread Rob Herring
On Tue, Aug 14, 2018 at 07:50:17PM +0300, Leonard Crestez wrote: > This is required for the imx pci driver to send the PME_Turn_Off TLP. > > Signed-off-by: Leonard Crestez > --- > drivers/reset/reset-imx7.c | 1 + > include/dt-bindings/reset/imx7-reset.h | 4 +++- Acked-by: Rob

Re: [PATCH v4 3/6] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-08-15 Thread Rob Herring
On Tue, Aug 14, 2018 at 07:50:17PM +0300, Leonard Crestez wrote: > This is required for the imx pci driver to send the PME_Turn_Off TLP. > > Signed-off-by: Leonard Crestez > --- > drivers/reset/reset-imx7.c | 1 + > include/dt-bindings/reset/imx7-reset.h | 4 +++- Acked-by: Rob

[PATCH] x86: i8259: Add missing include file

2018-08-15 Thread Guenter Roeck
i8259.h uses inb/outb and thus needs to include asm/io.h to avoid the following build error, as seen with x86_64:defconfig and CONFIG_SMP=n. In file included from drivers/rtc/rtc-cmos.c:45:0: arch/x86/include/asm/i8259.h: In function 'inb_pic': arch/x86/include/asm/i8259.h:32:24: error:

[PATCH] x86: i8259: Add missing include file

2018-08-15 Thread Guenter Roeck
i8259.h uses inb/outb and thus needs to include asm/io.h to avoid the following build error, as seen with x86_64:defconfig and CONFIG_SMP=n. In file included from drivers/rtc/rtc-cmos.c:45:0: arch/x86/include/asm/i8259.h: In function 'inb_pic': arch/x86/include/asm/i8259.h:32:24: error:

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 12:45 PM Kees Cook wrote: > > I feel like we're talking cross purposes. The BUG() cases were for > places where we detect that we're executing with an impossible stack > pointer. It seems like trying to recover from that would just hide the > corruption for a later time

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 12:45 PM Kees Cook wrote: > > I feel like we're talking cross purposes. The BUG() cases were for > places where we detect that we're executing with an impossible stack > pointer. It seems like trying to recover from that would just hide the > corruption for a later time

Re: [PATCH 4.18 00/79] 4.18.1-stable review

2018-08-15 Thread Dan Rue
On Tue, Aug 14, 2018 at 07:16:19PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.1 release. > There are 79 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.18 00/79] 4.18.1-stable review

2018-08-15 Thread Dan Rue
On Tue, Aug 14, 2018 at 07:16:19PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.1 release. > There are 79 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 1/6] nds32/ftrace: Support static function tracer

2018-08-15 Thread Steven Rostedt
On Wed, 15 Aug 2018 17:35:18 +0800 Zong Li wrote: > This patch support the static function tracer. On nds32 ABI, we need to > always push return address to stack for __builtin_return_address can > work correctly, otherwise, it will get the wrong value of $lp at leaf > function. > >

Re: [PATCH 1/6] nds32/ftrace: Support static function tracer

2018-08-15 Thread Steven Rostedt
On Wed, 15 Aug 2018 17:35:18 +0800 Zong Li wrote: > This patch support the static function tracer. On nds32 ABI, we need to > always push return address to stack for __builtin_return_address can > work correctly, otherwise, it will get the wrong value of $lp at leaf > function. > >

[PATCH v2 1/2] arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
ARM64's pfn_valid() shifts away the upper PAGE_SHIFT bits of the input before seeing if the PFN is valid. This leads to false positives when some of the upper bits are set, but the lower bits match a valid PFN. For example, the following userspace code looks up a bogus entry in /proc/kpageflags:

[PATCH v2 1/2] arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
ARM64's pfn_valid() shifts away the upper PAGE_SHIFT bits of the input before seeing if the PFN is valid. This leads to false positives when some of the upper bits are set, but the lower bits match a valid PFN. For example, the following userspace code looks up a bogus entry in /proc/kpageflags:

[PATCH v2 2/2] arm: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
ARM's pfn_valid() has a similar shifting bug to the ARM64 bug fixed in the previous patch. This only affects non-LPAE kernels, since LPAE kernels will promote to 64 bits inside __pfn_to_phys(). Fixes: 5e6f6aa1c243 ("memblock/arm: pfn_valid uses memblock_is_memory()") Cc: sta...@vger.kernel.org

[PATCH v2 2/2] arm: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
ARM's pfn_valid() has a similar shifting bug to the ARM64 bug fixed in the previous patch. This only affects non-LPAE kernels, since LPAE kernels will promote to 64 bits inside __pfn_to_phys(). Fixes: 5e6f6aa1c243 ("memblock/arm: pfn_valid uses memblock_is_memory()") Cc: sta...@vger.kernel.org

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Vivek Goyal
On Wed, Aug 15, 2018 at 09:06:13PM +0200, Yannik Sembritzki wrote: > > > I am wondering why did we have to split this keyring to begin with. > > So there are use cases where we want to trust builtin keys but > > not the ones which came from other places (UEFI secure boot db, or > > user loaded

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Vivek Goyal
On Wed, Aug 15, 2018 at 09:06:13PM +0200, Yannik Sembritzki wrote: > > > I am wondering why did we have to split this keyring to begin with. > > So there are use cases where we want to trust builtin keys but > > not the ones which came from other places (UEFI secure boot db, or > > user loaded

Re: A far fetched goal to clean up code quality

2018-08-15 Thread Al Viro
On Wed, Aug 15, 2018 at 08:33:36PM +0200, Martin Schroeder wrote: > I propose using following set of GCC flags to enforce code quality in > the long run. > > -Wall -Wextra -Werror\ > -std=gnu11\ > -pedantic \ > -Wchar-subscripts\ > -Wformat\ > -Wformat-nonliteral\ >

Re: A far fetched goal to clean up code quality

2018-08-15 Thread Al Viro
On Wed, Aug 15, 2018 at 08:33:36PM +0200, Martin Schroeder wrote: > I propose using following set of GCC flags to enforce code quality in > the long run. > > -Wall -Wextra -Werror\ > -std=gnu11\ > -pedantic \ > -Wchar-subscripts\ > -Wformat\ > -Wformat-nonliteral\ >

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Kees Cook
On Wed, Aug 15, 2018 at 12:04 PM, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >>

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Kees Cook
On Wed, Aug 15, 2018 at 12:04 PM, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >>

[PATCH 2/2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Yannik Sembritzki
Signed-off-by: Yannik Sembritzki --- arch/x86/kernel/kexec-bzimage64.c | 2 +- certs/system_keyring.c | 3 ++- crypto/asymmetric_keys/pkcs7_key_type.c | 2 +- include/linux/verification.h| 4 4 files changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 2/2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Yannik Sembritzki
Signed-off-by: Yannik Sembritzki --- arch/x86/kernel/kexec-bzimage64.c | 2 +- certs/system_keyring.c | 3 ++- crypto/asymmetric_keys/pkcs7_key_type.c | 2 +- include/linux/verification.h| 4 4 files changed, 8 insertions(+), 3 deletions(-) diff --git

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Alexander Popov
Hello Linus, On 15.08.2018 22:04, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >>

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Alexander Popov
Hello Linus, On 15.08.2018 22:04, Linus Torvalds wrote: > On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: >> >> I swear I'm doing my best. Are you speaking of >> stackleak_check_alloca() or stackleak_erase()? These were both >> discussed on the list, and we weren't able to come up with >>

[PATCH 1/2] Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

2018-08-15 Thread Yannik Sembritzki
The split of .system_keyring to .builtin_trusted_keys and .secondary_trusted_keys broke kexec, as kernels signed by keys which are now in the secondary keyring cannot be kexec'd anymore. Signed-off-by: Yannik Sembritzki CC: sta...@vger.kernel.org --- arch/x86/kernel/kexec-bzimage64.c | 2 +-

[PATCH 1/2] Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

2018-08-15 Thread Yannik Sembritzki
The split of .system_keyring to .builtin_trusted_keys and .secondary_trusted_keys broke kexec, as kernels signed by keys which are now in the secondary keyring cannot be kexec'd anymore. Signed-off-by: Yannik Sembritzki CC: sta...@vger.kernel.org --- arch/x86/kernel/kexec-bzimage64.c | 2 +-

[PATCH 0/2] Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

2018-08-15 Thread Yannik Sembritzki
I've written two patches for (a) the logical change of allowing kernels signed with keys in the secondary keyring to be kexec'd (b) the refactoring of the magic 1UL Linus requested. Yannik Sembritzki (2): Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

[PATCH 0/2] Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

2018-08-15 Thread Yannik Sembritzki
I've written two patches for (a) the logical change of allowing kernels signed with keys in the secondary keyring to be kexec'd (b) the refactoring of the magic 1UL Linus requested. Yannik Sembritzki (2): Fix kexec forbidding kernels signed with keys in the secondary keyring to boot

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 12:26 PM Guenter Roeck wrote: > > Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm. Grr. I think it's due mainly due to commit 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h"), which exposes a number of files that had some dodgy

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 12:26 PM Guenter Roeck wrote: > > Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm. Grr. I think it's due mainly due to commit 447ae3166702 ("x86: Don't include linux/irq.h from asm/hardirq.h"), which exposes a number of files that had some dodgy

Re: [PATCH V2] perf parser: Improve error message for PMU address filters

2018-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 04, 2018 at 05:25:36PM +0200, Jiri Olsa escreveu: > On Wed, Jul 04, 2018 at 02:13:45PM +0200, Jack Henschel wrote: > > This is the second version of a patch that improves the error > > message of the perf events parser when the PMU hardware does not support > > address filters. > > >

Re: [PATCH V2] perf parser: Improve error message for PMU address filters

2018-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 04, 2018 at 05:25:36PM +0200, Jiri Olsa escreveu: > On Wed, Jul 04, 2018 at 02:13:45PM +0200, Jack Henschel wrote: > > This is the second version of a patch that improves the error > > message of the perf events parser when the PMU hardware does not support > > address filters. > > >

Re: [PATCH 06/13] coresight: etb10: Handle errors enabling the device

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:48PM +0100, Suzuki K Poulose wrote: > Prepare the etb10 driver to return errors in enabling > the device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etb10.c | 18 +- > 1 file changed, 13

Re: [PATCH 06/13] coresight: etb10: Handle errors enabling the device

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:48PM +0100, Suzuki K Poulose wrote: > Prepare the etb10 driver to return errors in enabling > the device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etb10.c | 18 +- > 1 file changed, 13

Re: [PATCH 05/13] coresight: etm3: Add support for handling errors

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:47PM +0100, Suzuki K Poulose wrote: > Add support for reporting errors back from the SMP cross > function call for enabling ETM. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm3x.c | 42 >

Re: [PATCH 05/13] coresight: etm3: Add support for handling errors

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:47PM +0100, Suzuki K Poulose wrote: > Add support for reporting errors back from the SMP cross > function call for enabling ETM. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm3x.c | 42 >

Re: [PATCH] perf: disable parallelism for 'make clean'

2018-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2018 at 09:30:39AM +0200, Rasmus Villemoes escreveu: > On 2018-07-05 15:49, Jiri Olsa wrote: > > On Thu, Jul 05, 2018 at 03:15:27PM +0200, Rasmus Villemoes wrote: > > >> this only happens in combination with a O=... parameter. In any case, we > >> don't lose much by explicitly

Re: [PATCH] perf: disable parallelism for 'make clean'

2018-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2018 at 09:30:39AM +0200, Rasmus Villemoes escreveu: > On 2018-07-05 15:49, Jiri Olsa wrote: > > On Thu, Jul 05, 2018 at 03:15:27PM +0200, Rasmus Villemoes wrote: > > >> this only happens in combination with a O=... parameter. In any case, we > >> don't lose much by explicitly

Re: [PATCH] arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
On 08/14/2018 08:29 AM, Will Deacon wrote: > On Tue, Aug 14, 2018 at 08:17:48AM -0700, Greg Hackmann wrote: >> On 08/14/2018 03:40 AM, Will Deacon wrote: >>> Hi Greg, >>> >>> On Mon, Aug 13, 2018 at 12:30:11PM -0700, Greg Hackmann wrote: ARM64's pfn_valid() shifts away the upper PAGE_SHIFT

Re: [PATCH] arm64: mm: check for upper PAGE_SHIFT bits in pfn_valid()

2018-08-15 Thread Greg Hackmann
On 08/14/2018 08:29 AM, Will Deacon wrote: > On Tue, Aug 14, 2018 at 08:17:48AM -0700, Greg Hackmann wrote: >> On 08/14/2018 03:40 AM, Will Deacon wrote: >>> Hi Greg, >>> >>> On Mon, Aug 13, 2018 at 12:30:11PM -0700, Greg Hackmann wrote: ARM64's pfn_valid() shifts away the upper PAGE_SHIFT

[PATCH v2] scripts: modpost: check memory allocation results

2018-08-15 Thread Randy Dunlap
From: Randy Dunlap Fix missing error check for memory allocation functions in scripts/mod/modpost.c. Fixes kernel bugzilla #200319: https://bugzilla.kernel.org/show_bug.cgi?id=200319 Signed-off-by: Randy Dunlap Cc: Yuexing Wang Cc: Masahiro Yamada --- v2: add checks in more places

[PATCH v2] scripts: modpost: check memory allocation results

2018-08-15 Thread Randy Dunlap
From: Randy Dunlap Fix missing error check for memory allocation functions in scripts/mod/modpost.c. Fixes kernel bugzilla #200319: https://bugzilla.kernel.org/show_bug.cgi?id=200319 Signed-off-by: Randy Dunlap Cc: Yuexing Wang Cc: Masahiro Yamada --- v2: add checks in more places

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Guenter Roeck
On Wed, Aug 15, 2018 at 09:08:08PM +0200, Sebastian Gottschall wrote: > > Am 15.08.2018 um 20:55 schrieb Guenter Roeck: > >On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > >>if i fix the other error (can be reproduced with disable smp on standard > >>i386 build) > >> >

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Guenter Roeck
On Wed, Aug 15, 2018 at 09:08:08PM +0200, Sebastian Gottschall wrote: > > Am 15.08.2018 um 20:55 schrieb Guenter Roeck: > >On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > >>if i fix the other error (can be reproduced with disable smp on standard > >>i386 build) > >> >

Re: linux-next: manual merge of the block tree with the rdma tree

2018-08-15 Thread Jason Gunthorpe
On Wed, Aug 15, 2018 at 11:45:39AM +1000, Stephen Rothwell wrote: > Hi all, > > On Thu, 26 Jul 2018 13:58:04 +1000 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the block tree got a conflict in: > > > > drivers/nvme/target/rdma.c > > > > between commit: > > > >

Re: linux-next: manual merge of the block tree with the rdma tree

2018-08-15 Thread Jason Gunthorpe
On Wed, Aug 15, 2018 at 11:45:39AM +1000, Stephen Rothwell wrote: > Hi all, > > On Thu, 26 Jul 2018 13:58:04 +1000 Stephen Rothwell > wrote: > > > > Today's linux-next merge of the block tree got a conflict in: > > > > drivers/nvme/target/rdma.c > > > > between commit: > > > >

Re: [PATCH 03/13] coresight: tmc-etb/etf: Prepare to handle errors enabling

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:45PM +0100, Suzuki K Poulose wrote: > Prepare to handle errors in enabling the hardware and > report it back to the core driver. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 71 >

Re: [PATCH 03/13] coresight: tmc-etb/etf: Prepare to handle errors enabling

2018-08-15 Thread Mathieu Poirier
On Mon, Aug 06, 2018 at 02:41:45PM +0100, Suzuki K Poulose wrote: > Prepare to handle errors in enabling the hardware and > report it back to the core driver. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 71 >

Re: [RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-15 Thread Matthew Wilcox
On Thu, Aug 16, 2018 at 02:49:48AM +0800, Yang Shi wrote: > +static int do_munmap_zap_rlock(struct mm_struct *mm, unsigned long start, > +size_t len, struct list_head *uf) > +{ > + unsigned long end; > + struct vm_area_struct *start_vma, *prev, *vma; > + int

Re: [RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-15 Thread Matthew Wilcox
On Thu, Aug 16, 2018 at 02:49:48AM +0800, Yang Shi wrote: > +static int do_munmap_zap_rlock(struct mm_struct *mm, unsigned long start, > +size_t len, struct list_head *uf) > +{ > + unsigned long end; > + struct vm_area_struct *start_vma, *prev, *vma; > + int

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > if i fix the other error (can be reproduced with disable smp on standard > i386 build) > > another raises up again related to smp. to be serious. this patchset of x86 > patches is absolutelly broken and put together without

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > if i fix the other error (can be reproduced with disable smp on standard > i386 build) > > another raises up again related to smp. to be serious. this patchset of x86 > patches is absolutelly broken and put together without

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 07:01:38PM +0200, Sebastian Gottschall wrote: > nother issue seen on xscale and as it affects all non SMP configured kernels > > > kernel/cpu.c: In function 'boot_cpu_hotplug_init': > kernel/cpu.c:2204:28: error: 'struct cpuhp_cpu_state' has no member named >

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 07:01:38PM +0200, Sebastian Gottschall wrote: > nother issue seen on xscale and as it affects all non SMP configured kernels > > > kernel/cpu.c: In function 'boot_cpu_hotplug_init': > kernel/cpu.c:2204:28: error: 'struct cpuhp_cpu_state' has no member named >

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 08:33:30PM +0200, Sebastian Gottschall wrote: > > Am 15.08.2018 um 20:26 schrieb Linus Torvalds: > > On Wed, Aug 15, 2018 at 11:22 AM Sebastian Gottschall > > wrote: > > > btw. i found another compile error with x86 :-) > > This should already be fixed by commit

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Greg Kroah-Hartman
On Wed, Aug 15, 2018 at 08:33:30PM +0200, Sebastian Gottschall wrote: > > Am 15.08.2018 um 20:26 schrieb Linus Torvalds: > > On Wed, Aug 15, 2018 at 11:22 AM Sebastian Gottschall > > wrote: > > > btw. i found another compile error with x86 :-) > > This should already be fixed by commit

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Sebastian Gottschall
Am 15.08.2018 um 20:55 schrieb Guenter Roeck: On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: if i fix the other error (can be reproduced with disable smp on standard i386 build) another raises up again related to smp. to be serious. this patchset of x86 patches is

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Sebastian Gottschall
Am 15.08.2018 um 20:55 schrieb Guenter Roeck: On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: if i fix the other error (can be reproduced with disable smp on standard i386 build) another raises up again related to smp. to be serious. this patchset of x86 patches is

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Yannik Sembritzki
> I am wondering why did we have to split this keyring to begin with. > So there are use cases where we want to trust builtin keys but > not the ones which came from other places (UEFI secure boot db, or > user loaded one)? > "User loaded ones" should not be trusted in general to prevent

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Yannik Sembritzki
> I am wondering why did we have to split this keyring to begin with. > So there are use cases where we want to trust builtin keys but > not the ones which came from other places (UEFI secure boot db, or > user loaded one)? > "User loaded ones" should not be trusted in general to prevent

[PATCH v4] spi: orion: cosmetics - alias long direct_access variables

2018-08-15 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dir_acc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel Reviewed-by: Andrew Lunn Reviewed-by: Stefan Roese ---

[PATCH v4] spi: orion: cosmetics - alias long direct_access variables

2018-08-15 Thread Kosta Zertsekel
This change increases the source code readability. Instead of using `spi->child[cs].direct_access.XXX` use `dir_acc->XXX`. Instead of using `orion_spi->child[cs].direct_access.vaddr` use `vaddr`. Signed-off-by: Kosta Zertsekel Reviewed-by: Andrew Lunn Reviewed-by: Stefan Roese ---

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: > > I swear I'm doing my best. Are you speaking of > stackleak_check_alloca() or stackleak_erase()? These were both > discussed on the list, and we weren't able to come up with > alternatives: in both cases we're off the stack, and recovery is >

Re: [GIT PULL] gcc-plugin updates for v4.19-rc1

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 11:35 AM Kees Cook wrote: > > I swear I'm doing my best. Are you speaking of > stackleak_check_alloca() or stackleak_erase()? These were both > discussed on the list, and we weren't able to come up with > alternatives: in both cases we're off the stack, and recovery is >

[GIT PULL] first round of SCSI updates for the 4.18+ merge window

2018-08-15 Thread James Bottomley
This is mostly updates to the usual drivers: mpt3sas, lpfc, qla2xxx, hisi_sas, smartpqi, megaraid_sas, arcmsr. In addition, with the continuing absence of Nic we have target updates for tcmu and target core (all with reviews and acks). The biggest observable change is going to be that we're

[GIT PULL] first round of SCSI updates for the 4.18+ merge window

2018-08-15 Thread James Bottomley
This is mostly updates to the usual drivers: mpt3sas, lpfc, qla2xxx, hisi_sas, smartpqi, megaraid_sas, arcmsr. In addition, with the continuing absence of Nic we have target updates for tcmu and target core (all with reviews and acks). The biggest observable change is going to be that we're

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Vivek Goyal
On Wed, Aug 15, 2018 at 01:42:47PM -0400, Vivek Goyal wrote: > On Wed, Aug 15, 2018 at 07:27:33PM +0200, Yannik Sembritzki wrote: > > Would this be okay? > > [ CC dave young, Baoquan, Justin Forbes] > > Hi Yannik, > > I am reading that bug and wondering that what broke it. It used to work, > so

Re: [PATCH] Fix kexec forbidding kernels signed with custom platform keys to boot

2018-08-15 Thread Vivek Goyal
On Wed, Aug 15, 2018 at 01:42:47PM -0400, Vivek Goyal wrote: > On Wed, Aug 15, 2018 at 07:27:33PM +0200, Yannik Sembritzki wrote: > > Would this be okay? > > [ CC dave young, Baoquan, Justin Forbes] > > Hi Yannik, > > I am reading that bug and wondering that what broke it. It used to work, > so

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Guenter Roeck
On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > if i fix the other error (can be reproduced with disable smp on standard > i386 build) > > another raises up again related to smp. to be serious. this patchset of x86 > patches is absolutelly broken and put together without

Re: [PATCH 4.9 000/107] 4.9.120-stable review

2018-08-15 Thread Guenter Roeck
On Wed, Aug 15, 2018 at 08:27:00PM +0200, Sebastian Gottschall wrote: > if i fix the other error (can be reproduced with disable smp on standard > i386 build) > > another raises up again related to smp. to be serious. this patchset of x86 > patches is absolutelly broken and put together without

Re: general protection fault in send_sigurg_to_task

2018-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2018 at 10:11:20AM +1000, Stephen Rothwell wrote: > Hi Bruce, > > On Tue, 14 Aug 2018 13:50:20 -0700 Dmitry Vyukov wrote: > > > > On Tue, Aug 14, 2018 at 12:11 PM, J. Bruce Fields > > wrote: > > > On Mon, Aug 13, 2018 at 06:33:02AM -0700, syzbot wrote: > > >> syzbot has found

Re: general protection fault in send_sigurg_to_task

2018-08-15 Thread J. Bruce Fields
On Wed, Aug 15, 2018 at 10:11:20AM +1000, Stephen Rothwell wrote: > Hi Bruce, > > On Tue, 14 Aug 2018 13:50:20 -0700 Dmitry Vyukov wrote: > > > > On Tue, Aug 14, 2018 at 12:11 PM, J. Bruce Fields > > wrote: > > > On Mon, Aug 13, 2018 at 06:33:02AM -0700, syzbot wrote: > > >> syzbot has found

[RFC v8 PATCH 5/5] mm: unmap VM_PFNMAP mappings with optimized path

2018-08-15 Thread Yang Shi
When unmapping VM_PFNMAP mappings, vm flags need to be updated. Since the vmas have been detached, so it sounds safe to update vm flags with read mmap_sem. Cc: Michal Hocko Cc: Vlastimil Babka Signed-off-by: Yang Shi --- mm/mmap.c | 13 + 1 file changed, 5 insertions(+), 8

[RFC v8 PATCH 5/5] mm: unmap VM_PFNMAP mappings with optimized path

2018-08-15 Thread Yang Shi
When unmapping VM_PFNMAP mappings, vm flags need to be updated. Since the vmas have been detached, so it sounds safe to update vm flags with read mmap_sem. Cc: Michal Hocko Cc: Vlastimil Babka Signed-off-by: Yang Shi --- mm/mmap.c | 13 + 1 file changed, 5 insertions(+), 8

[RFC v8 PATCH 4/5] mm: unmap VM_HUGETLB mappings with optimized path

2018-08-15 Thread Yang Shi
When unmapping VM_HUGETLB mappings, vm flags need to be updated. Since the vmas have been detached, so it sounds safe to update vm flags with read mmap_sem. Cc: Michal Hocko Cc: Vlastimil Babka Signed-off-by: Yang Shi --- mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-15 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

[RFC v8 PATCH 2/5] uprobes: introduce has_uprobes helper

2018-08-15 Thread Yang Shi
We need check if mm or vma has uprobes in the following patch to check if a vma could be unmapped with holding read mmap_sem. The checks and pre-conditions used by uprobe_munmap() look just suitable for this purpose. Extracting those checks into a helper function, has_uprobes(). Cc: Peter

[RFC v8 PATCH 4/5] mm: unmap VM_HUGETLB mappings with optimized path

2018-08-15 Thread Yang Shi
When unmapping VM_HUGETLB mappings, vm flags need to be updated. Since the vmas have been detached, so it sounds safe to update vm flags with read mmap_sem. Cc: Michal Hocko Cc: Vlastimil Babka Signed-off-by: Yang Shi --- mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[RFC v8 PATCH 3/5] mm: mmap: zap pages with read mmap_sem in munmap

2018-08-15 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

[RFC v8 PATCH 2/5] uprobes: introduce has_uprobes helper

2018-08-15 Thread Yang Shi
We need check if mm or vma has uprobes in the following patch to check if a vma could be unmapped with holding read mmap_sem. The checks and pre-conditions used by uprobe_munmap() look just suitable for this purpose. Extracting those checks into a helper function, has_uprobes(). Cc: Peter

[RFC v8 PATCH 1/5] mm: refactor do_munmap() to extract the common part

2018-08-15 Thread Yang Shi
Introduces three new helper functions: * addr_ok() * munmap_lookup_vma() * munlock_vmas() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Reviewed-by: Laurent Dufour Acked-by:

[RFC v8 PATCH 1/5] mm: refactor do_munmap() to extract the common part

2018-08-15 Thread Yang Shi
Introduces three new helper functions: * addr_ok() * munmap_lookup_vma() * munlock_vmas() They will be used by do_munmap() and the new do_munmap with zapping large mapping early in the later patch. There is no functional change, just code refactor. Reviewed-by: Laurent Dufour Acked-by:

[RFC v8 PATCH 0/5] mm: zap pages with read mmap_sem in munmap for large mapping

2018-08-15 Thread Yang Shi
Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://lkml.org/lkml/2017/12/14/733 and https://lkml.org/lkml/2018/2/20/576. History: Then akpm

unregister_netdevice: waiting for DEV to become free (2)

2018-08-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1236568ee3cb Merge tag 'gpio-v4.18-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=135f47e040 kernel config: https://syzkaller.appspot.com/x/.config?x=152cb8ccd35b1f70

[RFC v8 PATCH 0/5] mm: zap pages with read mmap_sem in munmap for large mapping

2018-08-15 Thread Yang Shi
Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://lkml.org/lkml/2017/12/14/733 and https://lkml.org/lkml/2018/2/20/576. History: Then akpm

unregister_netdevice: waiting for DEV to become free (2)

2018-08-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1236568ee3cb Merge tag 'gpio-v4.18-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=135f47e040 kernel config: https://syzkaller.appspot.com/x/.config?x=152cb8ccd35b1f70

<    1   2   3   4   5   6   7   8   9   >