[PATCH 09/29] staging: bcm2835-audio: Fix incorrect draining handling

2018-09-04 Thread Takashi Iwai
The handling of SNDRV_PCM_TRIGGER_STOP at the trigger callback is incorrect: when the STOP is issued, the driver is supposed to drop the stream immediately. Meanwhile bcm2835 driver checks the DRAINING state and tries to issue some different command. This patch straightens things a bit, dropping

[PATCH 01/29] staging: bcm2835-audio: Clean up mutex locks

2018-09-04 Thread Takashi Iwai
snd-bcm2835 driver takes the lock with mutex_lock_interruptible() in all places, which don't make sense. Replace them with the simple mutex_lock(). Also taking a mutex lock right after creating it for each PCM object is nonsense, too. It cannot be racy at that point. We can get rid of it.

[PATCH 10/29] staging: bcm2835-audio: Kill unused spinlock

2018-09-04 Thread Takashi Iwai
The alsa_stream->lock is never used. Kill it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 -- drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 -- 2 files changed, 4 deletions(-) diff --git

[PATCH 10/29] staging: bcm2835-audio: Kill unused spinlock

2018-09-04 Thread Takashi Iwai
The alsa_stream->lock is never used. Kill it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 -- drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 -- 2 files changed, 4 deletions(-) diff --git

[PATCH 13/29] staging: bcm2835-audio: Drop useless NULL check

2018-09-04 Thread Takashi Iwai
alsa_stream->chip can be never NULL. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c

[PATCH 13/29] staging: bcm2835-audio: Drop useless NULL check

2018-09-04 Thread Takashi Iwai
alsa_stream->chip can be never NULL. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c

[PATCH 04/29] staging: bcm2835-audio: Remove redundant substream mask checks

2018-09-04 Thread Takashi Iwai
The avail_substreams bit mask is checked for the possible racy accesses, but this cannot happen in practice; i.e. the assignment and the check are superfluous. Let's rip them off. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 --

[PATCH] Bluetooth: btrtl: make array extension_sig static, shrinks object size

2018-09-04 Thread Colin King
From: Colin Ian King Don't populate the array extension_sig on the stack but instead make it static. Makes the object code smaller by 59 bytes: Before: textdata bss dec hex filename 143664920 0 192864b56 linux/drivers/bluetooth/btrtl.o After: text

[PATCH 11/29] staging: bcm2835-audio: Use PCM runtime values instead

2018-09-04 Thread Takashi Iwai
Some fields in alsa_stream are the values we keep already in PCM runtime object, hence they are redundant. Use the standard PCM runtime values instead of the private copies. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 23 ---

[PATCH 04/29] staging: bcm2835-audio: Remove redundant substream mask checks

2018-09-04 Thread Takashi Iwai
The avail_substreams bit mask is checked for the possible racy accesses, but this cannot happen in practice; i.e. the assignment and the check are superfluous. Let's rip them off. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 --

[PATCH] Bluetooth: btrtl: make array extension_sig static, shrinks object size

2018-09-04 Thread Colin King
From: Colin Ian King Don't populate the array extension_sig on the stack but instead make it static. Makes the object code smaller by 59 bytes: Before: textdata bss dec hex filename 143664920 0 192864b56 linux/drivers/bluetooth/btrtl.o After: text

[PATCH 11/29] staging: bcm2835-audio: Use PCM runtime values instead

2018-09-04 Thread Takashi Iwai
Some fields in alsa_stream are the values we keep already in PCM runtime object, hence they are redundant. Use the standard PCM runtime values instead of the private copies. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 23 ---

[PATCH 05/29] staging: bcm2835-audio: Fix mute controls, volume handling cleanup

2018-09-04 Thread Takashi Iwai
In the current code, the mute control is dealt in a special manner, modifying the current volume and saving the old volume, etc. This is inconsistent (e.g. change the volume while muted, then unmute), and way too complex. Also, the whole volume handling code has conversion between ALSA volume

[PATCH 16/29] staging: bcm2835-audio: Drop superfluous mutex lock during prepare

2018-09-04 Thread Takashi Iwai
The chip->audio_mutex is used basically for protecting the opened stream assignment, and the prepare callback is irrelevant with it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

Re: [PATCH v2] f2fs: fix to avoid NULL pointer dereference on se->discard_map

2018-09-04 Thread Vicente Bergas
On Tue, Sep 4, 2018 at 5:45 PM, Chao Yu wrote: > On 2018/9/4 23:25, Vicente Bergas wrote: >> On Mon, Sep 3, 2018 at 9:52 PM, Chao Yu wrote: >>> From: Chao Yu >>> >>>

[PATCH 08/29] staging: bcm2835-audio: Drop useless running flag and check

2018-09-04 Thread Takashi Iwai
The running flag of alsa_stream is basically useless. The running state is strictly controlled in ALSA PCM core side, hence the check in PCM trigger and close callbacks are superfluous. Also, the prefill ack at trigger start became superfluous nowadays with the ALSA PCM core update. Let's rip

[PATCH 05/29] staging: bcm2835-audio: Fix mute controls, volume handling cleanup

2018-09-04 Thread Takashi Iwai
In the current code, the mute control is dealt in a special manner, modifying the current volume and saving the old volume, etc. This is inconsistent (e.g. change the volume while muted, then unmute), and way too complex. Also, the whole volume handling code has conversion between ALSA volume

[PATCH 16/29] staging: bcm2835-audio: Drop superfluous mutex lock during prepare

2018-09-04 Thread Takashi Iwai
The chip->audio_mutex is used basically for protecting the opened stream assignment, and the prepare callback is irrelevant with it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

Re: [PATCH v2] f2fs: fix to avoid NULL pointer dereference on se->discard_map

2018-09-04 Thread Vicente Bergas
On Tue, Sep 4, 2018 at 5:45 PM, Chao Yu wrote: > On 2018/9/4 23:25, Vicente Bergas wrote: >> On Mon, Sep 3, 2018 at 9:52 PM, Chao Yu wrote: >>> From: Chao Yu >>> >>>

[PATCH 08/29] staging: bcm2835-audio: Drop useless running flag and check

2018-09-04 Thread Takashi Iwai
The running flag of alsa_stream is basically useless. The running state is strictly controlled in ALSA PCM core side, hence the check in PCM trigger and close callbacks are superfluous. Also, the prefill ack at trigger start became superfluous nowadays with the ALSA PCM core update. Let's rip

[PATCH 07/29] staging: bcm2835-audio: Remove superfluous open flag

2018-09-04 Thread Takashi Iwai
All the alsa_stream->open flag checks in the current code are redundant, and they cannot be racy. For the code simplification, let's remove the flag and its check. Signed-off-by: Takashi Iwai --- .../staging/vc04_services/bcm2835-audio/bcm2835-pcm.c| 9 ++---

[PATCH 07/29] staging: bcm2835-audio: Remove superfluous open flag

2018-09-04 Thread Takashi Iwai
All the alsa_stream->open flag checks in the current code are redundant, and they cannot be racy. For the code simplification, let's remove the flag and its check. Signed-off-by: Takashi Iwai --- .../staging/vc04_services/bcm2835-audio/bcm2835-pcm.c| 9 ++---

[PATCH 14/29] staging: bcm2835-audio: Propagate parameter setup error

2018-09-04 Thread Takashi Iwai
When the parameter setup fails, the driver should propagate the error code instead of silently ignoring it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 14/29] staging: bcm2835-audio: Propagate parameter setup error

2018-09-04 Thread Takashi Iwai
When the parameter setup fails, the driver should propagate the error code instead of silently ignoring it. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 17/29] staging: bcm2835-audio: Add 10ms period constraint

2018-09-04 Thread Takashi Iwai
It seems that the resolution of vc04 callback is in 10 msec; i.e. the minimal period size is also 10 msec. This patch adds the corresponding hw constraint. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 15/29] staging: bcm2835-audio: Drop debug messages in bcm2835-pcm.c

2018-09-04 Thread Takashi Iwai
These debug messages worsen the code readability a lot while they give little debuggability (which we already have via tracing, in anyway). Let's clean them up. This allows us to reduce the snd_bcm2835_pcm_lib_ioctl() function to be a direct call of the snd_pcm_lib_ioctl callback (like most

[PATCH 17/29] staging: bcm2835-audio: Add 10ms period constraint

2018-09-04 Thread Takashi Iwai
It seems that the resolution of vc04 callback is in 10 msec; i.e. the minimal period size is also 10 msec. This patch adds the corresponding hw constraint. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 15/29] staging: bcm2835-audio: Drop debug messages in bcm2835-pcm.c

2018-09-04 Thread Takashi Iwai
These debug messages worsen the code readability a lot while they give little debuggability (which we already have via tracing, in anyway). Let's clean them up. This allows us to reduce the snd_bcm2835_pcm_lib_ioctl() function to be a direct call of the snd_pcm_lib_ioctl callback (like most

[PATCH 21/29] staging: bcm2835-audio: Use card->private_data

2018-09-04 Thread Takashi Iwai
Instead of allocating a separate snd_device object, let snd_card_new() allocate the private resource. This simplifies the code. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835.c | 91 +++ 1 file changed, 13 insertions(+), 78 deletions(-) diff --git

[PATCH 24/29] staging: bcm2835-audio: Move module parameter description

2018-09-04 Thread Takashi Iwai
For more consistency, move the module parameter description right after its variable definition. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 06/29] staging: bcm2835-audio: Remove redundant function calls

2018-09-04 Thread Takashi Iwai
bcm2835_audio_setup(), bcm2835_audio_flush_buffers() and bcm2835_audio_flush_playback_buffers() functions do implement nothing. Also, bcm2835_audio_set_ctls() is already called inside bcm2835_audio_set_params(), so the later call is superfluous. This patch removes these superfluous

[PATCH 12/29] staging: bcm2835-audio: Drop unnecessary pcm indirect setup

2018-09-04 Thread Takashi Iwai
The hw_queue_size of PCM indirect helper doesn't need to be set up if you use the whole given buffer size. Drop the useless initialization, which just confuses readers. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 1 - 1 file changed, 1

[PATCH 25/29] staging: bcm2835-audio: Use coherent device buffers

2018-09-04 Thread Takashi Iwai
The memory access to the pages allocated with SNDRV_DMA_TYPE_CONTINUOUS are basically non-coherent, and it becomes a problem when a process accesses via mmap. For the more consistent access, use the device coherent memory, just by replacing the call pattern in the allocator helpers. The only

[PATCH 21/29] staging: bcm2835-audio: Use card->private_data

2018-09-04 Thread Takashi Iwai
Instead of allocating a separate snd_device object, let snd_card_new() allocate the private resource. This simplifies the code. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835.c | 91 +++ 1 file changed, 13 insertions(+), 78 deletions(-) diff --git

[PATCH 24/29] staging: bcm2835-audio: Move module parameter description

2018-09-04 Thread Takashi Iwai
For more consistency, move the module parameter description right after its variable definition. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 06/29] staging: bcm2835-audio: Remove redundant function calls

2018-09-04 Thread Takashi Iwai
bcm2835_audio_setup(), bcm2835_audio_flush_buffers() and bcm2835_audio_flush_playback_buffers() functions do implement nothing. Also, bcm2835_audio_set_ctls() is already called inside bcm2835_audio_set_params(), so the later call is superfluous. This patch removes these superfluous

[PATCH 12/29] staging: bcm2835-audio: Drop unnecessary pcm indirect setup

2018-09-04 Thread Takashi Iwai
The hw_queue_size of PCM indirect helper doesn't need to be set up if you use the whole given buffer size. Drop the useless initialization, which just confuses readers. Signed-off-by: Takashi Iwai --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 1 - 1 file changed, 1

[PATCH 25/29] staging: bcm2835-audio: Use coherent device buffers

2018-09-04 Thread Takashi Iwai
The memory access to the pages allocated with SNDRV_DMA_TYPE_CONTINUOUS are basically non-coherent, and it becomes a problem when a process accesses via mmap. For the more consistent access, use the device coherent memory, just by replacing the call pattern in the allocator helpers. The only

[PATCH 26/29] staging: bcm2835-audio: Set SNDRV_PCM_INFO_SYNC_APPLPTR

2018-09-04 Thread Takashi Iwai
The recent ALSA PCM core supports the SNDRV_PCM_INFO_SYNC_APPLPTR flag indicating that the driver needs the ack call at each appl_ptr update. This is requirement for the indirect PCM implementations like bcm2835-audio driver, too. Signed-off-by: Takashi Iwai ---

[PATCH 26/29] staging: bcm2835-audio: Set SNDRV_PCM_INFO_SYNC_APPLPTR

2018-09-04 Thread Takashi Iwai
The recent ALSA PCM core supports the SNDRV_PCM_INFO_SYNC_APPLPTR flag indicating that the driver needs the ack call at each appl_ptr update. This is requirement for the indirect PCM implementations like bcm2835-audio driver, too. Signed-off-by: Takashi Iwai ---

[PATCH 18/29] staging: bcm2835-audio: Make single vchi handle

2018-09-04 Thread Takashi Iwai
The bcm2835_audio_instance object contains the array of VCHI_SERVICE_HANDLE_T, while the code assumes and uses only the first element explicitly. Let's reduce to a single vchi handle for simplifying the code. Signed-off-by: Takashi Iwai --- .../bcm2835-audio/bcm2835-vchiq.c | 170

[PATCH 18/29] staging: bcm2835-audio: Make single vchi handle

2018-09-04 Thread Takashi Iwai
The bcm2835_audio_instance object contains the array of VCHI_SERVICE_HANDLE_T, while the code assumes and uses only the first element explicitly. Let's reduce to a single vchi handle for simplifying the code. Signed-off-by: Takashi Iwai --- .../bcm2835-audio/bcm2835-vchiq.c | 170

[PATCH 23/29] staging: bcm2835-audio: Remove unnecessary header file includes

2018-09-04 Thread Takashi Iwai
Yet a few header files are included unnecessarily. Drop them. Also remove trivial comments. Signed-off-by: Takashi Iwai --- .../bcm2835-audio/bcm2835-vchiq.c | 19 --- .../vc04_services/bcm2835-audio/bcm2835.h | 6 -- 2 files changed, 25 deletions(-) diff

[PATCH 23/29] staging: bcm2835-audio: Remove unnecessary header file includes

2018-09-04 Thread Takashi Iwai
Yet a few header files are included unnecessarily. Drop them. Also remove trivial comments. Signed-off-by: Takashi Iwai --- .../bcm2835-audio/bcm2835-vchiq.c | 19 --- .../vc04_services/bcm2835-audio/bcm2835.h | 6 -- 2 files changed, 25 deletions(-) diff

[PATCH 19/29] staging: bcm2835-audio: Code refactoring of vchiq accessor codes

2018-09-04 Thread Takashi Iwai
This is a cleanup and code refactoring in bcm2835-vchiq.c. The major code changes are to provide local helpers for easier use of lock / unlock, and message passing with/without response wait. This allows us to reduce lots of open codes. Also, the max packet is set at opening the stream, not at

[PATCH 19/29] staging: bcm2835-audio: Code refactoring of vchiq accessor codes

2018-09-04 Thread Takashi Iwai
This is a cleanup and code refactoring in bcm2835-vchiq.c. The major code changes are to provide local helpers for easier use of lock / unlock, and message passing with/without response wait. This allows us to reduce lots of open codes. Also, the max packet is set at opening the stream, not at

[PATCH 20/29] staging: bcm2835-audio: Operate non-atomic PCM ops

2018-09-04 Thread Takashi Iwai
This is the most significant part in the patch series. The bcm2835-audio driver used to queue the commands to vc04 core via workqueue, but basically the whole accesses to vc04 core are done in the sleepable context, including the callback calls. In such a case, rewriting the code using

[PATCH 20/29] staging: bcm2835-audio: Operate non-atomic PCM ops

2018-09-04 Thread Takashi Iwai
This is the most significant part in the patch series. The bcm2835-audio driver used to queue the commands to vc04 core via workqueue, but basically the whole accesses to vc04 core are done in the sleepable context, including the callback calls. In such a case, rewriting the code using

[PATCH 22/29] staging: bcm2835-audio: Use standard error print helpers

2018-09-04 Thread Takashi Iwai
For making the whole code more consistent, replace the home-made debug print macros with the standard dev_err() & co. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 +- .../bcm2835-audio/bcm2835-vchiq.c | 52 ---

[PATCH 22/29] staging: bcm2835-audio: Use standard error print helpers

2018-09-04 Thread Takashi Iwai
For making the whole code more consistent, replace the home-made debug print macros with the standard dev_err() & co. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 +- .../bcm2835-audio/bcm2835-vchiq.c | 52 ---

[PATCH 27/29] staging: bcm2835-audio: Simplify PCM creation helpers

2018-09-04 Thread Takashi Iwai
All three functions to create PCM objects are fairly resemble, and can be unified to a single common helper. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 87 --- .../vc04_services/bcm2835-audio/bcm2835.c | 17 +++-

[PATCH 28/29] staging: bcm2835-audio: Simplify kctl creation helpers

2018-09-04 Thread Takashi Iwai
Just a minor code refactoring and adding some const prefix. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 69 +++ 1 file changed, 25 insertions(+), 44 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c

[PATCH 29/29] staging: bcm2835-audio: Simplify card object management

2018-09-04 Thread Takashi Iwai
Instead of creating a dummy child device to manage the card object, just use devm stuff directly for releasing with snd_card_free(). This results in a lot of code reduction. Since the dummy child devices are gone, the device object to be passed to the memory allocator needs to be adjusted as

[PATCH 27/29] staging: bcm2835-audio: Simplify PCM creation helpers

2018-09-04 Thread Takashi Iwai
All three functions to create PCM objects are fairly resemble, and can be unified to a single common helper. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 87 --- .../vc04_services/bcm2835-audio/bcm2835.c | 17 +++-

[PATCH 28/29] staging: bcm2835-audio: Simplify kctl creation helpers

2018-09-04 Thread Takashi Iwai
Just a minor code refactoring and adding some const prefix. Signed-off-by: Takashi Iwai --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 69 +++ 1 file changed, 25 insertions(+), 44 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c

[PATCH 29/29] staging: bcm2835-audio: Simplify card object management

2018-09-04 Thread Takashi Iwai
Instead of creating a dummy child device to manage the card object, just use devm stuff directly for releasing with snd_card_free(). This results in a lot of code reduction. Since the dummy child devices are gone, the device object to be passed to the memory allocator needs to be adjusted as

Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:10:24AM -0500, Andrew F. Davis wrote: > On 09/04/2018 09:55 AM, Mark Brown wrote: > > you get to keep the pieces" territory. If we really want to have a way > > of explicitly specifying that some widgets should never be turned on > > then it feels like rather than have

Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:10:24AM -0500, Andrew F. Davis wrote: > On 09/04/2018 09:55 AM, Mark Brown wrote: > > you get to keep the pieces" territory. If we really want to have a way > > of explicitly specifying that some widgets should never be turned on > > then it feels like rather than have

Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling

2018-09-04 Thread Andrew F. Davis
On 09/04/2018 10:49 AM, Mark Brown wrote: > On Tue, Sep 04, 2018 at 10:03:40AM -0500, Andrew F. Davis wrote: >> On 09/04/2018 09:57 AM, Mark Brown wrote: > >>> It's there to save us having to rewrite the register cache if we asked >>> for the device to be powered down but that didn't actually

Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling

2018-09-04 Thread Andrew F. Davis
On 09/04/2018 10:49 AM, Mark Brown wrote: > On Tue, Sep 04, 2018 at 10:03:40AM -0500, Andrew F. Davis wrote: >> On 09/04/2018 09:57 AM, Mark Brown wrote: > >>> It's there to save us having to rewrite the register cache if we asked >>> for the device to be powered down but that didn't actually

[PATCH v2] of: __of_update_property_sysfs only call __of_sysfs_remove_bin_file if of_node_is_attached

2018-09-04 Thread Andre Kalb
To prevent warning "kernfs: can not remove '(null)', no directory" if an overlay isn't applied to the active devicetree. Using of_remove_property and then of_add_property doesn't show the warning. Signed-off-by: Andre Kalb --- Changes in v2: - Fix typo drivers/of/kobj.c | 2 +- 1 file

Re: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len

2018-09-04 Thread Alex Williamson
On Mon, 27 Aug 2018 05:47:21 -0700 Li Qiang wrote: > Free the vdev->msi_perm in error path. > > Signed-off-by: Li Qiang > --- > drivers/vfio/pci/vfio_pci_config.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c >

[PATCH v2] of: __of_update_property_sysfs only call __of_sysfs_remove_bin_file if of_node_is_attached

2018-09-04 Thread Andre Kalb
To prevent warning "kernfs: can not remove '(null)', no directory" if an overlay isn't applied to the active devicetree. Using of_remove_property and then of_add_property doesn't show the warning. Signed-off-by: Andre Kalb --- Changes in v2: - Fix typo drivers/of/kobj.c | 2 +- 1 file

Re: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len

2018-09-04 Thread Alex Williamson
On Mon, 27 Aug 2018 05:47:21 -0700 Li Qiang wrote: > Free the vdev->msi_perm in error path. > > Signed-off-by: Li Qiang > --- > drivers/vfio/pci/vfio_pci_config.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c >

Re: [PATCH v2 2/3] ASoC: tlv320aic31xx: Add headphone/headset detection

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:36:18AM -0500, Andrew F. Davis wrote: > This device can detect the insertion/removal of headphones and headsets. > Enable reporting this status by enabling this interrupt and forwarding > this to upper-layers if a jack has been defined. This doesn't apply against

Re: [PATCH v2 2/3] ASoC: tlv320aic31xx: Add headphone/headset detection

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:36:18AM -0500, Andrew F. Davis wrote: > This device can detect the insertion/removal of headphones and headsets. > Enable reporting this status by enabling this interrupt and forwarding > this to upper-layers if a jack has been defined. This doesn't apply against

Re: [RFC] perf tool improvement requests

2018-09-04 Thread Stephane Eranian
Arnaldo, On Tue, Sep 4, 2018 at 6:42 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 04, 2018 at 09:10:49AM +0200, Peter Zijlstra escreveu: > > On Mon, Sep 03, 2018 at 07:45:48PM -0700, Stephane Eranian wrote: > > > A few weeks ago, you had asked if I had more requests for the perf tool. > >

Re: [RFC] perf tool improvement requests

2018-09-04 Thread Stephane Eranian
Arnaldo, On Tue, Sep 4, 2018 at 6:42 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 04, 2018 at 09:10:49AM +0200, Peter Zijlstra escreveu: > > On Mon, Sep 03, 2018 at 07:45:48PM -0700, Stephane Eranian wrote: > > > A few weeks ago, you had asked if I had more requests for the perf tool. > >

Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:03:40AM -0500, Andrew F. Davis wrote: > On 09/04/2018 09:57 AM, Mark Brown wrote: > > It's there to save us having to rewrite the register cache if we asked > > for the device to be powered down but that didn't actually happen due to > > other constraints, we know all

Re: [PATCH] ASoC: tlv320aic31xx: Remove regulator notification handling

2018-09-04 Thread Mark Brown
On Tue, Sep 04, 2018 at 10:03:40AM -0500, Andrew F. Davis wrote: > On 09/04/2018 09:57 AM, Mark Brown wrote: > > It's there to save us having to rewrite the register cache if we asked > > for the device to be powered down but that didn't actually happen due to > > other constraints, we know all

[PATCH] staging: most: net: make array 'broadcast' static, shrinks object size

2018-09-04 Thread Colin King
From: Colin Ian King Don't populate the array 'broadcast' on the stack but instead make it static. Makes the object code smaller by 53 bytes: Before: textdata bss dec hex filename 105111521 448 1248030c0 drivers/staging/most/net/net.o After: textdata

[PATCH] staging: most: net: make array 'broadcast' static, shrinks object size

2018-09-04 Thread Colin King
From: Colin Ian King Don't populate the array 'broadcast' on the stack but instead make it static. Makes the object code smaller by 53 bytes: Before: textdata bss dec hex filename 105111521 448 1248030c0 drivers/staging/most/net/net.o After: textdata

Re: [PATCH v2] f2fs: fix to avoid NULL pointer dereference on se->discard_map

2018-09-04 Thread Chao Yu
On 2018/9/4 23:25, Vicente Bergas wrote: > On Mon, Sep 3, 2018 at 9:52 PM, Chao Yu wrote: >> From: Chao Yu >> >>

Re: [PATCH v2] f2fs: fix to avoid NULL pointer dereference on se->discard_map

2018-09-04 Thread Chao Yu
On 2018/9/4 23:25, Vicente Bergas wrote: > On Mon, Sep 3, 2018 at 9:52 PM, Chao Yu wrote: >> From: Chao Yu >> >>

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-09-04 Thread Sean Christopherson
On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > +

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-09-04 Thread Sean Christopherson
On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > +

Re: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support

2018-09-04 Thread Pu Wen
On 2018/9/4 22:52, Borislav Petkov wrote: Add Hygon support in amd_postcore_init(), early_root_info_init(). This whole commit message needs to not say *what* the patch does. Will rework the whole commit messages. +#define PCI_DEVICE_ID_HYGON_18H_ROOT 0x1450 +#define

Re: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support

2018-09-04 Thread Pu Wen
On 2018/9/4 22:52, Borislav Petkov wrote: Add Hygon support in amd_postcore_init(), early_root_info_init(). This whole commit message needs to not say *what* the patch does. Will rework the whole commit messages. +#define PCI_DEVICE_ID_HYGON_18H_ROOT 0x1450 +#define

Re: POSIX violation by writeback error

2018-09-04 Thread Jeff Layton
On Tue, 2018-09-04 at 22:56 +0800, 焦晓冬 wrote: > On Tue, Sep 4, 2018 at 7:09 PM Jeff Layton wrote: > > > > On Tue, 2018-09-04 at 16:58 +0800, Trol wrote: > > > On Tue, Sep 4, 2018 at 3:53 PM Rogier Wolff > > > wrote: > > > > > > ... > > > > > > > > > > Jlayton's patch is simple but wonderful

Re: POSIX violation by writeback error

2018-09-04 Thread Jeff Layton
On Tue, 2018-09-04 at 22:56 +0800, 焦晓冬 wrote: > On Tue, Sep 4, 2018 at 7:09 PM Jeff Layton wrote: > > > > On Tue, 2018-09-04 at 16:58 +0800, Trol wrote: > > > On Tue, Sep 4, 2018 at 3:53 PM Rogier Wolff > > > wrote: > > > > > > ... > > > > > > > > > > Jlayton's patch is simple but wonderful

[PATCH v2 03/03] clk: actions: Add Actions Semi S500 SoC clock support

2018-09-04 Thread Edgar Bernardi Righi
Basic clock support for S500 SoC was implemented using the Actions Semi Owl clock driver. This patch also adds custom delay support to Actions Semi OWL pll clock driver. The default delay (50us) is not enough for Actions Semi Owl S500 SoC. It needs up to 150us. A new field called "delay" was added

[PATCH v2 03/03] clk: actions: Add Actions Semi S500 SoC clock support

2018-09-04 Thread Edgar Bernardi Righi
Basic clock support for S500 SoC was implemented using the Actions Semi Owl clock driver. This patch also adds custom delay support to Actions Semi OWL pll clock driver. The default delay (50us) is not enough for Actions Semi Owl S500 SoC. It needs up to 150us. A new field called "delay" was added

Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-04 Thread Tony Lindgren
* Ulf Hansson [180904 14:39]: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 > > > > The wakeirq stays in /proc-interrupts >

[PATCH v2 02/03] arm: dts: actions: Enable clock controller for Actions Semi S500 SoC

2018-09-04 Thread Edgar Bernardi Righi
Enable clock controller for Actions Semi S500 SoC on owl-s500 device tree. Set UART clock reference from CMU for Actions Semi S500 SoC. Tested on a Lemaker Guitar board. Signed-off-by: Edgar Bernardi Righi diff --git a/arch/arm/boot/dts/owl-s500-cubieboard6.dts

Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

2018-09-04 Thread Tony Lindgren
* Ulf Hansson [180904 14:39]: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 > > > > The wakeirq stays in /proc-interrupts >

[PATCH v2 02/03] arm: dts: actions: Enable clock controller for Actions Semi S500 SoC

2018-09-04 Thread Edgar Bernardi Righi
Enable clock controller for Actions Semi S500 SoC on owl-s500 device tree. Set UART clock reference from CMU for Actions Semi S500 SoC. Tested on a Lemaker Guitar board. Signed-off-by: Edgar Bernardi Righi diff --git a/arch/arm/boot/dts/owl-s500-cubieboard6.dts

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-09-04 Thread Jarkko Sakkinen
On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > wrote: > > > > Add a Enclave Page Cache (EPC) memory manager that can be used to > > allocate and free EPC pages. The swapper thread ksgxswapd reclaims pages > > on the event when

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-09-04 Thread Jarkko Sakkinen
On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > wrote: > > > > Add a Enclave Page Cache (EPC) memory manager that can be used to > > allocate and free EPC pages. The swapper thread ksgxswapd reclaims pages > > on the event when

Re: [PATCH v2] ARM: dts: imx6ul: Add DTS for ConnectCore 6UL SBC Pro

2018-09-04 Thread Fabio Estevam
On Tue, Sep 4, 2018 at 12:28 PM, Alex Gonzalez wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_lcdif_dat0_17 > +_lcdif_clken > +_lcdif_hvsync>; > + lcd-supply = <_ext>; /* BU90T82 LVDS bridge power */ > + status

Re: [PATCH v2] ARM: dts: imx6ul: Add DTS for ConnectCore 6UL SBC Pro

2018-09-04 Thread Fabio Estevam
On Tue, Sep 4, 2018 at 12:28 PM, Alex Gonzalez wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_lcdif_dat0_17 > +_lcdif_clken > +_lcdif_hvsync>; > + lcd-supply = <_ext>; /* BU90T82 LVDS bridge power */ > + status

Re: [PATCH] rtl8xxxu: Add rtl8188ctv support

2018-09-04 Thread Jes Sorensen
On 09/04/2018 04:16 AM, Kalle Valo wrote: > Aleksei Mamlin wrote: > >> The Realtek rtl8188ctv (0x0bda:0x018a) is a highly integrated single-chip >> WLAN USB2.0 network interface controller. >> >> Currently rtl8188ctv is supported by rtlwifi driver. >> It is similar to the

Re: [PATCH] rtl8xxxu: Add rtl8188ctv support

2018-09-04 Thread Jes Sorensen
On 09/04/2018 04:16 AM, Kalle Valo wrote: > Aleksei Mamlin wrote: > >> The Realtek rtl8188ctv (0x0bda:0x018a) is a highly integrated single-chip >> WLAN USB2.0 network interface controller. >> >> Currently rtl8188ctv is supported by rtlwifi driver. >> It is similar to the

[PATCH v2 2/3] ASoC: tlv320aic31xx: Add headphone/headset detection

2018-09-04 Thread Andrew F. Davis
This device can detect the insertion/removal of headphones and headsets. Enable reporting this status by enabling this interrupt and forwarding this to upper-layers if a jack has been defined. This jack definition and the resulting operation from a jack detection event must currently be defined

Re: [PATCH 06/27] clk: sunxi-ng: h6: Set video PLLs limits

2018-09-04 Thread kbuild test robot
Hi Jernej, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sunxi/sunxi/for-next] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 2/3] ASoC: tlv320aic31xx: Add headphone/headset detection

2018-09-04 Thread Andrew F. Davis
This device can detect the insertion/removal of headphones and headsets. Enable reporting this status by enabling this interrupt and forwarding this to upper-layers if a jack has been defined. This jack definition and the resulting operation from a jack detection event must currently be defined

Re: [PATCH 06/27] clk: sunxi-ng: h6: Set video PLLs limits

2018-09-04 Thread kbuild test robot
Hi Jernej, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sunxi/sunxi/for-next] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 3/3] ASoC: tlv320aic31xx: Add button press detection

2018-09-04 Thread Andrew F. Davis
This device can optionally detect headset or microphone button presses. Add support for this by passing this event to the jack layer. Signed-off-by: Andrew F. Davis --- sound/soc/codecs/tlv320aic31xx.c | 17 +++-- sound/soc/codecs/tlv320aic31xx.h | 3 ++- 2 files changed, 17

[PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit for Actions Semi S500 SoC

2018-09-04 Thread Edgar Bernardi Righi
Add Clock Management Unit for Actions Semi S500 SoC. Dt-Bindings constants added. Tested on a Lemaker Guitar board. Signed-off-by: Edgar Bernardi Righi diff --git a/include/dt-bindings/clock/actions,s500-cmu.h b/include/dt-bindings/clock/actions,s500-cmu.h new file mode 100644 index

[PATCH v2 3/3] ASoC: tlv320aic31xx: Add button press detection

2018-09-04 Thread Andrew F. Davis
This device can optionally detect headset or microphone button presses. Add support for this by passing this event to the jack layer. Signed-off-by: Andrew F. Davis --- sound/soc/codecs/tlv320aic31xx.c | 17 +++-- sound/soc/codecs/tlv320aic31xx.h | 3 ++- 2 files changed, 17

[PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit for Actions Semi S500 SoC

2018-09-04 Thread Edgar Bernardi Righi
Add Clock Management Unit for Actions Semi S500 SoC. Dt-Bindings constants added. Tested on a Lemaker Guitar board. Signed-off-by: Edgar Bernardi Righi diff --git a/include/dt-bindings/clock/actions,s500-cmu.h b/include/dt-bindings/clock/actions,s500-cmu.h new file mode 100644 index

<    1   2   3   4   5   6   7   8   9   10   >