Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Jacek Anaszewski
Hi Baolin, On 09/25/2018 01:15 PM, Baolin Wang wrote: > On 23 September 2018 at 20:25, Jacek Anaszewski > wrote: >> On 09/22/2018 09:44 PM, Pavel Machek wrote: >>> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Jacek Anaszewski
Hi Baolin, On 09/25/2018 01:15 PM, Baolin Wang wrote: > On 23 September 2018 at 20:25, Jacek Anaszewski > wrote: >> On 09/22/2018 09:44 PM, Pavel Machek wrote: >>> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17

Re: [PATCH 1/1] MIPS: Add new Kconfig variable to avoid unaligned access instructions

2018-09-25 Thread Paul Burton
Hi Yasha, On Tue, Sep 25, 2018 at 10:30:52PM +0300, Yasha Cherikovsky wrote: > On Tue, 2018-09-25 at 17:45 +, Paul Burton wrote: > > How about we: > > > > - Add a Kconfig option CONFIG_CPU_SUPPORTS_LOAD_STORE_LR, and > > select > > it for all existing pre-r6 targets (probably from

Re: [PATCH 1/1] MIPS: Add new Kconfig variable to avoid unaligned access instructions

2018-09-25 Thread Paul Burton
Hi Yasha, On Tue, Sep 25, 2018 at 10:30:52PM +0300, Yasha Cherikovsky wrote: > On Tue, 2018-09-25 at 17:45 +, Paul Burton wrote: > > How about we: > > > > - Add a Kconfig option CONFIG_CPU_SUPPORTS_LOAD_STORE_LR, and > > select > > it for all existing pre-r6 targets (probably from

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread David Hildenbrand
On 25/09/2018 21:54, Tony Krowiak wrote: > On 09/24/2018 03:55 PM, David Hildenbrand wrote: >> On 24/09/2018 21:46, Tony Krowiak wrote: >>> On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: > On 09/24/2018 04:40 AM, David Hildenbrand wrote: >>

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread David Hildenbrand
On 25/09/2018 21:54, Tony Krowiak wrote: > On 09/24/2018 03:55 PM, David Hildenbrand wrote: >> On 24/09/2018 21:46, Tony Krowiak wrote: >>> On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: > On 09/24/2018 04:40 AM, David Hildenbrand wrote: >>

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread Tony Krowiak
On 09/24/2018 03:55 PM, David Hildenbrand wrote: On 24/09/2018 21:46, Tony Krowiak wrote: On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on

Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-09-25 Thread Doug Anderson
Hi, On Tue, Sep 25, 2018 at 12:36 PM wrote: > >> + unsigned int cur_speed_hz; > > > > unsigned long for Hz? The clk framework uses that type. > > cur_speed_hz stores the speed value requested as part of transfer (not > the resultant or rounded off frequency got from clk framework. It is

[PATCH] phy: lantiq: Fix compile warning

2018-09-25 Thread Hauke Mehrtens
This local variable is unused, remove it. Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module") Signed-off-by: Hauke Mehrtens --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-09-25 Thread Doug Anderson
Hi, On Tue, Sep 25, 2018 at 12:36 PM wrote: > >> + unsigned int cur_speed_hz; > > > > unsigned long for Hz? The clk framework uses that type. > > cur_speed_hz stores the speed value requested as part of transfer (not > the resultant or rounded off frequency got from clk framework. It is

[PATCH] phy: lantiq: Fix compile warning

2018-09-25 Thread Hauke Mehrtens
This local variable is unused, remove it. Fixes: dea54fbad332 ("phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module") Signed-off-by: Hauke Mehrtens --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v10 11/26] s390: vfio-ap: implement mediated device open callback

2018-09-25 Thread Tony Krowiak
On 09/24/2018 03:55 PM, David Hildenbrand wrote: On 24/09/2018 21:46, Tony Krowiak wrote: On 09/24/2018 02:40 PM, David Hildenbrand wrote: On 24/09/2018 18:07, Tony Krowiak wrote: On 09/24/2018 04:40 AM, David Hildenbrand wrote: /** - * Verify that the AP instructions are available on

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread David Rientjes
On Mon, 24 Sep 2018, Vlastimil Babka wrote: > On 9/24/18 10:02 PM, Michal Hocko wrote: > > On Mon 24-09-18 21:56:03, Michal Hocko wrote: > >> On Mon 24-09-18 12:30:07, David Rientjes wrote: > >>> Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") > >>> introduced a regression

Re: [patch v2] mm, thp: always specify ineligible vmas as nh in smaps

2018-09-25 Thread David Rientjes
On Mon, 24 Sep 2018, Vlastimil Babka wrote: > On 9/24/18 10:02 PM, Michal Hocko wrote: > > On Mon 24-09-18 21:56:03, Michal Hocko wrote: > >> On Mon 24-09-18 12:30:07, David Rientjes wrote: > >>> Commit 1860033237d4 ("mm: make PR_SET_THP_DISABLE immediately active") > >>> introduced a regression

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-25 Thread Pierce Griffiths
Paul, The #ifdef cannot be replaced, as this would break the build for CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two global variables, a struct, and a function that are declared/defined in a large "#ifdef CONFIG_HOTPLUG_CPU" block which ends directly above

Re: [PATCH] torture-test modules: Remove unnecessary "ret" variables

2018-09-25 Thread Pierce Griffiths
Paul, The #ifdef cannot be replaced, as this would break the build for CONFIG_HOTPLUG_CPU=n builds. There are assignments and references to two global variables, a struct, and a function that are declared/defined in a large "#ifdef CONFIG_HOTPLUG_CPU" block which ends directly above

[PATCH] arm64: percpu: Initialize ret in the default case

2018-09-25 Thread Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized. ./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ ./arch/arm64/include/asm/percpu.h:200:9:

[PATCH] arm64: percpu: Initialize ret in the default case

2018-09-25 Thread Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized. ./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ ./arch/arm64/include/asm/percpu.h:200:9:

Re: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings

2018-09-25 Thread Rob Herring
On Tue, Sep 25, 2018 at 5:25 AM Rajendra Nayak wrote: > > Hi Rob, > > []... > > + rpmhpd_opp_table: opp-table { > > + compatible = "operating-points-v2-qcom-level"; > > + > > + rpmhpd_opp_ret: opp1 { > > + qcom,level = ; > > +

Re: [PATCH v4 2/6] dt-bindings: power: Add qcom rpm power domain driver bindings

2018-09-25 Thread Rob Herring
On Tue, Sep 25, 2018 at 5:25 AM Rajendra Nayak wrote: > > Hi Rob, > > []... > > + rpmhpd_opp_table: opp-table { > > + compatible = "operating-points-v2-qcom-level"; > > + > > + rpmhpd_opp_ret: opp1 { > > + qcom,level = ; > > +

Re: [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver

2018-09-25 Thread Rob Herring
On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek wrote: > > Hi! > > > > Add the device tree bindings for the lm3697 > > > LED driver for backlighting and display. > > > > > > Signed-off-by: Dan Murphy > > > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++ > > > 1 file

Re: [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver

2018-09-25 Thread Rob Herring
On Mon, Sep 24, 2018 at 1:02 PM Pavel Machek wrote: > > Hi! > > > > Add the device tree bindings for the lm3697 > > > LED driver for backlighting and display. > > > > > > Signed-off-by: Dan Murphy > > > > .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++ > > > 1 file

Re: [PATCH v1 1/5] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30

2018-09-25 Thread Rob Herring
On Tue, Sep 25, 2018 at 12:29 PM Dmitry Osipenko wrote: > > On 9/25/18 7:58 PM, Rob Herring wrote: > > On Thu, Aug 30, 2018 at 10:43:52PM +0300, Dmitry Osipenko wrote: > >> Add device-tree binding that describes CPU frequency-scaling hardware > >> found on NVIDIA Tegra20/30 SoC's. > >> > >>

Re: [PATCH v1 1/5] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30

2018-09-25 Thread Rob Herring
On Tue, Sep 25, 2018 at 12:29 PM Dmitry Osipenko wrote: > > On 9/25/18 7:58 PM, Rob Herring wrote: > > On Thu, Aug 30, 2018 at 10:43:52PM +0300, Dmitry Osipenko wrote: > >> Add device-tree binding that describes CPU frequency-scaling hardware > >> found on NVIDIA Tegra20/30 SoC's. > >> > >>

Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-09-25 Thread dkota
[...] +#define TIMESTAMP_BEFORE BIT(1) +#define FRAGMENTATION BIT(2) +#define TIMESTAMP_AFTERBIT(3) +#define POST_CMD_DELAY BIT(4) + +static irqreturn_t geni_spi_isr(int irq, void *data); Does this need to be forward declared? Not required, will remove

Re: [PATCH V4 3/4] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-09-25 Thread dkota
[...] +#define TIMESTAMP_BEFORE BIT(1) +#define FRAGMENTATION BIT(2) +#define TIMESTAMP_AFTERBIT(3) +#define POST_CMD_DELAY BIT(4) + +static irqreturn_t geni_spi_isr(int irq, void *data); Does this need to be forward declared? Not required, will remove

[PATCH 3/5] firmware: dell_rbu: Move dell_rbu to drivers/platform/x86

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Signed-off-by: Stuart Hayes --- drivers/firmware/Kconfig | 12 drivers/firmware/Makefile | 1 - drivers/platform/x86/Kconfig | 12 drivers/platform/x86/Makefile | 1 +

[PATCH 2/5] firmware: dcdbas: Add support for WSMT ACPI table

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes If the WSMT ACPI table is present and indicates that a fixed communication buffer should be used, use the firmware-specified buffer instead of allocating a buffer in memory for communications between the dcdbas driver and firmare. Signed-off-by: Stuart Hayes --- This patch

[PATCH 0/5] Update and move Dell drivers dell_rbu and dcdbas

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes The dell_rbu and dcdbas drivers need some changes, and should be moved to drivers/platform/x86. Additionally, dell_rbu needs a maintainer, and the listed maintainer for dcdbas is inactive and needs to be changed. Stuart Hayes (5): firmware: dell_rbu: Make payload memory

[PATCH 5/5] MAINTAINERS: Update maintainer for dcdbas and dell_rbu

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Assign maintainer for dell_rbu driver, and reassign maintainer of dcdbas from inactive maintainer (current maintainer is aware of this change-- see https://www.spinics.net/lists/platform-driver-x86/msg16336.html). Signed-off-by: Stuart Hayes --- MAINTAINERS | 11 +--

[PATCH 1/5] firmware: dell_rbu: Make payload memory uncachable

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes The dell_rbu driver takes firmware update payloads and puts them in memory so the system BIOS can find them after a reboot. This sometimes fails (though rarely), because the memory containing the payload is in the CPU cache but never gets written back to main memory before

[PATCH 3/5] firmware: dell_rbu: Move dell_rbu to drivers/platform/x86

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Signed-off-by: Stuart Hayes --- drivers/firmware/Kconfig | 12 drivers/firmware/Makefile | 1 - drivers/platform/x86/Kconfig | 12 drivers/platform/x86/Makefile | 1 +

[PATCH 2/5] firmware: dcdbas: Add support for WSMT ACPI table

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes If the WSMT ACPI table is present and indicates that a fixed communication buffer should be used, use the firmware-specified buffer instead of allocating a buffer in memory for communications between the dcdbas driver and firmare. Signed-off-by: Stuart Hayes --- This patch

[PATCH 0/5] Update and move Dell drivers dell_rbu and dcdbas

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes The dell_rbu and dcdbas drivers need some changes, and should be moved to drivers/platform/x86. Additionally, dell_rbu needs a maintainer, and the listed maintainer for dcdbas is inactive and needs to be changed. Stuart Hayes (5): firmware: dell_rbu: Make payload memory

[PATCH 5/5] MAINTAINERS: Update maintainer for dcdbas and dell_rbu

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Assign maintainer for dell_rbu driver, and reassign maintainer of dcdbas from inactive maintainer (current maintainer is aware of this change-- see https://www.spinics.net/lists/platform-driver-x86/msg16336.html). Signed-off-by: Stuart Hayes --- MAINTAINERS | 11 +--

[PATCH 1/5] firmware: dell_rbu: Make payload memory uncachable

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes The dell_rbu driver takes firmware update payloads and puts them in memory so the system BIOS can find them after a reboot. This sometimes fails (though rarely), because the memory containing the payload is in the CPU cache but never gets written back to main memory before

[PATCH 4/5] firmware: dcdbas: Move dcdbas to drivers/platform/x86

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Signed-off-by: Stuart Hayes --- drivers/firmware/Kconfig| 16 drivers/firmware/Makefile | 1 - drivers/platform/x86/Kconfig| 16 drivers/platform/x86/Makefile | 1 +

[PATCH 4/5] firmware: dcdbas: Move dcdbas to drivers/platform/x86

2018-09-25 Thread Stuart Hayes
From: Stuart Hayes Signed-off-by: Stuart Hayes --- drivers/firmware/Kconfig| 16 drivers/firmware/Makefile | 1 - drivers/platform/x86/Kconfig| 16 drivers/platform/x86/Makefile | 1 +

Re: [PATCH 1/1] MIPS: Add new Kconfig variable to avoid unaligned access instructions

2018-09-25 Thread Yasha Cherikovsky
Hi Paul, On Tue, 2018-09-25 at 17:45 +, Paul Burton wrote: > Hi Yasha, > > On Thu, Sep 20, 2018 at 08:03:06PM +0300, Yasha Cherikovsky wrote: > > MIPSR6 doesn't support unaligned access instructions (lwl, lwr, > > swl, swr). > > The MIPS tree has some special cases to avoid these

Re: [PATCH 1/1] MIPS: Add new Kconfig variable to avoid unaligned access instructions

2018-09-25 Thread Yasha Cherikovsky
Hi Paul, On Tue, 2018-09-25 at 17:45 +, Paul Burton wrote: > Hi Yasha, > > On Thu, Sep 20, 2018 at 08:03:06PM +0300, Yasha Cherikovsky wrote: > > MIPSR6 doesn't support unaligned access instructions (lwl, lwr, > > swl, swr). > > The MIPS tree has some special cases to avoid these

[PATCH] mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmap

2018-09-25 Thread Janusz Krzysztofik
Commit b9762bebc633 ("gpiolib: Pass bitmaps, not integer arrays, to get/set array") changed the way GPIO values are passed to gpiod_get/set_array_value() and friends. The updated code of mmc_pwrseq_simple_set_gpios_value() incorrectly uses the 'value' argument as a bitmap of GPIO values and

[PATCH] mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmap

2018-09-25 Thread Janusz Krzysztofik
Commit b9762bebc633 ("gpiolib: Pass bitmaps, not integer arrays, to get/set array") changed the way GPIO values are passed to gpiod_get/set_array_value() and friends. The updated code of mmc_pwrseq_simple_set_gpios_value() incorrectly uses the 'value' argument as a bitmap of GPIO values and

Re: [PATCH -V5 RESEND 03/21] swap: Support PMD swap mapping in swap_duplicate()

2018-09-25 Thread Daniel Jordan
On Tue, Sep 25, 2018 at 03:13:30PM +0800, Huang Ying wrote: > @@ -3487,35 +3521,66 @@ static int __swap_duplicate_locked(struct > swap_info_struct *p, > } > > /* > - * Verify that a swap entry is valid and increment its swap map count. > + * Verify that the swap entries from *entry is valid

Re: [PATCH -V5 RESEND 03/21] swap: Support PMD swap mapping in swap_duplicate()

2018-09-25 Thread Daniel Jordan
On Tue, Sep 25, 2018 at 03:13:30PM +0800, Huang Ying wrote: > @@ -3487,35 +3521,66 @@ static int __swap_duplicate_locked(struct > swap_info_struct *p, > } > > /* > - * Verify that a swap entry is valid and increment its swap map count. > + * Verify that the swap entries from *entry is valid

Re: [PATCH] clocksource/drivers/fttmr010: fix set_next_event handler

2018-09-25 Thread Linus Walleij
On Tue, Sep 25, 2018 at 7:13 PM Sai Dasari wrote: > On 9/24/18, 4:21 PM, "openbmc on behalf of Joel Stanley" > > wrote: > > I will then add it to the set of tests I run when testing aspeed > kernels. > > Thanks Joel! Curious to know what would be the best place to keep these kind >

Re: [PATCH] clocksource/drivers/fttmr010: fix set_next_event handler

2018-09-25 Thread Linus Walleij
On Tue, Sep 25, 2018 at 7:13 PM Sai Dasari wrote: > On 9/24/18, 4:21 PM, "openbmc on behalf of Joel Stanley" > > wrote: > > I will then add it to the set of tests I run when testing aspeed > kernels. > > Thanks Joel! Curious to know what would be the best place to keep these kind >

Re: [PATCH] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Nathan Chancellor
On Tue, Sep 25, 2018 at 09:07:11PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote: > > Clang generates a warning when it sees a logical not followed by a > > conditional operator like ==, >, or < because it thinks that the logical > > not

Re: [PATCH] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Nathan Chancellor
On Tue, Sep 25, 2018 at 09:07:11PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote: > > Clang generates a warning when it sees a logical not followed by a > > conditional operator like ==, >, or < because it thinks that the logical > > not

[PATCH] gpio: omap: switch to use irq_chip pm runtime

2018-09-25 Thread Grygorii Strashko
The PM runtime management can be delegated from OMAP GPIO driver to the IRQ chip core, since commit be45beb2df69 ("genirq: Add runtime power management support for IRQ chips") introduces runtime power management support for IRQ chips. Hence, drop custom PM runtime support for OMAP GPIO IRQs and

[PATCH] gpio: omap: switch to use irq_chip pm runtime

2018-09-25 Thread Grygorii Strashko
The PM runtime management can be delegated from OMAP GPIO driver to the IRQ chip core, since commit be45beb2df69 ("genirq: Add runtime power management support for IRQ chips") introduces runtime power management support for IRQ chips. Hence, drop custom PM runtime support for OMAP GPIO IRQs and

[PATCH v2] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Nathan Chancellor
Clang generates a warning when it sees a logical not followed by a conditional operator like ==, >, or < because it thinks that the logical not should be applied to the whole statement: drivers/staging/rtl8188eu/core/rtw_ieee80211.c:293:8: warning: logical not is only applied to the left hand

[PATCH v2] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Nathan Chancellor
Clang generates a warning when it sees a logical not followed by a conditional operator like ==, >, or < because it thinks that the logical not should be applied to the whole statement: drivers/staging/rtl8188eu/core/rtw_ieee80211.c:293:8: warning: logical not is only applied to the left hand

Re: [PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit for Actions Semi S500 SoC

2018-09-25 Thread Rob Herring
On Tue, Sep 04, 2018 at 12:36:36PM -0300, Edgar Bernardi Righi wrote: > Add Clock Management Unit for Actions Semi S500 SoC. Dt-Bindings > constants added. > Tested on a Lemaker Guitar board. > > Signed-off-by: Edgar Bernardi Righi > > diff --git a/include/dt-bindings/clock/actions,s500-cmu.h >

Re: [PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit for Actions Semi S500 SoC

2018-09-25 Thread Rob Herring
On Tue, Sep 04, 2018 at 12:36:36PM -0300, Edgar Bernardi Righi wrote: > Add Clock Management Unit for Actions Semi S500 SoC. Dt-Bindings > constants added. > Tested on a Lemaker Guitar board. > > Signed-off-by: Edgar Bernardi Righi > > diff --git a/include/dt-bindings/clock/actions,s500-cmu.h >

[PATCH v3.1 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Use the new API to get the BD address instead of reading it directly from the device tree. Also remove an unncessary pair of braces in the same area of code. Signed-off-by: Matthias Kaehlcke Reviewed-by: Andy Shevchenko --- Changes in v3: - added 'Reviewed-by: Andy Shevchenko ' tag Changes in

[PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property. The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to

[PATCH v3.1 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Use the new API to get the BD address instead of reading it directly from the device tree. Also remove an unncessary pair of braces in the same area of code. Signed-off-by: Matthias Kaehlcke Reviewed-by: Andy Shevchenko --- Changes in v3: - added 'Reviewed-by: Andy Shevchenko ' tag Changes in

[PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property. The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to

[PATCH v3.1 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR)

2018-09-25 Thread Matthias Kaehlcke
(previous v3 post was messed up, resending as v3.1 with the correct stack) On some systems the Bluetooth Device Address (BD_ADDR) isn't stored on the Bluetooth chip itself. One way to configure the BD address is through the device tree. The btqcomsmd driver is an example, it can read the BD

[PATCH v3.1 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR)

2018-09-25 Thread Matthias Kaehlcke
(previous v3 post was messed up, resending as v3.1 with the correct stack) On some systems the Bluetooth Device Address (BD_ADDR) isn't stored on the Bluetooth chip itself. One way to configure the BD address is through the device tree. The btqcomsmd driver is an example, it can read the BD

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Borislav Petkov
On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote: > bumping for review. > > On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers > wrote: > > > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > > symbols. Why do we have to redefine these symbols? I don't see

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Borislav Petkov
On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote: > bumping for review. > > On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers > wrote: > > > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > > symbols. Why do we have to redefine these symbols? I don't see

Re: [PATCH] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Greg Kroah-Hartman
On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote: > Clang generates a warning when it sees a logical not followed by a > conditional operator like ==, >, or < because it thinks that the logical > not should be applied to the whole statement: > >

Re: [PATCH v2 37/37] ARM: tegra: colibri_t20: add eval board device tree

2018-09-25 Thread Rob Herring
On Sun, Sep 02, 2018 at 12:09:06PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add an evaluation board device tree more in-line with all our other > device trees. > > Signed-off-by: Marcel Ziswiler > > --- > + panel: panel { > + /* > + *

Re: [PATCH] staging: rtl8188eu: Simplify memcmp logical checks

2018-09-25 Thread Greg Kroah-Hartman
On Thu, Sep 20, 2018 at 05:22:21PM -0700, Nathan Chancellor wrote: > Clang generates a warning when it sees a logical not followed by a > conditional operator like ==, >, or < because it thinks that the logical > not should be applied to the whole statement: > >

Re: [PATCH v2 37/37] ARM: tegra: colibri_t20: add eval board device tree

2018-09-25 Thread Rob Herring
On Sun, Sep 02, 2018 at 12:09:06PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Add an evaluation board device tree more in-line with all our other > device trees. > > Signed-off-by: Marcel Ziswiler > > --- > + panel: panel { > + /* > + *

Re: [PATCH v2 29/37] ARM: tegra: colibri_t20: iris: simplify model and compatible properties

2018-09-25 Thread Rob Herring
On Sun, Sep 02, 2018 at 12:08:58PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Simplify model and compatible by dropping the 256/512 MB from the model, > -512 from the compatible and rename that property from toradex,iris to > toradex,colibri_t20-iris to be more in-line with all

Re: [PATCH v2 29/37] ARM: tegra: colibri_t20: iris: simplify model and compatible properties

2018-09-25 Thread Rob Herring
On Sun, Sep 02, 2018 at 12:08:58PM +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Simplify model and compatible by dropping the 256/512 MB from the model, > -512 from the compatible and rename that property from toradex,iris to > toradex,colibri_t20-iris to be more in-line with all

Re: [PATCH v3 1/2] Compiler Attributes: naked can be shared

2018-09-25 Thread Matthias Kaehlcke
Sorry, this series got messed up. Apparently the branch was still rebasing when I ran 'git send-email' :/ On Tue, Sep 25, 2018 at 11:53:38AM -0700, Matthias Kaehlcke wrote: > From: Miguel Ojeda > > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > which is the only current

Re: [PATCH v3 1/2] Compiler Attributes: naked can be shared

2018-09-25 Thread Matthias Kaehlcke
Sorry, this series got messed up. Apparently the branch was still rebasing when I ran 'git send-email' :/ On Tue, Sep 25, 2018 at 11:53:38AM -0700, Matthias Kaehlcke wrote: > From: Miguel Ojeda > > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > which is the only current

Re: [PATCH v2 28/37] ARM: tegra: colibri_t20: simplify model and compatible properties

2018-09-25 Thread Rob Herring
On Sun, 2 Sep 2018 12:08:57 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Simplify model and compatible by dropping the 256/512 MB from the model > and -512 from the compatible properties to be more in-line with all our > other device trees. > > Signed-off-by: Marcel Ziswiler > >

Re: [PATCH v2 28/37] ARM: tegra: colibri_t20: simplify model and compatible properties

2018-09-25 Thread Rob Herring
On Sun, 2 Sep 2018 12:08:57 +0200, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Simplify model and compatible by dropping the 256/512 MB from the model > and -512 from the compatible properties to be more in-line with all our > other device trees. > > Signed-off-by: Marcel Ziswiler > >

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-25 Thread Suman Anna
Hi Arnaud, > On 09/25/2018 02:25 AM, Suman Anna wrote: >> Hi Srinivas, >> >> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >>> Some of the rpmsg devices need to switch on power domains to communicate >>> with remote processor. For example on Qualcomm DB820c platform LPASS >>> power domain

Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c

2018-09-25 Thread Joe Perches
On Tue, 2018-09-25 at 20:49 +0200, Greg Kroah-Hartman wrote: > On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote: > > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote: > > > This patch fixes a few single statement macros in sd.c. > > > It converts two macros to inline functions. It

Re: [PATCH] rpmsg: core: add support to power domains for devices

2018-09-25 Thread Suman Anna
Hi Arnaud, > On 09/25/2018 02:25 AM, Suman Anna wrote: >> Hi Srinivas, >> >> On 06/15/2018 04:59 AM, Srinivas Kandagatla wrote: >>> Some of the rpmsg devices need to switch on power domains to communicate >>> with remote processor. For example on Qualcomm DB820c platform LPASS >>> power domain

Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c

2018-09-25 Thread Joe Perches
On Tue, 2018-09-25 at 20:49 +0200, Greg Kroah-Hartman wrote: > On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote: > > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote: > > > This patch fixes a few single statement macros in sd.c. > > > It converts two macros to inline functions. It

Re: [PATCH RESEND] mm: don't raise MEMCG_OOM event due to failed high-order allocation

2018-09-25 Thread Michal Hocko
On Mon 17-09-18 23:10:59, Roman Gushchin wrote: > The memcg OOM killer is never invoked due to a failed high-order > allocation, however the MEMCG_OOM event can be raised. > > As shown below, it can happen under conditions, which are very > far from a real OOM: e.g. there is plenty of clean

Re: [PATCH RESEND] mm: don't raise MEMCG_OOM event due to failed high-order allocation

2018-09-25 Thread Michal Hocko
On Mon 17-09-18 23:10:59, Roman Gushchin wrote: > The memcg OOM killer is never invoked due to a failed high-order > allocation, however the MEMCG_OOM event can be raised. > > As shown below, it can happen under conditions, which are very > far from a real OOM: e.g. there is plenty of clean

Re: different capability from different namespace required for prctl_set_mm_exe_file

2018-09-25 Thread Cyrill Gorcunov
On Tue, Sep 25, 2018 at 08:40:54PM +0200, Greg KH wrote: > > > > It is done this way on purpose. The prctl_set_mm_map is a complex call > > which carries a bunch of parameters and allowed if you're inside user-ns > > admin, > > in turn prctl_set_mm allows to modify settings one by one. So no, it

Re: different capability from different namespace required for prctl_set_mm_exe_file

2018-09-25 Thread Cyrill Gorcunov
On Tue, Sep 25, 2018 at 08:40:54PM +0200, Greg KH wrote: > > > > It is done this way on purpose. The prctl_set_mm_map is a complex call > > which carries a bunch of parameters and allowed if you're inside user-ns > > admin, > > in turn prctl_set_mm allows to modify settings one by one. So no, it

[PATCH v3 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR)

2018-09-25 Thread Matthias Kaehlcke
On some systems the Bluetooth Device Address (BD_ADDR) isn't stored on the Bluetooth chip itself. One way to configure the BD address is through the device tree. The btqcomsmd driver is an example, it can read the BD address from the DT property 'local-bd-address'. It is also planned to extend the

[PATCH v3 0/2] Add API to retrieve the Bluetooth Device Address (BD_ADDR)

2018-09-25 Thread Matthias Kaehlcke
On some systems the Bluetooth Device Address (BD_ADDR) isn't stored on the Bluetooth chip itself. One way to configure the BD address is through the device tree. The btqcomsmd driver is an example, it can read the BD address from the DT property 'local-bd-address'. It is also planned to extend the

[PATCH v3 1/2] Compiler Attributes: naked can be shared

2018-09-25 Thread Matthias Kaehlcke
From: Miguel Ojeda The naked attribute is supported by at least gcc >= 4.6 (for ARM, which is the only current user), gcc >= 8 (for x86), clang >= 3.1 and icc >= 13. See https://godbolt.org/z/350Dyc Therefore, move it out of compiler-gcc.h so that the definition is shared by all compilers.

[PATCH v3 2/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property. The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to

[PATCH v3 1/2] Compiler Attributes: naked can be shared

2018-09-25 Thread Matthias Kaehlcke
From: Miguel Ojeda The naked attribute is supported by at least gcc >= 4.6 (for ARM, which is the only current user), gcc >= 8 (for x86), clang >= 3.1 and icc >= 13. See https://godbolt.org/z/350Dyc Therefore, move it out of compiler-gcc.h so that the definition is shared by all compilers.

[PATCH v3 2/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

2018-09-25 Thread Matthias Kaehlcke
Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property. The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to

Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c

2018-09-25 Thread Greg Kroah-Hartman
On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote: > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote: > > This patch fixes a few single statement macros in sd.c. > > It converts two macros to inline functions. It removes > > five other macros and replaces their usages with calls

Re: [PATCH v2] staging: mt7621-mmc: Fix single statement macros in sd.c

2018-09-25 Thread Greg Kroah-Hartman
On Sun, Sep 23, 2018 at 06:31:32AM -0700, Joe Perches wrote: > On Sun, 2018-09-23 at 15:08 +0530, Nishad Kamdar wrote: > > This patch fixes a few single statement macros in sd.c. > > It converts two macros to inline functions. It removes > > five other macros and replaces their usages with calls

Re: [PATCH 00/10] GICv3 support for kexec/kdump on EFI systems

2018-09-25 Thread Jeremy Linton
Hi, On 09/21/2018 02:59 PM, Marc Zyngier wrote: The GICv3 architecture has the remarkable feature that once LPI tables have been assigned to redistributors and that LPI delivery is enabled, there is no guarantee that LPIs can be turned off (and most implementations do not allow it), nor can it

Re: [0/5] rcu doc updates

2018-09-25 Thread Joel Fernandes
On Tue, Sep 25, 2018 at 11:26 AM Joel Fernandes (Google) wrote: > > Hi Paul, > These patches are documentation updates for the rcu_dynticks rolling into > rcu_data and also the updates to the fact that there's a single rcu_state now. > Its based on your rcu/dev branch. > > Next I'm thinking of

Re: [PATCH 00/10] GICv3 support for kexec/kdump on EFI systems

2018-09-25 Thread Jeremy Linton
Hi, On 09/21/2018 02:59 PM, Marc Zyngier wrote: The GICv3 architecture has the remarkable feature that once LPI tables have been assigned to redistributors and that LPI delivery is enabled, there is no guarantee that LPIs can be turned off (and most implementations do not allow it), nor can it

Re: [0/5] rcu doc updates

2018-09-25 Thread Joel Fernandes
On Tue, Sep 25, 2018 at 11:26 AM Joel Fernandes (Google) wrote: > > Hi Paul, > These patches are documentation updates for the rcu_dynticks rolling into > rcu_data and also the updates to the fact that there's a single rcu_state now. > Its based on your rcu/dev branch. > > Next I'm thinking of

Re: [PATCH] staging: greybus: control.c: fixed some coding style issues

2018-09-25 Thread Greg KH
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. > Signing up for the kernel clean up crew while I learn C > > Signed-off-by: Aaron Williams > --- > drivers/staging/greybus/control.c | 39

Re: [PATCH] staging: greybus: control.c: fixed some coding style issues

2018-09-25 Thread Greg KH
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote: > fixed some "Alignment should match open parenthesis" checks. > Signing up for the kernel clean up crew while I learn C > > Signed-off-by: Aaron Williams > --- > drivers/staging/greybus/control.c | 39

[PATCH v3] PCI: Equalize hotplug memory and io for non/occupied slots

2018-09-25 Thread Jon Derrick
Currently, a hotplug bridge will be given hpmemsize additional memory and hpiosize additional io if available, in order to satisfy any future hotplug allocation requirements. These calculations don't consider the current memory/io size of the hotplug bridge/slot, so hotplug bridges/slots which

[PATCH v3] PCI: Equalize hotplug memory and io for non/occupied slots

2018-09-25 Thread Jon Derrick
Currently, a hotplug bridge will be given hpmemsize additional memory and hpiosize additional io if available, in order to satisfy any future hotplug allocation requirements. These calculations don't consider the current memory/io size of the hotplug bridge/slot, so hotplug bridges/slots which

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Nick Desaulniers
bumping for review. On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers wrote: > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > symbols. This will prevent warnings in source files in this directory > when Clang supports asm goto. > > Signed-off-by: Nick Desaulniers > --- >

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Nick Desaulniers
bumping for review. On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers wrote: > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > symbols. This will prevent warnings in source files in this directory > when Clang supports asm goto. > > Signed-off-by: Nick Desaulniers > --- >

Re: different capability from different namespace required for prctl_set_mm_exe_file

2018-09-25 Thread Greg KH
On Tue, Sep 25, 2018 at 09:34:27PM +0300, Cyrill Gorcunov wrote: > On Tue, Sep 25, 2018 at 07:37:45PM +0200, Greg KH wrote: > > On Tue, Sep 25, 2018 at 01:26:55PM -0400, Tong Zhang wrote: > > > Kernel Version: 4.18.5 > > > > > > Problem Description: > > > > > > We discovered inconsistent check

Re: different capability from different namespace required for prctl_set_mm_exe_file

2018-09-25 Thread Greg KH
On Tue, Sep 25, 2018 at 09:34:27PM +0300, Cyrill Gorcunov wrote: > On Tue, Sep 25, 2018 at 07:37:45PM +0200, Greg KH wrote: > > On Tue, Sep 25, 2018 at 01:26:55PM -0400, Tong Zhang wrote: > > > Kernel Version: 4.18.5 > > > > > > Problem Description: > > > > > > We discovered inconsistent check

<    1   2   3   4   5   6   7   8   9   10   >