Hello
Please i still await your response regarding my previous email.
Hello
Please i still await your response regarding my previous email.
Hello
Please i still await your response regarding my previous email.
Hello
Please i still await your response regarding my previous email.
Hi Al,
After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
/home/sfr/next/next/fs/f2fs/super.c: In function 'f2fs_remount':
/home/sfr/next/next/fs/f2fs/super.c:1589:16: error: 'MS_RDONLY' undeclared
(first use in this function); did you mean 'IS_RDONLY'?
Hi Al,
After merging the vfs tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
/home/sfr/next/next/fs/f2fs/super.c: In function 'f2fs_remount':
/home/sfr/next/next/fs/f2fs/super.c:1589:16: error: 'MS_RDONLY' undeclared
(first use in this function); did you mean 'IS_RDONLY'?
Hello all,
I am having trouble tracing child threads when using address filtering
with intel_pt ..
Assume this test code:
thread_start(){
...
test();
...
}
test(){
printf("test");
}
main(){
...
pthread_create(.., thread_start,);
}
Tracing the above program with the following
Hello all,
I am having trouble tracing child threads when using address filtering
with intel_pt ..
Assume this test code:
thread_start(){
...
test();
...
}
test(){
printf("test");
}
main(){
...
pthread_create(.., thread_start,);
}
Tracing the above program with the following
Enable the UniPhier SD controller driver.
Signed-off-by: Masahiro Yamada
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig
b/arch/arm/configs/multi_v7_defconfig
index fc33444..0d56568 100644
---
Enable the UniPhier SD controller driver.
Signed-off-by: Masahiro Yamada
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig
b/arch/arm/configs/multi_v7_defconfig
index fc33444..0d56568 100644
---
Enable the UniPhier SD controller driver.
Signed-off-by: Masahiro Yamada
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index db8d364..a15016e 100644
--- a/arch/arm64/configs/defconfig
+++
Enable the UniPhier SD controller driver.
Signed-off-by: Masahiro Yamada
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index db8d364..a15016e 100644
--- a/arch/arm64/configs/defconfig
+++
Hello all,
I am having trouble tracing child threads when using address filtering
with intel_pt ..
Assume this test code:
thread_start(){
...
test();
...
}
test(){
printf("test");
}
main(){
...
pthread_create(.., thread_start,);
}
Tracing the above program with the following
Hello all,
I am having trouble tracing child threads when using address filtering
with intel_pt ..
Assume this test code:
thread_start(){
...
test();
...
}
test(){
printf("test");
}
main(){
...
pthread_create(.., thread_start,);
}
Tracing the above program with the following
On Tue, Oct 2, 2018 at 1:42 AM Petr Mladek wrote:
>
> Well, I still wonder why it helped and why you do not see it with 4.4.
> I have a feeling that the console owner switch helped only by chance.
> In fact, you might be affected by a race in
> printk_safe_flush_on_panic() that was fixed by the
On Tue, Oct 2, 2018 at 1:42 AM Petr Mladek wrote:
>
> Well, I still wonder why it helped and why you do not see it with 4.4.
> I have a feeling that the console owner switch helped only by chance.
> In fact, you might be affected by a race in
> printk_safe_flush_on_panic() that was fixed by the
Hi Al,
Today's linux-next merge of the vfs tree got a conflict in:
fs/f2fs/super.c
between commit:
f80f781514ef ("f2fs: checkpoint disabling")
from the f2fs tree and commit:
307c6e5241b4 ("vfs: Require specification of size of mount data for internal
mounts")
from the vfs tree.
I
Hi Al,
Today's linux-next merge of the vfs tree got a conflict in:
fs/f2fs/super.c
between commit:
f80f781514ef ("f2fs: checkpoint disabling")
from the f2fs tree and commit:
307c6e5241b4 ("vfs: Require specification of size of mount data for internal
mounts")
from the vfs tree.
I
On Tue, Oct 02, 2018 at 03:39:31PM -0700, Sean O'Brien wrote:
> On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
> wrote:
> >
> > [adding Peter, for the libinput question]
> >
> > On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> > >
> > > USB device
> > > Vendor 05ac (Apple)
> > >
On Tue, Oct 02, 2018 at 03:39:31PM -0700, Sean O'Brien wrote:
> On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
> wrote:
> >
> > [adding Peter, for the libinput question]
> >
> > On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> > >
> > > USB device
> > > Vendor 05ac (Apple)
> > >
The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
Signed-off-by: Mihir Mehta
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
The file namei.c seems to have been renamed to namei_msdos.c, so I
decided to update the comment with the correct name, and expand it a bit
to tell the reader what to look for.
Signed-off-by: Mihir Mehta
---
fs/fat/dir.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Hi Arnd, Olof,
Please pull UniPhier DT updates for the v4.20 MW.
In this cycle, I queued up all arm/arm64 changes
into a single branch to avoid build errors.
Thanks!
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3:
Linux 4.19-rc1 (2018-08-26 14:11:59 -0700)
Hi Arnd, Olof,
Please pull UniPhier DT updates for the v4.20 MW.
In this cycle, I queued up all arm/arm64 changes
into a single branch to avoid build errors.
Thanks!
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3:
Linux 4.19-rc1 (2018-08-26 14:11:59 -0700)
Hi Mark,
> On Oct 2, 2018, at 4:46 AM, Mark Rutland wrote:
>
> [NOTICE: This email originated from an external sender. Please be mindful of
> safe email handling and proprietary information protection practices.]
>
Hi Mark,
> On Oct 2, 2018, at 4:46 AM, Mark Rutland wrote:
>
> [NOTICE: This email originated from an external sender. Please be mindful of
> safe email handling and proprietary information protection practices.]
>
Hi,
Sparse has suddenly started issuing as many as 11 warnings of "expression using
sizeof(void)" for each call to max3(). There are similar warnings for calls to
max(), thus I think this is the origin of the problem. My sparse version is
20180324-1.3-x86_64 installed in openSUSE Tumbleweed.
Hi,
Sparse has suddenly started issuing as many as 11 warnings of "expression using
sizeof(void)" for each call to max3(). There are similar warnings for calls to
max(), thus I think this is the origin of the problem. My sparse version is
20180324-1.3-x86_64 installed in openSUSE Tumbleweed.
Hi Reinette,
Thanks for the review. My response below.
On 10/02/2018 02:21 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/24/2018 12:19 PM, Moger, Babu wrote:
>> Re-organize the RDT init code. Separate the call sequence for each
>> feature. That way, it is easy to call quirks or features
Hi Reinette,
Thanks for the review. My response below.
On 10/02/2018 02:21 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/24/2018 12:19 PM, Moger, Babu wrote:
>> Re-organize the RDT init code. Separate the call sequence for each
>> feature. That way, it is easy to call quirks or features
On Tue, Sep 25, 2018 at 04:44:03PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:846e8dd47c26 Merge tag 'scsi-fixes' of git://git.kernel.or..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=15c874a140
>
On Tue, Sep 25, 2018 at 04:44:03PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:846e8dd47c26 Merge tag 'scsi-fixes' of git://git.kernel.or..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=15c874a140
>
Fixed all the braces issues of the xd.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/xd.c | 232 ++-
1 file changed, 92 insertions(+), 140 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index
Fixed all the braces issues of the xd.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/xd.c | 232 ++-
1 file changed, 92 insertions(+), 140 deletions(-)
diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
index
Fixed all the braces issues of the spi.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/spi.c | 153 +-
1 file changed, 59 insertions(+), 94 deletions(-)
diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
index
Fixed all the braces issues of the spi.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/spi.c | 153 +-
1 file changed, 59 insertions(+), 94 deletions(-)
diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
index
Fixed all the braces issues of the rtsx_scsi.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_scsi.c | 108 ++--
1 file changed, 36 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
Fixed all the braces issues of the rtsx_scsi.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_scsi.c | 108 ++--
1 file changed, 36 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
Fixed all the braces issues of the sd.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/sd.c | 704 +--
1 file changed, 268 insertions(+), 436 deletions(-)
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index
Fixed all the braces issues of the rtsx_chip.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_chip.c | 463
1 file changed, 199 insertions(+), 264 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
Fixed all the braces issues of the sd.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/sd.c | 704 +--
1 file changed, 268 insertions(+), 436 deletions(-)
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index
Fixed all the braces issues of the rtsx_chip.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_chip.c | 463
1 file changed, 199 insertions(+), 264 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
Fixed all the braces issues of the rtsx_card.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
Fixed all the braces issues of the rtsx_card.c file
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
From: Roman Kiryanov
This is the last patch in the series of patches to move file-scope
variables into the driver state. This change will help to introduce
another version of the pipe driver (with different state) for the
older host interface or having several instances of this device.
From: Roman Kiryanov
This is the last patch in the series of patches to move file-scope
variables into the driver state. This change will help to introduce
another version of the pipe driver (with different state) for the
older host interface or having several instances of this device.
From: Roman Kiryanov
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.
Signed-off-by: Roman
From: Roman Kiryanov
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.
Signed-off-by: Roman
From: Roman Kiryanov
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.
Signed-off-by: Roman
From: Roman Kiryanov
This is a series of patches to move mutable file-scope variables
into the driver state. This change will help to introduce another
version of the pipe driver (with different state) for the older
host interface or having several instances of this device.
Signed-off-by: Roman
On Tue, Oct 02, 2018 at 11:24:56AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Sep 29, 2018 at 03:39:03PM +0800, leo@linaro.org escreveu:
> > On Fri, Sep 28, 2018 at 10:19:44AM -0700, Andi Kleen wrote:
> > > > Seems to me, these two features are _NOT_ only benefit for intel_pt,
> > > >
On Tue, Oct 02, 2018 at 11:24:56AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Sep 29, 2018 at 03:39:03PM +0800, leo@linaro.org escreveu:
> > On Fri, Sep 28, 2018 at 10:19:44AM -0700, Andi Kleen wrote:
> > > > Seems to me, these two features are _NOT_ only benefit for intel_pt,
> > > >
Add SD controller nodes for LD4, Pro4, sLD8, Pro5, and PXs2.
This is also used as an eMMC controller for LD4, Pro4, and sLD8.
Signed-off-by: Masahiro Yamada
---
arch/arm/boot/dts/uniphier-ld4-ref.dts | 4 +++
arch/arm/boot/dts/uniphier-ld4.dtsi| 34 +
Add SD controller nodes for LD20 and PXs3.
LD20 does not support the UHS mode, while PXs3 supports it.
Signed-off-by: Masahiro Yamada
---
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi| 14 ++
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dts | 4
Hi Yamada-san,
On Mon, Oct 01, 2018 at 09:31:01PM +0900, Masahiro Yamada wrote:
> CTL_RESET_SDIO register is specific to the TMIO MFD (tmio_mmc.c).
>
> Add a new hook host->reset for performing a platform-specific reset
> sequence, and move CTL_RESET_SDIO over there.
>
> Signed-off-by: Masahiro
Add SD controller nodes for LD4, Pro4, sLD8, Pro5, and PXs2.
This is also used as an eMMC controller for LD4, Pro4, and sLD8.
Signed-off-by: Masahiro Yamada
---
arch/arm/boot/dts/uniphier-ld4-ref.dts | 4 +++
arch/arm/boot/dts/uniphier-ld4.dtsi| 34 +
Add SD controller nodes for LD20 and PXs3.
LD20 does not support the UHS mode, while PXs3 supports it.
Signed-off-by: Masahiro Yamada
---
arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi| 14 ++
arch/arm64/boot/dts/socionext/uniphier-pxs3-ref.dts | 4
Hi Yamada-san,
On Mon, Oct 01, 2018 at 09:31:01PM +0900, Masahiro Yamada wrote:
> CTL_RESET_SDIO register is specific to the TMIO MFD (tmio_mmc.c).
>
> Add a new hook host->reset for performing a platform-specific reset
> sequence, and move CTL_RESET_SDIO over there.
>
> Signed-off-by: Masahiro
On Mon, Oct 01, 2018 at 12:03:35AM +0200, Sebastian Reichel wrote:
> Hi,
>
> Udev may not detect sysfs attributes, that have been added
> after the device has been created. Code doing that is racy [0].
> The power-supply class properly registers its attributes
> when the device is created, but
On Mon, Oct 01, 2018 at 12:03:35AM +0200, Sebastian Reichel wrote:
> Hi,
>
> Udev may not detect sysfs attributes, that have been added
> after the device has been created. Code doing that is racy [0].
> The power-supply class properly registers its attributes
> when the device is created, but
On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
> It is safe to move a deference below a NULL test.
>
> Signed-off-by: zhong jiang
> Acked-by: Andrew Donnellan
> ---
> drivers/misc/cxl/guest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Wed, Sep 26, 2018 at 07:41:12PM +0800, zhong jiang wrote:
> It is safe to move a deference below a NULL test.
>
> Signed-off-by: zhong jiang
> Acked-by: Andrew Donnellan
> ---
> drivers/misc/cxl/guest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On Tue 02 Oct 14:15 PDT 2018, Arnd Bergmann wrote:
> The 'tiles' array is initialized to a constant pointers to constant
> strings, but the declaration is only half as constant:
>
> drivers/pinctrl/qcom/pinctrl-qcs404.c:1660:11: error: initialization discards
> 'const' qualifier from pointer
USB device
Vendor 05ac (Apple)
Device 0265 (Magic Trackpad 2)
Bluetooth device
Vendor 004c (Apple)
Device 0265 (Magic Trackpad 2)
Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.
Signed-off-by: Claudio Mettler
On Tue 02 Oct 14:15 PDT 2018, Arnd Bergmann wrote:
> The 'tiles' array is initialized to a constant pointers to constant
> strings, but the declaration is only half as constant:
>
> drivers/pinctrl/qcom/pinctrl-qcs404.c:1660:11: error: initialization discards
> 'const' qualifier from pointer
USB device
Vendor 05ac (Apple)
Device 0265 (Magic Trackpad 2)
Bluetooth device
Vendor 004c (Apple)
Device 0265 (Magic Trackpad 2)
Add support for Apple Magic Trackpad 2 over USB and bluetooth, putting
the device in multi-touch mode.
Signed-off-by: Claudio Mettler
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
arch/x86/kernel/cpu/amd.c:925:14: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((c->x86 == 6)) {
~~~^~~~
arch/x86/kernel/cpu/amd.c:925:14:
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
arch/x86/kernel/cpu/amd.c:925:14: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((c->x86 == 6)) {
~~~^~~~
arch/x86/kernel/cpu/amd.c:925:14:
On Wed, Oct 03, 2018 at 05:20:31AM +1000, James Morris wrote:
> On Tue, 2 Oct 2018, Dave Chinner wrote:
>
> > On Tue, Oct 02, 2018 at 06:08:16AM +1000, James Morris wrote:
> > > On Mon, 1 Oct 2018, Darrick J. Wong wrote:
> > >
> > > > If we /did/ replace CAP_SYS_ADMIN checking with a pile of LSM
On Wed, Oct 03, 2018 at 05:20:31AM +1000, James Morris wrote:
> On Tue, 2 Oct 2018, Dave Chinner wrote:
>
> > On Tue, Oct 02, 2018 at 06:08:16AM +1000, James Morris wrote:
> > > On Mon, 1 Oct 2018, Darrick J. Wong wrote:
> > >
> > > > If we /did/ replace CAP_SYS_ADMIN checking with a pile of LSM
On Tue, Oct 02, 2018 at 03:33:11PM -0700, Roman Kiryanov wrote:
> > I don't see a "global" variable here, what are you referring to.
> >
> > This one:
> >
> > > -static DECLARE_TASKLET(goldfish_interrupt_tasklet,
> > > goldfish_interrupt_task, 0);
> >
> > ?
>
> Yes.
>
> > That looks static to
On Tue, Oct 02, 2018 at 03:33:11PM -0700, Roman Kiryanov wrote:
> > I don't see a "global" variable here, what are you referring to.
> >
> > This one:
> >
> > > -static DECLARE_TASKLET(goldfish_interrupt_tasklet,
> > > goldfish_interrupt_task, 0);
> >
> > ?
>
> Yes.
>
> > That looks static to
Hi,
On Tue, Oct 2, 2018 at 2:48 PM Ryan Case wrote:
> +#define RD_FIFO_STATUS 0x002c
> +#define FIFO_EMPTY BIT(11)
> +#define WR_CNTS_MSK0x7f0
> +#define WR_CNTS_SHFT 4
> +#define RDY_64BYTE BIT(3)
> +#define RDY_32BYTE BIT(2)
> +#define RDY_16BYTE BIT(1)
> +#define
On Tue, Oct 2, 2018 at 3:35 PM Nathan Chancellor
wrote:
>
> Clang warns:
>
> drivers/cpufreq/cppc_cpufreq.c:431:36: warning: variable 'cppc_acpi_ids'
> is not needed and will not be emitted [-Wunneeded-internal-declaration]
> static const struct acpi_device_id cppc_acpi_ids[] = {
>
Hi,
On Tue, Oct 2, 2018 at 2:48 PM Ryan Case wrote:
> +#define RD_FIFO_STATUS 0x002c
> +#define FIFO_EMPTY BIT(11)
> +#define WR_CNTS_MSK0x7f0
> +#define WR_CNTS_SHFT 4
> +#define RDY_64BYTE BIT(3)
> +#define RDY_32BYTE BIT(2)
> +#define RDY_16BYTE BIT(1)
> +#define
On Tue, Oct 2, 2018 at 3:35 PM Nathan Chancellor
wrote:
>
> Clang warns:
>
> drivers/cpufreq/cppc_cpufreq.c:431:36: warning: variable 'cppc_acpi_ids'
> is not needed and will not be emitted [-Wunneeded-internal-declaration]
> static const struct acpi_device_id cppc_acpi_ids[] = {
>
On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
wrote:
>
> [adding Peter, for the libinput question]
>
> On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 0265 (Magic Trackpad 2)
> > Bluetooth device
> > Vendor
On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires
wrote:
>
> [adding Peter, for the libinput question]
>
> On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote:
> >
> > USB device
> > Vendor 05ac (Apple)
> > Device 0265 (Magic Trackpad 2)
> > Bluetooth device
> > Vendor
Clang warns:
drivers/cpufreq/cppc_cpufreq.c:431:36: warning: variable 'cppc_acpi_ids'
is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const struct acpi_device_id cppc_acpi_ids[] = {
^
1 warning generated.
Mark the definition as
Clang warns:
drivers/cpufreq/cppc_cpufreq.c:431:36: warning: variable 'cppc_acpi_ids'
is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const struct acpi_device_id cppc_acpi_ids[] = {
^
1 warning generated.
Mark the definition as
> I don't see a "global" variable here, what are you referring to.
>
> This one:
>
> > -static DECLARE_TASKLET(goldfish_interrupt_tasklet,
> > goldfish_interrupt_task, 0);
>
> ?
Yes.
> That looks static to this file to me.
> what am I missing here?
It has a global lifetime but it is visible
> I don't see a "global" variable here, what are you referring to.
>
> This one:
>
> > -static DECLARE_TASKLET(goldfish_interrupt_tasklet,
> > goldfish_interrupt_task, 0);
>
> ?
Yes.
> That looks static to this file to me.
> what am I missing here?
It has a global lifetime but it is visible
On Fri, 28 Sep 2018 14:49:47 -0500 Mihir Mehta wrote:
> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
Please send us a Signed-off-by: for this patch, as per
On Fri, 28 Sep 2018 14:49:47 -0500 Mihir Mehta wrote:
> The file namei.c seems to have been renamed to namei_msdos.c, so I
> decided to update the comment with the correct name, and expand it a bit
> to tell the reader what to look for.
Please send us a Signed-off-by: for this patch, as per
On Tue, Oct 02, 2018 at 03:18:49PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> This is a series of patches to remove mutable global variables
> to introduce another version of the pipe driver for the older
> host interface. I don't want to have two driver states where only
> one is
On Tue, Oct 02, 2018 at 03:18:49PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> This is a series of patches to remove mutable global variables
> to introduce another version of the pipe driver for the older
> host interface. I don't want to have two driver states where only
> one is
On Tue, Oct 02, 2018 at 11:43:46AM +0200, Jean Delvare wrote:
> On Mon, 26 Feb 2018 14:40:42 +0100, Bartosz Golaszewski wrote:
> > 2018-02-26 10:20 GMT+01:00 Jean Delvare :
> > > The EEPROMs which hold the SPD data on DDR4 memory modules are no
> > > longer standard AT24C02-compatible EEPROMs.
On Tue, Oct 02, 2018 at 11:43:46AM +0200, Jean Delvare wrote:
> On Mon, 26 Feb 2018 14:40:42 +0100, Bartosz Golaszewski wrote:
> > 2018-02-26 10:20 GMT+01:00 Jean Delvare :
> > > The EEPROMs which hold the SPD data on DDR4 memory modules are no
> > > longer standard AT24C02-compatible EEPROMs.
On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but
> not used
On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but
> not used
On Tue, Oct 02, 2018 at 11:46:11PM +0200, Helge Deller wrote:
> Hi Greg,
>
> On 02.10.2018 23:16, Greg Kroah-Hartman wrote:
> > On Tue, Oct 02, 2018 at 11:02:13PM +0200, Helge Deller wrote:
> >> please pull a last set of fixes for the parisc architecture for kernel
> >> 4.19 from:
> >>
> >>
On Tue, Oct 02, 2018 at 11:46:11PM +0200, Helge Deller wrote:
> Hi Greg,
>
> On 02.10.2018 23:16, Greg Kroah-Hartman wrote:
> > On Tue, Oct 02, 2018 at 11:02:13PM +0200, Helge Deller wrote:
> >> please pull a last set of fixes for the parisc architecture for kernel
> >> 4.19 from:
> >>
> >>
From: Roman Kiryanov
PIPE_V1_REG will be introduced later for v1 support.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe.c | 4 ++--
drivers/platform/goldfish/goldfish_pipe_qemu.h | 18 +-
drivers/platform/goldfish/goldfish_pipe_v2.c | 16
From: Roman Kiryanov
PIPE_V1_REG will be introduced later for v1 support.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe.c | 4 ++--
drivers/platform/goldfish/goldfish_pipe_qemu.h | 18 +-
drivers/platform/goldfish/goldfish_pipe_v2.c | 16
From: Roman Kiryanov
This is the v1 goldfish pipe driver.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/Makefile| 2 +-
drivers/platform/goldfish/goldfish_pipe.c | 9 +-
.../platform/goldfish/goldfish_pipe_qemu.h| 27 +
From: Roman Kiryanov
This is the v1 goldfish pipe driver.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/Makefile| 2 +-
drivers/platform/goldfish/goldfish_pipe.c | 9 +-
.../platform/goldfish/goldfish_pipe_qemu.h| 27 +
From: Roman Kiryanov
Create a constant to refer to the device name instead if several copies
of a string.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe.h| 2 ++
drivers/platform/goldfish/goldfish_pipe_v2.c | 4 ++--
2 files changed, 4 insertions(+), 2
From: Roman Kiryanov
Not required with the SPDX-License-Identifier header.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe_v2.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/platform/goldfish/goldfish_pipe_v2.c
From: Roman Kiryanov
Create a constant to refer to the device name instead if several copies
of a string.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe.h| 2 ++
drivers/platform/goldfish/goldfish_pipe_v2.c | 4 ++--
2 files changed, 4 insertions(+), 2
From: Roman Kiryanov
Not required with the SPDX-License-Identifier header.
Signed-off-by: Roman Kiryanov
---
drivers/platform/goldfish/goldfish_pipe_v2.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/platform/goldfish/goldfish_pipe_v2.c
101 - 200 of 2384 matches
Mail list logo
