[RFC v1 28/31] kunit: added Python libraries for handing KUnit config and kernel

2018-10-16 Thread Brendan Higgins
kunit_config.py: - parses .config and Kconfig files kunit_kernel.py: provides helper functions to: - configure the kernel using kunitconfig - builds the kernel with the correct architecture - provides function to invoke the kernel and stream the output back The kernel invocation is

[RFC v1 29/31] kunit: added KUnit wrapper script and simple output parser

2018-10-16 Thread Brendan Higgins
The KUnit wrapper script interfaces with the two modules (kunit_config.py and kunit_kernel.py) and provides a command line interface for running KUnit tests. This interface allows the caller to specify options like test timeouts. The script handles configuring, building and running the kernel and

[RFC v1 22/31] kunit: mock: add the concept of spyable functions

2018-10-16 Thread Brendan Higgins
Adds the concept of spying like in Mockito (http://static.javadoc.io/org.mockito/mockito-core/2.20.0/org/mockito/Mockito.html#spy-T-). This allows a function declaration to be labled as spyable which allows the function to be mocked *and* to allow the mock to invoke the original function

[RFC v1 26/31] arch: um: added stubs for mock iomem for KUnit

2018-10-16 Thread Brendan Higgins
This mocks out some iomem functions (functions like readl and writel), for mocking hardware interfaces. Signed-off-by: Brendan Higgins --- arch/um/Kconfig.common | 8 +- arch/um/Kconfig.um | 5 arch/um/include/asm/Kbuild | 1 -

[RFC v1 25/31] kunit: added concept of platform mocking

2018-10-16 Thread Brendan Higgins
Platform mocking is the mocking of all platform specific functions that interact directly with hardware. In effect, this provides the ability to mock any hardware behavior. Signed-off-by: Brendan Higgins --- drivers/base/Makefile| 1 + drivers/base/platform-mock.c | 65

[RFC v1 27/31] Documentation: kunit: adds complete documentation for KUnit

2018-10-16 Thread Brendan Higgins
- Added intro and usage guide for KUnit - Added API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins --- Documentation/index.rst | 1 + .../kunit/api/class-and-function-mocking.rst | 68 ++ Documentation/kunit/api/index.rst | 21 +

[RFC v1 31/31] MAINTAINERS: add entry for KUnit the unit testing framework

2018-10-16 Thread Brendan Higgins
Added myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 544cac829cf44..9c3d34f0062ad 100644 --- a/MAINTAINERS +++

[RFC v1 30/31] kunit.py: improved output from python wrapper

2018-10-16 Thread Brendan Higgins
- added colors to displayed output - added timing and summary Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins --- tools/testing/kunit/kunit.py| 20 ++- tools/testing/kunit/kunit_parser.py | 93 - 2 files changed, 109 insertions(+), 4 deletions(-)

[RFC v1 28/31] kunit: added Python libraries for handing KUnit config and kernel

2018-10-16 Thread Brendan Higgins
kunit_config.py: - parses .config and Kconfig files kunit_kernel.py: provides helper functions to: - configure the kernel using kunitconfig - builds the kernel with the correct architecture - provides function to invoke the kernel and stream the output back The kernel invocation is

[RFC v1 29/31] kunit: added KUnit wrapper script and simple output parser

2018-10-16 Thread Brendan Higgins
The KUnit wrapper script interfaces with the two modules (kunit_config.py and kunit_kernel.py) and provides a command line interface for running KUnit tests. This interface allows the caller to specify options like test timeouts. The script handles configuring, building and running the kernel and

[RFC v1 22/31] kunit: mock: add the concept of spyable functions

2018-10-16 Thread Brendan Higgins
Adds the concept of spying like in Mockito (http://static.javadoc.io/org.mockito/mockito-core/2.20.0/org/mockito/Mockito.html#spy-T-). This allows a function declaration to be labled as spyable which allows the function to be mocked *and* to allow the mock to invoke the original function

[RFC v1 26/31] arch: um: added stubs for mock iomem for KUnit

2018-10-16 Thread Brendan Higgins
This mocks out some iomem functions (functions like readl and writel), for mocking hardware interfaces. Signed-off-by: Brendan Higgins --- arch/um/Kconfig.common | 8 +- arch/um/Kconfig.um | 5 arch/um/include/asm/Kbuild | 1 -

[RFC v1 25/31] kunit: added concept of platform mocking

2018-10-16 Thread Brendan Higgins
Platform mocking is the mocking of all platform specific functions that interact directly with hardware. In effect, this provides the ability to mock any hardware behavior. Signed-off-by: Brendan Higgins --- drivers/base/Makefile| 1 + drivers/base/platform-mock.c | 65

[RFC v1 27/31] Documentation: kunit: adds complete documentation for KUnit

2018-10-16 Thread Brendan Higgins
- Added intro and usage guide for KUnit - Added API reference Signed-off-by: Felix Guo Signed-off-by: Brendan Higgins --- Documentation/index.rst | 1 + .../kunit/api/class-and-function-mocking.rst | 68 ++ Documentation/kunit/api/index.rst | 21 +

[RFC v1 18/31] kunit: mock: added parameter formatters

2018-10-16 Thread Brendan Higgins
Added parameter formatters which provide string formatting for parameters that have no matchers to be matched against. Signed-off-by: Brendan Higgins --- include/kunit/mock.h | 49 +++ kunit/common-mocks.c | 132 +++ kunit/mock.c

[RFC v1 15/31] kunit: mock: added basic matchers and actions

2018-10-16 Thread Brendan Higgins
Added basic matchers and actions needed for any kind of mocking to be useful; these matchers and actions are how expectations for mocks are described: what calls the mocks are expected to receive, and what the mock should do under those circumstances. Signed-off-by: Brendan Higgins ---

[RFC v1 14/31] kunit: mock: added internal mock infrastructure

2018-10-16 Thread Brendan Higgins
Adds the core internal mechanisms that mocks are implemented with; in particular, this adds the mechanisms by which expectation on mocks are validated and by which actions may be supplied and then executed when mocks are called. Signed-off-by: Brendan Higgins --- include/kunit/mock.h | 125

[RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-16 Thread Brendan Higgins
Makes minimum number of changes outside of the KUnit directories for KUnit to build and run using UML. Signed-off-by: Brendan Higgins --- Makefile | 2 +- arch/um/Kconfig.rest | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

[RFC v1 18/31] kunit: mock: added parameter formatters

2018-10-16 Thread Brendan Higgins
Added parameter formatters which provide string formatting for parameters that have no matchers to be matched against. Signed-off-by: Brendan Higgins --- include/kunit/mock.h | 49 +++ kunit/common-mocks.c | 132 +++ kunit/mock.c

[RFC v1 15/31] kunit: mock: added basic matchers and actions

2018-10-16 Thread Brendan Higgins
Added basic matchers and actions needed for any kind of mocking to be useful; these matchers and actions are how expectations for mocks are described: what calls the mocks are expected to receive, and what the mock should do under those circumstances. Signed-off-by: Brendan Higgins ---

[RFC v1 14/31] kunit: mock: added internal mock infrastructure

2018-10-16 Thread Brendan Higgins
Adds the core internal mechanisms that mocks are implemented with; in particular, this adds the mechanisms by which expectation on mocks are validated and by which actions may be supplied and then executed when mocks are called. Signed-off-by: Brendan Higgins --- include/kunit/mock.h | 125

[RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-16 Thread Brendan Higgins
Makes minimum number of changes outside of the KUnit directories for KUnit to build and run using UML. Signed-off-by: Brendan Higgins --- Makefile | 2 +- arch/um/Kconfig.rest | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index

[RFC v1 05/31] kunit: test: added the concept of expectations

2018-10-16 Thread Brendan Higgins
Added support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 259 +++ 1 file changed, 259 insertions(+) diff --git a/include/kunit/test.h

[RFC v1 19/31] kunit: mock: implemented nice, strict and naggy mock distinctions

2018-10-16 Thread Brendan Higgins
Nice mocks only fail when there is an expectation on a method, but none match a given call. Strict mocks only pass when there is a matching expectation for every call. Naggy mocks have the same pass/fail behavior as nice, but report a warning in any case a strict mock would fail. Signed-off-by:

[RFC v1 20/31] kunit: mock: add ability to mock functions with void context

2018-10-16 Thread Brendan Higgins
Adds ability to mock functions with a void* context object. Signed-off-by: Brendan Higgins --- include/kunit/mock.h| 53 + kunit/mock-macro-test.c | 30 +++ kunit/mock.c| 9 +++ 3 files changed, 92 insertions(+)

[RFC v1 24/31] kunit: improved sigsegv stack trace printing

2018-10-16 Thread Brendan Higgins
Sacrificed the control of printing stack trace within the crash handler in the test runner for getting a better stack trace; this is still not ideal, but much better than before. Signed-off-by: Brendan Higgins --- arch/um/kernel/trap.c | 11 ++- kunit/test.c | 13 +

[RFC v1 04/31] kunit: test: added test_stream a std::stream like logger

2018-10-16 Thread Brendan Higgins
Adds a C++ style log library for for logging test results. Signed-off-by: Brendan Higgins --- include/kunit/test-stream.h | 49 include/kunit/test.h| 2 + kunit/Makefile | 2 +- kunit/test-stream.c | 153

[RFC v1 16/31] kunit: mock: added class mocking support

2018-10-16 Thread Brendan Higgins
Introduces basic class mocking, the ability to automatically generate a Linux C-style class implementation whose behavior is controlled by test cases, which can also set expectations on when and how mocks are called. Signed-off-by: Brendan Higgins --- include/kunit/mock.h| 438

[RFC v1 05/31] kunit: test: added the concept of expectations

2018-10-16 Thread Brendan Higgins
Added support for expectations, which allow properties to be specified and then verified in tests. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 259 +++ 1 file changed, 259 insertions(+) diff --git a/include/kunit/test.h

[RFC v1 19/31] kunit: mock: implemented nice, strict and naggy mock distinctions

2018-10-16 Thread Brendan Higgins
Nice mocks only fail when there is an expectation on a method, but none match a given call. Strict mocks only pass when there is a matching expectation for every call. Naggy mocks have the same pass/fail behavior as nice, but report a warning in any case a strict mock would fail. Signed-off-by:

[RFC v1 20/31] kunit: mock: add ability to mock functions with void context

2018-10-16 Thread Brendan Higgins
Adds ability to mock functions with a void* context object. Signed-off-by: Brendan Higgins --- include/kunit/mock.h| 53 + kunit/mock-macro-test.c | 30 +++ kunit/mock.c| 9 +++ 3 files changed, 92 insertions(+)

[RFC v1 24/31] kunit: improved sigsegv stack trace printing

2018-10-16 Thread Brendan Higgins
Sacrificed the control of printing stack trace within the crash handler in the test runner for getting a better stack trace; this is still not ideal, but much better than before. Signed-off-by: Brendan Higgins --- arch/um/kernel/trap.c | 11 ++- kunit/test.c | 13 +

[RFC v1 04/31] kunit: test: added test_stream a std::stream like logger

2018-10-16 Thread Brendan Higgins
Adds a C++ style log library for for logging test results. Signed-off-by: Brendan Higgins --- include/kunit/test-stream.h | 49 include/kunit/test.h| 2 + kunit/Makefile | 2 +- kunit/test-stream.c | 153

[RFC v1 16/31] kunit: mock: added class mocking support

2018-10-16 Thread Brendan Higgins
Introduces basic class mocking, the ability to automatically generate a Linux C-style class implementation whose behavior is controlled by test cases, which can also set expectations on when and how mocks are called. Signed-off-by: Brendan Higgins --- include/kunit/mock.h| 438

[RFC v1 08/31] arch: um: added shim to trap to allow installing a fault catcher for tests

2018-10-16 Thread Brendan Higgins
Added context to current thread that allows a test to specify that it wants to skip the normal checks to run an installed fault catcher. Signed-off-by: Brendan Higgins --- arch/um/include/asm/processor-generic.h | 4 +++- arch/um/kernel/trap.c | 15 +++ 2 files

[RFC v1 07/31] kunit: test: added initial tests

2018-10-16 Thread Brendan Higgins
Added a test for string stream along with a more simple example. Signed-off-by: Brendan Higgins --- kunit/Kconfig | 12 ++ kunit/Makefile | 2 + kunit/example-test.c | 88 ++ kunit/string-stream-test.c | 61

[RFC v1 03/31] kunit: test: added test resource management API

2018-10-16 Thread Brendan Higgins
This creates a common API for test managed resources like memory and test objects. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 109 +++ kunit/test.c | 95 + 2 files changed, 204 insertions(+)

[RFC v1 10/31] kunit: test: added concept of initcalls

2018-10-16 Thread Brendan Higgins
Added a way to add plugins that require a test module to be loaded during initialization. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 19 +++ kunit/test.c | 29 + 2 files changed, 48 insertions(+) diff --git

[RFC v1 13/31] kunit: mock: added parameter list minipulation macros

2018-10-16 Thread Brendan Higgins
Adds macros for parsing and manipulating parameter lists needed for generating mocks. Signed-off-by: Brendan Higgins --- include/kunit/params.h | 305 kunit/Makefile | 2 +- kunit/mock-macro-test.c | 149 3 files changed,

[RFC v1 11/31] kunit: test: added concept of post conditions

2018-10-16 Thread Brendan Higgins
Adds a way to specify that certain conditions must be met at the end of a test case. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 6 ++ kunit/test.c | 13 - 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/include/kunit/test.h

[RFC v1 08/31] arch: um: added shim to trap to allow installing a fault catcher for tests

2018-10-16 Thread Brendan Higgins
Added context to current thread that allows a test to specify that it wants to skip the normal checks to run an installed fault catcher. Signed-off-by: Brendan Higgins --- arch/um/include/asm/processor-generic.h | 4 +++- arch/um/kernel/trap.c | 15 +++ 2 files

[RFC v1 07/31] kunit: test: added initial tests

2018-10-16 Thread Brendan Higgins
Added a test for string stream along with a more simple example. Signed-off-by: Brendan Higgins --- kunit/Kconfig | 12 ++ kunit/Makefile | 2 + kunit/example-test.c | 88 ++ kunit/string-stream-test.c | 61

[RFC v1 03/31] kunit: test: added test resource management API

2018-10-16 Thread Brendan Higgins
This creates a common API for test managed resources like memory and test objects. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 109 +++ kunit/test.c | 95 + 2 files changed, 204 insertions(+)

[RFC v1 10/31] kunit: test: added concept of initcalls

2018-10-16 Thread Brendan Higgins
Added a way to add plugins that require a test module to be loaded during initialization. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 19 +++ kunit/test.c | 29 + 2 files changed, 48 insertions(+) diff --git

[RFC v1 13/31] kunit: mock: added parameter list minipulation macros

2018-10-16 Thread Brendan Higgins
Adds macros for parsing and manipulating parameter lists needed for generating mocks. Signed-off-by: Brendan Higgins --- include/kunit/params.h | 305 kunit/Makefile | 2 +- kunit/mock-macro-test.c | 149 3 files changed,

[RFC v1 11/31] kunit: test: added concept of post conditions

2018-10-16 Thread Brendan Higgins
Adds a way to specify that certain conditions must be met at the end of a test case. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 6 ++ kunit/test.c | 13 - 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/include/kunit/test.h

[RFC v1 02/31] kunit: test: adds KUnit test runner core

2018-10-16 Thread Brendan Higgins
Adds the KUnit core, which allows test cases to be defined and associated with common initialization and cleanup logic. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 165 ++ kunit/Makefile | 2 +- kunit/test.c | 168

[RFC v1 02/31] kunit: test: adds KUnit test runner core

2018-10-16 Thread Brendan Higgins
Adds the KUnit core, which allows test cases to be defined and associated with common initialization and cleanup logic. Signed-off-by: Brendan Higgins --- include/kunit/test.h | 165 ++ kunit/Makefile | 2 +- kunit/test.c | 168

[RFC v1 01/31] kunit: test: added string_stream a std::stream like string builder

2018-10-16 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. This provides a library for constructing the string as you go similar to C++'s std::string. Signed-off-by: Brendan Higgins ---

[RFC v1 01/31] kunit: test: added string_stream a std::stream like string builder

2018-10-16 Thread Brendan Higgins
A number of test features need to do pretty complicated string printing where it may not be possible to rely on a single preallocated string with parameters. This provides a library for constructing the string as you go similar to C++'s std::string. Signed-off-by: Brendan Higgins ---

[RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-16 Thread Brendan Higgins
This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM and does not require tests to be written in userspace

[RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-16 Thread Brendan Higgins
This patch set proposes KUnit, a lightweight unit testing and mocking framework for the Linux kernel. Unlike Autotest and kselftest, KUnit is a true unit testing framework; it does not require installing the kernel on a test machine or in a VM and does not require tests to be written in userspace

Re: [PATCH v4 10/13] arch/x86: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array

2018-10-16 Thread Fenghua Yu
On Mon, Oct 15, 2018 at 08:55:54PM +, Moger, Babu wrote: > From: Sherry Hurwitz > > The feature bit X86_FEATURE_MBA is detected via CPUID leaf 0x8008 > EBX Bit 06. This bit indicates the support of AMD's MBA feature. > > This feature is supported by both Intel and AMD. But they are

Re: [PATCH v4 10/13] arch/x86: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array

2018-10-16 Thread Fenghua Yu
On Mon, Oct 15, 2018 at 08:55:54PM +, Moger, Babu wrote: > From: Sherry Hurwitz > > The feature bit X86_FEATURE_MBA is detected via CPUID leaf 0x8008 > EBX Bit 06. This bit indicates the support of AMD's MBA feature. > > This feature is supported by both Intel and AMD. But they are

Re: [PATCH v2] clk: mvebu: armada-37xx-tbg: Switch to clk_get and balance it in probe

2018-10-16 Thread Stephen Boyd
Quoting Gregory CLEMENT (2018-10-10 11:18:38) > The parent clock is get only to have its name, and then the clock is no > more used, so we can safely free it using clk_put. Furthermore as between > the successful devm_clk_get() and the devm_clk_put() call we don't exit > the probe function in

Re: [PATCH v2] clk: mvebu: armada-37xx-tbg: Switch to clk_get and balance it in probe

2018-10-16 Thread Stephen Boyd
Quoting Gregory CLEMENT (2018-10-10 11:18:38) > The parent clock is get only to have its name, and then the clock is no > more used, so we can safely free it using clk_put. Furthermore as between > the successful devm_clk_get() and the devm_clk_put() call we don't exit > the probe function in

Re: [PATCH 0/7] NULL pointer deref fix for stm32-dma

2018-10-16 Thread Joel Fernandes
On Tue, Oct 16, 2018 at 06:11:29PM +0200, Greg KH wrote: > On Mon, Oct 08, 2018 at 10:47:45PM -0700, Joel Fernandes (Google) wrote: > > Hi Greg, > > > > While looking at android-4.14, I found a NULL pointer deref with > > stm32-dma driver using Coccicheck errors. I found that upstream had a > >

Re: [RESEND][PATCH] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-10-16 Thread John Stultz
On Tue, Oct 16, 2018 at 3:48 PM, John Stultz wrote: > On Mon, Oct 15, 2018 at 8:41 PM, Martin K. Petersen > wrote: >> >> John, >> >>> Hynix ufs has deviations on hi36xx platform which will result in ufs >>> bursts transfer failures. >> >> Is this specific to the particular implementation on

Re: [PATCH 0/7] NULL pointer deref fix for stm32-dma

2018-10-16 Thread Joel Fernandes
On Tue, Oct 16, 2018 at 06:11:29PM +0200, Greg KH wrote: > On Mon, Oct 08, 2018 at 10:47:45PM -0700, Joel Fernandes (Google) wrote: > > Hi Greg, > > > > While looking at android-4.14, I found a NULL pointer deref with > > stm32-dma driver using Coccicheck errors. I found that upstream had a > >

Re: [RESEND][PATCH] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

2018-10-16 Thread John Stultz
On Tue, Oct 16, 2018 at 3:48 PM, John Stultz wrote: > On Mon, Oct 15, 2018 at 8:41 PM, Martin K. Petersen > wrote: >> >> John, >> >>> Hynix ufs has deviations on hi36xx platform which will result in ufs >>> bursts transfer failures. >> >> Is this specific to the particular implementation on

Re: [PATCH v4 08/13] arch/x86: Bring few more functions into the resource structure

2018-10-16 Thread Fenghua Yu
On Mon, Oct 15, 2018 at 08:55:49PM +, Moger, Babu wrote: > update_mba_bw : Feedback loop bandwidth update functionality is not > needed for AMD. Will you implement update_mba_bw() for AMD in future? > list_for_each_entry(crgrp, head, mon.crdtgrp_list) >

Re: [PATCH v4 08/13] arch/x86: Bring few more functions into the resource structure

2018-10-16 Thread Fenghua Yu
On Mon, Oct 15, 2018 at 08:55:49PM +, Moger, Babu wrote: > update_mba_bw : Feedback loop bandwidth update functionality is not > needed for AMD. Will you implement update_mba_bw() for AMD in future? > list_for_each_entry(crgrp, head, mon.crdtgrp_list) >

mmotm 2018-10-16-16-46 uploaded

2018-10-16 Thread akpm
The mm-of-the-moment snapshot 2018-10-16-16-46 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

mmotm 2018-10-16-16-46 uploaded

2018-10-16 Thread akpm
The mm-of-the-moment snapshot 2018-10-16-16-46 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

Re: [PATCH v3 1/2] sysctl: handle overflow in proc_get_long

2018-10-16 Thread Eric W. Biederman
Christian Brauner writes: > proc_get_long() is a funny function. It uses simple_strtoul() and for a > good reason. proc_get_long() wants to always succeed the parse and return > the maybe incorrect value and the trailing characters to check against a > pre-defined list of acceptable trailing

Re: [PATCH v3 1/2] sysctl: handle overflow in proc_get_long

2018-10-16 Thread Eric W. Biederman
Christian Brauner writes: > proc_get_long() is a funny function. It uses simple_strtoul() and for a > good reason. proc_get_long() wants to always succeed the parse and return > the maybe incorrect value and the trailing characters to check against a > pre-defined list of acceptable trailing

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Cyrille Pitchen
Hi Tudor, Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : > Hi, Yogesh, > > On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: >> Hi Tudor, >> >> This patch is breaking the 1-4-4 Read protocol for the spansion flash >> "s25fl512s". >> >> Without this patch read request command for Quad mode,

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Cyrille Pitchen
Hi Tudor, Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : > Hi, Yogesh, > > On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: >> Hi Tudor, >> >> This patch is breaking the 1-4-4 Read protocol for the spansion flash >> "s25fl512s". >> >> Without this patch read request command for Quad mode,

Re: [RFC PATCH 00/30] softirq: Make softirqs soft-interruptible (+ per vector disablement)

2018-10-16 Thread Richard Cochran
On Tue, Oct 16, 2018 at 04:03:59PM -0600, Jonathan Corbet wrote: > I have to ask a dumb question, though. Might it not be better to add a > new set of functions like: > > local_softirq_disable(mask); > spin_lock_softirq(lock, mask); > > Then just define the existing functions to

Re: [RFC PATCH 00/30] softirq: Make softirqs soft-interruptible (+ per vector disablement)

2018-10-16 Thread Richard Cochran
On Tue, Oct 16, 2018 at 04:03:59PM -0600, Jonathan Corbet wrote: > I have to ask a dumb question, though. Might it not be better to add a > new set of functions like: > > local_softirq_disable(mask); > spin_lock_softirq(lock, mask); > > Then just define the existing functions to

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Giuliano Augusto Faulin Belinassi
>(There is a linux-...@googlegroups.com mailing list >that bounces when I reply, so I removed it from the >cc list) Sorry. I think this may be because my HTML mode in gmail was enabled. > I wrote that to encourage you to do more than > what checkpatch says. > I just moved code around and

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Giuliano Augusto Faulin Belinassi
>(There is a linux-...@googlegroups.com mailing list >that bounces when I reply, so I removed it from the >cc list) Sorry. I think this may be because my HTML mode in gmail was enabled. > I wrote that to encourage you to do more than > what checkpatch says. > I just moved code around and

Re: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()

2018-10-16 Thread Andy Lutomirski
On Tue, Oct 16, 2018 at 2:39 PM Sebastian Andrzej Siewior wrote: > > On 2018-10-16 14:25:07 [-0700], Andy Lutomirski wrote: > > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > > > index 51a5a69ecac9f..fe6b21f0a6631 100644 > > > --- a/arch/x86/mm/pageattr.c > > > +++

Re: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()

2018-10-16 Thread Andy Lutomirski
On Tue, Oct 16, 2018 at 2:39 PM Sebastian Andrzej Siewior wrote: > > On 2018-10-16 14:25:07 [-0700], Andy Lutomirski wrote: > > > diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c > > > index 51a5a69ecac9f..fe6b21f0a6631 100644 > > > --- a/arch/x86/mm/pageattr.c > > > +++

[PATCH 7/7] tty: Fix section format

2018-10-16 Thread Tobin C. Harding
Currently sections (specifically 'Return:' and 'Context:') are non-uniform and/or incorrectly labelled. We should use the format outlined in Documentation/doc-guide/kernel-doc.rst. This patch is a bit of a mash up because text is on occasions mixed up in the current comments. - Use 'Context:'

[PATCH 4/7] tty: Fix kernel-doc variable typos

2018-10-16 Thread Tobin C. Harding
From: "Tobin C. Harding" There are a few typos in the kernel-doc variables [descriptions]. Fix these by using the correct variable name and adding a description. Fix kernel-doc variable typos. Signed-off-by: Tobin C. Harding --- drivers/tty/serial/men_z135_uart.c | 4 ++-- 1 file changed, 2

[PATCH 7/7] tty: Fix section format

2018-10-16 Thread Tobin C. Harding
Currently sections (specifically 'Return:' and 'Context:') are non-uniform and/or incorrectly labelled. We should use the format outlined in Documentation/doc-guide/kernel-doc.rst. This patch is a bit of a mash up because text is on occasions mixed up in the current comments. - Use 'Context:'

[PATCH 4/7] tty: Fix kernel-doc variable typos

2018-10-16 Thread Tobin C. Harding
From: "Tobin C. Harding" There are a few typos in the kernel-doc variables [descriptions]. Fix these by using the correct variable name and adding a description. Fix kernel-doc variable typos. Signed-off-by: Tobin C. Harding --- drivers/tty/serial/men_z135_uart.c | 4 ++-- 1 file changed, 2

[PATCH 1/7] tty: Fix whitespace before tab warnings

2018-10-16 Thread Tobin C. Harding
This patch is whitespace only. Checkpatch emits a BUNCH of warnings of type WARNING: please, no spaces at the start of a line WARNING: please, no space before tabs While these may seem trivial they hinder further cleanup efforts because there are so many that later cleanup

[PATCH 6/7] tty: Remove newline after function kernel-doc

2018-10-16 Thread Tobin C. Harding
From: "Tobin C. Harding" Currently there are many places were a newline is left between the kernel-doc function comment and the function it is documenting. There should not be a newline here. Remove newline after function kernel-doc. This patch is whitespace only. Signed-off-by: Tobin C.

[PATCH 1/7] tty: Fix whitespace before tab warnings

2018-10-16 Thread Tobin C. Harding
This patch is whitespace only. Checkpatch emits a BUNCH of warnings of type WARNING: please, no spaces at the start of a line WARNING: please, no space before tabs While these may seem trivial they hinder further cleanup efforts because there are so many that later cleanup

[PATCH 6/7] tty: Remove newline after function kernel-doc

2018-10-16 Thread Tobin C. Harding
From: "Tobin C. Harding" Currently there are many places were a newline is left between the kernel-doc function comment and the function it is documenting. There should not be a newline here. Remove newline after function kernel-doc. This patch is whitespace only. Signed-off-by: Tobin C.

[PATCH 0/7] drivers: tty: Fix kernel-docs comments

2018-10-16 Thread Tobin C. Harding
Hi, My first patch set using kernel.org email address. I've been so careful with this one I'm expecting some epic fail :) This set is an attempt to clean up the kernel docs comments under drivers/tty/. I do not know what time in the kernel dev cycle would be best for this set. If now is not

[PATCH 5/7] tty: Fix spacing between kernel-doc sections

2018-10-16 Thread Tobin C. Harding
There is a specified spacing for kernel-doc layout in Documentation/doc-guide/kernel-doc.rst we should try to adhere to it as much as possible. Fix spacing between sections. Signed-off-by: Tobin C. Harding --- drivers/tty/n_hdlc.c | 2 ++ drivers/tty/serial/serial-tegra.c | 2 --

[PATCH 0/7] drivers: tty: Fix kernel-docs comments

2018-10-16 Thread Tobin C. Harding
Hi, My first patch set using kernel.org email address. I've been so careful with this one I'm expecting some epic fail :) This set is an attempt to clean up the kernel docs comments under drivers/tty/. I do not know what time in the kernel dev cycle would be best for this set. If now is not

[PATCH 5/7] tty: Fix spacing between kernel-doc sections

2018-10-16 Thread Tobin C. Harding
There is a specified spacing for kernel-doc layout in Documentation/doc-guide/kernel-doc.rst we should try to adhere to it as much as possible. Fix spacing between sections. Signed-off-by: Tobin C. Harding --- drivers/tty/n_hdlc.c | 2 ++ drivers/tty/serial/serial-tegra.c | 2 --

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-16 Thread Andrew Morton
On Tue, 16 Oct 2018 19:11:49 -0400 Andrea Arcangeli wrote: > This was a severe regression > compared to previous kernels that made important workloads unusable > and it starts when __GFP_THISNODE was added to THP allocations under > MADV_HUGEPAGE. It is not a significant risk to go to the

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-16 Thread Andrew Morton
On Tue, 16 Oct 2018 19:11:49 -0400 Andrea Arcangeli wrote: > This was a severe regression > compared to previous kernels that made important workloads unusable > and it starts when __GFP_THISNODE was added to THP allocations under > MADV_HUGEPAGE. It is not a significant risk to go to the

Re: [PATCH] KVM: VMX: enable nested virtualization by default

2018-10-16 Thread Liran Alon
> On 17 Oct 2018, at 1:55, Paolo Bonzini wrote: > > With live migration support and finally a good solution for CR2/DR6 > exception payloads, nested VMX should finally be ready for having a stable And good solution for setting/getting vCPU events from userspace with correct pending/injected

Re: [PATCH] KVM: VMX: enable nested virtualization by default

2018-10-16 Thread Liran Alon
> On 17 Oct 2018, at 1:55, Paolo Bonzini wrote: > > With live migration support and finally a good solution for CR2/DR6 > exception payloads, nested VMX should finally be ready for having a stable And good solution for setting/getting vCPU events from userspace with correct pending/injected

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-16 Thread Andrea Arcangeli
Hello, On Tue, Oct 16, 2018 at 03:37:15PM -0700, Andrew Morton wrote: > we'll still make it into 4.19.1. Am reluctant to merge this while > discussion, testing and possibly more development are ongoing. I think there can be definitely more developments primarily to make the compact deferred

Re: [PATCH 1/2] mm: thp: relax __GFP_THISNODE for MADV_HUGEPAGE mappings

2018-10-16 Thread Andrea Arcangeli
Hello, On Tue, Oct 16, 2018 at 03:37:15PM -0700, Andrew Morton wrote: > we'll still make it into 4.19.1. Am reluctant to merge this while > discussion, testing and possibly more development are ongoing. I think there can be definitely more developments primarily to make the compact deferred

Re: Crash in msm serial on dragonboard with ftrace bootargs

2018-10-16 Thread Joel Fernandes
On Tue, Oct 16, 2018 at 05:08:25PM +0530, Sai Prakash Ranjan wrote: > Hi, > > On dragonboard 410c, with "ftrace=function" boot args, the console output > slows down and board resets without any backtrace as below. This is tested > on latest kernel and seems to exist even in older kernels as well.

Re: Crash in msm serial on dragonboard with ftrace bootargs

2018-10-16 Thread Joel Fernandes
On Tue, Oct 16, 2018 at 05:08:25PM +0530, Sai Prakash Ranjan wrote: > Hi, > > On dragonboard 410c, with "ftrace=function" boot args, the console output > slows down and board resets without any backtrace as below. This is tested > on latest kernel and seems to exist even in older kernels as well.

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Joe Perches
(There is a linux-...@googlegroups.com mailing list that bounces when I reply, so I removed it from the cc list) On Tue, 2018-10-16 at 19:48 -0300, Giuliano Belinassi wrote: > Hello, > Thank you for your review :-). > Sorry, but I am a newbie on this, and now I am confused about my next >

Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style

2018-10-16 Thread Joe Perches
(There is a linux-...@googlegroups.com mailing list that bounces when I reply, so I removed it from the cc list) On Tue, 2018-10-16 at 19:48 -0300, Giuliano Belinassi wrote: > Hello, > Thank you for your review :-). > Sorry, but I am a newbie on this, and now I am confused about my next >

Re: [PATCH 3/3] x86/fpu: Save FPU registers on context switch if there is a FPU

2018-10-16 Thread Andy Lutomirski
On Tue, Oct 16, 2018 at 1:25 PM Sebastian Andrzej Siewior wrote: > > Booting a 486 with "no387 nofxsr" ends with > | math_emulate: 0060:c101987d > | Kernel panic - not syncing: Math emulation needed in kernel > > on the first context switch in user land. The reason is that >

Re: [PATCH 3/3] x86/fpu: Save FPU registers on context switch if there is a FPU

2018-10-16 Thread Andy Lutomirski
On Tue, Oct 16, 2018 at 1:25 PM Sebastian Andrzej Siewior wrote: > > Booting a 486 with "no387 nofxsr" ends with > | math_emulate: 0060:c101987d > | Kernel panic - not syncing: Math emulation needed in kernel > > on the first context switch in user land. The reason is that >

[PATCH] KVM: VMX: enable nested virtualization by default

2018-10-16 Thread Paolo Bonzini
With live migration support and finally a good solution for CR2/DR6 exception payloads, nested VMX should finally be ready for having a stable userspace ABI. The results of syzkaller fuzzing are not perfect but not horrible either (and might be partially due to running on GCE, so that effectively

[PATCH] KVM: VMX: enable nested virtualization by default

2018-10-16 Thread Paolo Bonzini
With live migration support and finally a good solution for CR2/DR6 exception payloads, nested VMX should finally be ready for having a stable userspace ABI. The results of syzkaller fuzzing are not perfect but not horrible either (and might be partially due to running on GCE, so that effectively

<    1   2   3   4   5   6   7   8   9   10   >