[POC 09/12] fs/inode.c: access inode_cachep via rai_load

2018-10-17 Thread Rasmus Villemoes
This avoids a cacheline access to get the value of the inode_cachep pointer in the places that do a kmem_cache_*(inode_cachep, ...); Signed-off-by: Rasmus Villemoes --- fs/inode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index

[POC 05/12] x86-64: initial ro-after-init patching support

2018-10-17 Thread Rasmus Villemoes
This just sets things up so that the ARCH_HAS_RAI symbol gets selected, and prepare the arch-specific headers and support functions. Signed-off-by: Rasmus Villemoes --- arch/x86/Kconfig | 1 + arch/x86/include/asm/rai.S | 18 ++ arch/x86/include/asm/rai.h | 25

[POC 08/12] fs/dcache.c: access dentry_cache via rai_load

2018-10-17 Thread Rasmus Villemoes
This avoids a cacheline access to get the value of the dentry_cache pointer in the places that do a kmem_cache_*(dentry_cache, ...); Signed-off-by: Rasmus Villemoes --- fs/dcache.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index

[POC 09/12] fs/inode.c: access inode_cachep via rai_load

2018-10-17 Thread Rasmus Villemoes
This avoids a cacheline access to get the value of the inode_cachep pointer in the places that do a kmem_cache_*(inode_cachep, ...); Signed-off-by: Rasmus Villemoes --- fs/inode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index

[POC 05/12] x86-64: initial ro-after-init patching support

2018-10-17 Thread Rasmus Villemoes
This just sets things up so that the ARCH_HAS_RAI symbol gets selected, and prepare the arch-specific headers and support functions. Signed-off-by: Rasmus Villemoes --- arch/x86/Kconfig | 1 + arch/x86/include/asm/rai.S | 18 ++ arch/x86/include/asm/rai.h | 25

[POC 08/12] fs/dcache.c: access dentry_cache via rai_load

2018-10-17 Thread Rasmus Villemoes
This avoids a cacheline access to get the value of the dentry_cache pointer in the places that do a kmem_cache_*(dentry_cache, ...); Signed-off-by: Rasmus Villemoes --- fs/dcache.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index

[POC 04/12] vmlinux.lds.h: handle various rai sections

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- include/asm-generic/vmlinux.lds.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index f09ee3c544bc..f38510c6bfcc 100644 --- a/include/asm-generic/vmlinux.lds.h +++

[POC 04/12] vmlinux.lds.h: handle various rai sections

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- include/asm-generic/vmlinux.lds.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index f09ee3c544bc..f38510c6bfcc 100644 --- a/include/asm-generic/vmlinux.lds.h +++

[POC 11/12] x86-64: implement _rai_bucket_shift

2018-10-17 Thread Rasmus Villemoes
The only slightly tricky issue is that for implementing the thunk, we need some temporary registers (with %ecx being one of them), and we don't know whether the hash input and/or destination register collide with whichever we choose. One _could_ attempt text parsing in asm in order to find a safe

[POC 03/12] arch/Kconfig: add ARCH_HAS_RAI symbol

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- arch/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 9d329608913e..160893bd6a5c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -275,6 +275,9 @@ config ARCH_THREAD_STACK_ALLOCATOR config

[POC 11/12] x86-64: implement _rai_bucket_shift

2018-10-17 Thread Rasmus Villemoes
The only slightly tricky issue is that for implementing the thunk, we need some temporary registers (with %ecx being one of them), and we don't know whether the hash input and/or destination register collide with whichever we choose. One _could_ attempt text parsing in asm in order to find a safe

[POC 03/12] arch/Kconfig: add ARCH_HAS_RAI symbol

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- arch/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/Kconfig b/arch/Kconfig index 9d329608913e..160893bd6a5c 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -275,6 +275,9 @@ config ARCH_THREAD_STACK_ALLOCATOR config

[POC 12/12] fs/dcache.c: use rai_bucket_shift for dentry hashtable

2018-10-17 Thread Rasmus Villemoes
Before this, the disassembly of __d_lookup_rcu begins 0x2d10 <__d_lookup_rcu>: push %r15 0x2d12 <__d_lookup_rcu+2>: push %r14 0x2d14 <__d_lookup_rcu+4>: push %r13 0x2d16 <__d_lookup_rcu+6>: push %r12 0x2d18 <__d_lookup_rcu+8>: push %rbp 0x2d19

[POC 10/12] hack: /proc/rai: add rai_bucket_shift use

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- arch/x86/kernel/rai.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/kernel/rai.c b/arch/x86/kernel/rai.c index e55e85f11a2e..c4284ce7478f 100644 --- a/arch/x86/kernel/rai.c +++ b/arch/x86/kernel/rai.c @@ -63,11 +63,21 @@

[POC 12/12] fs/dcache.c: use rai_bucket_shift for dentry hashtable

2018-10-17 Thread Rasmus Villemoes
Before this, the disassembly of __d_lookup_rcu begins 0x2d10 <__d_lookup_rcu>: push %r15 0x2d12 <__d_lookup_rcu+2>: push %r14 0x2d14 <__d_lookup_rcu+4>: push %r13 0x2d16 <__d_lookup_rcu+6>: push %r12 0x2d18 <__d_lookup_rcu+8>: push %rbp 0x2d19

[POC 10/12] hack: /proc/rai: add rai_bucket_shift use

2018-10-17 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- arch/x86/kernel/rai.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/kernel/rai.c b/arch/x86/kernel/rai.c index e55e85f11a2e..c4284ce7478f 100644 --- a/arch/x86/kernel/rai.c +++ b/arch/x86/kernel/rai.c @@ -63,11 +63,21 @@

[POC 06/12] ugly ugly hack

2018-10-17 Thread Rasmus Villemoes
Just to have a quick way of seeing that rai-patching works (i.e., once we implement rai_load, we'd not expect the output to change). Also, inside virtme we can do a quick "gdb vmlinux /proc/kcode" and disassemble rai_proc_show to see how the patched function looks. Signed-off-by: Rasmus Villemoes

Re: [PATCH v7 1/6] seccomp: add a return code to trap to userspace

2018-10-17 Thread Tycho Andersen
On Wed, Oct 17, 2018 at 03:21:02PM -0700, Kees Cook wrote: > On Wed, Oct 17, 2018 at 1:29 PM, Tycho Andersen wrote: > > On Thu, Sep 27, 2018 at 02:31:24PM -0700, Kees Cook wrote: > >> On Thu, Sep 27, 2018 at 8:11 AM, Tycho Andersen wrote: > >> > @@ -60,4 +62,29 @@ struct seccomp_data { > >> >

[POC 06/12] ugly ugly hack

2018-10-17 Thread Rasmus Villemoes
Just to have a quick way of seeing that rai-patching works (i.e., once we implement rai_load, we'd not expect the output to change). Also, inside virtme we can do a quick "gdb vmlinux /proc/kcode" and disassemble rai_proc_show to see how the patched function looks. Signed-off-by: Rasmus Villemoes

Re: [PATCH v7 1/6] seccomp: add a return code to trap to userspace

2018-10-17 Thread Tycho Andersen
On Wed, Oct 17, 2018 at 03:21:02PM -0700, Kees Cook wrote: > On Wed, Oct 17, 2018 at 1:29 PM, Tycho Andersen wrote: > > On Thu, Sep 27, 2018 at 02:31:24PM -0700, Kees Cook wrote: > >> On Thu, Sep 27, 2018 at 8:11 AM, Tycho Andersen wrote: > >> > @@ -60,4 +62,29 @@ struct seccomp_data { > >> >

[POC 02/12] init/main.c: call update_rai_access()

2018-10-17 Thread Rasmus Villemoes
I hope that one can actually interchange the order of these calls a bit so that they read mark_readonly(); update_rai_access(); free_initmem(); because there will be some metadata associated to each rai_* macro invocation that might as well live in __initdata. But for

[POC 02/12] init/main.c: call update_rai_access()

2018-10-17 Thread Rasmus Villemoes
I hope that one can actually interchange the order of these calls a bit so that they read mark_readonly(); update_rai_access(); free_initmem(); because there will be some metadata associated to each rai_* macro invocation that might as well live in __initdata. But for

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:21:08 -0600 Jeffrey Hugo wrote: > On 10/17/2018 4:05 PM, Andrew Morton wrote: > > On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell > > wrote: > > > >> Cc: Arnd Bergmann > >> Co-developed-by: Arnd Bergmann > >> Signed-off-by: Anders Roxell > > > > This should have

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:21:08 -0600 Jeffrey Hugo wrote: > On 10/17/2018 4:05 PM, Andrew Morton wrote: > > On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell > > wrote: > > > >> Cc: Arnd Bergmann > >> Co-developed-by: Arnd Bergmann > >> Signed-off-by: Anders Roxell > > > > This should have

Re: [RFC v1 26/31] arch: um: added stubs for mock iomem for KUnit

2018-10-17 Thread Rob Herring
On Tue, Oct 16, 2018 at 6:54 PM Brendan Higgins wrote: > > This mocks out some iomem functions (functions like readl and writel), > for mocking hardware interfaces. > > Signed-off-by: Brendan Higgins > --- > arch/um/Kconfig.common | 8 +- > arch/um/Kconfig.um

Re: [RFC v1 26/31] arch: um: added stubs for mock iomem for KUnit

2018-10-17 Thread Rob Herring
On Tue, Oct 16, 2018 at 6:54 PM Brendan Higgins wrote: > > This mocks out some iomem functions (functions like readl and writel), > for mocking hardware interfaces. > > Signed-off-by: Brendan Higgins > --- > arch/um/Kconfig.common | 8 +- > arch/um/Kconfig.um

Re: [LKP] [mm/memory.c] 6558038e45: general_protection_fault:#[##]

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 09:36:00 +0800 kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-6): > > commit: 6558038e4540a22ee4f99a5def74791189102bc0 ("mm/memory.c: recheck page > table entry with page table lock held") >

Re: [LKP] [mm/memory.c] 6558038e45: general_protection_fault:#[##]

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 09:36:00 +0800 kernel test robot wrote: > FYI, we noticed the following commit (built with gcc-6): > > commit: 6558038e4540a22ee4f99a5def74791189102bc0 ("mm/memory.c: recheck page > table entry with page table lock held") >

Re: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Brendan Higgins
On Wed, Oct 17, 2018 at 10:49 AM wrote: > > > -Original Message- > > From: Brendan Higgins > > > > This patch set proposes KUnit, a lightweight unit testing and mocking > > framework for the Linux kernel. > > I'm interested in this, and think the kernel might benefit from this, > but I

Re: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Brendan Higgins
On Wed, Oct 17, 2018 at 10:49 AM wrote: > > > -Original Message- > > From: Brendan Higgins > > > > This patch set proposes KUnit, a lightweight unit testing and mocking > > framework for the Linux kernel. > > I'm interested in this, and think the kernel might benefit from this, > but I

Re: statx(2) API and documentation

2018-10-17 Thread Florian Weimer
* Andreas Dilger: >> So what's the point exactly? > > Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel > to mask off flags that it doesn't currently understand. It doesn't make > much sense for applications to specify STATX_ALL, since they don't have any > way to know

Re: statx(2) API and documentation

2018-10-17 Thread Florian Weimer
* Andreas Dilger: >> So what's the point exactly? > > Ah, I see your point... STATX_ALL seems to be mostly useful for the kernel > to mask off flags that it doesn't currently understand. It doesn't make > much sense for applications to specify STATX_ALL, since they don't have any > way to know

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Jeffrey Hugo
On 10/17/2018 4:05 PM, Andrew Morton wrote: On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell wrote: Cc: Arnd Bergmann Co-developed-by: Arnd Bergmann Signed-off-by: Anders Roxell This should have Arnd's Signed-off-by: as well. I'm just interested to know, why? -- Jeffrey Hugo Qualcomm

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Jeffrey Hugo
On 10/17/2018 4:05 PM, Andrew Morton wrote: On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell wrote: Cc: Arnd Bergmann Co-developed-by: Arnd Bergmann Signed-off-by: Anders Roxell This should have Arnd's Signed-off-by: as well. I'm just interested to know, why? -- Jeffrey Hugo Qualcomm

Re: l1tf: Kernel suggests I throw away third of my memory. I'd rather not

2018-10-17 Thread Dave Hansen
On 10/17/2018 04:32 AM, Pavel Machek wrote: >> Well, that depends. Do you care about PROT_NONE attacks as well? If not >> then no-swap would help you. But even then no-swap is rather theoretical >> attack on a physical host unless you allow an arbitrary swapout to a >> malicious user (e.g. allow a

Re: l1tf: Kernel suggests I throw away third of my memory. I'd rather not

2018-10-17 Thread Dave Hansen
On 10/17/2018 04:32 AM, Pavel Machek wrote: >> Well, that depends. Do you care about PROT_NONE attacks as well? If not >> then no-swap would help you. But even then no-swap is rather theoretical >> attack on a physical host unless you allow an arbitrary swapout to a >> malicious user (e.g. allow a

Re: [PATCH v7 1/6] seccomp: add a return code to trap to userspace

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 1:29 PM, Tycho Andersen wrote: > On Thu, Sep 27, 2018 at 02:31:24PM -0700, Kees Cook wrote: >> On Thu, Sep 27, 2018 at 8:11 AM, Tycho Andersen wrote: >> > @@ -60,4 +62,29 @@ struct seccomp_data { >> > __u64 args[6]; >> > }; >> > >> > +struct seccomp_notif { >> >

Re: [PATCH v7 1/6] seccomp: add a return code to trap to userspace

2018-10-17 Thread Kees Cook
On Wed, Oct 17, 2018 at 1:29 PM, Tycho Andersen wrote: > On Thu, Sep 27, 2018 at 02:31:24PM -0700, Kees Cook wrote: >> On Thu, Sep 27, 2018 at 8:11 AM, Tycho Andersen wrote: >> > @@ -60,4 +62,29 @@ struct seccomp_data { >> > __u64 args[6]; >> > }; >> > >> > +struct seccomp_notif { >> >

Re: statx(2) API and documentation

2018-10-17 Thread Amir Goldstein
On Wed, Oct 17, 2018 at 10:12 PM Miklos Szeredi wrote: > >> - STATX_ALL definition is unclear, can this change, or is it fixed? > >> If it's the former, than that's a backward compatibility nightmare. > >> If it's the latter, then what's the point? > > > > The value can change over time. It is

Re: statx(2) API and documentation

2018-10-17 Thread Amir Goldstein
On Wed, Oct 17, 2018 at 10:12 PM Miklos Szeredi wrote: > >> - STATX_ALL definition is unclear, can this change, or is it fixed? > >> If it's the former, than that's a backward compatibility nightmare. > >> If it's the latter, then what's the point? > > > > The value can change over time. It is

Re: [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration [ver #12]

2018-10-17 Thread Alan Jenkins
[resent, hopefully with slightly less formatting damage] On 17/10/2018 16:45, David Howells wrote: Alan Jenkins wrote: I agree. I'm happy to see this is using the same check as do_remount(). * change filesystem flags. dir should be a physical root of filesystem. * If you've mounted a

Re: [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration [ver #12]

2018-10-17 Thread Alan Jenkins
[resent, hopefully with slightly less formatting damage] On 17/10/2018 16:45, David Howells wrote: Alan Jenkins wrote: I agree. I'm happy to see this is using the same check as do_remount(). * change filesystem flags. dir should be a physical root of filesystem. * If you've mounted a

Re: [PATCH 2/2] writeback: don't decrement wb->refcnt if !wb->bdi

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:03:11 +0200 Anders Roxell wrote: > When enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE devtmpfs gets killed > because we try to remove a file and decrement the wb reference count > before the noop_backing_device_info gets initialized. > > Since arch_initcall(pl011_init) came

Re: [PATCH 2/2] writeback: don't decrement wb->refcnt if !wb->bdi

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:03:11 +0200 Anders Roxell wrote: > When enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE devtmpfs gets killed > because we try to remove a file and decrement the wb reference count > before the noop_backing_device_info gets initialized. > > Since arch_initcall(pl011_init) came

[tip:ras/core] x86/mcelog: Remove one mce_helper definition

2018-10-17 Thread tip-bot for Sebastian Andrzej Siewior
Commit-ID: 711f76a328cbe5b49164bb14bcb593fa52102051 Gitweb: https://git.kernel.org/tip/711f76a328cbe5b49164bb14bcb593fa52102051 Author: Sebastian Andrzej Siewior AuthorDate: Wed, 17 Oct 2018 19:05:53 +0200 Committer: Borislav Petkov CommitDate: Thu, 18 Oct 2018 00:05:04 +0200

[tip:ras/core] x86/mcelog: Remove one mce_helper definition

2018-10-17 Thread tip-bot for Sebastian Andrzej Siewior
Commit-ID: 711f76a328cbe5b49164bb14bcb593fa52102051 Gitweb: https://git.kernel.org/tip/711f76a328cbe5b49164bb14bcb593fa52102051 Author: Sebastian Andrzej Siewior AuthorDate: Wed, 17 Oct 2018 19:05:53 +0200 Committer: Borislav Petkov CommitDate: Thu, 18 Oct 2018 00:05:04 +0200

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell wrote: > Cc: Arnd Bergmann > Co-developed-by: Arnd Bergmann > Signed-off-by: Anders Roxell This should have Arnd's Signed-off-by: as well.

Re: [PATCH 1/2] serial: set suppress_bind_attrs flag only if builtin

2018-10-17 Thread Andrew Morton
On Wed, 17 Oct 2018 16:03:10 +0200 Anders Roxell wrote: > Cc: Arnd Bergmann > Co-developed-by: Arnd Bergmann > Signed-off-by: Anders Roxell This should have Arnd's Signed-off-by: as well.

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Alex Williamson
On Wed, 17 Oct 2018 17:15:33 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > > This patch adds a 4-byte reserved field in the structure > > vfio_eeh_pe_op to make sure that the u64 fields in the structure > > vfio_eeh_pe_err are 8-byte aligned.

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Alex Williamson
On Wed, 17 Oct 2018 17:15:33 -0400 Konrad Rzeszutek Wilk wrote: > On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > > This patch adds a 4-byte reserved field in the structure > > vfio_eeh_pe_op to make sure that the u64 fields in the structure > > vfio_eeh_pe_err are 8-byte aligned.

Re: [PATCH v4 2/4] perf: add arm64 smmuv3 pmu driver

2018-10-17 Thread kbuild test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19-rc8 next-20181017] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v4 2/4] perf: add arm64 smmuv3 pmu driver

2018-10-17 Thread kbuild test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19-rc8 next-20181017] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

linux-next: build warning after merge of the clk tree

2018-10-17 Thread Stephen Rothwell
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o see include/linux/module.h for more information Introduced by commit f2a76a2955c0 ("clk: qcom: Add Global

linux-next: build warning after merge of the clk tree

2018-10-17 Thread Stephen Rothwell
Hi all, After merging the clk tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/clk/qcom/gcc-sdm660.o see include/linux/module.h for more information Introduced by commit f2a76a2955c0 ("clk: qcom: Add Global

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-17 Thread Atish Patra
On 10/17/18 8:58 AM, Rob Herring wrote: On Tue, Oct 16, 2018 at 03:20:34PM -0700, Atish Patra wrote: On 10/16/18 3:04 PM, Thierry Reding wrote: On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: On 10/16/18 4:01 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:57:35PM -0700,

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-17 Thread Atish Patra
On 10/17/18 8:58 AM, Rob Herring wrote: On Tue, Oct 16, 2018 at 03:20:34PM -0700, Atish Patra wrote: On 10/16/18 3:04 PM, Thierry Reding wrote: On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: On 10/16/18 4:01 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:57:35PM -0700,

[PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together into the late init. Additionally cleans up the reporting to be more clear. Signed-off-by: Kees Cook ---

[PATCH] pstore: Refactor compression initialization

2018-10-17 Thread Kees Cook
With compression initialization now separated from pstore_register(), there is no longer a good reason to do compression method selection during fs init. Instead, merge everything together into the late init. Additionally cleans up the reporting to be more clear. Signed-off-by: Kees Cook ---

Re: [PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement

2018-10-17 Thread Marcel Ziswiler
On Wed, 2018-10-17 at 20:16 +0100, Mark Brown wrote: > On Wed, Oct 17, 2018 at 02:28:22PM +, Marcel Ziswiler wrote: > > > Some questions: > > - How exactly are devm allocations supposed to work concerning > > probe > > deferrals? > > Probe deferrals are just normal probe errors, any devm_

Re: [PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement

2018-10-17 Thread Marcel Ziswiler
On Wed, 2018-10-17 at 20:16 +0100, Mark Brown wrote: > On Wed, Oct 17, 2018 at 02:28:22PM +, Marcel Ziswiler wrote: > > > Some questions: > > - How exactly are devm allocations supposed to work concerning > > probe > > deferrals? > > Probe deferrals are just normal probe errors, any devm_

[PATCH 1/2] gpio: gpio-mmio: Allow volatile shadow regs

2018-10-17 Thread Kun Yi
Currently the generic GPIO driver stores the direction and data shadow register when the driver probes. However, in embedded SOCs the GPIO pins are often interleaved with pins muxed to other functions, and pinctrl driver might toggle the direction/data register values for these pins. With GPIO

[PATCH 0/2] Allow gpio-mmio to co-exist with pinctrl driver

2018-10-17 Thread Kun Yi
This patchset is to resolve an issue found with Nuvoton pinctrl driver when it uses a generic GPIO interface. Since the generic GPIO driver stores the bgpio_data and bgpio_dir shadow register values and later on modify based on the stored values, any change to the pin states in between by the

[PATCH 1/2] gpio: gpio-mmio: Allow volatile shadow regs

2018-10-17 Thread Kun Yi
Currently the generic GPIO driver stores the direction and data shadow register when the driver probes. However, in embedded SOCs the GPIO pins are often interleaved with pins muxed to other functions, and pinctrl driver might toggle the direction/data register values for these pins. With GPIO

[PATCH 0/2] Allow gpio-mmio to co-exist with pinctrl driver

2018-10-17 Thread Kun Yi
This patchset is to resolve an issue found with Nuvoton pinctrl driver when it uses a generic GPIO interface. Since the generic GPIO driver stores the bgpio_data and bgpio_dir shadow register values and later on modify based on the stored values, any change to the pin states in between by the

[PATCH 2/2] pinctrl: pinctrl-npcm7xx: Set BGPIOF_VOLATILE_REG

2018-10-17 Thread Kun Yi
Indicate that the pins are both controlled by the pinctrl driver and the generic GPIO driver, thus GPIO driver should read the register value before updating, instead of using the stored shadow register values. Signed-off-by: Kun Yi --- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 3 ++- 1 file

Re: [PATCH v4 01/18] of: overlay: add tests to validate kfrees from overlay removal

2018-10-17 Thread Alan Tull
On Mon, Oct 15, 2018 at 9:39 PM wrote: Hi Frank, > > From: Frank Rowand > > Add checks: > - attempted kfree due to refcount reaching zero before overlay > is removed > - properties linked to an overlay node when the node is removed > - node refcount > one during node removal in a

[PATCH 2/2] pinctrl: pinctrl-npcm7xx: Set BGPIOF_VOLATILE_REG

2018-10-17 Thread Kun Yi
Indicate that the pins are both controlled by the pinctrl driver and the generic GPIO driver, thus GPIO driver should read the register value before updating, instead of using the stored shadow register values. Signed-off-by: Kun Yi --- drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 3 ++- 1 file

Re: [PATCH v4 01/18] of: overlay: add tests to validate kfrees from overlay removal

2018-10-17 Thread Alan Tull
On Mon, Oct 15, 2018 at 9:39 PM wrote: Hi Frank, > > From: Frank Rowand > > Add checks: > - attempted kfree due to refcount reaching zero before overlay > is removed > - properties linked to an overlay node when the node is removed > - node refcount > one during node removal in a

Re: [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration [ver #12]

2018-10-17 Thread David Howells
Alan Jenkins wrote: > static int do_remount > (struct path > *path > , int ms_flags, int > sb_flags, > int

Re: [PATCH 31/34] vfs: syscall: Add fspick() to select a superblock for reconfiguration [ver #12]

2018-10-17 Thread David Howells
Alan Jenkins wrote: > static int do_remount > (struct path > *path > , int ms_flags, int > sb_flags, > int

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > > > I think this is interesting to groups doing automated testing of the kernel > > (including myself)

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > > > I think this is interesting to groups doing automated testing of the kernel > > (including myself)

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Konrad Rzeszutek Wilk
On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. Won't this break 32-bit kernels? That is the size of the structure will

Re: [PATCH] drivers/vfio: Fix an 8-byte alignment issue

2018-10-17 Thread Konrad Rzeszutek Wilk
On Wed, Oct 17, 2018 at 01:18:19PM -0500, Wenwen Wang wrote: > This patch adds a 4-byte reserved field in the structure > vfio_eeh_pe_op to make sure that the u64 fields in the structure > vfio_eeh_pe_err are 8-byte aligned. Won't this break 32-bit kernels? That is the size of the structure will

Re: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Brendan Higgins
On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > I think this is interesting to groups doing automated testing of the kernel > (including myself) as another set of tests to run. Right now I don't see it > as having

Re: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Brendan Higgins
On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > I think this is interesting to groups doing automated testing of the kernel > (including myself) as another set of tests to run. Right now I don't see it > as having

Re: [PATCH 1/2] locking/qspinlock_stat: Count instances of nested lock slowpaths

2018-10-17 Thread Waiman Long
On 10/17/2018 03:38 AM, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 09:45:06AM -0400, Waiman Long wrote: >> Queued spinlock supports up to 4 levels of lock slowpath nesting - >> user context, soft IRQ, hard IRQ and NMI. However, we are not sure how >> often the nesting happens. So 3 more

Re: [PATCH 1/2] locking/qspinlock_stat: Count instances of nested lock slowpaths

2018-10-17 Thread Waiman Long
On 10/17/2018 03:38 AM, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 09:45:06AM -0400, Waiman Long wrote: >> Queued spinlock supports up to 4 levels of lock slowpath nesting - >> user context, soft IRQ, hard IRQ and NMI. However, we are not sure how >> often the nesting happens. So 3 more

[PATCH 2/3] staging: emxx_udc: Added missing __iomem modifier to handle p_regs

2018-10-17 Thread Carmeli Tamir
Since in nbu2ss_drv_probe() p_regs is assigned from mmio_base, which is marked as __iomem, p_regs also should be market with __iomem. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 44 ++--- drivers/staging/emxx_udc/emxx_udc.h | 2 +- 2

[PATCH 3/3] staging: emxx_udc: Added missing le16_to_cpu conversions

2018-10-17 Thread Carmeli Tamir
Fixed sparse tool warnings due to missing convesion from le16 to cpu endienness. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 2/3] staging: emxx_udc: Added missing __iomem modifier to handle p_regs

2018-10-17 Thread Carmeli Tamir
Since in nbu2ss_drv_probe() p_regs is assigned from mmio_base, which is marked as __iomem, p_regs also should be market with __iomem. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 44 ++--- drivers/staging/emxx_udc/emxx_udc.h | 2 +- 2

[PATCH 3/3] staging: emxx_udc: Added missing le16_to_cpu conversions

2018-10-17 Thread Carmeli Tamir
Fixed sparse tool warnings due to missing convesion from le16 to cpu endienness. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

2018-10-17 Thread Carmeli Tamir
Added static modifier to the udc_controller, since it's only required within emxx_udc.c. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

2018-10-17 Thread Carmeli Tamir
Added static modifier to the udc_controller, since it's only required within emxx_udc.c. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Andy had some concerns about using regs_get_kernel_stack_nth() in a new function regs_get_kernel_argument() as if there's any error in the stack code, it could cause a bad memory access. To be on the safe side, call probe_kernel_read() on the stack address to be

[PATCH v2] x86: ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

2018-10-17 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Andy had some concerns about using regs_get_kernel_stack_nth() in a new function regs_get_kernel_argument() as if there's any error in the stack code, it could cause a bad memory access. To be on the safe side, call probe_kernel_read() on the stack address to be

Re: [PATCH v1 1/5] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:29 PM, Jon Hunter wrote: > > On 17/10/2018 15:43, Dmitry Osipenko wrote: >> On 10/17/18 5:14 PM, Jon Hunter wrote: >>> >>> On 17/10/2018 14:46, Dmitry Osipenko wrote: On 10/17/18 4:34 PM, Jon Hunter wrote: > > On 17/10/2018 14:07, Dmitry Osipenko wrote: >> On

Re: [PATCH v1 1/5] dt-bindings: cpufreq: Add binding for NVIDIA Tegra20/30

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:29 PM, Jon Hunter wrote: > > On 17/10/2018 15:43, Dmitry Osipenko wrote: >> On 10/17/18 5:14 PM, Jon Hunter wrote: >>> >>> On 17/10/2018 14:46, Dmitry Osipenko wrote: On 10/17/18 4:34 PM, Jon Hunter wrote: > > On 17/10/2018 14:07, Dmitry Osipenko wrote: >> On

Re: [PATCH] spi: pxa2xx: fix PCI dependency

2018-10-17 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Oct 17, 2018 at 8:52 PM Arnd Bergmann wrote: > The code reorganization broke building without CONFIG_PCI: > > drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_init_pdata': > drivers/spi/spi-pxa2xx.c:1457:15: error: implicit declaration of function > 'pci_match_id'; did you

Re: [PATCH] spi: pxa2xx: fix PCI dependency

2018-10-17 Thread Geert Uytterhoeven
Hi Arnd, On Wed, Oct 17, 2018 at 8:52 PM Arnd Bergmann wrote: > The code reorganization broke building without CONFIG_PCI: > > drivers/spi/spi-pxa2xx.c: In function 'pxa2xx_spi_init_pdata': > drivers/spi/spi-pxa2xx.c:1457:15: error: implicit declaration of function > 'pci_match_id'; did you

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:41 PM, Jon Hunter wrote: > > On 17/10/2018 15:30, Dmitry Osipenko wrote: >> On 10/17/18 4:59 PM, Jon Hunter wrote: >>> >>> On 13/05/2018 22:13, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in

Re: [PATCH v1] i2c: tegra: Remove suspend-resume

2018-10-17 Thread Dmitry Osipenko
On 10/17/18 10:41 PM, Jon Hunter wrote: > > On 17/10/2018 15:30, Dmitry Osipenko wrote: >> On 10/17/18 4:59 PM, Jon Hunter wrote: >>> >>> On 13/05/2018 22:13, Dmitry Osipenko wrote: Nothing prevents I2C clients to access I2C while Tegra's driver is being suspended, this results in

Re: [PATCH v13 12/12] selftests/livepatch: introduce tests

2018-10-17 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 02:37:13PM +0200, Petr Mladek wrote: > From: Joe Lawrence > > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against: > > - basic livepatching (multiple patches, atomic replace) > - pre/post (un)patch

Re: [PATCH v13 12/12] selftests/livepatch: introduce tests

2018-10-17 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 02:37:13PM +0200, Petr Mladek wrote: > From: Joe Lawrence > > Add a few livepatch modules and simple target modules that the included > regression suite can run tests against: > > - basic livepatching (multiple patches, atomic replace) > - pre/post (un)patch

Re: [PATCH v13 09/12] livepatch: Remove Nop structures when unused

2018-10-17 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 02:37:10PM +0200, Petr Mladek wrote: > +void klp_discard_replaced_stuff(struct klp_patch *new_patch) > +{ > + klp_discard_replaced_patches(new_patch); > + klp_discard_nops(new_patch); > +} > + > +/* Stuff? Really? :-) How about klp_discard_replaced()? -- Josh

Re: [PATCH v13 09/12] livepatch: Remove Nop structures when unused

2018-10-17 Thread Josh Poimboeuf
On Mon, Oct 15, 2018 at 02:37:10PM +0200, Petr Mladek wrote: > +void klp_discard_replaced_stuff(struct klp_patch *new_patch) > +{ > + klp_discard_replaced_patches(new_patch); > + klp_discard_nops(new_patch); > +} > + > +/* Stuff? Really? :-) How about klp_discard_replaced()? -- Josh

Re: [PATCH] selftests/ftrace: Strip escape sequences for log file

2018-10-17 Thread Steven Rostedt
On Wed, 17 Oct 2018 12:33:23 +0900 Masami Hiramatsu wrote: > Strip escape sequences from the stream to the ftracetest > summary log file. Note that all test-case results are > dumped raw in each file. > Acked-by: Steven Rostedt (VMware) Shuah, Please take this one too. Thanks! -- Steve

Re: [PATCH] selftests/ftrace: Strip escape sequences for log file

2018-10-17 Thread Steven Rostedt
On Wed, 17 Oct 2018 12:33:23 +0900 Masami Hiramatsu wrote: > Strip escape sequences from the stream to the ftracetest > summary log file. Note that all test-case results are > dumped raw in each file. > Acked-by: Steven Rostedt (VMware) Shuah, Please take this one too. Thanks! -- Steve

Re: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Rob Herring
On Tue, Oct 16, 2018 at 6:53 PM Brendan Higgins wrote: > > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > Unlike Autotest and kselftest, KUnit is a true unit testing framework; > it does not require installing the kernel on a test

Re: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Rob Herring
On Tue, Oct 16, 2018 at 6:53 PM Brendan Higgins wrote: > > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > Unlike Autotest and kselftest, KUnit is a true unit testing framework; > it does not require installing the kernel on a test

<    1   2   3   4   5   6   7   8   9   10   >