Re: [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag

2018-10-19 Thread Andreas Dilger
On Oct 19, 2018, at 11:42 AM, Miklos Szeredi wrote: >>> +#define STATX_RESULT_MASK STATX__RESERVED >> >> Please don't use that bit. > > Using it internally is perfectly harmless. If we'll need to extend > statx in the future and make use of this flag externally, then we can > easily move the

Re: [PATCH v2 6/5] statx: add STATX_RESULT_MASK flag

2018-10-19 Thread Andreas Dilger
On Oct 19, 2018, at 11:42 AM, Miklos Szeredi wrote: >>> +#define STATX_RESULT_MASK STATX__RESERVED >> >> Please don't use that bit. > > Using it internally is perfectly harmless. If we'll need to extend > statx in the future and make use of this flag externally, then we can > easily move the

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-10-19 Thread Joel Fernandes
On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: > Hi, > > This patch series adds Event tracing support to pstore and is continuation > to the RFC patch introduced to add a new tracing facility for register > accesses called Register Trace Buffer(RTB). Since we decided to not

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-10-19 Thread Joel Fernandes
On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: > Hi, > > This patch series adds Event tracing support to pstore and is continuation > to the RFC patch introduced to add a new tracing facility for register > accesses called Register Trace Buffer(RTB). Since we decided to not

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread Al Viro
On Fri, Oct 19, 2018 at 11:36:19PM +0100, David Howells wrote: > Alan Jenkins wrote: > > > # open_tree_clone 3 > # cd /proc/self/fd/3 > > # mount --move . /mnt > > [ 41.747831] mnt_flags=1020 umount=0 > > # cd / > > # umount /mnt > > umount: /mnt: target is busy > > > > ^ a newly introduced

Re: [PATCH 03/34] teach move_mount(2) to work with OPEN_TREE_CLONE [ver #12]

2018-10-19 Thread Al Viro
On Fri, Oct 19, 2018 at 11:36:19PM +0100, David Howells wrote: > Alan Jenkins wrote: > > > # open_tree_clone 3 > # cd /proc/self/fd/3 > > # mount --move . /mnt > > [ 41.747831] mnt_flags=1020 umount=0 > > # cd / > > # umount /mnt > > umount: /mnt: target is busy > > > > ^ a newly introduced

Re: [PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:59AM +0100, David Howells wrote: > @@ -1060,6 +1074,9 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll) > } > unroll -= i->iov_offset; > switch (iov_iter_type(i)) { > + case ITER_DISCARD: > + i->iov_offset = 0; > +

Re: [PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:59AM +0100, David Howells wrote: > @@ -1060,6 +1074,9 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll) > } > unroll -= i->iov_offset; > switch (iov_iter_type(i)) { > + case ITER_DISCARD: > + i->iov_offset = 0; > +

Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote: > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > them more efficient in a switch-statement. Are you sure that they *are* more efficient that way? Some of those paths are fairly hot, so much that I would

Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote: > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > them more efficient in a switch-statement. Are you sure that they *are* more efficient that way? Some of those paths are fairly hot, so much that I would

Re: [PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:44AM +0100, David Howells wrote: One general comment: I would strongly recommend splitting the iov_iter initializers change into a separate patch. > index 8d41ca7bfcf1..dcdbcb6f09f8 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -2990,7 +2990,7 @@

Re: [PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:44AM +0100, David Howells wrote: One general comment: I would strongly recommend splitting the iov_iter initializers change into a separate patch. > index 8d41ca7bfcf1..dcdbcb6f09f8 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -2990,7 +2990,7 @@

Re: [PATCH v4 2/4] perf: add arm64 smmuv3 pmu driver

2018-10-19 Thread kbuild test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH v4 2/4] perf: add arm64 smmuv3 pmu driver

2018-10-19 Thread kbuild test robot
Hi Neil, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux-sof-driver/master] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: perf overlapping maps...

2018-10-19 Thread David Miller
From: David Miller Date: Fri, 19 Oct 2018 21:05:49 -0700 (PDT) > One solution I've come up with is: > > 1) When synthesizing a fork event, set PERF_RECORD_MISC_COMM_EXEC in >header->misc. > > 2) Use this to elide the map groups clone in >thread__clone_map_groups(). Looking into code

Re: perf overlapping maps...

2018-10-19 Thread David Miller
From: David Miller Date: Fri, 19 Oct 2018 21:05:49 -0700 (PDT) > One solution I've come up with is: > > 1) When synthesizing a fork event, set PERF_RECORD_MISC_COMM_EXEC in >header->misc. > > 2) Use this to elide the map groups clone in >thread__clone_map_groups(). Looking into code

perf overlapping maps...

2018-10-19 Thread David Miller
Symbols aren't exactly right all the time on sparc and even the owner of a sample is set to "unknown" from time to time so I turned on some debugging to investigate. One thing that stands out is that we get overlapping maps all the time. So I tried to narrow down how this happens. Here is one

perf overlapping maps...

2018-10-19 Thread David Miller
Symbols aren't exactly right all the time on sparc and even the owner of a sample is set to "unknown" from time to time so I turned on some debugging to investigate. One thing that stands out is that we get overlapping maps all the time. So I tried to narrow down how this happens. Here is one

[tip:locking/core 6/10] arch/x86/include/asm/rmwcc.h:23:17: error: jump into statement expression

2018-10-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core head: 01a14bda11add9dcd4a59200f13834d634559935 commit: 7aa54be2976550f17c11a1c3e3630002dea39303 [6/10] locking/qspinlock, x86: Provide liveness guarantee config: x86_64-randconfig-u0-10201040 (attached as .config)

[tip:locking/core 6/10] arch/x86/include/asm/rmwcc.h:23:17: error: jump into statement expression

2018-10-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core head: 01a14bda11add9dcd4a59200f13834d634559935 commit: 7aa54be2976550f17c11a1c3e3630002dea39303 [6/10] locking/qspinlock, x86: Provide liveness guarantee config: x86_64-randconfig-u0-10201040 (attached as .config)

Second attempt to reach you: URGENT

2018-10-19 Thread Kelvin Cord
Hello, I'm Kelvin Cord, with First City Monument Bank here in Nigeria. I was wondering if you received my last email. I sincerely seek to present you as the Next of Kin to a late client who left behind ($170 Million USD) in a fixed deposit account in my bank before his demise. The British

Second attempt to reach you: URGENT

2018-10-19 Thread Kelvin Cord
Hello, I'm Kelvin Cord, with First City Monument Bank here in Nigeria. I was wondering if you received my last email. I sincerely seek to present you as the Next of Kin to a late client who left behind ($170 Million USD) in a fixed deposit account in my bank before his demise. The British

[PATCH v2 1/1] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
From: Dong Aisheng CAN transceiver is different on RevA and RevB board. It's active high on RevA while active low on Rev B. Signed-off-by: Dong Aisheng Signed-off-by: Joakim Zhang --- arch/arm/boot/dts/imx6sx-sdb-reva.dts | 12 arch/arm/boot/dts/imx6sx-sdb.dts | 5

[PATCH v2 1/1] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
From: Dong Aisheng CAN transceiver is different on RevA and RevB board. It's active high on RevA while active low on Rev B. Signed-off-by: Dong Aisheng Signed-off-by: Joakim Zhang --- arch/arm/boot/dts/imx6sx-sdb-reva.dts | 12 arch/arm/boot/dts/imx6sx-sdb.dts | 5

RE: [PATCH] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
-Original Message- From: Fabio Estevam [mailto:feste...@gmail.com] Sent: 2018年10月19日 20:52 To: Joakim Zhang Cc: Shawn Guo ; Sascha Hauer ; Sascha Hauer ; Fabio Estevam ; dl-linux-imx ; Rob Herring ; Mark Rutland ; A.s. Dong ; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE

RE: [PATCH] ARM: dts: imx6sx-sdb: Add flexcan support

2018-10-19 Thread Joakim Zhang
-Original Message- From: Fabio Estevam [mailto:feste...@gmail.com] Sent: 2018年10月19日 20:52 To: Joakim Zhang Cc: Shawn Guo ; Sascha Hauer ; Sascha Hauer ; Fabio Estevam ; dl-linux-imx ; Rob Herring ; Mark Rutland ; A.s. Dong ; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2018-10-19 Thread Moritz Fischer
On Fri, Oct 19, 2018 at 2:33 PM Moritz Fischer wrote: > > Hi Nava, > > Looks good to me, a couple of nits inline below. > > On Fri, Oct 19, 2018 at 1:50 AM Nava kishore Manne > wrote: > > > > This patch adds FPGA Manager support for the Xilinx > > ZynqMp chip. > > Isn't it ZynqMP ? > > > >

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2018-10-19 Thread Moritz Fischer
On Fri, Oct 19, 2018 at 2:33 PM Moritz Fischer wrote: > > Hi Nava, > > Looks good to me, a couple of nits inline below. > > On Fri, Oct 19, 2018 at 1:50 AM Nava kishore Manne > wrote: > > > > This patch adds FPGA Manager support for the Xilinx > > ZynqMp chip. > > Isn't it ZynqMP ? > > > >

[PATCH 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to accept unsigned modifier for its field type correctly. Currently, synthetic_events interface returns error for "unsigned" modifiers as below; # echo "myevent unsigned long var" >> synthetic_events sh: write error: Invalid argument This is

[PATCH 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Add a testcase to check the syntax and field types for synthetic_events interface. Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox Acked-by: Shuah Khan Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) ---

[PATCH 1/3] tracing: Fix synthetic event to accept unsigned modifier

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to accept unsigned modifier for its field type correctly. Currently, synthetic_events interface returns error for "unsigned" modifiers as below; # echo "myevent unsigned long var" >> synthetic_events sh: write error: Invalid argument This is

[PATCH 3/3] selftests: ftrace: Add synthetic event syntax testcase

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Add a testcase to check the syntax and field types for synthetic_events interface. Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox Acked-by: Shuah Khan Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) ---

[PATCH 2/3] tracing: Fix synthetic event to allow semicolon at end

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to allow independent semicolon at end. The synthetic_events interface accepts a semicolon after the last word if there is no space. # echo "myevent u64 var;" >> synthetic_events But if there is a space, it returns an error. # echo "myevent u64 var

[PATCH 0/3] [GIT PULL] tracing: A few small fixes to synthetic events

2018-10-19 Thread Steven Rostedt
Linus (aka Greg), Masami found some issues with the creation of synthetic events. The first two patches fix handling of unsigned type, and handling of a space before an ending semi-colon. The third patch adds a selftest to test the processing of synthetic events. Please pull the latest

[PATCH 0/3] [GIT PULL] tracing: A few small fixes to synthetic events

2018-10-19 Thread Steven Rostedt
Linus (aka Greg), Masami found some issues with the creation of synthetic events. The first two patches fix handling of unsigned type, and handling of a space before an ending semi-colon. The third patch adds a selftest to test the processing of synthetic events. Please pull the latest

[PATCH 2/3] tracing: Fix synthetic event to allow semicolon at end

2018-10-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix synthetic event to allow independent semicolon at end. The synthetic_events interface accepts a semicolon after the last word if there is no space. # echo "myevent u64 var;" >> synthetic_events But if there is a space, it returns an error. # echo "myevent u64 var

Re: [RFC PATCH 1/5] x86: introduce preemption disable prefix

2018-10-19 Thread Masami Hiramatsu
On Fri, 19 Oct 2018 04:44:33 + Nadav Amit wrote: > at 9:29 PM, Andy Lutomirski wrote: > > >> On Oct 18, 2018, at 6:08 PM, Nadav Amit wrote: > >> > >> at 10:00 AM, Andy Lutomirski wrote: > >> > On Oct 18, 2018, at 9:47 AM, Nadav Amit wrote: > > at 8:51 PM, Andy

Re: [RFC PATCH 1/5] x86: introduce preemption disable prefix

2018-10-19 Thread Masami Hiramatsu
On Fri, 19 Oct 2018 04:44:33 + Nadav Amit wrote: > at 9:29 PM, Andy Lutomirski wrote: > > >> On Oct 18, 2018, at 6:08 PM, Nadav Amit wrote: > >> > >> at 10:00 AM, Andy Lutomirski wrote: > >> > On Oct 18, 2018, at 9:47 AM, Nadav Amit wrote: > > at 8:51 PM, Andy

Re: [PATCH v7 00/21] tpm: separate tpm 1.x and tpm 2.x commands

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: This patch series provides initial separation of tpm 1.x and tpm 2.x commands, in foresight that the tpm 1.x chips will eventually phase out and can be compiled out for modern systems. A new file is added tpm1-cmd.c that contains tpm 1.x specific

Re: [PATCH v7 00/21] tpm: separate tpm 1.x and tpm 2.x commands

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: This patch series provides initial separation of tpm 1.x and tpm 2.x commands, in foresight that the tpm 1.x chips will eventually phase out and can be compiled out for modern systems. A new file is added tpm1-cmd.c that contains tpm 1.x specific

[PATCH 24/24] afs: Probe multiple fileservers simultaneously

2018-10-19 Thread David Howells
Send probes to all the unprobed fileservers in a fileserver list on all addresses simultaneously in an attempt to find out the fastest route whilst not getting stuck for 20s on any server or address that we don't get a reply from. This alleviates the problem whereby attempting to access a new

[PATCH 24/24] afs: Probe multiple fileservers simultaneously

2018-10-19 Thread David Howells
Send probes to all the unprobed fileservers in a fileserver list on all addresses simultaneously in an attempt to find out the fastest route whilst not getting stuck for 20s on any server or address that we don't get a reply from. This alleviates the problem whereby attempting to access a new

[PATCH 18/24] afs: Get the target vnode in afs_rmdir() and get a callback on it

2018-10-19 Thread David Howells
Get the target vnode in afs_rmdir() and validate it before we attempt the deletion, The vnode pointer will be passed through to the delivery function in a later patch so that the delivery function can mark it deleted. Signed-off-by: David Howells --- fs/afs/dir.c | 11 ++- 1 file

[PATCH 17/24] afs: Calc callback expiry in op reply delivery

2018-10-19 Thread David Howells
Calculate the callback expiration time at the point of operation reply delivery, using the reply time queried from AF_RXRPC on that call as a base. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/fsclient.c | 22 +- fs/afs/inode.c|4 ++--

[PATCH 19/24] afs: Expand data structure fields to support YFS

2018-10-19 Thread David Howells
Expand fields in various data structures to support the expanded information that YFS is capable of returning. Signed-off-by: David Howells --- fs/afs/afs.h | 35 ++- fs/afs/fsclient.c |9 + 2 files changed, 23 insertions(+), 21 deletions(-)

[PATCH 21/24] afs: Allow dumping of server cursor on operation failure

2018-10-19 Thread David Howells
Provide an option to allow the file or volume location server cursor to be dumped if the rotation routine falls off the end without managing to contact a server. Signed-off-by: David Howells --- fs/afs/Kconfig | 12 +++ fs/afs/addr_list.c |2 ++ fs/afs/internal.h |3 +++

[PATCH 18/24] afs: Get the target vnode in afs_rmdir() and get a callback on it

2018-10-19 Thread David Howells
Get the target vnode in afs_rmdir() and validate it before we attempt the deletion, The vnode pointer will be passed through to the delivery function in a later patch so that the delivery function can mark it deleted. Signed-off-by: David Howells --- fs/afs/dir.c | 11 ++- 1 file

[PATCH 17/24] afs: Calc callback expiry in op reply delivery

2018-10-19 Thread David Howells
Calculate the callback expiration time at the point of operation reply delivery, using the reply time queried from AF_RXRPC on that call as a base. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/fsclient.c | 22 +- fs/afs/inode.c|4 ++--

[PATCH 19/24] afs: Expand data structure fields to support YFS

2018-10-19 Thread David Howells
Expand fields in various data structures to support the expanded information that YFS is capable of returning. Signed-off-by: David Howells --- fs/afs/afs.h | 35 ++- fs/afs/fsclient.c |9 + 2 files changed, 23 insertions(+), 21 deletions(-)

[PATCH 21/24] afs: Allow dumping of server cursor on operation failure

2018-10-19 Thread David Howells
Provide an option to allow the file or volume location server cursor to be dumped if the rotation routine falls off the end without managing to contact a server. Signed-off-by: David Howells --- fs/afs/Kconfig | 12 +++ fs/afs/addr_list.c |2 ++ fs/afs/internal.h |3 +++

[PATCH 15/24] afs: Implement the YFS cache manager service

2018-10-19 Thread David Howells
Implement the YFS cache manager service which gives extra capabilities on top of AFS. This is done by listening for an additional service on the same port and indicating that anyone requesting an upgrade should be upgraded to the YFS port. Signed-off-by: David Howells --- fs/afs/cmservice.c

[PATCH 15/24] afs: Implement the YFS cache manager service

2018-10-19 Thread David Howells
Implement the YFS cache manager service which gives extra capabilities on top of AFS. This is done by listening for an additional service on the same port and indicating that anyone requesting an upgrade should be upgraded to the YFS port. Signed-off-by: David Howells --- fs/afs/cmservice.c

[PATCH 22/24] afs: Eliminate the address pointer from the address list cursor

2018-10-19 Thread David Howells
Eliminate the address pointer from the address list cursor as it's redundant (ac->addrs[ac->index] can be used to find the same address) and address lists must be replaced rather than being rearranged, so is of limited value. Signed-off-by: David Howells --- fs/afs/addr_list.c |2 --

[PATCH 23/24] afs: Fix callback handling

2018-10-19 Thread David Howells
In some circumstances, the callback interest pointer is NULL, so in such a case we can't dereference it when checking to see if the callback is broken. This causes an oops in some circumstances. Fix this by replacing the function that worked out the aggregate break counter with one that actually

[PATCH 20/24] afs: Implement YFS support in the fs client

2018-10-19 Thread David Howells
Implement support for talking to YFS-variant fileservers in the cache manager and the filesystem client. These implement upgraded services on the same port as their AFS services. YFS fileservers provide expanded capabilities over AFS. Signed-off-by: David Howells --- fs/afs/Makefile

[PATCH 16/24] afs: Fix FS.FetchStatus delivery from updating wrong vnode

2018-10-19 Thread David Howells
The FS.FetchStatus reply delivery function was updating inode of the directory in which a lookup had been done with the status of the looked up file. This corrupts some of the directory state. Fixes: 5cf9dd55a0ec ("afs: Prospectively look up extra files when doing a single lookup")

[PATCH 22/24] afs: Eliminate the address pointer from the address list cursor

2018-10-19 Thread David Howells
Eliminate the address pointer from the address list cursor as it's redundant (ac->addrs[ac->index] can be used to find the same address) and address lists must be replaced rather than being rearranged, so is of limited value. Signed-off-by: David Howells --- fs/afs/addr_list.c |2 --

[PATCH 23/24] afs: Fix callback handling

2018-10-19 Thread David Howells
In some circumstances, the callback interest pointer is NULL, so in such a case we can't dereference it when checking to see if the callback is broken. This causes an oops in some circumstances. Fix this by replacing the function that worked out the aggregate break counter with one that actually

[PATCH 20/24] afs: Implement YFS support in the fs client

2018-10-19 Thread David Howells
Implement support for talking to YFS-variant fileservers in the cache manager and the filesystem client. These implement upgraded services on the same port as their AFS services. YFS fileservers provide expanded capabilities over AFS. Signed-off-by: David Howells --- fs/afs/Makefile

[PATCH 16/24] afs: Fix FS.FetchStatus delivery from updating wrong vnode

2018-10-19 Thread David Howells
The FS.FetchStatus reply delivery function was updating inode of the directory in which a lookup had been done with the status of the looked up file. This corrupts some of the directory state. Fixes: 5cf9dd55a0ec ("afs: Prospectively look up extra files when doing a single lookup")

[PATCH 11/24] afs: Don't invoke the server to read data beyond EOF

2018-10-19 Thread David Howells
When writing a new page, clear space in the page rather than attempting to load it from the server if the space is beyond the EOF. Signed-off-by: David Howells --- fs/afs/write.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/afs/write.c b/fs/afs/write.c index

[PATCH 13/24] afs: Commit the status on a new file/dir/symlink

2018-10-19 Thread David Howells
Call the function to commit the status on a new file, dir or symlink so that the access rights for the caller's key are cached for that object. Without this, the next access to the file will cause a FetchStatus operation to be emitted to retrieve the access rights. Signed-off-by: David Howells

[PATCH 12/24] afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS

2018-10-19 Thread David Howells
Increase the sizes of the volume ID to 64 bits and the vnode ID (inode number equivalent) to 96 bits to allow the support of YFS. This requires the iget comparator to check the vnode->fid rather than i_ino and i_generation as i_ino is not sufficiently capacious. It also requires this data to be

[PATCH 11/24] afs: Don't invoke the server to read data beyond EOF

2018-10-19 Thread David Howells
When writing a new page, clear space in the page rather than attempting to load it from the server if the space is beyond the EOF. Signed-off-by: David Howells --- fs/afs/write.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fs/afs/write.c b/fs/afs/write.c index

[PATCH 13/24] afs: Commit the status on a new file/dir/symlink

2018-10-19 Thread David Howells
Call the function to commit the status on a new file, dir or symlink so that the access rights for the caller's key are cached for that object. Without this, the next access to the file will cause a FetchStatus operation to be emitted to retrieve the access rights. Signed-off-by: David Howells

[PATCH 12/24] afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS

2018-10-19 Thread David Howells
Increase the sizes of the volume ID to 64 bits and the vnode ID (inode number equivalent) to 96 bits to allow the support of YFS. This requires the iget comparator to check the vnode->fid rather than i_ino and i_generation as i_ino is not sufficiently capacious. It also requires this data to be

[PATCH 14/24] afs: Remove callback details from afs_callback_break struct

2018-10-19 Thread David Howells
Remove unnecessary details of a broken callback, such as version, expiry and type, from the afs_callback_break struct as they're not actually used and make the list take more memory. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/callback.c |8 ++--

[PATCH 14/24] afs: Remove callback details from afs_callback_break struct

2018-10-19 Thread David Howells
Remove unnecessary details of a broken callback, such as version, expiry and type, from the afs_callback_break struct as they're not actually used and make the list take more memory. Signed-off-by: David Howells --- fs/afs/afs.h |2 +- fs/afs/callback.c |8 ++--

[PATCH 08/24] afs: Fix TTL on VL server and address lists

2018-10-19 Thread David Howells
Currently the TTL on VL server and address lists isn't set in all circumstances and may be set to poor choices in others, since the TTL is derived from the SRV/AFSDB DNS record if and when available. Fix the TTL by limiting the range to a minimum and maximum from the current time. At some point

[PATCH 09/24] afs: Handle EIO from delivery function

2018-10-19 Thread David Howells
Fix afs_deliver_to_call() to handle -EIO being returned by the operation delivery function, indicating that the call found itself in the wrong state, by printing an error and aborting the call. Currently, an assertion failure will occur. This can happen, say, if the delivery function falls off

[PATCH 10/24] afs: Add a couple of tracepoints to log I/O errors

2018-10-19 Thread David Howells
Add a couple of tracepoints to log the production of I/O errors within the AFS filesystem. Signed-off-by: David Howells --- fs/afs/cmservice.c | 10 +++-- fs/afs/dir.c | 18 ++ fs/afs/internal.h | 11 ++ fs/afs/mntpt.c |5 ++-

[PATCH 08/24] afs: Fix TTL on VL server and address lists

2018-10-19 Thread David Howells
Currently the TTL on VL server and address lists isn't set in all circumstances and may be set to poor choices in others, since the TTL is derived from the SRV/AFSDB DNS record if and when available. Fix the TTL by limiting the range to a minimum and maximum from the current time. At some point

[PATCH 09/24] afs: Handle EIO from delivery function

2018-10-19 Thread David Howells
Fix afs_deliver_to_call() to handle -EIO being returned by the operation delivery function, indicating that the call found itself in the wrong state, by printing an error and aborting the call. Currently, an assertion failure will occur. This can happen, say, if the delivery function falls off

[PATCH 10/24] afs: Add a couple of tracepoints to log I/O errors

2018-10-19 Thread David Howells
Add a couple of tracepoints to log the production of I/O errors within the AFS filesystem. Signed-off-by: David Howells --- fs/afs/cmservice.c | 10 +++-- fs/afs/dir.c | 18 ++ fs/afs/internal.h | 11 ++ fs/afs/mntpt.c |5 ++-

[PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread David Howells
Add a new iterator, ITER_DISCARD, that can only be used in READ mode and just discards any data copied to it. This is useful in a network filesystem for discarding any unwanted data sent by a server. Signed-off-by: David Howells --- include/linux/uio.h |7 lib/iov_iter.c | 96

[PATCH 03/24] iov_iter: Add I/O discard iterator

2018-10-19 Thread David Howells
Add a new iterator, ITER_DISCARD, that can only be used in READ mode and just discards any data copied to it. This is useful in a network filesystem for discarding any unwanted data sent by a server. Signed-off-by: David Howells --- include/linux/uio.h |7 lib/iov_iter.c | 96

[PATCH 07/24] afs: Implement VL server rotation

2018-10-19 Thread David Howells
Track VL servers as independent entities rather than lumping all their addresses together into one set and implement server-level rotation by: (1) Add the concept of a VL server list, where each server has its own separate address list. This code is similar to the FS server list. (2) Use

[PATCH 05/24] afs: Set up the iov_iter before calling afs_extract_data()

2018-10-19 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A

[PATCH 05/24] afs: Set up the iov_iter before calling afs_extract_data()

2018-10-19 Thread David Howells
afs_extract_data sets up a temporary iov_iter and passes it to AF_RXRPC each time it is called to describe the remaining buffer to be filled. Instead: (1) Put an iterator in the afs_call struct. (2) Set the iterator for each marshalling stage to load data into the appropriate places. A

[PATCH 07/24] afs: Implement VL server rotation

2018-10-19 Thread David Howells
Track VL servers as independent entities rather than lumping all their addresses together into one set and implement server-level rotation by: (1) Add the concept of a VL server list, where each server has its own separate address list. This code is similar to the FS server list. (2) Use

[PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread David Howells
In the iov_iter struct, separate the iterator type from the iterator direction and use accessor functions to access them in most places. Convert a bunch of places to use switch-statements to access them rather then chains of bitwise-AND statements. This makes it easier to add further iterator

[PATCH 06/24] afs: Improve FS server rotation error handling

2018-10-19 Thread David Howells
Improve the error handling in FS server rotation by: (1) Cache the latest useful error value for the fs operation as a whole in struct afs_fs_cursor separately from the error cached in the afs_addr_cursor struct. The one in the address cursor gets clobbered occasionally. Copy

[PATCH 04/24] afs: Better tracing of protocol errors

2018-10-19 Thread David Howells
Include the site of detection of AFS protocol errors in trace lines to better be able to determine what went wrong. Signed-off-by: David Howells --- fs/afs/cmservice.c |6 ++ fs/afs/fsclient.c | 117 +++- fs/afs/inode.c

[PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread David Howells
Renumber the ITER_* constants in uio.h to be contiguous to make comparing them more efficient in a switch-statement. Signed-off-by: David Howells --- include/linux/uio.h |8 +++-- lib/iov_iter.c | 77 ++- 2 files changed, 62

[PATCH 00/24] AFS development

2018-10-19 Thread David Howells
Hi Al, Here's a set of development patches for AFS if you could pull it for the upcoming merge window. Its main features are: (1) Provide wrapper functions for accessing iov iterators, renumber the iterator types to be more amenable to switching on and provide a new read discard

[PATCH 04/24] afs: Better tracing of protocol errors

2018-10-19 Thread David Howells
Include the site of detection of AFS protocol errors in trace lines to better be able to determine what went wrong. Signed-off-by: David Howells --- fs/afs/cmservice.c |6 ++ fs/afs/fsclient.c | 117 +++- fs/afs/inode.c

[PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread David Howells
Renumber the ITER_* constants in uio.h to be contiguous to make comparing them more efficient in a switch-statement. Signed-off-by: David Howells --- include/linux/uio.h |8 +++-- lib/iov_iter.c | 77 ++- 2 files changed, 62

[PATCH 01/24] iov_iter: Separate type from direction and use accessor functions

2018-10-19 Thread David Howells
In the iov_iter struct, separate the iterator type from the iterator direction and use accessor functions to access them in most places. Convert a bunch of places to use switch-statements to access them rather then chains of bitwise-AND statements. This makes it easier to add further iterator

[PATCH 06/24] afs: Improve FS server rotation error handling

2018-10-19 Thread David Howells
Improve the error handling in FS server rotation by: (1) Cache the latest useful error value for the fs operation as a whole in struct afs_fs_cursor separately from the error cached in the afs_addr_cursor struct. The one in the address cursor gets clobbered occasionally. Copy

[PATCH 00/24] AFS development

2018-10-19 Thread David Howells
Hi Al, Here's a set of development patches for AFS if you could pull it for the upcoming merge window. Its main features are: (1) Provide wrapper functions for accessing iov iterators, renumber the iterator types to be more amenable to switching on and provide a new read discard

Re: [PATCH v7 13/21] tpm: add tpm_auto_startup() into tpm-interface.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Add wrapper tpm_auto_startup() to tpm-interface.c instead of open coded decision between TPM 1.x and TPM 2.x in tpm-chip.c Signed-off-by: Tomas Winkler Tested-by: Jarkko Sakkinen --- V3: New in the series. V4: Fix the commit message. V5-7: Resend.

Re: [PATCH v7 13/21] tpm: add tpm_auto_startup() into tpm-interface.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Add wrapper tpm_auto_startup() to tpm-interface.c instead of open coded decision between TPM 1.x and TPM 2.x in tpm-chip.c Signed-off-by: Tomas Winkler Tested-by: Jarkko Sakkinen --- V3: New in the series. V4: Fix the commit message. V5-7: Resend.

Re: [PATCH v7 12/21] tpm: factor out tpm_startup function

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: TPM manual startup is used only from within TPM 1.x or TPM 2.x code, hence remove tpm_startup() function from tpm-interface.c and add two static functions implementations tpm1_startup() and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively.

Re: [PATCH v7 12/21] tpm: factor out tpm_startup function

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: TPM manual startup is used only from within TPM 1.x or TPM 2.x code, hence remove tpm_startup() function from tpm-interface.c and add two static functions implementations tpm1_startup() and tpm2_startup() into to tpm1-cmd.c and tpm2-cmd.c respectively.

Re: [PATCH v7 11/21] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Factor out TPM 1.x suspend flow from tpm-interface.c into a new function tpm1_pm_suspend() in tpm1-cmd.c Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen I'll test this later. /Jarkko

Re: [PATCH] Documentation: dynamic-debug: fix wildcard description

2018-10-19 Thread Randy Dunlap
On 10/19/18 5:20 PM, Will Korteland wrote: > On 2018-10-20 00:16, Randy Dunlap wrote: >> -A another way is to use wildcard. The match rule support ``*`` (matches >> -zero or more characters) and ``?`` (matches exactly one character).For >> +A another way is to use wildcards. The match rule

Re: [PATCH v7 11/21] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c

2018-10-19 Thread Jarkko Sakkinen
On Fri, 19 Oct 2018, Tomas Winkler wrote: Factor out TPM 1.x suspend flow from tpm-interface.c into a new function tpm1_pm_suspend() in tpm1-cmd.c Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen I'll test this later. /Jarkko

Re: [PATCH] Documentation: dynamic-debug: fix wildcard description

2018-10-19 Thread Randy Dunlap
On 10/19/18 5:20 PM, Will Korteland wrote: > On 2018-10-20 00:16, Randy Dunlap wrote: >> -A another way is to use wildcard. The match rule support ``*`` (matches >> -zero or more characters) and ``?`` (matches exactly one character).For >> +A another way is to use wildcards. The match rule

Re: [PATCH 1/2] sched/fair: move rq_of helper function

2018-10-19 Thread kbuild test robot
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 1/2] sched/fair: move rq_of helper function

2018-10-19 Thread kbuild test robot
Hi Vincent, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.19-rc8 next-20181019] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

  1   2   3   4   5   6   7   8   9   10   >