Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-27 Thread Julia Lawall
On Sat, 27 Oct 2018, Joe Perches wrote: > On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote: > > [Adding Joe Perches] > > > > On Fri, 26 Oct 2018, Sasha Levin wrote: > > > > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > > > This change was suggested by

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-27 Thread Julia Lawall
On Sat, 27 Oct 2018, Joe Perches wrote: > On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote: > > [Adding Joe Perches] > > > > On Fri, 26 Oct 2018, Sasha Levin wrote: > > > > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > > > This change was suggested by

linux-next: Signed-off-by missing for commit in the c6x tree

2018-10-27 Thread Stephen Rothwell
Hi Mark, Commit fe381767b94f ("c6x: switch to NO_BOOTMEM") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgplP20KbtClc.pgp Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the c6x tree

2018-10-27 Thread Stephen Rothwell
Hi Mark, Commit fe381767b94f ("c6x: switch to NO_BOOTMEM") is missing a Signed-off-by from its committer. -- Cheers, Stephen Rothwell pgplP20KbtClc.pgp Description: OpenPGP digital signature

Re: [RFC] rcu: doc: update example about stale data

2018-10-27 Thread Joel Fernandes
On Sat, Oct 27, 2018 at 7:16 PM, Joel Fernandes (Google) wrote: > The RCU example for 'rejecting stale data' on system-call auditting > stops iterating through the rules if a deleted one is found. It makes > more sense to continue looking at other rules once a deleted one is > rejected. Although

Re: [RFC] rcu: doc: update example about stale data

2018-10-27 Thread Joel Fernandes
On Sat, Oct 27, 2018 at 7:16 PM, Joel Fernandes (Google) wrote: > The RCU example for 'rejecting stale data' on system-call auditting > stops iterating through the rules if a deleted one is found. It makes > more sense to continue looking at other rules once a deleted one is > rejected. Although

perf synthesized mmap timeouts

2018-10-27 Thread David Miller
If I understand the commit message for: commit 8cc42de736b617827a4e7664fb8d7a325bc125bc Author: Kan Liang Date: Thu Jan 18 13:26:32 2018 -0800 perf top: Check the latency of perf_top__mmap_read() properly, the problem is that a malicious or out of control app can be doing endless mmaps

perf synthesized mmap timeouts

2018-10-27 Thread David Miller
If I understand the commit message for: commit 8cc42de736b617827a4e7664fb8d7a325bc125bc Author: Kan Liang Date: Thu Jan 18 13:26:32 2018 -0800 perf top: Check the latency of perf_top__mmap_read() properly, the problem is that a malicious or out of control app can be doing endless mmaps

[PATCH] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-10-27 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. Signed-off-by: Nishad Kamdar --- drivers/staging/olpc_dcon/olpc_dcon.h | 12 drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 74 ++ 2 files changed, 44 insertions(+),

[PATCH] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-10-27 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. Signed-off-by: Nishad Kamdar --- drivers/staging/olpc_dcon/olpc_dcon.h | 12 drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 74 ++ 2 files changed, 44 insertions(+),

[RFC] doc: rcu: remove note on smp_mb during synchronize_rcu

2018-10-27 Thread Joel Fernandes (Google)
As per this thread [1], it seems this smp_mb isn't needed anymore: "So the smp_mb() that I was trying to add doesn't need to be there." So let us remove this part from the memory ordering documentation. [1] https://lkml.org/lkml/2017/10/6/707 Signed-off-by: Joel Fernandes (Google) ---

[RFC] doc: rcu: remove note on smp_mb during synchronize_rcu

2018-10-27 Thread Joel Fernandes (Google)
As per this thread [1], it seems this smp_mb isn't needed anymore: "So the smp_mb() that I was trying to add doesn't need to be there." So let us remove this part from the memory ordering documentation. [1] https://lkml.org/lkml/2017/10/6/707 Signed-off-by: Joel Fernandes (Google) ---

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-27 Thread Diego Viola
On Fri, Oct 26, 2018 at 5:36 PM Diego Viola wrote: > > On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: > > > > On 10/26/18 7:45 AM, Diego Viola wrote: > > > med_power_with_dipm causes my T450 to freeze with a SAMSUNG > > > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q). > > > > > > Switching the

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-27 Thread Diego Viola
On Fri, Oct 26, 2018 at 5:36 PM Diego Viola wrote: > > On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: > > > > On 10/26/18 7:45 AM, Diego Viola wrote: > > > med_power_with_dipm causes my T450 to freeze with a SAMSUNG > > > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q). > > > > > > Switching the

UI messages in event thread hangs perf top

2018-10-27 Thread David Miller
If I run perf top with a "make -j128" kernel build, I get ring buffer event processing timeouts which results in: ui__warning("Too slow to read ring buffer.\n" "Please try increasing the period (-c) or\n" "decreasing the

UI messages in event thread hangs perf top

2018-10-27 Thread David Miller
If I run perf top with a "make -j128" kernel build, I get ring buffer event processing timeouts which results in: ui__warning("Too slow to read ring buffer.\n" "Please try increasing the period (-c) or\n" "decreasing the

[PATCH] staging: rtl8712: fix CamelCase in fw_priv struct

2018-10-27 Thread Robert Eshleman
Rename fields in fw_priv struct from CamelCase to snake_case. Reported by checkpatch. Signed-off-by: Robert Eshleman --- drivers/staging/rtl8712/hal_init.c| 10 +- drivers/staging/rtl8712/rtl8712_hal.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH] staging: rtl8712: fix CamelCase in fw_priv struct

2018-10-27 Thread Robert Eshleman
Rename fields in fw_priv struct from CamelCase to snake_case. Reported by checkpatch. Signed-off-by: Robert Eshleman --- drivers/staging/rtl8712/hal_init.c| 10 +- drivers/staging/rtl8712/rtl8712_hal.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-27 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > This will apply GCC '-Og' optimization level which is supported > since GCC 4.8. This optimization level offers a reasonable level > of optimization while maintaining fast compilation and a good > debugging experience. It is similar to '-O1'

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-27 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > This will apply GCC '-Og' optimization level which is supported > since GCC 4.8. This optimization level offers a reasonable level > of optimization while maintaining fast compilation and a good > debugging experience. It is similar to '-O1'

[RFC] rcu: doc: update example about stale data

2018-10-27 Thread Joel Fernandes (Google)
The RCU example for 'rejecting stale data' on system-call auditting stops iterating through the rules if a deleted one is found. It makes more sense to continue looking at other rules once a deleted one is rejected. Although the original example is fine, this makes it more meaningful.

[RFC] rcu: doc: update example about stale data

2018-10-27 Thread Joel Fernandes (Google)
The RCU example for 'rejecting stale data' on system-call auditting stops iterating through the rules if a deleted one is found. It makes more sense to continue looking at other rules once a deleted one is rejected. Although the original example is fine, this makes it more meaningful.

Re: [PATCH v2 1/4] x86/mm: surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif

2018-10-27 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So > surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif to > make code correct. For clarification, is it better to mention that this is a preparation for

Re: [PATCH v2 1/4] x86/mm: surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif

2018-10-27 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So > surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif to > make code correct. For clarification, is it better to mention that this is a preparation for

Re: [PATCH] HID: moving to group maintainership model

2018-10-27 Thread Stephen Rothwell
Hi Jiri, On Sat, 27 Oct 2018 14:19:02 +0200 (CEST) Jiri Kosina wrote: > > Stephen, could you please update the hid.git URL for linux-next as below? > Thanks. Done, also added Benjamin as a contact. [for Benjamin's benefit ...] Thanks for adding your subsystem tree as a participant of

Re: [PATCH] HID: moving to group maintainership model

2018-10-27 Thread Stephen Rothwell
Hi Jiri, On Sat, 27 Oct 2018 14:19:02 +0200 (CEST) Jiri Kosina wrote: > > Stephen, could you please update the hid.git URL for linux-next as below? > Thanks. Done, also added Benjamin as a contact. [for Benjamin's benefit ...] Thanks for adding your subsystem tree as a participant of

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Al Viro
On Sat, Oct 27, 2018 at 03:46:02PM -0700, Bruce Perens wrote: > The anonymous person is generally thought to have appeared on the net > previously as MikeeUSA. That entity has a well-recorded history of misogyny > and other anti-social behaviour. You are misreading it - behaviour of that...

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Al Viro
On Sat, Oct 27, 2018 at 03:46:02PM -0700, Bruce Perens wrote: > The anonymous person is generally thought to have appeared on the net > previously as MikeeUSA. That entity has a well-recorded history of misogyny > and other anti-social behaviour. You are misreading it - behaviour of that...

Group Imbalance Bug - performance drop by factor 10x on NUMA boxes with cgroups

2018-10-27 Thread Jirka Hladky
Hi Mel and Srikar, I would like to ask you if you could look into the Group Imbalance Bug described in this paper http://www.ece.ubc.ca/~sasha/papers/eurosys16-final29.pdf in chapter 3.1. See also comment [1]. The paper describes the bug on workload which involves different ssh sessions and it

Group Imbalance Bug - performance drop by factor 10x on NUMA boxes with cgroups

2018-10-27 Thread Jirka Hladky
Hi Mel and Srikar, I would like to ask you if you could look into the Group Imbalance Bug described in this paper http://www.ece.ubc.ca/~sasha/papers/eurosys16-final29.pdf in chapter 3.1. See also comment [1]. The paper describes the bug on workload which involves different ssh sessions and it

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: > On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > > The function rtw_hal_xmit() returns true or false. > > Change the return type from s32 to bool. > [] > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > >

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: > On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > > The function rtw_hal_xmit() returns true or false. > > Change the return type from s32 to bool. > [] > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > >

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Eric S. Raymond
Bruce Perens : > The anonymous person is generally thought to have appeared on the net > previously as MikeeUSA. That entity has a well-recorded history of misogyny > and other anti-social behaviour. He's also complained to me recently that > because of "people like me", the law prohibits him from

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Eric S. Raymond
Bruce Perens : > The anonymous person is generally thought to have appeared on the net > previously as MikeeUSA. That entity has a well-recorded history of misogyny > and other anti-social behaviour. He's also complained to me recently that > because of "people like me", the law prohibits him from

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > The function rtw_hal_xmit() returns true or false. > Change the return type from s32 to bool. [] > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c [] > @@ -598,7 +598,7 @@

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: > The function rtw_hal_xmit() returns true or false. > Change the return type from s32 to bool. [] > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c > b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c [] > @@ -598,7 +598,7 @@

Re: [PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 23:32 +0100, Jordan Borgner wrote: > Added missing parentheses to sizeof() function in detect_memory_e820(). > > Removed unnecessary braces in detect_memory_e801(). > > Replaced three if-statements with a ternary if-statement and > removed an unnecessary integer variable

Re: [PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 23:32 +0100, Jordan Borgner wrote: > Added missing parentheses to sizeof() function in detect_memory_e820(). > > Removed unnecessary braces in detect_memory_e801(). > > Replaced three if-statements with a ternary if-statement and > removed an unnecessary integer variable

[PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-27 Thread Jordan Borgner
Added missing parentheses to sizeof() function in detect_memory_e820(). Removed unnecessary braces in detect_memory_e801(). Replaced three if-statements with a ternary if-statement and removed an unnecessary integer variable in detect_memory(). This is my first patch I hope it is okay.

[PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-27 Thread Jordan Borgner
Added missing parentheses to sizeof() function in detect_memory_e820(). Removed unnecessary braces in detect_memory_e801(). Replaced three if-statements with a ternary if-statement and removed an unnecessary integer variable in detect_memory(). This is my first patch I hope it is okay.

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, tim.b...@sony.com wrote: > Al, > > Can you please, even in the face of comments you find irritating, keep > your responses more civil? Calling someone a "wankstain" is > unprofessional Tim, to be completely honest, communicating anonymously doesn't really match my "this

Re: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, tim.b...@sony.com wrote: > Al, > > Can you please, even in the face of comments you find irritating, keep > your responses more civil? Calling someone a "wankstain" is > unprofessional Tim, to be completely honest, communicating anonymously doesn't really match my "this

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-27 Thread Joe Perches
On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote: > [Adding Joe Perches] > > On Fri, 26 Oct 2018, Sasha Levin wrote: > > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > > This change was suggested by checkpath.pl. Use unsigned int with bitfield > > > allocate

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-27 Thread Joe Perches
On Fri, 2018-10-26 at 22:54 +0200, Julia Lawall wrote: > [Adding Joe Perches] > > On Fri, 26 Oct 2018, Sasha Levin wrote: > > > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > > This change was suggested by checkpath.pl. Use unsigned int with bitfield > > > allocate

Re: Another HID problem this merge window..

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, Linus Torvalds wrote: > I wonder if there is some truly old historical legacy there, ie the old > PC keyboard support would have been configurable out only for expert > users to avoid errors, and maybe the HID Kconfig file started getting > ideas from that... This really

Re: Another HID problem this merge window..

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, Linus Torvalds wrote: > I wonder if there is some truly old historical legacy there, ie the old > PC keyboard support would have been configurable out only for expert > users to avoid errors, and maybe the HID Kconfig file started getting > ideas from that... This really

linux-kernel@vger.kernel.org has password qwerty. Password must be changed

2018-10-27 Thread linux-kernel
Hello! I'm a programmer who cracked your email account and device about half year ago. You entered a password on one of the insecure site you visited, and I catched it. Your password from linux-kernel@vger.kernel.org on moment of crack: qwerty Of course you can will change your password, or

linux-kernel@vger.kernel.org has password qwerty. Password must be changed

2018-10-27 Thread linux-kernel
Hello! I'm a programmer who cracked your email account and device about half year ago. You entered a password on one of the insecure site you visited, and I catched it. Your password from linux-kernel@vger.kernel.org on moment of crack: qwerty Of course you can will change your password, or

drivers//regulator/bd718x7-regulator.c:364:16: error: implicit declaration of function 'of_match_ptr'; did you mean 'hash_ptr'?

2018-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 commit: 2ece646c90c5b45dd76c76ea207a3f3459f2c472 regulator: bd718xx: rename bd71837 to 718xx date: 4 weeks ago config: x86_64-randconfig-s4-10280315 (attached as

drivers//regulator/bd718x7-regulator.c:364:16: error: implicit declaration of function 'of_match_ptr'; did you mean 'hash_ptr'?

2018-10-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 commit: 2ece646c90c5b45dd76c76ea207a3f3459f2c472 regulator: bd718xx: rename bd71837 to 718xx date: 4 weeks ago config: x86_64-randconfig-s4-10280315 (attached as

[PATCH 5/5] staging: rtl8188eu: cleanup long line in rtw_hal_xmit()

2018-10-27 Thread Michael Straube
Cleanup a line over 80 characters in rtw_hal_xmit() by using if(x) instead of if(x == true). Also clears a missing spaces around '|' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 5/5] staging: rtl8188eu: cleanup long line in rtw_hal_xmit()

2018-10-27 Thread Michael Straube
Cleanup a line over 80 characters in rtw_hal_xmit() by using if(x) instead of if(x == true). Also clears a missing spaces around '|' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/5] staging: rtl8188eu: change type of a struct field

2018-10-27 Thread Michael Straube
The field enable of struct recv_reorder_ctrl is only used for boolean values, so change the type from u8 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/5] staging: rtl8188eu: change type of a struct field

2018-10-27 Thread Michael Straube
The field enable of struct recv_reorder_ctrl is only used for boolean values, so change the type from u8 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/5] staging: rtl8188eu: change return type of rtl8188eu_xmitframe_complete()

2018-10-27 Thread Michael Straube
The function rtl8188eu_xmitframe_complete() returns true or false. Change the return type from s32 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c| 3 ++- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 4 ++-- 2 files changed, 4 insertions(+),

[PATCH 1/5] staging: rtl8188eu: remove unnecessary ternary operator

2018-10-27 Thread Michael Straube
The field accept_addba_req of struct mlme_ext_info has type bool. Use the value of accept_addba_req directly instead of the ternary operator in an asignment. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Michael Straube
The function rtw_hal_xmit() returns true or false. Change the return type from s32 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +- drivers/staging/rtl8188eu/include/hal_intf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/5] staging: rtl8188eu: change return type of rtl8188eu_xmitframe_complete()

2018-10-27 Thread Michael Straube
The function rtl8188eu_xmitframe_complete() returns true or false. Change the return type from s32 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c| 3 ++- drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 4 ++-- 2 files changed, 4 insertions(+),

[PATCH 1/5] staging: rtl8188eu: remove unnecessary ternary operator

2018-10-27 Thread Michael Straube
The field accept_addba_req of struct mlme_ext_info has type bool. Use the value of accept_addba_req directly instead of the ternary operator in an asignment. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-27 Thread Michael Straube
The function rtw_hal_xmit() returns true or false. Change the return type from s32 to bool. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c | 2 +- drivers/staging/rtl8188eu/include/hal_intf.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 12:36 PM Joe Perches wrote: > > In fairness, it seems many of the HID drivers do exactly that > and this could have been a "copy from example" addition. Interesting, and I think you're right. I wonder why I haven't noticed this before. Some of those might be hidden by

Re: Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 12:36 PM Joe Perches wrote: > > In fairness, it seems many of the HID drivers do exactly that > and this could have been a "copy from example" addition. Interesting, and I think you're right. I wonder why I haven't noticed this before. Some of those might be hidden by

Re: [PATCH 11/11] perf tools: Stop fallbacking to kallsyms for vdso symbols lookup

2018-10-27 Thread Vinicius Costa Gomes
Hi Jirka, Jiri Olsa writes: > On Fri, Oct 26, 2018 at 04:19:52PM -0700, Vinicius Costa Gomes wrote: >> Hi, >> >> Adrian Hunter writes: >> >> > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote: >> >> From: Arnaldo Carvalho de Melo >> >> >> >> David reports that: >> >> >> >> >> >> Perf

Re: [PATCH 11/11] perf tools: Stop fallbacking to kallsyms for vdso symbols lookup

2018-10-27 Thread Vinicius Costa Gomes
Hi Jirka, Jiri Olsa writes: > On Fri, Oct 26, 2018 at 04:19:52PM -0700, Vinicius Costa Gomes wrote: >> Hi, >> >> Adrian Hunter writes: >> >> > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote: >> >> From: Arnaldo Carvalho de Melo >> >> >> >> David reports that: >> >> >> >> >> >> Perf

Re: [PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-27 Thread Alexey Dobriyan
On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote: > +#include > +#define linux_proc_banner \ > + "%s version %s" \ > + " (" LINUX_COMPILE_BY "@" LINUX_COMPILE_HOST ")" \ > + " (" LINUX_COMPILER ") %s\n" Include doesn't work if compiling from scratch: rm -rf

Re: [PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-27 Thread Alexey Dobriyan
On Fri, Oct 26, 2018 at 11:20:34PM +0200, Rasmus Villemoes wrote: > +#include > +#define linux_proc_banner \ > + "%s version %s" \ > + " (" LINUX_COMPILE_BY "@" LINUX_COMPILE_HOST ")" \ > + " (" LINUX_COMPILER ") %s\n" Include doesn't work if compiling from scratch: rm -rf

Re: Another HID problem this merge window..

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 11:13 -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most people

Re: Another HID problem this merge window..

2018-10-27 Thread Joe Perches
On Sat, 2018-10-27 at 11:13 -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most people

[PATCH] PCI: histb: constify dw_pcie_host_ops structure

2018-10-27 Thread Julia Lawall
The dw_pcie_host_ops structure is only stored in the ops field of a pcie_port structure, and this field is const, so make the dw_pcie_host_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pci/controller/dwc/pcie-histb.c |2 +- 1 file

[PATCH] PCI: histb: constify dw_pcie_host_ops structure

2018-10-27 Thread Julia Lawall
The dw_pcie_host_ops structure is only stored in the ops field of a pcie_port structure, and this field is const, so make the dw_pcie_host_ops structure const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/pci/controller/dwc/pcie-histb.c |2 +- 1 file

Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
Ok, so this is a much smaller issue than the i2c one that cause boot problems, but it's annoying. We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of. Yet the new "BigBen Interactive" driver that

Another HID problem this merge window..

2018-10-27 Thread Linus Torvalds
Ok, so this is a much smaller issue than the i2c one that cause boot problems, but it's annoying. We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of. Yet the new "BigBen Interactive" driver that

Re: [GIT PULL REQUEST] watchdog - v4.20 Merge window

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 4:50 AM Wim Van Sebroeck wrote: > > Please pull the watchdog changes for the v4.20 (or 5.00) release cycle. Pulled, Linus

Re: [GIT PULL REQUEST] watchdog - v4.20 Merge window

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 4:50 AM Wim Van Sebroeck wrote: > > Please pull the watchdog changes for the v4.20 (or 5.00) release cycle. Pulled, Linus

Re: [git pull] Input updates for v4.20-rc0

2018-10-27 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 4:49 PM Dmitry Torokhov wrote: > > updates for the input subsystem. Just random driver fixups, > nothing exiting. Pulled, Linus

Re: [git pull] Input updates for v4.20-rc0

2018-10-27 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 4:49 PM Dmitry Torokhov wrote: > > updates for the input subsystem. Just random driver fixups, > nothing exiting. Pulled, Linus

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-27 Thread Himanshu Jha
Hi Dan, On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-27 Thread Himanshu Jha
Hi Dan, On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message

Gooday To You,

2018-10-27 Thread Ali Hamadu
Gooday To You, Please i need your kind Assistance. I will be very glad if you can assist me to receive this sum of ( $22. Million US dollars.) into your bank account for the benefit of our both families, reply me if you are ready to receive this fund.

Gooday To You,

2018-10-27 Thread Ali Hamadu
Gooday To You, Please i need your kind Assistance. I will be very glad if you can assist me to receive this sum of ( $22. Million US dollars.) into your bank account for the benefit of our both families, reply me if you are ready to receive this fund.

Gooday To You,

2018-10-27 Thread Ali Hamadu
Gooday To You, Please i need your kind Assistance. I will be very glad if you can assist me to receive this sum of ( $22. Million US dollars.) into your bank account for the benefit of our both families, reply me if you are ready to receive this fund.

Gooday To You,

2018-10-27 Thread Ali Hamadu
Gooday To You, Please i need your kind Assistance. I will be very glad if you can assist me to receive this sum of ( $22. Million US dollars.) into your bank account for the benefit of our both families, reply me if you are ready to receive this fund.

Re: [GIT PULL] RTC for 4.20

2018-10-27 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 1:55 PM Alexandre Belloni wrote: > > Here is the pull-request for the RTC subsystem for 4.20. > > This cycle, there were mostly non urgent fixes in drivers. I also > finally unexported the non managed registration. Pulled, Linus

Re: [GIT PULL] RTC for 4.20

2018-10-27 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 1:55 PM Alexandre Belloni wrote: > > Here is the pull-request for the RTC subsystem for 4.20. > > This cycle, there were mostly non urgent fixes in drivers. I also > finally unexported the non managed registration. Pulled, Linus

Re: Oops in current tree in i2c

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 9:08 AM Linus Torvalds wrote: > > I *think* the problem is that the i2c_hid_dmi_desc_override_table[] > isn't terminated by a NULL entry, and I will test that next. Confirmed. That makes my laptop boot cleanly. See commit b59dfdaef173 ("i2c-hid: properly terminate

Re: Oops in current tree in i2c

2018-10-27 Thread Linus Torvalds
On Sat, Oct 27, 2018 at 9:08 AM Linus Torvalds wrote: > > I *think* the problem is that the i2c_hid_dmi_desc_override_table[] > isn't terminated by a NULL entry, and I will test that next. Confirmed. That makes my laptop boot cleanly. See commit b59dfdaef173 ("i2c-hid: properly terminate

Re: Oops in current tree in i2c

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, Linus Torvalds wrote: > I *think* the problem is that the i2c_hid_dmi_desc_override_table[] > isn't terminated by a NULL entry, and I will test that next. Hm, that almost certainly is indeed the issue, thanks a lot for reporting it. > What makes me *very* unhappy about

Re: Oops in current tree in i2c

2018-10-27 Thread Jiri Kosina
On Sat, 27 Oct 2018, Linus Torvalds wrote: > I *think* the problem is that the i2c_hid_dmi_desc_override_table[] > isn't terminated by a NULL entry, and I will test that next. Hm, that almost certainly is indeed the issue, thanks a lot for reporting it. > What makes me *very* unhappy about

RE: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Tim.Bird
> -Original Message- > From: Al Viro > > On Sat, Oct 27, 2018 at 06:52:44AM +, visionsofal...@redchan.it wrote: > > Al: the FSF was so insistent on the adoption of the GPL version 3 > > because the GPL version 2 is not operative against the grantor. > > Anonymous wankstain: sod off

RE: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Tim.Bird
> -Original Message- > From: Al Viro > > On Sat, Oct 27, 2018 at 06:52:44AM +, visionsofal...@redchan.it wrote: > > Al: the FSF was so insistent on the adoption of the GPL version 3 > > because the GPL version 2 is not operative against the grantor. > > Anonymous wankstain: sod off

Oops in current tree in i2c

2018-10-27 Thread Linus Torvalds
Julian, Jiri, On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") but that's simply because it's the only thing that seems to touch this particular area in this

Oops in current tree in i2c

2018-10-27 Thread Linus Torvalds
Julian, Jiri, On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") but that's simply because it's the only thing that seems to touch this particular area in this

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-27 Thread Slawomir Stepien
Hi On paź 26, 2018 18:55, Nishad Kamdar wrote: > Add device tree table for matching vendor ID > and support for retrieving platform data > from device tree. So maybe you should make 2 commits? > Signed-off-by: Nishad Kamdar > --- > drivers/staging/iio/resolver/ad2s1210.c | 43

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-27 Thread Slawomir Stepien
Hi On paź 26, 2018 18:55, Nishad Kamdar wrote: > Add device tree table for matching vendor ID > and support for retrieving platform data > from device tree. So maybe you should make 2 commits? > Signed-off-by: Nishad Kamdar > --- > drivers/staging/iio/resolver/ad2s1210.c | 43

Re: [PATCH v2] mtd: spi-nor: Add support for SPI boot flash access for AMD Family 16h

2018-10-27 Thread Boris Brezillon
Hi Brett, On Tue, 16 Oct 2018 00:57:41 + "Grandbois, Brett" wrote: > Add support to expose the SPI boot flash on AMD Family 16h CPUs as a > standard mtd device to give userspace BIOS updaters greater feature > support. The BIOS and Kernel Developer's Guide refers to this as the > 'SPI ROM'

Re: [PATCH v2] mtd: spi-nor: Add support for SPI boot flash access for AMD Family 16h

2018-10-27 Thread Boris Brezillon
Hi Brett, On Tue, 16 Oct 2018 00:57:41 + "Grandbois, Brett" wrote: > Add support to expose the SPI boot flash on AMD Family 16h CPUs as a > standard mtd device to give userspace BIOS updaters greater feature > support. The BIOS and Kernel Developer's Guide refers to this as the > 'SPI ROM'

Re: [PATCH v2 1/3] namei: implement O_BENEATH-style AT_* flags

2018-10-27 Thread Aleksa Sarai
On 2018-10-27, Al Viro wrote: > On Sat, Oct 27, 2018 at 06:17:29PM +1100, Aleksa Sarai wrote: > > > I'm going to send out a v4 "soon" but I would like to know what folks > > think about having resolveat(2) (or similar) to separate the scoping O_* > > flags and produce an O_PATH -- since

Re: [PATCH v2 1/3] namei: implement O_BENEATH-style AT_* flags

2018-10-27 Thread Aleksa Sarai
On 2018-10-27, Al Viro wrote: > On Sat, Oct 27, 2018 at 06:17:29PM +1100, Aleksa Sarai wrote: > > > I'm going to send out a v4 "soon" but I would like to know what folks > > think about having resolveat(2) (or similar) to separate the scoping O_* > > flags and produce an O_PATH -- since

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
This contains two drivers: * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of the two busses of the MP2) and routing any i2c read/write command to the PCI driver. * i2c-amd-pci-mp2: PCI driver communicating through the C2P/P2C mailbox registers, or through DMA for more than 32

[PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller

2018-10-27 Thread Elie Morisse
This contains two drivers: * i2c-amd-plat-mp2: platform driver managing an i2c adapter (one of the two busses of the MP2) and routing any i2c read/write command to the PCI driver. * i2c-amd-pci-mp2: PCI driver communicating through the C2P/P2C mailbox registers, or through DMA for more than 32

  1   2   >