Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread santosh.shilim...@oracle.com
On 10/30/18 12:00 PM, Greg Kroah-Hartman wrote: On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: Hi Greg, [...] Would be able to apply this fix from Marc for stable or it needs to be re-posted with CC to stable ? This is not the correct way to submit patches for inclusi

Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode

2018-10-30 Thread David Miller
From: "Liang, Kan" Date: Mon, 29 Oct 2018 10:33:06 -0400 > The problem is that users have to wait tens of minutes to see perf > top results on the screen in KNL. Before that, there is nothing but > a black screen. I'm actually curious why so I started digging last night. First, I made perf top

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Greg Kroah-Hartman
On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: > Hi Greg, > > On 10/30/2018 4:11 AM, Marc Zyngier wrote: > > The Keystone QMSS driver is pretty damaged, in the sense that it > > does things like this: > > > > irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); > > > > where

Re: [PATCH] fs/proc: introduce /proc/stat2 file

2018-10-30 Thread Davidlohr Bueso
On Mon, 29 Oct 2018, Vito Caputo wrote: I'm definitely not in favor of just adding another stat file that is the same format as the existing one with the intrs zeroed out. It's a dirty hack; fine for your local needs but too gross for upstream IMHO. I suspect very few users of /proc/stat actu

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Mogens Jensen
‐‐‐ Original Message ‐‐‐ On Tuesday, October 30, 2018 4:04 PM, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > > Hi, > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > > > In addition I am not aware of any baytrail device using plt_clk_0, so > > > moving

Re: [RFC][PATCH v1] ACPI / scan: Create platform device for BOSC0200 ACPI nodes

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:27, Hans de Goede wrote: Hi, On 30-10-18 15:47, Andy Shevchenko wrote: On some laptops the ACPI device with BOSC0200 _HID is representing two accelerometers under one node. We add an ID to the I2C multi instantiate list to enumerate all I2C slaves correctly. I believe tha

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
On Tue, 2018-10-30 at 20:33 +0200, Andy Shevchenko wrote: > On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada > wrote: > > > > > Index printing is required here (for LTR Show and LTR Ignore) > > > > because it > > > > paves an obvious and easy way for the users of this driver to > > > > know >

Re: Fwd: [PATCH v2 2/8] selftests/resctrl: Add basic resctrl file system operations and data

2018-10-30 Thread Fenghua Yu
> From: Moger, Babu > > From: Fenghua Yu > > From: Sai Praneeth Prakhya > > > > The basic resctrl file system operations and data are added for future > > usage by resctrl selftest tool. > > > > + return 0; > > +} > > + > > +char get_sock_num(int cpu_no) > > +{ > > + char sock_num, phys_

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada wrote: > > > Index printing is required here (for LTR Show and LTR Ignore) > > > because it > > > paves an obvious and easy way for the users of this driver to know > > > the > > > IP number to be used for LTR ignore. This was specifically > > >

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi Pierre-Louis, On 30-10-18 17:27, Pierre-Louis Bossart wrote: On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean,

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Marc Zyngier
On 30/10/18 17:02, Florian Fainelli wrote: > On 10/30/18 4:11 AM, Marc Zyngier wrote: >> The Keystone QMSS driver is pretty damaged, in the sense that it >> does things like this: >> >> irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); >> >> where cpu_map is a local variable. As we leave the f

Re: [PATCH AUTOSEL 4.14 17/19] selftests: ftrace: Add synthetic event syntax testcase

2018-10-30 Thread Sasha Levin
On Tue, Oct 30, 2018 at 10:58:15AM -0400, Steven Rostedt wrote: On Tue, 30 Oct 2018 09:28:22 -0400 Sasha Levin wrote: From: Masami Hiramatsu [ Upstream commit ba0e41ca81b935b958006c7120466e2217357827 ] Add a testcase to check the syntax and field types for synthetic_events interface. Link:

[PATCH] firmware: raspberrypi: Define timeout for transactions

2018-10-30 Thread Stefan Wahren
We should never assume to get a reply from the firmware otherwise the call could block forever and the user don't get informed. So define a timeout of 1 sec and print a stacktrace once in the unlikely case the timeout expired. Signed-off-by: Stefan Wahren --- drivers/firmware/raspberrypi.c | 8 +

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR Show

[PATCH v2] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
Access to timerslack_ns is controlled by a process having CAP_SYS_NICE in its effective capability set, but the current check looks in the root namespace instead of the process' user namespace. Since a process is allowed to do other activities controlled by CAP_SYS_NICE inside a namespace, it shou

Re: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-30 Thread Jeff Layton
On Tue, 2018-10-30 at 08:04 -0400, Jeff Layton wrote: > On Mon, 2018-10-29 at 08:38 -0400, Jeff Layton wrote: > > On Mon, 2018-10-29 at 12:56 +1100, NeilBrown wrote: > > > On Fri, Oct 26 2018, Jeff Layton wrote: > > > > > > > On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote: > > > > > This took

Re: [PATCH] mm: handle no memcg case in memcg_kmem_charge() properly

2018-10-30 Thread Shakeel Butt
On Tue, Oct 30, 2018 at 8:56 AM Roman Gushchin wrote: > > On Tue, Oct 30, 2018 at 07:12:49AM +0100, Michal Hocko wrote: > > On Mon 29-10-18 21:51:55, Roman Gushchin wrote: > > > Mike Galbraith reported a regression caused by the commit 9b6f7e163cd0 > > > ("mm: rework memcg kernel stack accounting"

Re: [PATCH RFC kenrel/rcu] Eliminate BUG_ON() for sync.c

2018-10-30 Thread Paul E. McKenney
On Mon, Oct 22, 2018 at 06:14:40PM +0200, Oleg Nesterov wrote: > On 10/22, Paul E. McKenney wrote: > > > > > > @@ -125,12 +125,12 @@ void rcu_sync_enter(struct rcu_sync *rsp) > > > > rsp->gp_state = GP_PENDING; > > > > spin_unlock_irq(&rsp->rss_lock); > > > > > > > > -

RE: [PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Bae, Chang Seok
> Factor out the code to change index from x86_fsbase_write_cpu() and > x86_gsbase_write_cpu_inactive(). Now the code is located in > do_arch_prctl_64(). > > The helper functions that purport to write the base register should just > write the > base register only. It shouldn't have magic optimiza

[PATCH] mm: hide incomplete nr_indirectly_reclaimable in /proc/zoneinfo

2018-10-30 Thread Roman Gushchin
Yongqin reported that /proc/zoneinfo format is broken in 4.14 due to commit 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in /proc/vmstat") Node 0, zone DMA per-node stats nr_inactive_anon 403 nr_active_anon 89123 nr_inactive_file 128887 nr_active_file 4737

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Harry Cutts
Thanks for the analysis, Peter. On Mon, 29 Oct 2018 at 23:27, Peter Hutterer wrote: > IMO this is a lost battle because you cannot know when the ratchet is > enabled or not (at least not on all mice). Users switch between ratchet and > freewheeling time and once you're out of one mode, you have n

RE: [PATCH] Choose CPU based on allocated IRQs

2018-10-30 Thread Long Li
> Subject: Re: [PATCH] Choose CPU based on allocated IRQs > > Long, > > On Tue, 23 Oct 2018, Long Li wrote: > > thanks for this patch. > > A trivial formal thing ahead. The subject line > >[PATCH] Choose CPU based on allocated IRQs > > is lacking a proper subsystem prefix. In most cases y

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-30 Thread William Cohen
On 10/22/18 5:30 AM, Kees Cook wrote: > The arm compiler internally interprets an inline assembly label > as an unsigned long value, not a pointer. As a result, under > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address > of a label is 4 bytes, which was tripping the runtime chec

[PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Chang S. Bae
Factor out the code to change index from x86_fsbase_write_cpu() and x86_gsbase_write_cpu_inactive(). Now the code is located in do_arch_prctl_64(). The helper functions that purport to write the base register should just write the base register only. It shouldn't have magic optimizations to change

[PATCH v2] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P.L.S.S.S.N
Add device bindings for cpuidle states for cpu devices. Cc: Signed-off-by: Raju P.L.S.S.S.N --- Changes in v2 - Address comments from Doug --- --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 62 1 file changed, 62 insertions(+) diff --git a/arch/arm64/boot/dts/

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 05:39:26PM +0100, Oleg Nesterov wrote: > On 10/30, Oleg Nesterov wrote: > > > > On 10/30, Tycho Andersen wrote: > > > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > > struct seccomp_data *sd, > > >*/ > > > rmb(); > > > > > > + if (!

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Greg, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, an

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Arnd, Olof, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-la

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will

Re: [GIT PULL] tracing: Updates for 4.20 (or 5.0)

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:37 AM Steven Rostedt wrote: > > The biggest change here is the updates to kprobes Pulled. However, a little note: > - Added support for SDT in uprobes As an explanation, the above kind of sucks. "SDT"? I had to look it up. I added a note to the commit message, but pl

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Florian Fainelli
On 10/30/18 4:11 AM, Marc Zyngier wrote: > The Keystone QMSS driver is pretty damaged, in the sense that it > does things like this: > > irq_set_affinity_hint(irq, to_cpumask(&cpu_map)); > > where cpu_map is a local variable. As we leave the function, this > will point to nowhere-land, and

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Joel Fernandes
On Tue, Oct 30, 2018 at 1:50 AM Daniel Colascione wrote: > > On Tue, Oct 30, 2018 at 3:21 AM, Joel Fernandes wrote: > > On Mon, Oct 29, 2018 at 3:11 PM Daniel Colascione wrote: > >> > >> Add a simple proc-based kill interface. To use /proc/pid/kill, just > >> write the signal number in base-10 A

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

Re:Business proposition for you

2018-10-30 Thread Melvin Greg
Hello, I have a client from Syrian who will like to invest with your company. My client is willing to invest $4 Million. Can I have your company website to show to my client your company so that they will check and decide if they will invest there funds with you as joint partner. This inf

Re: [PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 17:08, Julia Lawall wrote: > Using devm_thermal_zone_of_sensor_register allows to simplify some > error handling code, drop a label, and drop the remove function. > > Signed-off-by: Julia Lawall Reviewed-by: Daniel Lezcano > --- > > This patch is completely orthogonal to the rec

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Doug Anderson
Resending since I accidentally clicked back to HTML and lists all bounced. :( On Tue, Oct 30, 2018 at 9:24 AM Raju P L S S S N wrote: > > On 10/24/2018 12:06 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N > > wrote: > >> + idle-states {

Re: [PATCH 0/2] [GIT PULL] tracing: Fixes to synthetic events

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:15 AM Steven Rostedt wrote: > > This is not my 4.20 pull request (that will be coming shortly). This > is just some last minute fixes that Masami sent me that I finally got > around to test. Pulled. Real pull request is next, Linus

Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification

2018-10-30 Thread Oleg Nesterov
On 10/29, Enke Chen wrote: > > Reviewed-by: Oleg Nesterov Hmm. I didn't say this ;) But OK, feel free to keep this tag. I do not like this feauture. But I see no technical problems in this version and I never pretented I understand the user-space needs, so I won't argue. Oleg.

[PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Julia Lawall
Using devm_thermal_zone_of_sensor_register allows to simplify some error handling code, drop a label, and drop the remove function. Signed-off-by: Julia Lawall --- This patch is completely orthogonal to the recent constification patch. drivers/thermal/broadcom/brcmstb_thermal.c | 24 ---

Re: [PATCH 2/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge

2018-10-30 Thread Luca Ceresoli
Hi Vladimir, On 08/10/18 23:12, Vladimir Zapolskiy wrote: > From: Vladimir Zapolskiy > > TI DS90Ux9xx de-/serializers are capable to route I2C messages to > I2C slave devices connected to a remote de-/serializer in a pair, > the change adds description of device tree bindings of the subcontrolle

Re: [PATCH] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
On Thu, Oct 25, 2018 at 01:56:27PM -0500, Eric W. Biederman wrote: > > Access to timerslack_ns is controlled by a process having CAP_SYS_NICE > > in its effective capability set, but the current check looks in the root > > namespace instead of the process' user namespace. Since a process is > > al

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Oleg Nesterov wrote: > > On 10/30, Tycho Andersen wrote: > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > struct seccomp_data *sd, > > */ > > rmb(); > > > > + if (!sd) { > > + populate_seccomp_data(&sd_local); > > + sd =

Re: [alsa-devel] [PATCH] ASoC: stm32: sai: fix invalid use of sizeof in stm32_sai_add_mclk_provider()

2018-10-30 Thread Mark Brown
On Sat, Oct 27, 2018 at 02:19:59AM +, Wei Yongjun wrote: > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. Someone else already sent a fix for this. signature.asc Description: PGP signature

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-30 Thread Stephen Boyd
Quoting Taniya Das (2018-10-29 23:01:44) > On 10/30/2018 12:13 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-28 03:34:55) > >> On 2018-10-19 16:04, Taniya Das wrote: > >>> On 10/10/2018 2:04 AM, Stephen Boyd wrote: > Quoting Taniya Das (2018-10-09 06:57:47) > > diff --git a/drive

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 11:27 PM Peter Hutterer wrote: > > Other issues I found with an MX Anywhere 2S is that on slow scroll and in > ratchet mode we get some scroll jitter. In ratchet mode we can get this > sequence if you scroll just past the notch and it snaps back: > [1, 1, 1, 1, 1, 1,

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-30 Thread Will Deacon
On Tue, Oct 30, 2018 at 04:58:41PM +0100, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 11:17:14PM +0200, Igor Stoppa wrote: > > > > > > On 25/10/2018 01:13, Peter Zijlstra wrote: > > > On Wed, Oct 24, 2018 at 12:35:03AM +0300, Igor Stoppa wrote: > > > > +static __always_inline > > > > +bool __

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
Thank you Juergen for your comments. I will soon send v2 patch. -Thanks, Manjunath On 10/30/2018 12:04 AM, Juergen Gross wrote: On 29/10/2018 19:31, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path. Typi

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Tycho Andersen wrote: > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > struct seccomp_data *sd, >*/ > rmb(); > > + if (!sd) { > + populate_seccomp_data(&sd_local); > + sd = &sd_local; > + } > + To me it would

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying th

[PATCH v2] ASoC: AMD: Fix race condition between register access

2018-10-30 Thread Agrawal, Akshu
During simultaneous running of playback and capture, we got hit by incorrect value write on common register. This was due to race condition between 2 streams. Fixing this by locking the common register access. Signed-off-by: Akshu Agrawal --- v2: Added 2 helper functions, removed locking in ch en

Re: Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-30 Thread Stephen Boyd
Quoting wang.y...@zte.com.cn (2018-10-29 23:13:24) > > Quoting Yi Wang (2018-10-29 01:31:47) > > > 'onecell' is malloced in clk_boston_setup(), but is not freed > > > before leaving from the error handling cases. > > > > How did you find this? Visual inspection? Some coccinelle script? > > Smatch

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 1:05 PM Hans de Goede wrote: > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat > $i/clk_flags; echo; done Just a side note about nice tool, called `grep` :-) grep -H . /sys/kernel/debug/clk/pmc_plt_clk_*/clk_flags does above in one call. -- With

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P L S S S N
On 10/24/2018 12:06 AM, Doug Anderson wrote: Hi, On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N wrote: + idle-states { + entry-method = "psci"; + + C0_CPU_SPC: c0_spc { nit: all these nodes should have dashes instead of spaces i

Re: Build error in drivers/cpufreq/intel_pstate.c

2018-10-30 Thread Srinivas Pandruvada
Hi, On Tue, 2018-10-30 at 18:00 +0200, Igor Stoppa wrote: > Hi, > I'm getting the following build error: > > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c: In > function > ‘show_base_frequency’: > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c:726:10: > error: implicit d

Re: [PATCH 2/2] thermal: broadcom: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:15, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia La

Re: [PATCH 1/2] thermal: armada: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:14, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of devm_thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Jul

Re: [PATCH] arm64: dts: qcom: msm8998: Reserve gpio ranges on MTP

2018-10-30 Thread Jeffrey Hugo
On 10/29/2018 11:45 PM, Bjorn Andersson wrote: GPIOs 0 through 3 and 81 through 84 are configured to not be accessible from the application CPUs. Mark them as reserved to allow the MSM8998 MTP to boot after the introduction of 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").

Re: [GIT PULL] More ACPI updates for v4.20-rc1

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 1:30 AM Rafael J. Wysocki wrote: > > These rework the handling of the P-unit semaphore on Intel > Baytrail and Cherrytrail systems to avoid race conditions and > excessive overhead related to it (Hans de Goede). Pulled, Linus

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-30 Thread Pekka Pessi
I guess it being an example doesn't make it strictly a recommendation, but I wonder if we should avoid giving examples that use mappings which we discourage. Well, yes, that is example for top0 – but I agree, giving examples that do not make much sense is not very productive. So currently we

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Dean Wallace
On 30-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > Hi, > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > In addition I am not aware of any baytrail device using plt_clk_0, > > > so moving a common machine driver such a cht_bsw_max98090_ti to use > >

[PATCH] sched/fair: util_est: fix cpu_util_wake for execl

2018-10-30 Thread Patrick Bellasi
A ~10% regression has been reported for UnixBench's execl throughput test: Message-ID: <20180402032000.GD3101@yexl-desktop> Message-ID: <20181024064100.ga27...@intel.com> That test is pretty simple, it does a "recursive" execve syscall on the same binary. Starting from the syscall, this seq

Re: [GIT PULL] More power management updates for v4.20-rc1

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 1:28 AM Rafael J. Wysocki wrote: > > These remove a questionable heuristic from the menu cpuidle governor, > fix a recent build regression in the intel_pstate driver, clean up > ARM big-Little support in cpufreq and fix up hung task watchdog's > interaction with system-wide

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 10:46 AM, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert

[PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure

2018-10-30 Thread Julia Lawall
The vb2_ops structure can be const as it is only stored in the ops field of a vb2_queue structure and this field is const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/usb/gadget/function/uvc_queue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: In addition I am not aware of any baytrail device using plt_clk_0, so moving a common machine driver such a cht_bsw_max98090_ti to use plt_clk0 only would break other devices (e.g. Rambi/Orco). Asking

Re: [PATCH v5 1/2] dt-bindings: iio: vadc: Update example to include unit address for node 'usb-id-nopull'

2018-10-30 Thread Rob Herring
On Sun, Oct 21, 2018 at 9:17 AM Jonathan Cameron wrote: > > On Thu, 18 Oct 2018 12:40:10 -0700 > Matthias Kaehlcke wrote: > > > On Fri, Oct 12, 2018 at 10:15:23AM -0700, Matthias Kaehlcke wrote: > > > On Fri, Oct 05, 2018 at 03:47:43PM -0500, Rob Herring wrote: > > > > On Wed, Oct 03, 2018 at 05:

Build error in drivers/cpufreq/intel_pstate.c

2018-10-30 Thread Igor Stoppa
Hi, I'm getting the following build error: /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c: In function ‘show_base_frequency’: /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c:726:10: error: implicit declaration of function ‘intel_pstate_get_cppc_guranteed’; did you mean ‘

Re: linux-next: manual merge of the compiler-attributes tree with the kbuild tree

2018-10-30 Thread Stephen Rothwell
Hi Miguel, On Tue, 30 Oct 2018 12:21:52 +0100 Miguel Ojeda wrote: > > From a quick look, it seems we want: > > #ifndef CONFIG_CC_OPTIMIZE_FOR_DEBUGGING > #define __compiletime_warning(message) __attribute__((__warning__(message))) > #define __compiletime_error(message) __attribute__((__error__(

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-30 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 11:17:14PM +0200, Igor Stoppa wrote: > > > On 25/10/2018 01:13, Peter Zijlstra wrote: > > On Wed, Oct 24, 2018 at 12:35:03AM +0300, Igor Stoppa wrote: > > > +static __always_inline > > > +bool __pratomic_long_op(bool inc, struct pratomic_long_t *l) > > > +{ > > > + struct

Re: [PATCH 1/2] kconfig: remove oldnoconfig target

2018-10-30 Thread Masahiro Yamada
On Tue, Oct 30, 2018 at 12:42 AM Masahiro Yamada wrote: > > As commit 312ee68752fa ("kconfig: announce removal of oldnoconfig if > used") announced, it is time for the removal. > > Signed-off-by: Masahiro Yamada > --- Applied to linux-kbuild. -- Best Regards Masahiro Yamada

Re: [PATCH] mm: handle no memcg case in memcg_kmem_charge() properly

2018-10-30 Thread Roman Gushchin
On Tue, Oct 30, 2018 at 07:12:49AM +0100, Michal Hocko wrote: > On Mon 29-10-18 21:51:55, Roman Gushchin wrote: > > Mike Galbraith reported a regression caused by the commit 9b6f7e163cd0 > > ("mm: rework memcg kernel stack accounting") on a system with > > "cgroup_disable=memory" boot option: the s

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 04:02:54PM +0100, Oleg Nesterov wrote: > On 10/29, Tycho Andersen wrote: > > > > +static long seccomp_notify_recv(struct seccomp_filter *filter, > > + void __user *buf) > > +{ > > + struct seccomp_knotif *knotif = NULL, *cur; > > + struct seccom

Re: linux-next: manual merge of the compiler-attributes tree with the kbuild tree

2018-10-30 Thread Masahiro Yamada
On Wed, Oct 31, 2018 at 12:06 AM Changbin Du wrote: > > On Tue, Oct 30, 2018 at 12:21:52PM +0100, Miguel Ojeda wrote: > > On Tue, Oct 30, 2018 at 12:49 AM Stephen Rothwell > > wrote: > > > > > > Hi all, > > > > > > On Tue, 30 Oct 2018 10:46:37 +1100 Stephen Rothwell > > > wrote: > > > > > > >

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Mauro Carvalho Chehab
Em Sun, 28 Oct 2018 14:08:31 -0700 Linus Torvalds escreveu: > On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds > wrote: > > > > So the recent change to enable the high-res scrolling really seems a > > bit *too* extreme. > > > > Is there some middle ground that turns the mouse from "look at it > >

[PATCH v3 4/5] tpm: retrieve digest size of unknown algorithms with PCR read

2018-10-30 Thread Roberto Sassu
Currently, the TPM driver retrieves the digest size from a table mapping TPM algorithms identifiers to identifiers defined by the crypto subsystem. If the algorithm is not defined by the latter, the digest size can be retrieved from the output of the PCR read command. The patch retrieves at TPM st

[PATCH v3 5/5] tpm: ensure that output of PCR read contains the correct digest size

2018-10-30 Thread Roberto Sassu
This patch ensures that the digest size returned by the TPM during a PCR read matches the size of the algorithm passed as argument to tpm2_pcr_read(). The check is performed after information about the PCR banks has been retrieved. Signed-off-by: Roberto Sassu --- drivers/char/tpm/tpm2-cmd.c | 1

[PATCH v3 3/5] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm

2018-10-30 Thread Roberto Sassu
Currently the TPM driver allows other kernel subsystems to read only the SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and tpm2_pcr_read() to pass a tpm_digest structure, which contains the desired hash algorithm. Also, since commit 125a22105410 ("tpm: React correctly to RC_TE

[PATCH v3 2/5] tpm: rename and export tpm2_digest and tpm2_algorithms

2018-10-30 Thread Roberto Sassu
Rename tpm2_* to tpm_* and move the definitions to include/linux/tpm.h so that these can be used by other kernel subsystems (e.g. IMA). Signed-off-by: Roberto Sassu Reviewed-by: Jarkko Sakkinen Acked-by: Mimi Zohar --- drivers/char/tpm/tpm-interface.c | 2 +- drivers/char/tpm/tpm.h

[PATCH 2/2] thermal: broadcom: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Julia Lawall
The thermal_zone_of_device_ops structure can be const as it is only passed as the last argument of thermal_zone_of_sensor_register and the corresponding parameter is declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- Unrelated to this change, is there a reason

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-10-30 Thread Emil Velikov
On Tue, 30 Oct 2018 at 13:52, Gerd Hoffmann wrote: > > On Tue, Oct 30, 2018 at 11:31:04AM +, Emil Velikov wrote: > > HI Gerd, > > > > On Tue, 30 Oct 2018 at 06:11, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > The execbuffer IOCTL is now read-write to allow the userspace to read > > >

[PATCH v3 1/5] tpm: change the end marker of the active_banks array to zero

2018-10-30 Thread Roberto Sassu
This patch changes the end marker of the active_banks array from TPM2_ALG_ERROR to zero. Signed-off-by: Roberto Sassu --- drivers/char/tpm/tpm-interface.c | 2 +- drivers/char/tpm/tpm2-cmd.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/char/tpm/tpm-interfac

[PATCH 1/2] thermal: armada: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Julia Lawall
The thermal_zone_of_device_ops structure can be const as it is only passed as the last argument of devm_thermal_zone_of_sensor_register and the corresponding parameter is declared as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/thermal/armada_thermal.c |

[PATCH 0/2] constify thermal_zone_of_device_ops structures

2018-10-30 Thread Julia Lawall
The thermal_zone_of_device_ops structures can be const as they are only passed as the last argument of a thermal_zone_of_sensor_register function and the corresponding parameter is declared as const. Done with the help of Coccinelle. --- drivers/thermal/armada_thermal.c |2 +- dri

[PATCH v3 0/5] tpm: retrieve digest size of unknown algorithms from TPM

2018-10-30 Thread Roberto Sassu
The TPM driver currently relies on the crypto subsystem to determine the digest size of supported TPM algorithms. In the future, TPM vendors might implement new algorithms in their chips, and those algorithms might not be supported by the crypto subsystem. Usually, vendors provide patches for the

Re: [PATCH] ASoC: AMD: Fix race condition between register access

2018-10-30 Thread Agrawal, Akshu
On 10/30/2018 7:02 AM, Daniel Kurtz wrote: > Hi Akshu, > > > On Mon, Oct 29, 2018 at 1:39 AM Agrawal, Akshu wrote: >> >> During simultaneous running of playback and capture, we >> got hit by incorrect value write on common register. This was due >> to race condition between 2 streams. >> Fixin

Re: [RFC PATCH v2 01/17] OPP: Allow to request stub voltage regulators

2018-10-30 Thread Dmitry Osipenko
On 10/29/18 9:53 AM, Viresh Kumar wrote: > On 26-10-18, 15:03, Dmitry Osipenko wrote: >> On 10/24/18 9:41 AM, Viresh Kumar wrote: >>> On 22-10-18, 15:12, Dmitry Osipenko wrote: Because there is one Tegra20 board (tegra20-trimslice) that doesn't declare necessary regulators, but we want to

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying these patches do not forget to remove the revert of the "Stop-marking-clocks-as-CLK_IS_CRITICA

Re: [PATCH] perf cs-etm: Correct CPU mode for samples

2018-10-30 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2018 at 05:30:55PM +0200, Adrian Hunter escreveu: > On 30/10/18 5:11 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Oct 30, 2018 at 11:04:49PM +0800, leo@linaro.org escreveu: > >> Hi Arnaldo, > >> > >> On Tue, Oct 30, 2018 at 11:32:26AM -0300, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH] sched/rt: Remove unnecessary CONFIG_RT_GROUP_SCHED in rt_se_prio()

2018-10-30 Thread 宋牧春
t rt_rq' will have member named 'highest_prio'. So, this patch does't make sense. kbuild test robot 于2018年10月30日周二 下午11:14写道: > > Hi Muchun, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tip/sched/core] > [also build tes

RE: [PATCH] tlclk: lean an indentation issue, remove extraneous tabs

2018-10-30 Thread Gross, Mark
Looks cool to me. Reviewed-by --mark > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, October 30, 2018 4:57 AM > To: Gross, Mark ; Arnd Bergmann ; > Greg Kroah-Hartman > Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org > Subjec

Re: [PATCH 13/17] prmem: linked list: disable layout randomization

2018-10-30 Thread Peter Zijlstra
On Fri, Oct 26, 2018 at 03:17:07AM -0700, Matthew Wilcox wrote: > On Fri, Oct 26, 2018 at 11:32:05AM +0200, Peter Zijlstra wrote: > > On Wed, Oct 24, 2018 at 12:35:00AM +0300, Igor Stoppa wrote: > > > Some of the data structures used in list management are composed by two > > > pointers. Since the

Re: Crash report: Broken NUMA distance map causes crash on arm64 system

2018-10-30 Thread John Garry
On 30/10/2018 09:55, John Garry wrote: On 30/10/2018 09:26, Peter Zijlstra wrote: On Tue, Oct 23, 2018 at 11:30:11AM +0100, John Garry wrote: Hi all, I have stumbled upon this crash on my arm64 system: [7.040874] SMP: Total of 64 processors activated. [7.045720] CPU features: detected

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
Hi Oleg, On Tue, Oct 30, 2018 at 03:32:36PM +0100, Oleg Nesterov wrote: > On 10/29, Tycho Andersen wrote: > > > > + /* This is where we wait for a reply from userspace. */ > > + err = wait_for_completion_interruptible(&n.ready); > > + mutex_lock(&match->notify_lock); > > + > > + /* > > +

Re: [PATCH] perf cs-etm: Correct CPU mode for samples

2018-10-30 Thread Adrian Hunter
On 30/10/18 5:11 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 30, 2018 at 11:04:49PM +0800, leo@linaro.org escreveu: >> Hi Arnaldo, >> >> On Tue, Oct 30, 2018 at 11:32:26AM -0300, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Oct 30, 2018 at 03:18:28PM +0800, Leo Yan escreveu: Since com

Re: [PATCH 3/3] kprobes/x86: Simplify indirect-jump check in retpoline

2018-10-30 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 11:55:06PM -0700, Zhenzhong Duan wrote: > Since CONFIG_RETPOLINE hard depends on compiler support now, so > replacing indirect-jump check with the range check is safe in that case. Can we put kprobes on module init text before we run alternatives on it? > @@ -240,20 +242,1

Re: [PATCH v2 1/2] sched/fair: Cleanup load_balance() condition

2018-10-30 Thread Peter Zijlstra
On Tue, Oct 30, 2018 at 10:27:59AM +, Valentin Schneider wrote: > Hi, > > On 26/09/2018 16:12, Valentin Schneider wrote: > > The alignment of the condition is off, clean that up. > > > > Also, logical operators have lower precedence than bitwise/relational > > operators, so remove one layer o

Re: [PATCH 1/3] retpolines: Only enable retpoline when compiler support it

2018-10-30 Thread Peter Zijlstra
On Mon, Oct 29, 2018 at 11:55:04PM -0700, Zhenzhong Duan wrote: > Since retpoline capable compilers are widely available, make > CONFIG_RETPOLINE hard depend on it. > > Change KBUILD to use CONFIG_RETPOLINE_SUPPORT to avoid conflict with > CONFIG_RETPOLINE which is used by kernel. > > With all th

Re: [RFC][PATCH v1] ACPI / scan: Create platform device for BOSC0200 ACPI nodes

2018-10-30 Thread Hans de Goede
Hi, On 30-10-18 15:47, Andy Shevchenko wrote: On some laptops the ACPI device with BOSC0200 _HID is representing two accelerometers under one node. We add an ID to the I2C multi instantiate list to enumerate all I2C slaves correctly. I believe that overall the approach here is correct, but I'

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 10:03 AM, Andy Shevchenko wrote: On Tue, Oct 30, 2018 at 4:48 PM Hans de Goede wrote: On 30-10-18 15:38, Dean Wallace wrote: Excellent work Hans. Compiled 4.19 with 0001-ASoC-intel-cht_bsw_max98090_ti-Use-pmc_plt_clk_0-ins.patch, sound works as before. for i in /sys/kernel/debu

<    1   2   3   4   5   6   7   >