Re: [PATCH AUTOSEL 4.14 17/19] selftests: ftrace: Add synthetic event syntax testcase

2018-10-30 Thread Sasha Levin
On Tue, Oct 30, 2018 at 10:58:15AM -0400, Steven Rostedt wrote: On Tue, 30 Oct 2018 09:28:22 -0400 Sasha Levin wrote: From: Masami Hiramatsu [ Upstream commit ba0e41ca81b935b958006c7120466e2217357827 ] Add a testcase to check the syntax and field types for synthetic_events interface.

Re: [PATCH AUTOSEL 4.14 17/19] selftests: ftrace: Add synthetic event syntax testcase

2018-10-30 Thread Sasha Levin
On Tue, Oct 30, 2018 at 10:58:15AM -0400, Steven Rostedt wrote: On Tue, 30 Oct 2018 09:28:22 -0400 Sasha Levin wrote: From: Masami Hiramatsu [ Upstream commit ba0e41ca81b935b958006c7120466e2217357827 ] Add a testcase to check the syntax and field types for synthetic_events interface.

[PATCH] firmware: raspberrypi: Define timeout for transactions

2018-10-30 Thread Stefan Wahren
We should never assume to get a reply from the firmware otherwise the call could block forever and the user don't get informed. So define a timeout of 1 sec and print a stacktrace once in the unlikely case the timeout expired. Signed-off-by: Stefan Wahren --- drivers/firmware/raspberrypi.c | 8

[PATCH] firmware: raspberrypi: Define timeout for transactions

2018-10-30 Thread Stefan Wahren
We should never assume to get a reply from the firmware otherwise the call could block forever and the user don't get informed. So define a timeout of 1 sec and print a stacktrace once in the unlikely case the timeout expired. Signed-off-by: Stefan Wahren --- drivers/firmware/raspberrypi.c | 8

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR

[PATCH v2] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
Access to timerslack_ns is controlled by a process having CAP_SYS_NICE in its effective capability set, but the current check looks in the root namespace instead of the process' user namespace. Since a process is allowed to do other activities controlled by CAP_SYS_NICE inside a namespace, it

[PATCH v2] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
Access to timerslack_ns is controlled by a process having CAP_SYS_NICE in its effective capability set, but the current check looks in the root namespace instead of the process' user namespace. Since a process is allowed to do other activities controlled by CAP_SYS_NICE inside a namespace, it

Re: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-30 Thread Jeff Layton
On Tue, 2018-10-30 at 08:04 -0400, Jeff Layton wrote: > On Mon, 2018-10-29 at 08:38 -0400, Jeff Layton wrote: > > On Mon, 2018-10-29 at 12:56 +1100, NeilBrown wrote: > > > On Fri, Oct 26 2018, Jeff Layton wrote: > > > > > > > On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote: > > > > > This took

Re: [PATCH 0/9 v3] locks: avoid thundering-herd wake-ups

2018-10-30 Thread Jeff Layton
On Tue, 2018-10-30 at 08:04 -0400, Jeff Layton wrote: > On Mon, 2018-10-29 at 08:38 -0400, Jeff Layton wrote: > > On Mon, 2018-10-29 at 12:56 +1100, NeilBrown wrote: > > > On Fri, Oct 26 2018, Jeff Layton wrote: > > > > > > > On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote: > > > > > This took

Re: [PATCH] mm: handle no memcg case in memcg_kmem_charge() properly

2018-10-30 Thread Shakeel Butt
On Tue, Oct 30, 2018 at 8:56 AM Roman Gushchin wrote: > > On Tue, Oct 30, 2018 at 07:12:49AM +0100, Michal Hocko wrote: > > On Mon 29-10-18 21:51:55, Roman Gushchin wrote: > > > Mike Galbraith reported a regression caused by the commit 9b6f7e163cd0 > > > ("mm: rework memcg kernel stack

Re: [PATCH] mm: handle no memcg case in memcg_kmem_charge() properly

2018-10-30 Thread Shakeel Butt
On Tue, Oct 30, 2018 at 8:56 AM Roman Gushchin wrote: > > On Tue, Oct 30, 2018 at 07:12:49AM +0100, Michal Hocko wrote: > > On Mon 29-10-18 21:51:55, Roman Gushchin wrote: > > > Mike Galbraith reported a regression caused by the commit 9b6f7e163cd0 > > > ("mm: rework memcg kernel stack

Re: [PATCH RFC kenrel/rcu] Eliminate BUG_ON() for sync.c

2018-10-30 Thread Paul E. McKenney
On Mon, Oct 22, 2018 at 06:14:40PM +0200, Oleg Nesterov wrote: > On 10/22, Paul E. McKenney wrote: > > > > > > @@ -125,12 +125,12 @@ void rcu_sync_enter(struct rcu_sync *rsp) > > > > rsp->gp_state = GP_PENDING; > > > > spin_unlock_irq(>rss_lock); > > > > > > > > -

Re: [PATCH RFC kenrel/rcu] Eliminate BUG_ON() for sync.c

2018-10-30 Thread Paul E. McKenney
On Mon, Oct 22, 2018 at 06:14:40PM +0200, Oleg Nesterov wrote: > On 10/22, Paul E. McKenney wrote: > > > > > > @@ -125,12 +125,12 @@ void rcu_sync_enter(struct rcu_sync *rsp) > > > > rsp->gp_state = GP_PENDING; > > > > spin_unlock_irq(>rss_lock); > > > > > > > > -

RE: [PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Bae, Chang Seok
> Factor out the code to change index from x86_fsbase_write_cpu() and > x86_gsbase_write_cpu_inactive(). Now the code is located in > do_arch_prctl_64(). > > The helper functions that purport to write the base register should just > write the > base register only. It shouldn't have magic

RE: [PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Bae, Chang Seok
> Factor out the code to change index from x86_fsbase_write_cpu() and > x86_gsbase_write_cpu_inactive(). Now the code is located in > do_arch_prctl_64(). > > The helper functions that purport to write the base register should just > write the > base register only. It shouldn't have magic

[PATCH] mm: hide incomplete nr_indirectly_reclaimable in /proc/zoneinfo

2018-10-30 Thread Roman Gushchin
Yongqin reported that /proc/zoneinfo format is broken in 4.14 due to commit 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in /proc/vmstat") Node 0, zone DMA per-node stats nr_inactive_anon 403 nr_active_anon 89123 nr_inactive_file 128887 nr_active_file

[PATCH] mm: hide incomplete nr_indirectly_reclaimable in /proc/zoneinfo

2018-10-30 Thread Roman Gushchin
Yongqin reported that /proc/zoneinfo format is broken in 4.14 due to commit 7aaf77272358 ("mm: don't show nr_indirectly_reclaimable in /proc/vmstat") Node 0, zone DMA per-node stats nr_inactive_anon 403 nr_active_anon 89123 nr_inactive_file 128887 nr_active_file

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Harry Cutts
Thanks for the analysis, Peter. On Mon, 29 Oct 2018 at 23:27, Peter Hutterer wrote: > IMO this is a lost battle because you cannot know when the ratchet is > enabled or not (at least not on all mice). Users switch between ratchet and > freewheeling time and once you're out of one mode, you have

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Harry Cutts
Thanks for the analysis, Peter. On Mon, 29 Oct 2018 at 23:27, Peter Hutterer wrote: > IMO this is a lost battle because you cannot know when the ratchet is > enabled or not (at least not on all mice). Users switch between ratchet and > freewheeling time and once you're out of one mode, you have

RE: [PATCH] Choose CPU based on allocated IRQs

2018-10-30 Thread Long Li
> Subject: Re: [PATCH] Choose CPU based on allocated IRQs > > Long, > > On Tue, 23 Oct 2018, Long Li wrote: > > thanks for this patch. > > A trivial formal thing ahead. The subject line > >[PATCH] Choose CPU based on allocated IRQs > > is lacking a proper subsystem prefix. In most cases

RE: [PATCH] Choose CPU based on allocated IRQs

2018-10-30 Thread Long Li
> Subject: Re: [PATCH] Choose CPU based on allocated IRQs > > Long, > > On Tue, 23 Oct 2018, Long Li wrote: > > thanks for this patch. > > A trivial formal thing ahead. The subject line > >[PATCH] Choose CPU based on allocated IRQs > > is lacking a proper subsystem prefix. In most cases

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-30 Thread William Cohen
On 10/22/18 5:30 AM, Kees Cook wrote: > The arm compiler internally interprets an inline assembly label > as an unsigned long value, not a pointer. As a result, under > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address > of a label is 4 bytes, which was tripping the runtime

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

2018-10-30 Thread William Cohen
On 10/22/18 5:30 AM, Kees Cook wrote: > The arm compiler internally interprets an inline assembly label > as an unsigned long value, not a pointer. As a result, under > CONFIG_FORTIFY_SOURCE, the size of the array pointed to by an address > of a label is 4 bytes, which was tripping the runtime

[PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Chang S. Bae
Factor out the code to change index from x86_fsbase_write_cpu() and x86_gsbase_write_cpu_inactive(). Now the code is located in do_arch_prctl_64(). The helper functions that purport to write the base register should just write the base register only. It shouldn't have magic optimizations to

[PATCH] x86/fsgsbase/64: Fix the base write helper functions

2018-10-30 Thread Chang S. Bae
Factor out the code to change index from x86_fsbase_write_cpu() and x86_gsbase_write_cpu_inactive(). Now the code is located in do_arch_prctl_64(). The helper functions that purport to write the base register should just write the base register only. It shouldn't have magic optimizations to

[PATCH v2] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P.L.S.S.S.N
Add device bindings for cpuidle states for cpu devices. Cc: Signed-off-by: Raju P.L.S.S.S.N --- Changes in v2 - Address comments from Doug --- --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 62 1 file changed, 62 insertions(+) diff --git

[PATCH v2] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P.L.S.S.S.N
Add device bindings for cpuidle states for cpu devices. Cc: Signed-off-by: Raju P.L.S.S.S.N --- Changes in v2 - Address comments from Doug --- --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 62 1 file changed, 62 insertions(+) diff --git

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 05:39:26PM +0100, Oleg Nesterov wrote: > On 10/30, Oleg Nesterov wrote: > > > > On 10/30, Tycho Andersen wrote: > > > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > > struct seccomp_data *sd, > > >*/ > > > rmb(); > > > > > > + if

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Tycho Andersen
On Tue, Oct 30, 2018 at 05:39:26PM +0100, Oleg Nesterov wrote: > On 10/30, Oleg Nesterov wrote: > > > > On 10/30, Tycho Andersen wrote: > > > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > > struct seccomp_data *sd, > > >*/ > > > rmb(); > > > > > > + if

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Greg, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Greg, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Arnd, Olof, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land,

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
Hi Arnd, Olof, On 10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land,

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Santosh Shilimkar
10/30/2018 4:11 AM, Marc Zyngier wrote: The Keystone QMSS driver is pretty damaged, in the sense that it does things like this: irq_set_affinity_hint(irq, to_cpumask(_map)); where cpu_map is a local variable. As we leave the function, this will point to nowhere-land, and things will

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Florian Fainelli
On 10/30/18 4:11 AM, Marc Zyngier wrote: > The Keystone QMSS driver is pretty damaged, in the sense that it > does things like this: > > irq_set_affinity_hint(irq, to_cpumask(_map)); > > where cpu_map is a local variable. As we leave the function, this > will point to nowhere-land, and

Re: [GIT PULL] tracing: Updates for 4.20 (or 5.0)

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:37 AM Steven Rostedt wrote: > > The biggest change here is the updates to kprobes Pulled. However, a little note: > - Added support for SDT in uprobes As an explanation, the above kind of sucks. "SDT"? I had to look it up. I added a note to the commit message, but

Re: [GIT PULL] tracing: Updates for 4.20 (or 5.0)

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:37 AM Steven Rostedt wrote: > > The biggest change here is the updates to kprobes Pulled. However, a little note: > - Added support for SDT in uprobes As an explanation, the above kind of sucks. "SDT"? I had to look it up. I added a note to the commit message, but

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread Florian Fainelli
On 10/30/18 4:11 AM, Marc Zyngier wrote: > The Keystone QMSS driver is pretty damaged, in the sense that it > does things like this: > > irq_set_affinity_hint(irq, to_cpumask(_map)); > > where cpu_map is a local variable. As we leave the function, this > will point to nowhere-land, and

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Joel Fernandes
On Tue, Oct 30, 2018 at 1:50 AM Daniel Colascione wrote: > > On Tue, Oct 30, 2018 at 3:21 AM, Joel Fernandes wrote: > > On Mon, Oct 29, 2018 at 3:11 PM Daniel Colascione wrote: > >> > >> Add a simple proc-based kill interface. To use /proc/pid/kill, just > >> write the signal number in base-10

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-30 Thread Joel Fernandes
On Tue, Oct 30, 2018 at 1:50 AM Daniel Colascione wrote: > > On Tue, Oct 30, 2018 at 3:21 AM, Joel Fernandes wrote: > > On Mon, Oct 29, 2018 at 3:11 PM Daniel Colascione wrote: > >> > >> Add a simple proc-based kill interface. To use /proc/pid/kill, just > >> write the signal number in base-10

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

Re:Business proposition for you

2018-10-30 Thread Melvin Greg
Hello, I have a client from Syrian who will like to invest with your company. My client is willing to invest $4 Million. Can I have your company website to show to my client your company so that they will check and decide if they will invest there funds with you as joint partner. This

Re:Business proposition for you

2018-10-30 Thread Melvin Greg
Hello, I have a client from Syrian who will like to invest with your company. My client is willing to invest $4 Million. Can I have your company website to show to my client your company so that they will check and decide if they will invest there funds with you as joint partner. This

Re: [PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 17:08, Julia Lawall wrote: > Using devm_thermal_zone_of_sensor_register allows to simplify some > error handling code, drop a label, and drop the remove function. > > Signed-off-by: Julia Lawall Reviewed-by: Daniel Lezcano > --- > > This patch is completely orthogonal to the

Re: [PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 17:08, Julia Lawall wrote: > Using devm_thermal_zone_of_sensor_register allows to simplify some > error handling code, drop a label, and drop the remove function. > > Signed-off-by: Julia Lawall Reviewed-by: Daniel Lezcano > --- > > This patch is completely orthogonal to the

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Doug Anderson
Resending since I accidentally clicked back to HTML and lists all bounced. :( On Tue, Oct 30, 2018 at 9:24 AM Raju P L S S S N wrote: > > On 10/24/2018 12:06 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N > > wrote: > >> + idle-states {

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Doug Anderson
Resending since I accidentally clicked back to HTML and lists all bounced. :( On Tue, Oct 30, 2018 at 9:24 AM Raju P L S S S N wrote: > > On 10/24/2018 12:06 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N > > wrote: > >> + idle-states {

Re: [PATCH 0/2] [GIT PULL] tracing: Fixes to synthetic events

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:15 AM Steven Rostedt wrote: > > This is not my 4.20 pull request (that will be coming shortly). This > is just some last minute fixes that Masami sent me that I finally got > around to test. Pulled. Real pull request is next, Linus

Re: [PATCH 0/2] [GIT PULL] tracing: Fixes to synthetic events

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 6:15 AM Steven Rostedt wrote: > > This is not my 4.20 pull request (that will be coming shortly). This > is just some last minute fixes that Masami sent me that I finally got > around to test. Pulled. Real pull request is next, Linus

Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification

2018-10-30 Thread Oleg Nesterov
On 10/29, Enke Chen wrote: > > Reviewed-by: Oleg Nesterov Hmm. I didn't say this ;) But OK, feel free to keep this tag. I do not like this feauture. But I see no technical problems in this version and I never pretented I understand the user-space needs, so I won't argue. Oleg.

Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification

2018-10-30 Thread Oleg Nesterov
On 10/29, Enke Chen wrote: > > Reviewed-by: Oleg Nesterov Hmm. I didn't say this ;) But OK, feel free to keep this tag. I do not like this feauture. But I see no technical problems in this version and I never pretented I understand the user-space needs, so I won't argue. Oleg.

[PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Julia Lawall
Using devm_thermal_zone_of_sensor_register allows to simplify some error handling code, drop a label, and drop the remove function. Signed-off-by: Julia Lawall --- This patch is completely orthogonal to the recent constification patch. drivers/thermal/broadcom/brcmstb_thermal.c | 24

[PATCH] thermal: broadcom: use devm_thermal_zone_of_sensor_register

2018-10-30 Thread Julia Lawall
Using devm_thermal_zone_of_sensor_register allows to simplify some error handling code, drop a label, and drop the remove function. Signed-off-by: Julia Lawall --- This patch is completely orthogonal to the recent constification patch. drivers/thermal/broadcom/brcmstb_thermal.c | 24

Re: [PATCH 2/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge

2018-10-30 Thread Luca Ceresoli
Hi Vladimir, On 08/10/18 23:12, Vladimir Zapolskiy wrote: > From: Vladimir Zapolskiy > > TI DS90Ux9xx de-/serializers are capable to route I2C messages to > I2C slave devices connected to a remote de-/serializer in a pair, > the change adds description of device tree bindings of the

Re: [PATCH 2/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge

2018-10-30 Thread Luca Ceresoli
Hi Vladimir, On 08/10/18 23:12, Vladimir Zapolskiy wrote: > From: Vladimir Zapolskiy > > TI DS90Ux9xx de-/serializers are capable to route I2C messages to > I2C slave devices connected to a remote de-/serializer in a pair, > the change adds description of device tree bindings of the

Re: [PATCH] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
On Thu, Oct 25, 2018 at 01:56:27PM -0500, Eric W. Biederman wrote: > > Access to timerslack_ns is controlled by a process having CAP_SYS_NICE > > in its effective capability set, but the current check looks in the root > > namespace instead of the process' user namespace. Since a process is > >

Re: [PATCH] proc: use ns_capable instead of capable for timerslack_ns

2018-10-30 Thread Benjamin Gordon
On Thu, Oct 25, 2018 at 01:56:27PM -0500, Eric W. Biederman wrote: > > Access to timerslack_ns is controlled by a process having CAP_SYS_NICE > > in its effective capability set, but the current check looks in the root > > namespace instead of the process' user namespace. Since a process is > >

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Oleg Nesterov wrote: > > On 10/30, Tycho Andersen wrote: > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > struct seccomp_data *sd, > > */ > > rmb(); > > > > + if (!sd) { > > + populate_seccomp_data(_local); > > + sd =

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Oleg Nesterov wrote: > > On 10/30, Tycho Andersen wrote: > > > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > > struct seccomp_data *sd, > > */ > > rmb(); > > > > + if (!sd) { > > + populate_seccomp_data(_local); > > + sd =

Re: [alsa-devel] [PATCH] ASoC: stm32: sai: fix invalid use of sizeof in stm32_sai_add_mclk_provider()

2018-10-30 Thread Mark Brown
On Sat, Oct 27, 2018 at 02:19:59AM +, Wei Yongjun wrote: > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. Someone else already sent a fix for this. signature.asc Description: PGP signature

Re: [alsa-devel] [PATCH] ASoC: stm32: sai: fix invalid use of sizeof in stm32_sai_add_mclk_provider()

2018-10-30 Thread Mark Brown
On Sat, Oct 27, 2018 at 02:19:59AM +, Wei Yongjun wrote: > sizeof() when applied to a pointer typed expression gives the > size of the pointer, not that of the pointed data. Someone else already sent a fix for this. signature.asc Description: PGP signature

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-30 Thread Stephen Boyd
Quoting Taniya Das (2018-10-29 23:01:44) > On 10/30/2018 12:13 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-28 03:34:55) > >> On 2018-10-19 16:04, Taniya Das wrote: > >>> On 10/10/2018 2:04 AM, Stephen Boyd wrote: > Quoting Taniya Das (2018-10-09 06:57:47) > > diff --git

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-30 Thread Stephen Boyd
Quoting Taniya Das (2018-10-29 23:01:44) > On 10/30/2018 12:13 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-28 03:34:55) > >> On 2018-10-19 16:04, Taniya Das wrote: > >>> On 10/10/2018 2:04 AM, Stephen Boyd wrote: > Quoting Taniya Das (2018-10-09 06:57:47) > > diff --git

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 11:27 PM Peter Hutterer wrote: > > Other issues I found with an MX Anywhere 2S is that on slow scroll and in > ratchet mode we get some scroll jitter. In ratchet mode we can get this > sequence if you scroll just past the notch and it snaps back: > [1, 1, 1, 1, 1, 1,

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 11:27 PM Peter Hutterer wrote: > > Other issues I found with an MX Anywhere 2S is that on slow scroll and in > ratchet mode we get some scroll jitter. In ratchet mode we can get this > sequence if you scroll just past the notch and it snaps back: > [1, 1, 1, 1, 1, 1,

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-30 Thread Will Deacon
On Tue, Oct 30, 2018 at 04:58:41PM +0100, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 11:17:14PM +0200, Igor Stoppa wrote: > > > > > > On 25/10/2018 01:13, Peter Zijlstra wrote: > > > On Wed, Oct 24, 2018 at 12:35:03AM +0300, Igor Stoppa wrote: > > > > +static __always_inline > > > > +bool

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
Thank you Juergen for your comments. I will soon send v2 patch. -Thanks, Manjunath On 10/30/2018 12:04 AM, Juergen Gross wrote: On 29/10/2018 19:31, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path.

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-30 Thread Will Deacon
On Tue, Oct 30, 2018 at 04:58:41PM +0100, Peter Zijlstra wrote: > On Mon, Oct 29, 2018 at 11:17:14PM +0200, Igor Stoppa wrote: > > > > > > On 25/10/2018 01:13, Peter Zijlstra wrote: > > > On Wed, Oct 24, 2018 at 12:35:03AM +0300, Igor Stoppa wrote: > > > > +static __always_inline > > > > +bool

Re: [Xen-devel] [PATCH] xen-blkfront: fix kernel panic with negotiate_mq error path

2018-10-30 Thread Manjunath Patil
Thank you Juergen for your comments. I will soon send v2 patch. -Thanks, Manjunath On 10/30/2018 12:04 AM, Juergen Gross wrote: On 29/10/2018 19:31, Manjunath Patil wrote: info->nr_rings isn't adjusted in case of ENOMEM error from negotiate_mq(). This leads to kernel panic in error path.

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Tycho Andersen wrote: > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > struct seccomp_data *sd, >*/ > rmb(); > > + if (!sd) { > + populate_seccomp_data(_local); > + sd = _local; > + } > + To me it would be

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying

Re: [PATCH v8 1/2] seccomp: add a return code to trap to userspace

2018-10-30 Thread Oleg Nesterov
On 10/30, Tycho Andersen wrote: > > @@ -828,6 +823,11 @@ static int __seccomp_filter(int this_syscall, const > struct seccomp_data *sd, >*/ > rmb(); > > + if (!sd) { > + populate_seccomp_data(_local); > + sd = _local; > + } > + To me it would be

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Pierre-Louis Bossart
On 10/30/18 11:02 AM, Hans de Goede wrote: Hi, On 30-10-18 16:46, Hans de Goede wrote: Hi, On 30-10-18 16:04, Pierre-Louis Bossart wrote: On 10/30/18 9:38 AM, Dean Wallace wrote: On 30-10-18, Hans de Goede wrote: Hi Dean, Attached are 2 different attempts at fixing this. When trying

[PATCH v2] ASoC: AMD: Fix race condition between register access

2018-10-30 Thread Agrawal, Akshu
During simultaneous running of playback and capture, we got hit by incorrect value write on common register. This was due to race condition between 2 streams. Fixing this by locking the common register access. Signed-off-by: Akshu Agrawal --- v2: Added 2 helper functions, removed locking in ch

[PATCH v2] ASoC: AMD: Fix race condition between register access

2018-10-30 Thread Agrawal, Akshu
During simultaneous running of playback and capture, we got hit by incorrect value write on common register. This was due to race condition between 2 streams. Fixing this by locking the common register access. Signed-off-by: Akshu Agrawal --- v2: Added 2 helper functions, removed locking in ch

Re: Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-30 Thread Stephen Boyd
Quoting wang.y...@zte.com.cn (2018-10-29 23:13:24) > > Quoting Yi Wang (2018-10-29 01:31:47) > > > 'onecell' is malloced in clk_boston_setup(), but is not freed > > > before leaving from the error handling cases. > > > > How did you find this? Visual inspection? Some coccinelle script? > > Smatch

Re: Re: [PATCH v2] clk: boston: fix possible memory leak in clk_boston_setup()

2018-10-30 Thread Stephen Boyd
Quoting wang.y...@zte.com.cn (2018-10-29 23:13:24) > > Quoting Yi Wang (2018-10-29 01:31:47) > > > 'onecell' is malloced in clk_boston_setup(), but is not freed > > > before leaving from the error handling cases. > > > > How did you find this? Visual inspection? Some coccinelle script? > > Smatch

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 1:05 PM Hans de Goede wrote: > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat > $i/clk_flags; echo; done Just a side note about nice tool, called `grep` :-) grep -H . /sys/kernel/debug/clk/pmc_plt_clk_*/clk_flags does above in one call. -- With

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 1:05 PM Hans de Goede wrote: > for i in /sys/kernel/debug/clk/pmc_plt_clk_?; do echo -n "$i: "; cat > $i/clk_flags; echo; done Just a side note about nice tool, called `grep` :-) grep -H . /sys/kernel/debug/clk/pmc_plt_clk_*/clk_flags does above in one call. -- With

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P L S S S N
On 10/24/2018 12:06 AM, Doug Anderson wrote: Hi, On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N wrote: + idle-states { + entry-method = "psci"; + + C0_CPU_SPC: c0_spc { nit: all these nodes should have dashes instead of spaces

Re: [PATCH] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-30 Thread Raju P L S S S N
On 10/24/2018 12:06 AM, Doug Anderson wrote: Hi, On Mon, Oct 15, 2018 at 10:02 AM Raju P.L.S.S.S.N wrote: + idle-states { + entry-method = "psci"; + + C0_CPU_SPC: c0_spc { nit: all these nodes should have dashes instead of spaces

Re: Build error in drivers/cpufreq/intel_pstate.c

2018-10-30 Thread Srinivas Pandruvada
Hi, On Tue, 2018-10-30 at 18:00 +0200, Igor Stoppa wrote: > Hi, > I'm getting the following build error: > > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c: In > function > ‘show_base_frequency’: > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c:726:10: > error: implicit

Re: Build error in drivers/cpufreq/intel_pstate.c

2018-10-30 Thread Srinivas Pandruvada
Hi, On Tue, 2018-10-30 at 18:00 +0200, Igor Stoppa wrote: > Hi, > I'm getting the following build error: > > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c: In > function > ‘show_base_frequency’: > /home/igor/dev/kernel/linux/drivers/cpufreq/intel_pstate.c:726:10: > error: implicit

Re: [PATCH 2/2] thermal: broadcom: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:15, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia

Re: [PATCH 2/2] thermal: broadcom: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:15, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia

Re: [PATCH 1/2] thermal: armada: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:14, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of devm_thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by:

Re: [PATCH 1/2] thermal: armada: constify thermal_zone_of_device_ops structure

2018-10-30 Thread Daniel Lezcano
On 30/10/2018 16:14, Julia Lawall wrote: > The thermal_zone_of_device_ops structure can be const as it is only > passed as the last argument of devm_thermal_zone_of_sensor_register > and the corresponding parameter is declared as const. > > Done with the help of Coccinelle. > > Signed-off-by:

Re: [PATCH] arm64: dts: qcom: msm8998: Reserve gpio ranges on MTP

2018-10-30 Thread Jeffrey Hugo
On 10/29/2018 11:45 PM, Bjorn Andersson wrote: GPIOs 0 through 3 and 81 through 84 are configured to not be accessible from the application CPUs. Mark them as reserved to allow the MSM8998 MTP to boot after the introduction of 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").

Re: [PATCH] arm64: dts: qcom: msm8998: Reserve gpio ranges on MTP

2018-10-30 Thread Jeffrey Hugo
On 10/29/2018 11:45 PM, Bjorn Andersson wrote: GPIOs 0 through 3 and 81 through 84 are configured to not be accessible from the application CPUs. Mark them as reserved to allow the MSM8998 MTP to boot after the introduction of 3edfb7bd76bd ("gpiolib: Show correct direction from the beginning").

Re: [GIT PULL] More ACPI updates for v4.20-rc1

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 1:30 AM Rafael J. Wysocki wrote: > > These rework the handling of the P-unit semaphore on Intel > Baytrail and Cherrytrail systems to avoid race conditions and > excessive overhead related to it (Hans de Goede). Pulled, Linus

Re: [GIT PULL] More ACPI updates for v4.20-rc1

2018-10-30 Thread Linus Torvalds
On Tue, Oct 30, 2018 at 1:30 AM Rafael J. Wysocki wrote: > > These rework the handling of the P-unit semaphore on Intel > Baytrail and Cherrytrail systems to avoid race conditions and > excessive overhead related to it (Hans de Goede). Pulled, Linus

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-30 Thread Pekka Pessi
I guess it being an example doesn't make it strictly a recommendation, but I wonder if we should avoid giving examples that use mappings which we discourage. Well, yes, that is example for top0 – but I agree, giving examples that do not make much sense is not very productive. So currently

Re: [PATCH 4/9] mailbox: tegra-hsp: Add support for shared mailboxes

2018-10-30 Thread Pekka Pessi
I guess it being an example doesn't make it strictly a recommendation, but I wonder if we should avoid giving examples that use mappings which we discourage. Well, yes, that is example for top0 – but I agree, giving examples that do not make much sense is not very productive. So currently

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Dean Wallace
On 30-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > Hi, > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > In addition I am not aware of any baytrail device using plt_clk_0, > > > so moving a common machine driver such a cht_bsw_max98090_ti to use >

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-30 Thread Dean Wallace
On 30-10-18, Hans de Goede wrote: > Hi, > > On 30-10-18 16:46, Hans de Goede wrote: > > Hi, > > > > On 30-10-18 16:04, Pierre-Louis Bossart wrote: > > > In addition I am not aware of any baytrail device using plt_clk_0, > > > so moving a common machine driver such a cht_bsw_max98090_ti to use >

[PATCH] sched/fair: util_est: fix cpu_util_wake for execl

2018-10-30 Thread Patrick Bellasi
A ~10% regression has been reported for UnixBench's execl throughput test: Message-ID: <20180402032000.GD3101@yexl-desktop> Message-ID: <20181024064100.ga27...@intel.com> That test is pretty simple, it does a "recursive" execve syscall on the same binary. Starting from the syscall, this

[PATCH] sched/fair: util_est: fix cpu_util_wake for execl

2018-10-30 Thread Patrick Bellasi
A ~10% regression has been reported for UnixBench's execl throughput test: Message-ID: <20180402032000.GD3101@yexl-desktop> Message-ID: <20181024064100.ga27...@intel.com> That test is pretty simple, it does a "recursive" execve syscall on the same binary. Starting from the syscall, this

<    1   2   3   4   5   6   7   8   9   10   >