On Fri, Nov 2, 2018 at 4:16 PM Arnd Bergmann wrote:
> asus_wmi_evaluate_method() is an empty dummy function when CONFIG_ASUS_WMI
> is disabled, or not reachable from a built-in device driver. This leads to
> a theoretical evaluation of an uninitialized variable that the compiler
> complains
On Fri, Nov 2, 2018 at 4:16 PM Arnd Bergmann wrote:
> asus_wmi_evaluate_method() is an empty dummy function when CONFIG_ASUS_WMI
> is disabled, or not reachable from a built-in device driver. This leads to
> a theoretical evaluation of an uninitialized variable that the compiler
> complains
Randconfig testing revealed a very old bug, with gcc-8:
sound/soc/intel/atom/sst/sst_loader.c: In function 'sst_load_fw':
sound/soc/intel/atom/sst/sst_loader.c:357:5: error: 'fw' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
if (fw == NULL) {
^
Randconfig testing revealed a very old bug, with gcc-8:
sound/soc/intel/atom/sst/sst_loader.c: In function 'sst_load_fw':
sound/soc/intel/atom/sst/sst_loader.c:357:5: error: 'fw' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
if (fw == NULL) {
^
On Wed, Oct 31, 2018 at 12:58:03AM +0300, Vasily Averin wrote:
> bh was not released after error in ext4_journal_get_write_access()
>
> Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and
On Wed, Oct 31, 2018 at 12:58:03AM +0300, Vasily Averin wrote:
> bh was not released after error in ext4_journal_get_write_access()
>
> Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and
On Sat, Nov 03 2018, Paul E. McKenney wrote:
> On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
>> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>>
>> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> >> On Thu, Nov 01 2018, Paul E. McKenney wrote:
>> >>
>> >> > On Sat,
On Sat, Nov 03 2018, Paul E. McKenney wrote:
> On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
>> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>>
>> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> >> On Thu, Nov 01 2018, Paul E. McKenney wrote:
>> >>
>> >> > On Sat,
On Wed, Oct 31, 2018 at 12:57:55AM +0300, Vasily Averin wrote:
> gdb_bh must be released in case of errors before update of s_group_desc
> but it must not be released after update of group descriptors
> because in this case bh can be used later.
>
> Fixes 01f795f9e0d6 ("ext4: add online resizing
On Wed, Oct 31, 2018 at 12:57:55AM +0300, Vasily Averin wrote:
> gdb_bh must be released in case of errors before update of s_group_desc
> but it must not be released after update of group descriptors
> because in this case bh can be used later.
>
> Fixes 01f795f9e0d6 ("ext4: add online resizing
On Wed, Oct 31, 2018 at 12:57:45AM +0300, Vasily Averin wrote:
> Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") #
> 3.3
>
> Signed-off-by: Vasily Averin
Thanks, applied. I adjusted the patch summary:
ext4: add missing brelse() in set_flexbg_block_bitmap()'s
On Wed, Oct 31, 2018 at 12:57:45AM +0300, Vasily Averin wrote:
> Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") #
> 3.3
>
> Signed-off-by: Vasily Averin
Thanks, applied. I adjusted the patch summary:
ext4: add missing brelse() in set_flexbg_block_bitmap()'s
On Wed, Oct 31, 2018 at 12:57:37AM +0300, Vasily Averin wrote:
> currently bh is set to NULL only during first iteration of for cycle,
> then this pointer is not cleared after end of using.
> Therefore rollback after errors can lead to extra brelse(bh) call,
> decrements bh counter and later
On Wed, Oct 31, 2018 at 12:57:37AM +0300, Vasily Averin wrote:
> currently bh is set to NULL only during first iteration of for cycle,
> then this pointer is not cleared after end of using.
> Therefore rollback after errors can lead to extra brelse(bh) call,
> decrements bh counter and later
This reverts commit 80463f1b7bf9f822fd3495139bcf3ef254fdca10, because
it breaks the bindeb-pkg build target in the following way:
...
LD [M] sound/soc/rockchip/snd-soc-rk3399-gru-sound.ko
LD [M] sound/soc/rockchip/snd-soc-rockchip-pcm.ko
LD [M]
This reverts commit 80463f1b7bf9f822fd3495139bcf3ef254fdca10, because
it breaks the bindeb-pkg build target in the following way:
...
LD [M] sound/soc/rockchip/snd-soc-rk3399-gru-sound.ko
LD [M] sound/soc/rockchip/snd-soc-rockchip-pcm.ko
LD [M]
On Sat, 3 Nov 2018, Samuel Holland wrote:
> In d8ae72427187, start was changed to point to the character under the
> cursor, instead of the beginning of the cleared area. The offset was
> correctly applied when clearing the backing buffer, but not when
> updating the framebuffer region. Fix this
On Sat, 3 Nov 2018, Samuel Holland wrote:
> In d8ae72427187, start was changed to point to the character under the
> cursor, instead of the beginning of the cleared area. The offset was
> correctly applied when clearing the backing buffer, but not when
> updating the framebuffer region. Fix this
On Tue 2018-09-18 22:54:55, Lubomir Rintel wrote:
> The device-tree booted MMP2 needs to enable the timer clock, otherwise
> the it would stop ticking when the boot finishes.
"the it" -> "it"
> It can also use the clock rate from the clk, the non-DT boards need to
> keep using the hardcoded
On Tue 2018-09-18 22:54:55, Lubomir Rintel wrote:
> The device-tree booted MMP2 needs to enable the timer clock, otherwise
> the it would stop ticking when the boot finishes.
"the it" -> "it"
> It can also use the clock rate from the clk, the non-DT boards need to
> keep using the hardcoded
syzbot has found a reproducer for the following crash on:
HEAD commit:25e9471b6a27 Add linux-next specific files for 20181102
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1549cfe540
kernel config:
On Sat, Nov 3, 2018 at 11:45 AM Olof Johansson wrote:
>
> ARM: SoC fixes
Pulled,
Linus
syzbot has found a reproducer for the following crash on:
HEAD commit:25e9471b6a27 Add linux-next specific files for 20181102
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1549cfe540
kernel config:
On Sat, Nov 3, 2018 at 11:45 AM Olof Johansson wrote:
>
> ARM: SoC fixes
Pulled,
Linus
On Tue 2018-09-18 22:54:54, Lubomir Rintel wrote:
> The timer shall enable its clock.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> ---
> arch/arm/mach-mmp/mmp2-dt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mmp/mmp2-dt.c
On Tue 2018-09-18 22:54:54, Lubomir Rintel wrote:
> The timer shall enable its clock.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> ---
> arch/arm/mach-mmp/mmp2-dt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mmp/mmp2-dt.c
On Tue 2018-09-18 22:54:53, Lubomir Rintel wrote:
> The timer needs the timer clock to be enabled, otherwise it stops
> ticking.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> ---
> arch/arm/boot/dts/mmp2.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Tue 2018-09-18 22:54:53, Lubomir Rintel wrote:
> The timer needs the timer clock to be enabled, otherwise it stops
> ticking.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> ---
> arch/arm/boot/dts/mmp2.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Tue 2018-09-18 22:54:52, Lubomir Rintel wrote:
> The timer needs the timer clock to be enabled, otherwise it stops
> ticking.
>
> Signed-off-by: Lubomir Rintel
> Reviewed-by: Rob Herring
Acked-by: Pavel Machek
> ---
> Changes since v1:
> - Made the clock optional, to keep compatibility
On Tue 2018-09-18 22:54:52, Lubomir Rintel wrote:
> The timer needs the timer clock to be enabled, otherwise it stops
> ticking.
>
> Signed-off-by: Lubomir Rintel
> Reviewed-by: Rob Herring
Acked-by: Pavel Machek
> ---
> Changes since v1:
> - Made the clock optional, to keep compatibility
On Mon 2018-09-17 14:11:24, Lubomir Rintel wrote:
> It makes no sense to remove the device on shutdown. And it break things
> when the hardware crucial for shutdown (such as the embedded controller)
> is attached to the SPI bus.
Again, are you sure?
On some hardware (sharp zaurus, phones) it is
On Mon 2018-09-17 14:11:24, Lubomir Rintel wrote:
> It makes no sense to remove the device on shutdown. And it break things
> when the hardware crucial for shutdown (such as the embedded controller)
> is attached to the SPI bus.
Again, are you sure?
On some hardware (sharp zaurus, phones) it is
On Mon 2018-09-17 14:10:41, Lubomir Rintel wrote:
> This allows use of SPI when power management is disables, such as on
> early boot;
disabled
boot.
> See also: commit 31eb74318054 ("PM / runtime: Fix handling of suppliers
> with disabled runtime PM")
>
> Cc: Mark Brown
> Signed-off-by:
On Mon 2018-09-17 14:10:41, Lubomir Rintel wrote:
> This allows use of SPI when power management is disables, such as on
> early boot;
disabled
boot.
> See also: commit 31eb74318054 ("PM / runtime: Fix handling of suppliers
> with disabled runtime PM")
>
> Cc: Mark Brown
> Signed-off-by:
On Mon 2018-09-17 13:39:46, Lubomir Rintel wrote:
> Marvell keeps their MMP2 datasheet secret, but there are good clues
> that TWSI2 is not on 0xd4025000 on that platform, not does it use
> IRQ 58. In fact, the IRQ 58 on MMP2 seems to be a signal processor:
>
>arch/arm/mach-mmp/irqs.h:#define
On Mon 2018-09-17 13:39:47, Lubomir Rintel wrote:
> I've gotten the base addresses, clocks and interrupts from an rusty and old
> out-of-tree driver. I haven't actually checked against the datasheet, since
> that one is reserved for the Marvell inner circle.
>
> Tested with an accelerometer on
On Mon 2018-09-17 13:39:46, Lubomir Rintel wrote:
> Marvell keeps their MMP2 datasheet secret, but there are good clues
> that TWSI2 is not on 0xd4025000 on that platform, not does it use
> IRQ 58. In fact, the IRQ 58 on MMP2 seems to be a signal processor:
>
>arch/arm/mach-mmp/irqs.h:#define
On Mon 2018-09-17 13:39:47, Lubomir Rintel wrote:
> I've gotten the base addresses, clocks and interrupts from an rusty and old
> out-of-tree driver. I haven't actually checked against the datasheet, since
> that one is reserved for the Marvell inner circle.
>
> Tested with an accelerometer on
On Mon 2018-09-17 13:23:03, Lubomir Rintel wrote:
> This will be useful for boards that actually use GPIO pins.
>
> Cc: Eric Miao
> Cc: Haojian Zhuang
> Cc: Rob Herring
> Cc: Mark Rutland
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> arch/arm/boot/dts/mmp2.dtsi | 2 +-
> 1
On Mon 2018-09-17 13:23:03, Lubomir Rintel wrote:
> This will be useful for boards that actually use GPIO pins.
>
> Cc: Eric Miao
> Cc: Haojian Zhuang
> Cc: Rob Herring
> Cc: Mark Rutland
> Signed-off-by: Lubomir Rintel
Acked-by: Pavel Machek
> arch/arm/boot/dts/mmp2.dtsi | 2 +-
> 1
On Mon 2018-09-17 13:17:21, Lubomir Rintel wrote:
> Similarly to PXA3xx pinctrl-single can't set pin direction on MMP2 either.
> See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> PXA3xx")
>
> Cc: Robert Jarzmik
> Cc: Linus Walleij
> Signed-off-by: Lubomir Rintel
On Mon 2018-09-17 13:17:21, Lubomir Rintel wrote:
> Similarly to PXA3xx pinctrl-single can't set pin direction on MMP2 either.
> See also: commit 9dabfdd84bdfa ("gpio: pxa: disable pinctrl calls for
> PXA3xx")
>
> Cc: Robert Jarzmik
> Cc: Linus Walleij
> Signed-off-by: Lubomir Rintel
Hi Linus,
The following changes since commit 4b42745211af552f170f38a1b97f4a112b5da6b2:
Merge tag 'armsoc-soc' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2018-10-29 15:37:33
-0700)
are available in the git repository at:
Hi Linus,
The following changes since commit 4b42745211af552f170f38a1b97f4a112b5da6b2:
Merge tag 'armsoc-soc' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2018-10-29 15:37:33
-0700)
are available in the git repository at:
The numa_slit variable used by node_distance is available to a
module as long as it is linked at compile-time. However, it is
not available to loadable modules. Leading to errors such as:
ERROR: "numa_slit" [drivers/nvme/host/nvme-core.ko] undefined!
The error above is caused by the nvme
The numa_slit variable used by node_distance is available to a
module as long as it is linked at compile-time. However, it is
not available to loadable modules. Leading to errors such as:
ERROR: "numa_slit" [drivers/nvme/host/nvme-core.ko] undefined!
The error above is caused by the nvme
The existing code triggered an invalid warning about 'rq' possibly being
used uninitialized. Instead of doing the silly warning suppression by
initializa it to NULL, refactor the code to bail out early instead.
Warning was:
kernel/sched/psi.c: In function ‘cgroup_move_task’:
The existing code triggered an invalid warning about 'rq' possibly being
used uninitialized. Instead of doing the silly warning suppression by
initializa it to NULL, refactor the code to bail out early instead.
Warning was:
kernel/sched/psi.c: In function ‘cgroup_move_task’:
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> Change the SMT code paths check from using cpu_smt_control to
> cpu_smt_enabled static key. This saves a branching check.
and adds extra size to the kernel for the patching. The only reason why it
would make sense for kvm is that then the EXPORT of
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> Change the SMT code paths check from using cpu_smt_control to
> cpu_smt_enabled static key. This saves a branching check.
and adds extra size to the kernel for the patching. The only reason why it
would make sense for kvm is that then the EXPORT of
On 11/3/18 8:04 AM, Greg Kroah-Hartman wrote:
On Sat, Nov 03, 2018 at 07:31:42AM -0700, Guenter Roeck wrote:
On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.79 release.
There are 143 patches in this series, all will be posted as a
On 11/3/18 8:04 AM, Greg Kroah-Hartman wrote:
On Sat, Nov 03, 2018 at 07:31:42AM -0700, Guenter Roeck wrote:
On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.14.79 release.
There are 143 patches in this series, all will be posted as a
merged into cifs-2.6.git for-next
On Sat, Nov 3, 2018 at 11:00 AM Colin King wrote:
>
> From: Colin Ian King
>
> Trivial fix to clean up indentation, replace spaces with tab
>
> Signed-off-by: Colin Ian King
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
merged into cifs-2.6.git for-next
On Sat, Nov 3, 2018 at 11:00 AM Colin King wrote:
>
> From: Colin Ian King
>
> Trivial fix to clean up indentation, replace spaces with tab
>
> Signed-off-by: Colin Ian King
> ---
> fs/cifs/cifsencrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> The cpu_smt_enabled static key serves identical purpose as cpu_smt_enabled
That doesn't make any sense.
> to enable SMT specific code.
>
> This patch replaces sched_smt_present in the scheduler with
> cpu_smt_enabled and deprecate sched_smt_present.
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> The cpu_smt_enabled static key serves identical purpose as cpu_smt_enabled
That doesn't make any sense.
> to enable SMT specific code.
>
> This patch replaces sched_smt_present in the scheduler with
> cpu_smt_enabled and deprecate sched_smt_present.
Amazon UK are selling a dual-band WiFi adapter for about 11 GBP (approx
15 USD). It contains a RealTek chip, and it comes with a CD with source
for a linux kernel driver which says it is rtl8821ae .
I have a patch to make this work with a 4.19 kernel (Fedora Rawhide a
few days ago).
I
Amazon UK are selling a dual-band WiFi adapter for about 11 GBP (approx
15 USD). It contains a RealTek chip, and it comes with a CD with source
for a linux kernel driver which says it is rtl8821ae .
I have a patch to make this work with a 4.19 kernel (Fedora Rawhide a
few days ago).
I
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> Extract the logic to show IBPB, STIBP usages in cpu_show_common()
> into helper functions.
>
> Later patches will add other userspace Spectre v2 mitigation modes.
> This patch makes it easy to show IBPB and STIBP
> usage scenario according to the
Tim,
On Tue, 30 Oct 2018, Tim Chen wrote:
> Extract the logic to show IBPB, STIBP usages in cpu_show_common()
> into helper functions.
>
> Later patches will add other userspace Spectre v2 mitigation modes.
> This patch makes it easy to show IBPB and STIBP
> usage scenario according to the
Hi Jerome,
Thanks for the review, we really appreciate your time.
I'm very sorry maybe I don't catch all your meaning very well.
Please see my comments below.
On 2018/10/29 3:16, Jerome Brunet wrote:
> On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote:
>> Hi Jerome,
>>
>> On Thu,
Hi Jerome,
Thanks for the review, we really appreciate your time.
I'm very sorry maybe I don't catch all your meaning very well.
Please see my comments below.
On 2018/10/29 3:16, Jerome Brunet wrote:
> On Thu, 2018-10-25 at 22:58 +0200, Martin Blumenstingl wrote:
>> Hi Jerome,
>>
>> On Thu,
On Sat, Nov 3, 2018 at 3:41 AM Catalin Marinas wrote:
>
> arm64 2nd round of updates for 4.20:
Pulled,
Linus
On Sat, Nov 3, 2018 at 3:41 AM Catalin Marinas wrote:
>
> arm64 2nd round of updates for 4.20:
Pulled,
Linus
On Sat, Nov 3, 2018 at 12:58 AM Masahiro Yamada
wrote:
>
> Please pull a little more Kbuild updates.
Pulled,
Linus
On Sat, Nov 3, 2018 at 12:58 AM Masahiro Yamada
wrote:
>
> Please pull a little more Kbuild updates.
Pulled,
Linus
In d8ae72427187, start was changed to point to the character under the
cursor, instead of the beginning of the cleared area. The offset was
correctly applied when clearing the backing buffer, but not when
updating the framebuffer region. Fix this by having start point once
again to the beginning
In d8ae72427187, start was changed to point to the character under the
cursor, instead of the beginning of the cleared area. The offset was
correctly applied when clearing the backing buffer, but not when
updating the framebuffer region. Fix this by having start point once
again to the beginning
> -Original Message-
> From: Hunter, Adrian
> Sent: Wednesday, October 31, 2018 11:11 AM
> To: Arnaldo Carvalho de Melo
> Cc: Jiri Olsa ; Andi Kleen ; linux-
> ker...@vger.kernel.org; leo@linaro.org; David Miller
> ; Mathieu Poirier
> Subject: [PATCH 2/5] perf tools: Use fallback for
> -Original Message-
> From: Hunter, Adrian
> Sent: Wednesday, October 31, 2018 11:11 AM
> To: Arnaldo Carvalho de Melo
> Cc: Jiri Olsa ; Andi Kleen ; linux-
> ker...@vger.kernel.org; leo@linaro.org; David Miller
> ; Mathieu Poirier
> Subject: [PATCH 2/5] perf tools: Use fallback for
On Sun, 4 Nov 2018 01:03:34 +0900
Masami Hiramatsu wrote:
> Introduce symbol_offset data structure for avoiding symbol+offset
> parsing when updating arguments.
>
> For kprobe events, "@symbol+offset" is supported, that requires
> to be updated when new module is loaded because @symbol address
On Sun, 4 Nov 2018 01:03:34 +0900
Masami Hiramatsu wrote:
> Introduce symbol_offset data structure for avoiding symbol+offset
> parsing when updating arguments.
>
> For kprobe events, "@symbol+offset" is supported, that requires
> to be updated when new module is loaded because @symbol address
On 11/3/18 4:59 AM, Priit Laes wrote:
Signed-off-by: Priit Laes
Where is the commit message? The stuff in the cover letter (Patch 0/N) never
makes it to the git repository. You must have a message in each of the
individual patches.
NACK.
Larry
---
On Fri, Nov 2, 2018 at 5:06 PM Al Viro wrote:
>
> Regression fix for net/9p handling of iov_iter; broken
> by braino when switching to iov_iter_is_kvec() et.al., spotted
> and fixed by Marc.
Pulled,
Linus
On 11/3/18 4:59 AM, Priit Laes wrote:
Signed-off-by: Priit Laes
Where is the commit message? The stuff in the cover letter (Patch 0/N) never
makes it to the git repository. You must have a message in each of the
individual patches.
NACK.
Larry
---
On Fri, Nov 2, 2018 at 5:06 PM Al Viro wrote:
>
> Regression fix for net/9p handling of iov_iter; broken
> by braino when switching to iov_iter_is_kvec() et.al., spotted
> and fixed by Marc.
Pulled,
Linus
On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>
> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
> >> On Thu, Nov 01 2018, Paul E. McKenney wrote:
> >>
> >> > On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>
> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
> >> On Thu, Nov 01 2018, Paul E. McKenney wrote:
> >>
> >> > On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
From: Eric Biggers
We need to check the return value of match_token() for Opt_err (-1)
before doing anything with it.
Reported-by: syzbot+a22e0dc07567662c5...@syzkaller.appspotmail.com
Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for
asymmetric keys [ver #2]")
From: Eric Biggers
We need to check the return value of match_token() for Opt_err (-1)
before doing anything with it.
Reported-by: syzbot+a22e0dc07567662c5...@syzkaller.appspotmail.com
Fixes: 00d60fd3b932 ("KEYS: Provide keyctls to drive the new key type ops for
asymmetric keys [ver #2]")
On Sat, 3 Nov 2018 13:04:04 -0300
Matheus Tavares Bernardino wrote:
> On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote:
> >
> > On Fri, 26 Oct 2018 23:00:04 -0300
> > Matheus Tavares wrote:
> >
> > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> > > implements the
WARN_ON() already contains an unlikely(), so it's not necessary to
use WARN_ON(1).
Signed-off-by: Yangtao Li
---
kernel/sched/deadline.c | 4 +---
kernel/sched/rt.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
On Sat, 3 Nov 2018 13:04:04 -0300
Matheus Tavares Bernardino wrote:
> On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote:
> >
> > On Fri, 26 Oct 2018 23:00:04 -0300
> > Matheus Tavares wrote:
> >
> > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and
> > > implements the
WARN_ON() already contains an unlikely(), so it's not necessary to
use WARN_ON(1).
Signed-off-by: Yangtao Li
---
kernel/sched/deadline.c | 4 +---
kernel/sched/rt.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
On Sat, 3 Nov 2018 12:59:16 -0300
Renato Lui Geh wrote:
> Hi,
>
> >On Thu, 1 Nov 2018 15:02:32 +
> >"Ardelean, Alexandru" wrote:
> >
> >> Good catch.
>
> That was actually Jonathan's catch. :)
>
> >> Acked-by: Alexandru Ardelean
>
> I read up on Acked-by on the kernel docs, as I
On Sat, 3 Nov 2018 12:59:16 -0300
Renato Lui Geh wrote:
> Hi,
>
> >On Thu, 1 Nov 2018 15:02:32 +
> >"Ardelean, Alexandru" wrote:
> >
> >> Good catch.
>
> That was actually Jonathan's catch. :)
>
> >> Acked-by: Alexandru Ardelean
>
> I read up on Acked-by on the kernel docs, as I
On Sat, 3 Nov 2018 13:06:19 -0300
Renato Lui Geh wrote:
> On Thu, 1 Nov 2018 15:20:55 +
> "Ardelean, Alexandru" wrote:
> >
> > This looks wrong.
> > I admit this was done in the same way in the probe function, but that looks
> > a bit wrong as well.
> >
> > Typically, the return value of
On Sat, 3 Nov 2018 13:06:19 -0300
Renato Lui Geh wrote:
> On Thu, 1 Nov 2018 15:20:55 +
> "Ardelean, Alexandru" wrote:
> >
> > This looks wrong.
> > I admit this was done in the same way in the probe function, but that looks
> > a bit wrong as well.
> >
> > Typically, the return value of
On Fri, 2 Nov 2018 15:42:09 +0800
Song Qiang wrote:
> PNI RM3100 is a high resolution, large signal immunity magnetometer,
> composed of 3 single sensors and a processing chip with a MagI2C
> interface.
>
> Following functions are available:
> - Single-shot measurement from
>
On Fri, 2 Nov 2018 15:42:09 +0800
Song Qiang wrote:
> PNI RM3100 is a high resolution, large signal immunity magnetometer,
> composed of 3 single sensors and a processing chip with a MagI2C
> interface.
>
> Following functions are available:
> - Single-shot measurement from
>
On Sat, 3 Nov 2018, Thomas Gleixner wrote:
> On Fri, 2 Nov 2018, Long Li wrote:
> > /**
> > * irq_matrix_assign_system - Assign system wide entry in the matrix
> > * @m: Matrix pointer
> > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix *m,
> > const struct
On Sat, 3 Nov 2018, Thomas Gleixner wrote:
> On Fri, 2 Nov 2018, Long Li wrote:
> > /**
> > * irq_matrix_assign_system - Assign system wide entry in the matrix
> > * @m: Matrix pointer
> > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix *m,
> > const struct
On Fri, Nov 2, 2018 at 4:36 PM Dave Chinner wrote:
>
> On Fri, Nov 02, 2018 at 09:35:23AM -0700, Linus Torvalds wrote:
> >
> > I don't love the timing of this at the end of the merge window, but pulled,
>
> When would have been a better time? It's too big for a late -rc, and
> it contains stuff
On Fri, Nov 2, 2018 at 4:36 PM Dave Chinner wrote:
>
> On Fri, Nov 02, 2018 at 09:35:23AM -0700, Linus Torvalds wrote:
> >
> > I don't love the timing of this at the end of the merge window, but pulled,
>
> When would have been a better time? It's too big for a late -rc, and
> it contains stuff
Remove @space from tpm_transmit() API` in order to completely remove the
bound between low-level transmission functionality and TPM spaces. The
only real dependency existing is the amount of data saved before trying
to send a command to the TPM.
It doesn't really matter if we save always a bit
Prepare and commit TPM space before and after calling tpm_transmit()
instead of doing that inside tpm_transmit(). After this change we can
remove TPM_TRANSMIT_NESTED flag from tpm2_prepare_space() and
tpm2_commit_space() and replace it with TPM_TRANSMIT_UNLOCKED.
Signed-off-by: Jarkko Sakkinen
Encapsulate tpm_transmit() call pattern to tpm_dev_transmit() because it
is identically used from two places. Use unlocked version of
tpm_transmit() so that we are able to move the calls to
tpm2_prepare_space() and tpm2_commit_space() later on to this new
function.
Signed-off-by: Jarkko Sakkinen
Remove @space from tpm_transmit() API` in order to completely remove the
bound between low-level transmission functionality and TPM spaces. The
only real dependency existing is the amount of data saved before trying
to send a command to the TPM.
It doesn't really matter if we save always a bit
Prepare and commit TPM space before and after calling tpm_transmit()
instead of doing that inside tpm_transmit(). After this change we can
remove TPM_TRANSMIT_NESTED flag from tpm2_prepare_space() and
tpm2_commit_space() and replace it with TPM_TRANSMIT_UNLOCKED.
Signed-off-by: Jarkko Sakkinen
Encapsulate tpm_transmit() call pattern to tpm_dev_transmit() because it
is identically used from two places. Use unlocked version of
tpm_transmit() so that we are able to move the calls to
tpm2_prepare_space() and tpm2_commit_space() later on to this new
function.
Signed-off-by: Jarkko Sakkinen
101 - 200 of 346 matches
Mail list logo
