[PATCH 5/8] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-03 Thread Jarkko Sakkinen
Move tpm_validate_command() to tpm2-space.c and make it part of the tpm2_prepare_space() flow. Make cc resolution as part of the TPM space functionality in order to detach it from rest of the tpm_transmit() flow. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 72

[PATCH 5/8] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-03 Thread Jarkko Sakkinen
Move tpm_validate_command() to tpm2-space.c and make it part of the tpm2_prepare_space() flow. Make cc resolution as part of the TPM space functionality in order to detach it from rest of the tpm_transmit() flow. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 72

[PATCH 1/8] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter

2018-11-03 Thread Jarkko Sakkinen
Since we pass an initialized struct tpm_buf instance in every call site now, it is cleaner to pass that directly to the tpm_transmit_cmd() as the TPM command/response buffer. Fine-tune a little bit tpm_transmit() and tpm_transmit_cmd() comments while doing this. Signed-off-by: Jarkko Sakkinen

[PATCH 4/8] tpm: access command header through struct in tpm_try_transmit()

2018-11-03 Thread Jarkko Sakkinen
Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 4 ++-- 1 file changed, 2

[PATCH 2/8] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-03 Thread Jarkko Sakkinen
The error logging for tpm2_commit_space() is in a wrong place. This commit moves it inside that function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm2-space.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm2-space.c

[PATCH 3/8] tpm: clean up tpm_try_transmit() error handling flow

2018-11-03 Thread Jarkko Sakkinen
Move locking, locality handling and power management to tpm_transmit() in order to simplify the flow and fix the error message formatting in tpm_try_transmit() to output correct function name by using the '__func__' macro. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 99

[PATCH 2/8] tpm: print tpm2_commit_space() error inside tpm2_commit_space()

2018-11-03 Thread Jarkko Sakkinen
The error logging for tpm2_commit_space() is in a wrong place. This commit moves it inside that function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm2-space.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/char/tpm/tpm2-space.c

[PATCH 3/8] tpm: clean up tpm_try_transmit() error handling flow

2018-11-03 Thread Jarkko Sakkinen
Move locking, locality handling and power management to tpm_transmit() in order to simplify the flow and fix the error message formatting in tpm_try_transmit() to output correct function name by using the '__func__' macro. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 99

[PATCH 1/8] tpm: use tpm_buf in tpm_transmit_cmd() as the IO parameter

2018-11-03 Thread Jarkko Sakkinen
Since we pass an initialized struct tpm_buf instance in every call site now, it is cleaner to pass that directly to the tpm_transmit_cmd() as the TPM command/response buffer. Fine-tune a little bit tpm_transmit() and tpm_transmit_cmd() comments while doing this. Signed-off-by: Jarkko Sakkinen

[PATCH 4/8] tpm: access command header through struct in tpm_try_transmit()

2018-11-03 Thread Jarkko Sakkinen
Instead of accessing fields of the command header through offsets to the raw buffer, it is a better idea to use the header struct pointer that is already used elsewhere in the function. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 4 ++-- 1 file changed, 2

[PATCH 0/8] Detach TPM space code out of the tpm_transmit() flow

2018-11-03 Thread Jarkko Sakkinen
Make the changes that are needed to detach TPM space code from tpm_transmit() flow so that we do no longer need nested tpm_transmit() calls. v2: * Print tpm2_commit_space() error inside tpm2_commit_space() * Error code was not printed when recv() callback failed. It is fixed in this version. *

[PATCH 0/8] Detach TPM space code out of the tpm_transmit() flow

2018-11-03 Thread Jarkko Sakkinen
Make the changes that are needed to detach TPM space code from tpm_transmit() flow so that we do no longer need nested tpm_transmit() calls. v2: * Print tpm2_commit_space() error inside tpm2_commit_space() * Error code was not printed when recv() callback failed. It is fixed in this version. *

Re: [PATCH] iio: sx932x: Add driver for Semtech sx932x proximity sensor

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 14:43:13 -0700 Enrico Granata wrote: > From: Enrico Granata > > This driver allows interfacing with the Semtech sx9320, sx9321 and sx9324 > proximity sensors via the IIO subsystem. > > Signed-off-by: Enrico Granata Various comments inline. Please make sure to proof read

Re: [PATCH] iio: sx932x: Add driver for Semtech sx932x proximity sensor

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 14:43:13 -0700 Enrico Granata wrote: > From: Enrico Granata > > This driver allows interfacing with the Semtech sx9320, sx9321 and sx9324 > proximity sensors via the IIO subsystem. > > Signed-off-by: Enrico Granata Various comments inline. Please make sure to proof read

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 09:17:54 -0400 Steven Rostedt wrote: > > > Then I tested with this: > > > > > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > > > index 3ef15a6683c0..4ddafddf1343 100644 > > > --- a/kernel/trace/trace_probe.c > > > +++ b/kernel/trace/trace_probe.c >

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 09:17:54 -0400 Steven Rostedt wrote: > > > Then I tested with this: > > > > > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > > > index 3ef15a6683c0..4ddafddf1343 100644 > > > --- a/kernel/trace/trace_probe.c > > > +++ b/kernel/trace/trace_probe.c >

[PATCH] nfsd: clean up indentation, increase indentation in switch statement

2018-11-03 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation, add in missing tabs. Signed-off-by: Colin Ian King --- fs/nfsd/nfs4state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index f093fbe47133..eb129a6f9eae 100644 ---

[PATCH] nfsd: clean up indentation, increase indentation in switch statement

2018-11-03 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation, add in missing tabs. Signed-off-by: Colin Ian King --- fs/nfsd/nfs4state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index f093fbe47133..eb129a6f9eae 100644 ---

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Renato Lui Geh
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: This looks wrong. I admit this was done in the same way in the probe function, but that looks a bit wrong as well. Typically, the return value of `regulator_get_voltage()` would get checked with: ret =

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Renato Lui Geh
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: This looks wrong. I admit this was done in the same way in the probe function, but that looks a bit wrong as well. Typically, the return value of `regulator_get_voltage()` would get checked with: ret =

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-11-03 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:04 -0300 > Matheus Tavares wrote: > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > > Signed-off-by: Victor Colombo > >

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-11-03 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:04 -0300 > Matheus Tavares wrote: > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > > Signed-off-by: Victor Colombo > >

[RFC PATCH] tracing/kprobes: Avoid parsing symbol+offset when updating arguments

2018-11-03 Thread Masami Hiramatsu
Introduce symbol_offset data structure for avoiding symbol+offset parsing when updating arguments. For kprobe events, "@symbol+offset" is supported, that requires to be updated when new module is loaded because @symbol address can be solved at that point. Currently kprobe events saves the

[RFC PATCH] tracing/kprobes: Avoid parsing symbol+offset when updating arguments

2018-11-03 Thread Masami Hiramatsu
Introduce symbol_offset data structure for avoiding symbol+offset parsing when updating arguments. For kprobe events, "@symbol+offset" is supported, that requires to be updated when new module is loaded because @symbol address can be solved at that point. Currently kprobe events saves the

[PATCH] cifs: clean up indentation, replace spaces with tab

2018-11-03 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation, replace spaces with tab Signed-off-by: Colin Ian King --- fs/cifs/cifsencrypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index 85b31cfa2f3c..ecdff344e8fe 100644

[PATCH] cifs: clean up indentation, replace spaces with tab

2018-11-03 Thread Colin King
From: Colin Ian King Trivial fix to clean up indentation, replace spaces with tab Signed-off-by: Colin Ian King --- fs/cifs/cifsencrypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c index 85b31cfa2f3c..ecdff344e8fe 100644

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Renato Lui Geh
Hi, On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: Good catch. That was actually Jonathan's catch. :) Acked-by: Alexandru Ardelean I read up on Acked-by on the kernel docs, as I didn't know exactly what it meant, but I'm not so sure on how to proceed once the patch has

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Renato Lui Geh
Hi, On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: Good catch. That was actually Jonathan's catch. :) Acked-by: Alexandru Ardelean I read up on Acked-by on the kernel docs, as I didn't know exactly what it meant, but I'm not so sure on how to proceed once the patch has

Re: [LKP] [sunrpc] 6a7da2a288: kernel_BUG_at_lib/iov_iter.c

2018-11-03 Thread Leonard Crestez
On 11/2/2018 2:50 AM, David Howells wrote: > kernel test robot wrote: > >> FYI, we noticed the following commit (built with gcc-7): >> >> commit: 6a7da2a288ce412d7ac117a2912a7b0d9104ee6d ("[RFC] sunrpc: Fix flood >> of warnings from iov_iter_kvec in linux-next") >> url: >>

Re: [LKP] [sunrpc] 6a7da2a288: kernel_BUG_at_lib/iov_iter.c

2018-11-03 Thread Leonard Crestez
On 11/2/2018 2:50 AM, David Howells wrote: > kernel test robot wrote: > >> FYI, we noticed the following commit (built with gcc-7): >> >> commit: 6a7da2a288ce412d7ac117a2912a7b0d9104ee6d ("[RFC] sunrpc: Fix flood >> of warnings from iov_iter_kvec in linux-next") >> url: >>

general protection fault in keyctl_pkey_params_get

2018-11-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:5f21585384a4 Merge tag 'for-linus-20181102' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10ba246d40 kernel config: https://syzkaller.appspot.com/x/.config?x=9384ecb1c973baed

general protection fault in keyctl_pkey_params_get

2018-11-03 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:5f21585384a4 Merge tag 'for-linus-20181102' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10ba246d40 kernel config: https://syzkaller.appspot.com/x/.config?x=9384ecb1c973baed

Re: [PATCH] copy_{to,from}_user(): fix compile-time sanity checks with gcc -Og

2018-11-03 Thread Arnd Bergmann
On 11/3/18, Changbin Du wrote: > On Fri, Nov 02, 2018 at 04:56:58PM +0100, Arnd Bergmann wrote: >> When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is set, we get countless warnings >> like >> >> In function 'check_copy_size', >> inlined from 'copy_from_user' at include/linux/uaccess.h:146:6, >>

Re: [PATCH] copy_{to,from}_user(): fix compile-time sanity checks with gcc -Og

2018-11-03 Thread Arnd Bergmann
On 11/3/18, Changbin Du wrote: > On Fri, Nov 02, 2018 at 04:56:58PM +0100, Arnd Bergmann wrote: >> When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is set, we get countless warnings >> like >> >> In function 'check_copy_size', >> inlined from 'copy_from_user' at include/linux/uaccess.h:146:6, >>

Update

2018-11-03 Thread Bruce Blake
Hello Dear how are you doing today? my name is Bruce Blake, the manager foreign affairs in City Finance Bank, we have a customer here in bank that has not accessed his account for the past 18 years, after some research made about him we found out he was a victim of the crashed mining company

Update

2018-11-03 Thread Bruce Blake
Hello Dear how are you doing today? my name is Bruce Blake, the manager foreign affairs in City Finance Bank, we have a customer here in bank that has not accessed his account for the past 18 years, after some research made about him we found out he was a victim of the crashed mining company

Update

2018-11-03 Thread Bruce Blake
Hello Dear how are you doing today? my name is Bruce Blake, the manager foreign affairs in City Finance Bank, we have a customer here in bank that has not accessed his account for the past 18 years, after some research made about him we found out he was a victim of the crashed mining company

Update

2018-11-03 Thread Bruce Blake
Hello Dear how are you doing today? my name is Bruce Blake, the manager foreign affairs in City Finance Bank, we have a customer here in bank that has not accessed his account for the past 18 years, after some research made about him we found out he was a victim of the crashed mining company

Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-03 Thread Thomas Gleixner
Long, On Fri, 2 Nov 2018, Long Li wrote: > /** > * irq_matrix_assign_system - Assign system wide entry in the matrix > * @m: Matrix pointer > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix *m, const > struct cpumask *msk, > if (cpumask_empty(msk)) >

Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

2018-11-03 Thread Thomas Gleixner
Long, On Fri, 2 Nov 2018, Long Li wrote: > /** > * irq_matrix_assign_system - Assign system wide entry in the matrix > * @m: Matrix pointer > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix *m, const > struct cpumask *msk, > if (cpumask_empty(msk)) >

Re: [PATCH 4.14 000/143] 4.14.79-stable review

2018-11-03 Thread Greg Kroah-Hartman
On Sat, Nov 03, 2018 at 07:31:42AM -0700, Guenter Roeck wrote: > On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.79 release. > > There are 143 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 4.14 000/143] 4.14.79-stable review

2018-11-03 Thread Greg Kroah-Hartman
On Sat, Nov 03, 2018 at 07:31:42AM -0700, Guenter Roeck wrote: > On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.79 release. > > There are 143 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 4.19 00/24] 4.19.1-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:34 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.1 release. There are 24 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.19 00/24] 4.19.1-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:34 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.1 release. There are 24 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.18 000/150] 4.18.17-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:32 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.18.17 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.18 000/150] 4.18.17-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:32 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.18.17 release. There are 150 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.14 000/143] 4.14.79-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.79 release. There are 143 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.14 000/143] 4.14.79-stable review

2018-11-03 Thread Guenter Roeck
On 11/2/18 11:33 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.79 release. There are 143 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH v15 16/23] x86/sgx: Enumerate and track EPC sections

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:17 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Enumerate Enclave Page Cache (EPC) sections via CPUID and add the data > structures necessary to track EPC pages so that they can be allocated, > freed and managed. As a system may have multiple EPC

Re: [PATCH v15 16/23] x86/sgx: Enumerate and track EPC sections

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:17 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Enumerate Enclave Page Cache (EPC) sections via CPUID and add the data > structures necessary to track EPC pages so that they can be allocated, > freed and managed. As a system may have multiple EPC

Re: [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:18 AM Jarkko Sakkinen wrote: > > ENCLS is an umbrella instruction for a variety of cpl0 SGX functions. > The ENCLS function that is executed is specified in EAX, with each > function potentially having more leaf-specific operands beyond EAX. > ENCLS introduces its own

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Steven Rostedt
On Sat, 3 Nov 2018 20:54:48 +0900 Masami Hiramatsu wrote: > On Fri, 2 Nov 2018 09:54:24 -0400 > Steven Rostedt wrote: > > > On Fri, 2 Nov 2018 16:14:59 +0900 > > Masami Hiramatsu wrote: > > > > > On Thu, 1 Nov 2018 15:10:14 -0400 > > > Steven Rostedt wrote: > > > > > > > On Thu, 1 Nov

Re: [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:18 AM Jarkko Sakkinen wrote: > > ENCLS is an umbrella instruction for a variety of cpl0 SGX functions. > The ENCLS function that is executed is specified in EAX, with each > function potentially having more leaf-specific operands beyond EAX. > ENCLS introduces its own

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Steven Rostedt
On Sat, 3 Nov 2018 20:54:48 +0900 Masami Hiramatsu wrote: > On Fri, 2 Nov 2018 09:54:24 -0400 > Steven Rostedt wrote: > > > On Fri, 2 Nov 2018 16:14:59 +0900 > > Masami Hiramatsu wrote: > > > > > On Thu, 1 Nov 2018 15:10:14 -0400 > > > Steven Rostedt wrote: > > > > > > > On Thu, 1 Nov

Re: [PATCH v15 14/23] x86/cpu/intel: Clear SGX_LC capability if not enabled in FEATURE_CONTROL

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:17 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Like SGX itself, SGX Launch Control must be explicitly enabled via a > flag in IA32_FEATURE_CONTROL. Clear the SGX_LC capability if Launch > Control is not fully enabled (or obviously if SGX itself is

Re: [PATCH v15 14/23] x86/cpu/intel: Clear SGX_LC capability if not enabled in FEATURE_CONTROL

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:17 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Like SGX itself, SGX Launch Control must be explicitly enabled via a > flag in IA32_FEATURE_CONTROL. Clear the SGX_LC capability if Launch > Control is not fully enabled (or obviously if SGX itself is

Re: [PATCH v15 11/23] x86/sgx: Add definitions for SGX's CPUID leaf and variable sub-leafs

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:16 AM Jarkko Sakkinen wrote: > > SGX defines its own CPUID leaf, 0x12, along with a variable number of > sub-leafs. Sub-leafs 0 and 1 are always available if SGX is supported > and enumerate various SGX features, e.g. instruction sets and enclave > capabilities.

Re: [PATCH v15 11/23] x86/sgx: Add definitions for SGX's CPUID leaf and variable sub-leafs

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:16 AM Jarkko Sakkinen wrote: > > SGX defines its own CPUID leaf, 0x12, along with a variable number of > sub-leafs. Sub-leafs 0 and 1 are always available if SGX is supported > and enumerate various SGX features, e.g. instruction sets and enclave > capabilities.

Re: [PATCH v3 3/3] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:28:19 + "Ardelean, Alexandru" wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > This patch removes the unnecessary field int_vref_mv in ad7780_state > > referring to the device's voltage. > > > > Signed-off-by: Renato Lui Geh > > --- > > Changes in

Re: [PATCH v3 3/3] staging: iio: ad7780: remove unnecessary stashed voltage value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:28:19 + "Ardelean, Alexandru" wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > This patch removes the unnecessary field int_vref_mv in ad7780_state > > referring to the device's voltage. > > > > Signed-off-by: Renato Lui Geh > > --- > > Changes in

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > The ad7780 driver previously did not read the correct device output, as > > it read an outdated value set at initialization. It now updates its > > voltage on read. > >

Re: [PATCH v3 2/3] staging: iio: ad7780: update voltage on read

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:20:55 + "Ardelean, Alexandru" wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > The ad7780 driver previously did not read the correct device output, as > > it read an outdated value set at initialization. It now updates its > > voltage on read. > >

Re: [PATCH v3] include/linux/compiler*.h: define asm_volatile_goto

2018-11-03 Thread Miguel Ojeda
On Wed, Oct 31, 2018 at 8:39 PM wrote: > > asm_volatile_goto should also be defined for other compilers that support > asm goto. Picking this up into compiler-attributes. Cheers, Miguel

Re: [PATCH v3] include/linux/compiler*.h: define asm_volatile_goto

2018-11-03 Thread Miguel Ojeda
On Wed, Oct 31, 2018 at 8:39 PM wrote: > > asm_volatile_goto should also be defined for other compilers that support > asm goto. Picking this up into compiler-attributes. Cheers, Miguel

Re: [PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:45:09 + Jonathan Cameron wrote: > On Wed, 31 Oct 2018 21:28:52 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > It would have been less 'noisy' to do these

Re: [PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:45:09 + Jonathan Cameron wrote: > On Wed, 31 Oct 2018 21:28:52 +0530 > Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface. > > > > Signed-off-by: Nishad Kamdar > It would have been less 'noisy' to do these

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: > Good catch. > > Acked-by: Alexandru Ardelean On the basis this has been broken for a long time, and you are clearly doing other nearby not fix work, I'm going to take this through the togreg tree rather than via the quicker fix

Re: [PATCH v3 1/3] staging: iio: ad7780: fix offset read value

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 15:02:32 + "Ardelean, Alexandru" wrote: > Good catch. > > Acked-by: Alexandru Ardelean On the basis this has been broken for a long time, and you are clearly doing other nearby not fix work, I'm going to take this through the togreg tree rather than via the quicker fix

Re: [PATCH v15 05/23] x86/cpu/intel: Detect SGX support and update caps appropriately

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:16 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Similar to other large Intel features such as VMX and TXT, SGX must be > explicitly enabled in IA32_FEATURE_CONTROL MSR to be truly usable. > Clear all SGX related capabilities if SGX is not fully enabled in

Re: [PATCH v15 05/23] x86/cpu/intel: Detect SGX support and update caps appropriately

2018-11-03 Thread Andy Shevchenko
On Sat, Nov 3, 2018 at 1:16 AM Jarkko Sakkinen wrote: > > From: Sean Christopherson > > Similar to other large Intel features such as VMX and TXT, SGX must be > explicitly enabled in IA32_FEATURE_CONTROL MSR to be truly usable. > Clear all SGX related capabilities if SGX is not fully enabled in

Re: [PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:39:27 + Jonathan Cameron wrote: > On Thu, 1 Nov 2018 21:05:09 +0530 > Himanshu Jha wrote: > > > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote: > > > Add device tree table for matching vendor ID. > > > > > > Signed-off-by: Nishad Kamdar > > > --- >

Re: [PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-11-03 Thread Jonathan Cameron
On Sat, 3 Nov 2018 12:39:27 + Jonathan Cameron wrote: > On Thu, 1 Nov 2018 21:05:09 +0530 > Himanshu Jha wrote: > > > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote: > > > Add device tree table for matching vendor ID. > > > > > > Signed-off-by: Nishad Kamdar > > > --- >

Re: [PATCH v7 2/3] staging: iio: ad2s1210: Drop the gpioin flag.

2018-11-03 Thread Jonathan Cameron
On Wed, 31 Oct 2018 21:29:53 +0530 Nishad Kamdar wrote: > Drop gpioin flag which decides how the GPIOs > are controlled as the GPIOs must be outputs > for the host as per the datasheet. > > Signed-off-by: Nishad Kamdar Whilst this does the right thing, it doesn't take advantage of

Re: [PATCH v7 2/3] staging: iio: ad2s1210: Drop the gpioin flag.

2018-11-03 Thread Jonathan Cameron
On Wed, 31 Oct 2018 21:29:53 +0530 Nishad Kamdar wrote: > Drop gpioin flag which decides how the GPIOs > are controlled as the GPIOs must be outputs > for the host as per the datasheet. > > Signed-off-by: Nishad Kamdar Whilst this does the right thing, it doesn't take advantage of

Re: [PATCH 4.14 053/143] x86/power: Fix some ordering bugs in __restore_processor_context()

2018-11-03 Thread Sasha Levin
On Sat, Nov 03, 2018 at 09:41:51AM +0100, Greg Kroah-Hartman wrote: On Sat, Nov 03, 2018 at 09:40:16AM +0100, Greg Kroah-Hartman wrote: On Fri, Nov 02, 2018 at 07:17:34PM -0400, Sasha Levin wrote: > On Fri, Nov 02, 2018 at 08:19:36PM +, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Fri,

Re: [PATCH 4.14 053/143] x86/power: Fix some ordering bugs in __restore_processor_context()

2018-11-03 Thread Sasha Levin
On Sat, Nov 03, 2018 at 09:41:51AM +0100, Greg Kroah-Hartman wrote: On Sat, Nov 03, 2018 at 09:40:16AM +0100, Greg Kroah-Hartman wrote: On Fri, Nov 02, 2018 at 07:17:34PM -0400, Sasha Levin wrote: > On Fri, Nov 02, 2018 at 08:19:36PM +, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Fri,

Re: [PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-11-03 Thread Jonathan Cameron
On Wed, 31 Oct 2018 21:28:52 +0530 Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar It would have been less 'noisy' to do these in the reverse order (drop the flag and support first, then do the gpiod

Re: [PATCH v7 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-11-03 Thread Jonathan Cameron
On Wed, 31 Oct 2018 21:28:52 +0530 Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar It would have been less 'noisy' to do these in the reverse order (drop the flag and support first, then do the gpiod

Re: linux-next: Tree for Nov 2 (compiler-gcc.h)

2018-11-03 Thread Miguel Ojeda
On Fri, Nov 2, 2018 at 4:56 PM Randy Dunlap wrote: > > Hi, > > on i386 or x86_64, with gcc (SUSE Linux) 4.8.5, I am seeing this problem: > > In file included from :0:0: > ../include/linux/compiler-gcc.h:75:45: internal compiler error: in > function_and_variable_visibility, at ipa.c:825 >

Re: linux-next: Tree for Nov 2 (compiler-gcc.h)

2018-11-03 Thread Miguel Ojeda
On Fri, Nov 2, 2018 at 4:56 PM Randy Dunlap wrote: > > Hi, > > on i386 or x86_64, with gcc (SUSE Linux) 4.8.5, I am seeing this problem: > > In file included from :0:0: > ../include/linux/compiler-gcc.h:75:45: internal compiler error: in > function_and_variable_visibility, at ipa.c:825 >

Re: [PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 21:05:09 +0530 Himanshu Jha wrote: > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID. > > > > Signed-off-by: Nishad Kamdar > > --- > > drivers/staging/iio/resolver/ad2s1210.c | 7 +++ > > 1 file changed, 7

Re: [PATCH v7 3/3] staging: iio: ad2s1210: Add device tree table.

2018-11-03 Thread Jonathan Cameron
On Thu, 1 Nov 2018 21:05:09 +0530 Himanshu Jha wrote: > On Wed, Oct 31, 2018 at 09:30:36PM +0530, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID. > > > > Signed-off-by: Nishad Kamdar > > --- > > drivers/staging/iio/resolver/ad2s1210.c | 7 +++ > > 1 file changed, 7

Re: [PATCH v3 2/3] iio: adc: Add ad7124 support

2018-11-03 Thread Jonathan Cameron
On Mon, 29 Oct 2018 18:38:31 +0200 Stefan Popa wrote: > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma-delta ADCs > with 24-bit precision and reference. > > Three power modes are available which in turn affect the output data rate: > * Full power: 9.38 SPS to 19,200 SPS > *

Re: [PATCH v3 2/3] iio: adc: Add ad7124 support

2018-11-03 Thread Jonathan Cameron
On Mon, 29 Oct 2018 18:38:31 +0200 Stefan Popa wrote: > The ad7124-4 and ad7124-8 are a family of 4 and 8 channel sigma-delta ADCs > with 24-bit precision and reference. > > Three power modes are available which in turn affect the output data rate: > * Full power: 9.38 SPS to 19,200 SPS > *

Re: [PATCH] mm: Create the new vm_fault_t type

2018-11-03 Thread Matthew Wilcox
On Sat, Nov 03, 2018 at 10:35:04AM +0530, Souptick Joarder wrote: > Page fault handlers are supposed to return VM_FAULT codes, > but some drivers/file systems mistakenly return error > numbers. Now that all drivers/file systems have been converted > to use the vm_fault_t return type, change the

Re: [PATCH] mm: Create the new vm_fault_t type

2018-11-03 Thread Matthew Wilcox
On Sat, Nov 03, 2018 at 10:35:04AM +0530, Souptick Joarder wrote: > Page fault handlers are supposed to return VM_FAULT codes, > but some drivers/file systems mistakenly return error > numbers. Now that all drivers/file systems have been converted > to use the vm_fault_t return type, change the

Re: [PATCH v3 3/3] dt-bindings: iio: adc: Add docs for ad7124

2018-11-03 Thread Jonathan Cameron
On Tue, 30 Oct 2018 15:56:15 -0500 Rob Herring wrote: > On Mon, Oct 29, 2018 at 06:39:30PM +0200, Stefan Popa wrote: > > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. > > > > Signed-off-by: Stefan Popa > > --- > > Changes in v2: > > - Nothing changed. > > Changes in

Re: [PATCH v3 3/3] dt-bindings: iio: adc: Add docs for ad7124

2018-11-03 Thread Jonathan Cameron
On Tue, 30 Oct 2018 15:56:15 -0500 Rob Herring wrote: > On Mon, Oct 29, 2018 at 06:39:30PM +0200, Stefan Popa wrote: > > Add support for Analog Devices AD7124 4-channels and 8-channels ADC. > > > > Signed-off-by: Stefan Popa > > --- > > Changes in v2: > > - Nothing changed. > > Changes in

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 09:54:24 -0400 Steven Rostedt wrote: > On Fri, 2 Nov 2018 16:14:59 +0900 > Masami Hiramatsu wrote: > > > On Thu, 1 Nov 2018 15:10:14 -0400 > > Steven Rostedt wrote: > > > > > On Thu, 1 Nov 2018 23:29:28 +0900 > > > Masami Hiramatsu wrote: > > > > > > > Fix strpbrk()'s

Re: [BUGFIX PATCH] tracing/kprobes: Fix strpbrk() argument order

2018-11-03 Thread Masami Hiramatsu
On Fri, 2 Nov 2018 09:54:24 -0400 Steven Rostedt wrote: > On Fri, 2 Nov 2018 16:14:59 +0900 > Masami Hiramatsu wrote: > > > On Thu, 1 Nov 2018 15:10:14 -0400 > > Steven Rostedt wrote: > > > > > On Thu, 1 Nov 2018 23:29:28 +0900 > > > Masami Hiramatsu wrote: > > > > > > > Fix strpbrk()'s

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-03 Thread Hans de Goede
Hi, On 03-11-18 07:57, João Paulo Rechi Vita wrote: Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting "Discharging" on some machines when AC was connected but the battery was not charging. But now on these machines the battery status is reported as "Not charging" even when the

Re: [PATCH] ACPI / battery: Fix reporting "Not charging" when capacity is 100%

2018-11-03 Thread Hans de Goede
Hi, On 03-11-18 07:57, João Paulo Rechi Vita wrote: Commit 19fffc8450d4378580a8f019b195c4617083176f fixed reporting "Discharging" on some machines when AC was connected but the battery was not charging. But now on these machines the battery status is reported as "Not charging" even when the

Re: [PATCH 4/6] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-03 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/Detach-TPM-space-code-from-tpm_transmit-flow/20181103-183010 base: git://git.infradead.org/users/jjs/linux-tpmdd next config: i386-randconfig-x002-201843 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

Re: [PATCH 4/6] tpm: move tpm_validate_commmand() to tpm2-space.c

2018-11-03 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/Detach-TPM-space-code-from-tpm_transmit-flow/20181103-183010 base: git://git.infradead.org/users/jjs/linux-tpmdd next config: i386-randconfig-x002-201843 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

[PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-03 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. --- Changes in v2: - Resolve a few compilation errors. - Add a level of indirection to read and write gpios. Signed-off-by: Nishad Kamdar --- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 89

[PATCH v2] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-03 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. --- Changes in v2: - Resolve a few compilation errors. - Add a level of indirection to read and write gpios. Signed-off-by: Nishad Kamdar --- drivers/staging/olpc_dcon/olpc_dcon_xo_1.c | 89

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-11-03 Thread Jonathan Cameron
On Fri, 2 Nov 2018 10:59:06 -0300 Matheus Tavares wrote: > On 10/28/18 1:43 PM, Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:01 -0300 > > Matheus Tavares wrote: > > > >> Previously, ad2s90_probe ignored the return code from spi_setup, not > >> handling its possible failure. This

Re: [PATCH v2 2/2] kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function()

2018-11-03 Thread Daniel Thompson
On Wed, Oct 31, 2018 at 02:41:14PM -0700, Doug Anderson wrote: > > As mentioned in another part of the thread we can also add robustness > > by skipping a cpu where csd->flags != 0 (and adding an appropriately > > large comment regarding why). Doing the check directly is abusing > > internal

Re: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-11-03 Thread Jonathan Cameron
On Fri, 2 Nov 2018 10:59:06 -0300 Matheus Tavares wrote: > On 10/28/18 1:43 PM, Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:01 -0300 > > Matheus Tavares wrote: > > > >> Previously, ad2s90_probe ignored the return code from spi_setup, not > >> handling its possible failure. This

Re: [PATCH v2 2/2] kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function()

2018-11-03 Thread Daniel Thompson
On Wed, Oct 31, 2018 at 02:41:14PM -0700, Doug Anderson wrote: > > As mentioned in another part of the thread we can also add robustness > > by skipping a cpu where csd->flags != 0 (and adding an appropriately > > large comment regarding why). Doing the check directly is abusing > > internal

<    1   2   3   4   >