Sometimes we want to print a whole line without being disturbed by
concurrent printk() from interrupts and/or other threads, for printk()
which does not end with '\n' can be disturbed.
We tried to allow printk() callers to explicitly use their local buffer
in order to make sure that a whole line
Sometimes we want to print a whole line without being disturbed by
concurrent printk() from interrupts and/or other threads, for printk()
which does not end with '\n' can be disturbed.
We tried to allow printk() callers to explicitly use their local buffer
in order to make sure that a whole line
Commit 67ec1072b053 (ALSA: pcm: Fix rwsem deadlock for non-atomic PCM stream)
fixes deadlock for non-atomic PCM stream. But, This patch causes antother stuck.
If writer is RT thread and reader is a normal thread, the reader thread will
be difficult to get scheduled. It may not give chance to
Commit 67ec1072b053 (ALSA: pcm: Fix rwsem deadlock for non-atomic PCM stream)
fixes deadlock for non-atomic PCM stream. But, This patch causes antother stuck.
If writer is RT thread and reader is a normal thread, the reader thread will
be difficult to get scheduled. It may not give chance to
On 11/21/18 11:16 AM, Linus Torvalds wrote:
> On Wed, Nov 21, 2018 at 9:27 AM Linus Torvalds
> wrote:
>>
>> It would be interesting to know exactly which copy it is that matters
>> so much... *inlining* the erms case might show that nicely in
>> profiles.
>
> Side note: the fact that Jens'
On 11/21/18 11:16 AM, Linus Torvalds wrote:
> On Wed, Nov 21, 2018 at 9:27 AM Linus Torvalds
> wrote:
>>
>> It would be interesting to know exactly which copy it is that matters
>> so much... *inlining* the erms case might show that nicely in
>> profiles.
>
> Side note: the fact that Jens'
On Sat, Nov 24, 2018 at 2:37 AM Steven Rostedt wrote:
>
> On Fri, 23 Nov 2018 09:01:18 +0900
> Namhyung Kim wrote:
>
> > Acked-by: Namhyung Kim
>
> Thanks Namhyung!
It'd be nice if you cc me for the whole patchset (and other tracing
patches) next time.
Thanks,
Namhyung
On Sat, Nov 24, 2018 at 2:37 AM Steven Rostedt wrote:
>
> On Fri, 23 Nov 2018 09:01:18 +0900
> Namhyung Kim wrote:
>
> > Acked-by: Namhyung Kim
>
> Thanks Namhyung!
It'd be nice if you cc me for the whole patchset (and other tracing
patches) next time.
Thanks,
Namhyung
On Wed, Nov 21, 2018 at 08:27:19PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> In order to make it possible to have multiple callbacks registered with the
> function_graph tracer, the retstack needs to be converted from an array of
> ftrace_ret_stack structures to an array
On Wed, Nov 21, 2018 at 08:27:19PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)"
>
> In order to make it possible to have multiple callbacks registered with the
> function_graph tracer, the retstack needs to be converted from an array of
> ftrace_ret_stack structures to an array
On Sat, Oct 13, 2018 at 10:59:46AM -0700, Randy Dunlap wrote:
> 4.19-rc7, on x86_64:
>
> modprobe test_kmod; rmmod test_kmod
>
> [ 199.033143] calling test_kmod_init+0x0/0x1000 [test_kmod] @ 1704
> [ 199.034636] misc test_kmod0: interface ready
> [ 199.035468] initcall
On Sat, Oct 13, 2018 at 10:59:46AM -0700, Randy Dunlap wrote:
> 4.19-rc7, on x86_64:
>
> modprobe test_kmod; rmmod test_kmod
>
> [ 199.033143] calling test_kmod_init+0x0/0x1000 [test_kmod] @ 1704
> [ 199.034636] misc test_kmod0: interface ready
> [ 199.035468] initcall
We double free the misc device string twice on rmmod, fix this.
Without this we cannot remove the module without crashing.
Cc: # for v4.12 and up
Reported-by: Randy Dunlap
Signed-off-by: Luis Chamberlain
---
lib/test_kmod.c | 1 -
1 file changed, 1 deletion(-)
diff --git
We double free the misc device string twice on rmmod, fix this.
Without this we cannot remove the module without crashing.
Cc: # for v4.12 and up
Reported-by: Randy Dunlap
Signed-off-by: Luis Chamberlain
---
lib/test_kmod.c | 1 -
1 file changed, 1 deletion(-)
diff --git
On Thu, Nov 15, 2018 at 7:17 AM Mike Rapoport wrote:
>
> On Tue, Nov 06, 2018 at 05:36:42PM +0530, Souptick Joarder wrote:
> > Page fault handlers are supposed to return VM_FAULT codes,
> > but some drivers/file systems mistakenly return error
> > numbers. Now that all drivers/file systems have
On Thu, Nov 15, 2018 at 7:17 AM Mike Rapoport wrote:
>
> On Tue, Nov 06, 2018 at 05:36:42PM +0530, Souptick Joarder wrote:
> > Page fault handlers are supposed to return VM_FAULT codes,
> > but some drivers/file systems mistakenly return error
> > numbers. Now that all drivers/file systems have
On Fri, 2018-11-23 at 03:19 -0800, tip-bot for Thomas Gleixner wrote:
> The SPDX
> identifier is a legally binding shorthand, which can be used instead of the
> full boiler plate text.
Is the "legally binding shorthand" actually proven anywhere?
I am not aware of any case law for this.
On Fri, 2018-11-23 at 03:19 -0800, tip-bot for Thomas Gleixner wrote:
> The SPDX
> identifier is a legally binding shorthand, which can be used instead of the
> full boiler plate text.
Is the "legally binding shorthand" actually proven anywhere?
I am not aware of any case law for this.
Well, moving "__printf(3, 4) __cold" to before
"int devkmsg_emit(int facility, int level, const char *fmt, ...) {"
seems to be working. I did not know...
>From 86fff21e5fef6d3f7970cf5c07a54a907e582b52 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa
Date: Sat, 24 Nov 2018 13:05:25 +0900
Subject:
Well, moving "__printf(3, 4) __cold" to before
"int devkmsg_emit(int facility, int level, const char *fmt, ...) {"
seems to be working. I did not know...
>From 86fff21e5fef6d3f7970cf5c07a54a907e582b52 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa
Date: Sat, 24 Nov 2018 13:05:25 +0900
Subject:
On Fri, Nov 23, 2018 at 03:56:33PM +0800, Pan Bian wrote:
> The function dentry_connected calls dput(dentry) to drop the previously
> acquired reference to dentry. In this case, dentry can be released.
> After that, IS_ROOT(dentry) checks the condition
> (dentry == dentry->d_parent), which may
On Fri, Nov 23, 2018 at 03:56:33PM +0800, Pan Bian wrote:
> The function dentry_connected calls dput(dentry) to drop the previously
> acquired reference to dentry. In this case, dentry can be released.
> After that, IS_ROOT(dentry) checks the condition
> (dentry == dentry->d_parent), which may
On 24/11/18 1:53 am, Szabolcs Nagy wrote:
On 23/11/18 14:11, David Newall wrote:
On 24/11/18 12:04 am, Florian Weimer wrote:
But socketcall does not exist on all architectures. Neither does
getpid, it's called getxpid on some architectures.
...
I think it would be a poor approach to expose
On 24/11/18 1:53 am, Szabolcs Nagy wrote:
On 23/11/18 14:11, David Newall wrote:
On 24/11/18 12:04 am, Florian Weimer wrote:
But socketcall does not exist on all architectures. Neither does
getpid, it's called getxpid on some architectures.
...
I think it would be a poor approach to expose
On 11/22/18 3:56 AM, Andy Shevchenko wrote:
On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote:
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote:
Compare:
/* CFL */
{ PCI_DEVICE(0x8086, 0xa348),
.driver_data = (unsigned
On 11/22/18 3:56 AM, Andy Shevchenko wrote:
On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote:
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote:
Compare:
/* CFL */
{ PCI_DEVICE(0x8086, 0xa348),
.driver_data = (unsigned
This series removes "select ARCH_USES_GETTIMEOFFSET" from arch/m68k
and converts users of arch_gettimeoffset to the clocksource API.
Various bugs are fixed along the way.
Those platforms which do not actually implement arch_gettimeoffset
(apollo, q40, sun3, sun3x) use the "jiffies" clocksource by
This series removes "select ARCH_USES_GETTIMEOFFSET" from arch/m68k
and converts users of arch_gettimeoffset to the clocksource API.
Various bugs are fixed along the way.
Those platforms which do not actually implement arch_gettimeoffset
(apollo, q40, sun3, sun3x) use the "jiffies" clocksource by
Some platforms execute their timer handler with the interrupt priority
level set below 6. That means the handler could be interrupted by another
driver and this could lead to re-entry of the timer core.
Avoid this by use of local_irq_save/restore for timer interrupt dispatch.
This provides mutual
Some platforms execute their timer handler with the interrupt priority
level set below 6. That means the handler could be interrupted by another
driver and this could lead to re-entry of the timer core.
Avoid this by use of local_irq_save/restore for timer interrupt dispatch.
This provides mutual
This resolves some bugs that affect VIA timer counter accesses.
Avoid lost interrupts caused by reading the counter low byte register.
Make allowance for the fact that the counter will be decremented to
0x before being reloaded.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn
This resolves some bugs that affect VIA timer counter accesses.
Avoid lost interrupts caused by reading the counter low byte register.
Make allowance for the fact that the counter will be decremented to
0x before being reloaded.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Finn
Because hp300_read_clk() never checks the timer interrupt flag it may
fail to notice that the timer has wrapped, allowing the clock to jump
backwards. This is not a new problem.
This is resolved by checking the interrupt flag and, if need be,
taking wrap-around into account. The interrupt handler
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Normally the MFP timer C interrupt flag would be used to check for
timer counter wrap-around. Unfortunately, that flag gets cleared by the
MFP itself (due to automatic End-of-Interrupt mode). This means that
Because hp300_read_clk() never checks the timer interrupt flag it may
fail to notice that the timer has wrapped, allowing the clock to jump
backwards. This is not a new problem.
This is resolved by checking the interrupt flag and, if need be,
taking wrap-around into account. The interrupt handler
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Normally the MFP timer C interrupt flag would be used to check for
timer counter wrap-around. Unfortunately, that flag gets cleared by the
MFP itself (due to automatic End-of-Interrupt mode). This means that
Reading the timer counter races with timer overflow (and the
corresponding interrupt). This is resolved by reading the overflow
register and taking this value into account. The interrupt handler
must clear the overflow register when it eventually executes.
Suggested-by: Thomas Gleixner
Reading the timer counter races with timer overflow (and the
corresponding interrupt). This is resolved by reading the overflow
register and taking this value into account. The interrupt handler
must clear the overflow register when it eventually executes.
Suggested-by: Thomas Gleixner
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v2:
- Don't check for timer interrupt in bvme6000_read_clk() when the timer is
about to be reloaded.
Changed since v1:
- Moved clk_total
These dummy implementations are no better than
default_arch_gettimeoffset() so remove them.
Signed-off-by: Finn Thain
---
arch/m68k/apollo/config.c | 7 ---
arch/m68k/q40/config.c| 9 -
arch/m68k/sun3/config.c | 2 --
arch/m68k/sun3/intersil.c | 7 ---
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v2:
- Don't check for timer interrupt in bvme6000_read_clk() when the timer is
about to be reloaded.
Changed since v1:
- Moved clk_total
These dummy implementations are no better than
default_arch_gettimeoffset() so remove them.
Signed-off-by: Finn Thain
---
arch/m68k/apollo/config.c | 7 ---
arch/m68k/q40/config.c| 9 -
arch/m68k/sun3/config.c | 2 --
arch/m68k/sun3/intersil.c | 7 ---
The functions that implement arch_gettimeoffset are re-used by
new clocksource drivers in subsequent patches.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
arch/m68k/Kconfig | 1 -
arch/m68k/amiga/config.c| 3 ---
arch/m68k/atari/config.c| 2 --
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v2:
- Don't check for timer interrupt in amiga_read_clk() when the timer is
about to be reloaded.
Changed since v1:
- Moved clk_total
The functions that implement arch_gettimeoffset are re-used by
new clocksource drivers in subsequent patches.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
arch/m68k/Kconfig | 1 -
arch/m68k/amiga/config.c| 3 ---
arch/m68k/atari/config.c| 2 --
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v2:
- Don't check for timer interrupt in amiga_read_clk() when the timer is
about to be reloaded.
Changed since v1:
- Moved clk_total
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
- Use type u32 for tick counter.
---
arch/m68k/hp300/time.c | 37
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
- Use type u32 for tick counter.
---
arch/m68k/include/asm/mvme147hw.h | 1 -
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
- Use type u32 for tick counter.
---
arch/m68k/hp300/time.c | 37
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
- Use type u32 for tick counter.
---
arch/m68k/include/asm/mvme147hw.h | 1 -
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
---
arch/m68k/mvme16x/config.c | 37 +++--
1 file
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
---
Changed since v1:
- Moved clk_total access to within the irq lock.
---
arch/m68k/mvme16x/config.c | 37 +++--
1 file
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
Tested-by: Stan Johnson
---
Changed since v2:
- Drop unneeded 'clk_offset' variable.
Changed since v1:
- Moved clk_total access to within the irq lock.
-
Reading the timer counter races with timer overflow (and the
corresponding interrupt). This is resolved by reading the overflow
register and taking this value into account. The interrupt handler
must clear the overflow register when it eventually executes.
Suggested-by: Thomas Gleixner
Add a platform clocksource by adapting the existing arch_gettimeoffset
implementation.
Signed-off-by: Finn Thain
Acked-by: Linus Walleij
Tested-by: Stan Johnson
---
Changed since v2:
- Drop unneeded 'clk_offset' variable.
Changed since v1:
- Moved clk_total access to within the irq lock.
-
Reading the timer counter races with timer overflow (and the
corresponding interrupt). This is resolved by reading the overflow
register and taking this value into account. The interrupt handler
must clear the overflow register when it eventually executes.
Suggested-by: Thomas Gleixner
On Sat, 24 Nov 2018, Michael Schmitz wrote:
>
> Am 20.11.2018 um 23:02 schrieb Andreas Schwab:
> > On Nov 20 2018, Linus Walleij wrote:
> >
> > > Yes you already see the same as I see: this chip MK68901 has no less
> > > than four timers. I bet the kernel is just using one of them, out of
>
On Sat, 24 Nov 2018, Michael Schmitz wrote:
>
> Am 20.11.2018 um 23:02 schrieb Andreas Schwab:
> > On Nov 20 2018, Linus Walleij wrote:
> >
> > > Yes you already see the same as I see: this chip MK68901 has no less
> > > than four timers. I bet the kernel is just using one of them, out of
>
> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote:
>
> On Tue, 20 Nov 2018, Qian Cai wrote:
>
> Looking deeper at that.
>
>> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
>> index 70935ed91125..140571aa483c 100644
>> --- a/lib/debugobjects.c
>> +++ b/lib/debugobjects.c
>> @@ -23,9
> On Nov 22, 2018, at 4:56 PM, Thomas Gleixner wrote:
>
> On Tue, 20 Nov 2018, Qian Cai wrote:
>
> Looking deeper at that.
>
>> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
>> index 70935ed91125..140571aa483c 100644
>> --- a/lib/debugobjects.c
>> +++ b/lib/debugobjects.c
>> @@ -23,9
> On Nov 23, 2018, at 4:46 PM, Thomas Gleixner wrote:
>
> On Thu, 22 Nov 2018, Waiman Long wrote:
>> On 11/22/2018 11:31 PM, Qian Cai wrote:
>>> The current value of the early boot static pool size, 1024 is not big
>>> enough for systems with large number of CPUs with timer or/and workqueue
> On Nov 23, 2018, at 4:46 PM, Thomas Gleixner wrote:
>
> On Thu, 22 Nov 2018, Waiman Long wrote:
>> On 11/22/2018 11:31 PM, Qian Cai wrote:
>>> The current value of the early boot static pool size, 1024 is not big
>>> enough for systems with large number of CPUs with timer or/and workqueue
The function hfs_bmap_free frees node via hfs_bnode_put(node). However,
it then reads node->this when dumping error message on an error path,
which may result in a use-after-free bug. This patch frees node only
when it is never used.
Fixes: a1185ffa2fc("HFS rewrite")
Signed-off-by: Pan Bian
The function hfs_bmap_free frees node via hfs_bnode_put(node). However,
it then reads node->this when dumping error message on an error path,
which may result in a use-after-free bug. This patch frees node only
when it is never used.
Fixes: a1185ffa2fc("HFS rewrite")
Signed-off-by: Pan Bian
On 11/23/2018 11:30 AM, Mimi Zohar wrote:
> On Fri, 2018-11-23 at 11:03 -0800, Casey Schaufler wrote:
>> On 11/22/2018 7:49 AM, Roberto Sassu wrote:
>>> Although rootfs (tmpfs) supports xattrs, they are not set due to the
>>> limitation of the cpio format. A new format called 'newcx' was proposed
On 11/23/2018 11:30 AM, Mimi Zohar wrote:
> On Fri, 2018-11-23 at 11:03 -0800, Casey Schaufler wrote:
>> On 11/22/2018 7:49 AM, Roberto Sassu wrote:
>>> Although rootfs (tmpfs) supports xattrs, they are not set due to the
>>> limitation of the cpio format. A new format called 'newcx' was proposed
Am 20.11.2018 um 23:02 schrieb Andreas Schwab:
On Nov 20 2018, Linus Walleij wrote:
Yes you already see the same as I see: this chip MK68901 has
no less than four timers. I bet the kernel is just using one of them,
out of habit.
Note that not all timers can be used freely. Some of them
Am 20.11.2018 um 23:02 schrieb Andreas Schwab:
On Nov 20 2018, Linus Walleij wrote:
Yes you already see the same as I see: this chip MK68901 has
no less than four timers. I bet the kernel is just using one of them,
out of habit.
Note that not all timers can be used freely. Some of them
On Fri, Nov 23, 2018 at 04:51:49PM -0800, Viacheslav Dubeyko wrote:
> On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote:
> > The function hfs_bmap_free frees node via hfs_bnode_put(node).
> > However,
> > it then reads node->this when dumping error message on an error path,
> > which may result in
On Fri, Nov 23, 2018 at 04:51:49PM -0800, Viacheslav Dubeyko wrote:
> On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote:
> > The function hfs_bmap_free frees node via hfs_bnode_put(node).
> > However,
> > it then reads node->this when dumping error message on an error path,
> > which may result in
On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote:
> The function hfs_bmap_free frees node via hfs_bnode_put(node).
> However,
> it then reads node->this when dumping error message on an error path,
> which may result in a use-after-free bug. This patch frees node only
> when it is never used.
>
On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote:
> The function hfs_bmap_free frees node via hfs_bnode_put(node).
> However,
> it then reads node->this when dumping error message on an error path,
> which may result in a use-after-free bug. This patch frees node only
> when it is never used.
>
Hi Marcelo,
I believe that a proper commit message for this patch could be something
like "Add device tree support".
On 11/23, Marcelo Schmitt wrote:
> Added a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to complete device-tree support for this
> driver.
>
>
Hi Marcelo,
I believe that a proper commit message for this patch could be something
like "Add device tree support".
On 11/23, Marcelo Schmitt wrote:
> Added a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to complete device-tree support for this
> driver.
>
>
On 2018/11/24 0:56, Steven Rostedt wrote:
> On Fri, 23 Nov 2018 13:46:47 +0100
> Petr Mladek wrote:
>
>> Steven told me on Plumbers conference that even few initial
>> characters saved him a day few times.
>
> Yes, and that has happened more than once. I would reboot and retest
> code that is
On 2018/11/24 0:56, Steven Rostedt wrote:
> On Fri, 23 Nov 2018 13:46:47 +0100
> Petr Mladek wrote:
>
>> Steven told me on Plumbers conference that even few initial
>> characters saved him a day few times.
>
> Yes, and that has happened more than once. I would reboot and retest
> code that is
Move ad2s90 resolver driver out of staging to the main tree.
Signed-off-by: Matheus Tavares
Signed-off-by: Victor Colombo
---
Changes in v3:
- none
Changes in v2:
- Disabled git move detection, to see the whole code, as Jonathan
suggested
drivers/iio/resolver/Kconfig | 10 ++
Move ad2s90 resolver driver out of staging to the main tree.
Signed-off-by: Matheus Tavares
Signed-off-by: Victor Colombo
---
Changes in v3:
- none
Changes in v2:
- Disabled git move detection, to see the whole code, as Jonathan
suggested
drivers/iio/resolver/Kconfig | 10 ++
This patch adds device tree support to ad2s90 with standard
device tree id table.
Signed-off-by: Matheus Tavares
---
Changes in v3:
- Removed of_patch_ptr from of_match_table assignment
Changes in v2:
- none
drivers/staging/iio/resolver/ad2s90.c | 7 +++
1 file changed, 7 insertions(+)
This patch adds device tree support to ad2s90 with standard
device tree id table.
Signed-off-by: Matheus Tavares
---
Changes in v3:
- Removed of_patch_ptr from of_match_table assignment
Changes in v2:
- none
drivers/staging/iio/resolver/ad2s90.c | 7 +++
1 file changed, 7 insertions(+)
From: Alexandru Ardelean
This patch adds a max frequency check at the beginning of ad2s90_probe
function so that when it is set to a value above 0.83Mhz, dev_err is
called with an appropriate message and -EINVAL is returned.
The defined limit is 0.83Mhz instead of 2Mhz, which is the chip's max
This series adds device tree support to ad2s90, adds the respective dt-binding
documentation, solves all remaining codestyle problems for ad2s90 and move it
out of staging.
This patch set completes all the remaining itens listed to be done before moving
the driver out of staging, enumerated in
From: Alexandru Ardelean
This patch adds a max frequency check at the beginning of ad2s90_probe
function so that when it is set to a value above 0.83Mhz, dev_err is
called with an appropriate message and -EINVAL is returned.
The defined limit is 0.83Mhz instead of 2Mhz, which is the chip's max
This series adds device tree support to ad2s90, adds the respective dt-binding
documentation, solves all remaining codestyle problems for ad2s90 and move it
out of staging.
This patch set completes all the remaining itens listed to be done before moving
the driver out of staging, enumerated in
This patch removes the license boilerplate text at the top of ad2s90.c
and, instead, adds the SPDX GPL-2.0 license identifier, which solves the
checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1".
Signed-off-by: Matheus Tavares
---
Changes in v3:
- none
From: Victor Colombo
Fix the checkpatch.pl issue:
"CHECK: struct mutex definition without comment".
Signed-off-by: Victor Colombo
Signed-off-by: Matheus Tavares
---
Changes in v3:
- none
Changes in v2:
- Patch added in v2
drivers/staging/iio/resolver/ad2s90.c | 2 +-
1 file changed, 1
This patch adds the device tree binding documentation for the ad2s90
resolver-to-digital converter.
Signed-off-by: Matheus Tavares
---
Changes in v3:
- Added reference to spi-bus documentation after spi properties, as
suggested by Alexandru Ardelean.
Changes in v2:
- Rewritten 'spi-cpol and
This patch removes the license boilerplate text at the top of ad2s90.c
and, instead, adds the SPDX GPL-2.0 license identifier, which solves the
checkpatch.pl warning:
"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1".
Signed-off-by: Matheus Tavares
---
Changes in v3:
- none
From: Victor Colombo
Fix the checkpatch.pl issue:
"CHECK: struct mutex definition without comment".
Signed-off-by: Victor Colombo
Signed-off-by: Matheus Tavares
---
Changes in v3:
- none
Changes in v2:
- Patch added in v2
drivers/staging/iio/resolver/ad2s90.c | 2 +-
1 file changed, 1
This patch adds the device tree binding documentation for the ad2s90
resolver-to-digital converter.
Signed-off-by: Matheus Tavares
---
Changes in v3:
- Added reference to spi-bus documentation after spi properties, as
suggested by Alexandru Ardelean.
Changes in v2:
- Rewritten 'spi-cpol and
The ad2s90 driver currently sets some spi settings (max_speed_hz and
mode) at ad2s90_probe. Since the maximum frequency is a required element
in DT binding for spi slave devices and because the spi mode for the
device can be either (0,0) or (1,1), these settings should be handled
via device tree,
The ad2s90 driver currently sets some spi settings (max_speed_hz and
mode) at ad2s90_probe. Since the maximum frequency is a required element
in DT binding for spi slave devices and because the spi mode for the
device can be either (0,0) or (1,1), these settings should be handled
via device tree,
Hi,
On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote:
> On 23/11/2018 0.01, Aaro Koskinen wrote:
> > With that reverted, the DMA works OK (and I can also now confirm that
> > OMAP_DMA_LCH_2D works). I haven't yet checked if we actually need that
> > quirk in OMAP UDC,
>
> The
Hi,
On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote:
> On 23/11/2018 0.01, Aaro Koskinen wrote:
> > With that reverted, the DMA works OK (and I can also now confirm that
> > OMAP_DMA_LCH_2D works). I haven't yet checked if we actually need that
> > quirk in OMAP UDC,
>
> The
On Wed, 7 Nov 2018 11:18:26 +0100 Michal Hocko wrote:
> From: Michal Hocko
>
> __dump_page prints the mapping pointer but that is quite unhelpful
> for many reports because the pointer itself only helps to distinguish
> anon/ksm mappings from other ones (because of lowest bits
> set).
On Wed, 7 Nov 2018 11:18:26 +0100 Michal Hocko wrote:
> From: Michal Hocko
>
> __dump_page prints the mapping pointer but that is quite unhelpful
> for many reports because the pointer itself only helps to distinguish
> anon/ksm mappings from other ones (because of lowest bits
> set).
Added a of_device_id struct variable and subsequent call to
MODULE_DEVICE_TABLE macro to complete device-tree support for this
driver.
Signed-off-by: Marcelo Schmitt
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Added a of_device_id struct variable and subsequent call to
MODULE_DEVICE_TABLE macro to complete device-tree support for this
driver.
Signed-off-by: Marcelo Schmitt
---
drivers/staging/iio/impedance-analyzer/ad5933.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Hi!
> > > > > > > You have general-purpose LED, yet you are treating it as
> > > > > > > "something
> > > > > > > special". That means ugly code (quoted above) and lack of
> > > > > > > flexibility.
> > > > > > >
> > I'd prefer this to be normal LED and "mic muted" to become normal
> >
Hi!
> > > > > > > You have general-purpose LED, yet you are treating it as
> > > > > > > "something
> > > > > > > special". That means ugly code (quoted above) and lack of
> > > > > > > flexibility.
> > > > > > >
> > I'd prefer this to be normal LED and "mic muted" to become normal
> >
1 - 100 of 840 matches
Mail list logo
