Re: [PATCH v2] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely

2018-12-12 Thread Wei Yang
On Tue, Dec 11, 2018 at 02:53:12PM +0100, Oscar Salvador wrote: >v1 -> v2: >- Keep branch to decrease refcount and print out > the failed pfn/page >- Modified changelog per Michal's feedback >- move put_page() out of the if/else branch > >--- >>From

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 03:27:51AM +0100, Marek Vasut wrote: > > I wonder whether the issue may be the JZ4780 UART not automatically > > resetting the FIFOs when FCR[0] changes. This is a guess, but the manual > > doesn't explicitly say it'll happen & the programming example it gives >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-12 Thread Jason Gunthorpe
On Wed, Dec 12, 2018 at 07:44:37PM -0500, Jerome Glisse wrote: > On many GPUs you can do that, it is hardware dependant and you have > steps to take but it is something you can do (and GPU can do > continuous DMA traffic have they have threads running that can > do continuous memory access). So i

Re: [PATCH v2] mm: thp: fix flags for pmd migration when split

2018-12-12 Thread Peter Xu
On Wed, Dec 12, 2018 at 04:51:38PM +0300, Konstantin Khlebnikov wrote: > On Wed, Dec 12, 2018 at 8:15 AM Peter Xu wrote: > > > > On Tue, Dec 11, 2018 at 11:21:44AM +0300, Konstantin Khlebnikov wrote: > > > On 11.12.2018 8:12, Peter Xu wrote: > > > > When splitting a huge migrating PMD, we'll

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-12 Thread Jason Gunthorpe
On Wed, Dec 12, 2018 at 07:01:09PM -0500, Jerome Glisse wrote: > On Wed, Dec 12, 2018 at 04:37:03PM -0700, Jason Gunthorpe wrote: > > On Wed, Dec 12, 2018 at 04:53:49PM -0500, Jerome Glisse wrote: > > > > Almost, we need some safety around assuming that DMA is complete the > > > > page, so the

[PATCH -next] usb: renesas_usbhs: Fix unused function warning when CONFIG_PM not set

2018-12-12 Thread YueHaibing
with CONFIG_PM not set, gcc warning this: drivers/usb/renesas_usbhs/common.c:844:12: warning: 'usbhsc_suspend' defined but not used [-Wunused-function] drivers/usb/renesas_usbhs/common.c:860:12: warning: 'usbhsc_resume' defined but not used [-Wunused-function] fix this by adding #ifdef around

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Tomasz Figa
On Wed, Dec 12, 2018 at 10:54 PM Christoph Hellwig wrote: > > On Wed, Dec 12, 2018 at 06:34:25PM +0900, Tomasz Figa wrote: > > The typical DMA-buf import/export flow is as follows: > > 1) Driver X allocates buffer A using this API for device x and gets a > > DMA address inside x's DMA (or IOVA)

Re: [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test

2018-12-12 Thread Michael Ellerman
Christophe Leroy writes: > On several arches, virt_to_phys() is in io.h > > Build fails without it: > > CC lib/test_debug_virtual.o > lib/test_debug_virtual.c: In function 'test_debug_virtual_init': > lib/test_debug_virtual.c:26:7: error: implicit declaration of function > 'virt_to_phys'

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-12 Thread Jonathan Liu
Hi Giulio, On Wed, 12 Dec 2018 at 04:20, Giulio Benetti wrote: > > Hi Jonathan, > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > > Hi Giulio, > > > > On Thu, 6 Dec 2018 at 22:00, Giulio Benetti > > wrote: > >> > >> Hi Jonathan, > >> > >> Il 06/12/2018 08:29, Jonathan Liu ha scritto: > >>> Hi

Re: [RFC PATCH v1 0/5] Add support for O_MAYEXEC

2018-12-12 Thread Matthew Wilcox
On Wed, Dec 12, 2018 at 09:17:07AM +0100, Mickaël Salaün wrote: > The goal of this patch series is to control script interpretation. A > new O_MAYEXEC flag used by sys_open() is added to enable userland script > interpreter to delegate to the kernel (and thus the system security > policy) the

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Marek Vasut
On 12/13/2018 02:48 AM, Paul Burton wrote: > Hi Marek, Hi, > On Thu, Dec 13, 2018 at 01:55:29AM +0100, Marek Vasut wrote: >> On 12/13/2018 01:41 AM, Paul Burton wrote: >>> This patch has broken the UART on my Ingenic JZ4780 based MIPS Creator >>> Ci20 board. After this patch the system seems to

Re: [PATCH] debugobjects: Move printk out of db lock critical sections

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 17:28), Waiman Long wrote: > > warning from lockdep as reported in https://lkml.org/lkml/2018/12/11/143. > That link shows an empty page, lkml.org is quite unstable. Let's use this one instead: https://lore.kernel.org/lkml/20181211091154.GL23332@shao2-debian/T/#u -ss

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-12 Thread Michael Ellerman
Frank Rowand writes: > On 12/11/18 8:07 AM, Rob Herring wrote: >> On Tue, Dec 11, 2018 at 7:29 AM Michael Ellerman wrote: ... >>> diff --git a/drivers/of/base.c b/drivers/of/base.c >>> index 09692c9b32a7..d8e4534c0686 100644 >>> --- a/drivers/of/base.c >>> +++ b/drivers/of/base.c >>> @@ -1190,6

Re: [PATCH v03] powerpc/mobility: Fix node detach/rename problem

2018-12-12 Thread Michael Ellerman
Rob Herring writes: > On Tue, Dec 11, 2018 at 7:29 AM Michael Ellerman wrote: ... >> diff --git a/drivers/of/base.c b/drivers/of/base.c >> index 09692c9b32a7..d8e4534c0686 100644 >> --- a/drivers/of/base.c >> +++ b/drivers/of/base.c >> @@ -1190,6 +1190,10 @@ struct device_node

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

2018-12-12 Thread Jonathan Liu
Hi Giulio, On Wed, 12 Dec 2018 at 04:39, Giulio Benetti wrote: > > Forgot to ask you, > > Il 11/12/2018 18:20, Giulio Benetti ha scritto: > > Hi Jonathan, > > > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > >> Hi Giulio, > >> > >> On Thu, 6 Dec 2018 at 22:00, Giulio Benetti > >> wrote: >

[PATCH net V3 3/3] Revert "net: vhost: lock the vqs one by one"

2018-12-12 Thread Jason Wang
This reverts commit 78139c94dc8c96a478e67dab3bee84dc6eccb5fd. We don't protect device IOTLB with vq mutex, which will lead e.g use after free for device IOTLB entries. And since we've switched to use mutex_trylock() in previous patch, it's safe to revert it without having deadlock. Fixes: commit

[PATCH net V3 2/3] vhost_net: switch to use mutex_trylock() in vhost_net_busy_poll()

2018-12-12 Thread Jason Wang
We used to hold the mutex of paired virtqueue in vhost_net_busy_poll(). But this will results an inconsistent lock order which may cause deadlock if we try to bring back the protection of device IOTLB with vq mutex that requires to hold mutex of all virtqueues at the same time. Fix this simply by

[PATCH net V3 0/3] Fix various issue of vhost

2018-12-12 Thread Jason Wang
Hi: This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through vq mutex, this fixes possible use after free in device IOTLB entries. Please consider them for

Re: [kbuild-all] [PATCH v3] ARM: smp: add support for per-task stack canaries

2018-12-12 Thread Rong Chen
On 12/09/2018 06:37 PM, Russell King - ARM Linux wrote: On Sun, Dec 09, 2018 at 06:28:11PM +0800, kbuild test robot wrote: Hi Ard, I love your patch! Perhaps something to improve: Hi, This looks to me like a false warning - how can a patch touching arch code affect the result of

[PATCH net V3 1/3] vhost: make sure used idx is seen before log in vhost_add_used_n()

2018-12-12 Thread Jason Wang
We miss a write barrier that guarantees used idx is updated and seen before log. This will let userspace sync and copy used ring before used idx is update. Fix this by adding a barrier before log_write(). Fixes: 8dd014adfea6f ("vhost-net: mergeable buffers support") Acked-by: Michael S. Tsirkin

Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode

2018-12-12 Thread Joe Perches
On Wed, 2018-12-12 at 13:14 -0500, Jeremy Cline wrote: > It might be worth noting this fixes commit 6f4d29df66ac > ("scripts/spdxcheck.py: make python3 compliant") umm, how does it do that? > and also Cc this for > stable since 6f4d29df66ac got backported to v4.19. While that commit > did indeed

Re: [v7, PATCH 0/2] add Ethernet driver support for mt2712

2018-12-12 Thread biao huang
Dear All, Sorry, I misunderstood David's reply mail in v6 series, please ignore v7 series. Dear David, I send you another follow-up patch to fix up build warning, please check it. Thanks! On Thu, 2018-12-13 at 09:56 +0800, Biao Huang wrote: > Changes in v7: > Add MODULE_LICENSE

Re: [PATCH RFC] rcu: add sparse check to rcu_assign_pointer

2018-12-12 Thread Paul E. McKenney
On Wed, Dec 12, 2018 at 02:37:10PM -0800, Joel Fernandes (Google) wrote: > rcu_assign_pointer currently doesn't do any sparse checking on a pointer > assigned. So its possible that a pointer that is not __rcu annotated is > assigned with rcu_assign_pointer without sparse complainting. >

[PATCH] seccomp: fix poor type promotion

2018-12-12 Thread Tycho Andersen
sparse complains, kernel/seccomp.c:1172:13: warning: incorrect type in assignment (different base types) kernel/seccomp.c:1172:13:expected restricted __poll_t [usertype] ret kernel/seccomp.c:1172:13:got int kernel/seccomp.c:1173:13: warning: restricted __poll_t degrades to integer

[PATCH] net-next: stmmac: dwmac-mediatek: add module license info

2018-12-12 Thread Biao Huang
Add MODULE_LICENSE info to fix this: WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.o Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |5 + 1 file changed, 5 insertions(+) diff --git

Re: rcu_preempt caused oom

2018-12-12 Thread Paul E. McKenney
On Thu, Dec 13, 2018 at 02:11:35AM +, Zhang, Jun wrote: > Hello, Paul > > I think the next patch is better. > Because ULONG_CMP_GE could cause double write, which has risk that write back > old value. > Please help review. > I don't test it. If you agree, we will test it. Just to make sure

Re: [PATCH net V2 0/4] Fix various issue of vhost

2018-12-12 Thread Jason Wang
On 2018/12/13 上午7:31, David Miller wrote: From: Jason Wang Date: Wed, 12 Dec 2018 18:08:15 +0800 This series tries to fix various issues of vhost: - Patch 1 adds a missing write barrier between used idx updating and logging. - Patch 2-3 brings back the protection of device IOTLB through

Re: [PATCH net V2 4/4] vhost: log dirty page correctly

2018-12-12 Thread Jason Wang
On 2018/12/12 下午10:32, Michael S. Tsirkin wrote: On Wed, Dec 12, 2018 at 06:08:19PM +0800, Jason Wang wrote: Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To

Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes"

2018-12-12 Thread Daniel Wang
> Additionally, for dbdda842fe96f to work as expected we really need fd5f7cde1b85d4c. Otherwise printk() can schedule under console_sem and console_owner, which will deactivate the "load balance" logic. It looks like fd5f7cde1b85d4c got into 4.14.82 that was released last month. On Wed, Dec 12,

[PATCH net] net: ipv4: do not handle duplicate fragments as overlapping

2018-12-12 Thread Michal Kubecek
Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping segments.") IPv4 reassembly code drops the whole queue whenever an overlapping fragment is received. However, the test is written in a way which detects duplicate fragments as overlapping so that in environments with many

[PATCH v1] pinctrl: mediatek: improve Kconfig dependencies

2018-12-12 Thread Ryder Lee
Remove prompts to make all pinctrl cores to non-visible symbols and make sure the target SoCs would be coupled with the corresponding cores. Signed-off-by: Ryder Lee --- Changes since v1: - Revise commit message - Change all pinctrl cores to non-visible symbols - Drop EINT_MTK in

Re: [PATCH net V2 3/4] Revert "net: vhost: lock the vqs one by one"

2018-12-12 Thread Jason Wang
On 2018/12/12 下午10:24, Michael S. Tsirkin wrote: On Wed, Dec 12, 2018 at 06:08:18PM +0800, Jason Wang wrote: This reverts commit 78139c94dc8c96a478e67dab3bee84dc6eccb5fd. We don't protect device IOTLB with vq mutex, which will lead e.g use after free for device IOTLB entries. And since we've

Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes"

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 16:40), Daniel Wang wrote: > In case this was buried in previous messages, the commit I'd like to > get backported to 4.14 is dbdda842fe96f: printk: Add console owner and > waiter logic to load balance console writes. But another followup > patch that fixes a bug in that patch is also

Re: [PATCH] iommu/io-pgtable-arm-v7s: Don't check PHYS_OFFSET if RAMDOMIZE_BASE is enabled

2018-12-12 Thread Yong Wu
On Wed, 2018-12-12 at 13:39 +, Robin Murphy wrote: > On 12/12/2018 13:02, Yong Wu wrote: > > If CONFIG_RANDOMIZE_BASE is enabled, the "memstart_addr" will be updated > > randomly, then the PHYS_OFFSET may be random. > > Oh, I hadn't ever realised that, good catch. However, since 29859aeb8a6e

Re: [PATCH v4 0/5] hisi_sas: DIF support

2018-12-12 Thread Martin K. Petersen
John, > This patchset introduces support to the driver for DIF/DIX. Applied 1-3 to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 4/5] scsi: hisi_sas: Add support for DIF feature for v3 hw

2018-12-12 Thread Martin K. Petersen
John, > +static void fill_prot_v3_hw(struct scsi_cmnd *scsi_cmnd, > + struct hisi_sas_protect_iu_v3_hw *prot) > +{ > + u8 prot_type = scsi_get_prot_type(scsi_cmnd); > + u8 prot_op = scsi_get_prot_op(scsi_cmnd); > + unsigned int interval =

Re: [PATCH 4.19 096/139] ALSA: hda/realtek - fix the pop noise on headphone for lenovo laptops

2018-12-12 Thread Thomas Zeitlhofer
Hello Hui, On Thu, Dec 13, 2018 at 08:23:40AM +0800, Hui Wang wrote: > Hello Thomas, > > I have sent a new patch to fix this LED regression, after applying > this patch (ALSA: hda/realtek - fix the pop noise on headphone for > lenovo laptops) and the new patch (ALSA: hda/realtek - Fix the mute >

A weird problem of Realtek r8168 after resume from S3

2018-12-12 Thread Chris Chiu
Hi, We got an acer laptop which has a problem with ethernet networking after resuming from S3. The ethernet is popular realtek r8168. The lspci shows as follows. 02:00.1 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller

Re: [LKP] [tty] c96cf923a9: WARNING:possible_circular_locking_dependency_detected

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 14:54), Dmitry Safonov wrote: > > In this particular case we probably can just move free_page() > > out of uart_port lock scope. Note that free_page()->MM can printk() > > on its own. > > > > > > Something like this (not tested): > > Looks good to me. > Probably, it's worth to

Re: [PATCH] squashfs: enable __GFP_FS in ->readpage to prevent hang in mem alloc

2018-12-12 Thread Hou Tao
ping ? On 2018/12/6 9:14, Hou Tao wrote: > ping ? > > On 2018/12/4 10:08, Hou Tao wrote: >> There is no need to disable __GFP_FS in ->readpage: >> * It's a read-only fs, so there will be no dirty/writeback page and >> there will be no deadlock against the caller's locked page >> * It just

RE: rcu_preempt caused oom

2018-12-12 Thread Zhang, Jun
Hello, Paul I think the next patch is better. Because ULONG_CMP_GE could cause double write, which has risk that write back old value. Please help review. I don't test it. If you agree, we will test it. Thanks! diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 0b760c1..c00f34e 100644

[PATCH v9 08/14] ima: Introduce is_signed()

2018-12-12 Thread Thiago Jung Bauermann
With the introduction of another IMA signature type (modsig), some places will need to check for both of them. It is cleaner to do that if there's a helper function to tell whether an xattr_value represents an IMA signature. Suggested-by: Mimi Zohar Signed-off-by: Thiago Jung Bauermann ---

[PATCH v9 11/14] ima: Implement support for module-style appended signatures

2018-12-12 Thread Thiago Jung Bauermann
Implement the appraise_type=imasig|modsig option, allowing IMA to read and verify modsig signatures. In case a file has both an xattr signature and an appended modsig, IMA will only use the appended signature if the key used by the xattr signature isn't present in the IMA keyring. Also enable

[PATCH v9 12/14] ima: Add new "d-sig" template field

2018-12-12 Thread Thiago Jung Bauermann
Define new "d-sig" template field which holds the digest that is expected to match the one contained in the modsig. Suggested-by: Mimi Zohar Signed-off-by: Thiago Jung Bauermann --- Documentation/security/IMA-templates.rst | 5 security/integrity/ima/ima.h | 9 +++

[PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it

2018-12-12 Thread Thiago Jung Bauermann
This avoids a dependency cycle in soon-to-be-introduced CONFIG_IMA_APPRAISE_MODSIG: it will select CONFIG_MODULE_SIG_FORMAT which in turn selects CONFIG_KEYS. Kconfig then complains that CONFIG_INTEGRITY_SIGNATURE depends on CONFIG_KEYS. Signed-off-by: Thiago Jung Bauermann Signed-off-by: Mimi

[PATCH v9 13/14] ima: Write modsig to the measurement list

2018-12-12 Thread Thiago Jung Bauermann
Add modsig support to the "sig" template field, allowing the the contents of the modsig to be included in the measurement list. Suggested-by: Mimi Zohar Signed-off-by: Thiago Jung Bauermann --- security/integrity/ima/ima.h | 7 +++ security/integrity/ima/ima_modsig.c |

[PATCH v9 10/14] ima: Add modsig appraise_type option for module-style appended signatures

2018-12-12 Thread Thiago Jung Bauermann
Introduce the modsig keyword to the IMA policy syntax to specify that a given hook should expect the file to have the IMA signature appended to it. Here is how it can be used in a rule: appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig|modsig With this rule, IMA will accept either a

[PATCH v9 09/14] ima: Export func_tokens

2018-12-12 Thread Thiago Jung Bauermann
ima_read_modsig() will need it so that it can show an error message. Signed-off-by: Thiago Jung Bauermann --- security/integrity/ima/ima.h| 2 ++ security/integrity/ima/ima_policy.c | 12 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH v9 14/14] ima: Store the measurement again when appraising a modsig

2018-12-12 Thread Thiago Jung Bauermann
If the IMA template contains the 'sig' field, then the modsig should be added to the measurement list when the file is appraised, and that is what normally happens. But If a measurement rule caused a file containing a modsig to be measured before a different rule causes it to be appraised, the

[PATCH v9 06/14] integrity: Introduce asymmetric_sig_has_known_key()

2018-12-12 Thread Thiago Jung Bauermann
IMA will only look for a modsig if the xattr sig references a key which is not in the expected kernel keyring. To that end, introduce asymmetric_sig_has_known_key(). The logic of extracting the key used in the xattr sig is factored out from asymmetric_verify() so that it can be used by the new

[PATCH v9 04/14] integrity: Introduce struct evm_xattr

2018-12-12 Thread Thiago Jung Bauermann
Even though struct evm_ima_xattr_data includes a fixed-size array to hold a SHA1 digest, most of the code ignores the array and uses the struct to mean "type indicator followed by data of unspecified size" and tracks the real size of what the struct represents in a separate length variable. The

[PATCH v9 05/14] integrity: Introduce integrity_keyring_from_id()

2018-12-12 Thread Thiago Jung Bauermann
IMA will need to obtain the keyring used to verify file signatures so that it can verify the module-style signature appended to files. Signed-off-by: Thiago Jung Bauermann Signed-off-by: Mimi Zohar --- security/integrity/digsig.c| 28 +---

[PATCH v9 02/14] PKCS#7: Refactor verify_pkcs7_signature() and add pkcs7_get_message_sig()

2018-12-12 Thread Thiago Jung Bauermann
IMA will need to verify a PKCS#7 which has already been parsed. For this reason, factor out the code which does that from verify_pkcs7_signature() into a new function which takes a struct pkcs7_message instead of a data buffer. In addition, IMA will need to know the key that signed a given PKCS#7

[PATCH v9 01/14] MODSIGN: Export module signature definitions

2018-12-12 Thread Thiago Jung Bauermann
IMA will use the module_signature format for append signatures, so export the relevant definitions and factor out the code which verifies that the appended signature trailer is valid. Also, create a CONFIG_MODULE_SIG_FORMAT option so that IMA can select it and be able to use mod_check_sig()

[PATCH v9 03/14] PKCS#7: Introduce pkcs7_get_digest()

2018-12-12 Thread Thiago Jung Bauermann
IMA will need to access the digest of the PKCS7 message (as calculated by the kernel) before the signature is verified, so introduce pkcs7_get_digest() for that purpose. Also, modify pkcs7_digest() to detect when the digest was already calculated so that it doesn't have to do redundant work.

[PATCH v9 00/14] Appended signatures support for IMA appraisal

2018-12-12 Thread Thiago Jung Bauermann
Hello, This version is basically about tidying up the code to make it clearer. Most of the changes are in patches 11 and 14. There are two functional changes: one is modifying the list of hooks allowed to use modsig to allow verifying signed modules and disallow verifying firmware, and the other

Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes"

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 16:52), Sasha Levin wrote: > On Wed, Dec 12, 2018 at 01:49:25PM -0800, Daniel Wang wrote: > > Thanks for the clarification. So I guess I don't need to start another > > thread for it? What are the next steps? > > Nothing here, I'll queue it once Sergey or Petr clarify if they wanted

[PATCH] proc/sysctl: don't return ENOMEM on lookup when a table is unregistering

2018-12-12 Thread Ivan Delalande
proc_sys_lookup can fail with ENOMEM instead of ENOENT when the corresponding sysctl table is being unregistered. In our case we see this upon opening /proc/sys/net/*/conf files while network interfaces are being removed, which confuses our configuration daemon. The problem was successfully

Re: [PATCH] debugobjects: Move printk out of db lock critical sections

2018-12-12 Thread Sergey Senozhatsky
On (12/12/18 17:28), Waiman Long wrote: > The db->lock is a raw spinlock and so the lock hold time is supposed > to be short. This will not be the case when printk() is being involved > in some of the critical sections. In order to avoid the long hold time, > in case some messages need to be

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-12 Thread Jerome Glisse
On Thu, Dec 13, 2018 at 11:51:19AM +1100, Dave Chinner wrote: > On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > > On Thu, Dec 13, 2018 at 08:46:41AM +1100, Dave Chinner wrote: > > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 10, 2018 at

[v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-12 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 87 1 file changed, 87 insertions(+) create mode 100644

[v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-12 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 413 3

[v7, PATCH 0/2] add Ethernet driver support for mt2712

2018-12-12 Thread Biao Huang
Changes in v7: Add MODULE_LICENSE info in driver. Biao Huang (2): net:stmmac: dwmac-mediatek: add support for mt2712 dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC .../devicetree/bindings/net/mediatek-dwmac.txt | 87 +

RE: [PATCH] kernel/hung_task.c: force ignore_loglevel before panic

2018-12-12 Thread Liu, Chuansheng
> -Original Message- > From: Petr Mladek [mailto:pmla...@suse.com] > Sent: Wednesday, December 12, 2018 6:18 PM > To: Liu, Chuansheng > Cc: Tetsuo Handa ; Sergey Senozhatsky > ; a...@linux-foundation.org; > sergey.senozhat...@gmail.com; rost...@goodmis.org; dvyu...@google.com; >

[PATCH V2] kernel/hung_task.c: Force console verbose before panic

2018-12-12 Thread Liu, Chuansheng
Based on patch commit 401c636a0eeb ("kernel/hung_task.c: show all hung tasks before panic"), we could get the call stack of hung task. However, if the console loglevel is not high, we still can not see the useful panic information in practice, and in most cases users don't set console loglevel to

Re: [PATCH] staging: erofs: Add a blank line after declarations

2018-12-12 Thread Gao Xiang
Hi Sungkyung, On 2018/12/12 23:50, Sungkyung Kim wrote: > Fix a warning from checkpathch.pl: 'Missing a blank line after > declarations' > > Signed-off-by: Sungkyung Kim > --- > drivers/staging/erofs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 1/8] perf: Allow to block process in syscall tracepoints

2018-12-12 Thread Dmitry V. Levin
On Wed, Dec 12, 2018 at 08:26:39PM -0500, Steven Rostedt wrote: > On Thu, 13 Dec 2018 03:39:38 +0300, wrote: > > > btw, I didn't ask for the implementation to be ugly. > > You don't have to introduce polling into the kernel if you don't want to, > > userspace is perfectly capable of invoking

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Paul Burton
Hi Marek, On Thu, Dec 13, 2018 at 01:55:29AM +0100, Marek Vasut wrote: > On 12/13/2018 01:41 AM, Paul Burton wrote: > > This patch has broken the UART on my Ingenic JZ4780 based MIPS Creator > > Ci20 board. After this patch the system seems to detect garbage input > > that is recognized as SysRq

Re: [PATCH net-next] rhashtable: further improve stability of rhashtable_walk

2018-12-12 Thread Herbert Xu
On Wed, Dec 12, 2018 at 07:49:08PM +1100, NeilBrown wrote: > On Wed, Dec 12 2018, Herbert Xu wrote: > > > On Wed, Dec 12, 2018 at 05:41:29PM +1100, NeilBrown wrote: > >> > >> So you would substantially slow down the rhashtable_walk_start() step. > > > > This whole thing is meant for uses such as

[PATCH] integrity: Remove references to module keyring

2018-12-12 Thread Thiago Jung Bauermann
>From what I can tell, it has never been used. Signed-off-by: Thiago Jung Bauermann --- security/integrity/digsig.c| 1 - security/integrity/integrity.h | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c index

[PATCH] power: supply: isp1704: switch to gpiod API

2018-12-12 Thread Sebastian Reichel
This migrates isp1704 driver from old GPIO API to new descriptor based GPIO API and drops useless platform data as a side-effect. Migration is simple, since all mainline users are DT based and DT API does not change. Out of tree users of the platform data need to migrate to gpiod_lookup_table as

Re: [PATCH 1/2] scsi: aacraid: change wait_sem to a completion

2018-12-12 Thread Martin K. Petersen
Arnd, > The wait_sem member is used like a completion, so we should use the > respective API. The behavior is unchanged. Applied to 4.21/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] srcu: Remove srcu_queue_delayed_work_on()

2018-12-12 Thread Joel Fernandes
On Wed, Dec 12, 2018 at 07:55:46AM -0800, Paul E. McKenney wrote: > On Wed, Dec 12, 2018 at 10:05:19PM +0800, Boqun Feng wrote: > > Hi Joel, > > > > On Tue, Dec 11, 2018 at 05:40:16PM -0800, Joel Fernandes wrote: > > > On Tue, Dec 11, 2018 at 12:12:38PM +0100, Sebastian Andrzej Siewior wrote: > >

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-12 Thread Xue Chaojing
There is no need to schedule a different tasklet for refill, This patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 2 -- 2 files changed, 5

[PATCH] Documentation: hid: fix wrong data structure reference for UHID_OUTPUT

2018-12-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Documentation/hid/uhid.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hid/uhid.txt b/Documentation/hid/uhid.txt index c8656dd029a9..958fff945304 100644 --- a/Documentation/hid/uhid.txt +++ b/Documentation/hid/uhid.txt @@

Re: [PATCH 1/8] perf: Allow to block process in syscall tracepoints

2018-12-12 Thread Steven Rostedt
On Thu, 13 Dec 2018 03:39:38 +0300 "Dmitry V. Levin" wrote: > btw, I didn't ask for the implementation to be ugly. > You don't have to introduce polling into the kernel if you don't want to, > userspace is perfectly capable of invoking wait4(2) in a loop. > Just block the tracee, notify the

RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-12 Thread Peter Chen
> > > > Felipe, I use Dynamic Debug for debugging, and show debug messages > > with "dmesg" after testing/debugging. I see dwc3 using trace, any > > benefits for switching to trace? > > The benefits I see are > Thanks, bin. > - *by default*, the debug log doesn't have to go through uart

Re: [PATCH] ARM: dts: omap5: Add l4 interconnect hierarchy and ti-sysc data

2018-12-12 Thread Tony Lindgren
* Tony Lindgren [181212 17:12]: > * Peter Ujfalusi [181212 02:44]: > > On 12/12/2018 12.12, Peter Ujfalusi wrote: > > > Reverting this patch in linux-next-20181210 will make the ethernet > > > working again. > > > > > > bootlog w/ revert: https://pastebin.com/dpRk1xWv > > > bootlog w/o revert:

Re: WARNING: locking bug in lock_downgrade

2018-12-12 Thread Yang Shi
Cc'ed Peter, Ingo and Waiman. It took me a few days to look into this warning, but I got lost in lockdep code. The problem is the commit dd2283f2605e ("mm: mmap: zap pages with read mmap_sem in munmap") does an optimization for munmap by downgrading write mmap_sem to read before zapping

Re: [alsa-devel] [PATCH 0/2] Graph fixes for using multiple endpoints per port

2018-12-12 Thread Tony Lindgren
* Kuninori Morimoto [181213 01:06]: > > Hi Tony > > > > According to OF graph maintainer, he said that > > > counting port / endpoint are not guaranteed, > > > and we need to use "reg". > > > (It is the reason of b6f3fc005a2c8b425d7a0973b43bef05890bf479) > > > > > > If you could double

Re: [PATCH] gpio: aspeed: remove duplicated statement

2018-12-12 Thread Joel Stanley
On Thu, 13 Dec 2018 at 08:24, Tao Ren wrote: > > Remove duplicated assignment statement from aspeed_gpio_probe() function. > > Signed-off-by: Tao Ren Acked-by: Joel Stanley Thanks Tao!

Re: [alsa-devel] [PATCH 0/2] Graph fixes for using multiple endpoints per port

2018-12-12 Thread Kuninori Morimoto
Hi Tony > > According to OF graph maintainer, he said that > > counting port / endpoint are not guaranteed, > > and we need to use "reg". > > (It is the reason of b6f3fc005a2c8b425d7a0973b43bef05890bf479) > > > > If you could double checked, and we could agreed > > that "reg" is the solution

Re: [GIT PULL] seccomp updates for next

2018-12-12 Thread James Morris
On Wed, 12 Dec 2018, Kees Cook wrote: > Hi James, > > Please pull these seccomp changes for next. > Pulled to next-seccomp and next-testing in: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git -- James Morris

Re: [PATCH v4 1/2] ARM: dts: aspeed: Add KCS & lpc ctrl for Facebook

2018-12-12 Thread Joel Stanley
On Thu, 13 Dec 2018 at 07:34, Vijay Khemka wrote: > > Added kcs device and lpc ctrl device to enable LPC clock in Facebook > Tiogapass device tree. As we're going to re-spin, it's a good idea to have the KCS and LPC changes in separate patches. I will take the KCS one straight away, but the LPC

RE: general protection fault in __ip_append_data

2018-12-12 Thread Jon Maloy
> -Original Message- > From: Dmitry Vyukov > Sent: 12-Dec-18 06:03 > To: syzbot+aab62b9c7b12e7c6a...@syzkaller.appspotmail.com; Jon Maloy > ; Ying Xue ; David > Miller ; tipc-discuss...@lists.sourceforge.net > Cc: Alexey Kuznetsov ; LKML ker...@vger.kernel.org>; netdev ; syzkaller-bugs

Re: [PATCH] serial: 8250: Fix clearing FIFOs in RS485 mode again

2018-12-12 Thread Marek Vasut
On 12/13/2018 01:41 AM, Paul Burton wrote: > Hi Marek / Greg / all, > > On Mon, Sep 03, 2018 at 12:44:52AM +, Marek Vasut wrote: >> The 8250 FIFOs indeed need to be cleared after stopping transmission in >> RS485 mode without SER_RS485_RX_DURING_TX flag set. But there are two >> problems with

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-12 Thread Dave Chinner
On Wed, Dec 12, 2018 at 04:59:31PM -0500, Jerome Glisse wrote: > On Thu, Dec 13, 2018 at 08:46:41AM +1100, Dave Chinner wrote: > > On Wed, Dec 12, 2018 at 10:03:20AM -0500, Jerome Glisse wrote: > > > On Mon, Dec 10, 2018 at 11:28:46AM +0100, Jan Kara wrote: > > > > On Fri 07-12-18 21:24:46, Jerome

[driver-core PATCH v9 9/9] driver core: Rewrite test_async_driver_probe to cover serialization and NUMA affinity

2018-12-12 Thread Alexander Duyck
The current async_probe test code is only testing one device allocated prior to driver load and only loading one device afterwards. Instead of doing things this way it makes much more sense to load one device per CPU in order to actually stress the async infrastructure. By doing this we should see

[driver-core PATCH v9 8/9] libnvdimm: Schedule device registration on node local to the device

2018-12-12 Thread Alexander Duyck
Force the device registration for nvdimm devices to be closer to the actual device. This is achieved by using either the NUMA node ID of the region, or of the parent. By doing this we can have everything above the region based on the region, and everything below the region based on the nvdimm bus.

[driver-core PATCH v9 7/9] PM core: Use new async_schedule_dev command

2018-12-12 Thread Alexander Duyck
Use the device specific version of the async_schedule commands to defer various tasks related to power management. By doing this we should see a slight improvement in performance as any device that is sensitive to latency/locality in the setup will now be initializing on the node closest to the

Re: linux-next: Signed-off-by missing for commits in the bpf-next tree

2018-12-12 Thread David Miller
From: Alexei Starovoitov Date: Wed, 12 Dec 2018 15:39:10 -0800 > But this approach doesn't scale. > We do rebase our trees when we need to fixup or drop patches and > at any given point a number of commits will be committed by me > and another set by Daniel. When we rebase we cannot keep adding

[driver-core PATCH v9 3/9] driver core: Probe devices asynchronously instead of the driver

2018-12-12 Thread Alexander Duyck
Probe devices asynchronously instead of the driver. This results in us seeing the same behavior if the device is registered before the driver or after. This way we can avoid serializing the initialization should the driver not be loaded until after the devices have already been added. The

[driver-core PATCH v9 5/9] async: Add support for queueing on specific NUMA node

2018-12-12 Thread Alexander Duyck
Introduce four new variants of the async_schedule_ functions that allow scheduling on a specific NUMA node. The first two functions are async_schedule_near and async_schedule_near_domain end up mapping to async_schedule and async_schedule_domain, but provide NUMA node specific functionality. They

[driver-core PATCH v9 6/9] driver core: Attach devices on CPU local to device node

2018-12-12 Thread Alexander Duyck
Call the asynchronous probe routines on a CPU local to the device node. By doing this we should be able to improve our initialization time significantly as we can avoid having to access the device from a remote node which may introduce higher latency. For example, in the case of initializing

[driver-core PATCH v9 4/9] workqueue: Provide queue_work_node to queue work near a given NUMA node

2018-12-12 Thread Alexander Duyck
Provide a new function, queue_work_node, which is meant to schedule work on a "random" CPU of the requested NUMA node. The main motivation for this is to help assist asynchronous init to better improve boot times for devices that are local to a specific node. For now we just default to the first

[driver-core PATCH v9 1/9] driver core: Establish order of operations for device_add and device_del via bitflag

2018-12-12 Thread Alexander Duyck
Add an additional bit flag to the device struct named "dead". This additional flag provides a guarantee that when a device_del is executed on a given interface an async worker will not attempt to attach the driver following the earlier device_del call. Previously this guarantee was not present

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-12 Thread Jerome Glisse
On Wed, Dec 12, 2018 at 04:18:33PM -0800, Dan Williams wrote: > On Wed, Dec 12, 2018 at 4:01 PM Jerome Glisse wrote: > > > > On Wed, Dec 12, 2018 at 04:37:03PM -0700, Jason Gunthorpe wrote: > > > On Wed, Dec 12, 2018 at 04:53:49PM -0500, Jerome Glisse wrote: > > > > > Almost, we need some safety

[driver-core PATCH v9 2/9] device core: Consolidate locking and unlocking of parent and device

2018-12-12 Thread Alexander Duyck
Try to consolidate all of the locking and unlocking of both the parent and device when attaching or removing a driver from a given device. To do that I first consolidated the lock pattern into two functions __device_driver_lock and __device_driver_unlock. After doing that I then created functions

[driver-core PATCH v9 0/9] Add NUMA aware async_schedule calls

2018-12-12 Thread Alexander Duyck
This patch set provides functionality that will help to improve the locality of the async_schedule calls used to provide deferred initialization. This patch set originally started out focused on just the one call to async_schedule_domain in the nvdimm tree that was being used to defer the

Re: [PATCH] blkcg: handle dying request_queue when associating a blkg

2018-12-12 Thread Jens Axboe
On 12/11/18 4:03 PM, Dennis Zhou wrote: > Between v3 [1] and v4 [2] of the blkg association series, the > association point moved from generic_make_request_checks(), which is > called after the request enters the queue, to bio_set_dev(), which is when > the bio is formed before submit_bio(). When

<    1   2   3   4   5   6   7   8   9   10   >