Re: [PATCHv2 1/3] mm/numa: change the topo of build_zonelist_xx()

2018-12-20 Thread kbuild test robot
Hi Pingfan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc7 next-20181220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH 10/10] driver core: remove BUS_ATTR()

2018-12-20 Thread Greg Kroah-Hartman
There are now no in-kernel users of BUS_ATTR() so drop it from device.h Everyone should use BUS_ATTR_RO/RW/WO() from now on. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- include/linux/device.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/device.h

[PATCH 03/10] SCSI: fcoe: convert to use BUS_ATTR_WO

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe driver can be trivially converted to use BUS_ATTR_WO(), so use that instead. At the same time remove a unneeded EXPORT_SYMBOL() marking for the sysfs callback function we are renaming, no idea of how that got into the

[PATCH 05/10] rapidio: rio-sysfs.c: convert to use BUS_ATTR_WO

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in rio-sysfs.c can be trivially converted to use BUS_ATTR_WO(), so use that instead. Cc: Matt Porter Cc: Alexandre Bounine Signed-off-by: Greg Kroah-Hartman --- drivers/rapidio/rio-sysfs.c | 5 ++--- 1 file changed, 2 insertions(+),

[PATCH 04/10] pseries: ibmebus.c: convert to use BUS_ATTR_WO

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in ibmebus.c can be trivially converted to use BUS_ATTR_WO(), so use that instead. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Tyrel Datwyler Signed-off-by: Greg Kroah-Hartman ---

[PATCH 06/10] block: rbd: convert to use BUS_ATTR_WO and RO

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in rbd.c can be trivially converted to use BUS_ATTR_WO and RO, so use those macros instead. Cc: Ilya Dryomov Cc: Sage Weil Cc: Alex Elder Cc: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/block/rbd.c | 45

[PATCH 00/10] Driver core: remove BUS_ATTR()

2018-12-20 Thread Greg Kroah-Hartman
In the quest to get rid of the need to specify any sysfs mode attributes, let's get rid of BUS_ATTR() and move the few remaining users of it over to use the "read write" and "write only" versions of the macro. Greg Kroah-Hartman (10): PCI: pci.c: convert to use BUS_ATTR_RW PCI: pci-sysfs.c:

[PATCH 07/10] driver core: bus: convert to use BUS_ATTR_WO and RW

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in bus.c can be trivially converted to use BUS_ATTR_WO and RW, so use those macros instead. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- drivers/base/bus.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH 02/10] PCI: pci-sysfs.c: convert to use BUS_ATTR_WO

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in pci-sysfs.c can be trivially converted to use BUS_ATTR_WO(), so use that instead. Cc: Bjorn Helgaas Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pci-sysfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH 09/10] driver core: drop use of BUS_ATTR()

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() so drop the last user of it from the tree. We had to "open code" it in order to prevent a function name conflict due to the use of DEVICE_ATTR_WO() earlier in the file :( Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- drivers/base/bus.c |

[PATCH 01/10] PCI: pci.c: convert to use BUS_ATTR_RW

2018-12-20 Thread Greg Kroah-Hartman
We are trying to get rid of BUS_ATTR() and the usage of that in pci.c can be trivially converted to use BUS_ATTR_RW(), so use that instead. Cc: Bjorn Helgaas Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 08/10] Documentation: driver core: remove use of BUS_ATTR

2018-12-20 Thread Greg Kroah-Hartman
We are getting rid of the "raw" BUS_ATTR() macro, so fix up the documentation to not refer to it anymore. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- Documentation/driver-model/bus.txt | 8 Documentation/filesystems/sysfs.txt | 4 +++- 2 files changed, 7

Re: [PATCH 4.14 00/72] 4.14.90-stable review

2018-12-20 Thread Jinpu Wang
> From: Greg Kroah-Hartman > Date: 2018年12月20日周四 上午10:39 > Subject: [PATCH 4.14 00/72] 4.14.90-stable review > To: > Cc: Greg Kroah-Hartman , > , , > , , , > , , > > > > This is the start of the stable review cycle for the 4.14.90 release. > There are 72 patches in this series, all will be

Re: [PATCH V4 2/4] mmc: cqhci: DMA Configuration prior to CQE

2018-12-20 Thread Adrian Hunter
On 20/12/18 11:01 PM, Sowjanya Komatineni wrote: > Hi Adrian, > > Thank you for the feedback. > >> This doesn't seem to relate to the host controller implementation. >> "The device" means the eMMC. > > Yes, setting block size of 512B before enabling command queue is a device > specific >

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2018-12-20 Thread Jorge Ramirez
On 12/20/18 18:07, Rob Herring wrote: On Thu, Dec 20, 2018 at 10:52:45AM +0100, Jorge Ramirez-Ortiz wrote: On 07/12/18 10:55:57, Jorge Ramirez-Ortiz wrote: Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY controller embedded in QCS404. Based on Sriharsha Allenki's original

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2018-12-20 Thread Jorge Ramirez
On 12/20/18 18:37, Jack Pham wrote: Hi Rob, Jorge, On Thu, Dec 20, 2018 at 11:05:31AM -0600, Rob Herring wrote: On Fri, Dec 07, 2018 at 10:55:57AM +0100, Jorge Ramirez-Ortiz wrote: Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY controller embedded in QCS404. Based on

Re: [PATCH] mfd: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-20 Thread Lee Jones
On Fri, 21 Dec 2018, Frank Lee wrote: > ping.. I've told you about this before: " Please don't do that. If you think your patch has been missed, then please send it again as a [RESEND]. In this case you will need to fix the $SUBJECT line too. To see what it should look like do the

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2018-12-20 Thread Jorge Ramirez
On 12/20/18 21:25, Stephen Boyd wrote: Quoting Jorge Ramirez-Ortiz (2018-12-07 01:55:57) + +- qcom,vdd-voltage-level: +Value type: +Definition: This is a list of three integer values where +each value corresponding to voltage corner in uV. As far as I'm aware, this

RE: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-12-20 Thread Naga Sureshkumar Relli
Hi Miquel, > -Original Message- > From: Miquel Raynal [mailto:miquel.ray...@bootlin.com] > Sent: Wednesday, December 19, 2018 7:57 PM > To: Naga Sureshkumar Relli > Cc: Boris Brezillon ; r...@kernel.org; > rich...@nod.at; > linux-kernel@vger.kernel.org; marek.va...@gmail.com; >

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2018-12-20 Thread Jacek Anaszewski
On 12/20/18 9:31 PM, Jacek Anaszewski wrote: On 12/19/18 10:50 PM, Dan Murphy wrote: On 12/19/2018 03:36 PM, Jacek Anaszewski wrote: Hi Dan and Pavel, On 12/19/18 9:41 PM, Dan Murphy wrote: Pavel On 12/19/2018 02:10 PM, Pavel Machek wrote: On Wed 2018-12-19 13:41:18, Dan Murphy wrote:

Re: [RFC][PATCH] printk: increase devkmsg write() ratelimit

2018-12-20 Thread Sergey Senozhatsky
On (12/20/18 08:58), Steven Rostedt wrote: > > > Userspace processes should never be able to overwrite messages > > > from the kernel. > > > > I would agree. > > > > It's a bit funny that kernel people first take the patch in and then, > > when user-space begins to use the feature, start to

Re: [PATCHv2] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr

2018-12-20 Thread Baoquan He
On 12/21/18 at 03:18pm, Baoquan He wrote: > On 12/14/18 at 12:07pm, Pingfan Liu wrote: > > Customer reported a bug on a high end server with many pcie devices, where > > kernel bootup with crashkernel=384M, and kaslr is enabled. Even > > though we still see much memory under 896 MB, the finding

[PATCH 05/21] PCI: imx6: Remove PCIE_PL_PFLR_* constants

2018-12-20 Thread Andrey Smirnov
Code using these constants was removed in commit a71280722eeb ("PCI: imx6: Remove LTSSM disable workaround"). No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 02/21] PCI: imx6: Remove redundant debug tracing

2018-12-20 Thread Andrey Smirnov
All calls to imx6_pcie_wait_for_link() share the same error path and the state of PHY debug registers will already be printed there. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 03/21] PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change()

2018-12-20 Thread Andrey Smirnov
Change error code from EINVAL to ETIMEDOUT in imx6_pcie_wait_for_speed_change() since that error code seems more appropriate. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com

[PATCH 06/21] PCI: imx6: Remove PCIE_PHY_RX_ASIC_OUT* constants

2018-12-20 Thread Andrey Smirnov
Code using these constants was removed in commit a77c5422d758 ("PCI: imx6: Remove broken Gen2 workaround"). No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 07/21] PCI: designware: Make use of IS_ALIGNED()

2018-12-20 Thread Andrey Smirnov
Make the intent a bit more clear as well as get rid of explicit arithmetic by using IS_ALIGNED() to determine if "addr" is aligned to "size". No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc:

Re: [PATCH] MAINTAINERS: update Android binder

2018-12-20 Thread Christian Brauner
On December 20, 2018 1:13:26 PM GMT+01:00, Martijn Coenen wrote: >Thanks Christian for signing up! > >On Thu, Dec 20, 2018 at 12:09 PM Greg KH >wrote: >> Ok, no objection from me, Todd/Martijn/Joel/Arve, can I get an ack >from >> someone? > >Acked-By: Martijn Coenen Thanks Martijn! Happy

[PATCH] percpu_rwsem: fix missed wakeup due to reordering of load

2018-12-20 Thread Prateek Sood
P1 is releaseing the cpu_hotplug_lock and P2 is acquiring cpu_hotplug_lock. P1 P2 percpu_up_read() path percpu_down_write() path rcu_sync_enter() //gp_state=GP_PASSED rcu_sync_is_idle()

[PATCH 11/21] PCI: designware: Make use of BIT() in constant definitions

2018-12-20 Thread Andrey Smirnov
Avoid using explicit left shifts and convert various definitions to use BIT() instead. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc:

[PATCH 10/21] PCI: designware: imx6: Share PHY debug register definitions

2018-12-20 Thread Andrey Smirnov
Both pcie-designware.c and pci-imx6.c contain custom definitions for PHY debug registers R0/R1 and on top of that there's already a definition for R0 in pcie-designware.h. Move all of the definitions to pcie-designware.h. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas

[PATCH 09/21] PCI: imx6: Drop imx6_pcie_link_up()

2018-12-20 Thread Andrey Smirnov
Until commit 4d107d3b5a68 ("PCI: imx6: Move link up check into imx6_pcie_wait_for_link()") the driver relied on both LINK_UP and LINK_IN_TRAINING to determine if PCIE link was up. I can't seem to find out why, but code using LINK_IN_TRAINING seem to disappear after commit 886bc5ceb5cc ("PCI:

[PATCH 13/21] PCI: imx6: Simplify bit operations in PHY functions

2018-12-20 Thread Andrey Smirnov
Simplify the code by incorporating left shifts into constant defnitions as well as using FIELD_PREP/GENMASK. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 14/21] PCI: imx6: Simplify pcie_phy_poll_ack()

2018-12-20 Thread Andrey Smirnov
Simplify pcie_phy_poll_ack() by incorporating shifting into constant definition and convert the code to use 'bool'. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu

[PATCH 2/5] ihex: Check if zero-length record is at the end of the blob

2018-12-20 Thread Andrey Smirnov
When verifying the validity of IHEX file we need to make sure that zero-length record we found is located at the end of the file. Not doing that could result in an invalid file with a bogus zero-length in the middle short-circuiting the check and being reported as valid. Cc: Chris Healy Cc: Kyle

[PATCH 4/5] tools/firmware/ihex2fw: Simplify next record offset calculation

2018-12-20 Thread Andrey Smirnov
We can convert original expression for 'writelen" to use ALIGN as follows: (p->len + 9) & ~3 => (p->len + 6 + 3) & ~3 => ALIGN(p->len + 6, 4) Now, subsituting "p->len + 6" with "p->len + sizeof(p->addr) + sizeof(p->len)" we end up with the same expression as used by kernel couterpart in

[PATCH 20/21] PCI: designware: Make use of GENMASK/FIELD_PREP

2018-12-20 Thread Andrey Smirnov
Convert various mult-bit fields to be defined using GENMASK/FIELD_PREP. This way bit field boundaries are defined in a single place only as well as defined in a way that makes it easier to verify them against reference manual. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn

[PATCH 1/5] ihex: Share code between ihex_validate_fw() and ihex_next_binrec()

2018-12-20 Thread Andrey Smirnov
Convert both ihex_validate_fw() and ihex_next_binrec() to use a helper function to calculate next record offest. This way we only have one place implementing next record offset calculation logic. No functional change intended. Cc: Chris Healy Cc: Kyle McMartin Cc: Andrew Morton Cc: Masahiro

[PATCH 5/5] tools/firmware/ihex2fw: Replace explicit alignment with ALIGN

2018-12-20 Thread Andrey Smirnov
(X + 3) & ~3 is the same as ALIGN(X, 4), so replace all of the instances of the formwer in the code with the latter. While at it, introduce a helper variable 'record_size' to avoid duplicating length calculatin code. No functional change intended. Cc: Chris Healy Cc: Kyle McMartin Cc: Andrew

[PATCH 3/5] ihex: Simplify next record offset calculation

2018-12-20 Thread Andrey Smirnov
Next record calucaltion can be reduced to a much more tivial ALIGN operation as follows: 1. Splitting 5 into 2 + 3 we get next = ((be16_to_cpu(rec->len) + 2 + 3) & ~3) - 2(1) 2. Using ALIGN macro we reduce (1) to: ALIGN(be16_to_cpu(rec->len) + 2, 4) - 2

[PATCH 17/21] PCI: imx6: Use common mask in imx6_pcie_reset_phy()

2018-12-20 Thread Andrey Smirnov
Simplify imx6_pcie_reset_phy() by using common mask. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc: linux-arm-ker...@lists.infradead.org

[PATCH 0/5] IHEX bug fix and some improvements

2018-12-20 Thread Andrey Smirnov
Everyone: This series is a big-fix to a problem I encountered while using code in bundled with a number of small improvmements. The bug fix is in commit: [PATCH 2/5] ihex: Check if zero-length record is at the end of the Small improvmentes are in the rest and all of them are purely optional.

[PATCH 16/21] PCI: imx6: Pass data to dw_pcie_writel_dbi() directly

2018-12-20 Thread Andrey Smirnov
Save a couple of lines of code by dropping assignement to 'var' and passing constants as via function arguments directly. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard

[PATCH 12/21] PCI: imx6: Make use of BIT() in constant definitions

2018-12-20 Thread Andrey Smirnov
Avoid using explicit left shifts and convert various definitions to use BIT() instead. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc:

[PATCH 21/21] PCI: designware: Remove superfluous shifting in definitions

2018-12-20 Thread Andrey Smirnov
Surrounding definitions no longer use explicit shift, so "<< 0" here serve no purpose. Remove them. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 18/21] PCI: imx6: Simplify bit operations in imx6_setup_phy_mpll()

2018-12-20 Thread Andrey Smirnov
Simplify bit operations in imx6_setup_phy_mpll() by using GENMASK/FIELD_PREP. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc:

[PATCH 15/21] PCI: imx6: Restrict PHY register data to 16-bit

2018-12-20 Thread Andrey Smirnov
PHY registers on i.MX6 are 16-bit wide, so we can get rid of explicit masking if we restrict pcie_phy_read/pcie_phy_write to use 'u16' instead of 'int'. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard

[PATCH 04/21] PCI: imx6: Remove duplicate macro definitions

2018-12-20 Thread Andrey Smirnov
Both PCIE_LINK_WIDTH_SPEED_CONTROL and PORT_LOGIC_SPEED_CHANGE are already defined in pcie-desingware.h, so drop duplicate definintion in pci-imx6.c. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez

[PATCH 19/21] PCI: imx6: Remove magic numbers from imx6_pcie_establish_link()

2018-12-20 Thread Andrey Smirnov
Explicitly define PCIE_RC_LCSR_LINK_SPEED and remove magic numbers from imx6_pcie_establish_link(). No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc:

[PATCH 01/21] PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock()

2018-12-20 Thread Andrey Smirnov
Make use of regmap_read_poll_timeout() to simplify imx7d_pcie_wait_for_phy_pll_lock(). No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-...@nxp.com Cc:

[PATCH 08/21] PCI: designware: Share code for dw_pcie_rd/wr_other_conf()

2018-12-20 Thread Andrey Smirnov
Default implementation of pcie_rd_other_conf() and dw_pcie_wd_other_conf() share more than 80% of their code. Move shared code into a dedicated subroutine and convert pcie_rd_other_conf() and dw_pcie_wd_other_conf() to use it. No functional change intended. Cc: Lorenzo Pieralisi Cc: Bjorn

[PATCH 00/21] i.MX6, DesignWare PCI improvements

2018-12-20 Thread Andrey Smirnov
Everyone: This is the series containing various small improvements that I made while reading the code and researching commit history of pci-imx6.c and pcie-designware*.c files. All changes are optional, so commits that don't seem like an improvement can be easily dropped. Hopefully each patch is

[PATCH] lm80: fix a missing check of return value

2018-12-20 Thread Kangjie Lu
When lm80_read_value() fails, the read data is an error number. So let's check its status before using the read data. Signed-off-by: Kangjie Lu --- drivers/hwmon/lm80.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/lm80.c b/drivers/hwmon/lm80.c

Re: [PATCH] mfd: cros_ec: Add support for MKBP more event flags

2018-12-20 Thread Lee Jones
On Thu, 20 Dec 2018, egran...@google.com wrote: > From: Enrico Granata > > The ChromeOS EC has support for signaling to the host that > a single IRQ can serve multiple MKBP events. > > Doing this serves an optimization purpose, as it minimizes the > number of round-trips into the interrupt

Re: Clang build error in drivers/scsi/smartpqi/smartpqi_init.c

2018-12-20 Thread Nathan Chancellor
On Fri, Dec 21, 2018 at 12:11:00AM -0700, Nathan Chancellor wrote: > Hi all, > > After commit 4fd22c13ad44 ("scsi: smartpqi: add ofa support"), an arm > allyesconfig build with Clang fails with the following warning/error: > > drivers/scsi/smartpqi/smartpqi_init.c:7473:2: warning: comparison of

Re: [PATCHv2] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr

2018-12-20 Thread Baoquan He
On 12/14/18 at 12:07pm, Pingfan Liu wrote: > Customer reported a bug on a high end server with many pcie devices, where > kernel bootup with crashkernel=384M, and kaslr is enabled. Even > though we still see much memory under 896 MB, the finding still failed > intermittently. Because currently we

Re: [PATCH v10 17/27] drivers: firmware: psci: Prepare to support PM domains

2018-12-20 Thread Daniel Lezcano
On 20/12/2018 22:37, Ulf Hansson wrote: > On Thu, 20 Dec 2018 at 19:06, Daniel Lezcano > wrote: >> >> On 20/12/2018 16:49, Ulf Hansson wrote: >> >> [ ... ] >> > +#ifdef CONFIG_CPU_IDLE It would be nicer if you can remove the CONFIG_CPU_IDLE by replacing it with a specific one

Clang build error in drivers/scsi/smartpqi/smartpqi_init.c

2018-12-20 Thread Nathan Chancellor
Hi all, After commit 4fd22c13ad44 ("scsi: smartpqi: add ofa support"), an arm allyesconfig build with Clang fails with the following warning/error: drivers/scsi/smartpqi/smartpqi_init.c:7473:2: warning: comparison of distinct pointer types ('typeof ((sg_count)) *' (aka 'unsigned int *') and

Re: [PATCH 4.19 00/67] 4.19.12-stable review

2018-12-20 Thread Greg Kroah-Hartman
On Thu, Dec 20, 2018 at 08:33:23PM +0530, Naresh Kamboju wrote: > On Thu, 20 Dec 2018 at 14:59, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 4.19.12 release. > > There are 67 patches in this series, all will be posted as a response > > to this one. If

Re: [PATCH 4.19 00/67] 4.19.12-stable review

2018-12-20 Thread Greg Kroah-Hartman
On Thu, Dec 20, 2018 at 10:29:59AM -0800, Guenter Roeck wrote: > On Thu, Dec 20, 2018 at 10:18:12AM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.12 release. > > There are 67 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 4.19 00/67] 4.19.12-stable review

2018-12-20 Thread Greg Kroah-Hartman
On Thu, Dec 20, 2018 at 03:48:09PM -0700, shuah wrote: > On 12/20/18 2:18 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.12 release. > > There are 67 patches in this series, all will be posted as a response > > to this one. If anyone has any issues

[PATCH] media: mt312: fix a missing check of mt312 reset

2018-12-20 Thread Kangjie Lu
mt312_reset() may fail. Although it is called in the end of mt312_set_frontend(), we better check its status and return its error code upstream instead of 0. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/mt312.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [GIT PULL] asm-generic: syscall table script for arch/sh

2018-12-20 Thread Christoph Hellwig
> The conversion does not include the old 64-bit sh5 architecture, which > has never shipped and not even compiled in a long time. Maybe it is time to drop the code for it then?

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-20 Thread Christoph Hellwig
On Thu, Dec 20, 2018 at 05:01:58PM -0500, Theodore Y. Ts'o wrote: > That's simply not true. Number one, fsverity is not mandatory for all > file systems to implement. If XFS doesn't want to implement fscrypt > or fsverity, it doesn't have to. Number two, we're not *making* any > changes to the

[PATCH] touchscreen: elants: fix a missing check of return values

2018-12-20 Thread Kangjie Lu
elants_i2c_send() may fail, let's check its return values. The fix does the check and reports an error message upon the failure. Signed-off-by: Kangjie Lu --- drivers/input/touchscreen/elants_i2c.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 6/7] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers

2018-12-20 Thread Michal Simek
On 21. 12. 18 3:37, Manivannan Sadhasivam wrote: > On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote: >> For all 96Boards, the following standard is used for onboard LEDs. >> >> green:user1 default-trigger: heartbeat >> green:user2 default-trigger:

Re: [RFC PATCH v2 04/11] powerpc/mm: Add a framework for Kernel Userspace Access Protection

2018-12-20 Thread Christophe Leroy
Le 21/12/2018 à 06:07, Michael Ellerman a écrit : Christophe Leroy writes: This patch implements a framework for Kernel Userspace Access Protection. Then subarches will have to possibility to provide their own implementation by providing setup_kuap() and lock/unlock_user_access() Some

[PATCH] netfilter: fix a missing check of nla put failure

2018-12-20 Thread Kangjie Lu
If nla_nest_start() may fail. The fix checks its return value and goes to nla_put_failure if it fails. Signed-off-by: Kangjie Lu --- net/netfilter/nf_tables_api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Christian Borntraeger
On 20.12.2018 18:23, Willem de Bruijn wrote: > On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote: >> >> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: >>> On 20.12.2018 10:12, Ido Schimmel wrote: +Willem On Thu, Dec 20, 2018 at 08:45:40AM +0100,

Re: [PATCH] percpu_rwsem: fix missed wakeup due to reordering of load

2018-12-20 Thread Prateek Sood
On 12/12/2018 08:58 PM, Andrea Parri wrote: > On Fri, Nov 30, 2018 at 08:40:56PM +0530, Prateek Sood wrote: >> In a scenario where cpu_hotplug_lock percpu_rw_semaphore is already >> acquired for read operation by P1 using percpu_down_read(). >> >> Now we have P1 in the path of releaseing the

Re: [PATCH 1/2] mm: vmscan: skip KSM page in direct reclaim if priority is low

2018-12-20 Thread Yang Shi
On 12/20/18 10:04 PM, Hugh Dickins wrote: On Thu, 20 Dec 2018, Andrew Morton wrote: Is anyone interested in reviewing this? Seems somewhat serious. Thanks. Somewhat serious, but no need to rush. From: Yang Shi Subject: mm: vmscan: skip KSM page in direct reclaim if priority is low When

[PATCH] regulator: tps65910: fix a missing check of return value

2018-12-20 Thread Kangjie Lu
tps65910_reg_set_bits() may fail. The fix checks if it fails, and if so, returns with its error code. Signed-off-by: Kangjie Lu --- drivers/regulator/tps65910-regulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/tps65910-regulator.c

[v1] arm64: dts: sdm845: add interconnect DT entries for MDSS on SDM845

2018-12-20 Thread Jayant Shekhar
Add interconnect properties such as the source and the destination ports for MDSS on SDM845. Signed-off-by: Jayant Shekhar --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

[PATCH v3] mm, page_alloc: Fix has_unmovable_pages for HugePages

2018-12-20 Thread Oscar Salvador
v3 -> v2: Get rid of the round_up() v2 -> v1: Adjust skip pages logic per Michal >From 8c057ff497a078f28e293af8c0bd089893a57753 Mon Sep 17 00:00:00 2001 From: Oscar Salvador Date: Wed, 19 Dec 2018 00:04:18 + Subject: [PATCH] mm, page_alloc: fix has_unmovable_pages for HugePages While

[PATCH] net: netxen: fix a missing check and an uninitialized use

2018-12-20 Thread Kangjie Lu
When netxen_rom_fast_read() fails, "bios" is left uninitialized and may contain random value, thus should not be used. The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO". Signed-off-by: Kangjie Lu --- drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 3 ++- 1 file

[PATCH] kconfig: remove unused "file" field of yylval union

2018-12-20 Thread Masahiro Yamada
This has never been used. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y index 8a4d029..60ee8e7 100644 --- a/scripts/kconfig/zconf.y +++ b/scripts/kconfig/zconf.y @@ -36,7 +36,6 @@

Re: [PATCHv2 2/3] mm/numa: build zonelist when alloc for device on offline node

2018-12-20 Thread Pingfan Liu
On Thu, Dec 20, 2018 at 8:44 PM Michal Hocko wrote: > > On Thu 20-12-18 20:26:28, Pingfan Liu wrote: > > On Thu, Dec 20, 2018 at 7:35 PM Michal Hocko wrote: > > > > > > On Thu 20-12-18 17:50:38, Pingfan Liu wrote: > > > [...] > > > > @@ -453,7 +456,12 @@ static inline int gfp_zonelist(gfp_t

drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:2547: undefined reference to `vxlan_fdb_find_uc'

2018-12-20 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9097a058d49e049925d8da72db07fffcee24efa0 commit: 1231e04f5bba47f87d0b690a2d58c771a59f93aa mlxsw: spectrum_switchdev: Add support for VxLAN encapsulation date: 9 weeks ago config:

[PATCH] hwmon: lm80: fix a missing check of return value

2018-12-20 Thread Kangjie Lu
If lm80_read_value() fails, it returns a negative number instead of the correct read data. Therefore, we should avoid using the data if it fails. The fix checks if lm80_read_value() fails, and if so, returns with the error number. Signed-off-by: Kangjie Lu --- drivers/hwmon/lm80.c | 15

Re: [PATCH 1/2] mm: vmscan: skip KSM page in direct reclaim if priority is low

2018-12-20 Thread Hugh Dickins
On Thu, 20 Dec 2018, Andrew Morton wrote: > > Is anyone interested in reviewing this? Seems somewhat serious. > Thanks. Somewhat serious, but no need to rush. > > From: Yang Shi > Subject: mm: vmscan: skip KSM page in direct reclaim if priority is low > > When running a stress test, we

Re: [PATCH] cifs: check kzalloc return

2018-12-20 Thread Steve French
Updated the patch with Joe's signed off and Nicholas's reviewed-by and pushed to cifs-2.6.git for-next See attached. On Wed, Dec 19, 2018 at 4:58 AM Joe Perches via samba-technical wrote: > > On Wed, 2018-12-19 at 08:22 +0100, Nicholas Mc Guire wrote: > > On Tue, Dec 18, 2018 at 09:33:58AM

linux-next: manual merge of the kvm tree with the powerpc tree

2018-12-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/powerpc/mm/fault.c between commit: 49a502ea23bf ("powerpc/mm: Make NULL pointer deferences explicit on bad page faults.") from the powerpc tree and commit: d7b456152230 ("KVM: PPC: Book3S HV: Implement functions

Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding

2018-12-20 Thread Baruch Siach
Hi Marek, Marek Behun writes: >> > +- compatible :must be "marvell,armada-37xx-rwtm-mailbox" >> >> Don't use wildcards in compatible strings. > > You mean that "mailbox" shouldn't be there? You should use '3700' instead of '37xx'. baruch -- http://baruch.siach.name/blog/

Re: [RFC PATCH v2 04/11] powerpc/mm: Add a framework for Kernel Userspace Access Protection

2018-12-20 Thread Michael Ellerman
Christophe Leroy writes: > This patch implements a framework for Kernel Userspace Access > Protection. > > Then subarches will have to possibility to provide their own > implementation by providing setup_kuap() and lock/unlock_user_access() > > Some platform will need to know the area accessed

Re: [PATCH] gpu: anx7808: fix a missing check of return value

2018-12-20 Thread Laurent Pinchart
Hi Kangjie, Thank you for the patch. On Thursday, 20 December 2018 09:41:16 EET Kangjie Lu wrote: > Both anx78xx_set_bits() and anx78xx_clear_bits() in the poweron process > may fail. The fix inserts checks for their return values. If the poweron > process fails, it calls anx78xx_poweroff(). >

[PATCH v2] media: si2165: fix a missing check of return value

2018-12-20 Thread Kangjie Lu
si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find that "val_tmp" will be an uninitialized value when regmap_read() fails. "val_tmp" is then assigned to "val". So if si2165_readreg8() fails, "val" will be a random value. Further use will lead to undefined behaviors. The fix

Re: [PATCH v4 13/18] memory: mtk-smi: Add bus_sel for mt8183

2018-12-20 Thread Nicolas Boichat
On Sat, Dec 8, 2018 at 4:43 PM Yong Wu wrote: > > There are 2 mmu cells in a M4U HW. we could adjust some larbs entering > mmu0 or mmu1 to balance the bandwidth via the smi-common register > SMI_BUS_SEL(0x220)(Each larb occupy 2 bits). > > In mt8183, For better performance, we switch larb1/2/5/7

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-20 Thread Nicolas Boichat
On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > the ARM Short-descriptor like mt8173, and most of the HW registers > are the same. > > Here list main differences between mt8183 and mt8173/mt2712: > 1) mt8183 has only one M4U

[ANNOUNCE] 4.9.146-rt125

2018-12-20 Thread Julia Cartwright
Hello RT Folks! I'm pleased to announce the 4.9.146-rt125 stable release. Apologies for an update to the 4.9-rt tree being way overdue. This release is just an update to the new stable 4.9.146 version and no RT specific changes have been made. You can get this release via the git tree at:

[v6] PCI: imx: make msi work without CONFIG_PCIEPORTBUS=y

2018-12-20 Thread Richard Zhu
The MSI Enable bit in the MSI Capability (PCIe r4.0, sec 7.7.1.2) controls whether a Function can request service using MSI. i.MX6 Root Ports implement the MSI Capability and may use MSI to request service for events like PME, hotplug, AER, etc. In addition, on i.MX6, the MSI Enable bit controls

RE: [PATCH 1/2] Documentation: can: flexcan: add PE clock source property to device tree

2018-12-20 Thread Joakim Zhang
> -Original Message- > From: Rob Herring > Sent: 2018年12月21日 4:23 > To: Joakim Zhang > Cc: m...@pengutronix.de; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; Aisheng Dong > Subject: Re: [PATCH 1/2] Documentation: can: flexcan:

Re: [PATCH] serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250

2018-12-20 Thread Florian Fainelli
;>> defined where it was not previously. Example mpc85xx_defconfig. This in >>> turn results in boot failures for those configurations, with an error >>> message of >>> >>> of_serial: probe of e0004500.serial failed with error -22 >>> >>>

[PATCH] Revert "serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250"

2018-12-20 Thread Florian Fainelli
This reverts commit 6d11023c345e369bcb9d5a68b271764e362c1f6e ("serial: 8250: Default SERIAL_OF_PLATFORM to SERIAL_8250") since that breaks at least mpc8544ds (PowerPC) using arch/powerpc/kernel/legacy_serial.c. See https://lkml.org/lkml/2018/12/5/1491 for discussion and analysis Fixes:

Re: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE

2018-12-20 Thread Tomasz Figa
On Thu, Dec 20, 2018 at 7:47 PM Daniel Vetter wrote: > > On Thu, Dec 20, 2018 at 10:07 AM Tomasz Figa wrote: > > > > Hi Helen, > > > > On Fri, Dec 14, 2018 at 10:35 AM Helen Koike > > wrote: > > > > > > Hi Tomasz, > > > > > > On 12/13/18 2:02 AM, Tomasz Figa wrote: > > > > On Thu, Dec 6, 2018

[PATCH v3 0/2] perf tests: Check for ARM [vectors] page

2018-12-20 Thread Florian Fainelli
Hi all, I just painfully learned that perf would segfault when CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of it. This patch series adds an ARM test for that by leveraging the existing find_vdso_map() function and making it more generic and capable of location any map

[PATCH v3 1/2] perf tools: Make find_vdso_map() more modular

2018-12-20 Thread Florian Fainelli
In preparation for checking that the vectors page on the ARM architecture, refactor the find_vdso_map() function to accept finding an arbitrary string and create a dedicated helper function for that under util/find-map.c and update the filename to find-map.c and all references to it:

[PATCH v3 2/2] perf tests: Add a test for the ARM 32-bit [vectors] page

2018-12-20 Thread Florian Fainelli
perf on ARM requires CONFIG_KUSER_HELPERS to be turned on to allow some independance with respect to the ARM CPU being used. Add a test which tries to locate the [vectors] page, created when CONFIG_KUSER_HELPERS is turned on to help asses the system's health. Signed-off-by: Florian Fainelli ---

[PATCH] panel-innolux: set display off in innolux_panel_unprepare

2018-12-20 Thread Hsin-Yi, Wang
Move mipi_dsi_dcs_set_display_off() from innolux_panel_disable() to innolux_panel_unprepare(), so they are consistent with innolux_panel_enable() and innolux_panel_prepare(). This also fixes some mode check and irq timeout issue in MTK dsi code. Since some dsi code (e.g. mtk_dsi) have following

Re: [PATCH v4 08/18] iommu/mediatek: Add larb-id remapped support

2018-12-20 Thread Nicolas Boichat
On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > The larb-id may be remapped in the smi-common, this means the > larb-id reported in the mtk_iommu_isr isn't the real larb-id, > > Take mt8183 as a example: >M4U > | >

RE: [PATCH 1/2] Documentation: can: flexcan: add PE clock source property to device tree

2018-12-20 Thread Aisheng Dong
> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Friday, December 21, 2018 4:23 AM > > On Thu, Dec 13, 2018 at 07:07:57AM +, Joakim Zhang wrote: > > From: Dong Aisheng > > > > The FlexCAN controller can parse clock source property from DTS file > > to select

  1   2   3   4   5   6   7   8   9   10   >