Re: [PATCH v2 2/2] drm/amd: validate user GEM object size

2018-12-22 Thread kbuild test robot
/linux/commits/Yu-Zhao/drm-amd-validate-user-pitch-alignment/20181222-153630 config: i386-randconfig-h1-12231406 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed

[PATCH] scsi: sd: Fix cache_type_store()

2018-12-22 Thread Ivan Mironov
Changing of caching mode via /sys/devices/.../scsi_disk/.../cache_type may fail if device responses to MODE SENSE command with DPOFUA flag set, and then checks this flag to be not set on MODE SELECT command. When trying to change cache_type, write always fails: # echo "none" >cache_type

Re: general protection fault in put_pid

2018-12-22 Thread Dmitry Vyukov
On Sat, Dec 22, 2018 at 8:07 PM Manfred Spraul wrote: > > Hi Dmitry, > > On 12/20/18 4:36 PM, Dmitry Vyukov wrote: > > On Wed, Dec 19, 2018 at 10:04 AM Manfred Spraul > > wrote: > >> Hello Dmitry, > >> > >> On 12/12/18 11:55 AM, Dmitry Vyukov wrote: > >>> On Tue, Dec 11, 2018 at 9:23 PM syzbot >

Re: [PATCH] sock: Make sock->sk_tstamp thread-safe

2018-12-22 Thread Eric Dumazet
On 12/21/2018 12:27 PM, Deepa Dinamani wrote: > Al Viro mentioned that there is probably a race condition > lurking in accesses of sk_tstamp on 32-bit machines. > > sock->sk_tstamp is of type ktime_t which is always an s64. > On a 32 bit architecture, we might run into situations of > unsafe

WARNING: ODEBUG bug in tipc_enable_bearer

2018-12-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ce28bb445388 Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=10eddf9740 kernel config: https://syzkaller.appspot.com/x/.config?x=67a2081147a23142

KASAN: slab-out-of-bounds Write in fpstate_init

2018-12-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6648e120dd1a Add linux-next specific files for 20181217 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=16fddf9740 kernel config: https://syzkaller.appspot.com/x/.config?x=9e2825c86a37329f

[PATCH] pinctrl: freescale: Break dependency on SOC_IMX8MQ for i.MX8MQ

2018-12-22 Thread Abel Vesa
The CONFIG_SOC_IMX8MQ will go away, so the dependency can be based on ARCH_MXC && ARM64. Signed-off-by: Abel Vesa --- drivers/pinctrl/freescale/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig

Re: [PATCH] net/mlx5e: fix semicolon.cocci warnings

2018-12-22 Thread Leon Romanovsky
On Sat, Dec 22, 2018 at 08:02:16PM +0800, kbuild test robot wrote: > From: kbuild test robot > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1339:57-58: Unneeded > semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Fixes: 4c8fb2986d44

[PATCH] phy: freescale: Break dependency on SOC_IMX8MQ for USB PHY

2018-12-22 Thread Abel Vesa
Since this is going to be used on more SoCs than just i.MX8MQ, make the dependency here more generic. Signed-off-by: Abel Vesa --- drivers/phy/freescale/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/freescale/Kconfig b/drivers/phy/freescale/Kconfig

[PATCH] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

2018-12-22 Thread Abel Vesa
Since this is going to be used on more SoCs than just i.MX8MQ, make the dependency here more generic. Signed-off-by: Abel Vesa --- drivers/soc/imx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index 2112d18..7ffbb6b

[BUG]Uncalibrated TSC is not accurate enough as a time keeper

2018-12-22 Thread Da Shi Cao
The cpu_khz and tsc_khz are now read directly by the cpuid instruction, and they are deemed to be very accurate. But this is not the case in our situation. The OS time lags behind about 8 seconds per hour. The CPU information is as follows: processor : 0 vendor_id : GenuineIntel cpu

[PATCH V8] iio: light: isl29018: add vcc regulator operation support

2018-12-22 Thread Anson Huang
The light sensor's power supply could be controllable by regulator on some platforms, such as i.MX6Q-SABRESD board, the light sensor isl29023's power supply is controlled by a GPIO fixed regulator, need to make sure the regulator is enabled before any operation of sensor, this patch adds vcc

RE: [PATCH V7] iio: light: isl29018: add vcc regulator operation support

2018-12-22 Thread Anson Huang
Hi, Jonathan Best Regards! Anson Huang > -Original Message- > From: Jonathan Cameron [mailto:ji...@kernel.org] > Sent: 2018年12月23日 1:15 > To: Anson Huang > Cc: knaac...@gmx.de; l...@metafoo.de; pme...@pmeerw.net; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;

[PATCH V6] iio: magnetometer: mag3110: add vdd/vddio regulator operation support

2018-12-22 Thread Anson Huang
The magnetometer's power supplies could be controllable on some platforms, such as i.MX6Q-SABRESD board, the mag3110's power supplies are controlled by a GPIO fixed regulator, need to make sure the regulators are enabled before any communication with mag3110, this patch adds vdd/vddio regulator

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Alexei Starovoitov
On Sat, Dec 22, 2018 at 11:03:31PM -0600, Gustavo A. R. Silva wrote: > Alexei, > > On 12/22/18 10:12 PM, Alexei Starovoitov wrote: > > On Sat, Dec 22, 2018 at 09:37:02PM -0600, Gustavo A. R. Silva wrote: > > > > > > Can't we have the case in which the code can be "trained" to read > > >

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
Alexei, On 12/22/18 10:12 PM, Alexei Starovoitov wrote: On Sat, Dec 22, 2018 at 09:37:02PM -0600, Gustavo A. R. Silva wrote: Can't we have the case in which the code can be "trained" to read perfectly valid values for prog->len for quite a while, making the microcode come into place and

[PATCH v2 0/4] staging: iio: adt7316: dac fixes

2018-12-22 Thread Jeremy Fertic
Changes in v2: - Patches 1-2: reworded commit messages and added Fixes tags - Patches 3-4: added Fixes tags Jeremy Fertic (4): staging: iio: adt7316: fix dac_bits assignment staging: iio: adt7316: fix handling of dac high resolution option staging: iio: adt7316: fix the dac read

[PATCH v2 2/4] staging: iio: adt7316: fix handling of dac high resolution option

2018-12-22 Thread Jeremy Fertic
The adt7316/7 and adt7516/7 have the option to output voltage proportional to temperature on dac a and/or dac b. The default dac resolution in this mode is 8 bits with the dac high resolution option enabling 10 bits. None of these settings affect dacs c and d. Remove the "1 (12 bits)" output from

[PATCH v2 3/4] staging: iio: adt7316: fix the dac read calculation

2018-12-22 Thread Jeremy Fertic
The calculation of the current dac value is using the wrong bits of the dac lsb register. Create two macros to shift the lsb register value into lsb position, depending on whether the dac is 10 or 12 bit. Initialize data to 0 so, with an 8 bit dac, the msb register value can be bitwise ORed with

[PATCH v2 4/4] staging: iio: adt7316: fix the dac write calculation

2018-12-22 Thread Jeremy Fertic
The lsb calculation is not masking the correct bits from the user input. Subtract 1 from (1 << offset) to correctly set up the mask to be applied to user input. The lsb register stores its value starting at the bit 7 position. adt7316_store_DAC() currently assumes the value is at the other end of

[PATCH v2 1/4] staging: iio: adt7316: fix dac_bits assignment

2018-12-22 Thread Jeremy Fertic
The value of dac_bits is used in adt7316_show_DAC() and adt7316_store_DAC(), and it should be either 8, 10, or 12 bits depending on the device in use. The driver currently only assigns a value to dac_bits in adt7316_store_da_high_resolution(). The purpose of the dac high resolution option is not

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-22 Thread Theodore Y. Ts'o
On Sat, Dec 22, 2018 at 08:10:07PM -0800, Matthew Wilcox wrote: > Pretty much every file format has the ability to put arbitrary blocks > of information into a file somewhere the tools which don't know about > it will skip it. For example, ZIP "includes an extra field facility > within file

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-22 Thread Theodore Y. Ts'o
On Sat, Dec 22, 2018 at 02:47:22PM -0800, Linus Torvalds wrote: > So I want to understand why this was made a filesystem operation in > the first place. What's fs-specific about this implementation? These are the things which are fs-specific. *) We have to splice into the file system's readpage

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Alexei Starovoitov
On Sat, Dec 22, 2018 at 09:37:02PM -0600, Gustavo A. R. Silva wrote: > > Can't we have the case in which the code can be "trained" to read > perfectly valid values for prog->len for quite a while, making the > microcode come into place and speculate about: > > 1013 if (flen == 0 || flen

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Ellie Reeves
Hi, I would like to thank you all for reacting to this issue so quickly, and I am really sorry for sending the message several time. I thought there was a problem with the way it was formatted or some such, hence why I sent it several times, because none of the messages seemed to get through.

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-22 Thread Matthew Wilcox
On Fri, Dec 21, 2018 at 11:17:12PM -0500, Theodore Y. Ts'o wrote: > Userspace applications which are reading the file aren't going to be > expecting Merkle tree. For example, one of the use cases is Android > APK files, which are essentially ZIP files. ZIP files can be parsed > both from the

Re: [PATCH] crypto: x86/chacha - avoid sleeping under kernel_fpu_begin()

2018-12-22 Thread Herbert Xu
On Sat, Dec 15, 2018 at 12:40:17PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Passing atomic=true to skcipher_walk_virt() only makes the later > skcipher_walk_done() calls use atomic memory allocations, not > skcipher_walk_virt() itself. Thus, we have to move it outside of the >

Re: [PATCH] crypto: cavium/nitrox - Added AEAD cipher support

2018-12-22 Thread Herbert Xu
On Fri, Dec 14, 2018 at 11:19:51AM +, Nagadheeraj Rottela wrote: > Added support to offload AEAD ciphers to NITROX. Currently supported > AEAD cipher is 'gcm(aes)'. > > Signed-off-by: Nagadheeraj Rottela > Reviewed-by: Srikanth Jampala > --- > drivers/crypto/cavium/nitrox/Makefile

Re: [PATCH 1/2] crypto: crypto_user_stat: remove unused dump functions

2018-12-22 Thread Herbert Xu
On Thu, Dec 13, 2018 at 08:36:37AM +, Corentin Labbe wrote: > This patch removes unused dump functions for crypto_user_stats. > There are remains of the copy/paste of crypto_user_base to > crypto_user_stat and I forgot to remove them. > > Signed-off-by: Corentin Labbe > --- >

Re: [PATCH] crypto: ux500 - Use proper enum in hash_set_dma_transfer

2018-12-22 Thread Herbert Xu
On Mon, Dec 10, 2018 at 04:49:54PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/crypto/ux500/hash/hash_core.c:169:4: warning: implicit > conversion from enumeration type 'enum dma_data_direction' to different > enumeration

Re: [PATCH] crypto: ux500 - Use proper enum in cryp_set_dma_transfer

2018-12-22 Thread Herbert Xu
On Mon, Dec 10, 2018 at 04:49:29PM -0700, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/crypto/ux500/cryp/cryp_core.c:559:5: warning: implicit > conversion from enumeration type 'enum dma_data_direction' to different > enumeration

Re: [PATCH 00/12] x86/crypto: gcmaes AVX scatter/gather support

2018-12-22 Thread Herbert Xu
On Mon, Dec 10, 2018 at 07:56:28PM +, Dave Watson wrote: > This patch set refactors the x86 aes/gcm AVX crypto routines to > support true scatter/gather by adding gcm_enc/dec_update methods. > > It is similar to the previous SSE patchset starting at e1fd316f. > Unlike the SSE routines, the

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
On 12/22/18 9:00 PM, Alexei Starovoitov wrote: On Sat, Dec 22, 2018 at 08:53:40PM -0600, Gustavo A. R. Silva wrote: Hi, On 12/22/18 8:40 PM, David Miller wrote: From: Alexei Starovoitov Date: Sat, 22 Dec 2018 15:59:54 -0800 On Sat, Dec 22, 2018 at 03:07:22PM -0800, David Miller wrote:

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 12:03:41 -0600 Tom Zanussi wrote: > Hi Steve, > > On Sat, 2018-12-22 at 13:01 -0500, Steven Rostedt wrote: > > On Sat, 22 Dec 2018 11:20:09 -0500 > > Steven Rostedt wrote: > > > > > From: "Steven Rostedt (VMware)" > > > > > > The tracing histogram code contains a lot

Re: [for-next][PATCH 0/5] tracing: Add string_has_prefix() and usages

2018-12-22 Thread Steven Rostedt
On Sun, 23 Dec 2018 12:41:20 +0900 Namhyung Kim wrote: > > Steven Rostedt (VMware) (5): > > string.h: Add str_has_prefix() helper function > > tracing: Use str_has_prefix() helper for histogram code > > tracing: Use str_has_prefix() instead of using fixed sizes > >

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
Alexei, On 12/22/18 9:37 PM, Gustavo A. R. Silva wrote: On 12/22/18 9:00 PM, Alexei Starovoitov wrote: On Sat, Dec 22, 2018 at 08:53:40PM -0600, Gustavo A. R. Silva wrote: Hi, On 12/22/18 8:40 PM, David Miller wrote: From: Alexei Starovoitov Date: Sat, 22 Dec 2018 15:59:54 -0800 On

Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
On 12/22/18 8:42 PM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Sat, 22 Dec 2018 17:37:35 -0600 I wonder if you can take this one too: https://lore.kernel.org/lkml/20181221212229.GA32635@embeddedor/ It's pretty similar to the af_nfc one. Sure, done. Great. Thanks. --

Re: [for-next][PATCH 5/5] tracing: Use the return of str_has_prefix() to remove open coded numbers

2018-12-22 Thread Steven Rostedt
On Sun, 23 Dec 2018 12:23:52 +0900 Masami Hiramatsu wrote: > On Sat, 22 Dec 2018 11:20:12 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > > > There are several locations that compare constants to the beginning of > > string variables to determine what commands should

Re: [for-next][PATCH 0/5] tracing: Add string_has_prefix() and usages

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 11:20:07AM -0500, Steven Rostedt wrote: > I hope everyone is OK with these changes. I pushed to linux-next but I'm > willing to change them if there are still issues. > > They ran through all my tests, althought zero-day-bot had a weird build > regression in sh, that looks

Re: [for-next][PATCH 4/5] tracing: Have the historgram use the result of str_has_prefix() for len of prefix

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 11:20:11AM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > As str_has_prefix() returns the length on match, we can use that for the > updating of the string pointer instead of recalculating the prefix size. > > Cc: Tom Zanussi > Signed-off-by: Steven

Re: [for-next][PATCH 2/5] tracing: Use str_has_prefix() helper for histogram code

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 11:20:09AM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The tracing histogram code contains a lot of instances of the construct: > > strncmp(str, "const", sizeof("const") - 1) > > This can be prone to bugs due to typos or bad cut and paste. Use

Re: [for-next][PATCH 5/5] tracing: Use the return of str_has_prefix() to remove open coded numbers

2018-12-22 Thread Masami Hiramatsu
On Sat, 22 Dec 2018 11:20:12 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > There are several locations that compare constants to the beginning of > string variables to determine what commands should be done, then the > constant length is used to index into the string. This

Re: [PATCH v4] string.h: Add str_has_prefix() helper function

2018-12-22 Thread Steven Rostedt
On Sun, 23 Dec 2018 12:13:43 +0900 Namhyung Kim wrote: > > Also, I believe there are some memcmp implementations that start at the > > end of the memory locations, not the beginning. That is, it compares > > backwards. Which is also legit for memcmp to do. > > I'm not sure, the man page says:

Re: [PATCH v3] string.h: Add str_has_prefix() helper

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 07:22:07AM -0500, Steven Rostedt wrote: > On Sat, 22 Dec 2018 18:28:18 +0900 > Namhyung Kim wrote: > > > > > > > for (i = 0; i < hist_data->attrs->n_actions; i++) { > > > str = hist_data->attrs->action_str[i]; > > > > > > - if (str_has_prefix(str,

Re: [alsa-devel] [PATCH v3 1/9] ASoC: sun4i-i2s: Adjust regmap settings

2018-12-22 Thread Chen-Yu Tsai
On Sun, Dec 23, 2018 at 6:12 AM Jonas Karlman wrote: > > On 2018-12-21 17:44, Chen-Yu Tsai wrote: > > On Fri, Dec 21, 2018 at 11:21 PM wrote: > >> From: Marcus Cooper > >> > >> Bypass the regmap cache when flushing the i2s FIFOs and modify the tables > >> to reflect this. > >> > >>

Re: [PATCH v4] string.h: Add str_has_prefix() helper function

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 12:24:54PM -0500, Steven Rostedt wrote: > On Sat, 22 Dec 2018 12:23:35 -0500 > Steven Rostedt wrote: > > > On Sat, 22 Dec 2018 12:19:11 -0500 > > Steven Rostedt wrote: > > > > > Because memcmp() isn't required to test byte by byte. In fact, most > > > implementations

Re: [PATCH v4] string.h: Add str_has_prefix() helper function

2018-12-22 Thread Namhyung Kim
On Sat, Dec 22, 2018 at 12:19:11PM -0500, Steven Rostedt wrote: > On Sun, 23 Dec 2018 01:46:05 +0900 > Namhyung Kim wrote: > > > > > What I meant by that is if a string is allocated at a end of a page, > > > and the next page is marked as not present. A read into that page will > > > cause a

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Alexei Starovoitov
On Sat, Dec 22, 2018 at 08:53:40PM -0600, Gustavo A. R. Silva wrote: > Hi, > > On 12/22/18 8:40 PM, David Miller wrote: > > From: Alexei Starovoitov > > Date: Sat, 22 Dec 2018 15:59:54 -0800 > > > > > On Sat, Dec 22, 2018 at 03:07:22PM -0800, David Miller wrote: > > > > From: "Gustavo A. R.

[PATCH v2 1/1] sock: Make sock->sk_stamp thread-safe

2018-12-22 Thread Deepa Dinamani
Al Viro mentioned (Message-ID <20170626041334.gz10...@zeniv.linux.org.uk>) that there is probably a race condition lurking in accesses of sk_stamp on 32-bit machines. sock->sk_stamp is of type ktime_t which is always an s64. On a 32 bit architecture, we might run into situations of unsafe access

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
Hi, On 12/22/18 8:40 PM, David Miller wrote: From: Alexei Starovoitov Date: Sat, 22 Dec 2018 15:59:54 -0800 On Sat, Dec 22, 2018 at 03:07:22PM -0800, David Miller wrote: From: "Gustavo A. R. Silva" Date: Fri, 21 Dec 2018 14:49:01 -0600 flen is indirectly controlled by user-space, hence

Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability

2018-12-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 22 Dec 2018 17:37:35 -0600 > I wonder if you can take this one too: > > https://lore.kernel.org/lkml/20181221212229.GA32635@embeddedor/ > > It's pretty similar to the af_nfc one. Sure, done.

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread David Miller
From: Alexei Starovoitov Date: Sat, 22 Dec 2018 15:59:54 -0800 > On Sat, Dec 22, 2018 at 03:07:22PM -0800, David Miller wrote: >> From: "Gustavo A. R. Silva" >> Date: Fri, 21 Dec 2018 14:49:01 -0600 >> >> > flen is indirectly controlled by user-space, hence leading to >> > a potential

Re: [PATCH 03/12] __wr_after_init: generic header

2018-12-22 Thread Igor Stoppa
On 21/12/2018 21:45, Matthew Wilcox wrote: On Fri, Dec 21, 2018 at 11:38:16AM -0800, Nadav Amit wrote: On Dec 19, 2018, at 1:33 PM, Igor Stoppa wrote: +static inline void *wr_memset(void *p, int c, __kernel_size_t len) +{ + return __wr_op((unsigned long)p, (unsigned long)c, len,

Re: [PATCH] debugfs: remove inc_nlink in debugfs_create_automount

2018-12-22 Thread Al Viro
On Sat, Dec 22, 2018 at 04:45:36PM +0800, yangerkun wrote: > Remove inc_nlink in debugfs_create_automount, or this inode will never > be free. Explain, please. What exactly would care about i_nlink in debugfs? It does *NOT* free any kind of backing store on inode eviction, for a good and simple

Re: [LKP] [bochs] df2052cc92: WARNING:at_drivers/gpu/drm/drm_mode_config.c:#drm_mode_config_cleanup

2018-12-22 Thread Peter Wu
On Fri, Dec 21, 2018 at 11:25:41AM -0800, Linus Torvalds wrote: > On Fri, Dec 21, 2018 at 12:32 AM kernel test robot > wrote: > > > > FYI, we noticed commit df2052cc9221 ("bochs: convert to > > drm_fb_helper_fbdev_setup/teardown") caused > > > > [ 487.591733] WARNING: CPU: 0 PID: 1 at > >

[PATCH] doc:it_IT: translation for process/submitting-patches

2018-12-22 Thread Federico Vaga
It translats the document process/submitting-patches.rst. Signed-off-by: Federico Vaga --- .../it_IT/process/submitting-patches.rst | 862 +- 1 file changed, 858 insertions(+), 4 deletions(-) diff --git a/Documentation/translations/it_IT/process/submitting-patches.rst

[PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-22 Thread Peter Wu
After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will have some effect). After that, drm_fb_helper_initial_config is called which may call the "fb_probe" driver callback. This driver callback may call

Re: [for-next][PATCH 0/5] tracing: Add string_has_prefix() and usages

2018-12-22 Thread Steven Rostedt
On Sat, 22 Dec 2018 11:20:07 -0500 Steven Rostedt wrote: > They ran through all my tests, althought zero-day-bot had a weird build > regression in sh, that looks totally unrelated: > > Regressions in current branch: > > arch/sh/kernel/dwarf.c:107:26: error: 'dwarf_frame_reg' defined but not

[PATCH] debugfs: remove inc_nlink in debugfs_create_automount

2018-12-22 Thread yangerkun
Remove inc_nlink in debugfs_create_automount, or this inode will never be free. Signed-off-by: yangerkun --- fs/debugfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 13b01351dd1c..9294238e364f 100644 ---

Re: [PATCH] debugfs: remove no need inc_nlink

2018-12-22 Thread yangerkun
Greg KH wrote on 2018/12/22 15:32: On Sat, Dec 22, 2018 at 11:41:11AM +0800, yangerkun wrote: Remove inc_nlink in debugfs_create_automount, or this inode will never be free. Signed-off-by: yangerkun --- fs/debugfs/inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread Alexei Starovoitov
On Sat, Dec 22, 2018 at 03:07:22PM -0800, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Fri, 21 Dec 2018 14:49:01 -0600 > > > flen is indirectly controlled by user-space, hence leading to > > a potential exploitation of the Spectre variant 1 vulnerability. > > > > This issue was

[GIT] Sparc

2018-12-22 Thread David Miller
Here is an early pull request for the next merge window: 1) Automatic system call table generation, from Firoz Khan. 2) Clean up accesses to the OF device names by using full_name instead of path_component_name. Please pull, thanks a lot! The following changes since commit

Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability

2018-12-22 Thread Gustavo A. R. Silva
On 12/22/18 5:09 PM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Fri, 21 Dec 2018 15:47:53 -0600 proto is indirectly controlled by user-space, hence leading to a potential exploitation of the Spectre variant 1 vulnerability. This issue was detected with the help of Smatch:

[PATCH 4/4] MAINTAINERS: add maintainer for HiSilicon QM and ZIP controller driver

2018-12-22 Thread Zhou Wang
Add Zhou Wang as a maintainer for HiSilicon QM and ZIP controller driver. Signed-off-by: Zhou Wang Reviewed-by: John Garry --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0767f1d..5be84e2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH 1/4] Documentation: Add debugfs doc for hisi_zip

2018-12-22 Thread Zhou Wang
Add debugfs descriptions for HiSilicon ZIP and QM driver. Signed-off-by: Zhou Wang Reviewed-by: Jonathan Cameron --- Documentation/ABI/testing/debugfs-hisi-zip | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/ABI/testing/debugfs-hisi-zip

[PATCH 2/4] crypto: hisilicon: Add queue management driver for HiSilicon QM module

2018-12-22 Thread Zhou Wang
QM is a general IP used by HiSilicon accelerators. It provides a general PCIe interface for the CPU and the accelerator to share a group of queues. A QM integrated in an accelerator provides queue management service. Queues can be assigned to PF and VFs, and queues can be controlled by unified

[PATCH 0/4] crypto: hisilicon: Add HiSilicon QM and ZIP controller driver

2018-12-22 Thread Zhou Wang
This series adds HiSilicon QM and ZIP controller driver in crypto subsystem. A simple QM/ZIP driver which helps to provide an example for a general accelerator framework is under review in community[1]. Based on this simple driver, this series adds HW v2 support, PCI passthrough, reset, PCI/misc

[PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support

2018-12-22 Thread Zhou Wang
The HiSilicon ZIP accelerator implements the zlib and gzip algorithm. It uses Hisilicon QM as the interface to the CPU. This patch provides PCIe driver to the accelerator and register it to the crypto subsystem. Signed-off-by: Zhou Wang Signed-off-by: Shiju Jose Signed-off-by: Kenneth Lee

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Gabriel C
Am So., 23. Dez. 2018 um 00:02 Uhr schrieb Linus Torvalds : > > On Sat, Dec 22, 2018 at 2:49 PM Christian Brauner > wrote: > > > > To be fair, no one apart from me was pointing out that it actually > > breaks people including systemd folks > > even though I was bringing it up with them. I even

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Linus Torvalds
On Sat, Dec 22, 2018 at 3:07 PM Christian Brauner wrote: > > However, for this case should I resend the revert? Since I was pointed at the original email thread, I just picked it up from there directly. It still applied cleanly, nothing had changed in that area. Linus

Re: [GIT PULL] auxdisplay for v4.20

2018-12-22 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Dec 2018 21:53:02 +0100: > https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v4.20 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/38c0ecf6087a8cb2af24ddd2124e9ca3c666dcdf Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] compiler-attributes for v4.20

2018-12-22 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Dec 2018 22:29:22 +0100: > https://github.com/ojeda/linux.git tags/compiler-attributes-for-linus-v4.20 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1104bd96eb2af9707dce69a22c63bd432a41380a Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] SCSI fixes for 4.20-rc7

2018-12-22 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Dec 2018 18:50:56 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9105b8aa50c182371533fc97db64fc8f26f051b3 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] nfc: af_nfc: Fix Spectre v1 vulnerability

2018-12-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 21 Dec 2018 15:47:53 -0600 > proto is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > net/nfc/af_nfc.c:42 nfc_sock_create()

Re: [PATCH] phonet: af_phonet: Fix Spectre v1 vulnerability

2018-12-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 21 Dec 2018 15:41:17 -0600 > protocol is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > net/phonet/af_phonet.c:48

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Christian Brauner
On Sun, Dec 23, 2018 at 12:02 AM Linus Torvalds wrote: > > On Sat, Dec 22, 2018 at 2:49 PM Christian Brauner > wrote: > > > > To be fair, no one apart from me was pointing out that it actually > > breaks people including systemd folks > > even though I was bringing it up with them. I even tried

Re: [PATCH] net: core: Fix Spectre v1 vulnerability

2018-12-22 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 21 Dec 2018 14:49:01 -0600 > flen is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > net/core/filter.c:1101

Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver

2018-12-22 Thread Pavel Machek
Hi, little elves! > So the little elves have been slowly working to get voice calls > working on droid 4 with the mainline kernel. And just in time for the > upcoming holidays, it might be possible to call friends and relatives. > > I've pushed out an experimental branch containing serdev ts

Re: [PATCH] sock: Make sock->sk_tstamp thread-safe

2018-12-22 Thread David Miller
From: Deepa Dinamani Date: Fri, 21 Dec 2018 12:27:33 -0800 > Al Viro mentioned that there is probably a race condition > lurking in accesses of sk_tstamp on 32-bit machines. > > sock->sk_tstamp is of type ktime_t which is always an s64. > On a 32 bit architecture, we might run into situations

Re: [PATCH] m68k/mac: Use '030 reset method on SE/30

2018-12-22 Thread Finn Thain
On Sat, 22 Dec 2018, Geert Uytterhoeven wrote: > > - local_irq_save(flags); > > - > > - rom_reset(); > > - > > - local_irq_restore(flags); > > I guess you removed the call to local_irq_restore() because you never > get there

Re: [PATCH][next] smack: fix two memory leaks in smack_add_opt

2018-12-22 Thread Colin Ian King
On 22/12/2018 19:34, Al Viro wrote: > On Sat, Dec 22, 2018 at 12:27:50PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently if s is null or when returning via the error exit label >> out_opt_err leaks of the allocated opts can occur. Fix the leak >> on the null s case by checking s

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Linus Torvalds
On Sat, Dec 22, 2018 at 2:49 PM Christian Brauner wrote: > > To be fair, no one apart from me was pointing out that it actually > breaks people including systemd folks > even though I was bringing it up with them. I even tried to fix all of > userspace after this got NACKED Seriously, the "we

Re: [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit

2018-12-22 Thread Sinan Kaya
On Sat, Dec 22, 2018 at 7:40 PM Lukas Wunner wrote: > > On Sat, Dec 22, 2018 at 09:07:12AM +, Sinan Kaya wrote: > > This driver depends on the PCI infrastructure but the dependency has not > > been explicitly called out. > > > > Signed-off-by: Sinan Kaya > > Reviewed-by: Lukas Wunner > >

[PATCH] rtlwifi: rtl8822b: fix a missing check of alloc_skb

2018-12-22 Thread Kangjie Lu
__netdev_alloc_skb() return NULl when it fails. skb_put() further uses it even when the allocation fails, leading to NULL pointer dereference. The fix inserts a check for the return value of __netdev_alloc_skb(). Signed-off-by: Kangjie Lu --- drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++ 1

Re: tpm_tis TPM2.0 not detected on cold boot

2018-12-22 Thread Mimi Zohar
On Sat, 2018-12-22 at 14:47 +0100, Michael Niewöhner wrote: > When I remove the timeout and boot directly to the linux kernel, I get that > "2314 TPM-self test error" since it has not finished, yet. The TPM is detected > by IMA and works fine then. > > Some more tests showed that any delay

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Christian Brauner
On Sat, Dec 22, 2018 at 11:20 PM Linus Torvalds wrote: > > Eric, this is entirely unacceptable. i would like to point out that I send a revert for this in *July* before any kernel with this change was released for the exact same reason. But I was ignored and no one came to argumentative aid: -

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-22 Thread Linus Torvalds
On Fri, Dec 21, 2018 at 8:20 PM Theodore Y. Ts'o wrote: > > On Fri, Dec 21, 2018 at 11:13:07AM -0800, Linus Torvalds wrote: > > > > In other words: either the model is that the file *itself* contains > > its own merkle tree that validates the file, or it isn't. You can't > > have it two ways. No

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-22 Thread Pavel Machek
Hi! > > This moves all remaining users of the legacy TI_ST driver to hcill (patches > > 1-3). Then patches 4-7 convert wl128x-radio driver to a standard platform > > device driver with support for multiple instances. Patch 7 will result in > > (userless) TI_ST driver no longer supporting radio at

[PATCH v3 2/2] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race

2018-12-22 Thread Mike Kravetz
hugetlbfs page faults can race with truncate and hole punch operations. Current code in the page fault path attempts to handle this by 'backing out' operations if we encounter the race. One obvious omission in the current code is removing a page newly added to the page cache. This is pretty

[PATCH v3 0/2] hugetlbfs: use i_mmap_rwsem for better synchronization

2018-12-22 Thread Mike Kravetz
There are two primary issues addressed here: 1) For shared pmds, huge PTE pointers returned by huge_pte_alloc can become invalid via a call to huge_pmd_unshare by another thread. 2) hugetlbfs page faults can race with truncation causing invalid global reserve counts and state. Both issues

[PATCH v3 1/2] hugetlbfs: use i_mmap_rwsem for more pmd sharing synchronization

2018-12-22 Thread Mike Kravetz
While looking at BUGs associated with invalid huge page map counts, it was discovered and observed that a huge pte pointer could become 'invalid' and point to another task's page table. Consider the following: A task takes a page fault on a shared hugetlbfs file and calls huge_pte_alloc to get a

RE: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.

2018-12-22 Thread Pawel Laszczak
Hi Rob, >On Mon, Dec 10, 2018 at 12:39:14PM +, Pawel Laszczak wrote: >> This patch aim at documenting USB related dt-bindings for the >> Cadence USBSS-DRD controller. >> >> Signed-off-by: Pawel Laszczak >> --- >> .../devicetree/bindings/usb/cdns3-usb.txt | 31 +++ >> 1

Re: [BREAKAGE] Since 4.18, kernel sets SB_I_NODEV implicitly on userns mounts, breaking systemd-nspawn

2018-12-22 Thread Linus Torvalds
Eric, this is entirely unacceptable. On Sat, Dec 22, 2018 at 12:58 PM Gabriel C wrote: > > Added some people to CC that might want to see this.. Thanks. > > Here's an email that was sent to lkml about the subject: > > > > https://lkml.org/lkml/2018/7/5/742 > > > > I link also this, quoting the

Re: [PATCH v2 2/2] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race

2018-12-22 Thread Kirill A. Shutemov
On Fri, Dec 21, 2018 at 02:17:32PM -0800, Mike Kravetz wrote: > Am I misunderstanding your question/concern? No. Thanks for the clarification. > > I have decided to add the locking (although unnecessary) with something like > this in hugetlbfs_evict_inode. > > /* >* The vfs layer

Re: [alsa-devel] [PATCH v3 1/9] ASoC: sun4i-i2s: Adjust regmap settings

2018-12-22 Thread Jonas Karlman
On 2018-12-21 17:44, Chen-Yu Tsai wrote: > On Fri, Dec 21, 2018 at 11:21 PM wrote: >> From: Marcus Cooper >> >> Bypass the regmap cache when flushing the i2s FIFOs and modify the tables >> to reflect this. >> >> Signed-off-by: Marcus Cooper >> --- >> sound/soc/sunxi/sun4i-i2s.c | 29

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-22 Thread Theodore Y. Ts'o
On Fri, Dec 21, 2018 at 11:13:07AM -0800, Linus Torvalds wrote: > > I do agree that your particular model is pretty damn broken in lots of ways. > > Why is it filesystem specific? If the whole point is that the file > itself has its own verification data (which I like), then I don't see > why

net: hns: question regarding ae_node device node refcounting

2018-12-22 Thread Alexey Khoroshilov
Hello, hns_nic_dev_probe() increments refcount of ae_node device node: ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0); But there is no of_node_put() for ae_node. What is the right place to decrement the ae_node refount? Should it be placed in hns_nic_dev_probe() or in

Re: [PATCH] lightnvm: pblk: fix use-after-free bug

2018-12-22 Thread Jens Axboe
On 12/22/18 11:30 AM, Matias Bjørling wrote: > On 12/22/18 8:39 AM, Gustavo A. R. Silva wrote: >> Remove one of the calls to function bio_put(), so *bio* is only >> freed once. >> >> Notice that bio is being dereferenced in bio_put(), hence leading to >> a use-after-free bug once *bio* has already

[PATCH] binderfs: implement "max" mount option

2018-12-22 Thread Christian Brauner
Since binderfs can be mounted by userns root in non-initial user namespaces some precautions are in order. First, a way to set a maximum on the number of binder devices that can be allocated per binderfs instance and second, a way to reserve a reasonable chunk of binderfs devices for the initial

[tip:efi/core] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE

2018-12-22 Thread tip-bot for Sai Praneeth Prakhya
Commit-ID: 1debf0958fa27b7c469dbf22754929ec59a7c0e7 Gitweb: https://git.kernel.org/tip/1debf0958fa27b7c469dbf22754929ec59a7c0e7 Author: Sai Praneeth Prakhya AuthorDate: Fri, 21 Dec 2018 18:22:34 -0800 Committer: Ingo Molnar CommitDate: Sat, 22 Dec 2018 20:58:30 +0100 x86/efi: Don't

  1   2   3   4   >