Re: general protection fault in put_pid

2018-12-25 Thread Dmitry Vyukov
On Sun, Dec 23, 2018 at 7:38 PM Manfred Spraul wrote: > > Hello Dmitry, > > On 12/23/18 11:42 AM, Dmitry Vyukov wrote: > > Actually was able to reproduce this with a syzkaller program: > > ./syz-execprog -repeat=0 -procs=10 prog > > ... > > kasan: CONFIG_KASAN_INLINE enabled > > kasan: GPF could

Re: [PATCH v3 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set

2018-12-25 Thread Rafael J. Wysocki
On Mon, Dec 24, 2018 at 12:25 AM Sinan Kaya wrote: > > Need CONFIG_PCI to be set in order to be able to use IOSF_MBI > functionality. > > Signed-off-by: Sinan Kaya The subject and changelog here don't match the changes below. Please fix. > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1

[PATCH] selftests/efivarfs: clean up test files from test_create*()

2018-12-25 Thread Po-Hsu Lin
Test files created by test_create*() tests will stay in the $efivarfs_mount directory until next reboot. When the tester tries to run this efivarfs test again on the same system, the immutable characteristics in that directory with those previously generated files will cause some "Permission

Re: rfc: bool structure members (was Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent)

2018-12-25 Thread Gal Pressman
On 25-Dec-18 01:12, Jason Gunthorpe wrote: > On Sun, Dec 23, 2018 at 06:42:20PM +0200, Gal Pressman wrote: >> On 22-Dec-18 01:52, Jason Gunthorpe wrote: >>> On Thu, Dec 20, 2018 at 09:12:43PM -0800, Joe Perches wrote: Care to submit a coding_style.rst patch or improve the one below this?

[PATCH] rts5208: fix a missing check of the status of sd_init_power

2018-12-25 Thread Kangjie Lu
sd_init_power() could fail. The fix inserts a check of its status. If it fails, returns STATUS_FAIL. Signed-off-by: Kangjie Lu --- drivers/staging/rts5208/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c

[PATCH] usb: gspca: add a missed check for goto_low_power

2018-12-25 Thread Kangjie Lu
The fix checks if goto_low_power() fails, and if so, issues an error message. Signed-off-by: Kangjie Lu --- drivers/media/usb/gspca/cpia1.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/cpia1.c b/drivers/media/usb/gspca/cpia1.c index

[PATCH] mfd: add a check for the status of mc13xxx_reg_read

2018-12-25 Thread Kangjie Lu
When mc13xxx_reg_read() fails, old_adc0 could be a random value and should not be used. The fix checks the status of mc13xxx_reg_read(): if it fails, returns with its error code. Signed-off-by: Kangjie Lu --- drivers/mfd/mc13xxx-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH][V2] drivers/net: appletalk/cops: remove redundant if statement and mask

2018-12-25 Thread Sergei Shtylyov
On 24.12.2018 22:41, Colin King wrote: From: Colin Ian King The two different assignments for pkt_len are actually the same and so the if statement is redundant and can be removed. Masking a u8 return value from inb() with 0xFF is also redundant and can also be emoved. Removed. :-)

[PATCH] media: drxk: add a missed check of the return value of write16

2018-12-25 Thread Kangjie Lu
write16() could fail. The fix inserts a check for its return value in case it fails. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/drxk_hard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/drxk_hard.c

<    1   2   3