Re: ath10_pci: WARN(() on resume from S3

2018-12-27 Thread DeX77
Hi, 4.20.0 I see now two. Also I see Unknown eventid: xxx and on 4.20.0 a unsupported HTC service id: xxx message(s). I have a similar trace on my Dell XPS 13: [31530.551292] ath10k_pci :3a:00.0: unsupported HTC service id: 1536 [31530.566621] ath10k_pci :3a:00.0: Unknown eventid:

[PATCH 0/2] sysctl: fix range-checking in do_proc_dointvec_minmax_conv()

2018-12-27 Thread Zev Weiss
Hello, After being left with an unusable system after a typo executing something like 'echo $((1<<24)) > /proc/sys/vm/max_map_count', I found that do_proc_dointvec_minmax_conv() was missing a check to ensure that the converted value actually fits in an int. The first of the following patches

[PATCH 1/2] test_sysctl: add tests for >32-bit values written to 32-bit integers

2018-12-27 Thread Zev Weiss
At present this exposes a bug in do_proc_dointvec_minmax_conv() (it fails to check for values that are too wide to fit in an int). Signed-off-by: Zev Weiss --- tools/testing/selftests/sysctl/sysctl.sh | 37 1 file changed, 37 insertions(+) diff --git

[PATCH 2/2] kernel/sysctl.c: define minmax conv functions in terms of non-minmax versions

2018-12-27 Thread Zev Weiss
do_proc_do[u]intvec_minmax_conv() had included open-coded versions of do_proc_do[u]intvec_conv(), though the signed one omitted the check that the value is in [INT_MIN, INT_MAX]. Rather than increase the duplication further by copying the additional check, we can instead refactor both to be

[PATCH v4 5/5] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host

2018-12-27 Thread Anup Patel
Currently on SMP host, all CPUs take external interrupts routed via PLIC. All CPUs will try to claim a given external interrupt but only one of them will succeed while other CPUs would simply resume whatever they were doing before. This means if we have N CPUs then for every external interrupt N-1

[PATCH v4 3/5] irqchip: sifive-plic: Add warning in plic_init() if handler already present

2018-12-27 Thread Anup Patel
We have two enteries (one for M-mode and another for S-mode) in the interrupts-extended DT property of PLIC DT node for each HART. It is expected that firmware/bootloader will set M-mode HWIRQ line of each HART to 0x (i.e. -1) in interrupts-extended DT property because Linux runs in S-mode

[PATCH v4 1/5] irqchip: sifive-plic: Pre-compute context hart base and enable base

2018-12-27 Thread Anup Patel
This patch does following optimizations: 1. Pre-compute hart base for each context handler 2. Pre-compute enable base for each context handler 3. Have enable lock for each context handler instead of global plic_toggle_lock Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 47

[PATCH v4 0/5] IRQ affinity support in PLIC driver

2018-12-27 Thread Anup Patel
This patchset primarily adds IRQ affinity support in PLIC driver and other improvements. It gives mechanism for explicitly route external interrupts to particular CPUs using smp_affinity attribute of each Linux IRQs. Also, we can now use IRQ balancer from kernel-space or user-space. The patchset

[PATCH v4 2/5] irqchip: sifive-plic: Don't inline plic_toggle() and plic_irq_toggle()

2018-12-27 Thread Anup Patel
The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a for loop so both these functions are not suitable for being inline hence this patch removes the inline keyword. Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v4 4/5] irqchip: sifive-plic: Differentiate between PLIC handler and context

2018-12-27 Thread Anup Patel
We explicitly differentiate between PLIC handler and context because PLIC context is for given mode of HART whereas PLIC handler is per-CPU software construct meant for handling interrupts from a particular PLIC context. To achieve this differentiation, we rename "nr_handlers" to "nr_contexts"

Re: [PATCH v3 0/2] perf tests: Check for ARM [vectors] page

2018-12-27 Thread Namhyung Kim
Hello, On Thu, Dec 20, 2018 at 07:43:35PM -0800, Florian Fainelli wrote: > Hi all, > > I just painfully learned that perf would segfault when > CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of Could you please elaborate? Thanks, Namhyung > it. This patch series adds

Re: [PATCH] sched: fix infinity loop in update_blocked_averages

2018-12-27 Thread Vincent Guittot
Adding Sargun and Dimitry who faced similar problem Adding Tejun On Thu, 27 Dec 2018 at 11:21, Vincent Guittot wrote: > > Le Thursday 27 Dec 2018 à 10:21:53 (+0100), Vincent Guittot a écrit : > > Hi Xie, > > > > On Thu, 27 Dec 2018 at 03:57, Xie XiuQi wrote: > > > > > > Zhepeng Xie report a

Re: [PATCH] sched: fix infinity loop in update_blocked_averages

2018-12-27 Thread Vincent Guittot
Le Thursday 27 Dec 2018 à 10:21:53 (+0100), Vincent Guittot a écrit : > Hi Xie, > > On Thu, 27 Dec 2018 at 03:57, Xie XiuQi wrote: > > > > Zhepeng Xie report a bug, there is a infinity loop in > > update_blocked_averages(). > > > > PID: 14233 TASK: 800b2de08fc0 CPU: 1 COMMAND: "docker" >

ath10_pci: WARN(() on resume from S3

2018-12-27 Thread Gabriel C
Hello , on a QCA9377 card I hit WARN() on each resume from S3. This is on kernel 4.19.X and now on 4.20.0 too. On kernel 4.19.x I see just the first WARN() while on 4.20.0 I see now two. Also I see Unknown eventid: xxx and on 4.20.0 a unsupported HTC service id: xxx message(s). ... [

Re: KASAN: use-after-free Write in __xfrm_policy_unlink

2018-12-27 Thread Dmitry Vyukov
On Wed, Dec 26, 2018 at 11:42 AM Florian Westphal wrote: > > syzbot wrote: > > syzbot has found a reproducer for the following crash on: > > > > HEAD commit:ce28bb445388 Merge git://git.kernel.org/pub/scm/linux/kern.. > > git tree: net-next > > console output:

Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver

2018-12-27 Thread Pavel Machek
Hi! > So the little elves have been slowly working to get voice calls > working on droid 4 with the mainline kernel. And just in time for the > upcoming holidays, it might be possible to call friends and > relatives. Thanks a lot for the Christmas present :-). > 2. Test a voice call > > $

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:22, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something

Re: [PATCH v1 6/7] drm: remove include of drmP.h from drm_modeset_helper.h

2018-12-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wednesday, 26 December 2018 23:03:52 EET Sam Ravnborg wrote: > Fix fallout in various files/drivers by adding missing include files. > > Signed-off-by: Sam Ravnborg > Cc: Alexey Brodkin > Cc: David Airlie > Cc: Daniel Vetter > Cc: Archit Taneja > Cc:

Re: [PATCH v1 4/7] drm: remove include of drmP.h from bridge/dw_hdmi.h

2018-12-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wednesday, 26 December 2018 23:03:50 EET Sam Ravnborg wrote: > Add missing includes in dw_hdmi.h and > fix fallout in drivers. > > Signed-off-by: Sam Ravnborg > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent Pinchart > Cc: David Airlie > Cc: Daniel

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:19, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something

Re: CPUs blocking in update_blocked_averages -- 4.19.12

2018-12-27 Thread Vincent Guittot
Hi Sargun, On Thu, 27 Dec 2018 at 10:36, Sargun Dhillon wrote: > > > > > We're seeing an issue introduced in 4.18, and that still persists in > > 4.19.12 (we upgraded from 4.9), where update_blocked_averages is > > blocking. We're running a workload where a majority of our workloads > > are

Re: [PATCH RFC 1/2] virtio-net: bql support

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:15, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote: On 2018/12/6 上午6:54, Michael S. Tsirkin wrote: When use_napi is set, let's enable BQLs. Note: some of the issues are similar to wifi. It's worth considering whether something

Re: [PATCH] rtc: fix a missing check of clk_prepare

2018-12-27 Thread Linus Walleij
On Wed, Dec 26, 2018 at 3:44 AM Kangjie Lu wrote: > clk_prepare() could fail, so let's check its status and if it fails > return its error code upstream. > > Signed-off-by: Kangjie Lu Acked-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

2018-12-27 Thread Jason Wang
On 2018/12/26 下午11:02, Michael S. Tsirkin wrote: On Wed, Dec 26, 2018 at 11:57:32AM +0800, Jason Wang wrote: On 2018/12/25 下午8:50, Michael S. Tsirkin wrote: On Tue, Dec 25, 2018 at 06:05:25PM +0800, Jason Wang wrote: On 2018/12/25 上午2:10, Michael S. Tsirkin wrote: On Mon, Dec 24, 2018 at

Re: [PATCH] pinctrl: freescale: Break dependency on SOC_IMX8MQ for i.MX8MQ

2018-12-27 Thread Linus Walleij
On Sun, Dec 23, 2018 at 8:08 AM Abel Vesa wrote: > The CONFIG_SOC_IMX8MQ will go away, so the dependency can be based on > ARCH_MXC && ARM64. > > Signed-off-by: Abel Vesa Patch applied with Dong's and Fabio's ACKs. Yours, Linus Walleij

Re: [PATCH] backlight: (adp8870) fix a missing check for adp8870_write

2018-12-27 Thread Sam Ravnborg
Hi Kangjie > adp8870_write() may fail. This fix checks if adp8870_write fails, and if > so, returns its error code. > > Signed-off-by: Kangjie Lu > --- > drivers/video/backlight/adp8870_bl.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git

RE: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

2018-12-27 Thread Pawel Laszczak
Hi, >> > + >> > + if (ret) >> > + return ret; >> > + >> > + state = readl(>otg_regs->sts); >> > + if (OTGSTS_OTG_NRDY(state) != 0) { >> > + dev_err(cdns->dev, "Cadence USB3 OTG device not ready\n"); >> > + return -ENODEV; >> > + }

Re: CPUs blocking in update_blocked_averages -- 4.19.12

2018-12-27 Thread Sargun Dhillon
> > We're seeing an issue introduced in 4.18, and that still persists in > 4.19.12 (we upgraded from 4.9), where update_blocked_averages is > blocking. We're running a workload where a majority of our workloads > are confined by cgroups. This exhibits itself due to a softlockup on > a CPU which

Re: [PATCH net V2 4/4] vhost: log dirty page correctly

2018-12-27 Thread Jason Wang
On 2018/12/26 下午9:46, Michael S. Tsirkin wrote: On Wed, Dec 26, 2018 at 01:43:26PM +0800, Jason Wang wrote: On 2018/12/26 上午12:25, Michael S. Tsirkin wrote: On Tue, Dec 25, 2018 at 05:43:25PM +0800, Jason Wang wrote: On 2018/12/25 上午1:41, Michael S. Tsirkin wrote: On Mon, Dec 24, 2018 at

Re: 4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384"

2018-12-27 Thread Christian Borntraeger
On 27.12.2018 10:13, Christian Borntraeger wrote: > Martin, > > Right now you get a message > "BUG: non-zero pgtables_bytes on freeing mm: -16384" > for EVERY process that exits in 4.19.5 and later. > > bisect points to > commit 4136161d676a93fc8df6bdb80d720c15522d6c24 > Author: Martin

答复: [PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel

2018-12-27 Thread Qu, Jim
Comments in line. Thanks JimQu 发件人: amd-gfx 代表 Kangjie Lu 发送时间: 2018年12月26日 14:23 收件人: k...@umn.edu 抄送: Zhou, David(ChunMing); David Airlie; Xu, Feifei; Francis, David; linux-kernel@vger.kernel.org; amd-...@lists.freedesktop.org; Huang, Ray;

[GIT PULL] GPIO bulk changes for the v4.21 kernel

2018-12-27 Thread Linus Walleij
Hi Linus, this is the main part of the v4.21 GPIO changes. Details are in the signed tag. Some interesting changes have already trickled in through the Regulator and MMC/SD trees but get mentioned in the signed tag nevertheless. Please pull it in! Yours, Linus Walleij The following changes

Re: [PATCH] sched: fix infinity loop in update_blocked_averages

2018-12-27 Thread Vincent Guittot
Hi Xie, On Thu, 27 Dec 2018 at 03:57, Xie XiuQi wrote: > > Zhepeng Xie report a bug, there is a infinity loop in > update_blocked_averages(). > > PID: 14233 TASK: 800b2de08fc0 CPU: 1 COMMAND: "docker" > #0 [2213b9d0] update_blocked_averages at 0811e4a8 > #1

4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384"

2018-12-27 Thread Christian Borntraeger
Martin, Right now you get a message "BUG: non-zero pgtables_bytes on freeing mm: -16384" for EVERY process that exits in 4.19.5 and later. bisect points to commit 4136161d676a93fc8df6bdb80d720c15522d6c24 Author: Martin Schwidefsky Date: Mon Oct 15 11:09:16 2018 +0200 s390/mm: fix

Re: [PATCH V5 3/3] mmc: tegra: HW Command Queue Support for Tegra SDMMC

2018-12-27 Thread Adrian Hunter
On 21/12/18 3:25 AM, Sowjanya Komatineni wrote: > This patch adds HW Command Queue for supported Tegra SDMMC > controllers. > > Tegra SDHCI with Quirk SDHCI_QUIRK2_BROKEN_64_BIT_DMA disables the > use of 64_BIT DMA to disable 64-bit addressing mode access to the > system memory and

Re: [PATCH][next] drivers: base: swnode: check if swnode is null before dereferencing it

2018-12-27 Thread Rafael J. Wysocki
On Sat, Dec 22, 2018 at 1:43 PM Colin King wrote: > > From: Colin Ian King > > The macro to_software_mode can potentially return NULL, so also add > a null check on the swnode before dereferencing it to avoid any null > pointer dereferences. > > Detected by CoverityScan, CID#1476052 ("Explicit

Re: [PATCH] drivers: base: swnode: check if pointer p is null before dereferencing it

2018-12-27 Thread Rafael J. Wysocki
On Sat, Dec 22, 2018 at 1:49 PM Colin King wrote: > > From: Colin Ian King > > The pointer p can be potentially null macro to_software_node can return > null. Add null check on p before dereferencing it to avoid any null > pointer dereferences. > > Detected by CoverityScan, CID#1476039

[PATCH v3] Optimize C3 entry on Centaur CPUs

2018-12-27 Thread David Wang
For new Centaur CPUs the ucode will take care of the preservation of cache coherence between CPU cores in C-states regardless of how deep the C-states are. So, it is not necessary to flush the caches in software befor entering C3. And this useless operation will cause performance drop for the

[PATCH] ALSA: hda/realtek: Enable the headset mic auto detection for ASUS laptops

2018-12-27 Thread Jian-Hong Pan
The headset mic of ASUS laptops like UX533FD, UX433FN and UX333FA, whose CODEC is Realtek ALC294 has jack auto detection feature. This patch enables the feature. Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan --- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v4 2/5] leds: Add helper for getting default pattern from Device Tree

2018-12-27 Thread Krzysztof Kozlowski
On Tue, 18 Dec 2018 at 16:27, Krzysztof Kozlowski wrote: > > Multiple LED triggers might need to access default pattern so add a > helper for that. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/leds/led-class.c | 42 ++ As pointed out by 0day-ci

[PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2018-12-27 Thread Matti Vaittinen
Do not return error if irq-type setting is requested for controlloer which does not support this. This is how regmap-irq has previously handled the undupported type settings and existing drivers seem to be upset if failure is now reported. Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620:

[regression from v4.19] Re: 4.20.0-rc6-next-20181210, v4.20-rc1: list_del corruption on thinkpad x220, graphics related?

2018-12-27 Thread Pavel Machek
Hi! > > > > If you think it is useful, I can try to update my machine to > > > > linux-next. > > > > > > linux-next is closer to drm-tip, so it's better. Do you have some > > > specific reason for not wanting to run drm-tip (but linux-next is still > > > ok)? > > > > I already have build/update

Re: [PATCH V5 1/3] mmc: sdhci: Fix sdhci_do_enable_v4_mode

2018-12-27 Thread Adrian Hunter
On 21/12/18 3:25 AM, Sowjanya Komatineni wrote: > V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register. > Need to perform word access to this register. > > Signed-off-by: Sowjanya Komatineni This patch has already been applied. > --- > drivers/mmc/host/sdhci.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 1/5] perf session: Get rid of file_size variable

2018-12-27 Thread Jiri Olsa
On Wed, Dec 26, 2018 at 04:43:42PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 26, 2018 at 02:51:28PM +0100, Jiri Olsa escreveu: > > It's not needed and removing it makes the code little > > more simple for upcoming changes. > > > > It's safe to replace file_size with data_size, because

Re: [PATCH 15/18] drm/mediatek: add RDMA1 fifo size into RDMA private data

2018-12-27 Thread CK Hu
Hi, Yongqiang: On Mon, 2018-12-24 at 16:08 +0800, Yongqiang Niu wrote: > This patch add RDMA1 fifo size into RDMA private data > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff

Re: [PATCH] xfs: add a check for xfs_trans_commit

2018-12-27 Thread Christoph Hellwig
On Wed, Dec 26, 2018 at 12:05:16AM -0600, Kangjie Lu wrote: > xfs_trans_commit could fails. The checks issues an error message upon > its failure. > > Signed-off-by: Kangjie Lu Please take a close look at what could fail in xfs_trans_commit, and how those failures are logged inside the

Re: [PATCH] perf python: Do not force closing original perf descriptor in evlist.get_pollfd

2018-12-27 Thread Jiri Olsa
On Wed, Dec 26, 2018 at 12:21:21PM +0100, Jiri Olsa wrote: > Ondřej reported that when compiled with python3, the python > extension regress in evlist.get_pollfd function behaviour. > > The evlist.get_pollfd creates file objects from evlist's fds > and returns them in the list. The python3

Re: [PATCH V4 1/3] mmc: sdhci: add support for using external DMA devices

2018-12-27 Thread Chunyan Zhang
On Thu, 27 Dec 2018 at 15:44, Adrian Hunter wrote: > > On 11/12/18 11:12 AM, Chunyan Zhang wrote: > > Some standard SD host controllers can support both external dma > > controllers as well as ADMA/SDMA in which the SD host controller > > acts as DMA master. TI's omap controller is the case as an

<    1   2   3   4