Re: [PATCH] drivers: platform: goldfish_sync: add a driver

2019-01-04 Thread kbuild test robot
Hi Roman, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH RFC lora-next 1/4] net: lora: sx125x sx1301: correct style warnings

2019-01-04 Thread Ben Whitten
Hi Andreas, On 29/12/2018 09:05, Andreas Färber wrote: Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: Checkpatch highlights some style issues which need to be addressed. Signed-off-by: Ben Whitten --- drivers/net/lora/sx125x.c | 20 +-- drivers/net/lora/sx1301.c | 52

[PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-01-04 Thread Manivannan Sadhasivam
Add HI3670 SoC UFS driver support by extending the common ufs-hisi driver. One major difference between HI3660 ad HI3670 SoCs interms of UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is used to distinguish the configuration. Signed-off-by: Manivannan Sadhasivam ---

[PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-01-04 Thread Manivannan Sadhasivam
Add UFS controller support for HiSilicon HI3670 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi

[PATCH v2 0/3] Add UFS controller support for HI3670 SoC

2019-01-04 Thread Manivannan Sadhasivam
Hello, This patchset adds UFS controller support for HiSilicon HI3670 SoC. HI3760 SoC is very similar to HI3660 SoC with almost same IPs, hence the same driver is extended to provide UFS support. Only major difference is the PHY. HI3670 has 10nm PHY, hence that parameter is used to distinguish

[PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-01-04 Thread Manivannan Sadhasivam
Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very similar to HI3660 SoC with almost same IPs. Only major difference in terms of UFS is the PHY. HI3670 has 10nm PHY. But since the original driver (HI3660 UFS) cannot make HI3670 UFS functional, a separate compatible is added for

Re: [PATCH 2/2] ARM: integrator: impd1: use struct_size() in devm_kzalloc()

2019-01-04 Thread kbuild test robot
Hi Gustavo, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm-soc/for-next] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2 2/2] ARM: integrator: impd1: use struct_size() in devm_kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = devm_kzalloc(dev,

[PATCH v2 1/2] ARM: integrator: impd1: fix NULL pointer dereference

2019-01-04 Thread Gustavo A. R. Silva
There is a potential NULL pointer dereference in case devm_kzalloc() fails and returns NULL. Fix this by adding a NULL check on lookup. This issue was detected with the help of Coccinelle. Fixes: 684284b64aae ("ARM: integrator: add MMCI device to IM-PD1") Cc: sta...@vger.kernel.org

[PATCH v2 0/2] Fix NULL pointer dereference and use struct_size

2019-01-04 Thread Gustavo A. R. Silva
Hi, The first patch in this series fixes a potential NULL pointer dereference by adding a NULL check. A tag for stable has been added for this patch. The second patch promotes the use of struct_size() in devm_kzalloc(). Both issues were detected with the help of Coccinelle. Thanks Changes in

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 09:44:17PM -0800, John Stultz wrote: > On Fri, Jan 4, 2019 at 9:39 PM Manivannan Sadhasivam > wrote: > > > > On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > > > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > > > wrote: > > > > On Fri, Jan 04, 2019

[PATCH] signal: allow the null signal in rt_sigqueueinfo()

2019-01-04 Thread Qian Cai
Running the trinity fuzzer triggered this, UBSAN: Undefined behaviour in kernel/signal.c:2946:7 shift exponent 4294967295 is too large for 64-bit type 'long unsigned int' [ 3752.406618] dump_stack+0xe0/0x17a [ 3752.419817] ubsan_epilogue+0xd/0x4e [ 3752.423429]

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 9:39 PM Manivannan Sadhasivam wrote: > > On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > > wrote: > > > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > > > From: Youlin Wang > > > > >

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 09:22:46PM -0800, John Stultz wrote: > On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam > wrote: > > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > > From: Youlin Wang > > > > > > There is an new "hisi-pcm-asp-dma-1.0" device added in > > >

Re: [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 8:34 PM John Stultz wrote: > > On Fri, Jan 4, 2019 at 7:49 PM Manivannan Sadhasivam > wrote: > > > > Hi John, > > > > On Fri, Jan 04, 2019 at 12:56:26PM -0800, John Stultz wrote: > > > Try to add DMA support to the uart nodes following > > > the assignments made in the dts

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 7:42 PM Manivannan Sadhasivam wrote: > On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > > From: Youlin Wang > > > > There is an new "hisi-pcm-asp-dma-1.0" device added in > > "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". > > So we have to add a matching id in

[PATCH] keyboard/mtk-pmic-keys.c: Remove duplicate header

2019-01-04 Thread Brajeswar Ghosh
Remove linux/kernel.h which is included more than once Signed-off-by: Brajeswar Ghosh --- drivers/input/keyboard/mtk-pmic-keys.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c index 02c67a1749fc..5027ebb7b4e8

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 8:53 PM Manivannan Sadhasivam wrote: > > On Fri, Jan 04, 2019 at 08:39:34PM -0800, John Stultz wrote: > > On Fri, Jan 4, 2019 at 8:00 PM Manivannan Sadhasivam > > wrote: > > > > > > Hi John, > > > > > > On Fri, Jan 04, 2019 at 12:56:22PM -0800, John Stultz wrote: > > > >

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 08:39:34PM -0800, John Stultz wrote: > On Fri, Jan 4, 2019 at 8:00 PM Manivannan Sadhasivam > wrote: > > > > Hi John, > > > > On Fri, Jan 04, 2019 at 12:56:22PM -0800, John Stultz wrote: > > > Some dma channels can be reserved for secure mode or other > > > hardware on the

Re: [PATCH] drivers/bus/fsl-mc/dpbp.c: Remove duplicate header

2019-01-04 Thread Brajeswar Ghosh
On Wed, Dec 5, 2018 at 12:10 PM Brajeswar Ghosh wrote: > > On Fri, Nov 16, 2018 at 8:47 PM Brajeswar Ghosh > wrote: > > > > On Fri, Nov 9, 2018 at 3:21 PM Brajeswar Ghosh > > wrote: > > > > > > Remove linux/fsl/mc.h which is included more than once > > > > > > Signed-off-by: Brajeswar Ghosh >

Re: [PATCH] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode

2019-01-04 Thread b-ak
On Fri, Jan 04, 2019 at 10:10:40PM +0530, b-ak wrote: > On Fri, Jan 04, 2019 at 01:04:21AM +0530, b-ak wrote: > > On Thu, Jan 03, 2019 at 12:45:54PM +, Mark Brown wrote: > > > On Wed, Jan 02, 2019 at 10:36:33PM +0530, b-ak wrote: > > > > During the bootup of the kernel, as soon as the DAPM

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 8:00 PM Manivannan Sadhasivam wrote: > > Hi John, > > On Fri, Jan 04, 2019 at 12:56:22PM -0800, John Stultz wrote: > > Some dma channels can be reserved for secure mode or other > > hardware on the SoC, so provide a binding for a bitmask > > listing the available channels

[PATCH v2] Drivers: hv: vmbus: Expose counters for interrupts and full conditions

2019-01-04 Thread Kimberly Brown
Counter values for per-channel interrupts and ring buffer full conditions are useful for investigating performance. Expose counters in sysfs for 2 types of guest to host interrupts: 1) Interrupts caused by the channel's outbound ring buffer transitioning from empty to not empty 2) Interrupts

Re: [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 7:49 PM Manivannan Sadhasivam wrote: > > Hi John, > > On Fri, Jan 04, 2019 at 12:56:26PM -0800, John Stultz wrote: > > Try to add DMA support to the uart nodes following > > the assignments made in the dts from the victoria vendor kernel > > here: > >

Re: [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960

2019-01-04 Thread John Stultz
On Fri, Jan 4, 2019 at 7:37 PM Manivannan Sadhasivam wrote: > > Hi John, > > On Fri, Jan 04, 2019 at 12:56:20PM -0800, John Stultz wrote: > > This patch series is based on recent work by Tanglei Han, and > > adds support for hi3660 SoCs as found on the HiKey960 board, > > Not sure about the

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-04 Thread Yunsheng Lin
On 2018/12/17 22:36, Russell King - ARM Linux wrote: > I'll try to do further diagnosis over Christmas in case I've missed > something, but I suspect it may be one of those "weird behaviour" issues > where the safest action is to disable pause mode as per my commit - > which is far saner than

RE: [PATCH 1/2] e1000e: Exclude device from suspend direct complete optimization

2019-01-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Kai-Heng Feng > Sent: Tuesday, December 11, 2018 12:00 AM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; intel-wired-...@lists.osuosl.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org;

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-04 Thread Manivannan Sadhasivam
Hi John, On Fri, Jan 04, 2019 at 12:56:22PM -0800, John Stultz wrote: > Some dma channels can be reserved for secure mode or other > hardware on the SoC, so provide a binding for a bitmask > listing the available channels for the kernel to use. > > Cc: Vinod Koul > Cc: Rob Herring > Cc: Mark

Re: [PATCH 7/8 v2] arm64: dts: hi3660: Add hisi asp dma device

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 12:56:27PM -0800, John Stultz wrote: > From: Youlin Wang > > Add asp-dma device to hi3660 dts > > Cc: Tanglei Han > Cc: Zhuangluan Su > Cc: Ryan Grachek > Cc: Manivannan Sadhasivam > Cc: Wei Xu > Cc: Rob Herring > Cc: Mark Rutland > Cc:

Re: [PATCH 6/8 v2] arm64: dts: hi3660: Add dma to uart nodes

2019-01-04 Thread Manivannan Sadhasivam
Hi John, On Fri, Jan 04, 2019 at 12:56:26PM -0800, John Stultz wrote: > Try to add DMA support to the uart nodes following > the assignments made in the dts from the victoria vendor kernel > here: > https://consumer.huawei.com/en/opensource/detail/?siteCode=worldwide=p10=openSourceSoftware=10=1 >

Re: [PATCHv3 1/2] mm/memblock: extend the limit inferior of bottom-up after parsing hotplug attr

2019-01-04 Thread Baoquan He
On 01/04/19 at 05:09pm, Mike Rapoport wrote: > On Thu, Jan 03, 2019 at 10:47:06AM -0800, Tejun Heo wrote: > > Hello, > > > > On Wed, Jan 02, 2019 at 07:05:38PM +0200, Mike Rapoport wrote: > > > I agree that currently the bottom-up allocation after the kernel text has > > > issues with KASLR. But

Re: [PATCH 4/8 v2] dma: k3dma: Delete axi_config

2019-01-04 Thread Manivannan Sadhasivam
On Fri, Jan 04, 2019 at 12:56:24PM -0800, John Stultz wrote: > From: Li Yu > > Axi_config controls whether DMA resources can be accessed in non-secure > mode, such as linux kernel. The register should be set by the bootloader > stage and depends on the device. > > Thus, this patch removes

Re: [PATCH 3/8 v2] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware

2019-01-04 Thread Manivannan Sadhasivam
Hi John, On Fri, Jan 04, 2019 at 12:56:23PM -0800, John Stultz wrote: > From: Youlin Wang > > There is an new "hisi-pcm-asp-dma-1.0" device added in > "arch/arm64/boot/dts/hisilicon/hi3660.dtsi". > So we have to add a matching id in the driver file: > .compatible =

Re: [PATCH 0/8 v2] k3dma patches to add support for hi3660/HiKey960

2019-01-04 Thread Manivannan Sadhasivam
Hi John, On Fri, Jan 04, 2019 at 12:56:20PM -0800, John Stultz wrote: > This patch series is based on recent work by Tanglei Han, and > adds support for hi3660 SoCs as found on the HiKey960 board, Not sure about the description/subject here! This patchset adds support for ASP DMAC found in

RE: [PATCH v2 1/2] virtio-balloon: tweak config_changed implementation

2019-01-04 Thread Wang, Wei W
On Friday, January 4, 2019 11:45 PM, Michael S. Tsirkin wrote: > > struct virtio_balloon { > > struct virtio_device *vdev; > > struct virtqueue *inflate_vq, *deflate_vq, *stats_vq, *free_page_vq; > > @@ -77,6 +81,8 @@ struct virtio_balloon { > > /* Prevent updating balloon when it is

[RFT][PATCH] regulator: bcm590xx: Fix .enable_reg for BCM590XX_REG_VSR

2019-01-04 Thread Axel Lin
Current implementation missed the case BCM590XX_REG_VSR, so bcm590xx_get_enable_register() returns 0 when id is BCM590XX_REG_VSR. Signed-off-by: Axel Lin --- Hi Matt, Current code looks strange becasue bcm590xx_get_enable_register() returns 0 for BCM590XX_REG_VSR but there is a

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-04 Thread Jason Gunthorpe
On Sat, Jan 05, 2019 at 10:37:17AM +0800, kbuild test robot wrote: > Hi Jason, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.20 next-20190103] > [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH] perf stat: Poll for monitored tasks being alive in fork mode

2019-01-04 Thread Jin, Yao
On 1/4/2019 8:54 PM, Jiri Olsa wrote: On Fri, Jan 04, 2019 at 10:28:17AM +0800, Jin Yao wrote: Following test shows the stat keeps running even if no longer task to monitor (mgen exits at ~5s). perf stat -e cycles -p `pgrep mgen` -I1000 -- sleep 10 time counts unit

[PATCH v2 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. This patch adds a "ti,single-shot" property to allow changing the default continuous mode to single-shot

[PATCH v2 2/2] hwmon: (ina3221) Implement ti,single-shot DT property

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. The DT binding doc is updated with a new boolean type property to allow changing the default operating mode from

[PATCH v2 0/2] hwmon (ina3221) Add single-shot mode support

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. This series of patches add a feature of changing default operating mode to its single-shot mode via DT.

[PATCH] kconfig: rename generated .*conf-cfg to *conf-cfg

2019-01-04 Thread Masahiro Yamada
Remove the dot-prefixing since it is just a matter of the .gitignore file. Signed-off-by: Masahiro Yamada --- scripts/kconfig/.gitignore | 1 + scripts/kconfig/Makefile | 36 ++-- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git

Re: [PATCH net 0/4] net: bpfilter: fix two bugs in bpfilter

2019-01-04 Thread Taehee Yoo
On Sat, 5 Jan 2019 at 05:54, David Miller wrote: > > From: Taehee Yoo > Date: Mon, 31 Dec 2018 01:30:45 +0900 > > > This patches fix two bugs in the bpfilter_umh which are related in > > iptables command. > ... > > I am still thinking about these patches, sorry for taking so long to > give a

Re: [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property

2019-01-04 Thread Nicolin Chen
On Fri, Jan 04, 2019 at 06:37:55PM -0800, Guenter Roeck wrote: > > +enum ina3221_modes { > > + INA3221_MODE_SINGLE_SHOT, > > + INA3221_MODE_CONTINUOUS, > > + INA3221_NUM_MODES, > > Is NUM_MODES used anywhere ? Please drop unless there is a reason to keep it. Will clean it up in v2. Thanks

Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-04 Thread Larry Finger
On 1/4/19 6:48 AM, Bernd Edlinger wrote: This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0

Re: [PATCH] x86: only use ERMS for user copies for larger sizes

2019-01-04 Thread Linus Torvalds
Coming back to this old thread, because I've spent most of the day resurrecting some of my old core x86 patches, and one of them was for the issue David Laight complained about: horrible memcpy_toio() performance. Yes, I should have done this before the merge window instead of at the end of it,

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-04 Thread kbuild test robot
Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property

2019-01-04 Thread Guenter Roeck
On 1/4/19 4:49 PM, Nicolin Chen wrote: By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. The DT binding doc is updated with a new boolean type property to allow

Re: [GIT PULL] sound updates for 4.21

2019-01-04 Thread Pierre-Louis Bossart
On 1/4/19 6:34 PM, Azat Khuzhin wrote: This is unfortunately a known issue with this driver, Takashi and I had a couple of email threads on this. Even without errors removing the module doesn't seem to release all resources. I don't like this at all, and for the Sound Open Firmware (SOF)

[PATCH 10/21] ASoC: rt274: fix boolean tests

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/rt274.c:958:6-8: WARNING: Comparison to bool sound/soc/codecs/rt274.c:961:6-9: WARNING: Comparison to bool sound/soc/codecs/rt274.c:384:5-7: WARNING: Comparison to bool sound/soc/codecs/rt274.c:387:5-8: WARNING: Comparison to bool Signed-off-by:

[PATCH 19/21] ASoC: da7219: use logical AND

2019-01-04 Thread Pierre-Louis Bossart
Reported by Sparse: da7219.c:841:57: warning: dubious: x & !y Cc: Adam Thomson Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/da7219.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index

[PATCH 16/21] ASoC: tscs42xx.c: fix boolean test

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/tscs42xx.c:392:5-31: WARNING: Comparison to bool Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/tscs42xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tscs42xx.c b/sound/soc/codecs/tscs42xx.c index

[PATCH 15/21] ASoC: nau8824: fix boolean assignment

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: nau8824.c:810:6-12: ERROR: Assignment of bool to non-0/1 constant Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/nau8824.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index

[PATCH 13/21] ASoC: max98927: fix boolean assignments

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/max98927.c:508:2-20: WARNING: Assignment of bool to 0/1 sound/soc/codecs/max98927.c:889:3-28: WARNING: Assignment of bool to 0/1 sound/soc/codecs/max98927.c:891:3-28: WARNING: Assignment of bool to 0/1 sound/soc/codecs/max98927.c:893:2-27: WARNING:

[PATCH 20/21] ASoC: rt5645: store eq kcontrol byte in __be

2019-01-04 Thread Pierre-Louis Bossart
From: Bard liao The eq parameters binary is stored in __be. However, it is unsigned short in rt5645_eq_param_s{} which will cause incorrect type assignment. So add struct rt5645_eq_param_s_be16{} to store the eq binary and convert it to unsigned short in rt5645->eq_param. Cc: Oder Chiou

[PATCH 17/21] ASoC: mt6351: remove unneeded variable

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: mt6351.c:1418:5-8: Unneeded variable: "ret". Return "0" on line 1437 Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/mt6351.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/codecs/mt6351.c index

[PATCH 21/21] ASoC: rl6437a: use __be32 for a __be32 buf

2019-01-04 Thread Pierre-Louis Bossart
From: Bard liao The buf in rl6347a_hw_read is __be32. Cc: Oder Chiou Signed-off-by: Bard liao Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rl6347a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rl6347a.c b/sound/soc/codecs/rl6347a.c

[PATCH 18/21] ASoC: da7219: fix endianness issues

2019-01-04 Thread Pierre-Louis Bossart
Reported by Sparse. da7219.c:440:44: warning: cast to restricted __le16 da7219.c:461:13: warning: incorrect type in assignment (different base types) da7219.c:461:13:expected unsigned short [unsigned] [usertype] val da7219.c:461:13:got restricted __le16 [usertype] da7219.c:1451:16:

[PATCH 11/21] ASoc: rt286: fix boolean tests

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/rt286.c:927:5-7: WARNING: Comparison to bool sound/soc/codecs/rt286.c:930:5-8: WARNING: Comparison to bool sound/soc/codecs/rt286.c:299:5-7: WARNING: Comparison to bool sound/soc/codecs/rt286.c:302:5-8: WARNING: Comparison to bool Signed-off-by:

[PATCH 04/21] ASoC: codecs: fix kernel doc descriptions

2019-01-04 Thread Pierre-Louis Bossart
Missing or spurious parameter descriptions. Fix warnings with W=1 Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/nau8825.c | 1 + sound/soc/codecs/rt5514.c | 1 + sound/soc/codecs/rt5677.c | 8 3 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 08/21] ASoC: rt298: fix boolean tests

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/rt298.c:992:6-8: WARNING: Comparison to bool sound/soc/codecs/rt298.c:995:6-9: WARNING: Comparison to bool sound/soc/codecs/rt298.c:317:5-7: WARNING: Comparison to bool sound/soc/codecs/rt298.c:320:5-8: WARNING: Comparison to bool

[PATCH 12/21] ASoC: rt5640: fix boolean assignments

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/rt5640.c:980:2-17: WARNING: Assignment of bool to 0/1 sound/soc/codecs/rt5640.c:984:2-17: WARNING: Assignment of bool to 0/1 sound/soc/codecs/rt5640.c:2825:1-16: WARNING: Assignment of bool to 0/1 Signed-off-by: Pierre-Louis Bossart ---

[PATCH 02/21] ASoC: max98090: remove unused constant variables

2019-01-04 Thread Pierre-Louis Bossart
Fix warnings with W=1 If these variables are useful then this driver should be modified to expose them. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/max98090.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/sound/soc/codecs/max98090.c

[PATCH 14/21] ASoC: rt5651: fix boolean assignments

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/rt5651.c:750:2-17: WARNING: Assignment of bool to 0/1 sound/soc/codecs/rt5651.c:754:2-17: WARNING: Assignment of bool to 0/1 sound/soc/codecs/rt5651.c:2192:1-16: WARNING: Assignment of bool to 0/1 Signed-off-by: Pierre-Louis Bossart ---

[PATCH 09/21] ASoC: cs4271: fix boolean assignments

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/cs4271.c:226:2-16: WARNING: Assignment of bool to 0/1 sound/soc/codecs/cs4271.c:229:2-16: WARNING: Assignment of bool to 0/1 Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/cs4271.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 01/21] ASoC: dmic: declare trigger function as static

2019-01-04 Thread Pierre-Louis Bossart
No reason why this is global, fix warnings with W=1 Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/dmic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index da921da50ef0..de041369e5a7 100644 ---

[PATCH 03/21] ASoC: es8316: remove unused constant variables

2019-01-04 Thread Pierre-Louis Bossart
Fix warnings with W=1 If these variables are useful this driver should be modified to expose them. Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/es8316.c | 4 1 file changed, 4 deletions(-) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index

[PATCH 07/21] ASoC: max98383: fix boolean assignments to true/false

2019-01-04 Thread Pierre-Louis Bossart
Reported by Coccinelle: sound/soc/codecs/max98373.c:411:2-20: WARNING: Assignment of bool to 0/1 sound/soc/codecs/max98373.c:922:2-27: WARNING: Assignment of bool to 0/1 sound/soc/codecs/max98373.c:924:2-27: WARNING: Assignment of bool to 0/1 Signed-off-by: Pierre-Louis Bossart ---

[PATCH 05/21] ASoC: rt5645: remove unused mux define

2019-01-04 Thread Pierre-Louis Bossart
From: Bard liao rt5645_if3_adc_in_mux, rt5645_inr_mux, and rt5645_inl_mux are not used. Remove them from the driver. Signed-off-by: Bard liao Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt5645.c | 36 1 file changed, 36 deletions(-) diff

[PATCH 06/21] ASoC: rt5670: remove unused mux/mixer define

2019-01-04 Thread Pierre-Louis Bossart
From: Bard liao Some mux/mixer are not used. Remove them from the driver. Signed-off-by: Bard liao Signed-off-by: Pierre-Louis Bossart --- sound/soc/codecs/rt5670.c | 54 --- 1 file changed, 54 deletions(-) diff --git a/sound/soc/codecs/rt5670.c

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5

2019-01-04 Thread Brian Norris
Hi again, On Thu, Jan 03, 2019 at 04:11:58PM -0800, Brian Norris wrote: > On Thu, Jan 03, 2019 at 04:01:45PM -0800, Bjorn Andersson wrote: > > I share your concern about this, but I came to suggest this as the > > driver cares about platforms but the firmware is (often?) > >

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > Currently there's still some bugs to be investigated, with communication > stalling on one device and another reading the radio versions wrong > (07 / 1f instead of 21, also observed on spi once). Reproducable 100% on SPI by setting REGCACHE_RBTREE

Re: [PATCH 1/3] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips

2019-01-04 Thread Brian Masney
On Fri, Jan 04, 2019 at 04:25:23PM -0800, Stephen Boyd wrote: > > + /* > > +* Check to see if the hwirq is already associated with another > > virq on > > +* this IRQ domain. If so, then disassociate it before associating > > the > > +* hwirq with the new virq. IRQs

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > diff --git a/drivers/net/lora/sx130x_picogw.c > b/drivers/net/lora/sx130x_picogw.c > new file mode 100644 > index ..577f9fb71d46 > --- /dev/null > +++ b/drivers/net/lora/sx130x_picogw.c [...] > + serdev_device_set_baudrate(sdev,

Re: KMSAN: uninit-value in mpol_rebind_mm

2019-01-04 Thread Andrew Morton
On Fri, 4 Jan 2019 09:50:31 +0100 Vlastimil Babka wrote: > > Yes, it doesn't and it's not trivial to do. The tool reports uses of > > unint _values_. Values don't necessary reside in memory. It can be a > > register, that come from another register that was calculated as a sum > > of two other

Re: [RFC][PATCH] hwmon: (ina2xx) Improve current and power reading precision

2019-01-04 Thread Nicolin Chen
Hi Stefan, Sorry for a super late reply. I took a long vacation. On Wed, Nov 21, 2018 at 10:16:09PM +, Brüns, Stefan wrote: > > > Another concern may be voltage drop over the shunt, but for this case you > > > have a nominal voltage of 1.8V, so 30uV are 0.001%. > > > > > > > When measuring

Re: [PATCH] Display CHECK files like CC files

2019-01-04 Thread Masahiro Yamada
Hi Matthew, On Thu, Jan 3, 2019 at 12:41 AM Matthew Wilcox wrote: > > When building with O= and C=1, this output looks weird: > > CC fs/file_table.o > CHECK ../fs/file_table.c > CC fs/open.o > CHECK ../fs/open.c > CC fs/super.o > CHECK ../fs/super.c > CC

Re: ZDNet article on GPL is wrong and misleading. PJ (paralegal) does not fully understand the law she's spoke about.

2019-01-04 Thread Jason C. Wells
Please CC trim the freebsd lists. This is not our jam. BTW, cross posting was never socially acceptable so please don't. Suddenly, I feel sorry for Mr. Moglen and Mr. Raymond. I can image 20 years of this sort of nonsense in your mailboxes. Cheers for all the good stuff you've done for FOSS.

Re: [PATCH 3/7] dt-bindings: riscv: cpus: add E51 cores to the list of documented CPUs

2019-01-04 Thread Rob Herring
On Fri, Jan 4, 2019 at 4:46 PM Palmer Dabbelt wrote: > > On Thu, 20 Dec 2018 13:01:41 PST (-0800), r...@kernel.org wrote: > > On Fri, Dec 14, 2018 at 09:21:50PM -0800, Paul Walmsley wrote: > >> Add compatible strings for the SiFive E51 family of CPU cores to the > >> RISC-V CPU compatible string

Re: [PATCH v2 2/2] mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)

2019-01-04 Thread Olof Johansson
On Wed, Jan 2, 2019 at 9:58 PM Faiz Abbas wrote: > > Hi Olof, Eduardo, > > On 03/01/19 1:26 AM, Eduardo Valentin wrote: > > On Wed, Jan 02, 2019 at 10:29:31AM -0800, Olof Johansson wrote: > >> Hi, > >> > >> > >> On Wed, Dec 12, 2018 at 1:20 AM Ulf Hansson wrote: > >>> > >>> + Thermal maintainers

[PATCH] drivers: platform: goldfish_sync: add a driver

2019-01-04 Thread rkir
From: Roman Kiryanov The Goldfish sync driver is designed to provide a interface between the underlying host's sync device and the kernel's fence sync framework. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/Kconfig | 7 + drivers/platform/goldfish/Makefile

[PATCH 2/2] hwmon: (ina3221) Implement ti,single-shot DT property

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. The DT binding doc is updated with a new boolean type property to allow changing the default operating mode from

[PATCH 1/2] dt-bindings: hwmon: ina3221: Add ti,single-shot property

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. This patch adds a "ti,single-shot" property to allow changing the default continuous mode to single-shot

[PATCH 0/2] hwmon (ina3221) Add single-shot mode support

2019-01-04 Thread Nicolin Chen
By default, ina3221, as a hardware monitor, continuously measures the inputs and generates corresponding data. However, for battery powered devices, this mode might be power consuming. This series of patches add a feature of changing default operating mode to its single-shot mode via DT. Nicolin

Re: [RFC PATCH] media: rcar-vin: Allow independent VIN link enablement

2019-01-04 Thread Steve Longerbeam
Hi Niklas, How about a patch that simply replaces the entity use_count check with a stream_count check? As in: diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index f0719ce24b97..aef8d8dab6ab 100644 ---

Re: [v2 PATCH 3/5] mm: memcontrol: introduce wipe_on_offline interface

2019-01-04 Thread Shakeel Butt
On Fri, Jan 4, 2019 at 4:21 PM Yang Shi wrote: > > We have some usecases which create and remove memcgs very frequently, > and the tasks in the memcg may just access the files which are unlikely > accessed by anyone else. So, we prefer force_empty the memcg before > rmdir'ing it to reclaim the

Re: [v2 PATCH 2/5] mm: memcontrol: do not try to do swap when force empty

2019-01-04 Thread Shakeel Butt
On Fri, Jan 4, 2019 at 4:21 PM Yang Shi wrote: > > The typical usecase of force empty is to try to reclaim as much as > possible memory before offlining a memcg. Since there should be no > attached tasks to offlining memcg, the tasks anonymous pages would have > already been freed or uncharged.

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-04 Thread Vesa Jääskeläinen
Hi Jacek, On 04/01/2019 23.37, Jacek Anaszewski wrote: But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single register write. How would you propose to address that? You could model it to something like this in

Re: [GIT PULL] sound updates for 4.21

2019-01-04 Thread Azat Khuzhin
> This is unfortunately a known issue with this driver, Takashi and I had > a couple of email threads on this. Even without errors removing the > module doesn't seem to release all resources. I don't like this at all, > and for the Sound Open Firmware (SOF) driver I mandated module > load-unload

Re: [RFC PATCH V3 1/5] vhost: generalize adding used elem

2019-01-04 Thread Sean Christopherson
On Fri, Jan 04, 2019 at 04:29:34PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 29, 2018 at 08:46:52PM +0800, Jason Wang wrote: > > Use one generic vhost_copy_to_user() instead of two dedicated > > accessor. This will simplify the conversion to fine grain > > accessors. About 2% improvement of

Re: [REGRESSION, BISECTED] pci: nvme device with HMB fails on arm64

2019-01-04 Thread Liviu Dudau
On Fri, Jan 04, 2019 at 06:34:47PM +0100, Christoph Hellwig wrote: > Hi Liviu, Hi Christoph, > > please try the patch below. Note that this is in top of mainline, > as the commit you found already needed another fixup, which has > made it to Linus already. This patch does fix the issue with

Re: [PATCH 1/3] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips

2019-01-04 Thread Stephen Boyd
Quoting Brian Masney (2018-12-29 03:47:53) > Convert the spmi-pmic-arb IRQ code to use the version 2 IRQ interface > in order to support hierarchical IRQ chips. Code was tested on a LG > Nexus 5 (hammerhead) phone. Can you add the motivation for this change here? Why should we care? > >

[v2 PATCH 1/5] doc: memcontrol: fix the obsolete content about force empty

2019-01-04 Thread Yang Shi
We don't do page cache reparent anymore when offlining memcg, so update force empty related content accordingly. Reviewed-by: Shakeel Butt Acked-by: Michal Hocko Cc: Johannes Weiner Signed-off-by: Yang Shi --- Documentation/cgroup-v1/memory.txt | 7 --- 1 file changed, 4 insertions(+), 3

[v2 PATCH 2/5] mm: memcontrol: do not try to do swap when force empty

2019-01-04 Thread Yang Shi
The typical usecase of force empty is to try to reclaim as much as possible memory before offlining a memcg. Since there should be no attached tasks to offlining memcg, the tasks anonymous pages would have already been freed or uncharged. Even though anonymous pages get swapped out, but they

[v2 PATCH 3/5] mm: memcontrol: introduce wipe_on_offline interface

2019-01-04 Thread Yang Shi
We have some usecases which create and remove memcgs very frequently, and the tasks in the memcg may just access the files which are unlikely accessed by anyone else. So, we prefer force_empty the memcg before rmdir'ing it to reclaim the page cache so that they don't get accumulated to incur

[v2 PATCH 4/5] mm: memcontrol: bring force_empty into default hierarchy

2019-01-04 Thread Yang Shi
The default hierarchy doesn't support force_empty, but there are some usecases which create and remove memcgs very frequently, and the tasks in the memcg may just access the files which are unlikely accessed by anyone else. So, we prefer force_empty the memcg before rmdir'ing it to reclaim the

[v2 PATCH 5/5] doc: memcontrol: add description for wipe_on_offline

2019-01-04 Thread Yang Shi
Add desprition of wipe_on_offline interface in cgroup documents. Cc: Michal Hocko Cc: Johannes Weiner Signed-off-by: Yang Shi --- Documentation/admin-guide/cgroup-v2.rst | 9 + Documentation/cgroup-v1/memory.txt | 10 ++ 2 files changed, 19 insertions(+) diff --git

[RFC v2 PATCH 0/5] mm: memcontrol: do memory reclaim when offlining

2019-01-04 Thread Yang Shi
We have some usecases which create and remove memcgs very frequently, and the tasks in the memcg may just access the files which are unlikely accessed by anyone else. So, we prefer force_empty the memcg before rmdir'ing it to reclaim the page cache so that they don't get accumulated to incur

Re: "flip_done timed out" messages causing huge increase in boot time

2019-01-04 Thread Daniel Kamil Kozar
I should really get to bed ... of course, I meant 516a49cc19467e298d08a404f73a6e311f4548d1 ;-) On Sat, 5 Jan 2019 at 01:16, Daniel Kamil Kozar wrote: > > Small omission on my part : I meant 4.19.12, not 4.19.2 as the last > working version. > Also, I can confirm that reverting >

Re: "flip_done timed out" messages causing huge increase in boot time

2019-01-04 Thread Daniel Kamil Kozar
Small omission on my part : I meant 4.19.12, not 4.19.2 as the last working version. Also, I can confirm that reverting 13947d150bae871bd880565ada318b0bcd0e690e from the current HEAD of linux-stable fixes the issue. On Sat, 5 Jan 2019 at 00:47, Daniel Kamil Kozar wrote: > > Hello. > After

  1   2   3   4   5   6   7   >