Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Linus Torvalds
[ Crossed emails ] On Sat, Jan 5, 2019 at 12:12 PM Jiri Kosina wrote: > > I am still not completely sure what to return in such cases though; we can > either blatantly lie and always pretend that the pages are resident That's what my untested patch did. Or maybe just claim they are all not

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Linus Torvalds
On Sat, Jan 5, 2019 at 11:46 AM Linus Torvalds wrote: > > Can we please just limit it to vma's that are either anonymous, or map > a file that the user actually owns? .. or slightly simpler: a file that the user opened for writing. IOW, some (TOTALLY UNTESTED!) patch like this?

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Jiri Kosina
On Sat, 5 Jan 2019, Linus Torvalds wrote: > > There are possibilities [1] how mincore() could be used as a converyor of > > a sidechannel information about pagecache metadata. > > Can we please just limit it to vma's that are either anonymous, or map > a file that the user actually owns? > >

Re: [PATCH v6] arm64: implement ftrace with regs

2019-01-05 Thread Steven Rostedt
On Sat, 5 Jan 2019 12:05:43 +0100 Torsten Duwe wrote: > > My point is: those 2 insn will _never_ be split by any alignment > > boundary > 8; does that mean anything, have you considered this? > > Forget that. Steve mentioned the keyword *interrupt*, which creates a > completely different

[PATCH] v2 pm: clk: fix a missing check of clk_prepare

2019-01-05 Thread Aditya Pakki
clk_prepare() could fail, so let's check its status, and if it fails, issue an error message and change the clock_entry_status to PCE_STATUS_ERROR Signed-off-by: Aditya Pakki --- drivers/base/power/clock_ops.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[4.19-stable PATCH 2/2] dax: Use non-exclusive wait in wait_entry_unlocked()

2019-01-05 Thread Dan Williams
commit d8a706414af4827fc0b4b1c0c631c607351938b9 upstream. get_unlocked_entry() uses an exclusive wait because it is guaranteed to eventually obtain the lock and follow on with an unlock+wakeup cycle. The wait_entry_unlocked() path does not have the same guarantee. Rather than open-code an extra

Re: [PATCH v9 14/27] pwm: jz4740: Improve algorithm of clock calculation

2019-01-05 Thread Uwe Kleine-König
On Thu, Dec 27, 2018 at 07:13:06PM +0100, Paul Cercueil wrote: > The previous algorithm hardcoded details about how the TCU clocks work. > The new algorithm will use clk_round_rate to find the perfect clock rate > for the PWM channel. > > Signed-off-by: Paul Cercueil > --- > > Notes: > v9:

[4.19-stable PATCH 1/2] dax: Don't access a freed inode

2019-01-05 Thread Dan Williams
From: Matthew Wilcox commit 55e56f06ed71d9441f3abd5b1d3c1a870812b3fe upstream. After we drop the i_pages lock, the inode can be freed at any time. The get_unlocked_entry() code has no choice but to reacquire the lock, so it can't be used here. Create a new wait_entry_unlocked() which takes

[4.19-stable PATCH 0/2] dax: Don't access a freed inode

2019-01-05 Thread Dan Williams
The original upstream fix, commit 55e56f06ed71 "dax: Don't access a freed inode", prompted an immediate cleanup request. Now that the cleanup has landed, commit d8a706414af4 "dax: Use non-exclusive wait in wait_entry_unlocked()", backport them both to -stable. --- Dan Williams (1): dax:

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread kbuild test robot
Hi Jiri, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input

2019-01-05 Thread Andrew Lunn
On Sat, Jan 05, 2019 at 06:39:02PM +, Bernd Edlinger wrote: > gain control when no beacon was received in the connected state Hi Bernd Your patch subject line is too long, so it got chopped in half. Please use something shorter. Andrew

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-4.21-2 tag

2019-01-05 Thread Linus Torvalds
On Sat, Jan 5, 2019 at 3:53 AM Michael Ellerman wrote: > > powerpc: Drop use of 'type' from access_ok() (2019-01-04 23:07:59 +1100) > > I see you've fixed this in your tree already. No problem. It was my mess-up to begin with, and I just did the obvious resolution (only difference between our

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Linus Torvalds
On Sat, Jan 5, 2019 at 9:27 AM Jiri Kosina wrote: > > From: Jiri Kosina > > There are possibilities [1] how mincore() could be used as a converyor of > a sidechannel information about pagecache metadata. Can we please just limit it to vma's that are either anonymous, or map a file that the user

Re: [PATCH v9 13/27] pwm: jz4740: Use clocks from TCU driver

2019-01-05 Thread Uwe Kleine-König
Hello, On Thu, Dec 27, 2018 at 07:13:05PM +0100, Paul Cercueil wrote: > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > index 4ed003bc3d8d..0343f0c1238e 100644 > --- a/drivers/pwm/Kconfig > +++ b/drivers/pwm/Kconfig > @@ -202,7 +202,8 @@ config PWM_IMX > config PWM_JZ4740 >

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread kbuild test robot
Hi Jiri, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20 next-20190103] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v9 12/27] pwm: jz4740: Use regmap from TCU driver

2019-01-05 Thread Uwe Kleine-König
On Thu, Dec 27, 2018 at 07:13:04PM +0100, Paul Cercueil wrote: > The ingenic-timer "TCU" driver provides us with a regmap, that we can > use to safely access the TCU registers. > > While this driver is devicetree-compatible, it is never (as of now) > probed from devicetree, so this change does

Re: [GIT PULL] arch/h8300 update

2019-01-05 Thread Linus Torvalds
On Sat, Jan 5, 2019 at 1:34 AM Yoshinori Sato wrote: > > git://git.sourceforge.jp/gitroot/uclinux-h8/linux.git tags/for-4.21 New signing key? That's ok, but please sign it with your old one unless there's some major reason you can't (ie "oops, I've lost the old one"). And yes, I see that the

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Vlastimil Babka
On 5.1.2019 20:24, Jiri Kosina wrote: > On Sat, 5 Jan 2019, Vlastimil Babka wrote: > >>> There are possibilities [1] how mincore() could be used as a converyor of >>> a sidechannel information about pagecache metadata. >>> >>> Provide vm.mincore_privileged sysctl, which makes it possible to

Re: [git pull] vfs.git mount.part1

2019-01-05 Thread Eric W. Biederman
Al Viro writes: > mount API prereqs. Mostly that's LSM mount options cleanups. > One trivial conflict in security/selinux/hooks.c, resolved by taking > the variant from this branch - the method has been split, leaving > only the part that used to be conditional upon "it's not an internal

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Jiri Kosina
On Sat, 5 Jan 2019, Vlastimil Babka wrote: > > There are possibilities [1] how mincore() could be used as a converyor of > > a sidechannel information about pagecache metadata. > > > > Provide vm.mincore_privileged sysctl, which makes it possible to mincore() > > start returning -EPERM in case

Re: [PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Vlastimil Babka
On 5.1.2019 18:27, Jiri Kosina wrote: > From: Jiri Kosina > > There are possibilities [1] how mincore() could be used as a converyor of > a sidechannel information about pagecache metadata. > > Provide vm.mincore_privileged sysctl, which makes it possible to mincore() > start returning -EPERM

[PATCH] v2 bakclight: fix missing checks in ambient_light_zone_store

2019-01-05 Thread Aditya Pakki
In adp8870_bl_ambient_light_zone_store, set, clear, and write can return an error but are not checked. The fix adds a check for these cases and returns -1 to match the return type (ssize_t). Signed-off-by: Aditya Pakki --- drivers/video/backlight/adp8870_bl.c | 16 +--- 1 file

[PATCH v2 3/4] rtlwifi: rtl8723ae: Re-introduce

2019-01-05 Thread Bernd Edlinger
rtl8723e_dm_refresh_rate_adaptive_mask This function was present in a previous version of the code base, it works just fine for me -- as long as it is not using stale data. Fixed a style nit in rtl8723e_dm_init_rate_adaptive_mask. Signed-off-by: Bernd Edlinger ---

[PATCH v2 4/4] rtlwifi: Move the clearing of

2019-01-05 Thread Bernd Edlinger
rtlpriv->link_info.num_rx_inperiod in rtl_watchdog_wq_callback a few lines down This is necessary since it is still used in the "AP off" detection code block. Moved clearing of rtlpriv->link_info.num_rx_inperiod as well for consistency. Signed-off-by: Bernd Edlinger ---

[PATCH v2 2/4] rtlwifi: rtl8723ae: Don't use dm.undec_sm_pwdb for input

2019-01-05 Thread Bernd Edlinger
gain control when no beacon was received in the connected state When no beacon was received, the value in dm.undec_sm_pwdb is most likely out of date and should not be used to adjust the input path. Assume instead that the signal level is low. Fix the state machine in

[PATCH v2 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-05 Thread Bernd Edlinger
This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0 ("rtlwifi: Fix logic error in enter/exit

[PATCH v2 0/4] rtlwifi: Fix issues with rtl8723ae

2019-01-05 Thread Bernd Edlinger
Currently the rtl8723ae driver is broken (since v4.7). Connection to AP is lost very often, especially when the signal level is not very good. The main issue is the power save mode is basically not working, and seems to trigger a firmware bug. So I had to take out the FW LPS mode handling.

Re: [GIT PULL 1/4] Kbuild updates for v4.21

2019-01-05 Thread Linus Torvalds
Masahiro, this isn't really related to the your request, but to just another pull request that caused much more of a rebuild than I expected. Doing a "make --debug", I see that the cause was that it touched include/uapi/linux/elf-em.h, and make says things like Prerequisite

[PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-05 Thread Randy Li
It offers an example how a full features video codec should be configured. The original clocks assignment don't look good, if the clocks lower than 300MHZ, most of decoing tasks would suffer from timeout problem, 500MHZ is also a little high for RK3399 running in a stable state. Signed-off-by:

[PATCH 1/4] staging: video: rockchip: video codec for vendor API

2019-01-05 Thread Randy Li
Signed-off-by: Randy Li --- drivers/staging/rockchip-mpp/Kconfig | 52 + drivers/staging/rockchip-mpp/Makefile | 16 + drivers/staging/rockchip-mpp/mpp_debug.h | 87 ++ drivers/staging/rockchip-mpp/mpp_dev_common.c | 971 ++

[PATCH 3/4] staging: video: rockchip: add video codec

2019-01-05 Thread Randy Li
Signed-off-by: Randy Li --- drivers/staging/Kconfig | 2 ++ drivers/staging/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index e4f608815c05..81634dd0a283 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@

[PATCH 2/4] staging: video: rockchip: fixup for upstream

2019-01-05 Thread Randy Li
Fixing those deprecated function from vendor kernel. Removing those features don't exist in upstream kernel. Signed-off-by: Randy Li --- drivers/staging/rockchip-mpp/mpp_dev_common.c | 12 ++-- drivers/staging/rockchip-mpp/mpp_dev_common.h | 2 +-

[PATCH 0/4] Rockchip: the vendor video codec for reference

2019-01-05 Thread Randy Li
Those patches are not for merging, I won't dream on it. As I said in previous email, this driver is used for checking the status of the other drivers. I have checked this driver would memory dump, its output looks well. The reason I didn't use the video output is VOP driver doesn't work well.

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-05 Thread Noralf Trønnes
Den 24.12.2018 16.03, skrev Peter Wu: On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls

Re: [PATCH] Staging: iio: ad7192: replaced bool in struct

2019-01-05 Thread Jonathan Cameron
On Sat, 22 Dec 2018 21:58:25 -0500 indigo omega wrote: > Hello Jonathan, > > I'd be happy to help cleanup this driver, and I'd greatly appreciate some > direction as to what needs to be done. > > Thank you, > > Amir Ghorbanian Sure, I'll give the current state a quick review... Major items

Re: [PATCH v3 4/4] arm64: dts: actions: s700-cubieboard7: Enable I2C0 and I2C1

2019-01-05 Thread Manivannan Sadhasivam
On Tue, Dec 11, 2018 at 09:04:48AM +0100, Parthiban Nallathambi wrote: > Add pinctrl definitions for Actions Semiconductor S700 I2C controllers. > Pinctrl definitions are only available for I2C0, I2C1 and I2C2. > Enable I2C0 (PMIC), I2C1 (gyro, touchscreen) in cubieboard7. > > Signed-off-by:

Re: [PATCH v3 2/4] arm64: dts: actions: s700: Add I2C controller nodes

2019-01-05 Thread Manivannan Sadhasivam
On Tue, Dec 11, 2018 at 09:04:46AM +0100, Parthiban Nallathambi wrote: > Add I2C controller nodes for Actions Semiconductor S700 SoC. > > Signed-off-by: Parthiban Nallathambi > Reviewed-by: Manivannan Sadhasivam Applied to dt-next branch where I have been collecting patches for Andreas.

Re: [PATCH v2 4/4] staging: iio: adt7316: fix the dac write calculation

2019-01-05 Thread Jonathan Cameron
On Sat, 22 Dec 2018 21:57:43 -0700 Jeremy Fertic wrote: > The lsb calculation is not masking the correct bits from the user input. > Subtract 1 from (1 << offset) to correctly set up the mask to be applied > to user input. > > The lsb register stores its value starting at the bit 7 position. >

Re: [PATCH v2 3/4] staging: iio: adt7316: fix the dac read calculation

2019-01-05 Thread Jonathan Cameron
On Sat, 22 Dec 2018 21:57:42 -0700 Jeremy Fertic wrote: > The calculation of the current dac value is using the wrong bits of the > dac lsb register. Create two macros to shift the lsb register value into > lsb position, depending on whether the dac is 10 or 12 bit. Initialize > data to 0 so,

Re: [PATCH v2 2/4] staging: iio: adt7316: fix handling of dac high resolution option

2019-01-05 Thread Jonathan Cameron
On Sat, 22 Dec 2018 21:57:41 -0700 Jeremy Fertic wrote: > The adt7316/7 and adt7516/7 have the option to output voltage proportional > to temperature on dac a and/or dac b. The default dac resolution in this > mode is 8 bits with the dac high resolution option enabling 10 bits. None > of these

Re: [RFC PATCH 3/3] selftests/vm: add script helper for CONFIG_TEST_VMALLOC_MODULE

2019-01-05 Thread Uladzislau Rezki
On Fri, Jan 04, 2019 at 11:34:30AM -0700, shuah wrote: > On 1/3/19 7:21 AM, Uladzislau Rezki (Sony) wrote: > > Add the test script for the kernel test driver to analyse vmalloc > > allocator for benchmarking and stressing purposes. It is just a kernel > > module loader. You can specify and pass

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-05 Thread Jason Gunthorpe
On Fri, Jan 04, 2019 at 02:44:01PM +1100, David Gibson wrote: > On Thu, Dec 06, 2018 at 08:45:09AM +0200, Leon Romanovsky wrote: > > On Thu, Dec 06, 2018 at 03:19:51PM +1100, David Gibson wrote: > > > Mellanox ConnectX-5 IB cards (MT27800) seem to cause a call trace when > > > unbound from their

Re: [PATCH v2 1/4] staging: iio: adt7316: fix dac_bits assignment

2019-01-05 Thread Jonathan Cameron
+ CC Shreeya who is working on the same driver. On Sat, 22 Dec 2018 21:57:40 -0700 Jeremy Fertic wrote: > The value of dac_bits is used in adt7316_show_DAC() and adt7316_store_DAC(), > and it should be either 8, 10, or 12 bits depending on the device in use. The > driver currently only assigns

[PATCH 2/3] arm64: dts: rockchip: add power domain to iommu rk3399

2019-01-05 Thread Randy Li
IOMMU device won't work without power unless PMU can't turn it off. Signed-off-by: Randy Li --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index

[PATCH 1/3] clk: rockchip: add video clk parents for rk3399

2019-01-05 Thread Randy Li
Video codec won't work properly with a clock too low nor too high. We need to export them, allowing the device tree to assign a suitable clocks for them. Signed-off-by: Randy Li --- drivers/clk/rockchip/clk-rk3399.c | 5 +++-- include/dt-bindings/clock/rk3399-cru.h | 2 ++ 2 files changed,

[PATCH 0/3] The basic patches for rockchip video codec

2019-01-05 Thread Randy Li
I will post a driver for video codec using the vendor userspace interface. It is not used for merging but checking the work status of the other devices and pre-patches need to be merged. Without the following modification, video codec can't work properly. I check the status of the upstream kernel

[PATCH 3/3] soc: rockchip: power-domain: export idle request

2019-01-05 Thread Randy Li
We need to put the power status of HEVC IP into IDLE unless we can't reset that IP or the SoC would crash down. rockchip_pmu_idle_request(dev, true)---> enter idle rockchip_pmu_idle_request(dev, false)---> exit idle Signed-off-by: Caesar Wang Signed-off-by: Jeffy Chen Signed-off-by: Randy Li

Re: [PATCH V6] iio: magnetometer: mag3110: add vdd/vddio regulator operation support

2019-01-05 Thread Jonathan Cameron
On Sun, 23 Dec 2018 06:12:30 + Anson Huang wrote: > The magnetometer's power supplies could be controllable on some platforms, > such as i.MX6Q-SABRESD board, the mag3110's power supplies are controlled > by a GPIO fixed regulator, need to make sure the regulators are enabled > before any

[PATCH V2] usbcore: Select only first configuration for non-UAC3 compliant devices

2019-01-05 Thread saranya . gopal
From: Saranya Gopal In most of the UAC1 and UAC2 audio devices, the first configuration is most often the best configuration. However, with recent patch to support UAC3 configuration, second configuration was unintentionally chosen for some of the UAC1/2 devices that had more than one

Re: [PATCH V8] iio: light: isl29018: add vcc regulator operation support

2019-01-05 Thread Jonathan Cameron
On Sun, 23 Dec 2018 06:46:32 + Anson Huang wrote: > The light sensor's power supply could be controllable by regulator > on some platforms, such as i.MX6Q-SABRESD board, the light sensor > isl29023's power supply is controlled by a GPIO fixed regulator, > need to make sure the regulator is

Re: 047fb56f7e ("blk-mq: fix changelog"): BUG: unable to handle kernel NULL pointer dereference at 00000030

2019-01-05 Thread Greg Kroah-Hartman
On Sun, Jan 06, 2019 at 01:18:42AM +0800, kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > debugfs_cleanup > > commit

Re: [PATCH V6 2/2] iio: accell: mma8452: add vdd/vddio regulator operation support

2019-01-05 Thread Jonathan Cameron
On Sun, 23 Dec 2018 09:02:32 + Anson Huang wrote: > The accelerometer's power supply could be controllable on some > platforms, such as i.MX6Q-SABRESD board, the mma8451's power supplies > are controlled by a GPIO fixed regulator, need to make sure the > regulators are enabled before any

[PATCH] mm/mincore: allow for making sys_mincore() privileged

2019-01-05 Thread Jiri Kosina
From: Jiri Kosina There are possibilities [1] how mincore() could be used as a converyor of a sidechannel information about pagecache metadata. Provide vm.mincore_privileged sysctl, which makes it possible to mincore() start returning -EPERM in case it's invoked by a process lacking

Re: [PATCH] Staging: iio: adt7316: Add regmap support

2019-01-05 Thread Jonathan Cameron
+CC Jeremy who is also working with this device. On Sun, 23 Dec 2018 19:32:24 +0530 Shreeya Patel wrote: > Both i2c and spi drivers have functions for reading and writing > to/from registers. Remove this redundant and common code by using > regmap API. > Also remove multi_read and multi_write

[PATCH] [v2]RDMA: add checks for the status of nla_put in ib_nl_send_msg

2019-01-05 Thread Aditya Pakki
The fix inserts multiple checks for nla_put, and changes the return type of ib_nl_set_path_rec_attrs() from void to int Signed-off-by: Aditya Pakki --- drivers/infiniband/core/sa_query.c | 56 -- 1 file changed, 38 insertions(+), 18 deletions(-) diff --git

Re: [PATCH 4/4] pmbus (dps650ab): add power supply driver

2019-01-05 Thread Guenter Roeck
On Fri, Jan 04, 2019 at 05:05:27PM +0800, Xiaoting Liu wrote: > The Delta dps650ab provides main power and standby power to server. > dps650ab can be detected by MFR_ID and MFR_MODEL referring to > manufacturer's feedback. This patch adds driver to moniter power > supply status. > Another

[PATCH] ver_linux: Assign constant RE to variable name for clarity

2019-01-05 Thread Alexander Kapshuk
The regular expression that matches the version number of a utility being queried is used as a constant expression in the current implementation. Assigning the RE in question to a variable gives it a meaningful name that clearly expresses the intended use of the expression without having to think

Re: [PATCH v1 1/2] dt-binding: iio: add NPCM ADC documentation

2019-01-05 Thread Jonathan Cameron
On Mon, 24 Dec 2018 18:47:54 +0200 Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM Analog-to-Digital Converter(ADC). > > Signed-off-by: Tomer Maimon > --- > .../bindings/iio/adc/nuvoton,npcm-adc.txt | 35 > ++ > 1 file

Re: [PATCH] iio: chemical: sps30: allow changing self cleaning period

2019-01-05 Thread Jonathan Cameron
On Wed, 26 Dec 2018 20:30:35 +0100 Tomasz Duszynski wrote: > Sensor can periodically trigger self cleaning. Period can be changed by > writing a new value to a dedicated attribute. Upon attribute read > triplet representing respectively current, minimum and maximum period is > returned. > >

[PATCH] tipc: fix memory leak in tipc_nl_compat_publ_dump

2019-01-05 Thread Gustavo A. R. Silva
There is a memory leak in case genlmsg_put fails. Fix this by freeing *args* before return. Addresses-Coverity-ID: 1476406 ("Resource leak") Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put") Signed-off-by: Gustavo A. R. Silva --- net/tipc/netlink_compat.c | 4 +++- 1 file

Re: [PATCH] iio: adc: xilinx: check return value of xadc_write_adc_reg

2019-01-05 Thread Jonathan Cameron
On Thu, 3 Jan 2019 12:16:49 +0100 Michal Simek wrote: > On 27. 12. 18 20:54, Aditya Pakki wrote: > > In function xadc_probe, xadc_write_adc_reg can return an error value > > when write fails. The fix checks for the return value consistent with > > other invocations of the latter function. > > >

Re: [PATCH 2/2] iio: adc: meson-saradc: enable the temperature sensor two more SoCs

2019-01-05 Thread Jonathan Cameron
On Thu, 27 Dec 2018 22:50:20 +0100 Martin Blumenstingl wrote: > Meson8b and Meson8m2 use the same logic to convert the ADC register > value to celsius, which is different from Meson8: > - Meson8 has different multiplier and divider values > - Meson8 uses a 4-bit TSC (temperature sensor

Re: [PATCH 2/2] iio: adc: meson-saradc: enable the temperature sensor two more SoCs

2019-01-05 Thread Jonathan Cameron
On Thu, 27 Dec 2018 22:50:20 +0100 Martin Blumenstingl wrote: > Meson8b and Meson8m2 use the same logic to convert the ADC register > value to celsius, which is different from Meson8: > - Meson8 has different multiplier and divider values > - Meson8 uses a 4-bit TSC (temperature sensor

Re: [PATCH 1/2] dt-bindings: iio: adc: meson-saradc: update temperature sensor support

2019-01-05 Thread Jonathan Cameron
On Thu, 3 Jan 2019 17:02:09 -0600 Rob Herring wrote: > On Thu, 27 Dec 2018 22:50:19 +0100, Martin Blumenstingl wrote: > > Meson8b and Meson8m2 use a 5-bit wide TSC (temperature sensor > > coefficient). The SAR ADC registers however can only store (the lower) > > 4 bits. The fifth (upper-most)

Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-05 Thread Larry Finger
On 1/5/19 10:30 AM, Bernd Edlinger wrote: On 1/5/19 5:13 PM, Larry Finger wrote: but this works: modprobe rtl8723ae debug_mask=0x debug_level=5 swlps=1 fwlps=0 Yes, I think that is a better thing to do now. If and when Realtek finds a firmware bug, and when the new firmware is

Re: [PATCH v2] ARM: Remove '-p' from LDFLAGS

2019-01-05 Thread Nicolas Pitre
On Mon, 31 Dec 2018, Nathan Chancellor wrote: > This option is not supported by lld: > > ld.lld: error: unknown argument: -p > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > that tree). Given that the lowest officially supported of binutils for > the kernel is

Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-05 Thread Bernd Edlinger
On 1/5/19 5:13 PM, Larry Finger wrote: >> but this works: >> >> modprobe rtl8723ae debug_mask=0x debug_level=5 swlps=1 fwlps=0 > > Yes, I think that is a better thing to do now. If and when Realtek finds a > firmware bug, and when the new firmware is readily available, then there will >

Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-05 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:06 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:08AM +0500, Ivan Mironov wrote: > > Strict requirement of pixclock to be zero breaks support of SDL 1.2 > > which contains hardcoded table of supported video modes with non-zero > > pixclock values[1]. > > > >

[PATCH] [V2] infiniband: fix a missing check of nla_put

2019-01-05 Thread Aditya Pakki
nla_put() may fail. The fix adds a check for its return value, and returns -EMSGSIZE if it fails, post canceling netlink msg. Signed-off-by: Aditya Pakki --- drivers/infiniband/core/addr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/addr.c

Re: [PATCH v2 3/3] ARM: spinlock: use unified assembler language syntax

2019-01-05 Thread Nicolas Pitre
On Thu, 3 Jan 2019, Stefan Agner wrote: > Convert the conditional infix to a postfix to make sure this inline > assembly is unified syntax. Since gcc assumes non-unified syntax > when emitting ARM instructions, make sure to define the syntax as > unified. > > This allows to use LLVM's integrated

Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-05 Thread Larry Finger
On 1/5/19 5:31 AM, Bernd Edlinger wrote: On 1/5/19 3:44 AM, Larry Finger wrote: On 1/4/19 6:48 AM, Bernd Edlinger wrote: This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-05 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > > SDL 1.2 sets all fields related to the pixel format to zero in some > > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all > > pixel format changing

Re: [PATCH v2 2/3] ARM: uaccess: use unified assembler language syntax

2019-01-05 Thread Nicolas Pitre
On Thu, 3 Jan 2019, Stefan Agner wrote: > Convert the conditional infix to a postfix to make sure this inline > assembly is unified syntax. Since gcc assumes non-unified syntax > when emitting ARM instructions, make sure to define the syntax as > unified. > > This allows to use LLVM's integrated

[git pull] FireWire (IEEE 1394) update post v4.20

2019-01-05 Thread Stefan Richter
Linus, please pull from the tag "firewire-update" at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git firewire-update to receive the following firewire subsystem patch: - remove an explicit dependency in Kconfig which is implied by another dependency Geert

Re: [PATCH 11/16] tools headers x86: Sync asm/cpufeatures.h copy with the kernel sources

2019-01-05 Thread Paolo Bonzini
On 04/01/19 19:33, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > To get the changes from: > > a0aea130afeb ("KVM: x86: Add CPUID support for new instruction WBNOINVD") Slightly better commit: 08e823c2c589 ("x86/cpufeatures: Add WBNOINVD feature definition")

<<>

2019-01-05 Thread Mr Owen Peter
Good Day, Hope you are doing great Today.I have a proposed BUSINESS DEAL that will benefit both parties. This is legitimate,legal and your personality will not be compromised.Please Reply to me ONLY if you are interested and consider your self capable for details. Sincerely, Peter OWEN

Re: [PATCH v2 1/3] ARM: fix argument count to match macro definition

2019-01-05 Thread Nicolas Pitre
On Thu, 3 Jan 2019, Stefan Agner wrote: > The macro str8w takes 10 arguments, abort being the 10th. In this > particular instantiation the abort argument is passed as 11th > argument leading to an error when using LLVM's integrated > assembler: > :46:47: error: too many positional arguments >

Re: use generic DMA mapping code in powerpc V4

2019-01-05 Thread Christian Zigotzky
Next step: c446404b041130fbd9d1772d184f24715cf2362f (powerpc/dma: remove dma_nommu_mmap_coherent) git clone git://git.infradead.org/users/hch/misc.git -b powerpc-dma.6 a git checkout c446404b041130fbd9d1772d184f24715cf2362f Output: Note: checking out

Re: [PATCH 09/16] tools headers uapi: Sync linux/kvm.h with the kernel sources

2019-01-05 Thread Paolo Bonzini
On 04/01/19 19:33, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo > > To get the changes from these csets: > > 2bc39970e932 ("x86/kvm/hyper-v: Introduce KVM_GET_SUPPORTED_HV_CPUID") > 2a31b9db1535 ("kvm: introduce manual dirty log reprotect") > > That results in these new

Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32

2019-01-05 Thread Larry Finger
On 1/5/19 3:10 AM, Július Milan wrote: Fixes the following sparse warnings: drivers/staging/wilc1000/host_interface.c:2360:30: warning: incorrect type in assignment (different base types) expected restricted __le32 [addressable] [assigned] [usertype] frame_type got restricted __le16

[PATCH] [V2] usb: chipidea: add a check for the availability of next child

2019-01-05 Thread Aditya Pakki
of_get_next_available_child returns NULL when no child nodes are found. The fix checks its return value instead of assuming a child is found. Signed-off-by: Aditya Pakki --- drivers/usb/chipidea/ci_hdrc_msm.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] [v2] netfilter: ipset: fix a missing check of nla_parse

2019-01-05 Thread Aditya Pakki
When nla_parse fails, we should not use the results (the first argument). The fix checks if it fails, and if so, returns its error code upstream. Signed-off-by: Aditya Pakki --- net/netfilter/ipset/ip_set_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[RESEND] x86: Refactor __cmpxchg to cmpxchg in lock_cmos

2019-01-05 Thread Philipp K
It is unusual to reference __cmpxchg() from other files than cmpxchg.h and similar. Instead, cmpxchg() is used, which expands to __cmpxchg() and derives the 'size' parameter automatically with sizeof(*(ptr)). So clean up the lock_cmos() function by using cmpxchg(), without changing the generated

Re: [PATCH] usbcore: Select only first configuration for non-UAC3 compliant devices

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 07:32:37PM +0530, saranya.go...@intel.com wrote: > From: Saranya Gopal > > In most of the UAC1 and UAC2 audio devices, the first > configuration is most often the best configuration. > However, with recent patch to support UAC3 configuration, > second configuration was

Re: [PATCH] drivers: misc: goldfish_address_space: add a driver

2019-01-05 Thread Greg KH
On Sat, Jan 05, 2019 at 01:43:55AM -0800, Roman Kiryanov wrote: > > Why isn't this in drivers/platform/goldfish/ ? > > I was not sure where to put, but this driver is not a platform one, it > is a pci one. You are controlling a "platform" device, the goldfish platform. What makes this different

Re: r8152: data corruption in various scenarios

2019-01-05 Thread Mark Lord
On 2019-01-05 9:14 a.m., Mark Lord wrote: > A couple of years back, I reported data corruption resulting from > a change in kernel 3.16 which enabled hardware checksums in the r8152 driver. > This was happening on an embedded system that was using a r8152 USB dongle. > > At the time, it was very

r8152: data corruption in various scenarios

2019-01-05 Thread Mark Lord
A couple of years back, I reported data corruption resulting from a change in kernel 3.16 which enabled hardware checksums in the r8152 driver. This was happening on an embedded system that was using a r8152 USB dongle. At the time, it was very difficult to figure out what could possibly be

[PATCH] Staging: rts5208: Fix error handling on rtsx_send_cmd

2019-01-05 Thread Aditya Pakki
In sd_execute_write_data, the rtsx_send_cmd could fail with ETIMEDOUT or EIO. The fix adds a check to handle these failures. Signed-off-by: Aditya Pakki --- drivers/staging/rts5208/sd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.c

RE: [alsa-devel] ALSA:usb audio Higher sample rates on usb audio no longer working.

2019-01-05 Thread Gopal, Saranya
Hi Con, Thanks a lot for reporting the issue and also for taking your time to help me with lsusb output and dmesg logs. I have sent a patch in another mail to fix this issue. Could you help by checking if the patch fixes this issue for you? Thanks, Saranya > -Original Message- > From:

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-05 Thread Manivannan Sadhasivam
Hi Vinod, On Sat, Jan 05, 2019 at 07:16:10PM +0530, Vinod Koul wrote: > On 05-01-19, 10:23, Manivannan Sadhasivam wrote: > > On Fri, Jan 04, 2019 at 08:39:34PM -0800, John Stultz wrote: > > > On Fri, Jan 4, 2019 at 8:00 PM Manivannan Sadhasivam > > > wrote: > > > > > > > > Hi John, > > > > > > >

[PATCH] usbcore: Select only first configuration for non-UAC3 compliant devices

2019-01-05 Thread saranya . gopal
From: Saranya Gopal In most of the UAC1 and UAC2 audio devices, the first configuration is most often the best configuration. However, with recent patch to support UAC3 configuration, second configuration was unintentionally chosen for some of the UAC1/2 devices that had more than one

Re: [PATCH 2/8 v2] Documentation: bindings: k3dma: Add binding for dma-avail-chan

2019-01-05 Thread Vinod Koul
On 05-01-19, 10:23, Manivannan Sadhasivam wrote: > On Fri, Jan 04, 2019 at 08:39:34PM -0800, John Stultz wrote: > > On Fri, Jan 4, 2019 at 8:00 PM Manivannan Sadhasivam > > wrote: > > > > > > Hi John, > > > > > > On Fri, Jan 04, 2019 at 12:56:22PM -0800, John Stultz wrote: > > > > Some dma

[PATCH] ASoC: rt5663: Fix error handling of device_property_read_u32_array

2019-01-05 Thread Aditya Pakki
In rt5663_parse_dp, the function device_property_read_u32_array() can return an error. This fix adds a check to the latter as well as to the callsite of rt5663_parse_dp in rt5663_i2c_probe. Signed-off-by: Aditya Pakki --- sound/soc/codecs/rt5663.c | 9 ++--- 1 file changed, 6 insertions(+),

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Jacek Anaszewski
On 1/5/19 1:31 PM, Pavel Machek wrote: We will need to solve RGB leds somehow, hopefully this is solved with it. When? With this attitude we will procrastinate it forever. It's been almost 3 years since first HSV patches. I proposed rough design of LED RGB class interface in [0]. If you find

Introducing Racoh Computer design suggestion/ Uxxuw For Fair Pay O-S

2019-01-05 Thread Ywe Cærlyn
I have been working on the philosophy behind Uxxuw For Fair O-S, in 2018. In 2019, I have philosophy v1.0 ready. Computersystems start with I/O, with a high-level paradigm for input/output. This to ease development. In our analysis we see problems with behaviour in Linux crowds, and this was

Re: [PATCH 2/3] qcom: spmi-gpio: add support for hierarchical IRQ chip

2019-01-05 Thread Brian Masney
On Sat, Jan 05, 2019 at 07:08:44AM -0500, Brian Masney wrote: > > I also seem to recall that GPIO numbering starts from 1 instead of > > 0, so please keep that in mind. > > I'm using the pinctrl numbering, which is zero based. > > / # head

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Pavel Machek
> >We will need to solve RGB leds somehow, hopefully this is solved with > >it. > > When? With this attitude we will procrastinate it forever. > It's been almost 3 years since first HSV patches. > > I proposed rough design of LED RGB class interface in [0]. > If you find it totally flawed, then

Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver

2019-01-05 Thread Jacek Anaszewski
Hi Pavel, On 1/4/19 11:07 PM, Pavel Machek wrote: Hi! But, aside from that hypothetic issue, we need a solution for LEDn_BRIGHTNESS feature of lp5024, i.e. setting color intensity via a single register write. How would you propose to address that? So they have hardware feature that allows

Re: [PATCH 2/3] qcom: spmi-gpio: add support for hierarchical IRQ chip

2019-01-05 Thread Brian Masney
On Thu, Jan 03, 2019 at 04:48:33PM -0800, Stephen Boyd wrote: > I'd think we want the interrupt-cells for the pmic gpio controller to be > 2 cells (pin and flags) instead of 4 like you have here to match the > parent interrupt specifier. I originally went with 4 interrupt cells for spmi-gpio to

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-4.21-2 tag

2019-01-05 Thread Michael Ellerman
Hi Linus, Michael Ellerman writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Linus, > > Please pull some powerpc fixes for 4.21: ... > > for you to fetch changes up to 074400a7be61250d9f0ccec07d5c35ffec4d8d22: > > powerpc: Drop use of 'type' from access_ok() (2019-01-04 23:07:59

<    1   2   3   >