[PATCH ghak104 V1] audit: move loginuid and sessionid from CONFIG_ AUDITSYSCALL to AUDIT

2019-01-22 Thread Richard Guy Briggs
loginuid and sessionid (and audit_log_session_info) should be part of CONFIG_AUDIT scope and not CONFIG_AUDITSYSCALL since it is used in CONFIG_CHANGE, ANOM_LINK, FEATURE_CHANGE (and INTEGRITY_RULE), none of which are otherwise dependent on AUDITSYSCALL. Please see github issue https://github.com/

Re: [PATCH 6/7] crypto: ccp: no need to check return value of debugfs_create functions

2019-01-22 Thread Gary R Hook
On 1/22/19 9:14 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Stupid question(s) time. If we don't care about failures (becau

Re: [PATCH v9 00/22] Re-use nvram module

2019-01-22 Thread Finn Thain
On Tue, 22 Jan 2019, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 03:18:56PM +1100, Finn Thain wrote: > > The "generic" NVRAM module, drivers/char/generic_nvram.c, implements a > > /dev/nvram misc device. This module is used only by 32-bit PowerPC > > platforms. > > > > The RTC "CMOS" NVRA

Re: [PATCH] regulator: qcom-smd: Batch up requests for disabled regulators

2019-01-22 Thread Jeffrey Hugo
On 1/22/2019 12:01 PM, Bjorn Andersson wrote: In some scenarios the early stages of the boot chain has configured regulators to be in a required state, but the later stages has skipped to inform the RPM about it's requirements. But as the SMD RPM regulators are being initialized voltage change r

Re: [PATCH 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-01-22 Thread Joel Fernandes
Hi Viktor, Could you CC me on the other patches as well, next time? I am quite interested and recently have worked on the latency tracer. Some comments below: On Mon, Jan 21, 2019 at 02:35:11PM +0200, Viktor Rosendahl wrote: > This burst feature enables the user to generate a burst of > preempt/

Re: [PATCH 1/6] x86: mce: no need to check return value of debugfs_create functions

2019-01-22 Thread Borislav Petkov
On Tue, Jan 22, 2019 at 03:35:37PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Thomas Gleixner > Cc: Ingo Molnar

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-22 Thread Matthias Kaehlcke
On Mon, Jan 21, 2019 at 08:11:39PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2019-01-19 06:01, Matthias Kaehlcke wrote: > > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > > > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > > > > > > > I obser

Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2019-01-22 Thread Paul Gortmaker
[Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On 22/01/2019 (Tue 19:52) Greg KH wrote: > On Tue, Jan 22, 2019 at 06:12:31PM +0100, Andreas Färber wrote: > > Am 22.01.19 um 17:56 schrieb Paul Gortmaker: > > > [[PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On > >

Re: [PATCH resend] drm/panel: panel-innolux: set display off in innolux_panel_unprepare

2019-01-22 Thread Sean Paul
On Fri, Jan 18, 2019 at 12:58:10PM -0500, Sean Paul wrote: > On Wed, Jan 9, 2019 at 1:59 AM Hsin-Yi, Wang wrote: > > > > Move mipi_dsi_dcs_set_display_off() from innolux_panel_disable() > > to innolux_panel_unprepare(), so they are consistent with > > innolux_panel_enable() and innolux_panel_prepa

[tip:x86/urgent] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled

2019-01-22 Thread tip-bot for Sinan Kaya
Commit-ID: 625210cfa6c0c26ea422f655bf68288176f174e6 Gitweb: https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6 Author: Sinan Kaya AuthorDate: Mon, 21 Jan 2019 23:19:58 + Committer: Borislav Petkov CommitDate: Tue, 22 Jan 2019 17:06:28 +0100 x86/Kconfig: Select PCI_

Re: [LSF/MM TOPIC] Page flags, can we free up space ?

2019-01-22 Thread Andi Kleen
Jerome Glisse writes: > > Right now this is more a temptative ie i do not know if i will succeed, > in any case i can report on failure or success and discuss my finding to > get people opinions on the matter. I would just stop putting node/zone number into the flags. These could be all handled w

Re: [PATCH 2/2] x86/kvmclock: set_memory_decrypted() takes number of pages

2019-01-22 Thread Lendacky, Thomas
On 1/22/19 3:17 PM, Thiago Jung Bauermann wrote: > From: Ram Pai > > set_memory_decrypted() expects the number of PAGE_SIZE pages to decrypt. > kvmclock_init_mem() instead passes number of bytes. This decrypts a huge > number of pages resulting in data corruption. Same comment as patch 1/2 in th

Re: [PATCH 1/2] dma-direct: set_memory_{en,de}crypted() take number of pages

2019-01-22 Thread Lendacky, Thomas
On 1/22/19 3:17 PM, Thiago Jung Bauermann wrote: > From: Ram Pai > > set_memory_encrypted() and set_memory_decrypted() expect the number of > PAGE_SIZE pages to encrypt or decrypt. dma_direct_alloc() and > dma_direct_free() instead pass number of bytes. This encrypts/decrypts a > huge number of p

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-22 Thread Matthias Kaehlcke
On Mon, Jan 21, 2019 at 09:56:13AM +0100, Johan Hovold wrote: > On Fri, Jan 18, 2019 at 04:31:09PM -0800, Matthias Kaehlcke wrote: > > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > > > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > > > > > > > I observed tha

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-22 Thread Jacek Anaszewski
Hi all, On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote:

[PATCH v2] iommu/vt-d: Implement dma_[un]map_resource()

2019-01-22 Thread Logan Gunthorpe
Currently the Intel IOMMU uses the default dma_[un]map_resource() implementations does nothing and simply returns the physical address unmodified. However, this doesn't create the IOVA entries necessary for addresses mapped this way to work when the IOMMU is enabled. Thus, when the IOMMU is enable

[PATCH] usb: gadget: udc: net2272: Fix bitwise and boolean operations

2019-01-22 Thread Gustavo A. R. Silva
(!x & y) strikes again. Fix bitwise and boolean operations by enclosing the expression: intcsr & (1 << NET2272_PCI_IRQ) in parentheses, before applying the boolean operator '!'. Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this. T

Re: [PATCH 2/4] arm: dump: no need to check return value of debugfs_create functions

2019-01-22 Thread Kees Cook
On Wed, Jan 23, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Russell King > Cc: Jinbum Park > Cc: Kee

Re: [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-22 Thread Doug Anderson
Hi, On Mon, Jan 21, 2019 at 9:13 AM Georgi Djakov wrote: > > Hi Rob, > > On 1/18/19 21:16, Rob Clark wrote: > > On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > >> > >> Hi, > >> > >> On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse > >> wrote: > >>> > >>> Try to get the interconnect path fo

[PATCH 2/2] x86/kvmclock: set_memory_decrypted() takes number of pages

2019-01-22 Thread Thiago Jung Bauermann
From: Ram Pai set_memory_decrypted() expects the number of PAGE_SIZE pages to decrypt. kvmclock_init_mem() instead passes number of bytes. This decrypts a huge number of pages resulting in data corruption. Fixed it. [ bauermann: Slightly reworded commit message and added Fixes: tag. ] Fixes: 6a

[PATCH v2 2/2] pinctrl: remove unused 'pinconf-config' debugfs interface

2019-01-22 Thread Vladimir Zapolskiy
The main goal of the change is to remove .pin_config_dbg_parse_modify callback before a driver with its support appears. So far the in-kernel interface did not attract any users since its introduction 5 years ago. Originally .pin_config_dbg_parse_modify callback and the associated 'pinconf-config'

[PATCH 1/2] dma-direct: set_memory_{en,de}crypted() take number of pages

2019-01-22 Thread Thiago Jung Bauermann
From: Ram Pai set_memory_encrypted() and set_memory_decrypted() expect the number of PAGE_SIZE pages to encrypt or decrypt. dma_direct_alloc() and dma_direct_free() instead pass number of bytes. This encrypts/decrypts a huge number of pages resulting in data corruption. Fixed it. [ bauermann: S

[PATCH v2 1/2] pinctrl: remove pinctrl/machine.h inclusion from pinctrl/pinconf.h

2019-01-22 Thread Vladimir Zapolskiy
The change adds explicit inclusion of linux/pinctrl/machine.h header to the only needed pinctrl-madera-core.c file, and therefore inclusion of pinctrl/machine.h header from pinctrl/pinconf.h can be removed. The change is preparatory to a follow-up reversal of commit f07512e615dd ("pinctrl/pinconfi

[PATCH v2 0/2] pinctrl: remove unused 'pinconf-config' debugfs interface

2019-01-22 Thread Vladimir Zapolskiy
The main goal of the change is to remove .pin_config_dbg_parse_modify callback before a driver with its support appears. So far the in-kernel interface did not attract any users since its introduction 5 years ago. Originally .pin_config_dbg_parse_modify callback and the associated 'pinconf-config'

Re: [PATCH v3 1/1] MAINTAINERS: update list of qcom drivers

2019-01-22 Thread Andy Gross
On Mon, Jan 21, 2019 at 01:58:41PM +0530, Amit Kucheria wrote: > On Tue, Jan 15, 2019 at 1:16 AM Amit Kucheria > wrote: > > > > Several drivers didn't have a specific maintainer (other than the > > subsystem maintainer). Add some generic regex patterns to capture most > > qcom drivers in the list

Re: [PATCH v3 2/3] usb: dwc3: qcom: Add support for MSM8998

2019-01-22 Thread Andy Gross
On Mon, Jan 21, 2019 at 02:33:08PM -0700, Jeffrey Hugo wrote: > Add a MSM8998 specific DT compatible so that we can properly bind to the > device and enable the USB controller. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Bjorn Andersson > --- > drivers/usb/dwc3/dwc3-qcom.c | 1 + > 1 file ch

Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2019-01-22 Thread Thomas Gleixner
On Mon, 21 Jan 2019, Thomas Gleixner wrote: > On Mon, 21 Jan 2019, Heiko Carstens wrote: > > > Hi Thomas, > > > > [full quote below] > > > > Did you have any time to look into this yet? :) > > > > The warning is still reproducible. > > Yeah, it's on my list of stuff which I need to take care o

Re: [PATCH v6 00/15] qcom: spmi: add support for hierarchical IRQ chip

2019-01-22 Thread Andy Gross
On Tue, Jan 22, 2019 at 04:31:20PM +0100, Linus Walleij wrote: > On Sat, Jan 19, 2019 at 9:43 PM Brian Masney wrote: > > > This patch series adds hierarchical IRQ chip support to spmi-gpio so > > that device tree consumers can request an IRQ directly from the GPIO > > block rather than having to

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-22 Thread Laurent Pinchart
Hi Ronald, Thank you for the patch. On Tue, Jan 22, 2019 at 06:13:11AM -0800, Ronald Tschalär wrote: > commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: Commits are usually quoted using the short 12 digits version of their SHA-1. > sil_sii8620: do not have a dependency of RC_CORE) ad

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-22 Thread Moritz Fischer
Hi Enrico, On Mon, Jan 21, 2019 at 11:19:34PM +0100, Enric Balletbo Serra wrote: > I tried with a Samsung Chromebook Plus (arm64 Chromebook) > > > What was the ioctl you ran? > > > > The code that I ran is this: https://hastebin.com/cupecuvowi.py > No guarantee :) I'll try to look deeper tomorro

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-22 Thread Ard Biesheuvel
On Tue, 22 Jan 2019 at 21:56, Alex Deucher wrote: > > On Tue, Jan 22, 2019 at 4:19 AM Ard Biesheuvel > wrote: > > > > On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > > > > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > > > On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > > > >>

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-22 Thread Thomas Gleixner
Chen, On Fri, 18 Jan 2019, Huacai Chen wrote: > > > I did not say that you removed all NULL returns. I said that this function > > > can return NULL for other reasons and then the same situation will happen. > > > > > > If the masks pointer returned is NULL then the calling code or any > > > subse

Re: [PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Fri, Jan 18, 2019 at 11:11:38PM +, Peter Rosin wrote: > The gpio API explicitly allows skipping the NULL check, precisely to > allow for neat support for optional gpios. Which is exactly what is at > play here. > > Reported-by: Andrzej Hajda > Signed-of

[PATCH perf] perf tools: fix synthesized PERF_RECORD_KSYMBOL/BPF_EVENT

2019-01-22 Thread Song Liu
Added missing machine->id_hdr_size to event->header.size. Also fixed size of PERF_RECORD_KSYMBOL by removing extra bytes for name. Fixes: 7b612e291a5a ("perf tools: Synthesize PERF_RECORD_* for loaded BPF programs") Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Suggested-by: Jiri Olsa Signed

Re: [PATCH v3 5/5] drm/bridge: lvds-encoder: add powerdown-gpios support

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Sat, Dec 29, 2018 at 07:07:43AM +, Peter Rosin wrote: > Optionally power down the LVDS-encoder when it is not in use. > > Signed-off-by: Peter Rosin As the powerdown-gpios property is only defined for two encoders, and both of them should work well wit

Re: ipmi_si: 90 s delay in system start with 4.14.94, but not 4.18.6

2019-01-22 Thread Corey Minyard
On 1/22/19 10:17 AM, Paul Menzel wrote: Dear Linux folks, Using Linux 4.14.94 on a HP EliteDesk 705 G4 MT desktop system, there is a 100 s delay during boot. ``` [0.00] Linux version 4.14.94.mx64.239 (r...@x.molgen.mpg.de) (gcc version 7.3.0 (GCC)) #1 SMP Mon Jan 21 11:39:45 CET 2019

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-22 Thread Alex Deucher
On Tue, Jan 22, 2019 at 4:19 AM Ard Biesheuvel wrote: > > On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > > On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > > >> On 2019-01-21 7:20 p.m., Ard Biesheuvel wrote: > > >>> On Mon, 21 Ja

linux-next: Fixes tag needs some work in the renesas tree

2019-01-22 Thread Stephen Rothwell
Hi all, In commit 8d6e2bbaeceb ("arm64: dts: renesas: r8a774a1: Fix hsusb reg size") Fixes tag Fixes: ed898d4fc19d ("arm64: dts: renesas: r8a774a1: Add USB-DMAC and has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes Pl

Re: [PATCH v3 4/5] drm/bridge: lvds-encoder: add dev helper variable in .probe()

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Sat, Dec 29, 2018 at 07:07:37AM +, Peter Rosin wrote: > Make the code easier to read and modify. > > Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/lvds-encoder.c | 19 +-- > 1 file changed, 9

Re: [PATCH v3 3/5] dt-bindings: display: bridge: thc63lvdm83d: use standard powerdown-gpios

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Sat, Dec 29, 2018 at 07:07:31AM +, Peter Rosin wrote: > The name powerdown-gpios is the standard property name for the > functionality covered by the previous pwdn-gpios name. This rename > should be safe to do since the linux driver supporting the bindin

Re: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter

2019-01-22 Thread Laurent Pinchart
Hello, On Fri, Jan 11, 2019 at 08:49:04AM -0600, Rob Herring wrote: > On Sat, Dec 29, 2018 at 07:07:19AM +, Peter Rosin wrote: > > DS90C185 has a shutdown pin which does not fit in the lvds-transmitter > > binding, which is meant to be generic. > > > > The sister chip DS90C187 is similar to D

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 09:39:24PM +0100, Christian Borntraeger wrote: > > > On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something diff

linux-next: Fixes tags need some work in the dma-mapping-fixes tree

2019-01-22 Thread Stephen Rothwell
Hi Christoph, In commit 702e8ed37bed ("arm64/xen: fix xen-swiotlb cache flushing") Fixes tag Fixes: 356da6d0cd ("dma-mapping: bypass indirect calls for dma-direct") has these problem(s): - SHA1 should be at least 12 digits long In commit 8218a55b6b91 ("sbitmap: Protect swap_lock fro

Re: [PATCH v3 2/5] dt-bindings: display: bridge: lvds-transmitter: cleanup example

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Sat, Dec 29, 2018 at 07:07:25AM +, Peter Rosin wrote: > Drop #address-cells and #size-cells from the root node in the > example, they are unused. > > Reviewed-by: Rob Herring > Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart > --- > Docume

Re: [PATCH 4.9 00/51] 4.9.152-stable review

2019-01-22 Thread Guenter Roeck
On Mon, Jan 21, 2019 at 02:43:56PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.152 release. > There are 51 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH] brcm80211: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 09:07:48PM +0100, Arend Van Spriel wrote: > The prefix should be 'brcmsmac'. > > On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Christian Borntraeger
On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: k...@vger

Re: [PATCH v2 lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-22 Thread Ben Whitten
Hi, On 22/01/2019 20:04, Rob Herring wrote: On Tue, Jan 22, 2019 at 12:07 PM Ben Whitten wrote: From: Ben Whitten Add basic documentation in YAML format for the SX130x series concentrators from Semtech. Required is; the location on the SPI bus and the compatible string. Signed-off-by: Ben

Re: [PATCH] drm: rcar-du: Fix build error

2019-01-22 Thread Laurent Pinchart
Hi Nathan, Thank you for the patch. On Fri, Jan 18, 2019 at 10:21:25AM -0700, Nathan Chancellor wrote: > On arm{32,64} allyesconfig builds: > > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c:40:1: error: incomplete result type > 'enum drm_mode_status' in function definition > drivers/gpu/drm/rcar-du/rc

Re: [PATCH] regulator: qcom-smd: Batch up requests for disabled regulators

2019-01-22 Thread Jeffrey Hugo
On 1/22/2019 1:11 PM, Bjorn Andersson wrote: On Tue 22 Jan 11:25 PST 2019, Jeffrey Hugo wrote: Hi Bjorn, This seems intresting, but I'm not sure I fully understand it yet. On 1/22/2019 12:01 PM, Bjorn Andersson wrote: In some scenarios the early stages of the boot chain has configured regula

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-22 Thread Mark Brown
On Tue, Jan 22, 2019 at 12:03:34PM +0530, Alok Chauhan wrote: > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. Still not seeing anything except this patch here in my inbox - like I said what's the story with dependenc

general protection fault in nf_ct_gre_keymap_flush

2019-01-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:5b22549b8c00 Add linux-next specific files for 20190122 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=11e6d908c0 kernel config: https://syzkaller.appspot.com/x/.config?x=9d3270828ee2eb2f

Re: [PATCH 1/3] platform/x86: wmi: move struct wmi_device_id to mod_devicetable.h

2019-01-22 Thread Mattias Jacobsson
On 2019-01-19, Mattias Jacobsson wrote: > In preparation for adding WMI support to MODULE_DEVICE_TABLE() move the > definition of struct wmi_device_id to mod_devicetable.h and inline > guid_string in the struct. > > Changing guid_string to an inline char array changes the loop conditions > when lo

KASAN: use-after-free Read in do_raw_spin_trylock

2019-01-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:28f9d1a3d4fe Merge branch 'mlxsw-spectrum_router-Add-GRE-t.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1302015f40 kernel config: https://syzkaller.appspot.com/x/.config?x=8a4dffabfb4e36f9 da

Re: [PATCH] backing-dev: no need to check return value of debugfs_create functions

2019-01-22 Thread Sebastian Andrzej Siewior
On 2019-01-22 19:33:48 [+0100], Greg Kroah-Hartman wrote: > On Tue, Jan 22, 2019 at 06:19:08PM +0100, Sebastian Andrzej Siewior wrote: > > but if you cat the stats file then it will dereference the bdi struct > > which has been free(), right? > > Maybe, I don't know, your code is long gone, it doe

Applied "regulator: arizona-ldo1: Convert to use regulator_linear_range for ldo1_hc" to the regulator tree

2019-01-22 Thread Mark Brown
The patch regulator: arizona-ldo1: Convert to use regulator_linear_range for ldo1_hc has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually some

Applied "regulator: wm831x-dcdc: Convert to use regulator_linear_range for wm831x_buckv" to the regulator tree

2019-01-22 Thread Mark Brown
The patch regulator: wm831x-dcdc: Convert to use regulator_linear_range for wm831x_buckv has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually

Applied "regulator: twl: Use of_device_get_match_data()" to the regulator tree

2019-01-22 Thread Mark Brown
The patch regulator: twl: Use of_device_get_match_data() has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) a

Applied "regulator: qcom-smd: Batch up requests for disabled regulators" to the regulator tree

2019-01-22 Thread Mark Brown
The patch regulator: qcom-smd: Batch up requests for disabled regulators has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Re: [RFC PATCH] ALSA: core: Add DMA share buffer support

2019-01-22 Thread Mark Brown
On Mon, Jan 21, 2019 at 03:15:43PM +0100, Jaroslav Kysela wrote: > Dne 21.1.2019 v 13:40 Mark Brown napsal(a): > > It was the bit about adding more extended permission control that I was > > worried about there, not the initial O_APPEND bit. Indeed the O_APPEND > > bit sounds like it might also w

Re: tsc: Fast TSC calibration failed with AMD B350M/Ryzen 3 2200G

2019-01-22 Thread Lendacky, Thomas
On 1/22/19 10:53 AM, Paul Menzel wrote: > [Adding Tom to CC] > > Dear Thomas, dear Tom, > > > On 01/14/19 11:09, Paul Menzel wrote: > >> On 01/11/19 21:43, Thomas Gleixner wrote: >> >>> On Mon, 7 Jan 2019, Paul Menzel wrote: On 01/07/19 16:24, Thomas Gleixner wrote: >> Linux 4.19.13 fr

Re: [PATCH] PCI: Use of_node_name_eq for node name comparisons

2019-01-22 Thread Bjorn Helgaas
[+cc Michael B] On Wed, Dec 05, 2018 at 01:50:34PM -0600, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc:

[PATCH] MIPS: OCTEON: irq: Fix potential NULL pointer dereference

2019-01-22 Thread Gustavo A. R. Silva
There is a potential NULL pointer dereference in case kzalloc() fails and returns NULL. Fix this by adding a NULL check on *cd* This bug was detected with the help of Coccinelle. Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes") Cc: sta...@vger.kernel.org Signed-off-by: Gustavo

Re: [PATCH v9 09/26] arm64: Unmask PMR before going idle

2019-01-22 Thread Ard Biesheuvel
On Mon, 21 Jan 2019 at 16:36, Julien Thierry wrote: > > CPU does not received signals for interrupts with a priority masked by > ICC_PMR_EL1. This means the CPU might not come back from a WFI > instruction. > > Make sure ICC_PMR_EL1 does not mask interrupts when doing a WFI. > > Since the logic of

[LSF/MM TOPIC] Page flags, can we free up space ?

2019-01-22 Thread Jerome Glisse
So lattely i have been looking at page flags and we are using 6 flags for memory reclaim and compaction: PG_referenced PG_lru PG_active PG_workingset PG_reclaim PG_unevictable On top of which you can add the page anonymous flag (anonymous or share memory) PG_anon // do

Re: [Freedreno] [v3] drm/msm/dpu: Clean up dpu hw interrupts

2019-01-22 Thread Sean Paul
On Tue, Dec 18, 2018 at 05:05:48PM +0530, Jayant Shekhar wrote: > Remove unused functions and macros from files handling > dpu hardware interrupts. > > changes in v2: > Removed clear_interrupt_status (Jordan Crouse) > changes in v3: > Changed commit text > > Signed-off-by: Jayant Shekhar Ap

Re: [PATCH v2 lora-next 3/4] dt-bindings: lora: sx125x: add clock bindings

2019-01-22 Thread Rob Herring
On Tue, Jan 22, 2019 at 12:07 PM Ben Whitten wrote: > > From: Ben Whitten > > The SX125x consumes a clock (FXOSC) ranging from 32 to 36 MHz. > If the radio is coupled with an SX130x the radio is therefor operating in > master mode and it may also provide a gated version of this clock for the > co

Re: [PATCH 1/3] dt-bindings: pwm: kona: Add new compatible for new version pwm-kona

2019-01-22 Thread Scott Branden
Hi Rob, On 2019-01-21 3:11 p.m., Rob Herring wrote: On Tue, Jan 15, 2019 at 04:14:21PM -0800, Scott Branden wrote: Hi Uwe, On 2019-01-12 7:05 a.m., Uwe Kleine-König wrote: Hello Scott, On Fri, Jan 11, 2019 at 01:28:45PM -0800, Scott Branden wrote: On 2019-01-11 12:48 p.m., Uwe Kleine-König

Re: [PATCH V3] i2c: tegra: Add Bus Clear Master Support

2019-01-22 Thread Dmitry Osipenko
22.01.2019 23:02, Sowjanya Komatineni пишет: > Bus clear feature of tegra i2c controller helps to recover from > bus hang when i2c master loses the bus arbitration due to the > slave device holding SDA LOW continuously for some unknown reasons. > > Per I2C specification, the device that held the b

Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component

2019-01-22 Thread Pierre-Louis Bossart
The issue was that we were seeing a memory corruption bug on an AMD chromebooks with that function already (not observed on Intel). I was testing some SOF integrations and was seeing this in the kernel logs. I had Dylan verify my logic before I sent the patch because it took so long to identify

Re: [Freedreno] [v1] drm/msm/dpu: Cleanup dpu plane interface

2019-01-22 Thread Sean Paul
On Tue, Dec 18, 2018 at 06:50:38PM +0530, Jayant Shekhar wrote: > Remove unused functions from dpu plane interface > and unused variables from dpu plane state structure. > > Signed-off-by: Jayant Shekhar Applied to dpu-staging, thanks! Sean > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2

Re: [PATCH] regulator: qcom-smd: Batch up requests for disabled regulators

2019-01-22 Thread Bjorn Andersson
On Tue 22 Jan 11:25 PST 2019, Jeffrey Hugo wrote: > Hi Bjorn, > > This seems intresting, but I'm not sure I fully understand it yet. > > On 1/22/2019 12:01 PM, Bjorn Andersson wrote: > > In some scenarios the early stages of the boot chain has configured > > regulators to be in a required state,

Re: [Freedreno] [v1] drm/msm/dpu: Remove unused enum and comment from dpu mdss

2019-01-22 Thread Sean Paul
On Wed, Dec 19, 2018 at 12:23:53AM +0530, Jayant Shekhar wrote: > Remove enum dpu_iommu_domain from dpu mdss as its unused. > > Remove unnecessary comment for variable which is already > removed. > > Signed-off-by: Jayant Shekhar Applied to dpu-staging, thanks! Sean > --- > drivers/gpu/drm/m

Re: [PATCHv4 1/4] arm64: dts: qcom: sdm845: Add Coresight support

2019-01-22 Thread Suzuki K Poulose
Hi Sai, On 01/22/2019 04:48 PM, Sai Prakash Ranjan wrote: Hi Suzuki, On 1/22/2019 9:38 PM, Suzuki K Poulose wrote: By inconsistent, I meant the registers provides values which are not the same on two different CPUs of the *same type*. And it is expected that two different CPU/ETM implementati

[RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-22 Thread Yang Shi
In current implementation, both kswapd and direct reclaim has to iterate all mem cgroups. It is not a problem before offline mem cgroups could be iterated. But, currently with iterating offline mem cgroups, it could be very time consuming. In our workloads, we saw over 400K mem cgroups accumulat

Re: [PATCH] brcm80211: no need to check return value of debugfs_create functions

2019-01-22 Thread Arend Van Spriel
The prefix should be 'brcmsmac'. On 1/22/2019 4:21 PM, Greg Kroah-Hartman wrote: When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. I could argue that if above is

Re: [PATCH v2 lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-22 Thread Rob Herring
On Tue, Jan 22, 2019 at 12:07 PM Ben Whitten wrote: > > From: Ben Whitten > > Add basic documentation in YAML format for the SX130x series concentrators > from Semtech. > Required is; the location on the SPI bus and the compatible string. > > Signed-off-by: Ben Whitten > --- > v1 -> v2: > * Drop

[PATCH] platform/x86: wmi: fix potential null pointer dereferences

2019-01-22 Thread Mattias Jacobsson
In the function wmi_dev_match() there are three variables that potentially can result in a null pointer dereference. Namely: dev/wblock, driver/wmi_driver, and wmi_driver->id_table. Check for NULL and return that the driver can't handle the device if any of these variables would result in a null p

[PATCH V3] i2c: tegra: Add Bus Clear Master Support

2019-01-22 Thread Sowjanya Komatineni
Bus clear feature of tegra i2c controller helps to recover from bus hang when i2c master loses the bus arbitration due to the slave device holding SDA LOW continuously for some unknown reasons. Per I2C specification, the device that held the bus LOW should release it within 9 clock pulses. During

Re: [Xen-devel] [RFC] virtio_ring: check dma_mem for xen_domain

2019-01-22 Thread Stefano Stabellini
On Mon, 21 Jan 2019, Peng Fan wrote: > on i.MX8QM, M4_1 is communicating with DomU using rpmsg with a fixed > address as the dma mem buffer which is predefined. > > Without this patch, the flow is: > vring_map_one_sg -> vring_use_dma_api > -> dma_map_page > ->

Re: [RFC 5/6] powerpc/pci/hotplug: Use common drcinfo parsing

2019-01-22 Thread Bjorn Helgaas
On Mon, Jan 14, 2019 at 06:28:57PM -0600, Bjorn Helgaas wrote: > On Fri, Dec 14, 2018 at 02:51:31PM -0600, Michael Bringmann wrote: > > The implementation of the pseries-specific drc info properties > > is currently implemented in pseries-specific and non-pseries-specific > > files. This patch set

[PATCH] tty: serial: 8250_mtk: Fix potential NULL pointer dereference

2019-01-22 Thread Gustavo A. R. Silva
There is a potential NULL pointer dereference in case devm_kzalloc() fails and returns NULL. Fix this by adding a NULL check on data->dma This bug was detected with the help of Coccinelle. Fixes: 85b5c1dd0456 ("serial: 8250-mtk: add uart DMA support") Signed-off-by: Gustavo A. R. Silva --- dri

[PATCH V10 2/4] arm64: dts: tegra: Add CQE Support for SDMMC4

2019-01-22 Thread Sowjanya Komatineni
Add CQE Support for Tegra186 and Tegra194 SDMMC4 controller Signed-off-by: Sowjanya Komatineni --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 + arch/arm64/boot/dts/nvidia/tegra194.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64

[PATCH V10 3/4] mmc: sdhci: Add ADMA3 DMA support for V4 enabled host

2019-01-22 Thread Sowjanya Komatineni
Below are the supported DMA types in Host Control1 Register with Version 4 enable b'00 - SDMA b'01 - Not Used b'10 - ADMA2 b'11 - ADMA2 or ADMA3 ADMA3 uses Command Descriptor to issue an SD command. A multi-block data transfer is performed by using a pair of CMD descriptor and ADMA2 descriptor. A

[PATCH V10 4/4] mmc: tegra: HW Command Queue Support for Tegra SDMMC

2019-01-22 Thread Sowjanya Komatineni
This patch adds HW Command Queue for supported Tegra SDMMC controllers. Signed-off-by: Sowjanya Komatineni --- [V10]: Changes are same as V9 except this series has SDHCI core changes into seperate patch drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-tegra.c | 117 +

[PATCH V10 1/4] dt-bindings: mmc: Add supports-cqe property

2019-01-22 Thread Sowjanya Komatineni
Add supports-cqe optional property for MMC hosts. This property is used to identify the specific host controller supporting command queue. Signed-off-by: Sowjanya Komatineni --- [V10]: This patch version moves supports-cqe property from vendor specific MMC property to common MMC propert

Re: [PATCH v8 11/11] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-22 Thread Tim Harvey
On Mon, Jan 21, 2019 at 12:24 PM Tim Harvey wrote: > > On Tue, Jan 15, 2019 at 3:54 PM Steve Longerbeam > wrote: > > > > Hi Tim, > > > > On 1/15/19 1:58 PM, Tim Harvey wrote: > > > On Wed, Jan 9, 2019 at 10:30 AM Steve Longerbeam > > > wrote: > > >> Also add an example pipeline for unconverted

Re: [PATCH] lightnvm: pblk: stop taking the free lock in in pblk_lines_free

2019-01-22 Thread Matias Bjørling
On 1/22/19 11:15 AM, h...@owltronix.com wrote: From: Hans Holmberg pblk_line_meta_free might sleep (it can end up calling vfree, depending on how we allocate lba lists), and this can lead to a BUG() if we wake up on a different cpu and release the lock. As there is no point of grabbing the fre

Re: [PATCH] lightnvm: pblk: use vfree to free metadata on error path

2019-01-22 Thread Matias Bjørling
On 1/22/19 11:17 AM, h...@owltronix.com wrote: From: Hans Holmberg As chunk metadata is allocated using vmalloc, we need to free it using vfree. Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page") Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-core.c | 2 +-

Re: [PATCH] lib/test_kmod: Potential double free in error handling

2019-01-22 Thread Luis Chamberlain
On Mon, Jan 21, 2019 at 05:00:11PM +0300, Dan Carpenter wrote: > There is a copy and paste bug so we set "config->test_driver" to NULL > twice instead of setting "config->test_fs". Smatch complains that it > leads to a double free: > > lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_

Re: [PATCH v11 perf, bpf-next 7/9] perf tools: synthesize PERF_RECORD_* for loaded BPF programs

2019-01-22 Thread Jiri Olsa
On Tue, Jan 22, 2019 at 07:24:43PM +, Song Liu wrote: > > > > On Jan 22, 2019, at 11:15 AM, Jiri Olsa wrote: > > > > On Tue, Jan 22, 2019 at 06:38:56PM +, Song Liu wrote: > > > > SNIP > > > in perf_session__process_event, this happens right when processing > buildids in 'per

Re: [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions

2019-01-22 Thread Paul Burton
Hi Greg, On Tue, Jan 22, 2019 at 08:29:16PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 22, 2019 at 07:22:57PM +, Paul Burton wrote: > > On Tue, Jan 22, 2019 at 08:48:56PM +0200, Aaro Koskinen wrote: > > > On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote: > > > > -static i

Re: [PATCH] selftests: kmod: worked on errors which breaks the overall execution of the test script

2019-01-22 Thread Luis Chamberlain
On Fri, Jan 18, 2019 at 02:32:58AM +0530, Jeffrin Jose T wrote: > The kmod.sh script breaks First thanks for the patch! But now let's get to it: on what distribution and version of bash does this break? The commit log should refer to this and it would help me confirm the issue. > because an array

Re: [PATCH v13 00/10] powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK

2019-01-22 Thread Christophe Leroy
Le 19/01/2019 à 11:23, Michael Ellerman a écrit : Christophe Leroy writes: The purpose of this serie is to activate CONFIG_THREAD_INFO_IN_TASK which moves the thread_info into task_struct. Moving thread_info into task_struct has the following advantages: - It protects thread_info from corr

Re: [PATCH 08/13] clk: qcom: hfpll: CLK_IGNORE_UNUSED

2019-01-22 Thread Jorge Ramirez
On 1/22/19 19:47, Stephen Boyd wrote: > Quoting Jorge Ramirez (2019-01-17 02:46:21) >> On 1/17/19 11:08, Viresh Kumar wrote: >>> On 17-01-19, 09:38, Jorge Ramirez wrote: COMMON_CLK_DISABLED_UNUSED relies on the enable_count reference counter to disable the clocks that were enabled by the

Re: [PATCH 0/3] drivers: Frequency constraint infrastructure

2019-01-22 Thread Matthias Kaehlcke
On Mon, Jan 21, 2019 at 12:10:55PM +0100, Rafael J. Wysocki wrote: > On Fri, Jan 18, 2019 at 1:39 PM Juri Lelli wrote: > > > > On 17/01/19 15:55, Rafael J. Wysocki wrote: > > > On Thu, Jan 17, 2019 at 2:16 PM Juri Lelli wrote: > > > > > > > > On 11/01/19 10:47, Rafael J. Wysocki wrote: > > > > >

Re: [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions

2019-01-22 Thread Greg Kroah-Hartman
On Tue, Jan 22, 2019 at 07:22:57PM +, Paul Burton wrote: > Hello, > > On Tue, Jan 22, 2019 at 08:48:56PM +0200, Aaro Koskinen wrote: > > On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote: > > > -static int init_debufs(void) > > > +static void init_debugfs(void) > > > { > > >

Re: [PATCH v3 04/10] dt-bindings: soc: qcom: Add AOSS QMP binding

2019-01-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2019-01-22 11:25:37) > On Tue 22 Jan 11:04 PST 2019, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2019-01-21 21:51:06) > > > Add binding for the QMP based side-channel communication mechanism to > > > the AOSS, which is used to control resources not exposed through t

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2019-01-22 Thread Pierre-Louis Bossart
On 1/20/19 11:55 PM, Mogens Jensen wrote: The only minor annoyance I'm experiencing now, is a large amount of debug output from something in kernel log when audio is played on the system: writing to lpe: : 01 01 01 01 00 00 08 00 ff ff ff ff 55 00 00 00 U... writing to l

Re: [PATCH] opp: no need to check return value of debugfs_create functions

2019-01-22 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2019-01-22 07:21:17) > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Viresh Kumar > Cc: Nishanth Menon > Cc: Stephen Boy

<    1   2   3   4   5   6   7   8   9   10   >