Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property

2019-02-16 Thread Jagan Teki
Hi Dmitry and Rob, On Thu, Feb 14, 2019 at 3:21 AM Rob Herring wrote: > > On Tue, Jan 22, 2019 at 7:39 AM Jagan Teki wrote: > > > > On Mon, Jan 21, 2019 at 9:46 PM Rob Herring wrote: > > > > > > On Fri, Jan 18, 2019 at 10:01 AM Jagan Teki > > > wrote: > > > > > > > > On Wed, Jan 9, 2019 at

Re: 答复: [v6] coccinelle: semantic code search for missing put_device()

2019-02-16 Thread Markus Elfring
> But please also refer to the examples of coccinelle, such as: > http://coccinelle.lip6.fr/rules/kmalloc.html > and > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/pci_free_consistent.cocci These scripts for the semantic patch language show some

[git pull] Input updates for v5.0-rc6

2019-02-16 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem: - tweaks to Elan drivers (both PS/2 and I2C) to support new devices. Also revert of one of IDs as that device should really be driven by

Re: [PATCH] trace: skip hwasan

2019-02-16 Thread Dmitry Vyukov
On Sun, Feb 17, 2019 at 5:34 AM Qian Cai wrote: > > Enabling function tracer with CONFIG_KASAN_SW_TAGS=y (hwasan) tracer > causes the whole system frozen on ThunderX2 systems with 256 CPUs, > because there is a burst of too much pointer access, and then KASAN will > dereference each byte of the

[PATCH] usb: core: add option of only authorizing internal devices

2019-02-16 Thread Dmitry Torokhov
On Chrome OS we want to use USBguard to potentially limit access to USB devices based on policy. We however to do not want to wait for userspace to come up before initializing fixed USB devices to not regress our boot times. This patch adds option to instruct the kernel to only authorize devices

Re: [PATCH] tty: serial: msm_serial: Remove __init from msm_console_setup()

2019-02-16 Thread Bjorn Andersson
On Sat 16 Feb 21:05 PST 2019, Jeffrey Hugo wrote: > Due to the complexities of modern Qualcomm SoCs, about a half dozen drivers > must successfully probe before the clocks for the console are present, and > the console can successfully probe. Depending on several random factors > such as probe

Re: [PATCH v3 0/3] input: goodix - support Goodix gt5688

2019-02-16 Thread Dmitry Torokhov
On Fri, Feb 15, 2019 at 03:11:50PM +0100, Guido Günther wrote: > Besides the support for gt5688 two more minimal changes piled up so I'm > folding these in here. One is a doc update for the goodix bindings, the > other one makes it a bit simpler to figure out configuration problems > (like lack of

[GIT PULL] KVM changes for Linux 5.0-rc7

2019-02-16 Thread Paolo Bonzini
Linus, The following changes since commit d13937116f1e82bf508a6325111b322c30c85eb9: Linux 5.0-rc6 (2019-02-10 14:42:20 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to

Re: [PATCH v2] Input: synaptics_i2c - remove redundant spinlock

2019-02-16 Thread Dmitry Torokhov
On Sun, Feb 17, 2019 at 01:10:53AM -0500, thesve...@gmail.com wrote: > From: Sven Van Asbroeck > > Remove a leftover spinlock. > > This was required back when mod_delayed_work() did not exist, > and had to be implemented with a cancel + queue. See > commit e7c2f967445d ("workqueue: use

[PATCH] scsi: clean obsolete return values of eh_timed_out

2019-02-16 Thread Avri Altman
Those are no longer in use since commit 242f9dcb8ba6 ("block: unify request timeout handling"). Signed-off-by: Avri Altman --- include/scsi/scsi_host.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index

Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()

2019-02-16 Thread Balbir Singh
On Sat, Feb 16, 2019 at 08:22:12AM -0600, Segher Boessenkool wrote: > Hi all, > > On Sat, Feb 16, 2019 at 09:55:11PM +1100, Balbir Singh wrote: > > On Thu, Feb 14, 2019 at 05:23:39PM +1100, Michael Ellerman wrote: > > > In v4.20 we changed our pgd/pud_present() to check for _PAGE_PRESENT > > >

[PATCH v2] Input: synaptics_i2c - remove redundant spinlock

2019-02-16 Thread thesven73
From: Sven Van Asbroeck Remove a leftover spinlock. This was required back when mod_delayed_work() did not exist, and had to be implemented with a cancel + queue. See commit e7c2f967445d ("workqueue: use mod_delayed_work() instead of __cancel + queue") schedule_delayed_work() and

Re: [PATCH] scripts/sign-file.c: Use CMS if LibreSSL >= 2.6.0 is present

2019-02-16 Thread Alec Ari
Scratch that patch, error is still there on module installation. Sorry about that! I thought that should have fixed it, I must be missing something here. Alec

Re: [PATCH] Input: st1232 - include gpio/consumer.h header for gpiod_set_value_cansleep()

2019-02-16 Thread Dmitry Torokhov
On Wed, Feb 13, 2019 at 12:19:58PM +0100, Martin Kepplinger wrote: > gpiod_set_value_cansleep() needs it's declaration in the corresponding > header. This fixes build errors like > >drivers/input/touchscreen/st1232.c: In function 'st1232_ts_power': > >>

Re: [PATCH] Input: synaptics_i2c - remove redundant spinlock

2019-02-16 Thread Dmitry Torokhov
Hi Sven, On Mon, Feb 11, 2019 at 08:34:42PM -0500, thesve...@gmail.com wrote: > @@ -372,13 +371,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c > *touch) > static void synaptics_i2c_reschedule_work(struct synaptics_i2c *touch, > unsigned

Re: [PATCH][next] mtd: spi-nor: cadence-quadspi: fix spelling mistake: "Couldnt't" -> "Couldn't"

2019-02-16 Thread Vignesh R
On 15/02/19 8:45 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_error message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/mtd/spi-nor/cadence-quadspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v1] Input: st-keyscan - fix potential zalloc NULL dereference

2019-02-16 Thread Dmitry Torokhov
On Tue, Feb 12, 2019 at 04:30:55PM +0100, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch fixes the following static checker warning: > > drivers/input/keyboard/st-keyscan.c:156 keyscan_probe() > error: potential zalloc NULL dereference: 'keypad_data->input_dev' > >

Re: [PATCH v2] LSM: Ignore "security=" when "lsm=" is specified

2019-02-16 Thread Tetsuo Handa
On 2019/02/14 1:05, Casey Schaufler wrote: > On 2/12/2019 10:23 AM, Kees Cook wrote: >> To avoid potential confusion, explicitly ignore "security=" when "lsm=" is >> used on the command line, and report that it is happening. >> >> Suggested-by: Tetsuo Handa >> Signed-off-by: Kees Cook > >

Fwd: [PATCH] scripts/sign-file.c: Use CMS if LibreSSL >= 2.6.0 is present

2019-02-16 Thread Alec Ari
Hello, it seems it's impossible to add tabs via gmail. The appropriate patch has been attached to kernel bugzilla #202159 Sorry about this, hitting tab toggles highlighted selection, using "more indent" didn't do the trick I guess. The patch works here but I suppose not for the one who reported

[PATCH] tty: serial: msm_serial: Remove __init from msm_console_setup()

2019-02-16 Thread Jeffrey Hugo
Due to the complexities of modern Qualcomm SoCs, about a half dozen drivers must successfully probe before the clocks for the console are present, and the console can successfully probe. Depending on several random factors such as probe order and modules vs builtin, msm_serial may not be able to

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-16 Thread Alexandre Oliva
On Feb 11, 2019, Aaro Koskinen wrote: > ATA (libata) CS5536 driver is having issues with spurious IRQs and often > disables IRQs completely during the boot. You should see a warning > in dmesg. This was the reason for slowness on my FuLoong mini-PC. A > workaround is to switch to old IDE driver.

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-16 Thread Alexandre Oliva
On Feb 11, 2019, Tom Li wrote: > We've just identified and confirmed the source of the shutdown problem a > few days ago on this mailing list. > You can pick up the patch from: > https://lore.kernel.org/lkml/20190207205812.ga11...@darkstar.musicnaut.iki.fi/ > A patch has been authored and

[PATCH v2 4/4] arm64: dts: qcom: msm8998: Add mmcc node

2019-02-16 Thread Jeffrey Hugo
Add MSM8998 Multimedia Clock Controller DT node. Signed-off-by: Jeffrey Hugo --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index

[PATCH] trace: skip hwasan

2019-02-16 Thread Qian Cai
Enabling function tracer with CONFIG_KASAN_SW_TAGS=y (hwasan) tracer causes the whole system frozen on ThunderX2 systems with 256 CPUs, because there is a burst of too much pointer access, and then KASAN will dereference each byte of the shadow address for the tag checking which will kill all the

[PATCH v2 3/4] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver

2019-02-16 Thread Jeffrey Hugo
Add a driver for the multimedia clock controller found on MSM8998 based devices. This should allow most multimedia device drivers to probe and control their clocks. Signed-off-by: Jeffrey Hugo --- drivers/clk/qcom/Kconfig |9 + drivers/clk/qcom/Makefile

[PATCH v2 2/4] dt-bindings: clock: Add support for the MSM8998 mmcc

2019-02-16 Thread Jeffrey Hugo
Document the multimedia clock controller found on MSM8998 Signed-off-by: Jeffrey Hugo --- .../devicetree/bindings/clock/qcom,mmcc.txt | 21 +++ 1 file changed, 21 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt

[PATCH v2 1/4] clk: qcom: smd: Add XO clock for MSM8998

2019-02-16 Thread Jeffrey Hugo
The XO clock generally feeds into other clock controllers as the parent for a lot of clock generators. Drop the "fake" XO clock in GCC now that it is redundant can will cause a namespace conflict. Signed-off-by: Jeffrey Hugo --- drivers/clk/qcom/clk-smd-rpm.c | 24

[PATCH v2 0/4] MSM8998 Multimedia Clock Controller

2019-02-16 Thread Jeffrey Hugo
The multimedia clock controller (mmcc) is the main clock controller for the multimedia subsystem and is required to enable things like display and camera. Based upon the "Rewrite clk parent handling" series [1] to simplify handling of the external clocks that feed into the MMCC. Assumes the

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Al Viro
On Sun, Feb 17, 2019 at 03:41:21AM +, Arthur Gautier wrote: > On Sat, Feb 16, 2019 at 11:47:02PM +, Al Viro wrote: > > On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: > > > > > What is the actual problem? We’re not actually demand-faulting this > > > data, are we? Are

[PATCH v3 0/2] Work around for Hisilicon CPPC cpufreq

2019-02-16 Thread Xiongfeng Wang
Hisilicon chips do not support delivered performance counter register and reference performance counter register. But the platform can calculate the real performance using its own method. This patch provide a workaround for this problem, and other platforms can also use this workaround framework.

[PATCH v3 2/2] cpufreq / cppc: Work around for Hisilicon CPPC cpufreq

2019-02-16 Thread Xiongfeng Wang
Hisilicon chips do not support delivered performance counter register and reference performance counter register. But the platform can calculate the real performance using its own method. We reuse the desired performance register to store the real performance calculated by the platform. After the

[PATCH v3 1/2] ACPI / CPPC: Add a helper to get desired performance

2019-02-16 Thread Xiongfeng Wang
This patch add a helper to get the value of desired performance register. Signed-off-by: Xiongfeng Wang --- drivers/acpi/cppc_acpi.c | 39 +++ include/acpi/cppc_acpi.h | 1 + 2 files changed, 40 insertions(+) diff --git a/drivers/acpi/cppc_acpi.c

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Arthur Gautier
On Sat, Feb 16, 2019 at 11:47:02PM +, Al Viro wrote: > On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: > > > What is the actual problem? We’re not actually demand-faulting this data, > > are we? Are we just overrunning the buffer because the from_user helpers > > are too

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-16 Thread Christopher Lameter
On Fri, 15 Feb 2019, Ira Weiny wrote: > > > > for filesystems and processes. The only problems come in for the things > > > > which bypass the page cache like O_DIRECT and DAX. > > > > > > It makes a lot of sense since the filesystems play COW etc games with the > > > pages and RDMA is very much

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Andy Lutomirski
> On Feb 16, 2019, at 3:47 PM, Al Viro wrote: > >> On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: >> >> What is the actual problem? We’re not actually demand-faulting this data, >> are we? Are we just overrunning the buffer because the from_user helpers >> are too

Re: [net-next, PATCH v2] net: stmmac: use correct define to get rx timestamp on GMAC4

2019-02-16 Thread David Miller
From: Alexandre Torgue Date: Thu, 14 Feb 2019 17:03:44 +0100 > In dwmac4_wrback_get_rx_timestamp_status we looking for a RX timestamp. > For that receive descriptors are handled and so we should use defines > related to receive descriptors. It'll no change the functional behavior > as

Re: [PATCH v3 6/6] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system

2019-02-16 Thread Baoquan He
Hi Mike, On 02/16/19 at 10:00pm, Baoquan He wrote: > On SGI UV system, kernel often hangs when KASLR is enabled. Disabling > KASLR makes kernel work well. I wrap codes which calculate the size of the direct mapping section into a new function calc_direct_mapping_size() as Ingo suggested. This

ptrace() with multithreaded tracer

2019-02-16 Thread Niklas Hambüchen
Hello, it would be awesome if somebody in the know could confirm or refute a suspicion on ptrace() that we have. The man page says: Attachment and subsequent commands are per thread: in a multi‐ threaded process, every thread can be individually attached to a (potentially

Re: [GIT PULL] auxdisplay for v5.0-rc7

2019-02-16 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 20:22:26 +0100: > https://github.com/ojeda/linux.git tags/auxdisplay-for-linus-v5.0-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9a7dcde4a661ccad2b641e873b15ce26bf302c4e Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] more nfsd fixes for 5.0

2019-02-16 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 17:01:02 -0500: > git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.0-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/88fe73cb804abc3d209a06f6221a7108d89ff04f Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] Please pull additional NFS client fixes for 5.0

2019-02-16 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 16:47:50 -0500: > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-5.0-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55638c520bb7b92999b6f0867ba135b6aeafc8d7 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] Compiler Attributes for v5.0-rc7

2019-02-16 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Feb 2019 20:10:59 +0100: > https://github.com/ojeda/linux.git tags/compiler-attributes-for-linus-v5.0-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0b999ae3614d09d97a1575936bcee884f912b10e Thank you! -- Deet-doot-dot, I am

Re: [GIT PULL] ARM: SoC fixes for 5.0

2019-02-16 Thread pr-tracker-bot
The pull request you sent on Sat, 16 Feb 2019 21:20:48 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/64c0133eb88a3b0c11c42580a520fe78b71b3932 Thank you! -- Deet-doot-dot, I am a

Re: [RFC PATCH v1 04/25] printk-rb: add writer interface

2019-02-16 Thread John Ogness
Hi Petr, I've made changes to the patch that hopefully align with what you are looking for. I would appreciate it if you could go over it and see if the changes are in the right direction. And if so, you should decide whether I should make these kinds of changes for the whole series and submit a

Re: [RFC PATCH 09/27] vfs: Allow mounting to other namespaces

2019-02-16 Thread Al Viro
On Fri, Feb 15, 2019 at 04:08:46PM +, David Howells wrote: > Currently sys_move_mount() and sys_mount(MS_MOVE) prevent the caller from > moving a mount into a namespace not their own. Relax this such that any > mount can be mounted onto any given mountpoint provided that the source > mount is

Re: [RFC PATCH 08/27] containers, vfs: Honour CONTAINER_NEW_EMPTY_FS_NS

2019-02-16 Thread Al Viro
On Fri, Feb 15, 2019 at 04:08:29PM +, David Howells wrote: > + mnt_ns = alloc_mnt_ns(container->cred->user_ns, false); > + if (IS_ERR(mnt_ns)) { > + ret = PTR_ERR(mnt_ns); > + goto out_fd; > + } > + > + mnt = real_mount(path->mnt); > +

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Pavel Machek
> >I don't pretend to fully understand it, _but_ hw_pattern should really > >describe the pattern LED should do, not whether it reacts to charging > >or not. > > Then we are back to step 1 of the discussion, that we need another > mechanism outside of the trigger to select if the LED shows the

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Al Viro
On Sat, Feb 16, 2019 at 11:47:02PM +, Al Viro wrote: > On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: > > > What is the actual problem? We’re not actually demand-faulting this data, > > are we? Are we just overrunning the buffer because the from_user helpers > > are too

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Al Viro
On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: > What is the actual problem? We’re not actually demand-faulting this data, > are we? Are we just overrunning the buffer because the from_user helpers are > too clever? Can we fix it for real by having the fancy helpers do

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-16 Thread Alexandre Oliva
On Feb 11, 2019, Aaro Koskinen wrote: > ATA (libata) CS5536 driver is having issues with spurious IRQs and often > disables IRQs completely during the boot. You should see a warning > in dmesg. Yup, thanks, it shows up first thing during boot. I hadn't seen that one in a while. Thanks. --

Re: [PATCH] gpu: drm: radeon: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

2019-02-16 Thread Alex Deucher
On Sat, Feb 16, 2019 at 1:01 AM Lukas Wunner wrote: > > On Fri, Feb 15, 2019 at 11:01:04AM -0500, Alex Deucher wrote: > > On Fri, Feb 15, 2019 at 10:39 AM Rafael J. Wysocki > > wrote: > > > On HP ProBook 4540s, if PM-runtime is enabled in the radeon driver > > > and the direct-complete

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Andy Lutomirski
> On Feb 16, 2019, at 2:50 PM, Andy Lutomirski wrote: > > > >>> On Feb 16, 2019, at 12:18 PM, Thomas Gleixner wrote: >>> On Sat, 16 Feb 2019, Jann Horn wrote: On Sat, Feb 16, 2019 at 12:59 AM wrote: When extracting an initramfs, a filename may be near an allocation

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Andy Lutomirski
> On Feb 16, 2019, at 12:18 PM, Thomas Gleixner wrote: > >> On Sat, 16 Feb 2019, Jann Horn wrote: >>> On Sat, Feb 16, 2019 at 12:59 AM wrote: >>> When extracting an initramfs, a filename may be near an allocation boundary. >>> Should that happen, strncopy_from_user will invoke

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-16 Thread Dave Chinner
On Fri, Feb 15, 2019 at 03:38:29PM -0800, Ira Weiny wrote: > On Fri, Feb 15, 2019 at 03:00:31PM -0700, Jason Gunthorpe wrote: > > On Fri, Feb 15, 2019 at 06:31:36PM +, Christopher Lameter wrote: > > > On Fri, 15 Feb 2019, Matthew Wilcox wrote: > > > > > > > > Since RDMA is something similar:

Re: [PATCH v2] parisc: Fix ptrace syscall number modification

2019-02-16 Thread Dmitry V. Levin
On Sat, Feb 16, 2019 at 05:55:24PM +0100, Helge Deller wrote: > On 16.02.19 14:10, Dmitry V. Levin wrote: > > Commit 910cd32e552e ("parisc: Fix and enable seccomp filter support") > > introduced a regression in ptrace-based syscall tampering: when tracer > > changes syscall number to -1, the

[PATCH] netfilter/ipvs: Fix unused variable warning

2019-02-16 Thread Borislav Petkov
From: Borislav Petkov Move the local variable 'ret' into the IP_VS_IPV6 ifdef so that the unused variable warning doesn't fire for randconfig builds with CONFIG_IP_VS_IPV6 disabled. Fixes: 098e13f5b21d ("ipvs: fix dependency on nf_defrag_ipv6") Cc: Andrea Claudi Cc: coret...@netfilter.org Cc:

Dear Friend (Assalamu Alaikum),

2019-02-16 Thread AISHA GADDAFI
Dear Friend (Assalamu Alaikum), I came across your e-mail contact prior a private ?search while in need of your assistance. My name is Aisha Al-Qaddafi a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Gaddafi). I

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-16 Thread Meelis Roos
The result of the bisection is [88dbcbb3a4847f5e6dfeae952d3105497700c128] blkdev: avoid migration stalls for blkdev pages Is that result relevant for the problem or should I continue bisecting between 4.20.0 and the so far first bad commit? Can you try reverting the commit and see if it

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Thomas Gleixner
On Sat, 16 Feb 2019, Thomas Gleixner wrote: > On Sat, 16 Feb 2019, Jann Horn wrote: > > On Sat, Feb 16, 2019 at 12:59 AM wrote: > > > When extracting an initramfs, a filename may be near an allocation > > > boundary. > > > Should that happen, strncopy_from_user will invoke unsafe_get_user which

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Hans de Goede
Hi, On 2/16/19 10:54 PM, Jacek Anaszewski wrote: On 2/16/19 8:37 PM, Pavel Machek wrote: Hi! I think that should work fine, which means that we can use the timer and pattern trigger support for the blinking and breathing modes. That still leaves the switching between user and hw-control

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Jacek Anaszewski
On 2/16/19 8:37 PM, Pavel Machek wrote: Hi! I think that should work fine, which means that we can use the timer and pattern trigger support for the blinking and breathing modes. That still leaves the switching between user and hw-control modes, as discussed the hw-controlled mode could be

Re: [PATCH] xarray: Document erasing entries during iteration

2019-02-16 Thread Wei Yang
On Thu, Feb 14, 2019 at 02:33:00PM -0800, Matthew Wilcox wrote: >On Thu, Feb 14, 2019 at 10:16:52PM +, Wei Yang wrote: >> On Wed, Feb 13, 2019 at 08:12:58AM -0800, Matthew Wilcox wrote: >> >The only remaining user of the radix tree in that tree is the IDR. So >> >now I'm converting the IDR

ax25: fix possible use-after-free

2019-02-16 Thread f6bvp
Patch applied successfully on Linux draws-f6bvp 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux However ax25_route_lock_use and ax25_route_lock_unuse() are not declared and compile failed. make : on entre dans le répertoire « /usr/src/linux-headers-4.14.79-v7+ » CC [M]

Re: find_get_entries_tag regression bisected

2019-02-16 Thread Matthew Wilcox
On Sat, Feb 16, 2019 at 09:29:48AM -0800, Matthew Wilcox wrote: > On Sat, Feb 16, 2019 at 07:35:11AM -0800, Matthew Wilcox wrote: > > Another way to fix this would be to mask the address in dax_entry_mkclean(), > > but I think this is cleaner. > > That's clearly rubbish, dax_entry_mkclean() can't

[PATCH] dm crypt: fix memory leak in dm_crypt_integrity_io_alloc() error path

2019-02-16 Thread sultan
From: Sultan Alsawaf dm_crypt_integrity_io_alloc() allocates space for an integrity payload but doesn't free it in the error path, leaking memory. Add a bio_integrity_free() invocation upon error to fix the memory leak. Signed-off-by: Sultan Alsawaf --- drivers/md/dm-crypt.c | 4 +++- 1 file

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Hans de Goede
Hi, On 2/16/19 8:37 PM, Pavel Machek wrote: Hi! I think that should work fine, which means that we can use the timer and pattern trigger support for the blinking and breathing modes. That still leaves the switching between user and hw-control modes, as discussed the hw-controlled mode could

Re: void __iomem *addr should be const

2019-02-16 Thread Hugo Lefeuvre
Hi, > The const makes perfectly sense and we should have consistent state all > over the place. Thanks, I will submit a patch addressing this issue soon. regards, Hugo -- Hugo Lefeuvre (hle)|www.owl.eu.com RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD

Re: [PATCH] staging/android: use multiple futex wait queues

2019-02-16 Thread Hugo Lefeuvre
Hi, > Have you tested this? I have finally set up a cuttlefish test env and tested both my first patch set[0] and this patch (v2). My first patch set works fine. I have nothing to say about it. > Noticed any performance speedups or slow downs? This patch doesn't work. The boot process goes

Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

2019-02-16 Thread Heiko Stuebner
Am Samstag, 16. Februar 2019, 02:13:25 CET schrieb Alexandru M Stan: > On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner wrote: > > > > Hi Enric, > > > > Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra: > > > In order to use earlycon, the stdout-path property needs to be set

[GIT PULL] ARM: SoC fixes for 5.0

2019-02-16 Thread Arnd Bergmann
The following changes since commit d13937116f1e82bf508a6325111b322c30c85eb9: Linux 5.0-rc6 (2019-02-10 14:42:20 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tags/armsoc-fixes for you to fetch changes up to

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Thomas Gleixner
On Sat, 16 Feb 2019, Jann Horn wrote: > On Sat, Feb 16, 2019 at 12:59 AM wrote: > > When extracting an initramfs, a filename may be near an allocation boundary. > > Should that happen, strncopy_from_user will invoke unsafe_get_user which > > may cross the allocation boundary. Should that happen,

Re: [PATCHv2] random: Make /dev/random wait for crng_ready

2019-02-16 Thread Bernd Edlinger
On 2/16/19 7:23 PM, Theodore Y. Ts'o wrote: > > This really isn't a correct way to fix things; since the blocking_pool > used for /dev/random and the CRNG state are different things, and are > fed by different sources of entropy. > It is interesting that random_poll does only look at

Re: [PATCH] VMCI: Support upto 64-bit PPNs

2019-02-16 Thread gre...@linuxfoundation.org
On Fri, Feb 15, 2019 at 04:32:47PM +, Vishnu DASA wrote: > diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h > index b724ef7005de..eaa1e762bf06 100644 > --- a/include/linux/vmw_vmci_defs.h > +++ b/include/linux/vmw_vmci_defs.h > @@ -45,6 +45,7 @@ > #define

Re: 4.20.7: pl2303 not working (post-4.19 regression) (limited info so far, not yet bisected)

2019-02-16 Thread Greg KH
On Sat, Feb 16, 2019 at 04:26:30PM +, Nix wrote: > So I just tried to connect up to my ancient Soekris firewall's serial > console to try to bisect a problem where it stopped booting in 4.20, and > found I couldn't. > > minicom says: > > minicom: cannot open /dev/ttyUSB0: Input/output error

Re: [PATCH] Use the correct style for SPDX License Identifier in all header files across the kernel

2019-02-16 Thread Greg Kroah-Hartman
On Sat, Feb 16, 2019 at 04:04:02PM +0530, Nishad Kamdar wrote: > 816 files changed, 970 insertions(+), 970 deletions(-) You have to break this up into subsystems at the very least, no one person can take this patch, sorry. greg k-h

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Pavel Machek
Hi! > I think that should work fine, which means that we can use the timer and > pattern trigger support for the blinking and breathing modes. > > That still leaves the switching between user and hw-control modes, > as discussed the hw-controlled mode could be modelled as a

xfstest status update - possible regression outside cifs in rc6

2019-02-16 Thread Steve French
Have been looking at the cifs buildbot's automated xfstest results (azure test bucket in this case), and noticed possible regression outside cifs with 5.0-rc6. Various xfstests started to fail on rc6 (didn't fail on rc5 or earlier, and no cifs changes involved). Presumably someone else caught

[PATCH] rpmsg: add clock API redirection driver

2019-02-16 Thread Xiang Xiao
From: Yanlin Zhu which could redirect clk API from remote to the kernel Signed-off-by: Yanlin Zhu --- drivers/rpmsg/Kconfig | 10 ++ drivers/rpmsg/Makefile| 1 + drivers/rpmsg/rpmsg_clk.c | 284 ++ 3 files changed, 295 insertions(+)

[PATCH V3] Add syslog redirection driver

2019-02-16 Thread Xiang Xiao
Changes vs. V2: - Remove memrchr function - Output message line by line Guiding Li (1): rpmsg: add syslog redirection driver drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 + drivers/rpmsg/rpmsg_syslog.c | 163 +++ 3

[PATCH V3] rpmsg: add syslog redirection driver

2019-02-16 Thread Xiang Xiao
From: Guiding Li This driver allows the remote processor to redirect the output of syslog or printf into the kernel log, which is very useful to see what happen in the remote side. Signed-off-by: Guiding Li --- drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 +

Re: void __iomem *addr should be const

2019-02-16 Thread Thomas Gleixner
On Sun, 10 Feb 2019, Hugo Lefeuvre wrote: > __iomem *addr seems to lack a const qualifier in the ioread* definitions > from include/asm-generic/iomap.h (other definitions such as > asm-generic/io.h do have the const). > > This issue was briefly discussed a while ago[0] but the outcome is not >

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-16 Thread Manoj
Joel Fernandes writes: > On Thu, Feb 14, 2019 at 07:19:29PM -0800, Alexei Starovoitov wrote: >> On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote: >> > Introduce in-kernel headers and other artifacts which are made available >> > as an archive through proc

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-16 Thread Hans de Goede
Hi, On 2/16/19 6:02 PM, Jacek Anaszewski wrote: Hi Hans, On 2/16/19 12:14 AM, Hans de Goede wrote: Hi, On 2/15/19 11:31 PM, Jacek Anaszewski wrote: On 2/15/19 11:26 PM, Hans de Goede wrote: I think that should work fine, which means that we can use the timer and pattern trigger support

Re: [v6] coccinelle: semantic code search for missing put_device()

2019-02-16 Thread Markus Elfring
> In a function, for a local variable obtained by of_find_device_by_node(), I got a software understanding where such a variable can not be obtained from this function call. The return value (like a pointer in this use case) can be stored there. > v6: > - to be double sure, replace >dev with

Re: [LSF/MM TOPIC] FS, MM, and stable trees

2019-02-16 Thread Theodore Y. Ts'o
On Thu, Feb 14, 2019 at 06:48:22PM -0800, James Bottomley wrote: > Well, we differ on the value of running regression tests, then. The > whole point of a test infrastructure is that it's simple to run 'make > check' in autoconf parlance. xfstests does provide a useful baseline > set of

Re: [PATCHv2] random: Make /dev/random wait for crng_ready

2019-02-16 Thread Theodore Y. Ts'o
On Fri, Feb 15, 2019 at 01:58:20PM +, Bernd Edlinger wrote: > Reading from /dev/random may return data while the getrandom > syscall is still blocking. > > Those bytes are not yet cryptographically secure. > > The first byte from /dev/random can have as little > as 8 bits entropy estimation.

[PATCH] ARM: dts: sun7i: add pinctrl for missing uart mux options

2019-02-16 Thread Mans Rullgard
This adds pinctrl settings for various missing uart options. Signed-off-by: Mans Rullgard --- arch/arm/boot/dts/sun7i-a20.dtsi | 45 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index

Re: [PATCH 4.20 237/352] igb: Fix an issue that PME is not enabled during runtime suspend

2019-02-16 Thread niveditas98
Bugzilla https://bugzilla.kernel.org/show_bug.cgi?id=202571 The igb commit is commit fb29f76cc5668d8fc9e2b04ebfaf4de4f62e1866 On Tue, Feb 12, 2019 at 7:21 PM Arvind Sankar wrote: > > After upgrading to 4.20.8, I got a WARN in my dmesg and I suspect this > change. Reverting it removes this

Re: [PATCH] random: fix inconsistent spinlock usage

2019-02-16 Thread Theodore Y. Ts'o
On Fri, Feb 15, 2019 at 02:03:06PM -0800, Sultan Alsawaf wrote: > All users of the struct entropy_store spinlock use the irqsave spinlock > variant. > Spinlock users of the same lock should use be consistent in their use of a > certain spinlock primitive, which makes add_interrupt_randomness()'s

Re: ext4 corruption on alpha with 4.20.0-09062-gd8372ba8ce28

2019-02-16 Thread Theodore Y. Ts'o
On Fri, Feb 15, 2019 at 06:59:48PM +0200, Meelis Roos wrote: > The result of the bisection is > [88dbcbb3a4847f5e6dfeae952d3105497700c128] blkdev: avoid migration stalls for > blkdev pages > > Is that result relevant for the problem or should I continue bisecting > between 4.20.0 and the so far

Re: find_get_entries_tag regression bisected

2019-02-16 Thread Matthew Wilcox
On Sat, Feb 16, 2019 at 07:35:11AM -0800, Matthew Wilcox wrote: > Another way to fix this would be to mask the address in dax_entry_mkclean(), > but I think this is cleaner. That's clearly rubbish, dax_entry_mkclean() can't possibly mask the address. It might be mis-aligned in another process.

[patch v6 6/7] PCI/MSI: Remove obsolete sanity checks for multiple interrupt sets

2019-02-16 Thread Thomas Gleixner
Multiple interrupt sets for affinity spreading are now handled in the core code and the number of sets and their size is recalculated via a driver supplied callback. That avoids the requirement to invoke pci_alloc_irq_vectors_affinity() with the arguments minvecs and maxvecs set to the same value

[patch v6 5/7] genirq/affinity: Remove the leftovers of the original set support

2019-02-16 Thread Thomas Gleixner
Now that the NVME driver is converted over to the calc_set() callback, the workarounds of the original set support can be removed. Signed-off-by: Thomas Gleixner --- kernel/irq/affinity.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) Index:

[patch v6 7/7] genirq/affinity: Add support for non-managed affinity sets

2019-02-16 Thread Thomas Gleixner
Some drivers need an extra set of interrupts which should not be marked managed, but should get initial interrupt spreading. Add a bitmap to struct irq_affinity which allows the driver to mark a particular set of interrupts as non managed. Check the bitmap during spreading and use the result to

[patch v6 3/7] genirq/affinity: Add new callback for (re)calculating interrupt sets

2019-02-16 Thread Thomas Gleixner
From: Ming Lei The interrupt affinity spreading mechanism supports to spread out affinities for one or more interrupt sets. A interrupt set contains one or more interrupts. Each set is mapped to a specific functionality of a device, e.g. general I/O queues and read I/O queus of multiqueue block

[patch v6 4/7] nvme-pci: Simplify interrupt allocation

2019-02-16 Thread Thomas Gleixner
From: Ming Lei The NVME PCI driver contains a tedious mechanism for interrupt allocation, which is necessary to adjust the number and size of interrupt sets to the maximum available number of interrupts which depends on the underlying PCI capabilities and the available CPU resources. It works

[patch v6 2/7] genirq/affinity: Store interrupt sets size in struct irq_affinity

2019-02-16 Thread Thomas Gleixner
From: Ming Lei The interrupt affinity spreading mechanism supports to spread out affinities for one or more interrupt sets. A interrupt set contains one or more interrupts. Each set is mapped to a specific functionality of a device, e.g. general I/O queues and read I/O queus of multiqueue block

[patch v6 1/7] genirq/affinity: Code consolidation

2019-02-16 Thread Thomas Gleixner
All information and calculations in the interrupt affinity spreading code is strictly unsigned int. Though the code uses int all over the place. Convert it over to unsigned int. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h | 20 +--- kernel/irq/affinity.c |

[patch v6 0/7] genirq/affinity: Overhaul the multiple interrupt sets support

2019-02-16 Thread Thomas Gleixner
This is the final update to the series with a few corner cases fixes vs. V5 which can be found here: https://lkml.kernel.org/r/20190214204755.819014...@linutronix.de The series applies against: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master and is also available from:

Re: [PATCH net-next 1/3] net: stmmac: Fix NAPI poll in TX path when in multi-queue

2019-02-16 Thread Lendacky, Thomas
On 2/15/19 6:35 PM, Florian Fainelli wrote: > On 2/15/19 5:42 AM, Jose Abreu wrote: >> Commit 8fce33317023 introduced the concept of NAPI per-channel and >> independent cleaning of TX path. >> >> This is currently breaking performance in some cases. The scenario >> happens when all packets are

  1   2   >