Re: [v2,1/2] mtd: spi-nor: Add support for EN25Q80A

2019-02-20 Thread Boris Brezillon
From: Boris Brezillon On Mon, 2019-02-18 at 12:04:43 UTC, Schrempf Frieder wrote: > From: Frieder Schrempf > > This adds support for the EON EN25Q80A, a 8Mb SPI NOR chip. > It is used on i.MX6 boards by Kontron Electronics GmbH > (N60xx, N61xx). > It was only tested with a single data line

Re: [v2,2/2] mtd: spi-nor: Add support for MX25V8035F

2019-02-20 Thread Boris Brezillon
From: Boris Brezillon On Mon, 2019-02-18 at 12:04:43 UTC, Schrempf Frieder wrote: > From: Frieder Schrempf > > This adds support for the Macronix MX25V8035F, a 8Mb SPI NOR chip. > It is used on i.MX6UL/ULL SoMs by Kontron Electronics GmbH (N631x). > It was only tested with a single data line

[PATCH] PM-runtime: fix deadlock when canceling hrtimer

2019-02-20 Thread Vincent Guittot
When rpm_resume() desactivates the autosuspend timer, it should only try to cancel hrtimer but not wait for the handler to finish because both rpm_resume() and pm_suspend_timer_fn() are taking the power.lock. We can have the deadlock sequence: CPU0 CPU1 rpm_resume()

Re: [next] mtd: spi-nor: cadence-quadspi: fix spelling mistake: "Couldnt't" -> "Couldn't"

2019-02-20 Thread Boris Brezillon
From: Boris Brezillon On Fri, 2019-02-15 at 15:15:47 UTC, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a dev_error message. Fix it. > > Signed-off-by: Colin Ian King > Reviewed-by: Tudor Ambarus Applied to http://git.infradead.org/linux-mtd.git spi-nor/next,

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-20 Thread Enric Balletbo i Serra
Hi, On 21/2/19 0:09, Randy Dunlap wrote: > On 2/20/19 2:11 PM, Nick Crews wrote: >> In the initial version of the Wilco EC Driver, the >> dependency order was wrong. It before was possible to >> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without >> having CONFIG_CROS_EC_LPC_MEC. This was

Re: [PATCH -next] platform/chrome: Fix off-by-one error in wilco_ec/debugfs.c

2019-02-20 Thread Enric Balletbo i Serra
Hi, On 20/2/19 23:15, Nick Crews wrote: > Hi Enric, > > On Wed, Feb 20, 2019 at 3:06 PM Enric Balletbo i Serra > wrote: >> >> Hi Nick, >> >> Thanks for the patch. >> >> On 20/2/19 22:58, Nick Crews wrote: >>> Before, in debugfs.c it was possible to supply only the message type, >>> and not

Re: [Xen-devel] [PATCH RFC 00/39] x86/KVM: Xen HVM guest support

2019-02-20 Thread Juergen Gross
On 21/02/2019 00:39, Marek Marczykowski-Górecki wrote: > On Wed, Feb 20, 2019 at 08:15:30PM +, Joao Martins wrote: >> 2. PV Driver support (patches 17 - 39) >> >> We start by redirecting hypercalls from the backend to routines >> which emulate the behaviour that PV backends expect i.e.

Re: [PATCH RFC v2 4/4] PCI: hotplug: Add quirk For Dell nvme pcie switches

2019-02-20 Thread Lukas Wunner
On Tue, Feb 19, 2019 at 07:20:30PM -0600, Alexandru Gagniuc wrote: > --- a/drivers/pci/hotplug/pciehp_hpc.c > +++ b/drivers/pci/hotplug/pciehp_hpc.c > @@ -952,3 +952,23 @@ DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_QCOM, 0x0400, > PCI_CLASS_BRIDGE_PCI, 8,

Re: [RESEND PATCH] amba: Allow pclk to be controlled by power domain

2019-02-20 Thread Ulf Hansson
On Tue, 19 Feb 2019 at 07:43, Bjorn Andersson wrote: > > On Tue 05 Feb 06:58 PST 2019, Ulf Hansson wrote: > > > On Thu, 31 Jan 2019 at 03:01, Bjorn Andersson > > wrote: > > > > > > On the Qualcomm SDM845 platform the apb_pclk is controlled as part of > > > the QDSS power/clock domain. Handle

linux-next: Tree for Feb 21

2019-02-20 Thread Stephen Rothwell
Hi all, Changes since 20190220: The v4l-dvb tree gained a conflict against the dma-mapping tree. The kvm tree lost its build failure. The xarray tree gained a build failure due to an interaction with the rdma tree for which I applied a merge fix patch. Non-merge commits (relative to Linus

Re: [PATCH] net: dsa: add missing phy address offset

2019-02-20 Thread Marcel Reichmuth
On Wed, Feb 20, 2019 at 08:31:22PM +0100, Andrew Lunn wrote: > On Wed, Feb 20, 2019 at 11:27:16AM -0800, Florian Fainelli wrote: > > On 2/20/19 10:15 AM, Marcel Reichmuth wrote: > > > > You are supposed to describe the port to PHY mapping using the binding, > > so for instance: > > > > ports { >

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Wei Yang
On Thu, Feb 21, 2019 at 03:18:22PM +0800, Huang, Ying wrote: >Greg Kroah-Hartman writes: > >> On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: >>> On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: >>> > On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote:

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-20 Thread Masami Hiramatsu
On Fri, 15 Feb 2019 12:47:13 -0500 Steven Rostedt wrote: > From: Changbin Du > > The userspace can ask kprobe to intercept strings at any memory address, > including invalid kernel address. In this case, fetch_store_strlen() > would crash since it uses general usercopy function, and user

Re: [PATCH v3 00/16] powerpc/32: Use BATs/LTLBs for STRICT_KERNEL_RWX

2019-02-20 Thread Christophe Leroy
Le 21/02/2019 à 07:31, Christophe Leroy a écrit : Le 21/02/2019 à 02:47, Michael Ellerman a écrit : Christophe Leroy writes: The purpose of this serie is to: - use BATs with STRICT_KERNEL_RWX on book3s (See patch 13 for details.) - use LTLBs with STRICT_KERNEL_RWX on 8xx (See patch 15

Re: [PATCH 05/11] x86 topology: export die_siblings

2019-02-20 Thread Len Brown
Hi Brice, Thank you for your suggestions! > Patches #4 and #5 are changing the meaning the core_siblings (in the > past, it always returned all threads in the entire package). All > existing user-space tools will see each die as a separate package until > they are updated to read die_siblings

Re: [PATCH v2 1/1] s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem

2019-02-20 Thread Christian Borntraeger
On 20.02.2019 14:12, Harald Freudenberger wrote: > On 18.02.19 19:08, Pierre Morel wrote: >> Libudev relies on having a subsystem link for non-root devices. To >> avoid libudev (and potentially other userspace tools) choking on the >> matrix device let us introduce a vfio_ap bus and with that

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-20 Thread Masami Hiramatsu
On Wed, 20 Feb 2019 11:42:17 -0500 Steven Rostedt wrote: > On Thu, 21 Feb 2019 01:04:53 +0900 > Masami Hiramatsu wrote: > > > > What about just adding 'u' to the end of the offset? Say you have a > > > data structure in kernel space that has a field in user space you want > > > to reference? >

Re: [PATCH RFC v2 2/4] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-20 Thread Lukas Wunner
On Tue, Feb 19, 2019 at 07:20:28PM -0600, Alexandru Gagniuc wrote: > @@ -213,6 +213,21 @@ void pciehp_handle_disable_request(struct controller > *ctrl) > ctrl->request_result = pciehp_disable_slot(ctrl, SAFE_REMOVAL); > } > > +static bool is_delayed_presence_up_event(struct controller

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Greg Kroah-Hartman
On Thu, Feb 21, 2019 at 03:18:22PM +0800, Huang, Ying wrote: > Greg Kroah-Hartman writes: > > > On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: > >> On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: > >> > On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang

Re: [PATCH] iwlwifi: mvm: Use div64_s64 instead of do_div in iwl_mvm_debug_range_resp

2019-02-20 Thread Luciano Coelho
On Wed, 2019-02-20 at 10:56 -0700, Nathan Chancellor wrote: > On Wed, Feb 20, 2019 at 11:51:34AM +0100, Arnd Bergmann wrote: > > On Tue, Feb 19, 2019 at 7:22 PM Nathan Chancellor > > wrote: > > > diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ftm- > > > initiator.c

Re: [LKP] [RFC PATCH] mm, memory_hotplug: fix off-by-one in is_pageblock_removable

2019-02-20 Thread Michal Hocko
On Thu 21-02-19 11:18:07, Rong Chen wrote: > Hi, > > The patch can fix the issue for me. Thanks for the confirmation! -- Michal Hocko SUSE Labs

Re: [PATCH] staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-20 Thread Nicholas Mc Guire
On Wed, Feb 20, 2019 at 10:25:24PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11: > warning: implicit conversion from enumeration type 'enum > halmac_cmd_process_status' to different enumeration type 'enum >

[PATCH V7 2/8] clocksource: tegra: add Tegra210 timer support

2019-02-20 Thread Joseph Lo
Add support for the Tegra210 timer that runs at oscillator clock (TMR10-TMR13). We need these timers to work as clock event device and to replace the ARMv8 architected timer due to it can't survive across the power cycle of the CPU core or CPUPORESET signal. So it can't be a wake-up source when

[PATCH V7 1/8] dt-bindings: timer: add Tegra210 timer

2019-02-20 Thread Joseph Lo
The Tegra210 timer provides fourteen 29-bit timer counters and one 32-bit timestamp counter. The TMRs run at either a fixed 1 MHz clock rate derived from the oscillator clock (TMR0-TMR9) or directly at the oscillator clock (TMR10-TMR13). Each TMR can be programmed to generate one-shot periodic, or

Re: [PATCH RFC v2 1/4] PCI: hotplug: Add support for disabling in-band presence

2019-02-20 Thread Lukas Wunner
On Tue, Feb 19, 2019 at 07:20:27PM -0600, Alexandru Gagniuc wrote: > @@ -846,6 +846,9 @@ struct controller *pcie_init(struct pcie_device *dev) > if (pdev->is_thunderbolt) > slot_cap |= PCI_EXP_SLTCAP_NCCS; > > + if (pdev->no_in_band_presence) > +

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Huang, Ying
Greg Kroah-Hartman writes: > On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: >> On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: >> > On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: >> > > On Mon, Feb 18, 2019 at 03:54:42PM +0800, kernel test robot

RE: [PATCH v4 6/6] usb:cdns3 Fix for stuck packets in on-chip OUT buffer.

2019-02-20 Thread Felipe Balbi
Hi, (please break your emails at 80-columns) Pawel Laszczak writes: >>> One more thing. Workaround has implemented algorithm that decide for which >>> endpoint it should be enabled. e.g for composite device MSC+NCM+ACM it >>> should work only for ACM OUT endpoint. >>> >> >>If ACM driver

Re: [PATCH v2] perf/core: use strndup_user() instead of buggy open-coded version

2019-02-20 Thread Song Liu
> On Feb 20, 2019, at 4:20 PM, Masami Hiramatsu wrote: > > Hi Jann, > > On Wed, 20 Feb 2019 17:54:43 +0100 > Jann Horn wrote: > >> The first version of this method was missing the check for >> `ret == PATH_MAX`; then such a check was added, but it didn't call kfree() >> on error, so there

Re: [PATCH 15/17] perf bpf-event: Add missing new line into pr_debug call

2019-02-20 Thread Song Liu
> On Feb 20, 2019, at 5:25 PM, Arnaldo Carvalho de Melo wrote: > > From: Jiri Olsa > > Add a missing new line into pr_debug call in > perf_event__synthesize_bpf_events(), > so that the error message does not screw the verbose output. > > Signed-off-by: Jiri Olsa > Cc: Alexander Shishkin

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Greg Kroah-Hartman
On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: > On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: > > > On Mon, Feb 18, 2019 at 03:54:42PM +0800, kernel test robot wrote: > > > >Greeting, > > > > >

Re: [PATCH] KVM: MMU: record maximum physical address width in kvm_mmu_extended_role

2019-02-20 Thread Yu Zhang
On Wed, Feb 20, 2019 at 03:06:10PM +0100, Vitaly Kuznetsov wrote: > Yu Zhang writes: > > > Previously, commit 7dcd57552008 ("x86/kvm/mmu: check if tdp/shadow > > MMU reconfiguration is needed") offered some optimization to avoid > > the unnecessary reconfiguration. Yet one scenario is broken -

Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-02-20 Thread Kees Cook
On Wed, Feb 20, 2019 at 6:06 PM Gustavo A. R. Silva wrote: > > Refactor some code in order to fix both the technical implementation > and the following warnings: > > drivers/iio/accel/cros_ec_accel_legacy.c: In function > ‘cros_ec_accel_legacy_probe’: >

[PATCH] perf record: Add support for limit perf output file size

2019-02-20 Thread Jiwei Sun
The patch adds a new option to limit the output file size, then based on it, we can create a wrapper of the perf command that uses the option to avoid exhausting the disk space by the unconscious user. Signed-off-by: Jiwei Sun --- tools/perf/builtin-record.c | 39

[PATCH 0/3] RPMPD for QCS404

2019-02-20 Thread Bjorn Andersson
Reworkd the macros of the rpmpd driver and add qcs404 power domains, then add this to the dts. Bjorn Andersson (3): soc: qcom: rpmpd: Modify corner defining macros soc: qcom: rpmpd: Add QCS404 corners arm64: dts: qcom: qcs404: Add rpmpd node .../devicetree/bindings/power/qcom,rpmpd.txt |

[PATCH 2/3] soc: qcom: rpmpd: Add QCS404 corners

2019-02-20 Thread Bjorn Andersson
Add the shared cx/mx and the low-power-island's cx and mx power-domains found on QCS404. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/power/qcom,rpmpd.txt | 1 + drivers/soc/qcom/rpmpd.c | 29 +++ include/dt-bindings/power/qcom-rpmpd.h

[PATCH 1/3] soc: qcom: rpmpd: Modify corner defining macros

2019-02-20 Thread Bjorn Andersson
QCS404 uses individual resource type magic for each power-domain, so adjust the macros slightly to make them reusable for this. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/rpmpd.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git

[PATCH 3/3] arm64: dts: qcom: qcs404: Add rpmpd node

2019-02-20 Thread Bjorn Andersson
Add the rpmpd node on the qcs404 and define the available levels. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 35 1 file changed, 35 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi

[PATCH V8 4/4] arm64: dts: imx: add i.MX8QXP thermal support

2019-02-20 Thread Anson Huang
Add i.MX8QXP CPU thermal zone support. Signed-off-by: Anson Huang --- Changes since V7: - move the "imx,sensor-resource-id" to scu tsens node; - correct #thermal-sensor-cells value to be 0 as there is ONLY one thermal zone now; - add cooling map for passive mode. ---

[PATCH V8 3/4] defconfig: arm64: add i.MX system controller thermal support

2019-02-20 Thread Anson Huang
This patch enables CONFIG_IMX_SC_THERMAL as module. Signed-off-by: Anson Huang --- No change. --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 2d9c390..52d503e 100644 ---

[PATCH V8 2/4] thermal: imx_sc: add i.MX system controller thermal support

2019-02-20 Thread Anson Huang
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and thermal sensors etc.. This patch adds i.MX system controller thermal driver support, Linux kernel has to communicate with system controller via MU (message

[PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding

2019-02-20 Thread Anson Huang
NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system controller, the system controller is in charge of system power, clock and thermal sensors etc. management, Linux kernel has to communicate with system controller via MU (message unit) IPC to get temperature from thermal sensors,

Re: [PATCH v2 1/3] x86/cpufeatures: Enumerate user wait instructions

2019-02-20 Thread Andy Lutomirski
On Wed, Feb 20, 2019 at 7:44 PM Tao Xu wrote: > > From: Fenghua Yu > > From patchwork Wed Jan 16 21:18:41 2019 > Content-Type: text/plain; charset="utf-8" [snipped more stuff like this] What happened here? > +/* Return value that will be used to set umwait control MSR */ > +static inline u32

[PATCH] ipmi_si: fix oops when loading ipmi_si driver

2019-02-20 Thread Yang Yingliang
When we excute the following commands, we got oops modprobe ipmi_si ports=0xffc0e3 type=bt [ 503.305487] ipmi_si: IPMI System Interface driver [ 503.305489] ipmi_hardcode: probing via hardcoded address [ 503.305491] ipmi_si: Adding hardcoded-specified bt state machine [ 503.305494] ipmi_si:

Re: [PATCH v3 00/16] powerpc/32: Use BATs/LTLBs for STRICT_KERNEL_RWX

2019-02-20 Thread Christophe Leroy
Le 21/02/2019 à 02:47, Michael Ellerman a écrit : Christophe Leroy writes: The purpose of this serie is to: - use BATs with STRICT_KERNEL_RWX on book3s (See patch 13 for details.) - use LTLBs with STRICT_KERNEL_RWX on 8xx (See patch 15 for a few details.) This doesn't boot qemu-mac99 for

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Huang, Ying
Wei Yang writes: > On Thu, Feb 21, 2019 at 12:46:18PM +0800, Huang, Ying wrote: >>Wei Yang writes: >> >>> On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 19, 2019 at 08:59:45AM +0800,

Re: [tip:x86/cleanups] x86: Remove pr_fmt duplicate logging prefixes

2019-02-20 Thread Bjorn Helgaas
On Thu, May 17, 2018 at 11:45 AM Joe Perches wrote: > > On Thu, 2018-05-17 at 20:27 +0200, Borislav Petkov wrote: > > On Sun, May 13, 2018 at 12:27:45PM -0700, tip-bot for Joe Perches wrote: > > > Commit-ID: 1de392f5d5e803663abbd8ed084233f154152bcd > > > Gitweb: > > >

Re: [RFC PATCH] docs/memory-barriers.txt: Rewrite "KERNEL I/O BARRIER EFFECTS" section

2019-02-20 Thread Michael Ellerman
Will Deacon writes: > [+more ppc folks] > > On Mon, Feb 18, 2019 at 04:50:12PM +, Will Deacon wrote: >> On Wed, Feb 13, 2019 at 10:27:09AM -0800, Linus Torvalds wrote: >> > Note that even if mmiowb() is expensive (and I don't think that's >> > actually even the case on ia64), you can - and

linux-next: build failure after merge of the xarray tree

2019-02-20 Thread Stephen Rothwell
Hi all, After merging the xarray tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: In file included from include/linux/uio.h:12, from include/linux/socket.h:8, from include/rdma/rdma_cm.h:37, from

Re: [PATCH] huegtlbfs: fix races and page leaks during migration

2019-02-20 Thread Andrew Morton
On Tue, 12 Feb 2019 14:14:00 -0800 Mike Kravetz wrote: > hugetlb pages should only be migrated if they are 'active'. The routines > set/clear_page_huge_active() modify the active state of hugetlb pages. > When a new hugetlb page is allocated at fault time, set_page_huge_active > is called

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Wei Yang
On Thu, Feb 21, 2019 at 12:46:18PM +0800, Huang, Ying wrote: >Wei Yang writes: > >> On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: >>>On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: > On

Re: [PATCH 5/6] lib: Fix function documentation for strncpy_from_user

2019-02-20 Thread Kees Cook
On Wed, Feb 20, 2019 at 9:25 PM Tobin C. Harding wrote: > > On Wed, Feb 20, 2019 at 05:05:10PM -0800, Kees Cook wrote: > > So, generally speaking, I'd love to split all strncpy* uses into > > strscpy_zero() (when expecting to do str->str copies), and some new > > function, named like mempadstr()

RE: Re: [PATCH v3 5/7] drivers: devfreq: add longer polling interval in idle

2019-02-20 Thread MyungJoo Ham
>> >> There are some requirements that you need to consider: >> >> Is 30% really applicable to ALL devfreq devices? >The 30% load while the device is on lowest OPP is to filter some noise. >It might be tunable over sysfs for each device if you like. >> - What if some devices do not want

[PATCH RFC 5/5] rcuwait: Replace rcu_assign_pointer() with WRITE_ONCE

2019-02-20 Thread Joel Fernandes (Google)
This suppresses a sparse error generated due to the recently added rcu_assign_pointer sparse check below. It seems WRITE_ONCE should be sufficient here. >> kernel//locking/percpu-rwsem.c:162:9: sparse: error: incompatible types in comparison expression (different address spaces) Signed-off-by:

[PATCH RFC 1/5] net: rtnetlink: Fix incorrect RCU API usage

2019-02-20 Thread Joel Fernandes (Google)
rtnl_register_internal() and rtnl_unregister_all tries to directly dereference an RCU protected pointed outside RCU read side section. While this is Ok to do since a lock is held, let us use the correct API to avoid programmer bugs in the future. This also fixes sparse warnings arising from not

[PATCH RFC 3/5] sched/cpufreq: Fix incorrect RCU API usage

2019-02-20 Thread Joel Fernandes (Google)
Recently I added an RCU annotation check to rcu_assign_pointer(). All pointers assigned to RCU protected data are to be annotated with __rcu inorder to be able to use rcu_assign_pointer() similar to checks in other RCU APIs. This resulted in a sparse error: kernel//sched/cpufreq.c:41:9: sparse:

[PATCH RFC 2/5] ixgbe: Fix incorrect RCU API usage

2019-02-20 Thread Joel Fernandes (Google)
Recently, I added an RCU annotation check in rcu_assign_pointer. This caused a sparse error to be reported by the ixgbe driver. Further looking, it seems the adapter->xdp_prog pointer is not annotated with __rcu. Annonating it fixed the error, but caused a bunch of other warnings. This patch

[PATCH RFC 4/5] sched/topology: Annonate RCU pointers properly

2019-02-20 Thread Joel Fernandes (Google)
The scheduler's topology code uses rcu_assign_pointer() to initialize various pointers. Let us annotate the pointers correctly which also help avoid future bugs. This suppresses the new sparse errors caused by an annotation check I added to rcu_assign_pointer(). Also replace rcu_assign_pointer

[PATCH RFC 0/5] RCU fixes for rcu_assign_pointer() usage

2019-02-20 Thread Joel Fernandes (Google)
These patches fix various RCU API usage issues found due to sparse errors as a result of the recent check to add rcu_check_sparse() to rcu_assign_pointer(). The errors in many cases seem to indicate either an incorrect API usage, or missing annotations. The annotations added can also help avoid

mmotm 2019-02-20-21-43 uploaded

2019-02-20 Thread akpm
The mm-of-the-moment snapshot 2019-02-20-21-43 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread kernel test robot
On Thu, Feb 21, 2019 at 11:46:12AM +0800, Wei Yang wrote: > On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: > >On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: > >> On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: > >> > On Mon, Feb 18, 2019 at

Re: [PATCH 08/11] powercap/intel_rapl: Support multi-die/package

2019-02-20 Thread Len Brown
On Wed, Feb 20, 2019 at 6:02 AM Peter Zijlstra wrote: > > list_for_each_entry(rp, _packages, plist) { > > @@ -1457,7 +1457,7 @@ static void rapl_remove_package(struct rapl_package > > *rp) > > /* called from CPU hotplug notifier, hotplug lock held */ > > static struct rapl_package

[PATCH v2 2/2] dmaengine: sprd: Change channel id to slave id for DMA cell specifier

2019-02-20 Thread Baolin Wang
We will describe the slave id in DMA cell specifier instead of DMA channel id, thus we should save the slave id from DMA engine translation function, and remove the channel id validation. Meanwhile we do not need set default slave id in sprd_dma_alloc_chan_resources(), remove it. Signed-off-by:

[PATCH v2 1/2] dt-bindings: dmaengine: sprd: Change channel id to slave id for DMA cell specifier

2019-02-20 Thread Baolin Wang
For Spreadtrum DMA engine, all channels are equal, which means slave can request any channels with setting a unique slave id to trigger this channel. Thus we can remove the channel id from device tree to assign the channel dynamically, moreover we should add the slave id in device tree.

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-20 Thread Vinod Koul
On 20-02-19, 20:59, Stefano Brivio wrote: > On Wed, 20 Feb 2019 11:02:01 -0800 (PST) > David Miller wrote: > > > From: Jiri Pirko > > Date: Wed, 20 Feb 2019 09:36:11 +0100 > > > > > Would be good to have some robot checking "Fixes" sanity... > > > > I want to add a script to my trees that

[PATCH v2] dax: Check the end of the block-device capacity with dax_direct_access()

2019-02-20 Thread Dan Williams
The checks in __bdev_dax_supported() helped mitigate a potential data corruption bug in the pmem driver's handling of section alignment padding. Strengthen the checks, including checking the end of the range, to validate the dev_pagemap, Xarray entries, and sector-to-pfn translation established

Re: [PATCH 3/6] lib/string: Use correct docstring format

2019-02-20 Thread Kees Cook
On Wed, Feb 20, 2019 at 8:14 PM Randy Dunlap wrote: > It's already in Documentation/core-api/kernel-api.rst, under > "String Manipulation." Ah! Thanks, yes, I missed it. :) -- Kees Cook

[PATCH] staging: rtlwifi: Use proper enum for return in halmac_parse_psd_data_88xx

2019-02-20 Thread Nathan Chancellor
Clang warns: drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11: warning: implicit conversion from enumeration type 'enum halmac_cmd_process_status' to different enumeration type 'enum halmac_ret_status' [-Wenum-conversion] return

Re: [PATCH 5/6] lib: Fix function documentation for strncpy_from_user

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 05:05:10PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 4:52 PM Jann Horn wrote: > > AFAICS the byte_at_a_time loop exits when max==0 is reached, and then > > if `res >= count` (in other words, if we've copied as many bytes as > > requested, haven't encountered a null

Re: [PATCH 4/6] lib/string: Add string copy/zero function

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 04:48:18PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > > > We have a function to copy strings safely and we have a function to copy > > strings _and_ zero the tail of the destination (if source string is > > shorter than

Re: [PATCH 2/6] lib/string: Fix erroneous 'overflow' documentation

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 04:02:37PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > > > Current documentation uses 'overflow' to describe a situation where less > > data is written to a buffer than buffer size not more. 'overflow' is > > the wrong word here -

[RFC PATCH 1/1] f2fs-dev: ioctl for removing a range from F2FS

2019-02-20 Thread sunqiuyang
From: Qiuyang Sun This ioctl shrinks a given length (aligned to sections) from end of the main area. Any cursegs and valid blocks will be moved out before invalidating the range. This feature can be used for adjusting partition sizes online. Signed-off-by: Qiuyang Sun --- fs/f2fs/f2fs.h|

Re: [PATCH 1/6] lib/string: Enable string selftesting

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 03:57:18PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > > > Currently we have a test module but it is not tied into the kselftest > > infrastructure. In preparation for adding string manipulation functions > > and testing we should

Re: [PATCH 0/6] lib: Add safe string funtions

2019-02-20 Thread Tobin C. Harding
On Wed, Feb 20, 2019 at 03:31:07PM -0800, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: > > During your talk at LCA you mentioned that we could do with a couple > > more safe string functions. One to zero the tail of the destination > > buffer after call to strscpy()

Re: [PATCH] kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig

2019-02-20 Thread Nathan Chancellor
On Thu, Feb 21, 2019 at 01:13:38PM +0900, Masahiro Yamada wrote: > Since -Wmaybe-uninitialized was introduced by GCC 4.7, we have patched > various false positives: > > - commit e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building >with -Os") turned off this option for -Os. > > -

[PATCH] f2fs: no need to take page lock in readdir

2019-02-20 Thread Gao Xiang
VFS will take inode_lock for readdir, therefore no need to take page lock in readdir at all just as the majority of other generic filesystems. This patch improves concurrency since .iterate_shared was introduced to VFS years ago. Signed-off-by: Gao Xiang --- personally tend to use

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Huang, Ying
Wei Yang writes: > On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: >>On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: >>> On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: >>> > On Mon, Feb 18, 2019 at 03:54:42PM +0800, kernel test robot wrote: >>> >

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Viresh Kumar
On 21-02-19, 10:02, Amit Kucheria wrote: > Perhaps I was just unfamiliar with the dev_pm_opp_set_supported_hw() > API where the actual allocation happens 3 levels deep. Maybe the > comment should apply to dev_pm_opp_set_supported_hw(). I leave it to > you to decide. I think we are fine without

What are the new features of Linux Kernel 5.0-rc7?

2019-02-20 Thread Turritopsis Dohrnii Teo En Ming
Good afternoon from Singapore, What are the new features of Linux Kernel 5.0-rc7? Thank you. ===BEGIN EMAIL SIGNATURE=== The Gospel for all Targeted Individuals (TIs): [The New York Times] Microwave Weapons Are Prime Suspect in Ills of U.S. Embassy Workers Link:

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Amit Kucheria
On Thu, Feb 21, 2019 at 9:15 AM Viresh Kumar wrote: > > On 20-02-19, 21:56, Amit Kucheria wrote: > > On Wed, Feb 20, 2019 at 4:44 PM Viresh Kumar > > wrote: > > > > > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > > > 256"), we have started getting following

RE: [PATCH v3 2/2] drivers: devfreq: add tracing for scheduling work

2019-02-20 Thread MyungJoo Ham
>This patch add basic tracing of the devfreq workqueue and delayed work. >It aims to capture changes of the polling intervals and device state. > >Signed-off-by: Lukasz Luba >--- > drivers/devfreq/devfreq.c | 5 + > 1 file changed, 5 insertions(+) > >diff --git a/drivers/devfreq/devfreq.c

RE: [PATCH v3 1/2] trace: events: add devfreq trace event file

2019-02-20 Thread MyungJoo Ham
>The patch adds a new file for with trace events for devfreq >framework. They are used for performance analysis of the framework. >It also contains updates in MAINTAINERS file adding new entry for >devfreq maintainers. > >Signed-off-by: Lukasz Luba >--- > MAINTAINERS| 1 + >

[PATCH] kbuild: compute false-positive -Wmaybe-uninitialized cases in Kconfig

2019-02-20 Thread Masahiro Yamada
Since -Wmaybe-uninitialized was introduced by GCC 4.7, we have patched various false positives: - commit e74fc973b6e5 ("Turn off -Wmaybe-uninitialized when building with -Os") turned off this option for -Os. - commit 815eb71e7149 ("Kbuild: disable 'maybe-uninitialized' warning for

Re: general protection fault in __dentry_path

2019-02-20 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:2137397c92ae Merge tag 'sound-5.0' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1270bf78c0 kernel config:

[PATCH 2/2] loop: set GENHD_FL_NO_PART_SCAN after blkdev_reread_part()

2019-02-20 Thread Dongli Zhang
Commit 0da03cab87e6 ("loop: Fix deadlock when calling blkdev_reread_part()") moves blkdev_reread_part() out of the loop_ctl_mutex. However, GENHD_FL_NO_PART_SCAN is set before __blkdev_reread_part(). As a result, __blkdev_reread_part() will fail the check of GENHD_FL_NO_PART_SCAN and will not

[PATCH 0/2] loop: fix two issues introduced by prior commit

2019-02-20 Thread Dongli Zhang
This patch set fix two issues introduced by prior commit. [PATCH 1/2] loop: do not print warn message if partition scan is successful [PATCH 1/2] fixes d57f3374ba48 ("loop: Move special partition reread handling in loop_clr_fd()") to not always print warn message even when partition scan is

[PATCH 1/2] loop: do not print warn message if partition scan is successful

2019-02-20 Thread Dongli Zhang
Do not print warn message when the partition scan returns 0. Fixes: d57f3374ba48 ("loop: Move special partition reread handling in loop_clr_fd()") Signed-off-by: Dongli Zhang --- drivers/block/loop.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/block/loop.c

Re: [PATCH 3/6] lib/string: Use correct docstring format

2019-02-20 Thread Randy Dunlap
On 2/20/19 4:07 PM, Kees Cook wrote: > On Mon, Feb 18, 2019 at 3:24 PM Tobin C. Harding wrote: >> >> Currently the docstring comments for strscpy() are not in the correct >> format. Prior to working on this file fix up the docstring. >> >> Use correct docstring format for strscpy(). > > Is this

[PATCH] mm/cma_debug: Avoid to use global cma_debugfs_root

2019-02-20 Thread Yue Hu
From: Yue Hu Currently cma_debugfs_root is at global space. That is unnecessary since it will be only used by next cma_debugfs_add_one(). We can just pass it to following calling, it will save global space. Also remove useless idx parameter. Signed-off-by: Yue Hu --- mm/cma_debug.c | 9

[PATCH] Documentation: fix admin-guide/README.rst minimum gcc version requirement

2019-02-20 Thread Randy Dunlap
From: Randy Dunlap Fix minimum gcc version as specified in Documentation/process/changes.rst. Suggested-by: Matthew Wilcox Signed-off-by: Randy Dunlap --- Documentation/admin-guide/README.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH] mm/cma_debug: Check for null tmp in cma_debugfs_add_one()

2019-02-20 Thread Yue Hu
From: Yue Hu If debugfs_create_dir() failed, the following debugfs_create_file() will be meanless since it depends on non-NULL tmp dentry and it will only waste CPU resource. Signed-off-by: Yue Hu --- mm/cma_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/cma_debug.c

Re: [PATCH 05/32] locking/lockdep: Prepare valid_state() to handle plain masks

2019-02-20 Thread Frederic Weisbecker
On Wed, Feb 13, 2019 at 11:47:13AM -0800, Linus Torvalds wrote: > On Wed, Feb 13, 2019 at 7:16 AM Frederic Weisbecker > wrote: > > > > > > If "vectors" only has the high hit set, you end up with "fs" having > > > the value "64". > > > > > > And then "vectors >>= fs" is undefined and won't

Re: [LKP] [driver core] 570d020012: will-it-scale.per_thread_ops -12.2% regression

2019-02-20 Thread Wei Yang
On Thu, Feb 21, 2019 at 11:10:49AM +0800, kernel test robot wrote: >On Tue, Feb 19, 2019 at 01:19:04PM +0100, Greg Kroah-Hartman wrote: >> On Tue, Feb 19, 2019 at 08:59:45AM +0800, Wei Yang wrote: >> > On Mon, Feb 18, 2019 at 03:54:42PM +0800, kernel test robot wrote: >> > >Greeting, >> > > >> >

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Viresh Kumar
On 20-02-19, 21:56, Amit Kucheria wrote: > On Wed, Feb 20, 2019 at 4:44 PM Viresh Kumar wrote: > > > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > > 256"), we have started getting following compilation warning: > > > > qcom-cpufreq-kryo.c:168:1: warning: the frame

[PATCH] : drop the gcc-3.3 'const' hack in roundup()

2019-02-20 Thread Randy Dunlap
From: Randy Dunlap The single quotation marks around "const" were causing a documentation markup warning with reST. Instead of fixing that warning, just delete that comment line and the gcc-3.3 hack of using "const" in the roundup() macro since gcc-3.3 is no longer supported for kernel builds.

RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first

2019-02-20 Thread Peter Chen
> > On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote: > > > According to the chipidea driver bindings, the USB PHY is specified via > > > the > "phys" > > > phandle node. However, this only takes effect for USB PHYs that use > > > the common PHY framework. For legacy USB PHYs, a simple

[PATCH -next] drm/nouveau/dmem: remove set but not used variable 'drm'

2019-02-20 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free': drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning: variable 'drm' set but not used [-Wunused-but-set-variable] struct nouveau_drm *drm; ^

[PATCHv7 3/4] pci: layerscape: Add the EP mode support.

2019-02-20 Thread Xiaowei Bao
Add the PCIe EP mode support for layerscape platform. Signed-off-by: Xiaowei Bao Reviewed-by: Minghuan Lian Reviewed-by: Zhiqiang Hou Reviewed-by: Kishon Vijay Abraham I --- depends on: https://patchwork.kernel.org/project/linux-pci/list/?series=66177 v2: - remove the EP mode check

[PATCHv7 2/4] arm64: dts: Add the PCIE EP node in dts

2019-02-20 Thread Xiaowei Bao
Add the PCIE EP node in dts for ls1046a. Signed-off-by: Xiaowei Bao Reviewed-by: Minghuan Lian Reviewed-by: Zhiqiang Hou Reviewed-by: Rob Herring --- v2: - Add the SoC specific compatibles. v3: - no change v4: - no change v5: - change the OB win number due to the RM update. v6: - no

[PATCHv7 4/4] misc: pci_endpoint_test: Add the layerscape EP device support

2019-02-20 Thread Xiaowei Bao
Add the layerscape EP device support in pci_endpoint_test driver. Signed-off-by: Xiaowei Bao Reviewed-by: Minghuan Lian Reviewed-by: Zhiqiang Hou Reviewed-by: Greg KH --- v2: - no change v3: - no change v4: - delate the comments. v5: - no change. v6: - no change. v7: - no change.

[PATCHv7 1/4] dt-bindings: add DT binding for the layerscape PCIe controller with EP mode

2019-02-20 Thread Xiaowei Bao
Add the documentation for the Device Tree binding for the layerscape PCIe controller with EP mode. Signed-off-by: Xiaowei Bao Reviewed-by: Minghuan Lian Reviewed-by: Zhiqiang Hou Reviewed-by: Rob Herring --- v2: - Add the SoC specific compatibles. v3: - modify the commit message. v4: - no

  1   2   3   4   5   6   7   8   9   10   >