Re: [PATCH V2] cpufreq: Call transition notifier only once for each policy

2019-03-18 Thread Viresh Kumar
On 18-03-19, 12:49, Rafael J. Wysocki wrote: > To summarize, I think that it would be sufficient to do this just for > policy->cpu and, as Peter said, warn once if there are more CPUs in > the policy or policy->cpu is not the CPU running this code. And mark > the TSC as unstable in both of these

Re: [PATCH] PCI: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Jisheng Zhang
On Mon, 18 Mar 2019 19:26:30 -0500 Aditya Pakki wrote: > > In gen_pci_probe, of_match_node can return a NULL pointer in case of This could not happen. If the probe is called, it means OF registered a device with a valid compatible string, so of_match_node cannot be NULL. > failure. The patch

Re: [PATCH] pinctrl: berlin: as370: Fix to avoid NULL pointer dereference

2019-03-18 Thread Jisheng Zhang
On Mon, 18 Mar 2019 18:37:27 -0500 Aditya Pakki wrote: > > > of_match_device in as370_pinctrl_probe can return a NULL value > when the matching device is not found. The patch avoids a potential Similar as the comment to your previous patch, this could not happen. If the probe is called, it

Re: [PATCH] pinctrl: berlin: Fix to avoid NULL pointer dereference

2019-03-18 Thread Jisheng Zhang
On Mon, 18 Mar 2019 18:31:29 -0500 Aditya Pakki wrote: > > > of_match_device can return a NULL value when the matching device is This could not happen. If the probe is called, it means OF registered a device with a valid compatible string, so match cannot be NULL. > not found. The patch avoids

Re: [PATCH v2] mtd: spi-nor: Return error when nor->addr_width does not match the device size

2019-03-18 Thread Vignesh Raghavendra
Hi, On 13/03/19 7:15 PM, Liu Xiang wrote: > In some is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header > is 0xfff920e5. So the DWORD1[18:17] Address Bytes bits are 0b00, > means that 3-Byte only addressing. But the device size is larger > than 16MB, nor->addr_width must be 4 to access

linux-next: Tree for Mar 19

2019-03-18 Thread Stephen Rothwell
Hi all, Changes since 20190318: New trees: amdgpu-fixes, amdgpu The amdgpu tree gained a conflict against Linus' tree and a build failure for which I reverted a commit. The drm-misc tree gained a conflict against the drm-intel tree. The selinux tree gained a build failure so I used

Re: [PATCH v2 2/2] kvm/vmx: Using hardware cpuid faulting to avoid emulation overhead

2019-03-18 Thread Xiaoyao Li
On Mon, 2019-03-18 at 09:38 -0700, Sean Christopherson wrote: > On Mon, Mar 18, 2019 at 07:43:24PM +0800, Xiaoyao Li wrote: > > Current cpuid faulting of guest is purely emulated in kvm, which exploits > > CPUID vm exit to inject #GP to guest. However, if host hardware cpu has > >

linux-next: manual merge of the akpm-current tree with the amdgpu tree

2019-03-18 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: mm/hmm.c between commit: e811b0a79998 ("mm/hmm: use reference counting for HMM struct") from the amdgpu tree and commit: e0ed7d6bb0c5 ("mm/hmm: use reference counting for HMM struct") and following commits

Re: [PATCH v2] kbuild: add workaround for Debian make-kpkg

2019-03-18 Thread Masahiro Yamada
Hi Andreas, On Mon, Mar 18, 2019 at 7:00 PM Andreas Schwab wrote: > > On Mär 08 2019, Masahiro Yamada wrote: > > > +$(warning Do not include top Makefile of Linux Kernel) > > So how do I add additional targets then? Currently I create > GNUmakefile, include Makefile, then add the targets I

Re: Commit seems to prevent use of GNUmakefile wrappers

2019-03-18 Thread Masahiro Yamada
Hi David, On Mon, Mar 18, 2019 at 11:43 PM David Howells wrote: > > Hi Mashiro, > > commit 2b50f7ab63685cd247e32ad321f7338ed130d3d5 > Author: Masahiro Yamada > kbuild: add workaround for Debian make-kpkg > > seems to prevent the use of GNUmakefile wrappers to set the

[PATCH v6] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used

2019-03-18 Thread Kimberly Brown
There are two methods for signaling the host: the monitor page mechanism and hypercalls. The monitor page mechanism is used by performance critical channels (storage, networking, etc.) because it provides improved throughput. However, latency is increased. Monitor pages are allocated to these

[PATCH] kbuild: skip sub-make for in-tree build with GNU Make 4.x

2019-03-18 Thread Masahiro Yamada
Commit 2b50f7ab6368 ("kbuild: add workaround for Debian make-kpkg") annoyed people who want to wrap the top Makefile with GNUmakefile or something in order to customize it for their use. On second thought, we do not need to run the sub-make for in-tree build with Make 4.x because the 'MAKEFLAGS

Re: [PATCH]perf:Remove P8 HW events which are not supported

2019-03-18 Thread Ravi Bangoria
On 3/18/19 11:56 PM, Arnaldo Carvalho de Melo wrote: > I added this: > > Cc: Sukadev Bhattiprolu > Fixes: 2a81fa3bb5ed ("perf vendor events: Add power8 PMU events") > > - Arnaldo Sure. Thanks a lot Arnaldo!

Re: [PATCH 1/2] regulator: axp20x: Remove unneeded NULL test against rdev

2019-03-18 Thread Chen-Yu Tsai
On Tue, Mar 19, 2019 at 11:36 AM Axel Lin wrote: > > rdev won't be NULL in .enable callback. > > Signed-off-by: Axel Lin Acked-by: Chen-Yu Tsai

Re: [PATCH 2/2] regulator: axp20x: Use rdev_get_id at appropriate places

2019-03-18 Thread Chen-Yu Tsai
On Tue, Mar 19, 2019 at 11:36 AM Axel Lin wrote: > > Use rdev_get_id() to simplify the code a bit. > > Signed-off-by: Axel Lin Acked-by: Chen-Yu Tsai

[PATCH 2/2] regulator: axp20x: Use rdev_get_id at appropriate places

2019-03-18 Thread Axel Lin
Use rdev_get_id() to simplify the code a bit. Signed-off-by: Axel Lin --- drivers/regulator/axp20x-regulator.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index

[PATCH 1/2] regulator: axp20x: Remove unneeded NULL test against rdev

2019-03-18 Thread Axel Lin
rdev won't be NULL in .enable callback. Signed-off-by: Axel Lin --- drivers/regulator/axp20x-regulator.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index fba8f58ab769..8a366f66208e 100644 ---

Re: [RFC 2/2] PCI: imx6: Add support for i.MX8QM/QXP PCIe

2019-03-18 Thread Andrey Smirnov
On Thu, Mar 14, 2019 at 11:05 PM Richard Zhu wrote: > > > > > + imx6_pcie->pcie_inbound_axi = > > > > devm_clk_get(>dev, > > > > > + "pcie_inbound_axi"); > > > > > + if (IS_ERR(imx6_pcie->pcie_inbound_axi)) { > > > > > +

Re: [PATCH linux-next v2 1/2] ASoC: rsnd: src: Avoid a potential deadlock

2019-03-18 Thread Jiada Wang
Hi Fabrizio On 2019/03/14 3:19, Fabrizio Castro wrote: Hello Jiada, From: Jiada Wang Sent: 13 March 2019 11:56 Subject: Re: [PATCH linux-next v2 1/2] ASoC: rsnd: src: Avoid a potential deadlock Hi Geert On 2019/03/12 18:15, Geert Uytterhoeven wrote: Hi Jiada, Fabrizio, On Thu, Mar 7,

Re: [PATCH 07/10] mm/hmm: add an helper function that fault pages and map them to a device

2019-03-18 Thread Dan Williams
On Mon, Mar 18, 2019 at 3:15 PM Jerome Glisse wrote: > > On Mon, Mar 18, 2019 at 02:30:15PM -0700, Dan Williams wrote: > > On Mon, Mar 18, 2019 at 1:41 PM Jerome Glisse wrote: > > > > > > On Mon, Mar 18, 2019 at 01:21:00PM -0700, Dan Williams wrote: > > > > On Tue, Jan 29, 2019 at 8:55 AM

Re: [PATCH v2 01/19] locking/lockdep: Change all print_*() return type to void

2019-03-18 Thread Yuyang Du
Thanks for the review. On Mon, 18 Mar 2019 at 17:45, Joe Perches wrote: > > On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote: > > Since none of the print_*() function's return value is necessary, change > > their return type to void. No functional change. > > > > In cases where an invariable

Re: [PATCH] include/linux/hugetlb.h: Convert to use vm_fault_t

2019-03-18 Thread Matthew Wilcox
On Mon, Mar 18, 2019 at 09:56:05PM +0530, Souptick Joarder wrote: > >> mm/memory.c:3968:21: sparse: incorrect type in assignment (different > >> base types) @@expected restricted vm_fault_t [usertype] ret @@ > >> got e] ret @@ >mm/memory.c:3968:21:expected restricted vm_fault_t

Re: [PATCH] ceph: Fix a memory leak in ci->i_head_snapc

2019-03-18 Thread Yan, Zheng
On Tue, Mar 19, 2019 at 12:22 AM Luis Henriques wrote: > > "Yan, Zheng" writes: > > > On Mon, Mar 18, 2019 at 6:33 PM Luis Henriques wrote: > >> > >> "Yan, Zheng" writes: > >> > >> > On Fri, Mar 15, 2019 at 7:13 PM Luis Henriques > >> > wrote: > >> >> > >> >> I'm occasionally seeing a

[PATCH v2 1/1] userfaultfd/sysctl: add vm.unprivileged_userfaultfd

2019-03-18 Thread Peter Xu
Add a global sysctl knob "vm.unprivileged_userfaultfd" to control whether userfaultfd is allowed by unprivileged users. When this is set to zero, only privileged users (root user, or users with the CAP_SYS_PTRACE capability) will be able to use the userfaultfd syscalls. Suggested-by: Andrea

[PATCH v2 0/1] userfaultfd: allow to forbid unprivileged users

2019-03-18 Thread Peter Xu
Hi, This is the second version of the work. V1 was here: https://lkml.org/lkml/2019/3/11/207 I removed CC to kvm list since not necessary any more, but added linux-api to the list as suggested by Kirill. This one greatly simplifies the previous version, dropped the kvm special entry and mimic

[PATCH] udf: Fix to check the return value of load_nls

2019-03-18 Thread Aditya Pakki
load_nls may fail and return an error message. The patch checks for such a scenario and passes the error upstream. Signed-off-by: Aditya Pakki --- fs/udf/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/udf/super.c b/fs/udf/super.c index ffd8038ff728..1a38271de6d9 100644 ---

linux-next: build warning after merge of the leds tree

2019-03-18 Thread Stephen Rothwell
Hi all, After merging the leds tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/leds/leds-pca9532.c: In function 'pca9532_probe': drivers/leds/leds-pca9532.c:536:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] devid =

Re: [PATCH 5.0 00/43] 5.0.3-stable review

2019-03-18 Thread Naresh Kamboju
On Mon, 18 Mar 2019 at 14:59, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.0.3 release. > There are 43 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 4.20 00/52] 4.20.17-stable review

2019-03-18 Thread Naresh Kamboju
On Mon, 18 Mar 2019 at 14:59, Greg Kroah-Hartman wrote: > > -- > NOTE, this is going to be the LAST 4.20.y release. After this one, 4.20 > will be end-of-life. Please move to the 5.0.y tree at this point in > time, or let me know why that is not possible. > -- >

Re: [PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-03-18 Thread Claire Chang
> > >>> Signed-off-by: Balakrishna Godavarthi Tested-by: Claire Chang

Re: [PATCH] include/linux/hugetlb.h: Convert to use vm_fault_t

2019-03-18 Thread Souptick Joarder
On Tue, Mar 19, 2019 at 5:47 AM Mike Kravetz wrote: > > > On 3/18/19 9:26 AM, Souptick Joarder wrote: > > kbuild produces the below warning -> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f > >

Re: [PATCH 5.0 00/43] 5.0.3-stable review

2019-03-18 Thread Guenter Roeck
On 3/18/19 2:23 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.0.3 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.20 00/52] 4.20.17-stable review

2019-03-18 Thread Guenter Roeck
On 3/18/19 2:24 AM, Greg Kroah-Hartman wrote: -- NOTE, this is going to be the LAST 4.20.y release. After this one, 4.20 will be end-of-life. Please move to the 5.0.y tree at this point in time, or let me know why that is not possible. -- This is the start of

Re: [PATCH 4.19 00/52] 4.19.30-stable review

2019-03-18 Thread Guenter Roeck
On 3/18/19 2:24 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.30 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.14 00/34] 4.14.107-stable review

2019-03-18 Thread Guenter Roeck
On 3/18/19 2:25 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.107 release. There are 34 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.9 00/31] 4.9.164-stable review

2019-03-18 Thread Guenter Roeck
On 3/18/19 2:25 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.164 release. There are 31 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

[RESEND PATCH v4 7/9] videobuf2/videobuf2-dma-sg.c: Convert to use vm_map_pages()

2019-03-18 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. vm_pgoff is treated in V4L2 API as a 'cookie' to select a buffer, not as a in-buffer offset by design and it always want to mmap a whole buffer from its beginning. Signed-off-by: Souptick Joarder Suggested-by: Marek

[PATCH v2 03/11] staging: mt7621-mmc: Fix warning when reloading module with debug msgs enabled

2019-03-18 Thread George Hilliard
The kernel complained: [ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 proc_register+0xf0/0x108 [ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered when doing a modprobe/rmmod/modprobe of this module if debug messages are compiled in. Fix this by

Re: [PATCH 0/1] platform/x86: dell-wmi: Uncomment events that were

2019-03-18 Thread Renato Soma
On Mon, Mar 18, 2019 at 01:00:32PM +0100, Pali Rohár wrote: > > = > > > > > > Left WMI key: Windows Mobility Center > > Press:'x' > > Hold: - > > Release: - > > > > In my machine

[PATCH v2 05/11] staging: mt7621-mmc: Bill the caller for I/O time

2019-03-18 Thread George Hilliard
When waiting on completions, use the _io variant so the caller is charged as using I/O. This should have no effect on the module's functionality, only improve CPU accounting. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v2 10/11] staging: mt7621-mmc: Fix BRUST -> BURST typo

2019-03-18 Thread George Hilliard
Obvious typo. It is specified as BURST in the datasheet. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/mt6575_sd.h | 10 +- drivers/staging/mt7621-mmc/sd.c| 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH v2 02/11] staging: mt7621-mmc: Remove obsolete comments and variables

2019-03-18 Thread George Hilliard
These comments don't contain useful code or alternate implementation ideas. Remove them. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/mt6575_sd.h | 3 --- drivers/staging/mt7621-mmc/sd.c| 2 -- 2 files changed, 5 deletions(-) diff --git

[PATCH v2 11/11] staging: mt7621-mmc: Only unmap_sg if mapped

2019-03-18 Thread George Hilliard
A failure while processing the start command could cause dma_unmap_sg() to be called without first calling dma_map_sg(). Since calling dma_unmap_sg() is only needed when data != NULL, move the unmap call into the corresponding if {} block. Signed-off-by: George Hilliard ---

[PATCH v2 08/11] staging: mt7621-mmc: Remove redundant host->mmc->f_max write

2019-03-18 Thread George Hilliard
This is set once during initialization and never changed. Don't bother setting it again in the interrupt handler. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/sd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

[PATCH v2 06/11] staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-18 Thread George Hilliard
The module was initializing completions whenever it was going to wait on them, and not when the completion was allocated. This is incorrect according to the completion docs: Calling init_completion() on the same completion object twice is most likely a bug [...] Re-initialization is

[PATCH v2 09/11] staging: mt7621-mmc: Immediately notify mmc layer of card change detection

2019-03-18 Thread George Hilliard
There is no need to delay notifying the mmc layer. Schedule the delayed work to run immediately. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/sd.c

[RESEND PATCH v4 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero()

2019-03-18 Thread Souptick Joarder
Convert to use vm_map_pages_zero() to map range of kernel memory to user vma. This driver has ignored vm_pgoff and mapped the entire pages. We could later "fix" these drivers to behave according to the normal vm_pgoff offsetting simply by removing the _zero suffix on the function name and if that

[PATCH v2 07/11] staging: mt7621-mmc: Check for nonzero number of scatterlist entries

2019-03-18 Thread George Hilliard
The buffer descriptor setup loop is correct only if it is setting up at least one bd struct. Besides, there is an error somewhere if dma_map_sg() returns 0. So add a paranoid check for this condition. Signed-off-by: George Hilliard --- drivers/staging/mt7621-mmc/sd.c | 7 ++- 1 file

[no subject]

2019-03-18 Thread George Hilliard
Because of this change, the driver now expects a pinctrl device reference in the mmc controller's device tree node; without it, it will bail out. This could break existing setups that don't specify it because it "just worked" up until now. So currently I just let the old behavior fall away

[PATCH v2 01/11] staging: mt7621-mmc: fix unused variable compiler warning

2019-03-18 Thread George Hilliard
The compiler complains: drivers/staging/mt7621-mmc/dbg.c: In function ‘msdc_debug_proc_write’: drivers/staging/mt7621-mmc/dbg.c:237:12: warning: unused variable ‘size’ [-Wunused-variable] int mode, size; ^~~~ drivers/staging/mt7621-mmc/dbg.c:237:6: warning:

[PATCH v2 04/11] staging: mt7621-mmc: Use pinctrl subsystem to select SDXC pin mode

2019-03-18 Thread George Hilliard
The driver previously grabbed the SD pins for itself, ignoring the pin controller. Remove this, and allow the pinctrl subsystem to set up the pins using the device tree mappings. This allows this driver to work on related devices that have a different pin controller mapping, such as the MT7688.

[PATCH] x86: hpet: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
hpet_virt_address may be NULL when ioremap_nocache fails. The patch checks for such a scenario and avoids NULL pointer dereference. Signed-off-by: Aditya Pakki --- arch/x86/kernel/hpet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index

[RESEND PATCH v4 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages()

2019-03-18 Thread Souptick Joarder
Convert to use vm_map_pages() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- arch/arm/mm/dma-mapping.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index

[PATCH] misc/fastrpc: add checked value for dma_set_mask

2019-03-18 Thread Bo YU
There be should check return value from dma_set_mask to throw some infos if fail to set dma mask. Detected by CoverityScan, CID# 1443983: Error handling issues (CHECKED_RETURN) Fixes:f6f9279f2bf0 (misc: fastrpc: Add Qualcomm fastrpc basic driver model) Signed-off-by: Bo YU ---

[spi:for-5.2 11/19] drivers/spi/spi-fsl-lpspi.c:483:5: sparse: symbol 'fsl_lpspi_runtime_resume' was not declared. Should it be static?

2019-03-18 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2 head: 69b921acae8a5b7feef03921d9b42c3634f3b9d1 commit: 944c01a889d97dc08e1b71f4ed868f4023fd6034 [11/19] spi: lpspi: enable runtime pm for lpspi reproduce: # apt-get install sparse git checkout

[RFC PATCH spi] spi: lpspi: fsl_lpspi_runtime_resume() can be static

2019-03-18 Thread kbuild test robot
Fixes: 944c01a889d9 ("spi: lpspi: enable runtime pm for lpspi") Signed-off-by: kbuild test robot --- spi-fsl-lpspi.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 1860f06..4de8eb3 100644 ---

[PATCH v2] mmc: dw_mmc: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_node can fail and return NULL in case no matching structure. The patches checks for such a scenario and returns -ENXIO. --- V1: Added files dw_mmc-zx.c and dw_mmc-rockchip.c Signed-off-by: Aditya Pakki --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ drivers/mmc/host/dw_mmc-k3.c |

linux-next: build failure after merge of the selinux tree

2019-03-18 Thread Stephen Rothwell
#include ^~ Caused by commit e37c1877ba5b ("scripts/selinux: modernize mdp") I have used the selinux tree from next-20190318 for today. -- Cheers, Stephen Rothwell pgpWYAe2lA68o.pgp Description: OpenPGP digital signature

[PATCH] device_cgroup: fix RCU imbalance in error case

2019-03-18 Thread Jann Horn
When dev_exception_add() returns an error (due to a failed memory allocation), make sure that we move the RCU preemption count back to where it was before we were called. We dropped the RCU read lock inside the loop body, so we can't just "break". sparse complains about this, too: $ make -s C=2

[PATCH] slimbus: ngd: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
In of_qcom_slim_ngd_register, of_match_node may fail and return a NULL pointer. This patch avoids such a scenario leading to NULL pointer dereference. Fixes: 458a445deb9c ("slimbus: ngd: Fix build error on x86") Signed-off-by: Aditya Pakki --- drivers/slimbus/qcom-ngd-ctrl.c | 2 ++ 1 file

linux-next: build warning after merge of the mmc tree

2019-03-18 Thread Stephen Rothwell
Hi all, After merging the mmc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/mmc/host/dw_mmc.c: In function 'dw_mci_wait_hw_unbusy': drivers/mmc/host/dw_mmc.c:239:16: warning: unused variable 'irqflags' [-Wunused-variable] unsigned long irqflags;

[PATCH] PCI/LINK: bw_notification: Do not leave interrupt handler NULL

2019-03-18 Thread Alexandru Gagniuc
A threaded IRQ with a NULL handler does not work with level-triggered interrupts. request_threaded_irq() will return an error: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 16 pcie_bw_notification: probe of :00:1b.0:pcie010 failed with error -22 For level

Re: [PATCH v2 1/4] perf: Add a 'percore' event qualifier

2019-03-18 Thread Jin, Yao
On 3/18/2019 5:21 PM, Jiri Olsa wrote: On Sun, Mar 17, 2019 at 12:34:25AM +0800, Jin Yao wrote: SNIP static bool config_term_shrinked; @@ -950,6 +951,7 @@ config_term_avail(int term_type, struct parse_events_error *err) case PARSE_EVENTS__TERM_TYPE_CONFIG2: case

[PATCH v3 1/4] perf: Add a 'percore' event qualifier

2019-03-18 Thread Jin Yao
Add a 'percore' event qualifier, like cpu/event=0,umask=0x3,percore=1/, that sums up the event counts for both hardware threads in a core. We can already do this with --per-core, but it's often useful to do this together with other metrics that are collected per hardware thread. So we need to

[PATCH v3 2/4] perf stat: Factor out aggregate counts printing

2019-03-18 Thread Jin Yao
Move the aggregate counts printing to a new function print_counter_aggrdata, which will be used in following patches. v3: --- No change v2: --- Create this patch according to Jiri's comments. Signed-off-by: Jin Yao --- tools/perf/util/stat-display.c | 65

[PATCH v3 0/4] perf: Support a new 'percore' event qualifier

2019-03-18 Thread Jin Yao
The 'percore' event qualifier which sums up the event counts for both hardware threads in a core. For example, perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/ In this example, we count the event 'ref-cycles' per-core and per-CPU in one perf stat command-line. We can already

[PATCH v3 3/4] perf stat: Support 'percore' event qualifier

2019-03-18 Thread Jin Yao
With this patch, we can use the 'percore' event qualifier in perf-stat. root@skl:/tmp# perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/ -a -A -I1000 1.000773050 S0-C0 98,352,832 cpu/event=0,umask=0x3,percore=1/

[PATCH v3 4/4] perf test: Add a simple test for term 'percore'

2019-03-18 Thread Jin Yao
It's a simple test which just checks if parser works. v3: --- No change v2: --- Change 'coresum' to 'percore' Signed-off-by: Jin Yao --- tools/perf/tests/parse-events.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/parse-events.c

[PATCH] ASoC: codecs: Fix to avoid potential NULL pointer dereferences

2019-03-18 Thread Aditya Pakki
In sirf_audio_codec_driver_probe, of_match_node may fail and return a NULL pointer. The patch avoids a potential NULL pointer dereference. Signed-off-by: Aditya Pakki --- sound/soc/codecs/sirf-audio-codec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

RE: [PATCH V5 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-18 Thread Anson Huang
Hi, Thierry Best Regards! Anson Huang > -Original Message- > From: Thierry Reding [mailto:thierry.red...@gmail.com] > Sent: 2019年3月18日 23:31 > To: Anson Huang > Cc: robh...@kernel.org; mark.rutl...@arm.com; shawn...@kernel.org; > s.ha...@pengutronix.de; ker...@pengutronix.de;

Re: [PATCH v1] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-03-18 Thread Nicolas Boichat
On Wed, Mar 13, 2019 at 5:45 PM wrote: > > 在 2019-03-07 14:49,Balakrishna Godavarthi 写道: > > Hi Stepen, > > > > On 2019-03-07 04:03, Stephen Boyd wrote: > >> Quoting Balakrishna Godavarthi (2019-03-06 08:21:13) > >>> This patch enables enough time to ROME controller to bootup > >>> after we bring

Re: [PATCH v1 2/2] extcon: mrfld: Introduce extcon driver for Basin Cove PMIC

2019-03-18 Thread Chanwoo Choi
Hi Andy, On 19. 3. 18. 오후 9:46, Andy Shevchenko wrote: > On Mon, Mar 18, 2019 at 07:38:26PM +0900, Chanwoo Choi wrote: > >> Thanks for comment. I add my comments >> and then you have to rebase it on latest v5.0-rc1 >> because the merge conflict happen on v5.0-rc1. > > Thanks for review, see my

Re: [PATCH] mmc: dw_mmc: Fix to avoid potential NULL pointer dereference【请注意,邮件由linux-mmc-ow...@vger.kernel.org代发】

2019-03-18 Thread Shawn Lin
On 2019/3/19 8:19, Aditya Pakki wrote: of_match_node can fail and return NULL in case no matching structure. The patches checks for such a scenario and returns -ENXIO. Signed-off-by: Aditya Pakki --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ drivers/mmc/host/dw_mmc-k3.c | 2 ++

Re: [syzbot? printk?] no WARN_ON() messages printed before "Kernel panic - not syncing: panic_on_warn set ..."

2019-03-18 Thread Tetsuo Handa
Dmitry Vyukov wrote: > On Mon, Mar 18, 2019 at 1:32 PM Dmitry Vyukov wrote: > > Wait, but isn't SYSLOG_ACTION_CONSOLE_LEVEL what we are looking for? > > syzkaller knows about the syslog syscall: > >

Re: [PATCH] extcon: fix a missing check of regmap_read

2019-03-18 Thread Chanwoo Choi
Hi, On 19. 3. 19. 오전 1:41, Kangjie Lu wrote: > When regmap_read fails, it doesn't make sense to use the read > value "val" because it can be uninitialized. > > The fix returns if regmap_read fails. > > Signed-off-by: Kangjie Lu > --- > drivers/extcon/extcon-axp288.c | 4 > 1 file

Re: ulfh/next boot bisection: v5.1-rc1-22-gb3725d97ba75 on rk3399-gru-kevin【请注意,邮件由linux-mmc-ow...@vger.kernel.org代发】

2019-03-18 Thread Shawn Lin
On 2019/3/19 6:50, kernelci.org bot wrote: * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to

[PATCH] PCI: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
In gen_pci_probe, of_match_node can return a NULL pointer in case of failure. The patch avoids a NULL pointer dereference in such a scenario. Signed-off-by: Aditya Pakki --- drivers/pci/controller/pci-host-generic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] mmc: dw_mmc: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_node can fail and return NULL in case no matching structure. The patches checks for such a scenario and returns -ENXIO. Signed-off-by: Aditya Pakki --- drivers/mmc/host/dw_mmc-exynos.c | 2 ++ drivers/mmc/host/dw_mmc-k3.c | 2 ++ drivers/mmc/host/dw_mmc-pltfm.c | 2 ++ 3 files

Re: [PATCH] include/linux/hugetlb.h: Convert to use vm_fault_t

2019-03-18 Thread Mike Kravetz
On 3/18/19 9:26 AM, Souptick Joarder wrote: > kbuild produces the below warning -> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5453a3df2a5eb49bc24615d4cf0d66b2aae05e5f > commit 3d3539018d2c ("mm: create the new vm_fault_t type") > reproduce:

[PATCH v2] objtool: Move objtool_file struct off the stack

2019-03-18 Thread Josh Poimboeuf
Objtool uses over 512k of stack, thanks to the hash table embedded in the objtool_file struct. This causes an unnecessarily large stack allocation and breaks users with low stack limits. Move the struct off the stack. Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")

linux-next: build failure after merge of the amdgpu tree

2019-03-18 Thread Stephen Rothwell
Hi all, After merging the amdgpu tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: "get_vupdate_offset_from_vsync" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! Caused by commit 67b112ed997b ("drm/amd/display: On DCN1, Wait for vupdate on cursor updates") I

Re: [PATCH 00/25] objtool: UACCESS validation v4

2019-03-18 Thread Josh Poimboeuf
On Mon, Mar 18, 2019 at 04:38:40PM +0100, Peter Zijlstra wrote: > Teach objtool to validate the UACCESS (SMAP, PAN) rules which are currently > unenforced and (therefore obviously) violated. > > UACCESS sections should be small; we want to limit the amount of code that can > touch userspace.

Re: [PATCH] lib: Add shared copy of __lshrti3 from libgcc

2019-03-18 Thread hpa
On March 18, 2019 4:52:19 PM PDT, Matthias Kaehlcke wrote: >On Mon, Mar 18, 2019 at 04:44:03PM -0700, h...@zytor.com wrote: >> On March 18, 2019 3:16:39 PM PDT, Matthias Kaehlcke > wrote: >> >On Mon, Mar 18, 2019 at 02:50:44PM -0700, h...@zytor.com wrote: >> >> On March 18, 2019 2:31:13 PM PDT,

linux-next: manual merge of the amdgpu tree with Linus' tree

2019-03-18 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c between commits: d63716658ac1 ("drm/amd/display: Use vrr friendly pageflip throttling in DC.") 634092b1b9f6 ("drm/amd/display: Use vrr friendly pageflip throttling in

Re: [PATCH] lib: Add shared copy of __lshrti3 from libgcc

2019-03-18 Thread hpa
On March 18, 2019 4:52:19 PM PDT, Matthias Kaehlcke wrote: >On Mon, Mar 18, 2019 at 04:44:03PM -0700, h...@zytor.com wrote: >> On March 18, 2019 3:16:39 PM PDT, Matthias Kaehlcke > wrote: >> >On Mon, Mar 18, 2019 at 02:50:44PM -0700, h...@zytor.com wrote: >> >> On March 18, 2019 2:31:13 PM PDT,

Re: [PATCH] lib: Add shared copy of __lshrti3 from libgcc

2019-03-18 Thread Matthias Kaehlcke
On Mon, Mar 18, 2019 at 04:44:03PM -0700, h...@zytor.com wrote: > On March 18, 2019 3:16:39 PM PDT, Matthias Kaehlcke wrote: > >On Mon, Mar 18, 2019 at 02:50:44PM -0700, h...@zytor.com wrote: > >> On March 18, 2019 2:31:13 PM PDT, Matthias Kaehlcke > > wrote: > >> >On Fri, Mar 15, 2019 at

Re: [PATCH 23/25] objtool: Add UACCESS validation

2019-03-18 Thread Josh Poimboeuf
On Mon, Mar 18, 2019 at 04:39:03PM +0100, Peter Zijlstra wrote: > +++ b/tools/objtool/check.c > @@ -443,6 +443,82 @@ static void add_ignores(struct objtool_f > } > > /* > + * This is a whitelist of functions that is allowed to be called with AC set. s/is/are/ -- Josh

[PATCH] serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device on failure to find a matching device can return a NULL pointer. The patch checks for such a scenrio and passes the error upstream. Signed-off-by: Aditya Pakki --- drivers/tty/serial/mvebu-uart.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android

2019-03-18 Thread Joel Fernandes
On Mon, Mar 18, 2019 at 01:29:51AM +0100, Christian Brauner wrote: > On Sun, Mar 17, 2019 at 08:40:19AM -0700, Daniel Colascione wrote: > > On Sun, Mar 17, 2019 at 4:42 AM Christian Brauner > > wrote: > > > > > > On Sat, Mar 16, 2019 at 09:53:06PM -0400, Joel Fernandes wrote: > > > > On Sat, Mar

[PATCH] serial: max310x: Fix to avoid potential NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device can return a NULL pointer when matching device is not found. This patch avoids a scenario causing NULL pointer derefernce. Signed-off-by: Aditya Pakki --- drivers/tty/serial/max310x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/max310x.c

Re: [PATCH] lib: Add shared copy of __lshrti3 from libgcc

2019-03-18 Thread hpa
On March 18, 2019 3:16:39 PM PDT, Matthias Kaehlcke wrote: >On Mon, Mar 18, 2019 at 02:50:44PM -0700, h...@zytor.com wrote: >> On March 18, 2019 2:31:13 PM PDT, Matthias Kaehlcke > wrote: >> >On Fri, Mar 15, 2019 at 01:54:50PM -0700, Matthias Kaehlcke wrote: >> >> The compiler may emit calls to

[PATCH] pinctrl: berlin: as370: Fix to avoid NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device in as370_pinctrl_probe can return a NULL value when the matching device is not found. The patch avoids a potential dereference in such scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/berlin/pinctrl-as370.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 02/25] tracing: Improve "if" macro code generation

2019-03-18 Thread Josh Poimboeuf
On Mon, Mar 18, 2019 at 04:38:42PM +0100, Peter Zijlstra wrote: > With CONFIG_PROFILE_ALL_BRANCHES, the "if" macro converts the > conditional to an array index. This can cause GCC to create horrible > code. When there are nested ifs, the generated code uses register > values to encode branching

Re: [RFC PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-03-18 Thread Josh Poimboeuf
On Mon, Mar 18, 2019 at 01:15:44PM -0700, Andy Lutomirski wrote: > On Mon, Mar 18, 2019 at 2:41 AM Elena Reshetova > wrote: > > > > If CONFIG_RANDOMIZE_KSTACK_OFFSET is selected, > > the kernel stack offset is randomized upon each > > entry to a system call after fixed location of pt_regs > >

[PATCH] pinctrl: berlin: Fix to avoid NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device can return a NULL value when the matching device is not found. The patch avoids a potential dereference in such scenario. Signed-off-by: Aditya Pakki --- drivers/pinctrl/berlin/berlin-bg4ct.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] NFS: Fix nfs4_lock_state refcounting in nfs4_alloc_{lock,unlock}data()

2019-03-18 Thread NeilBrown
On Mon, Mar 18 2019, Trond Myklebust wrote: > On Mon, 2019-03-18 at 17:00 +, Catalin Marinas wrote: >> Commit 7b587e1a5a6c ("NFS: use locks_copy_lock() to copy locks.") >> changed the lock copying from memcpy() to the dedicated >> locks_copy_lock() function. The latter correctly increments

[PATCH] mtd: rawnand: vf610: Fix to check for NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device can return NULL if there is no matching device is found. The patch avoids a potential NULL pointer dereference by checking for the return value and passing the error upstream. Signed-off-by: Aditya Pakki --- drivers/mtd/nand/raw/vf610_nfc.c | 2 ++ 1 file changed, 2

Re: [PATCH] tpm: fix a race between poll and write in tpm-dev-common

2019-03-18 Thread James Bottomley
On Mon, 2019-03-18 at 15:18 -0700, Tadeusz Struk wrote: > Since the poll returns EPOLLIN base on the state of two > variables, the response_read being false and the > response_length > 0 the poll needs to take the buffer_mutex > after it is woken up. > > Fixes: 9488585b21bef0df12 ("tpm: add

[PATCH RESEND] clk: imx5: Fix i.MX50 clock registers

2019-03-18 Thread Jonathan Neuschäfer
There are a few differences between the i.MX50 clock tree and those of i.MX51 and i.MX53 that are not yet handled in clk-imx51-imx53.c. This patch handles the following differences: - i.MX50 does not have a periph_apm clock. Instead, the main bus clock (a.k.a. periph_clk) comes directly from a

[PATCH] mfd: mc13xxx: i2c/spi Fix to avoid NULL pointer dereference

2019-03-18 Thread Aditya Pakki
of_match_device can return NULL if no matching device is found. The patches avoids a scenario causing null pointer dereference. Signed-off-by: Aditya Pakki --- drivers/mfd/mc13xxx-i2c.c | 2 ++ drivers/mfd/mc13xxx-spi.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >