[PATCH tip/core/rcu 05/11] rcu: Move rcu_print_task_exp_stall() to tree_exp.h

2019-03-26 Thread Paul E. McKenney
Because expedited CPU stall warnings are contained within the kernel/rcu/tree_exp.h file, rcu_print_task_exp_stall() should live there too. This commit carries out the required code motion. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_exp.h| 32 kerne

Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-26 Thread Suman Anna
Hi Tony, On 3/26/19 6:13 PM, Tony Lindgren wrote: > * Tony Lindgren [190325 22:00]: >> We should not do the reset until the clocks are enabled. Let's only init >> restctrl in sysc_init_resets() and do the reset later on in sysc_reset(). > ... > >> static int sysc_reset(struct sysc *ddata) >> {

[PATCH tip/core/rcu 02/11] rcu: Move RCU CPU stall-warning code out of tree_plugin.h

2019-03-26 Thread Paul E. McKenney
The RCU CPU stall-warning code for normal grace periods is currently scattered across two files, due to earlier Tiny RCU support for RCU CPU stall warnings and for old Kconfig options that have long since been retired. Given that it is hard for the lead RCU maintainer to find relevant stall-warnin

[PATCH tip/core/rcu 03/11] rcu: Move RCU CPU stall-warning code out of tree.c

2019-03-26 Thread Paul E. McKenney
This commit completes the process of consolidating the code for RCU CPU stall warnings for normal grace periods by moving the remaining such code from kernel/rcu/tree.c to kernel/rcu/tree_stall.h. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree.c | 291 -

[PATCH tip/core/rcu 07/11] rcu: Move FAST_NO_HZ stall-warning code to tree_stall.h

2019-03-26 Thread Paul E. McKenney
This commit further consolidates the stall-warning code by moving print_cpu_stall_info() and its helper functions along with zero_cpu_stall_ticks() to kernel/rcu/tree_stall.h. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree.h| 1 - kernel/rcu/tree_plugin.h | 80 -

[PATCH tip/core/rcu 01/11] rcu: Move RCU CPU stall-warning code out of update.c

2019-03-26 Thread Paul E. McKenney
The RCU CPU stall-warning code for normal grace periods is currently scattered across three files, due to earlier Tiny RCU support for RCU CPU stall warnings and for old Kconfig options that have long since been retired. Given that it is hard for the lead RCU maintainer to find relevant stall-warn

[PATCH tip/core/rcu 0/11] RCU CPU stall-warning changes for v5.2

2019-03-26 Thread Paul E. McKenney
Hello! This series is primarily code movement for RCU CPU stall warnings. If I am having a hard time finding the various scattered pieces of this code, it is in need of consolidation! 1-3.Move RCU CPU stall-warning code into kernel/rcu/tree_stall.h. 4. Inline RCU task stall-warning help

RE: [PATCH v19,RESEND 08/27] x86/cpu/intel: Detect SGX support and update caps appropriately

2019-03-26 Thread Huang, Kai
> On Tue, Mar 26, 2019 at 02:25:52PM -0700, Huang, Kai wrote: > > > > > > That being said, this in no way impacts KVM's ability to virtualize SGX, > > > e.g. > > > KVM can directly do CPUID and {RD,WR}MSR to probe the capabilities > > > of the platform as needed. > > > > I am not following. KVM ca

Re: [PATCH 5.0 00/52] 5.0.5-stable review

2019-03-26 Thread shuah
On 3/26/19 12:29 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.0.5 release. There are 52 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

Re: [PATCH 4.19 00/45] 4.19.32-stable review

2019-03-26 Thread shuah
On 3/26/19 12:29 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.32 release. There are 45 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.9 00/30] 4.9.166-stable review

2019-03-26 Thread shuah
On 3/26/19 12:29 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.166 release. There are 30 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

[PATCH tip/core/rcu 1/2] srcu: Check for in-flight callbacks in _cleanup_srcu_struct()

2019-03-26 Thread Paul E. McKenney
If someone fails to drain the corresponding SRCU callbacks (for example, by failing to invoke srcu_barrier()) before invoking either cleanup_srcu_struct() or cleanup_srcu_struct_quiesced(), the resulting diagnostic is an ambiguous use-after-free diagnostic, and even then only if you are running som

Re: [PATCH 4.14 00/41] 4.14.109-stable review

2019-03-26 Thread shuah
On 3/26/19 12:29 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.109 release. There are 41 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be mad

[PATCH tip/core/rcu 2/2] srcu: Remove cleanup_srcu_struct_quiesced()

2019-03-26 Thread Paul E. McKenney
The cleanup_srcu_struct_quiesced() function was added because NVME used WQ_MEM_RECLAIM workqueues and SRCU did not, which meant that NVME workqueues waiting on SRCU workqueues could result in deadlocks during low-memory conditions. However, SRCU now also has WQ_MEM_RECLAIM workqueues, so there is

[PATCH tip/core/rcu 09/18] rcu: Allow rcu_nocbs= to specify all CPUs

2019-03-26 Thread Paul E. McKenney
Currently, the rcu_nocbs= kernel boot parameter requires that a specific list of CPUs be specified, and has no way to say "all of them". As noted by user RavFX in a comment to Phoronix topic 1002538, this is an inconvenient side effect of the removal of the RCU_NOCB_CPU_ALL Kconfig option. This co

Re: [RFC 4/4] net/ipv4/fib: Don't synchronise_rcu() every 512Kb

2019-03-26 Thread Dmitry Safonov
On 3/26/19 3:39 PM, David Ahern wrote: > On 3/26/19 9:30 AM, Dmitry Safonov wrote: >> Fib trie has a hard-coded sync_pages limit to call synchronise_rcu(). >> The limit is 128 pages or 512Kb (considering common case with 4Kb >> pages). >> >> Unfortunately, at Arista we have use-scenarios with full

[PATCH tip/core/rcu 0/2] SRCU updates for v5.2

2019-03-26 Thread Paul E. McKenney
Hello! This series contains SRCU updates: 1. Check for in-flight callbacks in _cleanup_srcu_struct(). 2. Remove cleanup_srcu_struct_quiesced(). Thanx, Paul

[PATCH tip/core/rcu 17/18] rcu: Fix typo in tree_exp.h comment

2019-03-26 Thread Paul E. McKenney
This commit changes a rcu_exp_handler() comment from rcu_preempt_defer_qs() to rcu_preempt_deferred_qs() in order to better match reality. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_exp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree_exp.h b/kernel/

[PATCH tip/core/rcu 01/18] rcu: Unconditionally expedite during suspend/hibernate

2019-03-26 Thread Paul E. McKenney
The rcu_pm_notify() function refuses to switch to/from expedited grace periods on systems with more than 256 CPUs due to the serialized initialization of expedited grace periods. However, expedited grace periods are now initialized in parallel, removing this concern. This commit therefore removes

[PATCH tip/core/rcu 08/18] rcu: Move common code out of if-else block

2019-03-26 Thread Paul E. McKenney
From: Akira Yokosawa As the result of recent addition of "rdp->core_needs_qs = false;" in the "if" block, now both branches of the if-else have the same assignment. Factor it out and reduce line count. Signed-off-by: Akira Yokosawa Cc: Joel Fernandes Signed-off-by: Paul E. McKenney Acked-by:

[PATCH tip/core/rcu 10/18] rcu: Report error for bad rcu_nocbs= parameter values

2019-03-26 Thread Paul E. McKenney
This commit prints a console message when cpulist_parse() reports a bad list of CPUs, and sets all CPUs' bits in that case. The reason for setting all CPUs' bits is that this is the safe(r) choice for real-time workloads, which would normally be the ones using the rcu_nocbs= kernel boot parameter.

[PATCH tip/core/rcu 15/18] rcu: Fix force_qs_rnp() header comment

2019-03-26 Thread Paul E. McKenney
From: Zhouyi Zhou Previously, threads blocked on offlining CPUS were migrated to the root rcu_node structure, thus requiring RCU priority boosting on this structure. However, since commit d19fb8d1f3f6 ("rcu: Don't migrate blocked tasks even if all corresponding CPUs offline"), RCU does not migra

[PATCH tip/core/rcu 14/18] rcu: Update jiffies_to_sched_qs and adjust_jiffies_till_sched_qs() comments

2019-03-26 Thread Paul E. McKenney
This commit better documents the jiffies_to_sched_qs default-value strategy used by adjust_jiffies_till_sched_qs() Reported-by: Joel Fernandes Signed-off-by: Paul E. McKenney --- kernel/rcu/tree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/r

[PATCH tip/core/rcu 02/18] rcu: Avoid unnecessary softirq when system is idle

2019-03-26 Thread Paul E. McKenney
From: "Joel Fernandes (Google)" When there are no callbacks pending on an idle system, I noticed that RCU softirq is continuously firing. During this the cpu_no_qs is set to false, and core_needs_qs is set to true indefinitely. This causes rcu_process_callbacks to be repeatedly called, even thoug

[PATCH tip/core/rcu 06/18] MAINTAINERS: RCU now has its own email list

2019-03-26 Thread Paul E. McKenney
This commit makes r...@vger.kernel.org be the official list for RCU-related topics. Signed-off-by: Paul E. McKenney --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf70b548..1924b52937a6 100644 --- a/MAINTAINERS +++ b/

[PATCH tip/core/rcu 04/18] rcu: Make exit_rcu() handle non-preempted RCU readers

2019-03-26 Thread Paul E. McKenney
The purpose of exit_rcu() is to handle cases where buggy code causes a task to exit within an RCU read-side critical section. It currently does that in the case where said RCU read-side critical section was preempted at least once, but fails to handle cases where preemption did not occur. This ca

[PATCH tip/core/rcu 12/18] rcu: Default jiffies_to_sched_qs to jiffies_till_sched_qs

2019-03-26 Thread Paul E. McKenney
From: Neeraj Upadhyay The current code only calls adjust_jiffies_till_sched_qs() if jiffies_till_sched_qs is left at its default value, so when the jiffies_till_sched_qs kernel-boot parameter actually is specified, jiffies_to_sched_qs will be left with the value zero, which will result in useless

[PATCH tip/core/rcu 03/18] rcu: rcu_qs -- Use raise_softirq_irqoff to not save irqs twice

2019-03-26 Thread Paul E. McKenney
From: Cyrill Gorcunov The rcu_qs is disabling IRQs by self so no need to do the same in raise_softirq but instead we can save some cycles using raise_softirq_irqoff directly. CC: Paul E. McKenney Signed-off-by: Cyrill Gorcunov Signed-off-by: Paul E. McKenney --- kernel/rcu/tiny.c | 2 +- 1 f

[PATCH tip/core/rcu 13/18] rcu: Do a single rhp->func read in rcu_head_after_call_rcu()

2019-03-26 Thread Paul E. McKenney
From: Neeraj Upadhyay The rcu_head_after_call_rcu() function reads the rhp->func pointer twice, which can result in a false-positive WARN_ON_ONCE() if the callback were passed to call_rcu() between the two reads. Although racing rcu_head_after_call_rcu() with call_rcu() is to be a dubious use ca

[PATCH tip/core/rcu 11/18] rcu: Fix self-wakeups for grace-period kthread

2019-03-26 Thread Paul E. McKenney
From: Neeraj Upadhyay The current rcu_gp_kthread_wake() function uses in_interrupt() and thus does a self-wakeup from all interrupt contexts, including the pointless case where the GP kthread happens to be running with bottom halves disabled, along with the impossible case where the GP kthread is

[PATCH tip/core/rcu 18/18] rcu: Correct READ_ONCE()/WRITE_ONCE() for ->rcu_read_unlock_special

2019-03-26 Thread Paul E. McKenney
The task_struct structure's ->rcu_read_unlock_special field is only ever read or written by the owning task, but it is accessed both at process and interrupt levels. It may therefore be accessed using plain reads and writes while interrupts are disabled, but must be accessed using READ_ONCE() and

[PATCH tip/core/rcu 05/18] rcu: Set rcutree.kthread_prio sysfs access to read-only

2019-03-26 Thread Paul E. McKenney
From: Liu Song The rcutree.kthread_prio kernel-boot parameter is used to set the priority for boost (rcub), per-CPU (rcuc), and grace-period (rcu_preempt or rcu_sched) kthreads. It is also used by rcutorture to check whether it is possible to meaningfully test RCU priority boosting. However, al

[PATCH tip/core/rcu 07/18] MAINTAINERS: Add -rcu branch name ("dev")

2019-03-26 Thread Paul E. McKenney
Signed-off-by: Paul E. McKenney --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1924b52937a6..a9b5270d006e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8983,7 +8983,7 @@ R:Daniel Lustig L: linux-kernel@

Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-26 Thread Tony Lindgren
* Tony Lindgren [190325 22:00]: > We should not do the reset until the clocks are enabled. Let's only init > restctrl in sysc_init_resets() and do the reset later on in sysc_reset(). ... > static int sysc_reset(struct sysc *ddata) > { > int offset = ddata->offsets[SYSC_SYSCONFIG]; > -

[PATCH tip/core/rcu 16/18] rcu: Eliminate redundant NULL-pointer check

2019-03-26 Thread Paul E. McKenney
Because rcu_wake_cond() checks for a null task_struct pointer, there is no need for its callers to do so. This commit eliminates the redundant check. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_plugin.h | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/rc

[PATCH tip/core/rcu 0/18] Miscellaneous fixes for v5.2

2019-03-26 Thread Paul E. McKenney
Hello! This series contains miscellaneous fixes. 1. Unconditionally expedite during suspend/hibernate (unless the real-time guys have disabled expediting altogether, that is). 2. Avoid unnecessary softirq when system is idle, courtesy of Joel Fernandes. 3. rcu_qs

[PATCH] Yama: mark local symbols as static

2019-03-26 Thread Jann Horn
sparse complains that Yama defines functions and a variable as non-static even though they don't exist in any header. Fix it by making them static. Signed-off-by: Jann Horn --- security/yama/yama_lsm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/security/yama/yama_l

[PATCH tip/core/rcu 1/4] doc: Remove obsolete RCU update functions from RCU documentation

2019-03-26 Thread Paul E. McKenney
Now that synchronize_rcu_bh, synchronize_rcu_bh_expedited, call_rcu_bh, rcu_barrier_bh, synchronize_sched, synchronize_sched_expedited, call_rcu_sched, rcu_barrier_sched, get_state_synchronize_sched, and cond_synchronize_sched are obsolete, let's remove them from the documentation aside from a smal

[PATCH tip/core/rcu 4/4] doc: Fix typos and otherwise modernize checklist.txt

2019-03-26 Thread Paul E. McKenney
This commit fixes some issues with Documentation/RCU/checklist.txt. Signed-off-by: Paul E. McKenney --- Documentation/RCU/checklist.txt | 43 +++-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/Documentation/RCU/checklist.txt b/Documentation/RCU/chec

[PATCH tip/core/rcu 2/4] doc: Repair some whitespace damage

2019-03-26 Thread Paul E. McKenney
From: Tycho Andersen A diagram in whatisRCU.txt has space character before tabs. This commit therefore makes this diagram consistent with elsewhere in the document: Use one leading tab, followed by spaces for any additional whitespace required. Signed-off-by: Tycho Andersen Signed-off-by: Paul

[PATCH tip/core/rcu 3/4] doc: Describe choice of rcu_dereference() APIs and __rcu usage

2019-03-26 Thread Paul E. McKenney
Reported-by: Andrew Morton Signed-off-by: Paul E. McKenney --- Documentation/RCU/rcu_dereference.txt | 103 ++ 1 file changed, 103 insertions(+) diff --git a/Documentation/RCU/rcu_dereference.txt b/Documentation/RCU/rcu_dereference.txt index ab96227bad42..bf699e8cfc75 1

[PATCH tip/core/rcu 0/4] Documentation updates for v5.2

2019-03-26 Thread Paul E. McKenney
Hello! This series contains documentation updates: 1. Remove obsolete RCU update functions from RCU documentation. 2. Repair some whitespace damage, courtesy of Tycho Andersen. 3. Describe choice of rcu_dereference() APIs and __rcu usage. 4. Fix typos and otherwise moderniz

Re: INFO: rcu detected stall in __perf_sw_event

2019-03-26 Thread syzbot
syzbot has bisected this bug to: commit cf85d89562f39cc7ae73de54639f1915a9195b7a Author: Finn Thain Date: Fri May 25 07:34:36 2018 + m68k/mac: Enable PDMA for PowerBook 500 series bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1226cb8b20 start commit: b0314565 Mer

linux-next: build failure after merge of the sound-asoc tree

2019-03-26 Thread Stephen Rothwell
Hi all, After merging the sound-asoc tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/linux/printk.h:330, from include/linux/kernel.h:15, from include/linux/clk.h:16, from sound/soc/fsl/fsl_audm

[PATCH tip/core/rcu 0/2] straggling consolidation cleanups for v5.2

2019-03-26 Thread Paul E. McKenney
Hello! This series contains a few straggling RCU consolidation updates: 1. Update kprobes's documentation of obsolete RCU update functions. 2. Update netfilter comment from call_rcu_bh() to call_rcu() Thanx, Paul ---

Re: [PATCH] timekeeping: Force upper bound for setting CLOCK_REALTIME

2019-03-26 Thread Thomas Gleixner
On Tue, 26 Mar 2019, Arnd Bergmann wrote: > On Tue, Mar 26, 2019 at 1:31 PM Thomas Gleixner wrote: > > > > On Tue, 26 Mar 2019, Miroslav Lichvar wrote: > > > On Sat, Mar 23, 2019 at 11:36:19AM +0100, Thomas Gleixner wrote: > > > > It is reasonable to force an upper bound for the various methods of

[PATCH tip/core/rcu 2/2] net/ipv4/netfilter: Update comment from call_rcu_bh() to call_rcu()

2019-03-26 Thread Paul E. McKenney
The RCU flavors have been consolidated, so this commit replaces a comment's mention of call_rcu_bh() with call_rcu(). Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Florian Westphal Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI Cc: Cc: Cc: --- net/ipv4/netfi

Re: [PATCH] EDAC/amd64: Use maximum channel count for the EDAC channel layer size

2019-03-26 Thread Borislav Petkov
On Tue, Mar 26, 2019 at 07:15:29PM +, Ghannam, Yazen wrote: > Just tested on a fully populated system. Everything seems to be okay. Thanks, queued. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v2 2/4] mm/sparse: Optimize sparse_add_one_section()

2019-03-26 Thread Baoquan He
Hi Michal, On 03/26/19 at 03:31pm, Michal Hocko wrote: > > > > OK, I am fine to drop it. Or only put the section existence checking > > > > earlier to avoid unnecessary usemap/memmap allocation? > > > > > > DO you have any data on how often that happens? Should basically never > > > happening, ri

Re: New feature/ABI review process [was Re: [RESEND PATCH v6 04/12] x86/fsgsbase/64:..]

2019-03-26 Thread Andi Kleen
> > If you want to advocate the more complex design of mixed SWAPGS/FSGSBASE > then provide numbers and not hand-waving. Numbers of real-world workloads, > not numbers of artificial test cases which exercise the rare worst case. Well you're proposing the much more complicated solution, not me. S

Re: [PATCH v3] kmemleaak: survive in a low-memory situation

2019-03-26 Thread Qian Cai
On 3/26/19 12:06 PM, Catalin Marinas wrote: > I wonder whether we'd be better off to replace the metadata allocator > with gen_pool. This way we'd also get rid of early logging/replaying of > the memory allocations since we can populate the gen_pool early with a > static buffer. I suppose this is

[PATCH 1/3] fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock

2019-03-26 Thread Kirill Smelkov
Commit 9c225f2655 (vfs: atomic f_pos accesses as per POSIX) added locking for file.f_pos access and in particular made concurrent read and write not possible - now both those functions take f_pos lock for the whole run, and so if e.g. a read is blocked waiting for data, write will deadlock waiting

Re: [RFC PATCH v2 1/3] resource: Request IO port regions from children of ioport_resource

2019-03-26 Thread Bjorn Helgaas
[+cc Catalin, Will, linux-arm-kernel] On Tue, Mar 26, 2019 at 04:33:55PM +, John Garry wrote: > On 25/03/2019 23:32, Bjorn Helgaas wrote: > > On Thu, Mar 21, 2019 at 02:14:08AM +0800, John Garry wrote: > > > Currently when we request an IO port region, the request is made directly > > > to the

Re: [PATCH 22/27] Lock down kprobes

2019-03-26 Thread Masami Hiramatsu
On Tue, 26 Mar 2019 10:41:23 -0700 Matthew Garrett wrote: > On Tue, Mar 26, 2019 at 5:30 AM Masami Hiramatsu wrote: > > > > On Mon, 25 Mar 2019 15:09:49 -0700 > > Matthew Garrett wrote: > > > > > From: David Howells > > > > > > Disallow the creation of kprobes when the kernel is locked down by

RE: [PATCH v3] HID: core: move Usage Page concatenation to Main item

2019-03-26 Thread Junge, Terry
Hi Nicolas, This patch looks good except for one comment/question below. Thanks, Terry On Tuesday, March 26, 2019 1:04 PM Nicolas Saenz Julienne wrote: > >As seen on some USB wireless keyboards manufactured by Primax, the HID >parser was using some assumptions that are not always true. In this

[PATCH 2/4] ACPI/PPTT: Modify node flag detection to find last IDENTICAL

2019-03-26 Thread Jeremy Linton
The ACPI specification implies that the IDENTICAL flag should be set on all non leaf nodes where the children are identical. This means that we need to be searching for the last node with the identical flag set rather than the first one. To achieve this with the existing code we need to pass a fun

[PATCH 3/4] arm_pmu: acpi: spe: Add initial MADT/SPE probing

2019-03-26 Thread Jeremy Linton
ACPI 6.3 adds additional fields to the MADT GICC structure to describe SPE PPI's. We pick these out of the cached reference to the madt_gicc structure similarly to the core PMU code. We then create a platform device referring to the IRQ and let the user/module loader decide whether to load the SPE

[PATCH 0/4] arm64: SPE ACPI enablement

2019-03-26 Thread Jeremy Linton
This patch series enables the Arm Statistical Profiling Extension (SPE) on ACPI platforms. This is possible because ACPI 6.3 uses a previously reserved field in the MADT to store the SPE interrupt number, similarly to how the normal PMU is described. If a consistent valid interrupt exists across a

[PATCH 4/4] perf: arm_spe: Enable ACPI/Platform automatic module loading

2019-03-26 Thread Jeremy Linton
Lets add the MODULE_TABLE and platform id_table entries so that the SPE driver can attach to the ACPI platform device created by the core pmu code. Signed-off-by: Jeremy Linton Reviewed-by: Sudeep Holla --- drivers/perf/arm_spe_pmu.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletion

[PATCH 1/4] ACPI/PPTT: Add function to return ACPI 6.3 Identical tokens

2019-03-26 Thread Jeremy Linton
ACPI 6.3 adds a flag to indicate that child nodes are all identical cores. This is useful to authoritatively determine if a set of (possibly offline) cores are identical or not. Since the flag doesn't give us a unique id we can generate one and use it to create bitmaps of sibling nodes, or simply

Re: [RFC PATCH v4 0/8] This patch-set is to enable Guest CET support

2019-03-26 Thread Sean Christopherson
On Tue, Mar 26, 2019 at 04:45:34AM +0800, Yang Weijiang wrote: > Hi, Paolo and Sean, > Do you have any comments on v4 patches? My backlog is a bit full at the moment, I'll try to review the series later this week.

Re: [PATCH] irqchip: plic: Fix priority base offset

2019-03-26 Thread Alistair Francis
On Fri, Mar 22, 2019 at 6:27 AM Christoph Hellwig wrote: > > On Wed, Mar 20, 2019 at 05:04:58PM -0700, Alistair Francis wrote: > > > Well, it starts at 0x00, but the first one is reserved. If you think > > > that is too confusing I'd rather throw in a comment explaining this > > > fact rather tha

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-26 Thread Thomas Gleixner
Andi. On Tue, 26 Mar 2019, Andi Kleen wrote: > On Tue, Mar 26, 2019 at 06:03:59PM +0100, Thomas Gleixner wrote: > > On Thu, 21 Mar 2019, Andi Kleen wrote: > > > > > With gcc 8 toplevel assembler statements that do not mark themselves > > > as .text may end up in other sections. > > > > Which is

Re: [PATCH V4 04/23] perf/x86/intel: Support adaptive PEBSv4

2019-03-26 Thread Andi Kleen
> + for (at = base; at < top; at += cpuc->pebs_record_size) { > + u64 pebs_status; > + > + pebs_status = get_pebs_status(at) & cpuc->pebs_enabled; > + pebs_status &= mask; > + > + for_each_set_bit(bit, (unsigned long *)&pebs_status, size) > +

Re: [GIT PULL] Please pull NFS client fixes

2019-03-26 Thread pr-tracker-bot
The pull request you sent on Tue, 26 Mar 2019 20:12:07 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-5.1-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/14c741de93861749dfb60b4964028541f5c506ca Thank you! -- Deet-doot-dot, I am a bot.

[PATCH 1/4] perf, tools: Revert checks for duration_time

2019-03-26 Thread Andi Kleen
From: Andi Kleen This reverts e864c5ca145e perf stat: Hide internal duration_time counter but doing it manually since the code has now moved to a different file. The next patch will properly implement duration_time as a full event, so no need to hide it anymore. Signed-off-by: Andi Kleen ---

[PATCH 3/4] perf, tools: Support name for duration_time

2019-03-26 Thread Andi Kleen
From: Andi Kleen Implement printing the correct name for duration_time Signed-off-by: Andi Kleen --- tools/perf/util/evsel.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 7835e05f0c0a..6872394b6f55 100644

[PATCH 4/4] perf, tools, list: Output tool events

2019-03-26 Thread Andi Kleen
From: Andi Kleen Add support to perf list to output tool internal events, currently only duration_time. Signed-off-by: Andi Kleen --- tools/perf/builtin-list.c | 6 -- tools/perf/util/parse-events.c | 20 tools/perf/util/parse-events.h | 1 + 3 files changed, 25

[PATCH 2/4] perf, tools: Implement duration_time as a proper event

2019-03-26 Thread Andi Kleen
From: Andi Kleen The perf metric expression use duration_time internally to normalize events. Normal perf stat without -x also prints the duration time. But when using -x, the interval is not output anywhere, which is inconvenient for any post processing which often wants to normalize values to t

perf: Add duration_time to perf stat

2019-03-26 Thread Andi Kleen
Currently it's not possible to get the wall clock time of a measurement in CSV mode output, it's only in the non CSV perf stat output. Often this is needed to normalize event counts to time. Add a new duration_time event that can be specified and reports the wall clock time in ns.

Re: [PATCH 3/6] bitmap_parselist: rework input string parser

2019-03-26 Thread Mike Travis
On 3/26/2019 2:09 PM, Yuri Norov wrote: + Mike Travis + Thomas Gleixner -- On Tue, Mar 26, 2019 at 12:07:45AM +0300, Yury Norov wrote: The requirement for this rework is to keep the __bitmap_parselist() copy-less and singl

Re: [PATCH v19,RESEND 08/27] x86/cpu/intel: Detect SGX support and update caps appropriately

2019-03-26 Thread Sean Christopherson
On Tue, Mar 26, 2019 at 02:25:52PM -0700, Huang, Kai wrote: > > > > That being said, this in no way impacts KVM's ability to virtualize SGX, > > e.g. > > KVM can directly do CPUID and {RD,WR}MSR to probe the capabilities of the > > platform as needed. > > I am not following. KVM can do whatever

Re: [PATCH 10/25] coresight: tpiu: Clean up device specific data

2019-03-26 Thread Mathieu Poirier
On Wed, Mar 20, 2019 at 06:49:27PM +, Suzuki K Poulose wrote: > Switch to using the coresight device instead of the parent > amba device. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tpiu.c | 12 ++-- > 1 file changed, 6 ins

Re: [PATCH 08/25] coresight: tmc: Clean up device specific data

2019-03-26 Thread Mathieu Poirier
Hi Suzuki, On Wed, Mar 20, 2019 at 06:49:25PM +, Suzuki K Poulose wrote: > In preparation to use a consistent device naming scheme, > clean up the device link tracking in replicator driver. > Use the "coresight" device instead of the "real" parent device > for all internal purposes. All other

[PATCH] watchdog: Respect watchdog cpumask on CPU hotplug

2019-03-26 Thread Thomas Gleixner
The rework of the watchdog core to use cpu_stop_work broke the watchdog cpumask on CPU hotplug. The watchdog_enable/disable() functions are now called unconditionally from the hotplug callback, i.e. even on CPUs which are not in the watchdog cpumask. Only invoke them when the plugged CPU is in th

Re: [PATCH] ACPI / PM: Propagate KEY_POWER wakeup events to user space

2019-03-26 Thread Rafael J. Wysocki
On Mon, Mar 4, 2019 at 4:18 AM Chen, Hu wrote: > > When the system is woken from S3 by the ACPI fixed power button, send > KEY_POWER to user space. > > I run Android on x86 PC (it's a NUC). Everytime I press the power button > to wake the system, it suspends right away. After some debug, I find >

Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2

2019-03-26 Thread Steven Rostedt
On Tue, 26 Mar 2019 14:29:27 -0700 Linus Torvalds wrote: > On Tue, Mar 26, 2019 at 11:48 AM Steven Rostedt wrote: > > > > Should I work on changing this? > > I don't personally much care, but the pr-tracker-bot clearly does. > > If you don't care about the automated "it's been pulled" messag

Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes

2019-03-26 Thread Angus Ainslie
On 2019-03-19 07:31, Shawn Guo wrote: On Fri, Mar 08, 2019 at 12:02:22PM +, Daniel Baluta wrote: SDMA1 is part of AIPS-3 region and SDMA2 is part of AIPS-1 region. Reviewed-by: Fabio Estevam Reviewed-by tag should go after your SoB, since that's the sequence of how they come. Signed-of

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-26 Thread Andi Kleen
On Tue, Mar 26, 2019 at 06:03:59PM +0100, Thomas Gleixner wrote: > Andi, > > On Thu, 21 Mar 2019, Andi Kleen wrote: > > > With gcc 8 toplevel assembler statements that do not mark themselves > > as .text may end up in other sections. > > Which is clearly a change in behaviour. Is that intended o

Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2

2019-03-26 Thread Linus Torvalds
On Tue, Mar 26, 2019 at 11:48 AM Steven Rostedt wrote: > > Should I work on changing this? I don't personally much care, but the pr-tracker-bot clearly does. If you don't care about the automated "it's been pulled" message, that doesn't matter, of course. That said, I'd almost prefer to get jus

Re: [RFC PATCH v2 13/14] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > + When hpet is specified, the NMI watchdog will be driven > + by an HPET timer, if available in the system. Otherwise, > + the perf-based implementation will be used. Specifying > +

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Rafael J. Wysocki
On Tue, Mar 26, 2019 at 7:31 PM Leon Romanovsky wrote: > > On Tue, Mar 26, 2019 at 07:08:07PM +0100, Rafael J. Wysocki wrote: > > On Tue, Mar 26, 2019 at 6:53 PM Leon Romanovsky wrote: > > > > > > On Tue, Mar 26, 2019 at 05:30:22PM +0100, Rafael J. Wysocki wrote: > > > > On Tue, Mar 26, 2019 at 4

[PATCH 2/2] EDAC, altera: Initialize peripheral FIFOs in probe()

2019-03-26 Thread thor . thayer
From: Thor Thayer The FIFO memory and ECC initialization doesn't need to be done as a separate operation early in the startup. Improve the Arria10 and Stratix10 peripheral FIFO init by initializing memory and enabling ECC as part of the device driver initialization. Signed-off-by: Thor Thayer

[PATCH 1/2] EDAC, altera: Less Intrusive Error Injection

2019-03-26 Thread thor . thayer
From: Thor Thayer Improve the Arria10 and Stratix10 error injection routine by reading the data and changing just 1 bit before writing back out. Previous routine would overwrite the first bytes to 0 then change 1 bit but this method is less intrusive. Signed-off-by: Thor Thayer --- drivers/eda

RE: [PATCH v19,RESEND 08/27] x86/cpu/intel: Detect SGX support and update caps appropriately

2019-03-26 Thread Huang, Kai
> > On Tue, Mar 26, 2019 at 05:17:40AM -0700, Huang, Kai wrote: > > On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote: > > > From: Sean Christopherson > > > > > > Similar to other large Intel features such as VMX and TXT, SGX must > > > be explicitly enabled in IA32_FEATURE_CONTROL MSR to

Re: [PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-26 Thread Scott Wood
On Tue, 2019-03-26 at 14:33 -0500, Alan Tull wrote: > On Mon, Mar 25, 2019 at 5:58 PM Scott Wood wrote: > > Hi Scott, > > > On Mon, 2019-03-25 at 17:53 -0500, Scott Wood wrote: > > > On Mon, 2019-03-25 at 11:07 +0800, Wu Hao wrote: > > > > +#if defined(CONFIG_X86) && defined(CONFIG_AS_AVX512) >

Re: [PATCH V31 10/25] PCI: Lock down BAR access when the kernel is locked down

2019-03-26 Thread Alex Williamson
On Tue, 26 Mar 2019 13:55:39 -0700 Andy Lutomirski wrote: > On Tue, Mar 26, 2019 at 11:28 AM Matthew Garrett > wrote: > > > > From: Matthew Garrett > > > > Any hardware that can potentially generate DMA has to be locked down in > > order to avoid it being possible for an attacker to modify kern

Re: [PATCH] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-26 Thread Jett Rink
Tested-by: Jett Rink On Sun, Mar 24, 2019 at 9:36 AM Srinivas Pandruvada wrote: > > On Sat, 2019-03-23 at 16:46 +0530, Rushikesh S Kadam wrote: > > This driver adds support for loading Intel Integrated > > Sensor Hub (ISH) firmware from host file system to ISH > > SRAM and start execution. > >

[PATCH v11] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-03-26 Thread Liming Sun
This commit adds the TmFifo platform driver for Mellanox BlueField Soc. TmFifo is a shared FIFO which enables external host machine to exchange data with the SoC via USB or PCIe. The driver is based on virtio framework and has console and network access enabled. Reviewed-by: Vadim Pasternak Signe

Re: [RFC PATCH v2 06/14] x86/hpet: Configure the timer used by the hardlockup detector

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > +#ifdef CONFIG_X86_HARDLOCKUP_DETECTOR_HPET > +struct hpet_hld_data *hpet_hardlockup_detector_assign_timer(void) > +{ > + struct hpet_hld_data *hdata; > + unsigned int cfg; > + > + cfg = hpet_readl(HPET_Tn_CFG(HPET_WD_TIMER_NR)); > + > + if

Re: [RFC PATCH v2 05/14] x86/hpet: Relocate flag definitions to a header file

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > Users of HPET timers (such as the hardlockup detector) need the definitions > of these flags to interpret the configuration of a timer as passed by > platform code. Which platform code? > +#define HPET_DEV_USED_BIT2 > +#define HPET_DEV_USED

Re: [PATCH 3/6] bitmap_parselist: rework input string parser

2019-03-26 Thread Yuri Norov
+ Mike Travis + Thomas Gleixner -- On Tue, Mar 26, 2019 at 12:07:45AM +0300, Yury Norov wrote: >> The requirement for this rework is to keep the __bitmap_parselist() >> copy-less and single-pass but make it more readable and mai

RE: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave Driver

2019-03-26 Thread Huang, Kai
> On Tue, Mar 26, 2019 at 01:40:57PM +0100, Thomas Gleixner wrote: > > On Tue, 26 Mar 2019, Huang, Kai wrote: > > > On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote: > > > > 13 files changed, 1657 insertions(+), 2 deletions(-) create mode > > > > 100644 arch/x86/include/uapi/asm/sgx.h cr

Re: [PATCH v2 3/5] gpio: use new gpio_set_config() helper in more places

2019-03-26 Thread Thomas Petazzoni
Hello Guenter, On Tue, 26 Mar 2019 13:03:02 -0700 Guenter Roeck wrote: > > I'll have a look. In the mean time, I'm fine with the patch being > > reverted. > > The problem is still seen in the latest kernel as of last night, and > I did not see any further activities. Should I send a revert requ

Re: [RFC PATCH 1/4] vfs: Create fs_context-aware mount_bdev() replacement

2019-03-26 Thread Andrew Price
Hi David, I've been testing gfs2 on top of this patch and it seems... On 19/03/2019 16:23, David Howells wrote: Create a function, vfs_get_block_super(), that is fs_context-aware and a replacement for mount_bdev(). It caches the block device pointer and file open mode in the fs_context struct

Re: [PATCH v2 0/8] klp-convert

2019-03-26 Thread Joe Lawrence
On 3/26/19 4:18 PM, Joao Moreira wrote: On 3/18/19 4:18 PM, Joe Lawrence wrote: On Fri, Mar 01, 2019 at 11:13:05AM -0300, Joao Moreira wrote: Livepatches may use symbols which are not contained in its own scope, and, because of that, may end up compiled with relocations that will only be reso

Re: [RFC PATCH v2 03/14] x86/hpet: Calculate ticks-per-second in a separate function

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > int hpet_alloc(struct hpet_data *hdp) > { > u64 cap, mcfg; > @@ -845,7 +868,6 @@ int hpet_alloc(struct hpet_data *hdp) > size_t siz; > struct hpet __iomem *hpet; > static struct hpets *last; > - unsigned long period; > u

Re: [RFC PATCH v2 02/14] x86/hpet: Expose more functions to read and write registers

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > struct irq_data; > @@ -109,6 +114,11 @@ extern void hpet_unregister_irq_handler(rtc_irq_handler > handler); > static inline int hpet_enable(void) { return 0; } > static inline int is_hpet_enabled(void) { return 0; } > #define hpet_readl(a) 0 > +#defin

Re: [PATCH V31 11/25] x86: Lock down IO port access when the kernel is locked down

2019-03-26 Thread Andy Lutomirski
On Tue, Mar 26, 2019 at 11:28 AM Matthew Garrett wrote: > > From: Matthew Garrett > > IO port access would permit users to gain access to PCI configuration > registers, which in turn (on a lot of hardware) give access to MMIO > register space. This would potentially permit root to trigger arbitra

Re: [RFC PATCH v2 12/14] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI

2019-03-26 Thread Thomas Gleixner
On Wed, 27 Feb 2019, Ricardo Neri wrote: > @@ -62,7 +67,18 @@ static inline void set_comparator(struct hpet_hld_data > *hdata, > static void kick_timer(struct hpet_hld_data *hdata, bool force) > { > bool kick_needed = force || !(hdata->flags & HPET_DEV_PERI_CAP); > - unsigned long new_

<    1   2   3   4   5   6   7   8   9   10   >