Re: [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities

2019-03-26 Thread Jan Kiszka
On 26.03.19 18:05, Stephen Boyd wrote: Quoting Kieran Bingham (2019-03-26 01:52:10) Hi Stephen, On 25/03/2019 18:45, Stephen Boyd wrote: Implement gdb functions for rb_first(), rb_last(), rb_next(), and rb_prev(). These can be useful to iterate through the kernel's red-black trees. I

Re: [PATCH] ASoC: core: Fix use-after-free after deferred card registration

2019-03-26 Thread Curtis Malainey
This has already been patched. See https://mailman.alsa-project.org/pipermail/alsa-devel/2019-March/146150.html On Tue, Mar 26, 2019 at 10:23 AM Guenter Roeck wrote: > > If snd_soc_register_card() fails because one of its links fails > to instantiate with -EPROBE_DEFER, and the to-be-registered

Re: [RESEND PATCH v6 02/11] dt-bindings: power: supply: add DT bindings for max77650

2019-03-26 Thread Bartosz Golaszewski
pt., 22 mar 2019 o 10:00 Pavel Machek napisał(a): > > On Mon 2019-03-18 18:40:31, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Add the DT binding document for the battery charger module of max77650. > > > > Signed-off-by: Bartosz Golaszewski > > --- > >

Re: [PATCHv4 16/28] PCI: mobiveil: refactor Mobiveil PCIe Host Bridge IP driver

2019-03-26 Thread Lorenzo Pieralisi
On Mon, Mar 11, 2019 at 09:32:04AM +, Z.q. Hou wrote: > From: Hou Zhiqiang > > As the Mobiveil PCIe controller support RC DAUL mode, and to > make platforms which integrated the Mobiveil PCIe IP more easy > to add their drivers, this patch moved the Mobiveil driver to > a new directory

[PATCH v7 04/11] dt-bindings: input: add DT bindings for max77650

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the DT binding document for the onkey module of max77650. Signed-off-by: Bartosz Golaszewski Reviewed-by: Rob Herring --- .../bindings/input/max77650-onkey.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644

[PATCH v7 02/11] dt-bindings: power: supply: add DT bindings for max77650

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the DT binding document for the battery charger module of max77650. Signed-off-by: Bartosz Golaszewski --- .../power/supply/max77650-charger.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644

[PATCH v7 03/11] dt-bindings: leds: add DT bindings for max77650

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the DT binding document for the LEDs module of max77650. Signed-off-by: Bartosz Golaszewski Reviewed-by: Rob Herring --- .../bindings/leds/leds-max77650.txt | 57 +++ 1 file changed, 57 insertions(+) create mode 100644

Re: [PATCH] cpuset: restore sanity to cpuset_cpus_allowed_fallback()

2019-03-26 Thread Joel Savitz
Forgot to add cc's... my bad. Best, Joel Savitz On Tue, Mar 26, 2019 at 1:31 PM Joel Savitz wrote: > > Ping! > > Does anyone have any comments or concerns about this patch? > > Best, > Joel Savitz > > Best, > Joel Savitz > > > On Thu, Mar 7, 2019 at 9:42 AM Joel Savitz wrote: > > > > On Wed,

[PATCH v7 05/11] mfd: core: document mfd_add_devices()

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a kernel doc for mfd_add_devices(). Signed-off-by: Bartosz Golaszewski Acked-by: Pavel Machek --- drivers/mfd/mfd-core.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index

[PATCH v7 06/11] mfd: max77650: new core mfd driver

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches. Signed-off-by: Bartosz Golaszewski --- drivers/mfd/Kconfig | 14 +++ drivers/mfd/Makefile | 1 +

[PATCH v7 09/11] leds: max77650: add LEDs support

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs. Signed-off-by: Bartosz Golaszewski Acked-by: Jacek Anaszewski --- drivers/leds/Kconfig | 6 ++ drivers/leds/Makefile| 1 +

[PATCH v7 10/11] input: max77650: add onkey support

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add support for the push- and slide-button events for max77650. Signed-off-by: Bartosz Golaszewski Acked-by: Dmitry Torokhov Acked-by: Pavel Machek --- drivers/input/misc/Kconfig | 9 +++ drivers/input/misc/Makefile | 1 +

[PATCH v7 11/11] MAINTAINERS: add an entry for max77650 mfd driver

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski I plan on extending this set of drivers so add myself as maintainer. Signed-off-by: Bartosz Golaszewski --- MAINTAINERS | 14 ++ 1 file changed, 14 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e5a5d263f29..b32fe859c341 100644 ---

[PATCH v7 08/11] gpio: max77650: add GPIO support

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add GPIO support for max77650 mfd device. This PMIC exposes a single GPIO line. Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 7 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-max77650.c | 190

[PATCH v7 07/11] power: supply: max77650: add support for battery charger

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add basic support for the battery charger for max77650 PMIC. Signed-off-by: Bartosz Golaszewski --- drivers/power/supply/Kconfig| 7 + drivers/power/supply/Makefile | 1 + drivers/power/supply/max77650-charger.c | 367

Re: [PATCH net-next v5 05/22] ethtool: introduce ethtool netlink interface

2019-03-26 Thread Michal Kubecek
On Tue, Mar 26, 2019 at 05:36:40PM +0100, Jiri Pirko wrote: > Mon, Mar 25, 2019 at 06:08:09PM CET, mkube...@suse.cz wrote: > >+/* genetlink setup */ > >+ > >+static const struct genl_ops ethtool_genl_ops[] = { > > Please be consistent with prefixes. Either use "ethtool_" or "ethnl_" > for all

[PATCH v7 00/11] mfd: add support for max77650 PMIC

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds support for max77650 ultra low-power PMIC. It provides the core mfd driver and a set of five sub-drivers for the regulator, power supply, gpio, leds and input subsystems. Patches 1-4 add the DT binding documents. Patch 5 documents mfd_add_devices().

[PATCH v7 01/11] dt-bindings: mfd: add DT bindings for max77650

2019-03-26 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a DT binding document for max77650 ultra-low power PMIC. This describes the core mfd device and the GPIO module. Signed-off-by: Bartosz Golaszewski Reviewed-by: Rob Herring Acked-by: Pavel Machek --- .../devicetree/bindings/mfd/max77650.txt | 46

Re: [PATCH] cpuset: restore sanity to cpuset_cpus_allowed_fallback()

2019-03-26 Thread Joel Savitz
Ping! Does anyone have any comments or concerns about this patch? Best, Joel Savitz Best, Joel Savitz On Thu, Mar 7, 2019 at 9:42 AM Joel Savitz wrote: > > On Wed, Mar 6, 2019 at 7:55 PM Joel Savitz wrote: > > > > If a process is limited by taskset (i.e. cpuset) to only be allowed to > >

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-26 Thread Alexey Gladkov
On Fri, Mar 22, 2019 at 02:34:12PM +0900, Masahiro Yamada wrote: > Hi. > > (added some people to CC) > > > On Fri, Mar 15, 2019 at 7:10 PM Alexey Gladkov > wrote: > > > > Problem: > > > > When a kernel module is compiled as a separate module, some important > > information about the kernel

Re: [PATCH 08/17] x86/speculation: Fix __initconst in bugs.c

2019-03-26 Thread Thomas Gleixner
On Thu, 21 Mar 2019, Andi Kleen wrote: Finally found a fix in the pile of unrelated crap. Subject: x86/speculation: Fix __initconst in bugs.c So how does this fix __initconst? Again from Documentation: "The summary phrase in the email’s Subject should concisely describe the patch which

[PATCH v2 0/2] PCI/AER: Consistently use _OSC to determine who owns AER

2019-03-26 Thread Alexandru Gagniuc
This started as a nudge from Keith, who pointed out that it doesn't make sense to disable AER services when only one device has a FIRMWARE_FIRST HEST. I won't re-phrase the points in the original patch [1]. The patch started a long discussion in the ACPI Software Working Group (ASWG). The nearly

[PATCH] ASoC: core: Fix use-after-free after deferred card registration

2019-03-26 Thread Guenter Roeck
If snd_soc_register_card() fails because one of its links fails to instantiate with -EPROBE_DEFER, and the to-be-registered link is a legacy link, a subsequent retry will trigger a use-after-free and quite often a system crash. Example: byt-max98090 byt-max98090: ASoC: failed to init link

A CALL FOR HELP

2019-03-26 Thread Mrs Ruhama Koenig
My Dearest, Please forgive me for stressing you with my predicaments as I know that this letter may come to you as big surprise. Actually, I came across your E-mail from my personal search afterward I decided to email you directly believing that you will be honest to fulfil my final wish

Re: [PATCH v6 3/3] arm64: dts: Add USB DT nodes for Stingray SoC

2019-03-26 Thread Florian Fainelli
On Tue, 19 Mar 2019 14:45:44 +0530, Srinath Mannam wrote: > Add DT nodes for > - Two xHCI host controllers > - Two BDC Broadcom USB device controller > - Five USB PHY controllers > > [xHCI0] [BDC0][xHCI1][BDC1] >| | |

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 1:17 PM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 01:15:25PM -0400, Joel Fernandes wrote: > > On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: > > [snip] > > > > > > > > > + > > > > > + if (!result) > > > > > +

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:15:25PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: > [snip] > > > > + struct pid *struct_pid; > > > > + pid_t result; > > > > + > > > > + if (flags) > > > > + return -EINVAL; > > > > +

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote: [snip] > > > + struct pid *struct_pid; > > > + pid_t result; > > > + > > > + if (flags) > > > + return -EINVAL; > > > + > > > + switch (cmd) { > > > + case PIDCMD_QUERY_PID: > > > + break; > > > + case

Re: [PATCH] arm64: dts: msm8998: Add UFS phy reset

2019-03-26 Thread Marc Gonzalez
On 26/03/2019 18:05, Evan Green wrote: > With the new refactoring at [1], the UFS phy now controls its own > destiny in toggling the phy reset bit within the UFS host controller. > Add the DT pieces needed to 1) expose the reset controller from the > HC, and 2) use it from the PHY. This series is

Re: [PATCH v19,RESEND 24/27] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions

2019-03-26 Thread Andy Lutomirski
On Mon, Mar 25, 2019 at 9:53 PM Xing, Cedric wrote: > > > On Mon, Mar 25, 2019 at 11:03 AM Sean Christopherson > > wrote: > > > > > > On Sun, Mar 24, 2019 at 01:59:48AM -0700, Xing, Cedric wrote: > > > > As said in my previous email, this vDSO API isn't even compliant to > > > > x86_64 ABI and

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 01:06:01PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:50:28AM -0700, Daniel Colascione wrote: > On Tue, Mar 26, 2019 at 9:44 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > > wrote: > > > > > > > > On

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Joel Fernandes
On Tue, Mar 26, 2019 at 04:55:11PM +0100, Christian Brauner wrote: > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is preserved in this >

Re: [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities

2019-03-26 Thread Stephen Boyd
Quoting Kieran Bingham (2019-03-26 01:52:10) > Hi Stephen, > > On 25/03/2019 18:45, Stephen Boyd wrote: > > Implement gdb functions for rb_first(), rb_last(), rb_next(), and > > rb_prev(). These can be useful to iterate through the kernel's red-black > > trees. > > I definitely approve of

[PATCH] arm64: dts: msm8998: Add UFS phy reset

2019-03-26 Thread Evan Green
With the new refactoring at [1], the UFS phy now controls its own destiny in toggling the phy reset bit within the UFS host controller. Add the DT pieces needed to 1) expose the reset controller from the HC, and 2) use it from the PHY. This series is based atop linux-next plus Marc's series at

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-26 Thread Thomas Gleixner
Andi, On Thu, 21 Mar 2019, Andi Kleen wrote: > With gcc 8 toplevel assembler statements that do not mark themselves > as .text may end up in other sections. Which is clearly a change in behaviour. Is that intended or just yet another feature of GCC? Your subject says: 'x86, lto:' So is this a

[PATCH fixes] MIPS: perf: Fix build with CONFIG_CPU_BMIPS5000 enabled

2019-03-26 Thread Florian Fainelli
The 'event' variable may be unused in case only CONFIG_CPU_BMIPS5000 being enabled: arch/mips/kernel/perf_event_mipsxx.c: In function 'mipsxx_pmu_enable_event': arch/mips/kernel/perf_event_mipsxx.c:326:21: error: unused variable 'event' [-Werror=unused-variable] struct perf_event *event =

RE: [PATCH v7 2/4] perf/smmuv3: Add arm64 smmuv3 pmu driver

2019-03-26 Thread Shameerali Kolothum Thodi
Hi Robin, > -Original Message- > From: Robin Murphy [mailto:robin.mur...@arm.com] > Sent: 26 March 2019 16:58 > To: Shameerali Kolothum Thodi ; > lorenzo.pieral...@arm.com > Cc: andrew.mur...@arm.com; jean-philippe.bruc...@arm.com; > will.dea...@arm.com; mark.rutl...@arm.com; Guohanjun

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:46 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:42:59AM -0700, Andy Lutomirski wrote: > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > wrote: > > > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > > On Tue, Mar 26,

Re: Fixes and cleanup from LTO tree

2019-03-26 Thread Thomas Gleixner
Andi, On Thu, 21 Mar 2019, Andi Kleen wrote: > Here are a range of bug fixes and cleanups that have accumulated in my > gcc Link Time Optimization (LTO) branches; for issues found > by the compiler when doing global optimization and a few > other issues. > >

[PATCH] lib/lzo: fix bugs for very short or empty input

2019-03-26 Thread Dave Rodgman
For very short input data (0 - 1 bytes), lzo-rle was not behaving correctly. Fix this behaviour and update documentation accordingly. For zero-length input, lzo v0 outputs an end-of-stream marker only, which was misinterpreted by lzo-rle as a bitstream version number. Ensure bitstream versions >

Re: [PATCH v2] genirq: Respect IRQCHIP_SKIP_SET_WAKE in irq_chip_set_wake_parent()

2019-03-26 Thread Stephen Boyd
Quoting Marc Zyngier (2019-03-26 04:11:56) > Hi Stephen, > > On 25/03/2019 18:10, Stephen Boyd wrote: > > This function returns an error if a child irqchip calls > > irq_chip_set_wake_parent() but its parent irqchip has the > > IRQCHIP_SKIP_SET_WAKE flag set. Let's return 0 for success here

Re: [PATCH v6 04/19] powerpc: mm: Add p?d_large() definitions

2019-03-26 Thread Christophe Leroy
Le 26/03/2019 à 17:26, Steven Price a écrit : walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For

Re: [PATCH v7 2/4] perf/smmuv3: Add arm64 smmuv3 pmu driver

2019-03-26 Thread Robin Murphy
Hi Shameer, On 26/03/2019 15:17, Shameer Kolothum wrote: [...] +static int smmu_pmu_apply_event_filter(struct smmu_pmu *smmu_pmu, + struct perf_event *event, int idx) +{ + u32 span, sid; + unsigned int num_ctrs = smmu_pmu->num_counters; +

[PATCH] HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630

2019-03-26 Thread Jeffrey Hugo
Similar to commit edfc3722cfef ("HID: quirks: Fix keyboard + touchpad on Toshiba Click Mini not working"), the Lenovo Miix 630 has a combo keyboard/touchpad device with vid:pid of 04F3:0400, which is shared with Elan touchpads. The combo on the Miix 630 has an ACPI id of QTEC0001, which is not

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:44 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > > wrote: > > > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > > On Tue, Mar 26,

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:42:59AM -0700, Andy Lutomirski wrote: > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > > On Tue, Mar

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:38:31AM -0700, Daniel Colascione wrote: > On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner > wrote: > > > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > > On Tue, Mar

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Andy Lutomirski
On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > > Thanks for the

[patch 2/2] x86/smp: Enforce CONFIG_HOTPLUG_CPU when SMP=y

2019-03-26 Thread Thomas Gleixner
The SMT disable 'nosmt' command line argument is not working properly when CONFIG_HOTPLUG_CPU is disabled. The teardown of the sibling CPUs which are required to be brought up due to the MCE issues, cannot work. The CPUs are then kept in a half dead state. As the 'nosmt' functionality has become

[patch 1/2] cpu/hotplug: Prevent crash when CPU bringup fails on CONFIG_HOTPLUG_CPU=n

2019-03-26 Thread Thomas Gleixner
Tianyu reported a crash in a CPU hotplug teardown callback when booting a kernel which has CONFIG_HOTPLUG_CPU disabled with the 'nosmt' boot parameter. It turns out that the SMP=y CONFIG_HOTPLUG_CPU=n case has been broken forever in case that a bringup callback fails. Unfortunately this issue was

[patch 0/2] cpu/hotplug: Prevent damage with SMP=y and HOTPLUG_CPU=n

2019-03-26 Thread Thomas Gleixner
Tianyu reported a crash with SMP=y and HOTPLUG_CPU=n plus 'nosmt' on the kernel command line. https://lkml.kernel.org/r/1553521883-20868-1-git-send-email-tianyu@microsoft.com The reason is a bug in the hotplug code which does not handle the fact, that HOTPLUG_CPU=n cannot tear down a CPU

Re: [PATCH 4.14 00/41] 4.14.109-stable review

2019-03-26 Thread Naresh Kamboju
On Tue, 26 Mar 2019 at 12:04, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.109 release. > There are 41 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:34 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > > Thanks for the

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
On Tue, Mar 26, 2019 at 9:23 AM Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > Thanks for the patch. > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > > wrote: > > > > > > The pidctl() syscalls builds on, extends, and improves

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 05:31:42PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > > Thanks for the patch. > > > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner

Re: [RFC PATCH v2 1/3] resource: Request IO port regions from children of ioport_resource

2019-03-26 Thread John Garry
On 25/03/2019 23:32, Bjorn Helgaas wrote: Hi John, Hi Bjorn, Thanks for reviewing this. On Thu, Mar 21, 2019 at 02:14:08AM +0800, John Garry wrote: Currently when we request an IO port region, the request is made directly to the top resource, ioport_resource. Let's be explicit here,

Re: [PATCH v3] kmemleaak: survive in a low-memory situation

2019-03-26 Thread Michal Hocko
On Tue 26-03-19 16:20:41, Catalin Marinas wrote: > On Tue, Mar 26, 2019 at 09:05:36AM -0700, Matthew Wilcox wrote: > > On Tue, Mar 26, 2019 at 11:43:38AM -0400, Qian Cai wrote: > > > Unless there is a brave soul to reimplement the kmemleak to embed it's > > > metadata into the tracked memory

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 05:23:37PM +0100, Christian Brauner wrote: > On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > > Thanks for the patch. > > > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > > wrote: > > > > > > The pidctl() syscalls builds on, extends, and

Re: linux-next: Fixes tag needs some work in the btrfs-kdave tree

2019-03-26 Thread David Sterba
On Tue, Mar 26, 2019 at 07:09:24AM +1100, Stephen Rothwell wrote: > Hi all, > > In commit > > 167ab7e5ebbf ("btrfs: reloc: Fix NULL pointer dereference due to expanded > reloc_root lifespan") > > Fixes tag > > Fixes: d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after >

Re: [PATCH -next] x86/apic: Reduce print level of CPU limit announcement

2019-03-26 Thread Rafael J. Wysocki
On Tue, Mar 26, 2019 at 4:32 PM Leon Romanovsky wrote: > > On Tue, Mar 26, 2019 at 04:12:27PM +0100, Rafael J. Wysocki wrote: > > On Tue, Mar 26, 2019 at 3:41 PM Leon Romanovsky wrote: > > > > > > On Tue, Mar 26, 2019 at 01:29:54PM +0100, Rafael J. Wysocki wrote: > > > > On Tue, Mar 26, 2019 at

Re: [PATCH v3] kmemleaak: survive in a low-memory situation

2019-03-26 Thread Qian Cai
On 3/26/19 12:00 PM, Christopher Lameter wrote: >> + */ >> +gfp = (in_atomic() || irqs_disabled()) ? GFP_ATOMIC : >> + gfp_kmemleak_mask(gfp) | __GFP_DIRECT_RECLAIM; >> +object = kmem_cache_alloc(object_cache, gfp); >> +} >> + >> if

Re: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS

2019-03-26 Thread Jonathan Neuschäfer
Hi, thanks for your comments. I'll address them in v2. On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote: > On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote: > > The Kobo Aura is an e-book reader released in 2013. [...] > > + sd2_pwrseq: pwrseq { > > +

[PATCH v6 14/19] x86: mm: Don't display pages which aren't present in debugfs

2019-03-26 Thread Steven Price
For the /sys/kernel/debug/page_tables/ files, rather than outputing a mostly empty line when a block of memory isn't present just skip the line. This keeps the output shorter and will help with a future change switching to using the generic page walk code as we no longer care about the 'level'

[PATCH v6 19/19] x86: mm: Convert dump_pagetables to use walk_page_range

2019-03-26 Thread Steven Price
Make use of the new functionality in walk_page_range to remove the arch page walking code and use the generic code to walk the page tables. The effective permissions are passed down the chain using new fields in struct pg_state. The KASAN optimisation is implemented by including test_p?d

[PATCH v6 15/19] x86: mm: Point to struct seq_file from struct pg_state

2019-03-26 Thread Steven Price
mm/dump_pagetables.c passes both struct seq_file and struct pg_state down the chain of walk_*_level() functions to be passed to note_page(). Instead place the struct seq_file in struct pg_state and access it from struct pg_state (which is private to this file) in note_page(). Signed-off-by:

[PATCH v6 13/19] arm64: mm: Convert mm/dump.c to use walk_page_range()

2019-03-26 Thread Steven Price
Now walk_page_range() can walk kernel page tables, we can switch the arm64 ptdump code over to using it, simplifying the code. Signed-off-by: Steven Price --- arch/arm64/mm/dump.c | 117 ++- 1 file changed, 59 insertions(+), 58 deletions(-) diff --git

[PATCH v6 16/19] x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct

2019-03-26 Thread Steven Price
To enable x86 to use the generic walk_page_range() function, the callers of ptdump_walk_pgd_level() need to pass an mm_struct rather than the raw pgd_t pointer. Luckily since commit 7e904a91bf60 ("efi: Use efi_mm in x86 as well as ARM") we now have an mm_struct for EFI on x86. Signed-off-by:

[PATCH v6 18/19] x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct

2019-03-26 Thread Steven Price
An mm_struct is needed to enable x86 to use of the generic walk_page_range() function. In the case of walking the user page tables (when CONFIG_PAGE_TABLE_ISOLATION is enabled), it is necessary to create a fake_mm structure because there isn't an mm_struct with a pointer to the pgd of the user

[PATCH v6 17/19] x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct

2019-03-26 Thread Steven Price
To enable x86 to use the generic walk_page_range() function, the callers of ptdump_walk_pgd_level_debugfs() need to pass in the mm_struct. This means that ptdump_walk_pgd_level_core() is now always passed a valid pgd, so drop the support for pgd==NULL. Signed-off-by: Steven Price ---

[PATCH v6 11/19] mm: pagewalk: Allow walking without vma

2019-03-26 Thread Steven Price
Since 48684a65b4e3: "mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)", page_table_walk() will report any kernel area as a hole, because it lacks a vma. This means each arch has re-implemented page table walking when needed, for example in the per-arch ptdump walker. Remove

[PATCH v6 10/19] mm: pagewalk: Add p4d_entry() and pgd_entry()

2019-03-26 Thread Steven Price
pgd_entry() and pud_entry() were removed by commit 0b1fbfe50006c410 ("mm/pagewalk: remove pgd_entry() and pud_entry()") because there were no users. We're about to add users so reintroduce them, along with p4d_entry() as we now have 5 levels of tables. Note that commit a00cc7d9dd93d66a ("mm, x86:

[PATCH v6 12/19] mm: pagewalk: Add test_p?d callbacks

2019-03-26 Thread Steven Price
It is useful to be able to skip parts of the page table tree even when walking without VMAs. Add test_p?d callbacks similar to test_walk but which are called just before a table at that level is walked. If the callback returns non-zero then the entire table is skipped. Signed-off-by: Steven Price

[PATCH v6 09/19] mm: Add generic p?d_large() macros

2019-03-26 Thread Steven Price
Exposing the pud/pgd levels of the page tables to walk_page_range() means we may come across the exotic large mappings that come with large areas of contiguous memory (such as the kernel's linear map). For architectures that don't provide p?d_large() macros, provide generic does nothing defaults.

[PATCH v6 08/19] x86: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For x86 we already have static inline functions, so

[PATCH v6 07/19] sparc: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For sparc 64 bit, pmd_large() and pud_large() are already

[PATCH v6 06/19] s390: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For s390, pud_large() and pmd_large() are already

[PATCH v6 05/19] riscv: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For riscv a page is large when it has a read, write or

[PATCH v6 03/19] mips: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information is provided by the p?d_large() functions/macros. For mips, we only support large pages on 64 bit. For 64

[PATCH v6 02/19] arm64: mm: Add p?d_large() definitions

2019-03-26 Thread Steven Price
walk_page_range() is going to be allowed to walk page tables other than those of user space. For this it needs to know when it has reached a 'leaf' entry in the page tables. This information will be provided by the p?d_large() functions/macros. For arm64, we already have p?d_sect() macros which

[PATCH v6 00/19] Convert x86 & arm64 to use generic page walk

2019-03-26 Thread Steven Price
Most architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for walking the page tables because the generic walk_page_range() function is unable to walk the page tables used by the kernel. This series extends the

Re: Bad file pattern in MAINTAINERS section 'KEYS-TRUSTED'

2019-03-26 Thread James Bottomley
On Tue, 2019-03-26 at 09:59 -0500, Denis Kenzior wrote: > Hi James, > > On 03/26/2019 09:25 AM, James Bottomley wrote: > > Looking at the contents of linux/keys/trusted.h, it looks like the > > wrong decision to move it. The contents are way too improperly > > named > > and duplicative to be in

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
On Tue, Mar 26, 2019 at 09:17:07AM -0700, Daniel Colascione wrote: > Thanks for the patch. > > On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner > wrote: > > > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has

Re: [PATCH v3] kmemleaak: survive in a low-memory situation

2019-03-26 Thread Catalin Marinas
On Tue, Mar 26, 2019 at 09:05:36AM -0700, Matthew Wilcox wrote: > On Tue, Mar 26, 2019 at 11:43:38AM -0400, Qian Cai wrote: > > Unless there is a brave soul to reimplement the kmemleak to embed it's > > metadata into the tracked memory itself in a foreseeable future, this > > provides a good

Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs

2019-03-26 Thread Thomas Gleixner
On Tue, 26 Mar 2019, Steven Rostedt wrote: > On Tue, 26 Mar 2019 17:09:44 +0100 (CET) > Thomas Gleixner wrote: > > > > > 1) The third argument of get/set(), i.e. the argument offset, is 0 on > > > > all > > > > call sites. Do we need it at all? > > > > > > Probably "maxargs" can be

Re: [PATCH v1 2/4] pid: add pidctl()

2019-03-26 Thread Daniel Colascione
Thanks for the patch. On Tue, Mar 26, 2019 at 8:55 AM Christian Brauner wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is

Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs

2019-03-26 Thread Steven Rostedt
On Tue, 26 Mar 2019 17:09:44 +0100 (CET) Thomas Gleixner wrote: > > > 1) The third argument of get/set(), i.e. the argument offset, is 0 on all > > > call sites. Do we need it at all? > > > > Probably "maxargs" can be removed too, Steven sent the patches a long ago, > > see > >

Re: BUG: KASAN: stack-out-of-bounds in unwind_next_frame (*Reproducible*)

2019-03-26 Thread Thomas Gleixner
Alex, On Mon, 25 Mar 2019, 573149609 wrote: Thanks for the report. > I think I found a reproducible kernel bug in version 5.0.4. > Source file: arch/x86/kernel/unwind_orc.c:505 > The KASAN output is as following: > [ 26.095365] BUG: KASAN: stack-out-of-bounds in >

Re: [PATCH 2/4] pid: add pidctl()

2019-03-26 Thread Christian Brauner
> Agreed, I also was going to say the same, about the flags. Please review the updated version I just sent out. Christian

[PATCH V4 22/23] perf, tools: Add documentation for topdown metrics

2019-03-26 Thread kan . liang
From: Andi Kleen Add some documentation how to use the topdown metrics in ring 3. Signed-off-by: Andi Kleen Signed-off-by: Kan Liang --- No changes since V3. tools/perf/Documentation/topdown.txt | 223 +++ 1 file changed, 223 insertions(+) create mode 100644

Re: [PATCH v2 2/8] kbuild: Support for Symbols.list creation

2019-03-26 Thread Joe Lawrence
On 3/26/19 10:40 AM, Joao Moreira wrote: On 3/20/19 4:08 PM, Miroslav Benes wrote: diff --git a/scripts/Makefile.build b/scripts/Makefile.build index fd03d60f6c5a..1e28ad21314c 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -247,6 +247,11 @@ cmd_gen_ksymdeps = \

Re: [PATCH v2] x86/realmode: don't leak kernel addresses

2019-03-26 Thread Borislav Petkov
On Sun, Mar 24, 2019 at 08:05:04PM +0100, Matteo Croce wrote: > Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), > at boot "ptrval" is printed instead of the trampoline addresses: > > Base memory trampoline at [(ptrval)] 99000 size 24576 > > Remove

[PATCH V4 02/23] perf/x86/intel: Extract memory code PEBS parser for reuse

2019-03-26 Thread kan . liang
From: Andi Kleen Extract some code related to memory profiling from the PEBS record parser into separate functions. It can be reused by the upcoming adaptive PEBS parser. No functional changes. Rename intel_hsw_weight to intel_get_tsx_weight, and intel_hsw_transaction to

[PATCH V4 03/23] perf/x86/intel/ds: Extract code of event update in short period

2019-03-26 Thread kan . liang
From: Kan Liang The drain_pebs() could be called twice in a short period for auto-reload event in pmu::read(). The intel_pmu_save_and_restart_reload() should be called to update the event->count. This case should also be handled on Icelake. Extract the codes for reuse later. Signed-off-by: Kan

[PATCH V4 04/23] perf/x86/intel: Support adaptive PEBSv4

2019-03-26 Thread kan . liang
From: Kan Liang Adaptive PEBS is a new way to report PEBS sampling information. Instead of a fixed size record for all PEBS events it allows to configure the PEBS record to only include the information needed. Events can then opt in to use such an extended record, or stay with a basic record

[PATCH V4 06/23] perf/x86: Support constraint ranges

2019-03-26 Thread kan . liang
From: Peter Zijlstra Icelake extended the general counters to 8, even when SMT is enabled. However only a (large) subset of the events can be used on all 8 counters. The events that can or cannot be used on all counters are organized in ranges. A lot of scheduler constraints are required to

[PATCH V4 10/23] perf/x86/msr: Add Icelake support

2019-03-26 Thread kan . liang
From: Kan Liang Icelake is the same as the existing Skylake parts. Signed-off-by: Kan Liang --- No changes since V3. arch/x86/events/msr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/events/msr.c b/arch/x86/events/msr.c index a878e6286e4a..f3f4c2263501 100644 ---

[PATCH V4 07/23] perf/x86/intel: Add Icelake support

2019-03-26 Thread kan . liang
From: Kan Liang Add Icelake core PMU perf code, including constraint tables and the main enable code. Icelake expanded the generic counters to always 8 even with HT on, but a range of events cannot be scheduled on the extra 4 counters. Add new constraint ranges to describe this to the

[PATCH V4 15/23] perf/x86/intel: Support hardware TopDown metrics

2019-03-26 Thread kan . liang
From: Kan Liang Intro = Icelake has support for measuring the four top level TopDown metrics directly in hardware. This is implemented by an additional "metrics" register, and a new Fixed Counter 3 that measures pipeline "slots". Events == We export four metric events as separate perf

<    1   2   3   4   5   6   7   8   9   10   >