Re: [PATCH v10 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-08 Thread Andrew Jeffery
On Tue, 9 Apr 2019, at 00:12, Patrick Venture wrote: > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > Signed-off-by: Patrick Venture > Reviewed-by: Rob Herring Reviewed-by: Andrew Jeffery > --- > Changes for v10: > - Chopped out nearly identical information.

Re: [PATCH 03/22] watchdog: aspeed_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Andrew Jeffery
On Tue, 9 Apr 2019, at 05:09, Guenter Roeck wrote: > Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatedly. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used t

[PATCH v6] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-08 Thread Nick Crews
The EC is in charge of controlling the keyboard backlight on the Wilco platform. We expose a standard LED class device at /sys/class/leds/chromeos::kbd_backlight. This driver is modeled after the standard Chrome OS keyboard backlight driver at drivers/platform/chrome/cros_kbd_led_backlight.c Some

Re: [PATCH] adfs: mark expected switch fall-throughs

2019-04-08 Thread Kees Cook
On Mon, Jan 14, 2019 at 12:35 PM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplic

Re: [PATCH] afs: Mark expected switch fall-throughs

2019-04-08 Thread Kees Cook
On Thu, Jan 10, 2019 at 2:02 PM Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in many cases I placed a /* Fall through */ comment > at the bottom of the case, which what GCC is expecting t

Re: [PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels

2019-04-08 Thread Robert Foss
Hey Fabio, On 4/8/19 10:37 PM, Fabio Estevam wrote: Hi Robert, [Adding Gary] On Mon, Apr 8, 2019 at 2:54 PM Robert Foss wrote: If a LVDS device is not connected, having the LVDS channels enabled will prevent imx-ldb from probing correctly even if other CRTCs are connected. Signed-off-by: R

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-08 Thread Nick Crews
I've just found a few [embarrassing :)] bugs in this version, so after we figure out the naming, please wait for me to send out another patch that fixes these. Thanks, Nick On Thu, Apr 4, 2019 at 11:10 AM Nick Crews wrote: > > We want all backlights for the system keyboard to > use a common name

[PATCH 14/18] iommu/vt-d: Add nested translation support

2019-04-08 Thread Jacob Pan
Nested translation mode is supported in VT-d 3.0 Spec.CH 3.8. With PASID granular translation type set to 0x11b, translation result from the first level(FL) also subject to a second level(SL) page table translation. This mode is used for SVA virtualization, where FL performs guest virtual to guest

[PATCH 07/18] iommu: Introduce attach/detach_pasid_table API

2019-04-08 Thread Jacob Pan
In virtualization use case, when a guest is assigned a PCI host device, protected by a virtual IOMMU on the guest, the physical IOMMU must be programmed to be consistent with the guest mappings. If the physical IOMMU supports two translation stages it makes sense to program guest mappings onto the

Re: linux-next: Fixes tags need some work in the cifs tree

2019-04-08 Thread Stephen Rothwell
Hi Steve, On Mon, 8 Apr 2019 17:30:20 -0500 Steve French wrote: > > I just fixed these up manually and repushed to cifs-2.6.git for-next Thanks. > I was curious if checkpatch should have flagged this - I reran > checkpatch on the original version of Zhang's patches and it didn't > complain abou

Re: linux-next: manual merge of the kspp-gustavo tree with Linus' tree

2019-04-08 Thread Gustavo A. R. Silva
On 4/7/19 4:17 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the kspp-gustavo tree got a conflict in: > > arch/x86/include/asm/syscall.h > > between commits: > > b35f549df1d7 ("syscalls: Remove start and number from > syscall_get_arguments() args") > 32d9258662

Re: [PATCH] slab: fix a crash by reading /proc/slab_allocators

2019-04-08 Thread Tobin C. Harding
On Sun, Apr 07, 2019 at 07:35:34PM -1000, Linus Torvalds wrote: > On Sat, Apr 6, 2019 at 12:59 PM Qian Cai wrote: > > > > The commit 510ded33e075 ("slab: implement slab_root_caches list") > > changes the name of the list node within "struct kmem_cache" from > > "list" to "root_caches_node", but le

RE: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Ghannam, Yazen
> -Original Message- > From: linux-edac-ow...@vger.kernel.org On > Behalf Of Luck, Tony > Sent: Monday, April 8, 2019 6:23 PM > To: Ghannam, Yazen > Cc: Borislav Petkov ; linux-e...@vger.kernel.org; > linux-kernel@vger.kernel.org; x...@kernel.org > Subject: Re: [PATCH RESEND 4/5] x86/MC

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Luck, Tony
On Mon, Apr 08, 2019 at 10:48:34PM +, Ghannam, Yazen wrote: > Okay, so drop the export and leave the injector code as-is (it's > already doing a rdmsrl_on_cpu()). It's still a globally visible symbol (shared by core.c and amd.c). So I think it needs a "mce_" prefix. While it doesn't collide n

Re: [PATCH v4 1/3] mm/vmap: keep track of free blocks for vmap allocation

2019-04-08 Thread Roman Gushchin
On Sat, Apr 06, 2019 at 08:35:06PM +0200, Uladzislau Rezki (Sony) wrote: > Currently an allocation of the new vmap area is done over busy > list iteration(complexity O(n)) until a suitable hole is found > between two busy areas. Therefore each new allocation causes > the list being grown. Due to ov

Re: linux-next: build warning after merge of the sound-asoc tree

2019-04-08 Thread Stephen Rothwell
Hi all, On Tue, 26 Mar 2019 10:01:45 +1100 Stephen Rothwell wrote: > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > sound/soc/codecs/tlv320aic32x4-clk.c: In function > 'clk_aic32x4_pll_recalc_rate': > sound/soc/codecs/tlv320aic3

[GIT PULL] TPM fixes for v5.1

2019-04-08 Thread James Morris
Please pull these TPM fixes, from Jarkko: "These are critical fixes for v5.1. Contains also couple of new selftests for v5.1 features (partial reads in /dev/tpm0)." --- The following changes since commit fd008d1a7a204695f0e5e003af16448bb9c34b7b: Merge branch 'linus' of git://git.kernel.org/

Re: [PATCH v3] PCI: al: Add Amazon Annapurna Labs PCIe host controller driver

2019-04-08 Thread Benjamin Herrenschmidt
On Thu, 2019-03-28 at 13:57 +0200, Jonathan Chocron wrote: > Add support for Amazon's Annapurna Labs PCIe driver. The HW > controller > is based on DesignWare's IP. > > The HW doesn't support accessing the Root Port's config space via > ECAM, > so we obtain its base address via an AMZN0001 device.

Re: [PATCH v1 bitops] bitops: Fix UBSAN undefined behavior warning for rotation right

2019-04-08 Thread Andrew Morton
(resend, cc Andrey) On Sun, 7 Apr 2019 12:53:25 + Vadim Pasternak wrote: > The warning is caused by call to rorXX(), if the second parameters of > this function "shift" is zero. In such case UBSAN reports the warning > for the next expression: (word << (XX - shift), where XX is > 64, 32, 16

Re: [PATCH v1 bitops] bitops: Fix UBSAN undefined behavior warning for rotation right

2019-04-08 Thread Andrew Morton
On Sun, 7 Apr 2019 12:53:25 + Vadim Pasternak wrote: > The warning is caused by call to rorXX(), if the second parameters of > this function "shift" is zero. In such case UBSAN reports the warning > for the next expression: (word << (XX - shift), where XX is > 64, 32, 16, 8 for respectively

Re: [PATCH V5 00/12] perf: Add Icelake support (kernel only, except Topdown)

2019-04-08 Thread Liang, Kan
On 4/8/2019 12:06 PM, Liang, Kan wrote: @@ -1875,7 +1868,7 @@ static void intel_pmu_drain_pebs_nhm(str   counts[bit]++;   } -    for (bit = 0; bit < size; bit++) { +    for_each_set_bit(bit, (unsigned long *)&mask, size) {   if ((counts[bit] == 0) && (error[bit] == 0))

RE: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Ghannam, Yazen
> -Original Message- > From: linux-edac-ow...@vger.kernel.org On > Behalf Of Borislav Petkov > Sent: Monday, April 8, 2019 3:50 PM > To: Luck, Tony > Cc: Ghannam, Yazen ; linux-e...@vger.kernel.org; > linux-kernel@vger.kernel.org; x...@kernel.org > Subject: Re: [PATCH RESEND 4/5] x86/MC

Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm QCS404 DT bindings

2019-04-08 Thread Bjorn Andersson
On Fri 05 Apr 08:46 PDT 2019, Georgi Djakov wrote: > Hi Bjorn, > > On 4/5/19 21:32, Bjorn Andersson wrote: > > On Fri 05 Apr 10:54 +07 2019, Georgi Djakov wrote: > > > >> The Qualcomm QCS404 platform has several buses that could be controlled > >> and tuned according to the bandwidth demand. > >

Re: [PATCH] spi: rockchip: Revert "set min/max speed"

2019-04-08 Thread Vicente Bergas
On Sunday, April 7, 2019 2:57:59 AM CEST, Vicente Bergas wrote: This reverts commit 420b82f84294 ("spi: rockchip: set min/max speed") commit 74b7efa82b11 ("spi: rockchip: precompute rx sample delay") The former breaks bursts of writes of 48 bytes or more. Both patches touch the same part of the f

Re: [PATCH 07/12] s390: cio: fix cio_irb declaration

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:20PM +0200, Arnd Bergmann wrote: > clang points out that the declaration of cio_irb does not match the > definition exactly, it is missing the alignment attribute: > > ../drivers/s390/cio/cio.c:50:1: warning: section does not match previous > declaration [-Wsection]

Re: [PATCH 06/12] s390: ctcm: fix ctcm_new_device error return code

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:19PM +0200, Arnd Bergmann wrote: > clang points out that the return code from this function is > undefined for one of the error paths: > > ../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used > uninitialized whenever 'if' condition is true >

Re: [PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:18PM +0200, Arnd Bergmann wrote: > The 'func_code' variable gets printed in debug statements without > a prior initialization in multiple functions, as reported when building > with clang: > > drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is us

Re: linux-next: Fixes tags need some work in the cifs tree

2019-04-08 Thread Steve French
I just fixed these up manually and repushed to cifs-2.6.git for-next I was curious if checkpatch should have flagged this - I reran checkpatch on the original version of Zhang's patches and it didn't complain about the spacing (and probably should have). On Mon, Apr 8, 2019 at 4:38 PM Stephen Rot

Re: [PATCH v3 1/7] clkdev: Hold clocks_mutex while iterating clocks list

2019-04-08 Thread Russell King - ARM Linux admin
On Mon, Apr 08, 2019 at 10:00:02AM -0700, Stephen Boyd wrote: > Quoting Matti Vaittinen (2019-04-08 03:49:41) > > On Fri, Apr 05, 2019 at 01:37:24PM -0700, Stephen Boyd wrote: > > > Quoting Vaittinen, Matti (2019-04-04 23:51:43) > > > > On Thu, 2019-04-04 at 14:53 -0700, Stephen Boyd wrote: > > > >

Re: [PATCH 04/12] s390: qeth: address type mismatch warning

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:17PM +0200, Arnd Bergmann wrote: > clang produces a harmless warning for each use for the qeth_adp_supported > macro: > > drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from > enumeration type 'enum qeth_ipa_setadp_cmd' to > different enum

Re: [PATCH] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread Roman Gushchin
Ooops... wrong subject. Please, ignore. Thanks!

[PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread Roman Gushchin
Dan reported, that cleanup path in test_memcg_subtree_control() triggers a static checker warning: ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ test_memcg_subtree_control() error: uninitialized symbol 'child2'. Fix this by initializing child2 and parent2 variables and split the cl

[PATCH 2/2] kernel: use sysctl shared variables for range check

2019-04-08 Thread Matteo Croce
Use the shared variables for range check, instead of declaring a local one in every source file. Signed-off-by: Matteo Croce --- kernel/pid_namespace.c | 3 +- kernel/sysctl.c| 193 - kernel/ucount.c| 6 +- 3 files changed, 98 insertion

[PATCH 1/2] proc/sysctl: add shared variables for range check

2019-04-08 Thread Matteo Croce
In the sysctl code the proc_dointvec_minmax() function is often used to validate the user supplied value between an allowed range. This function uses the extra1 and extra2 members from struct ctl_table as minimum and maximum allowed value. On sysctl handler declaration, in every source file there

[PATCH 0/2] sysctl: share commonly used constants

2019-04-08 Thread Matteo Croce
In the sysctl code there are a lot of duplicate constants used to validate the user input, which could be put in a shared place. Some of them are not even constant, fix this with the following patches. The first one declares the shared constants, the second one makes use of them for the kernel/ sys

Re: 4/8/201912:57:28 PM

2019-04-08 Thread China National Chemicals
Dear linux-kernel@vger.kernel.org Greetings to you from China. Our company is currentlylooking for a sales representative in the USA. You could become our principal sales agent and earn big. It wouldn't disturb your present job, you could work from home as well. No upfront deposit. It is 100% l

Re: [PATCH 03/12] s390: purgatory: pass --target option to clang

2019-04-08 Thread Nathan Chancellor
On Mon, Apr 08, 2019 at 11:26:16PM +0200, Arnd Bergmann wrote: > The purgatory Makefile does not inherit the original cflags, > so clang falls back to the default target architecture when > building it, typically this would be x86 when cross-compiling. > > Pass --target=s390x-linux to all compiler

Re: [PATCH net-next v3] net: dsa: mv88e6xxx: Prevent suspend to RAM

2019-04-08 Thread Pavel Machek
On Tue 2019-02-05 12:07:28, Miquel Raynal wrote: > On one hand, the mv88e6xxx driver has a work queue called in loop > which will attempt register accesses after MDIO bus suspension, that > entirely freezes the platform during suspend. > > On the other hand, the DSA core is not ready yet to suppor

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Alexander Duyck
On Mon, Apr 8, 2019 at 2:21 PM David Hildenbrand wrote: > > On 08.04.19 22:51, David Hildenbrand wrote: > > On 08.04.19 22:10, Alexander Duyck wrote: > >> On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: > >>> > >> > >> In addition we will need some way to identify which pages hav

Re: [PATCH v10 02/18] counter: Documentation: Add Generic Counter sysfs documentation

2019-04-08 Thread Pavel Machek
On Tue 2019-04-02 15:30:37, William Breathitt Gray wrote: > This patch adds standard documentation for the userspace sysfs > attributes of the Generic Counter interface. > > Reviewed-by: Jonathan Cameron > Signed-off-by: William Breathitt Gray > --- > Documentation/ABI/testing/sysfs-bus-counter

Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread Roman Gushchin
On Mon, Apr 08, 2019 at 12:53:39PM -0600, shuah wrote: > On 3/27/19 8:56 PM, Roman Gushchin wrote: > > Dan reported, that cleanup path in test_memcg_subtree_control() > > triggers a static checker warning: > >./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ > >test_memcg_subtree_cont

[PATCH 3/7] cgroup: introduce cgroup_parse_percentage

2019-04-08 Thread Song Liu
This patch introduces a helper to parse percentage string to long integer, with user selected scale: long cgroup_parse_percentage(char *tok, unsigned long base) Valid tok could be integer 0 to 100, decimal 0.00 to 100.00, or "max". A tok of "max"is same as "100". Base is the desire output sca

Re: [PATCH v3 3/7] clk: Add of_clk_hw_register() API for early clk drivers

2019-04-08 Thread Jeffrey Hugo
On 4/4/2019 3:53 PM, Stephen Boyd wrote: In some circumstances drivers register clks early and don't have access to a struct device because the device model isn't initialized yet. Add an API to let drivers register clks associated with a struct device_node so that these drivers can participate in

[PATCH 5/7] sched/fair: global idleness counter for cpu.headroom

2019-04-08 Thread Song Liu
This patch introduces a global idleness counter in fair.c for the cpu.headroom knob. This counter is based on per cpu get_idle_time(). The counter is used via function call: unsigned long cfs_global_idleness_update(u64 now, u64 period); The function returns global idleness in fixed-point perce

[PATCH 7/7] Documentation: cgroup-v2: add information for cpu.headroom

2019-04-08 Thread Song Liu
This patch adds simple explanation of the new cpu.headroom knob. Signed-off-by: Song Liu --- Documentation/admin-guide/cgroup-v2.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst index 20

[PATCH 6/7] sched/fair: throttle task runtime based on cpu.headroom

2019-04-08 Thread Song Liu
This patch enables task runtime throttling based on cpu.headroom setting. The throttling leverages the same mechanism of the cpu.max knob. Task groups with non-zero target_idle get throttled. In __refill_cfs_bandwidth_runtime(), global idleness measured by function cfs_global_idleness_update() is

[PATCH 4/7] sched, cgroup: add entry cpu.headroom

2019-04-08 Thread Song Liu
This patch introduces a new cgroup cpu controller knob: cpu.headroom. cpu.headroom is a mechanism for latency sensitive applications (or the main workkload) to enforce latency requirements by reserving cpu cycle headroom. Only the latency sensitive application can use the cpu cycle headroom. cpu c

[PATCH 2/7] cgroup: introduce hook css_has_tasks_changed

2019-04-08 Thread Song Liu
This patch introduces a new hook css_has_tasks_changed: void (*css_has_tasks_changed)(struct cgroup_subsys_state *css, bool has_tasks); The hook is called when the cgroup gets its first task and when the cgroup loses its last task. It is called under css_set_lo

Re: [PATCH 1/4] kernel-doc: Revert "scripts/kernel-doc: Processing -nofunc for functions only"

2019-04-08 Thread Jonathan Corbet
On Fri, 5 Apr 2019 14:44:50 -0700 Sean Christopherson wrote: > Now that Docbook has been deprecated in favor of Sphinx, the -nofunction > option in kernel-doc is defunct, e.g. Sphinx doesn't currently support > it. Furthermore, "functions only" behavior was used by Docproc to avoid > duplicatin

[PATCH 1/7] sched: refactor tg_set_cfs_bandwidth()

2019-04-08 Thread Song Liu
This patch factors tg_switch_cfs_runtime() out of tg_set_cfs_bandwidth(), so that next patches can extend tg_switch_cfs_runtime() to support the new target_idle_pct value. This patch doesn't have any functionality changes. Signed-off-by: Song Liu --- kernel/sched/core.c | 71 +++

Re: [PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-04-08 Thread Carlos O'Donell
On 4/8/19 3:20 PM, Tulio Magno Quites Machado Filho wrote: Carlos O'Donell writes: On 4/5/19 5:16 AM, Florian Weimer wrote: * Carlos O'Donell: It is valuable that it be a trap, particularly for constant pools because it means that a jump into the constant pool will trap. Sorry, I don't und

[PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-08 Thread Song Liu
Servers running latency sensitive workload usually aren't fully loaded for various reasons including disaster readiness. The machines running our interactive workloads (referred as main workload) have a lot of spare CPU cycles that we would like to use for optimistic side jobs like video encodi

[PATCH] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread Roman Gushchin
Dan reported, that cleanup path in test_memcg_subtree_control() triggers a static checker warning: ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ test_memcg_subtree_control() error: uninitialized symbol 'child2'. Fix this by initializing child2 and parent2 variables and split the cl

linux-next: Fixes tag needs some work in the nfsd tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit 3c86794ac0e6 ("nfsd/nfsd3_proc_readdir: fix buffer count and page pointers") Fixes tag Fixes: f875a79 "nfsd: allow nfsv3 readdir request to be larger" has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more)

[PATCH 09/14] media: ov6650: Fix incorrect use of JPEG colorspace

2019-04-08 Thread Janusz Krzysztofik
Since its initial submission, the driver selects V4L2_COLORSPACE_JPEG for supported formats other than V4L2_MBUS_FMT_SBGGR8_1X8. According to v4l2-compliance test program, V4L2_COLORSPACE_JPEG applies exclusively to V4L2_PIX_FMT_JPEG. Since the sensor does not support JPEG format, fix it to alway

[PATCH 12/14] media: ov6650: Fix default format not applied on device probe

2019-04-08 Thread Janusz Krzysztofik
It is not clear what pixel format is actually configured in hardware on reset. MEDIA_BUS_FMT_YUYV8_2X8, assumed on device probe since the driver was intiially submitted, is for sure not the one. Fix it by explicitly applying a known, driver default frame format just after initial device reset. F

linux-next: Fixes tags need some work in the cifs tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit 7d672725ba72 ("cifs: Fix lease buffer length error") Fixes tags Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later)) Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list) has these problem(s): - missing space between the SHA

[PATCH 09/12] s390: make __load_psw_mask work with clang

2019-04-08 Thread Arnd Bergmann
clang fails to use the %O and %R inline assembly modifiers the same way as gcc, leading to build failures with every use of __load_psw_mask(): /tmp/nmi-4a9f80.s: Assembler messages: /tmp/nmi-4a9f80.s:571: Error: junk at end of line: `+8(160(%r11))' /tmp/nmi-4a9f80.s:626: Error: junk at end of line

[PATCH 12/12] [PROBABLY WRONG] s390: void '0' constraint in inline assembly

2019-04-08 Thread Arnd Bergmann
clang does not understand the contraint "0" in the CALL_ON_STACK() macro: ../arch/s390/mm/maccess.c:117:10: error: invalid input constraint '0' in asm return CALL_ON_STACK(_memcpy_real, S390_lowcore.nodat_stack, ^ ../arch/s390/include/asm/processor.h:292:20:

[PATCH 10/12] s390: avoid __builtin_return_address(n) on clang

2019-04-08 Thread Arnd Bergmann
llvm on s390 has problems with __builtin_return_address(n), with n>0, this results in a somewhat cryptic error message: fatal error: error in backend: Unsupported stack frame traversal count To work around it, use the direct return address directly. This is probably not ideal here, but gets thing

[PATCH 11/12] s390: make chkbss work with clang

2019-04-08 Thread Arnd Bergmann
llvm skips an empty .bss section entirely, which makes the check fail with an unexpected error: /tmp/binutils-multi-test/bin/s390x-linux-gnu-objdump: section '.bss' mentioned in a -j option, but not found in any input file error: arch/s390/boot/compressed/decompressor.o .bss section is not empty

[PATCH 06/12] s390: ctcm: fix ctcm_new_device error return code

2019-04-08 Thread Arnd Bergmann
clang points out that the return code from this function is undefined for one of the error paths: ../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (priv->channel[direction]

[PATCH 07/12] s390: cio: fix cio_irb declaration

2019-04-08 Thread Arnd Bergmann
clang points out that the declaration of cio_irb does not match the definition exactly, it is missing the alignment attribute: ../drivers/s390/cio/cio.c:50:1: warning: section does not match previous declaration [-Wsection] DEFINE_PER_CPU_ALIGNED(struct irb, cio_irb); ^ ../include/linux/percpu-de

[PATCH 08/12] s390: syscall_wrapper: avoid clang warning

2019-04-08 Thread Arnd Bergmann
Building system calls with clang results in a warning about an alias from a global function to a static one: ../fs/namei.c:3847:1: warning: unused function '__se_sys_mkdirat' [-Wunused-function] SYSCALL_DEFINE3(mkdirat, int, dfd, const char __user *, pathname, umode_t, mode) ^ ../include/linux/sy

[PATCH 04/12] s390: qeth: address type mismatch warning

2019-04-08 Thread Arnd Bergmann
clang produces a harmless warning for each use for the qeth_adp_supported macro: drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from enumeration type 'enum qeth_ipa_setadp_cmd' to different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion] if (qeth_adp

[PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Arnd Bergmann
The 'func_code' variable gets printed in debug statements without a prior initialization in multiple functions, as reported when building with clang: drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is used uninitialized whenever 'if' condition is true [-Wsometimes-unin

Re: Removing pcap? (EZX support in mainline linux)

2019-04-08 Thread Antonio Ospite
On Mon, 08 Apr 2019 21:14:44 +0200 Robert Jarzmik wrote: > Arnd Bergmann writes: > > > On Mon, Apr 8, 2019 at 8:58 AM Antonio Ospite wrote: > >> On Sun, 7 Apr 2019 16:07:41 +0200 > >> Alexandre Belloni wrote: > >> adding Robert to CC as he is listed as the current maintainer of > >> ARM/EZX S

[PATCH 03/12] s390: purgatory: pass --target option to clang

2019-04-08 Thread Arnd Bergmann
The purgatory Makefile does not inherit the original cflags, so clang falls back to the default target architecture when building it, typically this would be x86 when cross-compiling. Pass --target=s390x-linux to all compilers that understand this option. Signed-off-by: Arnd Bergmann --- arch/s

[PATCH 02/12] s390: don't build vdso32 with clang

2019-04-08 Thread Arnd Bergmann
clang does not support 31 bit object files on s390, so skip the 32-bit vdso here, and only build it when using gcc to compile the kernel. Signed-off-by: Arnd Bergmann --- arch/s390/Kconfig | 3 +++ arch/s390/kernel/Makefile | 2 +- arch/s390/kernel/vdso.c | 10 +- 3 files cha

linux-next: Fixes tags need some work in the sound-asoc tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit b4ed6b51f356 ("ASoC: core: conditionally increase module refcount on component open") Fixes tag Fixes: b450b878('ASoC: core: don't increase component module refcount has these problem(s): - missing space between the SHA1 and the subject - SHA1 should be at least 12

[PATCH 01/12] s390: remove -fno-strength-reduce flag

2019-04-08 Thread Arnd Bergmann
This was added as a workaround for really old compilers, and it prevents building with clang now. I can see no reason for keeping it, as it has already been removed for most architectures in the pre-git era, so let's remove it everywhere, rather than only for clang. Signed-off-by: Arnd Bergmann -

Re: [PATCH] x86/boot: This program cannot be run in DOS mode.$

2019-04-08 Thread Pavel Machek
On Mon 2019-04-08 20:08:09, Pali Rohár wrote: > On Monday 08 April 2019 20:04:22 Pavel Machek wrote: > > On Mon 2019-04-01 12:24:34, Pali Rohár wrote: > > > Every EFI binary is in PE format. And we know that PE format needs to have > > > MZ MS-DOS header as there is written offset to PE header. > >

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:51, David Hildenbrand wrote: > On 08.04.19 22:10, Alexander Duyck wrote: >> On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >>> >> >> In addition we will need some way to identify which pages have been >> hinted on and which have not. The way I believe easiest t

Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node

2019-04-08 Thread Clément Péron
On Mon, 8 Apr 2019 at 10:16, Maxime Ripard wrote: > > On Sun, Apr 07, 2019 at 04:27:36PM +0200, Clément Péron wrote: > > Hi, > > > > On Fri, 5 Apr 2019 at 18:24, Clément Péron wrote: > > > > > > Hi, > > > > > > On Fri, 5 Apr 2019 at 17:08, Maxime Ripard > > > wrote: > > > > > > > > On Fri, Apr

[PATCH v4] platform/chrome: mfd/cros_ec_debugfs: Add debugfs entry to retrieve EC uptime.

2019-04-08 Thread Tim Wawrzynczak
The new debugfs entry 'uptime' is being made available to userspace so that a userspace daemon can synchronize EC logs with host time. Signed-off-by: Tim Wawrzynczak --- Enric, AFAIK only the cros_ec supports the 'uptime' command for now. And yes, the file does need to be seekable; the userspace

[PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

2019-04-08 Thread Stefan Agner
The LLVM Target parser currently does not allow to specify the security extension as part of -march (see also LLVM Bug 40186 [0]). When trying to use Clang with LLVM's integrated assembler, this leads to build errors such as this: clang-8: error: the clang compiler does not support '-Wa,-march=ar

[PATCH v2 2/3] ARM: mvebu: drop unnecessary label

2019-04-08 Thread Stefan Agner
The label mvebu_boot_wa_start is not necessary and causes a build issue when building with LLVM's integrated assembler: AS arch/arm/mach-mvebu/pmsu_ll.o arch/arm/mach-mvebu/pmsu_ll.S:59:1: error: invalid symbol redefinition mvebu_boot_wa_start: ^ Drop the label. Signed-off-by: Stef

[PATCH v2 3/3] ARM: mvebu: prefix coprocessor operand with p

2019-04-08 Thread Stefan Agner
In every other instance where mrc is used the coprocessor operand is prefix with p (e.g. p15). Use the p prefix in this case too. This fixes a build issue when using LLVM's integrated assembler: arch/arm/mach-mvebu/coherency_ll.S:69:6: error: invalid operand for instruction mrc 15, 0, r3, cr0

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:10, Alexander Duyck wrote: > On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >> > > In addition we will need some way to identify which pages have been > hinted on and which have not. The way I believe easiest to do this > would be to overload the PageType v

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 08:42:36PM +, Luck, Tony wrote: > > Actually, it should not be exported at all. A function returning the num > > banks is better instead. > > Are all the places it is used in non-pre-emptible sections of code? Looping > in the CMCI and #MC handlers should be fine. But d

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:10, Alexander Duyck wrote: > On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >> > > In addition we will need some way to identify which pages have been > hinted on and which have not. The way I believe easiest to do this > would be to overload the PageType v

Re: [PATCH 15/24] dt-bindings: pinctrl: pinctrl-mt65xx: add support for MT8516

2019-04-08 Thread Linus Walleij
On Sat, Mar 23, 2019 at 10:17 PM Fabien Parent wrote: > Add binding documentation of pinctrl-mt65xx for MT8516 SoC. > > Signed-off-by: Fabien Parent Patch applied with Rob's ACK. Yours, Linus Walleij

RE: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Luck, Tony
> Actually, it should not be exported at all. A function returning the num > banks is better instead. Are all the places it is used in non-pre-emptible sections of code? Looping in the CMCI and #MC handlers should be fine. But do we need get_cpu()/put_cpu() in any places? -Tony

Re: [PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels

2019-04-08 Thread Fabio Estevam
Hi Robert, [Adding Gary] On Mon, Apr 8, 2019 at 2:54 PM Robert Foss wrote: > > If a LVDS device is not connected, having the LVDS channels > enabled will prevent imx-ldb from probing correctly even > if other CRTCs are connected. > > Signed-off-by: Robert Foss > --- > arch/arm/boot/dts/imx6qdl

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 01:26:59PM -0700, Luck, Tony wrote: > On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote: > > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); > > The name "num_banks" is a bit generic for an exported symbol. > I think it sh

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Gustavo A. R. Silva
On 4/8/19 3:00 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 08, 2019 at 02:52:52PM -0500, Gustavo A. R. Silva escreveu: >> >> >> On 4/8/19 2:35 PM, Arnaldo Carvalho de Melo wrote: >>> Em Mon, Apr 08, 2019 at 01:26:09PM -0500, Gustavo A. R. Silva escreveu: On 4/8/19 1:22 PM, S

Re: linux-next: manual merge of the audit tree with Linus' tree

2019-04-08 Thread Paul Moore
On Mon, Apr 8, 2019 at 1:15 PM Dmitry V. Levin wrote: > On Mon, Apr 08, 2019 at 11:31:31AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the audit tree got conflicts in: > > > > arch/mips/kernel/ptrace.c > > kernel/seccomp.c > > > > between commit: > > > > b3

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Alan Tull
On Mon, Apr 8, 2019 at 11:51 AM Moritz Fischer wrote: > > Hi Michal, > > On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: > > On 08. 04. 19 16:17, Alan Tull wrote: > > > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne > > > wrote: > > >> > > >> Hi Alan, > > >> > > >> Thanks for lo

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Luck, Tony
On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote: > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); The name "num_banks" is a bit generic for an exported symbol. I think it should have a "mce_" prefix. -Tony

Re: [PATCH 4.20 105/171] net: stmmac: Send TSO packets always from Queue 0

2019-04-08 Thread Ben Hutchings
On Tue, 2019-03-12 at 10:08 -0700, Greg Kroah-Hartman wrote: > 4.20-stable review patch. If anyone has any objections, please let me know. > > -- > > [ Upstream commit c5acdbee22a1b200dde07effd26fd1f649e9ab8a ] > > The number of TSO enabled channels in HW can be different than t

Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument

2019-04-08 Thread Stefan Agner
On 31.03.2019 19:34, Arnd Bergmann wrote: > On Sun, Mar 24, 2019 at 3:06 AM Arnd Bergmann wrote: >> >> On Sat, Mar 23, 2019 at 4:52 PM Stefan Agner wrote: >> > >> > The LLVM Target parser currently does not allow to specify the security >> > extension as part of -march (see also LLVM Bug 40186 [0

Re: [PATCH v2] soc: fsl: add DPAA2 console support

2019-04-08 Thread Li Yang
On Fri, Apr 5, 2019 at 4:51 AM Ioana Ciornei wrote: > > This patch adds DPAA2 MC and AIOP console log support. > > The platform driver probes on the "fsl,dpaa2-console" device tree node > which describes the base firmware address needed in order to infer the > start address of both firmware logs:

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Alexander Duyck
On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: > > >>> > >>> In addition we will need some way to identify which pages have been > >>> hinted on and which have not. The way I believe easiest to do this > >>> would be to overload the PageType value so that we could essentially > >>> have

[PATCH v2 1/4] soundwire: fix style issues

2019-04-08 Thread Pierre-Louis Bossart
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this. Fi

[PATCH v2 3/4] soundwire: stream: remove useless initialization of local variable

2019-04-08 Thread Pierre-Louis Bossart
no need to reset return value. Detected with cppcheck: [drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2 4/4] soundwire: add missing newlines in dynamic debug logs

2019-04-08 Thread Pierre-Louis Bossart
For some reason the newlines are not used everywhere. Fix as needed. Reported-by: Joe Perches Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/bus.c| 74 +-- drivers/soundwire/cadence_master.c | 12 ++-- drivers/soundwire/intel.c | 12 ++-- drive

[PATCH v2 2/4] soundwire: bus: remove useless initializations

2019-04-08 Thread Pierre-Louis Bossart
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwi

[PATCH v2 0/4] soundwire: code cleanup

2019-04-08 Thread Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Changes since v1: added missing

Re: [PATCH 19/27] x86/fpu: Update xstate's PKRU value on write_pkru()

2019-04-08 Thread Sebastian Andrzej Siewior
On 2019-04-08 11:14:28 [-0700], Dave Hansen wrote: > On 4/3/19 9:41 AM, Sebastian Andrzej Siewior wrote: > > During the context switch the xstate is loaded which also includes the > > PKRU value. > > If xstate is restored on return to userland it is required that the > > PKRU value in xstate is the

Re: [GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-08 Thread Dan Murphy
Tony On 4/8/19 2:30 PM, Tony Lindgren wrote: * Dan Murphy [190408 15:54]: On 4/7/19 5:17 PM, Pavel Machek wrote: Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, not from the device tree. We can always add runtime override control to the driver. Yeah that sounds good t

<    1   2   3   4   5   6   7   8   >