Re: [PATCH V4 06/16] PCI: dwc: Add ext config space capability search API

2019-04-23 Thread Bjorn Helgaas
On Tue, Apr 23, 2019 at 01:57:20PM +0530, Vidya Sagar wrote: > Add extended configuration space capability search API using struct dw_pcie * > pointer > > Signed-off-by: Vidya Sagar > Acked-by: Gustavo Pimentel > --- > Changes from [v3]: > * None > > Changes from [v2]: > * None > > Changes

Re: [PATCH] KEYS: Make use of platform keyring for module signature verify

2019-04-23 Thread James Morris
On Tue, 23 Apr 2019, Robert Holmes wrote: > This patch completes commit 278311e417be ("kexec, KEYS: Make use of > platform keyring for signature verify") which, while adding the > platform keyring for bzImage verification, neglected to also add > this keyring for module verification. > You

Re: [PATCH V4 05/16] PCI: dwc: Move config space capability search API

2019-04-23 Thread Bjorn Helgaas
On Tue, Apr 23, 2019 at 01:57:19PM +0530, Vidya Sagar wrote: > Move PCIe config space capability search API to common DesignWare file > as this can be used by both host and ep mode codes. > > Signed-off-by: Vidya Sagar > Acked-by: Gustavo Pimentel > --- > Changes from [v3]: > * Rebased to

[PATCH] sh: require --Wl,--hash-style=sysv

2019-04-23 Thread Nick Desaulniers
Towards the goal of removing cc-ldoption, prefer ld-option, or better yet, require --Wl,--hash-style=sysv since the selftest for vdso's requires DT_HASH. Cc: Andy Lutomirsky Cc: clang-built-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers ---

Re: [REGRESSION 5.0.x] Windows XP broken on KVM

2019-04-23 Thread Takashi Iwai
On Thu, 18 Apr 2019 10:05:34 +0200, Takashi Iwai wrote: > > On Thu, 18 Apr 2019 09:53:28 +0200, > Greg Kroah-Hartman wrote: > > > > On Thu, Apr 18, 2019 at 09:38:52AM +0200, Takashi Iwai wrote: > > > Hi, > > > > > > we've got a regression report on the recent 5.0.x kernel, starting > > > from

Re: [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 01:16:37PM -0700, Paul E. McKenney wrote: > Agreed, but I thought that one of the ideas going forward was to get > rid of smp_mb__{before,after}_atomic(). It's not one I had considered.. I just wanted to get rid of this 'surprise' behaviour.

Re: [PATCH] bpf: Fix preempt_enable_no_resched() abuse

2019-04-23 Thread Linus Torvalds
On Tue, Apr 23, 2019 at 12:56 PM Peter Zijlstra wrote: > > Unless the very next line is schedule(), or implies it, one must not use > preempt_enable_no_resched(). It can cause a preemption to go missing and > thereby cause arbitrary delays, breaking the PREEMPT=y invariant. That language may be

Re: [PATCH RESEND v5 0/5] namei: vfs flags to restrict path resolution

2019-04-23 Thread Christian Brauner
On Tue, Apr 23, 2019 at 01:13:52PM -0700, Kees Cook wrote: > On Mon, Mar 25, 2019 at 6:05 AM Aleksa Sarai wrote: > > > > On 2019-03-21, Andy Lutomirski wrote: > > > On Wed, Mar 20, 2019 at 7:38 AM Aleksa Sarai wrote: > > > > Now that the holiday break is over, it's time to re-send this patch >

Re: [REGRESSION 5.0.x] Windows XP broken on KVM

2019-04-23 Thread Greg Kroah-Hartman
On Thu, Apr 18, 2019 at 09:56:02AM +0200, Paolo Bonzini wrote: > On 18/04/19 09:38, Takashi Iwai wrote: > > Hi, > > > > we've got a regression report on the recent 5.0.x kernel, starting > > from 5.0.6, where Windows XP can't boot on KVM any longer. > > > > The culprit seems to be the patch > >

Re: [PATCH RESEND v5 0/5] namei: vfs flags to restrict path resolution

2019-04-23 Thread Kees Cook
On Mon, Mar 25, 2019 at 6:05 AM Aleksa Sarai wrote: > > On 2019-03-21, Andy Lutomirski wrote: > > On Wed, Mar 20, 2019 at 7:38 AM Aleksa Sarai wrote: > > > Now that the holiday break is over, it's time to re-send this patch > > > series (with a few additions, due to new information we got from

Re: [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()

2019-04-23 Thread Paul E. McKenney
On Tue, Apr 23, 2019 at 03:40:03PM +0200, Peter Zijlstra wrote: > On Tue, Apr 23, 2019 at 06:30:10AM -0700, Paul E. McKenney wrote: > > There are a great many that look like this: > > > > smp_mb__before_atomic(); > > clear_bit(NFSD4_CLIENT_UPCALL_LOCK, >cl_flags); > >

Re: [PATCH v3 1/4] ARM: use arch_extension directive instead of arch argument

2019-04-23 Thread Stefan Agner
On 11.04.2019 09:54, Stefan Agner wrote: > The LLVM Target parser currently does not allow to specify the security > extension as part of -march (see also LLVM Bug 40186 [0]). When trying > to use Clang with LLVM's integrated assembler, this leads to build > errors such as this: > clang-8:

Re: kernel BUG at kernel/cred.c:434!

2019-04-23 Thread Paul Moore
On Tue, Apr 23, 2019 at 12:08 AM Yang Yingliang wrote: > On 2019/4/23 3:48, Paul Moore wrote: > > On Sat, Apr 20, 2019 at 3:39 AM Yang Yingliang > > wrote: > >> I'm not sure you got my point. > > I went back and looked at your previous emails again to try and > > understand what you are talking

Re: [RFC 2/6] objtool: arm64: Add required implementation for supporting the aarch64 architecture in objtool.

2019-04-23 Thread Josh Poimboeuf
On Tue, Apr 09, 2019 at 02:52:39PM +0100, Raphael Gault wrote: > Provide implementation for the arch-dependent functions that are called by > the main check > function of objtool. > The ORC unwinder is not yet supported by the arm64 architecture so we only > provide a dummy > interface for now.

Re: [PATCH] Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()

2019-04-23 Thread Paul E. McKenney
On Tue, Apr 23, 2019 at 03:26:20PM +0200, Peter Zijlstra wrote: > On Tue, Apr 23, 2019 at 06:21:16AM -0700, Paul E. McKenney wrote: > > On Tue, Apr 23, 2019 at 02:17:15PM +0200, Peter Zijlstra wrote: > > > On Sat, Apr 20, 2019 at 01:54:40AM -0700, Paul E. McKenney wrote: > > > > 3. Make

Re: [RFC 1/6] objtool: Refactor code to make it more suitable for multiple architecture support

2019-04-23 Thread Josh Poimboeuf
On Tue, Apr 09, 2019 at 02:52:38PM +0100, Raphael Gault wrote: > The jump destination and relocation offset used previously are only reliable > on x86_64 architecture. We abstract these computations by calling > arch-dependant "dependent" > implementation. > > The control flow information and

Re: [RFC PATCH v1 3/3] selftests/x86: Augment SGX selftest to test new __vdso_sgx_enter_enclave() and its callback interface

2019-04-23 Thread Sean Christopherson
On Tue, Apr 23, 2019 at 12:07:26PM -0700, Andy Lutomirski wrote: > On Tue, Apr 23, 2019 at 11:59 AM Sean Christopherson > wrote: > > > > On Mon, Apr 22, 2019 at 06:29:06PM -0700, Andy Lutomirski wrote: > > > What's not tested here is running this code with EFLAGS.TF set and > > > making sure that

[GIT PULL] nfsd bugfixes for 5.1

2019-04-23 Thread J. Bruce Fields
Please pull nfsd bugfixes from: git://linux-nfs.org/~bfields/linux.git tags/nfsd-5.1-1 Fix miscellaneous nfsd bugs, in NFSv4.1 callbacks, NFSv4.1 lock-notification callbacks, NFSv3 readdir encoding, and the cache/upcall code. --b. Jeff Layton (2): nfsd: wake waiters blocked on

Re: [RFC] Bluetooth: Retry configure request if result is L2CAP_CONF_UNKNOWN

2019-04-23 Thread Marcel Holtmann
Hi Andrey, > Due to: > > - current implementation of l2cap_config_rsp() dropping BT > connection if sender of configuration response replied with unknown > option failure (Result=0x0003/L2CAP_CONF_UNKNOWN) > > - current implementation of l2cap_build_conf_req() adding >

[PATCH v2] iio: adc: ad7766: Change alignment to match paranthesis

2019-04-23 Thread Camylla Gonçalves Cantanheide
This commit align broken line to match upper line parenthesis, in lines 80, 130, 237, 242, 255, 264 and 293. Solves the checkpatch.pl's message: CHECK: Alignment should match open parenthesis In lines 130, 255, 264 and 293 it was necessary to break a line. Signed-off-by: Camylla Gonçalves

[PATCH] trace: Fix preempt_enable_no_resched() abuse

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 09:55:59PM +0200, Peter Zijlstra wrote: > On Tue, Apr 23, 2019 at 03:41:32PM -0400, Waiman Long wrote: > > I saw a number of instances of > > preempt_enable_no_resched() without right next a schedule(). > > Look more closely.. and let me know, if true, those are bugs that

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-23 Thread Robert R. Howell
On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > > On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: >> >> On 4/18/19 5:42 AM, Hans de Goede wrote: >> On 4/8/19 2:16 AM, Hans de Goede wrote:> > > Hmm, interesting so you have hibernation working on a T100TA > (with 5.0 +

Re: [PATCH v2] platform: uv: fix missing checks for kcalloc

2019-04-23 Thread Kees Cook
On Mon, Mar 25, 2019 at 1:29 PM Kangjie Lu wrote: > > In case kcalloc fails, the patch return an error to avoid > potential NULL pointer dereference. > > Signed-off-by: Kangjie Lu Reviewed-by: Kees Cook -Kees > > --- > v2: reuse existing error path as suggested by > Borislav Petkov > --- >

[PATCH] Wqiio: adc: ad7766: Change alignment to match paranthesis

2019-04-23 Thread Camylla Gonçalves Cantanheide
This commit align broken line to match upper line parenthesis, in lines 80, 130, 237, 242, 255, 264 and 293. Solves the checkpatch.pl's message: CHECK: Alignment should match open parenthesis In lines 130, 255, 264 and 293 it was necessary to break a line. Signed-off-by: Camylla Gonçalves

[PATCH] MAINTAINERS: LEDs: Add designated reviewer for LED subsystem

2019-04-23 Thread Dan Murphy
Add a designated reviewer for the LED subsystem as there are already two maintainers assigned. Signed-off-by: Dan Murphy --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3671fdea5010..ee0b10484194 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH] fs/proc/proc_sysctl.c: Fix a NULL pointer dereference

2019-04-23 Thread Kees Cook
On Mon, Apr 22, 2019 at 7:54 PM YueHaibing wrote: > > Friendly ping... > > On 2019/4/9 23:36, Yue Haibing wrote: > > From: YueHaibing > > > > Syzkaller report this: > > > > sysctl could not get directory: /net//bridge -12 > > kasan: CONFIG_KASAN_INLINE enabled > > kasan: GPF could be caused by

[PATCH] bpf: Fix preempt_enable_no_resched() abuse

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 03:41:32PM -0400, Waiman Long wrote: > On 4/23/19 3:34 PM, Peter Zijlstra wrote: > > On Tue, Apr 23, 2019 at 03:12:16PM -0400, Waiman Long wrote: > >> You are right on that. However, there is a variant called > >> preempt_enable_no_resched() that doesn't have this side

[PATCH v3 2/3] security: Move stackleak config to Kconfig.hardening

2019-04-23 Thread Kees Cook
This moves the stackleak plugin options to Kconfig.hardening's memory initialization menu. Signed-off-by: Kees Cook --- scripts/gcc-plugins/Kconfig | 51 - security/Kconfig.hardening | 57 + 2 files changed, 57 insertions(+),

[PATCH v3 3/3] security: Implement Clang's stack initialization

2019-04-23 Thread Kees Cook
CONFIG_INIT_STACK_ALL turns on stack initialization based on -ftrivial-auto-var-init in Clang builds, which has greater coverage than CONFIG_GCC_PLUGINS_STRUCTLEAK_BYREF_ALL. -ftrivial-auto-var-init Clang option provides trivial initializers for uninitialized local variables, variable fields and

[PATCH v3 1/3] security: Create "kernel hardening" config area

2019-04-23 Thread Kees Cook
Right now kernel hardening options are scattered around various Kconfig files. This can be a central place to collect these kinds of options going forward. This is initially populated with the memory initialization options from the gcc-plugins. Signed-off-by: Kees Cook ---

[PATCH v3 0/3] Refactor memory initialization hardening

2019-04-23 Thread Kees Cook
This refactors the stack memory initialization configs in order to keep things together when adding Clang stack initialization, and in preparation for future heap memory initialization configs. I intend to carry this in the gcc-plugins tree, but I'd really like to get Acks from Masahiro (Kconfig

Re: [musl] Re: [PATCH] binfmt_elf: Update READ_IMPLIES_EXEC logic for modern CPUs

2019-04-23 Thread Rich Felker
On Tue, Apr 23, 2019 at 09:02:03PM +0200, Jann Horn wrote: > +linux-api, +musl > > On Tue, Apr 23, 2019 at 8:12 PM Kees Cook wrote: > > The READ_IMPLIES_EXEC work-around was designed for old CPUs lacking NX > > (to have the visible permission flags on memory regions reflect reality: > > they are

Re: [PATCH][v2] drivers: hv: Add a module description line to the hv_vmbus driver

2019-04-23 Thread Sasha Levin
On Tue, Apr 23, 2019 at 04:39:57PM +, Michael Kelley wrote: From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM This patch only adds a MODULE_DESCRIPTION statement to the driver. This change is only cosmetic, so there should be no runtime impact. Signed-off-by: Joseph Salisbury

Re: [PATCH][v2] drivers: input: serio: Add a module desription to the hyperv_keyboard driver

2019-04-23 Thread Sasha Levin
On Tue, Apr 23, 2019 at 04:39:00PM +, Michael Kelley wrote: From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM This patch only adds a MODULE_DESCRIPTION statement to the driver. This change is only cosmetic, so there should be no runtime impact. Signed-off-by: Joseph Salisbury

Re: [PATCH][v2] drivers: hid: Add a module description line to the hid_hyperv driver

2019-04-23 Thread Sasha Levin
On Tue, Apr 23, 2019 at 04:38:05PM +, Michael Kelley wrote: From: Joseph Salisbury Sent: Monday, April 22, 2019 8:47 PM This patch only adds a MODULE_DESCRIPTION statement to the driver. This change is only cosmetic, so there should be no runtime impact. Signed-off-by: Joseph Salisbury

Re: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-23 Thread Andy Lutomirski
> On Apr 23, 2019, at 12:26 PM, Sean Christopherson > wrote: > >> On Mon, Apr 22, 2019 at 05:37:24PM -0700, Cedric Xing wrote: >> The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, >> which prohibits enclaves from allocating and passing parameters for >> untrusted

Re: [PATCH v2 1/3] security: Create "kernel hardening" config area

2019-04-23 Thread Kees Cook
On Thu, Apr 11, 2019 at 6:39 PM Masahiro Yamada wrote: > > On Fri, Apr 12, 2019 at 3:01 AM Kees Cook wrote: > > > > Right now kernel hardening options are scattered around various Kconfig > > files. This can be a central place to collect these kinds of options > > going forward. This is

Re: [PATCH v4 14/16] locking/rwsem: Guard against making count negative

2019-04-23 Thread Waiman Long
On 4/23/19 3:34 PM, Peter Zijlstra wrote: > On Tue, Apr 23, 2019 at 03:12:16PM -0400, Waiman Long wrote: >> On 4/23/19 12:27 PM, Linus Torvalds wrote: >>> On Tue, Apr 23, 2019 at 7:17 AM Peter Zijlstra wrote: I'm not aware of an architecture where disabling interrupts is faster than

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Marcel Holtmann
Hi Matthias, > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for > ROME controllers instantiated through ldisc, where the call causes a > crash due to a NULL pointer dereferentiation. Only call the

Re: [PATCH 2/2] HID: input: fix assignment of .value

2019-04-23 Thread Sasha Levin
On Tue, Apr 23, 2019 at 11:54:07AM -0600, James Feeney wrote: On 4/23/19 11:21 AM, Sasha Levin wrote: Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 2dc702c991e3 HID: input: use the Resolution Multiplier for high-resolution

Re: [PATCH v4 14/16] locking/rwsem: Guard against making count negative

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 03:12:16PM -0400, Waiman Long wrote: > On 4/23/19 12:27 PM, Linus Torvalds wrote: > > On Tue, Apr 23, 2019 at 7:17 AM Peter Zijlstra wrote: > >> I'm not aware of an architecture where disabling interrupts is faster > >> than disabling preemption. > > I don't thin kit ever

Re: [PATCH] rcu/sync: kill rcu_sync_type/gp_type

2019-04-23 Thread Paul E. McKenney
On Tue, Apr 23, 2019 at 02:07:24PM +0200, Oleg Nesterov wrote: > Now that the RCU flavors were consolidated rcu_sync_type makes no sense, > all internal update functions except .held() doesn't depend on gp_type. > > The patch adds RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held()) into >

Re: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-23 Thread Sean Christopherson
On Mon, Apr 22, 2019 at 05:37:24PM -0700, Cedric Xing wrote: > The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, > which prohibits enclaves from allocating and passing parameters for > untrusted function calls (aka. o-calls). > > This patch addresses the problem above by

[GIT PULL] arch: add pidfd and io_uring syscalls everywhere

2019-04-23 Thread Arnd Bergmann
The following changes since commit 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b: Linux 5.1-rc1 (2019-03-17 14:22:26 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git syscalls-5.1 for you to fetch changes up to

[PATCH] exec: test ->recursion_depth

2019-04-23 Thread Alexey Dobriyan
Test that trivially recursing script onto itself doesn't work. Note: this is different test from ELOOP tests in execveat.c Those test that execveat(2) doesn't follow symlinks when told to do so. Signed-off-by: Alexey Dobriyan --- tools/testing/selftests/exec/.gitignore|3 -

Re: [PATCH v4 9/9] clk: fixed-factor: Let clk framework find parent

2019-04-23 Thread Guenter Roeck
On Tue, Apr 23, 2019 at 11:22:57AM -0700, Stephen Boyd wrote: > Quoting Guenter Roeck (2019-04-23 11:09:22) > > Hi, > > > > On Fri, Apr 12, 2019 at 11:31:50AM -0700, Stephen Boyd wrote: > > > Convert this driver to a more modern way of specifying parents now that > > > we have a way to specify

Re: [PATCH] binfmt_elf: Update READ_IMPLIES_EXEC logic for modern CPUs

2019-04-23 Thread Kees Cook
On Tue, Apr 23, 2019 at 12:02 PM Jann Horn wrote: > It's probably worth going a bit more into detail in this description > on how libraries typically allocate thread stacks. > > It looks like glibc will be fine; before commit 54ee14b3882 >

Re: [PATCHv1 7/7] vfio/mdev: Fix race conditions with mdev device life cycle APIs

2019-04-23 Thread Alex Williamson
On Thu, 4 Apr 2019 23:05:43 + Parav Pandit wrote: > > -Original Message- > > From: Alex Williamson > > Sent: Thursday, April 4, 2019 3:44 PM > > To: Parav Pandit > > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > > kwankh...@nvidia.com; c...@nvidia.com > > Subject: Re:

Re: linux-next: manual merge of the phy-next tree with the qcom tree

2019-04-23 Thread Andy Gross
On Tue, Apr 23, 2019 at 11:13:59AM +0200, Marc Gonzalez wrote: > > I've included "dt-bindings: phy-qcom-qmp: Tweak qcom,msm8998-qmp-ufs-phy" in > > linux-phy tree now. > > Thanks Kishon, > > Great news. That's one less patch to keep track of. Thanks Kishon! Andy

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-23 Thread Andy Gross
On Tue, Apr 23, 2019 at 06:26:40PM +0530, Amit Kucheria wrote: > On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez wrote: > > > > On 02/04/2019 20:46, Amit Kucheria wrote: > > > > > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: > > >> > > >> On 29/03/2019 11:12, Amit Kucheria wrote: > > >> > >

Re: [PATCH v4 14/16] locking/rwsem: Guard against making count negative

2019-04-23 Thread Waiman Long
On 4/23/19 12:27 PM, Linus Torvalds wrote: > On Tue, Apr 23, 2019 at 7:17 AM Peter Zijlstra wrote: >> I'm not aware of an architecture where disabling interrupts is faster >> than disabling preemption. > I don't thin kit ever is, but I'd worry a bit about the > preempt_enable() just because it

Re: [RFC PATCH v1 3/3] selftests/x86: Augment SGX selftest to test new __vdso_sgx_enter_enclave() and its callback interface

2019-04-23 Thread Andy Lutomirski
On Tue, Apr 23, 2019 at 11:59 AM Sean Christopherson wrote: > > On Mon, Apr 22, 2019 at 06:29:06PM -0700, Andy Lutomirski wrote: > > What's not tested here is running this code with EFLAGS.TF set and > > making sure that it unwinds correctly. Also, Jarkko, unless I missed > > something, the vDSO

Re: [PATCH] binfmt_elf: Update READ_IMPLIES_EXEC logic for modern CPUs

2019-04-23 Thread Jann Horn
+linux-api, +musl On Tue, Apr 23, 2019 at 8:12 PM Kees Cook wrote: > The READ_IMPLIES_EXEC work-around was designed for old CPUs lacking NX > (to have the visible permission flags on memory regions reflect reality: > they are all executable), and for old toolchains that lacked the ELF >

Re: [PATCH 2/2] mm/page_alloc: fix never set ALLOC_NOFRAGMENT flag

2019-04-23 Thread Andrew Morton
On Tue, 23 Apr 2019 15:08:06 +0300 Andrey Ryabinin wrote: > Commit 0a79cdad5eb2 ("mm: use alloc_flags to record if kswapd can wake") > removed setting of the ALLOC_NOFRAGMENT flag. Bring it back. What are the runtime effects of this fix?

Re: [RFC PATCH v1 3/3] selftests/x86: Augment SGX selftest to test new __vdso_sgx_enter_enclave() and its callback interface

2019-04-23 Thread Sean Christopherson
On Mon, Apr 22, 2019 at 06:29:06PM -0700, Andy Lutomirski wrote: > What's not tested here is running this code with EFLAGS.TF set and > making sure that it unwinds correctly. Also, Jarkko, unless I missed > something, the vDSO extable code likely has a bug. If you run the > instruction right

Re: mmotm 2019-04-19-14-53 uploaded (objtool)

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 07:39:12PM +0200, Peter Zijlstra wrote: > On Tue, Apr 23, 2019 at 09:07:01AM -0700, Andy Lutomirski wrote: > > > diff --git a/arch/x86/include/asm/uaccess.h > > > b/arch/x86/include/asm/uaccess.h > > > index 22ba683afdc2..c82abd6e4ca3 100644 > > > ---

Re: [rcu:dev.2019.04.16a 38/72] kernel/rcu/tree.c:2408:36: sparse: sparse: incorrect type in initializer (different address spaces)

2019-04-23 Thread Paul E. McKenney
On Tue, Apr 23, 2019 at 06:44:55PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-04-23 09:38:09 [-0700], Paul E. McKenney wrote: > > Ah, thank you! Shall I fold the above patch into your existing one, > > or are you looking to do something else here? > > The problem (that has been reported)

Re: Does vdso_install attempt to re-compile objects under root privilege?

2019-04-23 Thread Andy Lutomirski
On Thu, Apr 18, 2019 at 1:08 AM Masahiro Yamada wrote: > > Hi. > > I have a question about 'vdso_install'. > > > In my understanding, vdso is embedded in the kernel. > In addition, you can run 'make vdso_install' > to install an unstripped version of vdso. > (Mainly, debugging purpose?) > > By

Re: [RFC PATCH v2 00/17] Core scheduling v2

2019-04-23 Thread Vineeth Remanan Pillai
>> - Processes with different tags can still share the core > I may have missed something... Could you explain this statement? > This, to me, is the whole point of the patch series. If it's not > doing this then ... what? What I meant was, the patch needs some more work to be accurate. There

Re: [PATCH] sched: fix a potential divide error

2019-04-23 Thread Peter Zijlstra
On Sat, Apr 20, 2019 at 04:34:16PM +0800, Xie XiuQi wrote: > We meet a divide error on 3.10.0 kernel, the error message is bellow: That is a _realll_ old kernel. I would urge you to upgrade. > [42.287996] divide error: [#1] SMP > sched_clock_cpu may not be consistent bwtwen

Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO

2019-04-23 Thread Arnd Bergmann
On Tue, Apr 23, 2019 at 8:25 PM Kees Cook wrote: > On Tue, Apr 23, 2019 at 11:15 AM Nick Desaulniers > wrote: > > On Tue, Apr 23, 2019 at 7:12 AM Mark Rutland wrote: > > > > > > On Mon, Apr 22, 2019 at 10:44:10AM -0700, Nick Desaulniers wrote: > > > > On Tue, Apr 16, 2019 at 9:03 PM Kees Cook

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex Williamson
On Tue, 23 Apr 2019 12:53:07 -0500 Alex G wrote: > On 4/23/19 12:10 PM, Bjorn Helgaas wrote: > > On Tue, Apr 23, 2019 at 09:33:53AM -0500, Alex G wrote: > >> On 4/22/19 7:33 PM, Alex Williamson wrote: > >>> There is nothing wrong happening here that needs to fill logs. I > >>> thought maybe

[PATCH] x86/build: Move _etext to actual end of .text

2019-04-23 Thread Kees Cook
When building x86 with Clang LTO and CFI, CFI jump regions are automatically added to the end of the .text section late in linking. As a result, the _etext position was being labelled before the appended jump regions, causing confusion about where the boundaries of the executable region actually

Re: [PATCH v4] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-23 Thread Srinivas Pandruvada
+Jiri He is not copied. On Tue, 2019-04-23 at 12:14 +0200, Enric Balletbo i Serra wrote: > > On 17/4/19 12:18, Rushikesh S Kadam wrote: > > This driver implements a slim layer to enable the ChromeOS > > EC kernel stack (cros_ec) to communicate with ChromeOS EC > > firmware running on the Intel

Re: [v2 PATCH] mm: thp: fix false negative of shmem vma's THP eligibility

2019-04-23 Thread Yang Shi
On 4/23/19 10:52 AM, Michal Hocko wrote: On Wed 24-04-19 00:43:01, Yang Shi wrote: The commit 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each vma") introduced THPeligible bit for processes' smaps. But, when checking the eligibility for shmem vma,

Re: [PATCH v2 6/7] mfd: max77620: Support device-tree properly

2019-04-23 Thread Dmitry Osipenko
22.04.2019 22:13, Dmitry Osipenko пишет: > For some unknown reason the driver for Max77620 doesn't wire up the > device-tree support properly and nothing in kernel creates I2C device > for the driver (and never did), moreover device-tree files for NVIDIA > Tegra210/186/194 boards already have

Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO

2019-04-23 Thread Kees Cook
On Tue, Apr 23, 2019 at 11:15 AM Nick Desaulniers wrote: > > On Tue, Apr 23, 2019 at 7:12 AM Mark Rutland wrote: > > > > On Mon, Apr 22, 2019 at 10:44:10AM -0700, Nick Desaulniers wrote: > > > On Tue, Apr 16, 2019 at 9:03 PM Kees Cook wrote: > > > > > > > > On Tue, Apr 16, 2019 at 12:08 PM Mark

Re: [PATCH v2 3/6] clk: meson: g12a: mark fclk_div3 as critical

2019-04-23 Thread Stephen Boyd
Quoting Neil Armstrong (2019-04-23 02:15:00) > On Amlogic Meson G12b platform, the fclk_div3 seems to be necessary for > the system to operate correctly. > > Disabling it cause the entire system to freeze, including peripherals. > > This patch patch marks this clock as critical, fixing boot on

Re: [PATCH v4 9/9] clk: fixed-factor: Let clk framework find parent

2019-04-23 Thread Stephen Boyd
Quoting Guenter Roeck (2019-04-23 11:09:22) > Hi, > > On Fri, Apr 12, 2019 at 11:31:50AM -0700, Stephen Boyd wrote: > > Convert this driver to a more modern way of specifying parents now that > > we have a way to specify clk parents by DT index. This lets us nicely > > avoid a problem where a

Re: [PATCH v2 4/4] s390: fix clang -Wpointer-sign warnigns in boot code

2019-04-23 Thread Nick Desaulniers
On Tue, Apr 23, 2019 at 1:06 AM Arnd Bergmann wrote: > > On Mon, Apr 22, 2019 at 7:52 PM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > @@ -20,7 +20,7 @@ extern __u8 _ebc_tolower[256]; /* EBCDIC -> lowercase */ > > > extern __u8 _ebc_toupper[256]; /* EBCDIC -> uppercase */ > > > > >

[tip:ras/core] x86/MCE: Add an MCE-record filtering function

2019-04-23 Thread tip-bot for Yazen Ghannam
Commit-ID: 45d4b7b9cb88526f6d5bd4c03efab88d75d10e4f Gitweb: https://git.kernel.org/tip/45d4b7b9cb88526f6d5bd4c03efab88d75d10e4f Author: Yazen Ghannam AuthorDate: Mon, 25 Mar 2019 16:34:22 + Committer: Borislav Petkov CommitDate: Tue, 23 Apr 2019 18:04:47 +0200 x86/MCE: Add an

[tip:ras/core] x86/MCE/AMD: Don't report L1 BTB MCA errors on some family 17h models

2019-04-23 Thread tip-bot for Yazen Ghannam
Commit-ID: 71a84402b93e5fbd8f817f40059c137e10171788 Gitweb: https://git.kernel.org/tip/71a84402b93e5fbd8f817f40059c137e10171788 Author: Yazen Ghannam AuthorDate: Mon, 25 Mar 2019 16:34:22 + Committer: Borislav Petkov CommitDate: Tue, 23 Apr 2019 18:16:07 +0200 x86/MCE/AMD: Don't

[PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Matthias Kaehlcke
qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that the HCI is always associated with a serdev device. This isn't true for ROME controllers instantiated through ldisc, where the call causes a crash due to a NULL pointer dereferentiation. Only call the function when we have a

Re: [PATCH 3/3] scripts/gdb: Add $lx_clk_core_lookup function

2019-04-23 Thread Stephen Boyd
Quoting Leonard Crestez (2019-04-23 04:12:49) > On 4/22/2019 11:18 PM, Stephen Boyd wrote: > > Do you need to do the .string() for comparison? Or does it work just as > > well to compare a gdb.Value object to a python string? It would be nice > > if the gdb.Value object could figure out that

Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO

2019-04-23 Thread Nick Desaulniers
On Tue, Apr 23, 2019 at 7:12 AM Mark Rutland wrote: > > On Mon, Apr 22, 2019 at 10:44:10AM -0700, Nick Desaulniers wrote: > > On Tue, Apr 16, 2019 at 9:03 PM Kees Cook wrote: > > > > > > On Tue, Apr 16, 2019 at 12:08 PM Mark Rutland > > > wrote: > > > > > > > > On Mon, Apr 15, 2019 at

Re: [RFC PATCH 1/1] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation

2019-04-23 Thread Nicolai Stange
Hi Steven, many thanks for having a look! Steven Rostedt writes: > I just found this in my Inbox, and this looks to be a legit issue. > > On Thu, 26 Jul 2018 12:40:29 +0200 > Nicolai Stange wrote: > > You still working on this? Yes, this still needs to get fixed somehow, preferably at the

[PATCH] binfmt_elf: Update READ_IMPLIES_EXEC logic for modern CPUs

2019-04-23 Thread Kees Cook
The READ_IMPLIES_EXEC work-around was designed for old CPUs lacking NX (to have the visible permission flags on memory regions reflect reality: they are all executable), and for old toolchains that lacked the ELF PT_GNU_STACK marking (under the assumption than toolchains that couldn't even specify

Re: [PATCH v4 9/9] clk: fixed-factor: Let clk framework find parent

2019-04-23 Thread Guenter Roeck
, max_idle_ns: 0 ns [0.00] Division by zero in kernel. Reverting the crash fixes the problem. Bisect log attached. Guenter --- # bad: [76c938fcaa4b4a5d8f05fa907925d5043834964e] Add linux-next specific files for 20190423 # good: [085b7755808aa11f78ab9377257e1dad2e6fa4bb] Linux 5.1-rc6 g

Re: general protection fault in fanotify_handle_event

2019-04-23 Thread Amir Goldstein
On Tue, Apr 23, 2019 at 7:27 PM Jan Kara wrote: > > On Fri 19-04-19 12:33:02, Amir Goldstein wrote: > > On Thu, Apr 18, 2019 at 8:14 PM syzbot > > wrote: > > > > > > syzbot has bisected this bug to: > > > > > > commit 77115225acc67d9ac4b15f04dd138006b9cd1ef2 > > > Author: Amir Goldstein > > >

Re: [RFC PATCH v2 00/17] Core scheduling v2

2019-04-23 Thread Phil Auld
Hi, On Tue, Apr 23, 2019 at 04:18:05PM + Vineeth Remanan Pillai wrote: > Second iteration of the core-scheduling feature. Thanks for spinning V2 of this. > > This version fixes apparent bugs and performance issues in v1. This > doesn't fully address the issue of core sharing between

Re: [PATCH 2/2] HID: input: fix assignment of .value

2019-04-23 Thread James Feeney
On 4/23/19 11:21 AM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 2dc702c991e3 HID: input: use the Resolution Multiplier for > high-resolution scrolling. > > The bot has tested the following

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex G
On 4/22/19 5:43 PM, Alex Williamson wrote: On systems that don't support any PCIe services other than bandwidth notification, pcie_message_numbers() can return zero vectors, causing the vector reallocation in pcie_port_enable_irq_vec() to retry with zero, which fails, resulting in fallback to

Re: [PATCH v2 31/36] coresight: stm: ACPI support for parsing stimulus base

2019-04-23 Thread Mathieu Poirier
On Mon, Apr 15, 2019 at 05:04:14PM +0100, Suzuki K Poulose wrote: > The stimulus base for STM device must be listed as the second memory > resource, followed by the programming base address as described in > "Section 2.3 Resources" in ACPI for CoreSightTM 1.0 Platform Design > documen (DEN0067).

Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices

2019-04-23 Thread Matthias Kaehlcke
On Tue, Apr 23, 2019 at 07:26:40PM +0200, Marcel Holtmann wrote: > Hi Matthias, > > > qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > > the HCI is always associated with a serdev device. This isn't true for > > ROME controllers instantiated through ldisc, where the call

Re: [PATCH v2] ARM: multi_v7_defconfig: Enable missing drivers for supported Chromebooks

2019-04-23 Thread Heiko Stuebner
Am Donnerstag, 7. März 2019, 16:20:31 CEST schrieb Enric Balletbo i Serra: > Enable following drivers for merged devices: > - Batteries with BQ27XXX chips for Minnie boards. > - Elan eKTH I2C touchscreen for Minnie boards. > - GPIO charger for all Veyron boards. > - Rockchip SARADC driver for all

Re: [PATCH 3/4] ARM: rockchip: fix a leaked reference by adding missing of_node_put

2019-04-23 Thread Heiko Stuebner
Am Dienstag, 5. März 2019, 12:32:56 CEST schrieb Wen Yang: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: >

Re: WARNING: locking bug in split_huge_page_to_list

2019-04-23 Thread Matthew Wilcox
On Tue, Apr 23, 2019 at 09:13:06AM -0700, syzbot wrote: > DEBUG_LOCKS_WARN_ON(class_idx > MAX_LOCKDEP_KEYS) > WARNING: CPU: 0 PID: 1553 at kernel/locking/lockdep.c:3673 > __lock_acquire+0x1887/0x3fb0 kernel/locking/lockdep.c:3673 > down_write+0x38/0x90 kernel/locking/rwsem.c:70 >

RE: [PATCH] tools/power turbostat: Make interval calculation per thread to reduce jitter

2019-04-23 Thread Ghannam, Yazen
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf Of Ghannam, Yazen > Sent: Monday, March 25, 2019 12:33 PM > To: linux...@vger.kernel.org > Cc: Ghannam, Yazen ; linux-kernel@vger.kernel.org; > l...@kernel.org > Subject: [PATCH] tools/power turbostat: Make

Re: [v2 PATCH] mm: thp: fix false negative of shmem vma's THP eligibility

2019-04-23 Thread Michal Hocko
On Wed 24-04-19 00:43:01, Yang Shi wrote: > The commit 7635d9cbe832 ("mm, thp, proc: report THP eligibility for each > vma") introduced THPeligible bit for processes' smaps. But, when checking > the eligibility for shmem vma, __transparent_hugepage_enabled() is > called to override the result from

Re: [PATCH] PCI/LINK: Account for BW notification in vector calculation

2019-04-23 Thread Alex G
On 4/23/19 12:10 PM, Bjorn Helgaas wrote: On Tue, Apr 23, 2019 at 09:33:53AM -0500, Alex G wrote: On 4/22/19 7:33 PM, Alex Williamson wrote: There is nothing wrong happening here that needs to fill logs. I thought maybe if I enabled notification of autonomous bandwidth changes that it might

Re: [PATCH v2 07/15] ARM: rockchip: fix a leaked reference by adding missing of_node_put

2019-04-23 Thread Heiko Stuebner
Hi, sorry that this took so long to look at, but I think it needs a bit of rework, see below: Am Dienstag, 5. März 2019, 12:33:58 CEST schrieb Wen Yang: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last >

Re: [PATCH v2 0/2] ARM errata 814220

2019-04-23 Thread Fabio Estevam
On Wed, Feb 27, 2019 at 1:21 PM Alexandre Torgue wrote: > > > On 2/14/19 9:31 AM, Benjamin Gaignard wrote: > > Implement ARM errata 814220 for Cortex A7. > > > > This patch has been wroten by Jason Liu years ago but never send upstream. > > I have tried to contact the author on multiple email

Re: [PATCH] KVM: x86: Add Intel CPUID.1F cpuid emulation support

2019-04-23 Thread Sean Christopherson
On Tue, Apr 23, 2019 at 11:23:59AM +0800, Like Xu wrote: > On 2019/4/23 2:35, Sean Christopherson wrote: > >> #define F(x) bit(X86_FEATURE_##x) > >> int kvm_update_cpuid(struct kvm_vcpu *vcpu) > >>@@ -426,6 +436,7 @@ static inline int __do_cpuid_ent(struct > >>kvm_cpuid_entry2 *entry, u32

Re: mmotm 2019-04-19-14-53 uploaded (objtool)

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 09:07:01AM -0700, Andy Lutomirski wrote: > > diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h > > index 22ba683afdc2..c82abd6e4ca3 100644 > > --- a/arch/x86/include/asm/uaccess.h > > +++ b/arch/x86/include/asm/uaccess.h > > @@ -427,10 +427,11 @@

Re: [PATCH v2 30/36] coresight: Use platform agnostic names

2019-04-23 Thread Mathieu Poirier
On Mon, Apr 15, 2019 at 05:04:13PM +0100, Suzuki K Poulose wrote: > So far we have reused the name of the "platform" device for > the CoreSight device. But this is not very intuitive when > we move to ACPI. Also, the ACPI device names have ":" in them > (e.g, ARMHC97C:01), which the perf tool

Re: [PATCH v4 00/63] Include linux ACPI/PCI/X86 docs into Sphinx TOC tree

2019-04-23 Thread Bjorn Helgaas
On Tue, Apr 23, 2019 at 06:39:47PM +0200, Rafael J. Wysocki wrote: > On Tue, Apr 23, 2019 at 6:30 PM Changbin Du wrote: > > Hi Corbet and All, > > The kernel now uses Sphinx to generate intelligent and beautiful > > documentation from reStructuredText files. I converted all of the Linux > >

Re: [PATCH 1/1] vfio: Use dev_printk() when possible

2019-04-23 Thread Alex Williamson
On Sat, 30 Mar 2019 09:41:35 -0500 Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Use dev_printk() when possible to make messages consistent with other > device-related messages. > > Signed-off-by: Bjorn Helgaas > --- > drivers/vfio/pci/vfio_pci.c | 26 +++-- >

Re: mmotm 2019-04-19-14-53 uploaded (objtool)

2019-04-23 Thread Peter Zijlstra
On Tue, Apr 23, 2019 at 09:19:50AM -0700, Linus Torvalds wrote: > Ack on that patch. Except I think the uaccess.h part should be a > separate commit: Of course, I'll go write proper patches.

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-04-23 Thread Michael Turquette
Hi Jerome, On Mon, Apr 8, 2019 at 9:38 AM Jerome Brunet wrote: > > On Fri, 2019-04-05 at 13:43 -0700, Stephen Boyd wrote: > > Quoting Michael Turquette (2019-04-05 08:43:40) > > > Hi Jerome, > > > > > > On Fri, Mar 29, 2019 at 3:58 PM Jerome Brunet > > > wrote: > > > > On Fri, 2019-03-29 at

Re: [PATCH v2] Bluetooth: hci_qca: Give enough time to ROME controller to bootup.

2019-04-23 Thread Marcel Holtmann
Hi Balakrishna, > This patch enables enough time to ROME controller to bootup > after we bring the enable pin out of reset. > > Fixes: 05ba533c5c11 ("Bluetooth: hci_qca: Add serdev support"). > Signed-off-by: Balakrishna Godavarthi > Reviewed-by: Rocky Liao > Tested-by: Rocky Liao >

<    1   2   3   4   5   6   7   8   9   >