Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Takashi Iwai
On Tue, 30 Apr 2019 11:29:19 +0200, Liwei Song wrote: > > > > On 04/30/2019 04:53 PM, Takashi Iwai wrote: > > On Tue, 30 Apr 2019 10:32:47 +0200, > > Liwei Song wrote: > >> > >> > >> > >> On 04/30/2019 03:31 PM, Takashi Iwai wrote: > >>> On Tue, 30 Apr 2019 08:10:53 +0200, > >>> Song liwei

[PATCH v8 11/14] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2019-04-30 Thread Lokesh Vutla
Texas Instruments' K3 generation SoCs has an IP Interrupt Aggregator which is an interrupt controller that does the following: - Converts events to interrupts that can be understood by an interrupt router. - Allows for multiplexing of events to interrupts. Configuration of the interrupt

[PATCH v8 04/14] firmware: ti_sci: Add RM mapping table for am654

2019-04-30 Thread Lokesh Vutla
From: Peter Ujfalusi Add the resource mapping table for AM654 SoC as defined in http://downloads.ti.com/tisci/esd/latest/5_soc_doc/am6x/resasg_types.html Introduce a new compatible for AM654 "ti,am654-sci" for using this resource map table. Reviewed-by: Rob Herring Acked-by: Tony Lindgren

[PATCH v8 13/14] irqchip: ti-sci-inta: Add msi domain support

2019-04-30 Thread Lokesh Vutla
Add a msi domain that is child to the INTA domain. Clients uses the INTA msi bus layer to allocate irqs in this msi domain. Signed-off-by: Lokesh Vutla --- Changes sinece v7: -None drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-ti-sci-inta.c | 40 ++-

[PATCH v8 14/14] arm64: arch_k3: Enable interrupt controller drivers

2019-04-30 Thread Lokesh Vutla
Select the TISCI Interrupt Router, Aggregator drivers and all its dependencies for TI's SoCs based on K3 architecture. Suggested-by: Marc Zyngier Signed-off-by: Lokesh Vutla --- Changes since v7: -None arch/arm64/Kconfig.platforms | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v8 07/14] gpio: thunderx: Use the default parent apis for {request,release}_resources

2019-04-30 Thread Lokesh Vutla
thunderx_gpio_irq_{request,release}_resources apis are trying to {request,release} resources on parent interrupt. There are default apis doing the same. Use the default parent apis instead of writing the same code snippet. Cc: linux-g...@vger.kernel.org Cc: Linus Walleij Acked-by: Linus Walleij

[PATCH v8 10/14] dt-bindings: irqchip: Introduce TISCI Interrupt Aggregator bindings

2019-04-30 Thread Lokesh Vutla
Add the DT binding documentation for Interrupt Aggregator driver. Signed-off-by: Lokesh Vutla --- Changes since v7: - None .../interrupt-controller/ti,sci-inta.txt | 66 +++ MAINTAINERS | 1 + 2 files changed, 67 insertions(+) create mode

[PATCH v8 12/14] soc: ti: Add MSI domain bus support for Interrupt Aggregator

2019-04-30 Thread Lokesh Vutla
With the system coprocessor managing the range allocation of the inputs to Interrupt Aggregator, it is difficult to represent the device IRQs from DT. The suggestion is to use MSI in such cases where devices wants to allocate and group interrupts dynamically. Create a MSI domain bus layer that

[PATCH v8 08/14] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-04-30 Thread Lokesh Vutla
Add the DT binding documentation for Interrupt router driver. Signed-off-by: Lokesh Vutla --- Changes since v7: - Changes interrupt cells to 2. .../interrupt-controller/ti,sci-intr.txt | 82 +++ MAINTAINERS | 1 + 2 files changed, 83

[PATCH v8 09/14] irqchip: ti-sci-intr: Add support for Interrupt Router driver

2019-04-30 Thread Lokesh Vutla
Texas Instruments' K3 generation SoCs has an IP Interrupt Router that does allows for redirection of input interrupts to host interrupt controller. Interrupt Router inputs are either from a peripheral or from an Interrupt Aggregator which is another interrupt controller. Configuration of the

[PATCH v8 01/14] firmware: ti_sci: Add support to get TISCI handle using of_phandle

2019-04-30 Thread Lokesh Vutla
From: Grygorii Strashko TISCI has been updated to have support for Resource management(like interrupts etc..). And there can be multiple device instances of a resource type in a SoC. So every driver corresponding to a resource type should get a TISCI handle so that it can make TISCI calls. And

[PATCH v8 05/14] firmware: ti_sci: Add helper apis to manage resources

2019-04-30 Thread Lokesh Vutla
Each resource with in the device can be uniquely identified as defined by TISCI. Since this is generic across the devices, resource allocation also can be made generic instead of each client driver handling the resource. So add helper apis to manage the resource. Signed-off-by: Lokesh Vutla ---

[PATCH v8 06/14] genirq: Introduce irq_chip_{request,release}_resource_parent() apis

2019-04-30 Thread Lokesh Vutla
Introduce irq_chip_{request,release}_resource_parent() apis so that these can be used in hierarchical irqchips. Signed-off-by: Lokesh Vutla --- Changes since v7: -None include/linux/irq.h | 2 ++ kernel/irq/chip.c | 27 +++ 2 files changed, 29 insertions(+) diff

[PATCH v8 00/14] Add support for TISCI Interrupt controller drivers

2019-04-30 Thread Lokesh Vutla
TI AM65x SoC based on K3 architecture introduced support for Events which are message based interrupts with minimal latency. These events are not compatible with regular interrupts and are valid only through an event transport lane. An Interrupt Aggregator(INTA) is introduced to convert these

[PATCH v8 03/14] firmware: ti_sci: Add support for IRQ management

2019-04-30 Thread Lokesh Vutla
TISCI abstracts the handling of IRQ routes where interrupt sources are not directly connected to host interrupt controller. Add support for the set of TISCI commands for requesting and releasing IRQs. Signed-off-by: Lokesh Vutla --- Changes since v7: - Updated to latest system firmware version

[PATCH v8 02/14] firmware: ti_sci: Add support for RM core ops

2019-04-30 Thread Lokesh Vutla
TISCI provides support for getting the resources(IRQ, RING etc..) assigned to a specific device. These resources can be handled by the client and in turn sends TISCI cmd to configure the resources. It is very important that client should keep track on usage of these resources. Add support for

[PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Elaine Zhang
Explicitly use the pinctrl to set/unset the right mode instead of relying on the pinctrl init mode. And it requires setting the tshut polarity before select pinctrl. When the temperature sensor mode is set to 0, it will automatically reset the board via the Clock-Reset-Unit (CRU) if the over

[PATCH v3 2/3] dt-bindings: rockchip-thermal: Support the PX30 SoC compatible

2019-04-30 Thread Elaine Zhang
Add a new compatible for thermal founding on PX30 SoCs. Signed-off-by: Elaine Zhang Acked-by: Daniel Lezcano Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 0/3] thermal: rockchip: fix up thermal driver

2019-04-30 Thread Elaine Zhang
1. add pinctrl control. 2. support PX30 soc change in V3: PATCH V3 1/3: remove panic. PATCH V3 2/3: No change in V3. PATCH V3 2/3: No change in V3 change in V2: PATCH V2 1/3: keep tshut_mode TSHUT_MODE_GPIO; In case of pinctrl get or lookup error, just bail out; No

[PATCH v3 3/3] thermal: rockchip: Support the PX30 SoC in thermal driver

2019-04-30 Thread Elaine Zhang
PX30 SOC has two Temperature Sensors for CPU and GPU. Signed-off-by: Elaine Zhang --- drivers/thermal/rockchip_thermal.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index

Re: [PATCH RFC V2] staging: kpc2000: use int for wait_for_completion_interruptible

2019-04-30 Thread Dan Carpenter
On Sat, Apr 27, 2019 at 11:14:34AM +0200, Nicholas Mc Guire wrote: > weit_for_completion_interruptible returns in (0 on completion and ^ wait_for_completion_interruptible > -ERESTARTSYS on interruption) - so use an int not long for API conformance > and simplify the logic here a bit: need

Re: sysfs attrs for HW ECDSA signature

2019-04-30 Thread Greg Kroah-Hartman
On Tue, Apr 30, 2019 at 11:23:19AM +0200, Marek Behun wrote: > On Tue, 30 Apr 2019 10:27:28 +0200 > Greg Kroah-Hartman wrote: > > > On Mon, Apr 29, 2019 at 11:47:52PM +0200, Marek Behun wrote: > > > Hi Greg and Tejun, > > > > > > is it acceptable for a driver to expose sysfs attr files for

Re: Question about sched_setaffinity()

2019-04-30 Thread Peter Zijlstra
On Sat, Apr 27, 2019 at 11:02:46AM -0700, Paul E. McKenney wrote: > This actually passes rcutorture. But, as Andrea noted, not klitmus. > After some investigation, it turned out that klitmus was creating kthreads > with PF_NO_SETAFFINITY, hence the failures. But that prompted me to > put checks

Re: [PATCH] selftests : netfilter: Wrote a error and exit code for a command which needed veth kernel module.

2019-04-30 Thread Florian Westphal
shuah wrote: > Would you like me to take this patch through ksleftest tree? Please do, this patch is neither in nf nor nf-next and it looks fine to me.

Re: [PATCH] staging: greybus: use proper return type for wait_for_completion_timeout

2019-04-30 Thread Dan Carpenter
On Sat, Apr 27, 2019 at 05:27:25AM +0200, Nicholas Mc Guire wrote: > wait_for_completion_timeout() returns unsigned long (0 on timeout or > remaining jiffies) not int. > Yeah, but it's fine though because 1 / 256 fits into int without a problem. I'm not sure this sort of patch is worth it

Re: [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem

2019-04-30 Thread Kirill Tkhai
On 30.04.2019 12:38, Cyrill Gorcunov wrote: > On Tue, Apr 30, 2019 at 12:09:57PM +0300, Kirill Tkhai wrote: >> >> This looks OK for me. >> >> But speaking about existing code it's a secret for me, why we ignore arg_lock >> in binfmt code, e.g. in load_elf_binary(). > > Well, strictly speaking we

Re: [PATCH RFC] staging: kpc2000: use int for wait_for_completion_interruptible

2019-04-30 Thread Dan Carpenter
On Sat, Apr 27, 2019 at 04:38:45AM +0200, Nicholas Mc Guire wrote: > weit_for_completion_interruptible returns in (0 on completion and > -ERESTARTSYS on interruption) - so use an int not long for API conformance > and simplify the logic here a bit: need not check explicitly for == 0 as > this is

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Arnd Bergmann
On Tue, Apr 30, 2019 at 11:33 AM Nathan Chancellor wrote: > On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > > On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor > > wrote: > > > > > > This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this > > > point, it has not been

[RFC V2 07/11] arm64: dts: mt8183: add dvfsrc related nodes

2019-04-30 Thread Henry Chen
Enable dvfsrc on mt8183 platform. Signed-off-by: Henry Chen --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 665d561..d298013 100644 ---

[RFC V2 02/11] dt-bindings: soc: Add opp table on scpsys bindings

2019-04-30 Thread Henry Chen
Add opp table on scpsys dt-bindings for Mediatek SoC. Signed-off-by: Henry Chen --- .../devicetree/bindings/soc/mediatek/scpsys.txt| 42 ++ 1 file changed, 42 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt

[PATCH RFC V2] Add driver for dvfsrc, support for active state of scpsys

2019-04-30 Thread Henry Chen
The patchsets add support for MediaTek hardware module named DVFSRC (dynamic voltage and frequency scaling resource collector). The DVFSRC is a HW module which is used to collect all the requests from both software and hardware and turn into the decision of minimum operating voltage and minimum

[RFC V2 08/11] dt-bindings: interconnect: add MT8183 interconnect dt-bindings

2019-04-30 Thread Henry Chen
Add interconnect provider dt-bindings for MT8183. Signed-off-by: Henry Chen --- .../bindings/interconnect/mtk,mt8183.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt diff --git

[RFC V2 04/11] arm64: dts: mt8183: add performance state support of scpsys

2019-04-30 Thread Henry Chen
Add support for performance state of scpsys on mt8183 platform. Signed-off-by: Henry Chen --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi

[RFC V2 05/11] soc: mediatek: add header for mediatek SIP interface

2019-04-30 Thread Henry Chen
Add a header to collect SIPs and add one SIP call to initialize power management hardware for the SIP interface defined to access the SPM handling vcore voltage and ddr rate changes on mt8183 (and most likely later socs). Signed-off-by: Henry Chen --- include/soc/mediatek/mtk_sip.h | 17

[RFC V2 09/11] dt-bindings: interconnect: Add header for interconnect node

2019-04-30 Thread Henry Chen
Add header file for mt8183 interconnect node that could be shared between the interconeect provider driver and Device Tree source files. Signed-off-by: Henry Chen --- include/dt-bindings/interconnect/mtk,mt8183.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644

[RFC V2 11/11] arm64: dts: mt8183: Add interconnect provider DT nodes

2019-04-30 Thread Henry Chen
Add DDR EMI provider dictating dram interconnect bus performance found on MT8183-based platforms Signed-off-by: Henry Chen --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi

[RFC V2 01/11] dt-bindings: soc: Add dvfsrc driver bindings

2019-04-30 Thread Henry Chen
Document the binding for enabling dvfsrc on MediaTek SoC. Signed-off-by: Henry Chen --- .../devicetree/bindings/soc/mediatek/dvfsrc.txt| 23 ++ include/dt-bindings/soc/mtk,dvfsrc.h | 14 + 2 files changed, 37 insertions(+) create mode 100644

[RFC V2 10/11] interconnect: mediatek: Add mt8183 interconnect provider driver

2019-04-30 Thread Henry Chen
Introduce Mediatek MT8183 specific provider driver using the interconnect framework. Signed-off-by: Henry Chen --- drivers/interconnect/Kconfig | 1 + drivers/interconnect/Makefile | 1 + drivers/interconnect/mediatek/Kconfig | 13 ++

[RFC V2 03/11] soc: mediatek: add support for the performance state

2019-04-30 Thread Henry Chen
Support power domain performance state, add header file for scp event. Signed-off-by: Henry Chen --- drivers/soc/mediatek/mtk-scpsys.c | 53 +++ drivers/soc/mediatek/mtk-scpsys.h | 22 2 files changed, 75 insertions(+) create mode 100644

[RFC V2 06/11] soc: mediatek: add MT8183 dvfsrc support

2019-04-30 Thread Henry Chen
Add dvfsrc driver for MT8183 Signed-off-by: Henry Chen --- drivers/soc/mediatek/Kconfig | 15 ++ drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mtk-dvfsrc.c | 347 ++ include/soc/mediatek/mtk_dvfsrc.h | 22 +++ 4 files changed, 385

Re: [PATCH v2 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error

2019-04-30 Thread Daniel Lezcano
On 29/04/2019 11:51, elaine.zhang wrote: [ ... ] > pinctrl select to gpio mode when tsadc suspend and shutdown. > > When suspend, tsadc is disabled, the otp_pin should revert to the > default gpio state. > >> >>>     return 0; >>>   } >>> @@ -1383,7 +1413,8 @@ static int __maybe_unused >>>

Re: [RFC PATCH 2/7] x86/sci: add core implementation for system call isolation

2019-04-30 Thread Peter Zijlstra
On Tue, Apr 30, 2019 at 07:03:37AM +0200, Ingo Molnar wrote: > So the question IMHO isn't whether it's "valid C", because we already > have the Linux kernel's own C syntax variant and are enforcing it with > varying degrees of success. I'm not getting into the whole 'safe' fight here; but

Re: [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem

2019-04-30 Thread Cyrill Gorcunov
On Tue, Apr 30, 2019 at 12:09:57PM +0300, Kirill Tkhai wrote: > > This looks OK for me. > > But speaking about existing code it's a secret for me, why we ignore arg_lock > in binfmt code, e.g. in load_elf_binary(). Well, strictly speaking we probably should but you know setup of the @arg_start

Re: [PATCH v7 3/4] s390: ap: implement PAPQ AQIC interception in kernel

2019-04-30 Thread Halil Pasic
On Tue, 30 Apr 2019 10:32:52 +0200 Pierre Morel wrote: > >>> +    aqic_gisa.gisa = gisa->next_alert >> 4; > >> > >> Why gisa->next_alert? Isn't this supposed to get set to gisa origin > >> (without some bits on the left)? s/left/right/ > > > > Someone already asked this question. It must

Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt)

2019-04-30 Thread Rafael J. Wysocki
On Tue, Apr 30, 2019 at 11:00 AM Mika Westerberg wrote: > > +Rafael, Furquan and linux-acpi > > (The original thread is here > https://lore.kernel.org/lkml/s5hy33siofw.wl-ti...@suse.de/T/#u) > > On Tue, Apr 30, 2019 at 10:39:00AM +0200, Michael Hirmke wrote: > > Hi Takashi, > > > > [...] > > >>>

Re: [PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Nathan Chancellor
+ Nick and the list On Tue, Apr 30, 2019 at 04:00:44PM +0700, Phong Tran wrote: > The cell is a pointer to __be32. > with the be32_to_cpu a lot of clang warning show that: > > ./include/linux/of.h:238:37: warning: multiple unsequenced modifications > to 'cell' [-Wunsequenced] > r

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-04-30 Thread Borislav Petkov
On Tue, Apr 30, 2019 at 02:50:58AM -0400, Len Brown wrote: > If one were to make a change here, I'd consider adding the (physical) die_id, > though it is already in sysfs topology as an attribute. From: Documentation/x86/topology.txt "The kernel does not care about the concept of physical

Re: [PATCH] kbuild: Enable -Wsometimes-uninitialized

2019-04-30 Thread Nathan Chancellor
On Tue, Apr 30, 2019 at 09:16:50AM +0200, Arnd Bergmann wrote: > On Tue, Apr 30, 2019 at 3:01 AM Nathan Chancellor > wrote: > > > > This is Clang's version of GCC's -Wmaybe-uninitialized. Up to this > > point, it has not been used because -Wuninitialized has been disabled, > > which also turns

[PATCH 4/4] rtc: pcap: convert to SPDX identifier

2019-04-30 Thread Alexandre Belloni
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcap.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-pcap.c b/drivers/rtc/rtc-pcap.c index d424339f7abb..178bfb1dea21 100644 ---

[PATCH 2/4] rtc: pcap: switch to rtc_time64_to_tm/rtc_tm_to_time64

2019-04-30 Thread Alexandre Belloni
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcap.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcap.c b/drivers/rtc/rtc-pcap.c index

Re: dcache_readdir NULL inode oops

2019-04-30 Thread Jan Glauber
Hi Al, On Fri, Nov 30, 2018 at 04:32:28PM +, Will Deacon wrote: > On Fri, Nov 30, 2018 at 04:08:52PM +, Al Viro wrote: > > On Fri, Nov 30, 2018 at 09:16:49AM -0600, Eric W. Biederman wrote: > > > >> > + inode_lock(parent->d_inode); > > > >> > dentry->d_fsdata = NULL; > > >

[PATCH 3/4] rtc: pcap: use .set_time

2019-04-30 Thread Alexandre Belloni
Use .set_time instead of the deprecated .set_mmss. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcap.c b/drivers/rtc/rtc-pcap.c index be2678042fcc..d424339f7abb 100644 ---

[PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Alexandre Belloni
While the range of REFERENCE + TIME is actually 33 bits, the counter itself (TIME) is a 32-bits seconds counter. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-digicolor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index

[PATCH 1/4] rtc: pcap: set range

2019-04-30 Thread Alexandre Belloni
While PCAP_RTC_DAY_MASK is set to 0x3, it is very unlikely to be correct as this ends in june 1992, before the product even existed. It is more likely to be a 14-bit day counter. The next product in the family (the mc13xxx) has a 15-bit day counter. The same issue is seen with

[PATCH 4/4] rtc: digicolor: convert to SPDX identifier

2019-04-30 Thread Alexandre Belloni
Use SPDX-License-Identifier instead of a verbose license text. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-digicolor.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index ed2fc1adafd5..0aecc3f8e721

[PATCH 3/4] rtc: digicolor: use .set_time

2019-04-30 Thread Alexandre Belloni
Use .set_time instead of the deprecated .set_mmss. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-digicolor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index e6e16aaac254..ed2fc1adafd5 100644 ---

[PATCH 1/4] rtc: digicolor: fix possible race condition

2019-04-30 Thread Alexandre Belloni
The IRQ is requested before the struct rtc is allocated and registered, but this struct is used in the IRQ handler. This may lead to a NULL pointer dereference. Switch to devm_rtc_allocate_device/rtc_register_device to allocate the rtc struct before requesting the IRQ. Signed-off-by: Alexandre

Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Liwei Song
On 04/30/2019 04:53 PM, Takashi Iwai wrote: > On Tue, 30 Apr 2019 10:32:47 +0200, > Liwei Song wrote: >> >> >> >> On 04/30/2019 03:31 PM, Takashi Iwai wrote: >>> On Tue, 30 Apr 2019 08:10:53 +0200, >>> Song liwei wrote: From: Liwei Song Fix the following BUG: BUG:

Re: [PATCH v7 2/4] vfio: ap: register IOMMU VFIO notifier

2019-04-30 Thread Halil Pasic
On Tue, 30 Apr 2019 09:59:51 +0200 Pierre Morel wrote: > On 29/04/2019 18:07, Halil Pasic wrote: > > On Fri, 26 Apr 2019 15:01:26 +0200 > > Pierre Morel wrote: > > > >> @@ -858,7 +887,17 @@ static int vfio_ap_mdev_open(struct mdev_device *mdev) > >>return ret; > >>} > >> >

[PATCH v2 4/7] rtc: jz4740: use .set_time

2019-04-30 Thread Alexandre Belloni
Use .set_time instead of the deprecated .set_mmss. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index

[PATCH v2 2/7] rtc: jz4740: switch to rtc_time64_to_tm/rtc_tm_to_time64

2019-04-30 Thread Alexandre Belloni
Call the 64bit versions of rtc_tm time conversion now that the range is enforced by the core. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c

[PATCH v2 5/7] rtc: jz4740: use dev_pm_set_wake_irq() to simplify code

2019-04-30 Thread Alexandre Belloni
Use dev_pm_set_wake_irq() to set the RTC as a wakeup source for suspend. This allows to remove the whole dev_pm_ops structure. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 37 +++-- 1 file changed, 7 insertions(+),

[PATCH v2 6/7] rtc: jz4740: rework invalid time detection

2019-04-30 Thread Alexandre Belloni
The scratchpad register is used to detect an invalid time when power to the RTC has been lost. Instead of deleting that precious information and set the time to the UNIX epoch, forward it to userspace. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c |

[PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m

2019-04-30 Thread Geert Uytterhoeven
The THERMAL configuration option was changed from tristate to bool, but a dependency on THERMAL=m was forgotten, leading to a warning when running "make savedefconfig": boolean symbol THERMAL tested for 'm'? test forced to 'n' Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module

[PATCH v2 7/7] rtc: jz4740: convert to SPDX identifier

2019-04-30 Thread Alexandre Belloni
Use SPDX-License-Identifier instead of a verbose license text. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index

[PATCH v2 1/7] rtc: jz4740: set range

2019-04-30 Thread Alexandre Belloni
RTC_SEC is a 32-bit seconds counter. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index d0a891777f44..079469627bd7

[PATCH v2 3/7] rtc: jz4740: remove useless check

2019-04-30 Thread Alexandre Belloni
rtc_time64_to_tm always returns a valid tm, it is not necessary to validate it. Tested-by: Mathieu Malaterre Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-jz4740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c

Re: [PATCH 2/3] prctl_set_mm: Refactor checks from validate_prctl_map

2019-04-30 Thread Kirill Tkhai
On 30.04.2019 11:18, Michal Koutný wrote: > Despite comment of validate_prctl_map claims there are no capability > checks, it is not completely true since commit 4d28df6152aa ("prctl: > Allow local CAP_SYS_ADMIN changing exe_file"). Extract the check out of > the function and make the function

[PATCH v2 2/2] Bluetooth: btusb: Quiesce btusb on system suspend

2019-04-30 Thread Kai-Heng Feng
System may freeze during suspend, and it's caused by btusb early wakeup: kernel: pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -16 kernel: dpm_run_callback(): pci_pm_suspend+0x0/0x130 returns -16 kernel: PM: Device :00:14.0 failed to suspend async: error -16 kernel: PM: Some devices

[PATCH v2 1/2] Bluetooth: Disable LE Advertising in hci_suspend_dev()

2019-04-30 Thread Kai-Heng Feng
LE Advertising may wake up system during system-wide sleep, disable it to prevent this issue from happening. Do the reverse in hci_resume_dev(). Signed-off-by: Kai-Heng Feng --- v2: - Abstract away enabling/disabling LE advertising from btusb. include/net/bluetooth/hci_core.h | 1 +

Re: [PATCH 3/4] x86/ftrace: make ftrace_int3_handler() not to skip fops invocation

2019-04-30 Thread Nicolai Stange
Steven Rostedt writes: > On Mon, 29 Apr 2019 14:38:35 -0700 > Linus Torvalds wrote: > >> On Mon, Apr 29, 2019 at 1:30 PM Steven Rostedt wrote: >> > >> > The update from "call custom_trampoline" to "call iterator_trampoline" >> > is where we have an issue. >> >> So it has never worked. Just

Re: sysfs attrs for HW ECDSA signature

2019-04-30 Thread Marek Behun
On Tue, 30 Apr 2019 10:27:28 +0200 Greg Kroah-Hartman wrote: > On Mon, Apr 29, 2019 at 11:47:52PM +0200, Marek Behun wrote: > > Hi Greg and Tejun, > > > > is it acceptable for a driver to expose sysfs attr files for ECDSA > > signature generation? > > What is "ECDSA signature generation"? Is

Re: [PATCH v2] mt76: mt7615: add TX/RX antenna pattern capabilities

2019-04-30 Thread Felix Fietkau
On 2019-04-26 07:23, Ryder Lee wrote: > Announce antenna pattern cap to adapt PHY and baseband settings. > > Signed-off-by: Ryder Lee > --- > Changes since v2: > - Add a prefix mt76 in the title. > --- > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [RFC PATCH 0/3] latencytop lock usage improvement

2019-04-30 Thread Feng Tang
Hi Peter, On Tue, Apr 30, 2019 at 11:10:33AM +0200, Peter Zijlstra wrote: > On Tue, Apr 30, 2019 at 04:35:05PM +0800, Feng Tang wrote: > > Hi Peter, > > > > On Tue, Apr 30, 2019 at 10:09:10AM +0200, Peter Zijlstra wrote: > > > On Mon, Apr 29, 2019 at 04:03:28PM +0800, Feng Tang wrote: > > > > Hi

Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading

2019-04-30 Thread Heiko Carstens
On Tue, Apr 30, 2019 at 09:51:08AM +0200, Jessica Yu wrote: > +++ Prarit Bhargava [29/04/19 11:17 -0400]: > >Heiko, do you want a Signed-off-by or a Reported-by? Either one works > >for me. > > > >P. > > I think you forgot to CC Heiko :) Indeed ;) I'm fine with the Reported-by tag. Thank you!

Re: [PATCH V4] cpufreq: Call transition notifier only once for each policy

2019-04-30 Thread Rafael J. Wysocki
On Mon, Apr 29, 2019 at 11:34 AM Viresh Kumar wrote: > > Currently the notifiers are called once for each CPU of the policy->cpus > cpumask. It would be more optimal if the notifier can be called only > once and all the relevant information be provided to it. IMO this also is a matter of I/F

Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-30 Thread Dan Carpenter
On Wed, Apr 24, 2019 at 11:57:43AM -0700, Nathan Chancellor wrote: > diff --git a/drivers/staging/kpc2000/kpc2000/cell_probe.c > b/drivers/staging/kpc2000/kpc2000/cell_probe.c > index ad2cc0a3bfa1..13f544f3c0b9 100644 > --- a/drivers/staging/kpc2000/kpc2000/cell_probe.c > +++

Re: [PATCH v10 00/11] mfd: add support for max77650 PMIC

2019-04-30 Thread Bartosz Golaszewski
wt., 23 kwi 2019 o 11:04 Bartosz Golaszewski napisał(a): > > From: Bartosz Golaszewski > > This series adds support for max77650 ultra low-power PMIC. It provides > the core mfd driver and a set of five sub-drivers for the regulator, > power supply, gpio, leds and input subsystems. > > Patches

Re: [PATCH 3/3] prctl_set_mm: downgrade mmap_sem to read lock

2019-04-30 Thread Kirill Tkhai
On 30.04.2019 12:08, Cyrill Gorcunov wrote: > On Tue, Apr 30, 2019 at 11:55:45AM +0300, Kirill Tkhai wrote: >>> - up_write(>mmap_sem); >>> + spin_unlock(>arg_lock); >>> + up_read(>mmap_sem); >>> return error; >> >> Hm, shouldn't spin_lock()/spin_unlock() pair go as a fixup to existing

[PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-04-30 Thread Petr Mladek
klp_try_switch_task() is called under klp_mutex. The buffer for debugging messages might be static. Signed-off-by: Petr Mladek --- kernel/livepatch/transition.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c

[PATCH v2 1/2] livepatch: Remove duplicate warning about missing reliable stacktrace support

2019-04-30 Thread Petr Mladek
WARN_ON_ONCE() could not be called safely under rq lock because of console deadlock issues. Fortunately, there is another check for the reliable stacktrace support in klp_enable_patch(). Signed-off-by: Petr Mladek --- kernel/livepatch/transition.c | 9 - 1 file changed, 8 insertions(+),

[PATCH v2 0/2] livepatch: Clean up of reliable stacktrace warnings

2019-04-30 Thread Petr Mladek
This is the remaining piece from the original patchset[1]. It is a simplification and split of the 3rd patch. [1] https://lkml.kernel.org/r/20190424085550.29612-1-pmla...@suse.com Petr Mladek (2): livepatch: Remove duplicate warning about missing reliable stacktrace support livepatch:

Re: [RFC PATCH 0/3] latencytop lock usage improvement

2019-04-30 Thread Peter Zijlstra
On Tue, Apr 30, 2019 at 04:35:05PM +0800, Feng Tang wrote: > Hi Peter, > > On Tue, Apr 30, 2019 at 10:09:10AM +0200, Peter Zijlstra wrote: > > On Mon, Apr 29, 2019 at 04:03:28PM +0800, Feng Tang wrote: > > > Hi All, > > > > > > latencytop is a very nice tool for tracing system latency hotspots,

Re: [PATCH 1/3] mm: get_cmdline use arg_lock instead of mmap_sem

2019-04-30 Thread Kirill Tkhai
On 30.04.2019 11:18, Michal Koutný wrote: > The commit a3b609ef9f8b ("proc read mm's {arg,env}_{start,end} with mmap > semaphore taken.") added synchronization of reading argument/environment > boundaries under mmap_sem. Later commit 88aa7cc688d4 ("mm: introduce > arg_lock to protect arg_start|end

Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

2019-04-30 Thread Peter Zijlstra
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? On Mon, Apr 29, 2019 at 04:02:33PM -0700, Ian Rogers wrote: > This is very interesting. How does the code handle cgroup

Re: [PATCH 4/5] ceph: fix improper use of smp_mb__before_atomic()

2019-04-30 Thread Yan, Zheng
On Tue, Apr 30, 2019 at 4:26 PM Peter Zijlstra wrote: > > On Mon, Apr 29, 2019 at 10:15:00PM +0200, Andrea Parri wrote: > > This barrier only applies to the read-modify-write operations; in > > particular, it does not apply to the atomic64_set() primitive. > > > > Replace the barrier with an

Re: [PATCH 3/3] prctl_set_mm: downgrade mmap_sem to read lock

2019-04-30 Thread Cyrill Gorcunov
On Tue, Apr 30, 2019 at 11:55:45AM +0300, Kirill Tkhai wrote: > > - up_write(>mmap_sem); > > + spin_unlock(>arg_lock); > > + up_read(>mmap_sem); > > return error; > > Hm, shouldn't spin_lock()/spin_unlock() pair go as a fixup to existing code > in a separate patch? > > Without them,

Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

2019-04-30 Thread Peter Zijlstra
On Mon, Apr 29, 2019 at 07:44:04AM -0700, kan.li...@linux.intel.com wrote: > +static struct perf_event * > +perf_event_groups_first_cgroup(struct perf_event_groups *groups, > +int cpu, u64 cgrp_id) > +{ > + struct perf_event *node_event = NULL, *match = NULL; > +

Re: [PATCH 3/4] perf cgroup: Add cgroup ID as a key of RB tree

2019-04-30 Thread Peter Zijlstra
On Mon, Apr 29, 2019 at 07:44:04AM -0700, kan.li...@linux.intel.com wrote: > Add unique cgrp_id for each cgroup, which is composed by CPU ID and css > subsys-unique ID. *WHY* ?! that doesn't make any kind of sense.. In fact you mostly then use the low word because most everything is already per

[PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Phong Tran
The cell is a pointer to __be32. with the be32_to_cpu a lot of clang warning show that: ./include/linux/of.h:238:37: warning: multiple unsequenced modifications to 'cell' [-Wunsequenced] r = (r << 32) | be32_to_cpu(*(cell++)); ^~

Re: [PATCH REPOST] random: Add a spinlock_t to struct batched_entropy

2019-04-30 Thread Sebastian Andrzej Siewior
On 2019-04-28 14:29:28 [-0400], Theodore Ts'o wrote: > This patch is already on the random.git tree. (It wasn't in > linux-next because I had forgotten that linux-next pulls from the dev > branch, as opposed to the master branch.) Oh, Thank you! > Cheers, > >

Re: [REGRESSION 5.0.8] Dell thunderbolt dock broken (xhci_hcd and thunderbolt)

2019-04-30 Thread Mika Westerberg
+Rafael, Furquan and linux-acpi (The original thread is here https://lore.kernel.org/lkml/s5hy33siofw.wl-ti...@suse.de/T/#u) On Tue, Apr 30, 2019 at 10:39:00AM +0200, Michael Hirmke wrote: > Hi Takashi, > > [...] > >>> I also have XPS 9370 but not that particular dock. I will check tomorrow >

Re: [PATCH] fs: VALIDATE_FS_PARSER should default to n

2019-04-30 Thread Geert Uytterhoeven
Hi David, On Mon, Apr 1, 2019 at 1:54 PM Geert Uytterhoeven wrote: > CONFIG_VALIDATE_FS_PARSER is a debugging tool to check that the parser > tables are vaguely sane. It was set to default to 'Y' for the moment to > catch errors in upcoming fs conversion development. > > Make sure it is not

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Vinod Koul
On 19-04-19, 12:14, Pierre-Louis Bossart wrote: > > > > >   enum sdw_command_response > > > >   cdns_xfer_msg_defer(struct sdw_bus *bus, > > > > -    struct sdw_msg *msg, struct sdw_defer *defer) > > > > +    struct sdw_msg *msg, struct sdw_defer *defer) > > > > > > this one too.. >

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-30 Thread Peter Zijlstra
On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index e47ef76..039e2f2 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -795,6 +795,7 @@ struct perf_cpu_context { >

Re: [PATCH 3/3] prctl_set_mm: downgrade mmap_sem to read lock

2019-04-30 Thread Kirill Tkhai
On 30.04.2019 11:18, Michal Koutný wrote: > Since commit 88aa7cc688d4 ("mm: introduce arg_lock to protect > arg_start|end and env_start|end in mm_struct") we use arg_lock for > boundaries modifications. Synchronize prctl_set_mm with this lock and > keep mmap_sem for reading only (analogous to what

Re: [PATCH 4/7] dmaengine: sprd: Add device validation to support multiple controllers

2019-04-30 Thread Baolin Wang
Hi Vinod, On Tue, 30 Apr 2019 at 16:34, Baolin Wang wrote: > > On Tue, 30 Apr 2019 at 16:30, Vinod Koul wrote: > > > > On 30-04-19, 13:30, Baolin Wang wrote: > > > On Mon, 29 Apr 2019 at 22:05, Vinod Koul wrote: > > > > > > > > On 29-04-19, 20:20, Baolin Wang wrote: > > > > > On Mon, 29 Apr

Re: [PATCH] ALSA: hda: check RIRB to avoid use NULL pointer

2019-04-30 Thread Takashi Iwai
On Tue, 30 Apr 2019 10:32:47 +0200, Liwei Song wrote: > > > > On 04/30/2019 03:31 PM, Takashi Iwai wrote: > > On Tue, 30 Apr 2019 08:10:53 +0200, > > Song liwei wrote: > >> > >> From: Liwei Song > >> > >> Fix the following BUG: > >> > >> BUG: unable to handle kernel NULL pointer dereference at

Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues

2019-04-30 Thread Vinod Koul
On 15-04-19, 08:09, Pierre-Louis Bossart wrote: > > > > > > > Signed-off-by: Pierre-Louis Bossart > > > --- > > > drivers/soundwire/Kconfig | 2 +- > > > drivers/soundwire/bus.c| 87 > > > drivers/soundwire/bus.h| 16 +-- > > >

Re: scripts/selinux build error in 4.14 after glibc update

2019-04-30 Thread Greg KH
On Mon, Apr 29, 2019 at 06:37:03PM -0400, Paul Moore wrote: > On Mon, Apr 29, 2019 at 10:52 AM Greg KH wrote: > > On Mon, Apr 29, 2019 at 10:47:00AM -0400, Paul Moore wrote: > > > On Mon, Apr 29, 2019 at 10:09 AM Greg KH > > > wrote: > > > > On Mon, Apr 29, 2019 at 10:02:29AM -0400, Paul Moore

<    4   5   6   7   8   9   10   >