Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

2019-05-13 Thread Akinobu Mita
2019年5月13日(月) 16:41 Minwoo Im : > > > -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > > *dev); > > +static void

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Christoph Hellwig
On Mon, May 13, 2019 at 02:54:49PM +, mario.limoncie...@dell.com wrote: > The Intel DMA controller suspend callbacks in drivers/dma/idma64.c look to me > to > turn off the controller. How is that relevant? That thing is neither a NVMe controller, nor even an PCIe device.. > And NVME spec

[PATCH v9 0/3] Add support for the Purism Librem5 devkit

2019-05-13 Thread Angus Ainslie (Purism)
The Librem5 devkit is based on the imx8mq from NXP. This is a default devicetree to boot the board to a command prompt. Changes since v8: Fixed license comment. Changed regulators to all lower case. Changed clock frequency for NXP errata e7805. Dropped blank line. Changes since v7: More

[PATCH v9 2/3] dt-bindings: Add an entry for Purism SPC

2019-05-13 Thread Angus Ainslie (Purism)
Add an entry for Purism, SPC Signed-off-by: Angus Ainslie (Purism) Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

[PATCH v9 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-13 Thread Angus Ainslie (Purism)
This is for the development kit board for the Librem 5. The current level of support yields a working console and is able to boot userspace from the network or eMMC. Additional subsystems that are active : - Both USB ports - SD card socket - WiFi usdhc - WWAN modem - GNSS - GPIO keys - LEDs -

[PATCH v9 3/3] dt-bindings: arm: fsl: Add the imx8mq boards

2019-05-13 Thread Angus Ainslie (Purism)
Add an entry for imx8mq based boards Signed-off-by: Angus Ainslie (Purism) Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Christoph Hellwig
On Mon, May 13, 2019 at 02:43:43PM +, mario.limoncie...@dell.com wrote: > Well I've got a thought, quoting the NVME spec: > "After a successful completion of a Set Features command for this feature, > the controller shall be in the > Power State specified. If enabled, autonomous power state

RE: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Mario.Limonciello
> -Original Message- > From: Keith Busch > Sent: Monday, May 13, 2019 9:38 AM > To: Limonciello, Mario > Cc: keith.bu...@intel.com; h...@lst.de; s...@grimberg.me; linux- > n...@lists.infradead.org; raf...@kernel.org; linux-kernel@vger.kernel.org; > linux- > p...@vger.kernel.org;

Re: [PATCH v5 02/12] Documentation: PCI: convert pci.txt to reST

2019-05-13 Thread Mauro Carvalho Chehab
Em Mon, 13 May 2019 22:19:50 +0800 Changbin Du escreveu: > This converts the plain text documentation to reStructuredText format and > add it to Sphinx TOC tree. No essential content change. > > The description about struct pci_driver and struct pci_device_id are moved > into in-source

Re: [PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-05-13 Thread Sean Paul
On Wed, May 08, 2019 at 01:42:12PM -0700, Rob Clark wrote: > From: Jayant Shekhar > > The interconnect framework is designed to provide a > standard kernel interface to control the settings of > the interconnects on a SoC. > > The interconnect API uses a consumer/provider-based model, > where

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

2019-05-13 Thread Daniel Vetter
On Sat, May 11, 2019 at 01:33:44PM -0400, Theodore Ts'o wrote: > On Fri, May 10, 2019 at 02:12:40PM -0700, Frank Rowand wrote: > > However, the reply is incorrect. Kselftest in-kernel tests (which > > is the context here) can be configured as built in instead of as > > a module, and built in a

Re: [PATCH v3 0/4] Add reset controller support for BM1880 SoC

2019-05-13 Thread Philipp Zabel
On Mon, 2019-05-13 at 19:36 +0530, Manivannan Sadhasivam wrote: > Hi Philipp, > > On Mon, May 13, 2019 at 01:06:29PM +0200, Philipp Zabel wrote: > > Hi, > > > > On Sat, 2019-05-11 at 00:15 +0530, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This patchset adds reset controller support

Re: KASAN: slab-out-of-bounds Write in usb_get_bos_descriptor

2019-05-13 Thread Alan Stern
On Fri, 10 May 2019, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:43151d6c usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=124794d8a0

[PATCH] habanalabs: increase PCI ELBI timeout for Palladium

2019-05-13 Thread Oded Gabbay
From: Omer Shpigelman This patch increases the timeout for PCI ELBI configuration to support low frequency Palladium images. Signed-off-by: Omer Shpigelman Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/habanalabs.h | 2 ++ drivers/misc/habanalabs/pci.c| 10 +- 2

Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment

2019-05-13 Thread Philippe CORNU
Dear Yannick, Acked-by: Philippe Cornu Thank you, Philippe :-) On 5/13/19 3:15 PM, Yannick Fertré wrote: > Clk_round_rate returns rounded clock without changing > the hardware in any way. > This function couldn't replace set_rate/get_rate calls. > Todo comment has been removed & a new log

RE: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Mario.Limonciello
> -Original Message- > From: Christoph Hellwig > Sent: Monday, May 13, 2019 9:38 AM > To: Limonciello, Mario > Cc: keith.bu...@intel.com; h...@lst.de; s...@grimberg.me; linux- > n...@lists.infradead.org; raf...@kernel.org; linux-kernel@vger.kernel.org; > linux- > p...@vger.kernel.org;

Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF MFD bindings

2019-05-13 Thread Geert Uytterhoeven
Hi Mason, Note that if you send multipart/text+html emails, they will be dropped silently by most Linux mailing lists. Hence I'm quoting your last email fully, to give other people a chance reading it (and commenting). On Mon, May 13, 2019 at 11:37 AM wrote: > > > > [...] > > > > >> > >> > On

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Keith Busch
On Mon, May 13, 2019 at 02:24:41PM +, mario.limoncie...@dell.com wrote: > This was not a disk with HMB, but with regard to the HMB I believe it needs > to be > removed during s0ix so that there isn't any mistake that SSD thinks it can > access HMB > memory in s0ix. Is that really the case,

[RFC KVM 01/27] kernel: Export memory-management symbols required for KVM address space isolation

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Export symbols needed to create, manage, populate and switch a mm from a kernel module (kvm in this case). This is a hacky way for now to start. This should be changed to some suitable memory-management API. Signed-off-by: Liran Alon Signed-off-by: Alexandre Chartre ---

Re: [PATCH v3 04/10] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-05-13 Thread Sean Paul
On Sat, May 11, 2019 at 3:12 PM Laurent Pinchart wrote: > > Hi Sean, > > Thank you for the patch. > Hey Laurent, Thanks for looking! > On Thu, May 02, 2019 at 03:49:46PM -0400, Sean Paul wrote: > > From: Sean Paul > > > > Everyone who implements connector_helper_funcs->atomic_check reaches >

[RFC KVM 26/27] kvm/isolation: initialize the KVM page table with KVM memslots

2019-05-13 Thread Alexandre Chartre
KVM memslots can change after they have been created so new memslots have to be mapped when they are created. TODO: we currently don't unmapped old memslots, they should be unmapped when they are freed. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 39

[RFC KVM 05/27] KVM: x86: Add handler to exit kvm isolation

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Interrupt handlers will need this handler to switch from the KVM address space back to the kernel address space on their prelog. Signed-off-by: Liran Alon Signed-off-by: Alexandre Chartre --- arch/x86/include/asm/irq.h |1 + arch/x86/kernel/irq.c | 11 +++

[RFC KVM 27/27] kvm/isolation: initialize the KVM page table with KVM buses

2019-05-13 Thread Alexandre Chartre
KVM buses can change after they have been created so new buses have to be mapped when they are created. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 37 + arch/x86/kvm/isolation.h |1 + arch/x86/kvm/x86.c | 13 -

[RFC KVM 23/27] kvm/isolation: initialize the KVM page table with the vcpu tasks

2019-05-13 Thread Alexandre Chartre
Tasks which are going to be running with the KVM address space have to be mapped with their core data (stack, mm, pgd..) so that they can (at least) switch back to the kernel address space. For now, assume that these tasks are the ones running vcpu, and that there's a 1:1 mapping between a task

[PATCH] ARC: Send SIGSEGV if userspace process accesses kernel virtual memory

2019-05-13 Thread Eugeniy Paltsev
As of today if userspace process tries to access address which belongs to kernel virtual memory area and kernel have mapping for this address that process hangs instead of receiving SIGSEGV and being killed. Steps to reproduce: Create userspace application which reads from the beginning of

Re: [alsa-devel] [PATCH] ASoC: max98090: remove 24-bit format support

2019-05-13 Thread Pierre-Louis Bossart
On 5/10/19 5:25 AM, Yu-Hsuan Hsu wrote: Remove 24-bit format support because it doesn't work now. We can revert this change after it really supports. (https://patchwork.kernel.org/patch/10783561/) Signed-off-by: Yu-Hsuan Hsu As discussed in the previous thread, the data sheet explicitly

[RFC KVM 24/27] kvm/isolation: KVM page fault handler

2019-05-13 Thread Alexandre Chartre
The KVM page fault handler handles page fault occurring while using the KVM address space by switching to the kernel address space and retrying the access (except if the fault occurs while switching to the kernel address space). Processing of page faults occurring while using the kernel address

[RFC KVM 14/27] kvm/isolation: functions to copy page table entries for a VA range

2019-05-13 Thread Alexandre Chartre
These functions are based on the copy_pxx_range() functions defined in mm/memory.c. The main difference is that a level parameter is specified to indicate the page table level (PGD, P4D, PUD PMD, PTE) at which the copy should be done. Also functions don't use a vma parameter, and don't alter the

[RFC KVM 17/27] kvm/isolation: improve mapping copy when mapping is already present

2019-05-13 Thread Alexandre Chartre
A mapping can already exist if a buffer was mapped in the KVM address space, and then the buffer was freed but there was no request to unmap from the KVM address space. In that case, clear the existing mapping before mapping the new buffer. Also if the new mapping is a subset of an already larger

[RFC KVM 18/27] kvm/isolation: function to copy page table entries for percpu buffer

2019-05-13 Thread Alexandre Chartre
pcpu_base_addr is already mapped to the KVM address space, but this represents the first percpu chunk. To access a per-cpu buffer not allocated in the first chunk, add a function which maps all cpu buffers corresponding to that per-cpu buffer. Also add function to clear page table entries for a

[RFC KVM 09/27] kvm/isolation: function to track buffers allocated for the KVM page table

2019-05-13 Thread Alexandre Chartre
The KVM page table will have direct references to the kernel page table, at different levels (PGD, P4D, PUD, PMD). When freeing the KVM page table, we should make sure that we free parts actually allocated for the KVM page table, and not parts of the kernel page table referenced from the KVM page

[RFC KVM 21/27] kvm/isolation: initialize the KVM page table with vmx VM data

2019-05-13 Thread Alexandre Chartre
Map VM data, in particular the kvm structure data. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 17 + arch/x86/kvm/isolation.h |2 ++ arch/x86/kvm/vmx/vmx.c | 31 ++- arch/x86/kvm/x86.c | 12

[RFC KVM 06/27] KVM: x86: Exit KVM isolation on IRQ entry

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Next commits will change most of KVM #VMExit handlers to run in KVM isolated address space. Any interrupt handler raised during execution in KVM address space needs to switch back to host address space. This patch makes sure that IRQ handlers will run in full host address space

[RFC KVM 22/27] kvm/isolation: initialize the KVM page table with vmx cpu data

2019-05-13 Thread Alexandre Chartre
Map vmx cpu to the KVM address space when a vmx cpu is created, and unmap when it is freed. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/vmx/vmx.c | 65 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c

[RFC KVM 25/27] kvm/isolation: implement actual KVM isolation enter/exit

2019-05-13 Thread Alexandre Chartre
From: Liran Alon KVM isolation enter/exit is done by switching between the KVM address space and the kernel address space. Signed-off-by: Liran Alon Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 30 -- arch/x86/mm/tlb.c|1 +

[RFC KVM 20/27] kvm/isolation: initialize the KVM page table with vmx specific data

2019-05-13 Thread Alexandre Chartre
In addition of core memory mappings, the KVM page table has to be initialized with vmx specific data. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/vmx/vmx.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c

[RFC KVM 19/27] kvm/isolation: initialize the KVM page table with core mappings

2019-05-13 Thread Alexandre Chartre
The KVM page table is initialized with adding core memory mappings: the kernel text, the per-cpu memory, the kvm module, the cpu_entry_area, %esp fixup stacks, IRQ stacks. Signed-off-by: Alexandre Chartre --- arch/x86/kernel/cpu/common.c |2 + arch/x86/kvm/isolation.c | 131

[RFC KVM 12/27] kvm/isolation: add KVM page table entry allocation functions

2019-05-13 Thread Alexandre Chartre
These functions allocate p4d/pud/pmd/pte pages and ensure that pages are in the KVM page table. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 94 ++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git

[RFC KVM 13/27] kvm/isolation: add KVM page table entry set functions

2019-05-13 Thread Alexandre Chartre
Add wrappers around the page table entry (pgd/p4d/pud/pmd) set function to check that an existing entry is not being overwritten. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 107 ++ 1 files changed, 107 insertions(+), 0

[RFC KVM 16/27] kvm/isolation: functions to clear page table entries for a VA range

2019-05-13 Thread Alexandre Chartre
These functions will be used to unmapped memory from the KVM address space. When clearing mapping in the KVM page table, check that the clearing effectively happens in the KVM page table and there is no crossing of the KVM page table boundary (with references to the kernel page table), so that

[RFC KVM 04/27] KVM: x86: Switch to KVM address space on entry to guest

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Switch to KVM address space on entry to guest and switch out on immediately at exit (before enabling host interrupts). For now, this is not effectively switching, we just remain on the kernel address space. In addition, we switch back as soon as we exit guest, which makes KVM

[RFC KVM 15/27] kvm/isolation: keep track of VA range mapped in KVM address space

2019-05-13 Thread Alexandre Chartre
This will be used when we have to clear mappings to ensure the same range is cleared at the same page table level it was copied. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 86 - 1 files changed, 84 insertions(+), 2 deletions(-)

[RFC KVM 11/27] kvm/isolation: add KVM page table entry offset functions

2019-05-13 Thread Alexandre Chartre
These functions are wrappers are the p4d/pud/pmd/pte offset functions which ensure that page table pointers are in the KVM page table. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 61 ++ 1 files changed, 61 insertions(+), 0

[RFC KVM 10/27] kvm/isolation: add KVM page table entry free functions

2019-05-13 Thread Alexandre Chartre
These functions are wrappers around the p4d/pud/pmd/pte free function which can be used with any pointer in the directory. Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git

[RFC KVM 08/27] KVM: x86: Optimize branches which checks if address space isolation enabled

2019-05-13 Thread Alexandre Chartre
From: Liran Alon As every entry to guest checks if should switch from host_mm to kvm_mm, these branches is at very hot path. Optimize them by using static_branch. Signed-off-by: Liran Alon Signed-off-by: Alexandre Chartre --- arch/x86/kvm/isolation.c | 11 ---

[RFC KVM 00/27] KVM Address Space Isolation

2019-05-13 Thread Alexandre Chartre
Hi, This series aims to introduce the concept of KVM address space isolation. This is done as part of the upstream community effort to have exploit mitigations for CPU info-leaks vulnerabilities such as L1TF. These patches are based on an original patches from Liran Alon, completed with

[RFC KVM 02/27] KVM: x86: Introduce address_space_isolation module parameter

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Add the address_space_isolation parameter to the kvm module. When set to true, KVM #VMExit handlers run in isolated address space which maps only KVM required code and per-VM information instead of entire kernel address space. This mechanism is meant to mitigate memory-leak

[RFC KVM 03/27] KVM: x86: Introduce KVM separate virtual address space

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Create a separate mm for KVM that will be active when KVM #VMExit handlers run. Up until the point which we architectully need to access host (or other VM) sensitive data. This patch just create kvm_mm but never makes it active yet. This will be done by next commits.

[RFC KVM 07/27] KVM: x86: Switch to host address space when may access sensitive data

2019-05-13 Thread Alexandre Chartre
From: Liran Alon Before this patch, we exited from KVM isolated address space to host address space as soon as we exit guest. Change code such that most of KVM #VMExit handlers will run in KVM isolated address space and switch back to host address space only before accessing sensitive data.

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Christoph Hellwig
On Mon, May 13, 2019 at 02:24:41PM +, mario.limoncie...@dell.com wrote: > I've received the result that from one of my partners this patch doesn't > work properly and the platform doesn't go into a lower power state. Well, it sounds like your partners device does not work properly in this

Re: [PATCH] modules: fix livelock in add_unformed_module()

2019-05-13 Thread Barret Rhoden
Hi - On 5/13/19 7:23 AM, Prarit Bhargava wrote: [snip] A module is loaded once for each cpu. Does one CPU succeed in loading the module, and the others fail with EEXIST? My follow-up patch changes from wait_event_interruptible() to wait_event_interruptible_timeout() so the CPUs are no

Re: [PATCH AUTOSEL 4.14 79/95] x86/asm: Remove dead __GNUC__ conditionals

2019-05-13 Thread Sasha Levin
On Tue, May 07, 2019 at 08:15:03AM +0200, Greg KH wrote: On Tue, May 07, 2019 at 07:57:01AM +0200, Rasmus Villemoes wrote: On 07/05/2019 07.38, Sasha Levin wrote: > From: Rasmus Villemoes > > [ Upstream commit 88ca66d8540ca26119b1428cddb96b37925bdf01 ] > > The minimum supported gcc version is

Re: [PATCH RESEND 1/2] soc: imx: Add SCU SoC info driver support

2019-05-13 Thread Daniel Baluta
> + > +static u32 imx8qxp_soc_revision(void) > +{ > + struct imx_sc_msg_misc_get_soc_id msg; > + struct imx_sc_rpc_msg *hdr = > + u32 rev = 0; > + int ret; > + > + hdr->ver = IMX_SC_RPC_VERSION; > + hdr->svc = IMX_SC_RPC_SVC_MISC; > + hdr->func =

Re: linux-next: manual merge of the vhost tree with the iommu tree

2019-05-13 Thread Jean-Philippe Brucker
On 12/05/2019 18:16, Michael S. Tsirkin wrote: > On Thu, Feb 28, 2019 at 11:04:42AM +0100, Joerg Roedel wrote: >> On Wed, Feb 27, 2019 at 08:58:36AM -0500, Michael S. Tsirkin wrote: >>> Even though it's not going into 5.1 I feel it's helpful to keep it in >>> the vhost tree until the next cycle,

Re: [PATCH, RFC 03/62] mm/ksm: Do not merge pages with different KeyIDs

2019-05-13 Thread Kirill A. Shutemov
On Fri, May 10, 2019 at 06:07:11PM +, Dave Hansen wrote: > On 5/8/19 7:43 AM, Kirill A. Shutemov wrote: > > KeyID indicates what key to use to encrypt and decrypt page's content. > > Depending on the implementation a cipher text may be tied to physical > > address of the page. It means that

[PATCH v3] drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs

2019-05-13 Thread Uenal Mutlu
Increasing the SATA/AHCI DMA TX/RX FIFOs (P0DMACR.TXTS and .RXTS, ie. TX_TRANSACTION_SIZE and RX_TRANSACTION_SIZE) from default 0x0 each to 0x3 each, gives a write performance boost of 120 MiB/s to 132 MiB/s from lame 36 MiB/s to 45 MiB/s previously. Read performance is above 200 MiB/s. [tested on

RE: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Mario.Limonciello
> > Cc: Mario Limonciello > > Cc: Kai Heng Feng > > Signed-off-by: Keith Busch > > --- > > Disclaimer: I've tested only on emulation faking support for the feature. > > Thanks for sharing. I'll arrange some testing with this with storage > partners early > next week. > I've received the

Re: [PATCH] powerpc/powernv/npu: Fix reference leak

2019-05-13 Thread Greg Kurz
Michael, Any comments on this patch ? Should I repost with a shorter comment as suggested by Alexey ? Cheers, -- Greg On Mon, 29 Apr 2019 12:36:59 +0200 Greg Kurz wrote: > On Mon, 29 Apr 2019 16:01:29 +1000 > Alexey Kardashevskiy wrote: > > > On 20/04/2019 01:34, Greg Kurz wrote: > > >

[PATCH 2/2] input: keyboard: mtk-pmic-keys: add MT6392 support

2019-05-13 Thread Fabien Parent
Add support for MT6392 PMIC's keys. Signed-off-by: Fabien Parent --- drivers/input/keyboard/mtk-pmic-keys.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c index 8e6ebab05ab4..aaf68cbf7e5b

[PATCH 1/2] dt-bindings: input: mtk-pmic-keys: add MT6392 binding definition

2019-05-13 Thread Fabien Parent
Add the binding documentation of the mtk-pmic-keys for the MT6392 PMICs. Signed-off-by: Fabien Parent --- .../devicetree/bindings/input/mtk-pmic-keys.txt | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[Patch] slub: Fix a missing-check bug in mm/slub.c file of Linux 5.1.1

2019-05-13 Thread Gen Zhang
Pointer s is allocated with kmem_cache_zalloc(). And s is used in the follwoing codes. However, when kmem_cache_zalloc fails, using s will cause null pointer dereference and the kernel will go wrong. Thus we check whether the kmem_cache_zalloc fails. Signed-off-by: Gen Zhang --- --- mm/slub.c

[PATCH v2] powerpc/boot: pass CONFIG options in a simpler and more robust way

2019-05-13 Thread Masahiro Yamada
Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures with -j 1") was also wrong. The correct dependency is: $(obj)/serial.o: $(obj)/autoconf.h However, I do not see the reason why we need to copy

Re: [PATCH] vsprintf: Do not break early boot with probing addresses

2019-05-13 Thread Steven Rostedt
On Mon, 13 May 2019 14:42:20 +0200 Petr Mladek wrote: > > The "(null)" is good enough by itself and already an established > > practice.. > > (efault) made more sense with the probe_kernel_read() that > checked wide range of addresses. Well, I still think that > it makes sense to distinguish

Re: Linux in KVM guest segfaults when hosts runs Linux 5.1

2019-05-13 Thread Radim Krčmář
2019-05-12 13:53+0200, Marc Haber: > since updating my home desktop machine to kernel 5.1.1, KVM guests > started on that machine segfault after booting: [...] > Any idea short of bisecting? It has also been spotted by Borislav and the fix [1] should land in the next kernel update, thanks for the

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-13 Thread Sibi Sankar
Hey Bjorn, On 5/1/19 10:07 AM, Bjorn Andersson wrote: The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple

Re: Linux in KVM guest segfaults when hosts runs Linux 5.1

2019-05-13 Thread Sean Christopherson
On Sun, May 12, 2019 at 01:53:02PM +0200, Marc Haber wrote: > Hi, > > since updating my home desktop machine to kernel 5.1.1, KVM guests > started on that machine segfault after booting: > general protection fault: [#1] PREEMPT SMP NOPTI > CPU: 0 PID: 13 Comm: kworker/0:1 Not tainted

Re: [PATCH v3 0/4] Add reset controller support for BM1880 SoC

2019-05-13 Thread Manivannan Sadhasivam
Hi Philipp, On Mon, May 13, 2019 at 01:06:29PM +0200, Philipp Zabel wrote: > Hi, > > On Sat, 2019-05-11 at 00:15 +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This patchset adds reset controller support for Bitmain BM1880 SoC. > > BM1880 SoC has only one reset controller and the

Re: [PATCH] thermal: tsens: Make some symbols static

2019-05-13 Thread Amit Kucheria
On Mon, May 13, 2019 at 7:31 PM YueHaibing wrote: > > Fix sparse warnings: > > drivers/thermal/qcom/tsens-v0_1.c:322:29: warning: symbol 'tsens_v0_1_feat' > was not declared. Should it be static? > drivers/thermal/qcom/tsens-v0_1.c:330:24: warning: symbol > 'tsens_v0_1_regfields' was not

Re: [RFC PATCH] ARM: mach-shmobile: Parse DT to get ARCH timer memory region

2019-05-13 Thread Oleksandr
On 13.05.19 12:19, Julien Grall wrote: Hi, Hi, Julien, Geert On 5/10/19 5:22 PM, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Don't use hardcoded address, retrieve it from device-tree instead. And besides, this patch fixes the memory error when running on top of Xen

Re: [PATCH -next v2] mm/hotplug: fix a null-ptr-deref during NUMA boot

2019-05-13 Thread Michal Hocko
On Mon 13-05-19 09:43:59, Qian Cai wrote: > On Mon, 2019-05-13 at 14:41 +0200, Michal Hocko wrote: > > On Sun 12-05-19 01:48:29, Qian Cai wrote: > > > The linux-next commit ("x86, numa: always initialize all possible > > > nodes") introduced a crash below during boot for systems with a > > >

Re: [PATCH] powerpc/boot: fix broken way to pass CONFIG options

2019-05-13 Thread Oliver
On Mon, May 13, 2019 at 11:56 PM Masahiro Yamada wrote: > > On Mon, May 13, 2019 at 9:33 PM Masahiro Yamada > wrote: > > > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > > with -j 1") was also

Re: [PATCH v2] selftests: kvm: Add files generated when compiled to .gitignore

2019-05-13 Thread Sean Christopherson
On Sat, May 11, 2019 at 10:44:34PM -0600, Kelsey Skunberg wrote: > The following files are generated in /selftests/kvm/ after compiling and > should be added to /selftests/kvm/.gitignore: > > - /x86_64/hyperv_cpuid > - /x86_64/smm_test > - /clear_dirty_log_test > >

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

2019-05-13 Thread Christoph Hellwig
Usage of a scatterlist here is rather bogus as we never use it for dma mapping. Why can't you store the various pages in a large bio_vec and then just issue that to the device in one get log page command? (or at least a few if MDTS kicks in?)

Re: [PATCH] powerpc/boot: fix broken way to pass CONFIG options

2019-05-13 Thread Oliver
On Mon, May 13, 2019 at 9:23 PM Masahiro Yamada wrote: > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > with -j 1") was also wrong. > > Check-in source files never ever depend on build artifacts.

[PATCH] thermal: tsens: Make some symbols static

2019-05-13 Thread YueHaibing
Fix sparse warnings: drivers/thermal/qcom/tsens-v0_1.c:322:29: warning: symbol 'tsens_v0_1_feat' was not declared. Should it be static? drivers/thermal/qcom/tsens-v0_1.c:330:24: warning: symbol 'tsens_v0_1_regfields' was not declared. Should it be static? drivers/thermal/qcom/tsens-v1.c:147:29:

Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

2019-05-13 Thread Keith Busch
On Sun, May 12, 2019 at 08:54:16AM -0700, Akinobu Mita wrote: > @@ -2536,6 +2539,9 @@ static void nvme_reset_work(struct work_struct *work) > if (result) > goto out; > > + nvme_coredump_logs(dev); If you change nvme_coredump_logs to return an int, check it here for < 0

Re: [PATCH] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG

2019-05-13 Thread Schrempf Frieder
Hi Jeff, I just noticed I hit the wrong button and my previous reply was only sent to the MTD list, so I'm resending with fixed recipients... On 10.05.19 14:17, l...@allycomm.com wrote: > From: Jeff Kletsky > > The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices > and,

Re: Format ioctls (Input 1) test Cropping failed: 4.19, 4.14, 4.9 and 4.4

2019-05-13 Thread Hans Verkuil
On 5/13/19 3:36 PM, Naresh Kamboju wrote: > Format ioctls (Input 1) test Cropping failed on all devices running > 4.19, 4.14, 4.9 and 4.4 kernel branches. > > Format ioctls (Input 1): > > ... > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > fail: >

[PATCH] thermal: tegra: Make tegra210_tsensor_thermtrips static

2019-05-13 Thread YueHaibing
Fix sparse warning: drivers/thermal/tegra/tegra210-soctherm.c:211:33: warning: symbol 'tegra210_tsensor_thermtrips' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/thermal/tegra/tegra210-soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] powerpc/boot: fix broken way to pass CONFIG options

2019-05-13 Thread Masahiro Yamada
On Mon, May 13, 2019 at 9:33 PM Masahiro Yamada wrote: > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > with -j 1") was also wrong. > > Check-in source files never ever depend on build artifacts.

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

2019-05-13 Thread Keith Busch
On Sun, May 12, 2019 at 08:54:15AM -0700, Akinobu Mita wrote: > +static void nvme_coredump_logs(struct nvme_dev *dev) > +{ > + struct dev_coredumpm_bulk_data *bulk_data; > + > + if (!dev->dumps) > + return; > + > + bulk_data = nvme_coredump_alloc(dev, 1); > + if

Re: [PATCH v8 09/12] mm/sparsemem: Support sub-section hotplug

2019-05-13 Thread Oscar Salvador
On Mon, May 06, 2019 at 04:40:14PM -0700, Dan Williams wrote: > > +void subsection_mask_set(unsigned long *map, unsigned long pfn, > + unsigned long nr_pages) > +{ > + int idx = subsection_map_index(pfn); > + int end = subsection_map_index(pfn + nr_pages - 1); > + > +

Re: [RFC PATCH 0/7] sched/cpufreq: Make schedutil energy aware

2019-05-13 Thread Douglas Raillard
Hi Viresh, Rafael, On 5/13/19 8:12 AM, Viresh Kumar wrote: On Wed, May 8, 2019 at 11:57 PM wrote: From: Douglas RAILLARD Make schedutil cpufreq governor energy-aware. Hi Douglas, I was wondering on why the cpufreq maintainers weren't cc'd for this set and then I noticed that

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Keith Busch
On Sat, May 11, 2019 at 11:06:35PM -0700, Chaitanya Kulkarni wrote: > On 5/10/19 2:35 PM, Keith Busch wrote: > > > > +int nvme_set_power(struct nvme_ctrl *ctrl, unsigned ps) > dev->ctrl.npss is u8 can we use same data type here ? > If this is due to last_ps we use as a result and then call

Re: [PATCH] serial: sh-sci: disable DMA for uart_console

2019-05-13 Thread Wolfram Sang
On Thu, May 09, 2019 at 10:43:30AM -0400, George G. Davis wrote: > As noted in commit 84b40e3b57ee ("serial: 8250: omap: Disable DMA for > console UART"), UART console lines use low-level PIO only access functions > which will conflict with use of the line when DMA is enabled, e.g. when > the

Re: [PATCH 2/3 v5] add a new template field buf to contain the buffer

2019-05-13 Thread Roberto Sassu
On 5/11/2019 12:37 AM, Prakhar Srivastava wrote: From: Prakhar Srivastava The buffer(cmdline args) added to the ima log cannot be attested without having the actual buffer. Thus to make the measured buffer available to stroe/read a new ima temaplate (buf) is added. Hi Prakhar please fix the

Re: Hardware-accelerated video decoders used through a firmware instead of hardware registers

2019-05-13 Thread Philipp Zabel
Hi, On Sun, 2019-05-12 at 18:32 +0200, Paul Kocialkowski wrote: [...] > I would be curious to know what the situation is on the i.MX6 coda > block, which also seems pretty obscure. FWIW, I had started collecting things I learned about the BIT processor in the CODA IP cores, mostly by looking at

[PATCH v4 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented.

2019-05-13 Thread Vandana BN
This patch resloves below warnings reported by checkpath in kpc_dma WARNING: Missing a blank line after declarations WARNING: labels should not be indented CHECK: Please don't use multiple blank lines CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by:

Re: [PATCH -next v2] mm/hotplug: fix a null-ptr-deref during NUMA boot

2019-05-13 Thread Qian Cai
On Mon, 2019-05-13 at 14:41 +0200, Michal Hocko wrote: > On Sun 12-05-19 01:48:29, Qian Cai wrote: > > The linux-next commit ("x86, numa: always initialize all possible > > nodes") introduced a crash below during boot for systems with a > > memory-less node. This is due to CPUs that get onlined

[PATCH v4 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch.

2019-05-13 Thread Vandana BN
This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit

[PATCH v4 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation

2019-05-13 Thread Vandana BN
This Patch resolves unnecessary cast warning and const file_operations reported by checkpath.pl WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject

[PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.

2019-05-13 Thread Vandana BN
This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split

[PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{','!' and open paranthesis '('.

2019-05-13 Thread Vandana BN
This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit

[PATCH v4 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch.

2019-05-13 Thread Vandana BN
This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message

[PATCH v4 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations reported by checkpatch.

2019-05-13 Thread Vandana BN
This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be "foo __exit bar" Signed-off-by: Vandana BN --- v2 - split changes to multiple

[PATCH v4 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

2019-05-13 Thread Vandana BN
Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++---

Re: [PATCH v2 0/7] Add new tracepoints required for EAS testing

2019-05-13 Thread Qais Yousef
On 05/13/19 14:28, Peter Zijlstra wrote: > > > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index c8c7c7efb487..11555f95a88e 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -594,6 +594,23 @@

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-13 Thread Keith Busch
On Sat, May 11, 2019 at 12:22:58AM -0700, Christoph Hellwig wrote: > A couple nitpicks, mostly leftover from the previous iteration > (I didn't see replies to those comments from you, despite seeing > a reply to my mail, assuming it didn't get lost): I thought you just meant the freeze/unfreeze

Re: [GIT PULL REQUEST] watchdog - v5.2 Merge window

2019-05-13 Thread pr-tracker-bot
The pull request you sent on Mon, 13 May 2019 12:48:55 +0200: > git://www.linux-watchdog.org/linux-watchdog.git tags/linux-watchdog-5.2-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55472bae5331f33582d9f0e8919fed8bebcda0da Thank you! -- Deet-doot-dot, I am a

Re: test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4

2019-05-13 Thread Hans Verkuil
On 5/13/19 3:32 PM, Naresh Kamboju wrote: > Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4 > kernel branches ? Probably related to commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields in s_parm). Regards, Hans > > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK

<    1   2   3   4   5   6   7   8   >