[PATCH] mfd: stmfx.h: typo in the header guard

2019-06-23 Thread Denis Efremov
The guard macro MFX_STMFX_H in the header stmfx.h doesn't match the #ifndef macro MFD_STMFX_H. The patch fixes the typo. Signed-off-by: Denis Efremov --- include/linux/mfd/stmfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/stmfx.h

Re: [PATCH V7 2/3] PCI: dwc: Cleanup DBI,ATU read and write APIs

2019-06-23 Thread Vidya Sagar
On 6/23/2019 1:17 PM, Jingoo Han wrote: On 6/23/19, 1:52 AM, Vidya Sagar wrote: Cleanup DBI read and write APIs by removing "__" (underscore) from their names as there are no no-underscore versions and the underscore versions are already doing what no-underscore versions typically do. It also

stmmac regression on ASUS TinkerBoard

2019-06-23 Thread Katsuhiro Suzuki
Hello stmmac maintainers, I found this commit and that has some regressions: 74371272f97f net: stmmac: Convert to phylink and remove phylib logic My environment is: - ASUS TinkerBoard - SoC is RK3288 - Using STMMAC driver drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c - Using

Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT

2019-06-23 Thread Masahiro Yamada
On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada wrote: > > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice > with different values, which is pointless and confusing. > > [1] arch/nios2/Kconfig > > config TRACE_IRQFLAGS_SUPPORT > def_bool n > > [2]

Re: [PATCH v2] powerpc/boot: pass CONFIG options in a simpler and more robust way

2019-06-23 Thread Masahiro Yamada
On Mon, May 13, 2019 at 11:24 PM Masahiro Yamada wrote: > > Commit 5e9dcb6188a4 ("powerpc/boot: Expose Kconfig symbols to wrapper") > was wrong, but commit e41b93a6be57 ("powerpc/boot: Fix build failures > with -j 1") was also wrong. > > The correct dependency is: > > $(obj)/serial.o:

Re: [PATCH v2] powerpc/mm: mark more tlb functions as __always_inline

2019-06-23 Thread Masahiro Yamada
On Tue, May 21, 2019 at 10:19 PM Masahiro Yamada wrote: > > With CONFIG_OPTIMIZE_INLINING enabled, Laura Abbott reported error > with gcc 9.1.1: > > arch/powerpc/mm/book3s64/radix_tlb.c: In function '_tlbiel_pid': > arch/powerpc/mm/book3s64/radix_tlb.c:104:2: warning: asm operand 3 probably

[GIT PULL] auxdisplay for v5.2-rc7

2019-06-23 Thread Miguel Ojeda
Hi Linus, A cleanup that was in -next for several weeks (before I added an Ack). It is late in the cycle, so pick it up if you feel like it! Cheers, Miguel The following changes since commit 9e0babf2c06c73cda2c0cd37a1653d823adb40ec: Linux 5.2-rc5 (2019-06-16 08:49:45 -1000) are available in

Re: [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board

2019-06-23 Thread Katsuhiro Suzuki
Hello Heiko, Andrew, Thank you for comments. I found the commit that has regression: 74371272f97f net: stmmac: Convert to phylink and remove phylib logic So I'll report it to netdev and stmmac guys. Best Regards, --- Katsuhiro Suzuki On 2019/06/23 2:55, Andrew Lunn wrote: On Sat, Jun 22,

[patch 02/29] x86/hpet: Replace printk(KERN...) with pr_...()

2019-06-23 Thread Thomas Gleixner
And sanitize the format strings while at it. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 45 +++-- 1 file changed, 19 insertions(+), 26 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -20,6 +20,9 @@ #include

[patch 01/29] x86/hpet: Simplify CPU online code

2019-06-23 Thread Thomas Gleixner
The indirection via work scheduled on the upcoming CPU was necessary with the old hotplug code because the online callback was invoked on the control CPU not on the upcoming CPU. The rework of the CPU hotplug core guarantees that the online callbacks are invoked on the upcoming CPU. Remove the

[patch 11/29] x86/hpet: Separate counter check out of clocksource register code

2019-06-23 Thread Thomas Gleixner
The init code checks whether the HPET counter works late in the init function when the clocksource is registered. That should happen right with the other sanity checks. Split it into a separate validation function and move it to the other sanity checks. Signed-off-by: Thomas Gleixner ---

[patch 09/29] x86/hpet: Move static and global variables to one place

2019-06-23 Thread Thomas Gleixner
Having static and global variables sprinkled all over the code is just annoying to read. Move them all to the top of the file. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 50 + 1 file changed, 22 insertions(+), 28 deletions(-)

[patch 21/29] x86/hpet: Add function to select a /dev/hpet channel

2019-06-23 Thread Thomas Gleixner
If CONFIG_HPET=y is enabled the x86 specific HPET code should reserve at least one channel for the /dev/hpet character device, so that not all channels are absorbed for per CPU clockevent devices. Create a function to assign HPET_MODE_DEVICE so the rework of the clockevents allocation code can

[patch 06/29] x86/hpet: Remove the unused hpet_msi_read() function

2019-06-23 Thread Thomas Gleixner
No users. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/hpet.h |1 - arch/x86/kernel/hpet.c |7 --- 2 files changed, 8 deletions(-) --- a/arch/x86/include/asm/hpet.h +++ b/arch/x86/include/asm/hpet.h @@ -81,7 +81,6 @@ struct irq_domain; extern void

[patch 25/29] x86/hpet: Wrap legacy clockevent in hpet_channel

2019-06-23 Thread Thomas Gleixner
For HPET channel 0 there exist two clockevent structures right now: - the static hpet_clockevent - the clockevent in channel 0 storage The goal is to use the clockevent in the channel storage, remove the static variable and share code with the MSI implementation. As a first step wrap the

[patch 14/29] x86/hpet: Remove not required includes

2019-06-23 Thread Thomas Gleixner
From: Ingo Molnar Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -1,22 +1,12 @@ // SPDX-License-Identifier: GPL-2.0-only

[patch 05/29] x86/hpet: Remove unused parameter from hpet_next_event()

2019-06-23 Thread Thomas Gleixner
The clockevent device pointer is not used in this function. While at it, rename the misnamed 'timer' parameter to 'channel', which makes it clear what this parameter means. No functional change. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 10 +- 1 file changed, 5

[patch 12/29] x86/hpet: Simplify counter validation

2019-06-23 Thread Thomas Gleixner
There is no point to loop for 200k TSC cycles to check afterwards whether the HPET counter is working. Read the counter inside of the loop and break out when the counter value changed. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 10 -- 1 file changed, 4 insertions(+),

[patch 07/29] x86/hpet: Mark init functions __init

2019-06-23 Thread Thomas Gleixner
They are only called from init code. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -176,7 +176,7 @@ do {

[patch 00/29] x86/hpet: Cleanup the channel management

2019-06-23 Thread Thomas Gleixner
When reviewing the HPET NMI watchdog series, I stared into the HPET code and the proposed changes. The latter try to add yet another layer of duct tape and ifdeffery to the existing maze. No, thanks. The following series cleans up the channel management and consolidates all state storage into a

[patch 08/29] x86/hpet: Sanitize stub functions

2019-06-23 Thread Thomas Gleixner
Mark them inline and remove the pointless 'return;' statement. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -692,16 +692,10 @@ static int

[patch 04/29] x86/hpet: Remove pointless x86-64 specific #include

2019-06-23 Thread Thomas Gleixner
Nothing requires asm/pgtable.h here anymore. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c |4 1 file changed, 4 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -71,10 +71,6 @@ static inline void hpet_writel(unsigned writel(d,

[patch 03/29] x86/hpet: Restructure init code

2019-06-23 Thread Thomas Gleixner
As a preparatory change for further consolidation, restructure the HPET init code so it becomes more readable. Fix up misleading and stale comments and rename variables so they actually make sense. No intended functional change. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 81

[patch 23/29] x86/hpet: Move clockevents into channels

2019-06-23 Thread Thomas Gleixner
Instead of allocating yet another data structure, move the clock event data into the channel structure. This allows further consolidation of the reservation code and the reuse of the cached boot config to replace the extra flags in the clockevent data. Signed-off-by: Thomas Gleixner ---

[patch 27/29] x86/hpet: Carve out shareable parts of init_one_hpet_msi_clockevent()

2019-06-23 Thread Thomas Gleixner
To finally remove the static channel0/clockevent storage and to utilize the channel 0 storage in hpet_base, it's required to run time initialize the clockevent. The MSI clockevents already have a run time init function. Carve out the parts which can be shared between the legacy and the MSI

[patch 22/29] x86/hpet: Rename variables to prepare for switching to channels

2019-06-23 Thread Thomas Gleixner
From: Ingo Molnar struct hpet_dev is gone with the next change as the clockevent storage moves into struct hpet_channel. So the variable name hdev will not make sense anymore. Ditto for timer vs. channel and similar details. Doing the rename in the change makes the patch harder to review. Doing

[patch 20/29] x86/hpet: Add mode information to struct hpet_channel

2019-06-23 Thread Thomas Gleixner
The usage of the individual HPET channels is not tracked in a central place. The information is scattered in different data structures. Also the HPET reservation in the HPET character device is split out into several places which makes the code hard to follow. Assigning a mode to the channel

[patch 19/29] x86/hpet: Use cached channel data

2019-06-23 Thread Thomas Gleixner
Instead of rereading the HPET registers over and over use the information which was cached in hpet_enable(). Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) ---

[patch 24/29] x86/hpet: Use cached info instead of extra flags

2019-06-23 Thread Thomas Gleixner
Now that HPET clockevent support is integrated into the channel data, reuse the cached boot configuration instead of copying the same information into a flags field. This also allows to consolidate the reservation code into one place, which can now solely depend on the mode information.

[patch 10/29] x86/hpet: Shuffle code around for readability sake

2019-06-23 Thread Thomas Gleixner
It doesn't make sense to have init functions in the middle of other code. Aside of that, further changes in that area create horrible diffs if the code stays where it is. No functional change Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 81

[patch 16/29] x86/hpet: Clean up comments

2019-06-23 Thread Thomas Gleixner
From: Ingo Molnar Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -266,8 +266,8 @@ static void

[patch 17/29] x86/hpet: Coding style cleanup

2019-06-23 Thread Thomas Gleixner
From: Ingo Molnar Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c @@ -131,26 +131,33 @@

[patch 13/29] x86/hpet: Decapitalize and rename EVT_TO_HPET_DEV

2019-06-23 Thread Thomas Gleixner
It's a function not a macro and the upcoming changes use channel for the individual hpet timer units to allow a step by step refactoring approach. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) ---

[patch 29/29] x86/hpet: Use channel for legacy clockevent storage

2019-06-23 Thread Thomas Gleixner
All preparations are done. Use the channel storage for the legacy clockevent and remove the static variable. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c

[patch 18/29] x86/hpet: Introduce struct hpet_base and struct hpet_channel

2019-06-23 Thread Thomas Gleixner
Introduce new data structures to replace the ad hoc collection of separate variables and pointers. Replace the boot configuration store and restore as a first step. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 84 - 1 file

[patch 28/29] x86/hpet: Use common init for legacy clockevent

2019-06-23 Thread Thomas Gleixner
Replace the static initialization of the legacy clockevent with runtime initialization utilizing the common init function as the last preparatory step to switch the legacy clockevent over to the channel 0 storage in hpet_base. This comes with a twist. The static clockevent initializer has

[patch 26/29] x86/hpet: Consolidate clockevent functions

2019-06-23 Thread Thomas Gleixner
Now that the legacy clockevent is wrapped in a hpet_channel struct most clockevent functions can be shared between the legacy and the MSI based clockevents. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 92 + 1 file changed, 25

[patch 15/29] x86/hpet: Make naming consistent

2019-06-23 Thread Thomas Gleixner
From: Ingo Molnar Use 'evt' for clockevents pointers and capitalize HPET in comments. Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner --- arch/x86/kernel/hpet.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) --- a/arch/x86/kernel/hpet.c +++

Re: [PATCH] x86/vdso: Give the [ph]vclock_page declarations real types

2019-06-23 Thread Thomas Gleixner
On Sun, 23 Jun 2019, Linus Torvalds wrote: > Andy added comments and changed the patch in other ways too, so I think > it's fine to have him as author, and my sign-off is just for the original > smaller patch. Well, that will earn me a nastigram from the next checkers as it's not compliant to

Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

2019-06-23 Thread Thomas Gleixner
Octavio, On Sat, 22 Jun 2019, Thomas Gleixner wrote: > On Wed, 19 Jun 2019, Octavio Alvarez wrote: > > On 6/13/19 3:45 PM, Thomas Gleixner wrote: > > > Can you please provide the content of /proc/interrupts with the driver > > > loaded and working after boot (don't hibernate) for the following

kernel BUG at arch/x86/mm/physaddr.c:LINE! (3)

2019-06-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15068816a0 kernel config: https://syzkaller.appspot.com/x/.config?x=e5c77f8090a3b96b

WARNING in kernfs_remove_by_name_ns

2019-06-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:abf02e29 Merge tag 'pm-5.2-rc6' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17a6c806a0 kernel config: https://syzkaller.appspot.com/x/.config?x=e5c77f8090a3b96b

Re: [PATCH] x86/vdso: Give the [ph]vclock_page declarations real types

2019-06-23 Thread Thomas Gleixner
On Sat, 22 Jun 2019, Andy Lutomirski wrote: > Clean up the vDSO code a bit by giving pvclock_page and hvclock_page > their actual types instead of u8[PAGE_SIZE]. This shouldn't > materially affect the generated code. > > Heavily based on a patch from Linus. > > Cc: Borislav Petkov > Cc: Peter

Re: [PATCH 0/9] x86: Concurrent TLB flushes and other improvements

2019-06-23 Thread Thomas Gleixner
Nadav, On Wed, 12 Jun 2019, Nadav Amit wrote: > Patch 1 does small cleanup. Patches 2-5 implement the concurrent > execution of TLB flushes. Patches 6-9 deal with false-sharing and > unnecessary atomic operations. There is still no implementation that > uses the concurrent TLB flushes by Xen and

[PATCH RESEND V2 3/3] arm64: dts: imx8mq: Add system counter node

2019-06-23 Thread Anson . Huang
From: Anson Huang Add i.MX8MQ system counter node to enable timer-imx-sysctr broadcast timer driver. Signed-off-by: Anson Huang --- No change. --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi

[PATCH RESEND V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property

2019-06-23 Thread Anson . Huang
From: Anson Huang Systems which use platform driver model for clock driver require the clock frequency to be supplied via device tree when system counter driver is enabled. This is necessary as in the platform driver model the of_clk operations do not work correctly because system counter

WARNING: bad unlock balance in rcu_lock_release

2019-06-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:bed3c0d8 Merge tag 'for-5.2-rc5-tag' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148ef681a0 kernel config: https://syzkaller.appspot.com/x/.config?x=28ec3437a5394ee0

[PATCH RESEND V2 2/3] clocksource: imx-sysctr: Make timer work with clock driver using platform driver model

2019-06-23 Thread Anson . Huang
From: Anson Huang On some i.MX8M platforms, clock driver uses platform driver model and it is NOT ready during timer initialization phase, the clock operations will fail and system counter driver will fail too. As all the i.MX8M platforms' system counter clock are from OSC which is always

[tip:smp/hotplug] smp: Remove smp_call_function() and on_each_cpu() return values

2019-06-23 Thread tip-bot for Nadav Amit
Commit-ID: caa759323c73676b3e48c8d9c86093c88b4aba97 Gitweb: https://git.kernel.org/tip/caa759323c73676b3e48c8d9c86093c88b4aba97 Author: Nadav Amit AuthorDate: Wed, 12 Jun 2019 23:48:05 -0700 Committer: Thomas Gleixner CommitDate: Sun, 23 Jun 2019 14:26:26 +0200 smp: Remove

[tip:smp/hotplug] smp: Do not mark call_function_data as shared

2019-06-23 Thread tip-bot for Nadav Amit
Commit-ID: a22793c79d6ea0a492ce1a308ec46df52ee9406e Gitweb: https://git.kernel.org/tip/a22793c79d6ea0a492ce1a308ec46df52ee9406e Author: Nadav Amit AuthorDate: Wed, 12 Jun 2019 23:48:11 -0700 Committer: Thomas Gleixner CommitDate: Sun, 23 Jun 2019 14:26:25 +0200 smp: Do not mark

[PATCH] iio: srf04: fix wrong limitation in distance measuring

2019-06-23 Thread Andreas Klinger
The measured time value in the driver is limited to the maximum distance which can be read by the sensor. This limitation was wrong and is fixed by this patch. It also takes into account that we are supporting a variety of sensors today and that the recently added sensors have a higher maximum

RE: [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option

2019-06-23 Thread Anson Huang
Hi, Thomas > On Sun, 23 Jun 2019, anson.hu...@nxp.com wrote: > > Again the short summary could be more informative. Instead of 'Add foo' > you could say: > > .: Make timer work with platform driver model > > That sums up the real meat of the patch. 'Add some option' is pretty >

[tip:x86/apic] x86/apic: Use non-atomic operations when possible

2019-06-23 Thread tip-bot for Nadav Amit
Commit-ID: dde3626f815e38bbf96fddd5185038c4b4d395a8 Gitweb: https://git.kernel.org/tip/dde3626f815e38bbf96fddd5185038c4b4d395a8 Author: Nadav Amit AuthorDate: Wed, 12 Jun 2019 23:48:13 -0700 Committer: Thomas Gleixner CommitDate: Sun, 23 Jun 2019 14:07:23 +0200 x86/apic: Use

Re: [PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option

2019-06-23 Thread Thomas Gleixner
On Sun, 23 Jun 2019, anson.hu...@nxp.com wrote: Again the short summary could be more informative. Instead of 'Add foo' you could say: .: Make timer work with platform driver model That sums up the real meat of the patch. 'Add some option' is pretty uninformative. > On some i.MX8M

Re: [PATCH] ftrace: add simple oneshot function tracer

2019-06-23 Thread Thomas Preisner
On Mon, Jun 17, 2019 at 08:16:27PM -0400, Steven Rostedt wrote: > On Wed, 12 Jun 2019 23:29:35 +0200 > Thomas Preisner wrote: > > Hi Thomas, > > BTW, what email client do you use, because your replies seem to confuse > my email client (claws-mail) and it doesn't thread them at all. > Although

RE: [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property

2019-06-23 Thread Anson Huang
Hi, Thomas > Anson, > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > >

[PATCH V2 2/3] clocksource: imx-sysctr: Add of_clk skip option

2019-06-23 Thread Anson . Huang
From: Anson Huang On some i.MX8M platforms, clock driver uses platform driver model and it is NOT ready during timer initialization phase, the clock operations will fail and system counter driver will fail too. As all the i.MX8M platforms' system counter clock are from OSC which is always

[PATCH V2 1/3] clocksource/drivers/sysctr: Add optional clock-frequency property

2019-06-23 Thread Anson . Huang
From: Anson Huang Systems which use platform driver model for clock driver require the clock frequency to be supplied via device tree when system counter driver is enabled. This is necessary as in the platform driver model the of_clk operations do not work correctly because system counter

[PATCH V2 3/3] arm64: dts: imx8mq: Add system counter node

2019-06-23 Thread Anson . Huang
From: Anson Huang Add i.MX8MQ system counter node to enable timer-imx-sysctr broadcast timer driver. Signed-off-by: Anson Huang --- No change. --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi

Re: [PATCH] x86: tls: fix possible spectre-v1 in do_get_thread_area()

2019-06-23 Thread Thomas Gleixner
On Tue, 11 Jun 2019, Dianzhang Chen wrote: Subject prefix is 'x86/tls:' please. > The idx in do_get_thread_area() is controlled by userspace The idx? Please to not variable names in the change log. The variable name is an implementation detail. The index to access the threads tls array is

Re: [PATCH] x86: fix possible spectre-v1 in ptrace_get_debugreg()

2019-06-23 Thread Thomas Gleixner
On Fri, 24 May 2019, Dianzhang Chen wrote: > Subject : [PATCH] x86: fix possible spectre-v1 in ptrace_get_debugreg() Please use the proper prefix. Run git log on the file and you'll find it. Also please start the short summary sentence after the prefix with an upper case letter. > The n in

Re: [RFC 0/2] Add workaround for core wake-up on IPI for i.MX8MQ

2019-06-23 Thread Martin Kepplinger
On 10.06.19 14:13, Abel Vesa wrote: > This is another alternative for the RFC: > https://lkml.org/lkml/2019/3/27/545 > > This new workaround proposal is a little bit more hacky but more contained > since everything is done within the irq-imx-gpcv2 driver. > > Basically, it 'hijacks' the

Re: [PATCH] x86: fix possible spectre-v1 in do_get_thread_area()

2019-06-23 Thread Thomas Gleixner
On Fri, 24 May 2019, Dianzhang Chen wrote: > The idx in do_get_thread_area() is controlled by userspace via syscall: > ptrace(defined in kernel/ptrace.c), hence leading to a potential exploitation > of the Spectre variant 1 vulnerability. > The idx can be controlled from: ptrace -> arch_ptrace

RE: [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property

2019-06-23 Thread Thomas Gleixner
Anson, A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, 23 Jun 2019,

Re: [PATCH] samples: make pidfd-metadata fail gracefully on older kernels

2019-06-23 Thread Dmitry V. Levin
On Sat, Jun 22, 2019 at 12:13:39AM +0200, Christian Brauner wrote: [...] > Out of curiosity: what makes the new flag different than say > CLONE_NEWCGROUP or any new clone flag that got introduced? > CLONE_NEWCGROUP too would not be detectable apart from the method I gave > you above; same for

RE: [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property

2019-06-23 Thread Anson Huang
Hi, Thomas Thanks for the useful comment, I will resend the patch with improvement. Anson. > -Original Message- > From: Thomas Gleixner > Sent: Sunday, June 23, 2019 6:47 PM > To: Anson Huang > Cc: daniel.lezc...@linaro.org; robh...@kernel.org; mark.rutl...@arm.com; >

RE: [PATCH 3/3] arm64: dts: imx8mq: Add system counter node

2019-06-23 Thread Anson Huang
> -Original Message- > From: Martin Kepplinger > Sent: Sunday, June 23, 2019 7:21 PM > To: Anson Huang ; daniel.lezc...@linaro.org; > t...@linutronix.de; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; > feste...@gmail.com;

Re: [PATCH] x86/mm: Handle physical-virtual alignment mismatch in phys_p4d_init()

2019-06-23 Thread Thomas Gleixner
On Fri, 21 Jun 2019, Kirill A. Shutemov wrote: > On Thu, Jun 20, 2019 at 02:42:55PM +, Dave Hansen wrote: > > On 6/20/19 4:22 AM, Kirill A. Shutemov wrote: > > > The commit relaxes KASLR alignment requirements and it can lead to > > > mismatch bentween 'i' and 'p4d_index(vaddr)' inside the

[PATCH 2/2] samples: make pidfd-metadata fail gracefully on older kernels

2019-06-23 Thread Dmitry V. Levin
Initialize pidfd to an invalid descriptor, to fail gracefully on those kernels that do not implement CLONE_PIDFD and leave pidfd unchanged. Signed-off-by: Dmitry V. Levin --- samples/pidfd/pidfd-metadata.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] CLONE_PIDFD: do not use the value pointed by parent_tidptr

2019-06-23 Thread Dmitry V. Levin
Userspace needs a cheap and reliable way to tell whether CLONE_PIDFD is supported by the kernel or not. While older kernels without CLONE_PIDFD support just leave unchanged the value pointed by parent_tidptr, current implementation fails with EINVAL if that value is non-zero. If CLONE_PIDFD is

RE: [PATCH 3/3] arm64: dts: imx8mq: Add system counter node

2019-06-23 Thread Anson Huang
Hi, Martin > -Original Message- > From: Martin Kepplinger > Sent: Saturday, June 22, 2019 10:16 PM > To: Anson Huang ; daniel.lezc...@linaro.org; > t...@linutronix.de; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; >

Re: [PATCH 3/3] arm64: dts: imx8mq: Add system counter node

2019-06-23 Thread Martin Kepplinger
On 22.06.19 16:16, Martin Kepplinger wrote: > On 21.06.19 10:28, anson.hu...@nxp.com wrote: >> From: Anson Huang >> >> Add i.MX8MQ system counter node to enable timer-imx-sysctr >> broadcast timer driver. > > with these changes and TIMER_IMX_SYS_CTR selected, I don't see cpuidle > working yet

RE: [PATCH 4/4] arm64: dts: imx8mm: Add system counter node

2019-06-23 Thread Anson Huang
Hi, Martin > -Original Message- > From: Martin Kepplinger > Sent: Saturday, June 22, 2019 8:10 PM > To: Anson Huang ; catalin.mari...@arm.com; > w...@kernel.org; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker...@pengutronix.de; >

Re: [PATCH v2] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline

2019-06-23 Thread Thomas Gleixner
On Tue, 11 Jun 2019, Anders Roxell wrote: > With the function graph tracer, each traced function calls sched_clock() > to take a timestamp. As sched_clock() uses > raw_read_seqcount()/read_seqcount_retry(), we must ensure that these > do not in turn trigger the graph tracer. > Both functions is

Re: [PATCH V34 20/29] x86/mmiotrace: Lock down the testmmiotrace module

2019-06-23 Thread Thomas Gleixner
On Fri, 21 Jun 2019, Matthew Garrett wrote: > From: David Howells > > The testmmiotrace module shouldn't be permitted when the kernel is locked > down as it can be used to arbitrarily read and write MMIO space. This is > a runtime check rather than buildtime in order to allow configurations

Re: [PATCH v3 1/2] x86/vdso: Move mult and shift into struct vgtod_ts

2019-06-23 Thread Thomas Gleixner
Alexander, On Wed, 5 Jun 2019, Sverdlin, Alexander (Nokia - DE/Ulm) wrote: > From: Alexander Sverdlin > > This is a preparation for CLOCK_MONOTONIC_RAW vDSO implementation. > Coincidentally it had a slight performance improvement as well: > > Test code > #include > #include >

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-06-23 Thread Brian Masney
Hi Stephen and Thierry, On Fri, May 31, 2019 at 12:51:38PM +0200, Linus Walleij wrote: > On Wed, May 29, 2019 at 12:12 PM Brian Masney wrote: > > > My first revision of this vibrator driver used the Linux PWM framework > > due to the variable duty cycle: > > So what I perceive if I get the

Re: Kernel touch Kconfig consult

2019-06-23 Thread Marek Vasut
On 6/23/19 9:02 AM, Dmitry Torokhov wrote: > Hi, > > On Fri, Jun 14, 2019 at 06:47:19AM -0400, luhua.xu wrote: >> Hi Dmitry,Rob,Marek, Nick,Richard,Martin, >> >> In our customer support experience, many smartphone have two or three >> touch vendor mixture , and customer use one load to support

Re: [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property

2019-06-23 Thread Thomas Gleixner
Anson, On Fri, 21 Jun 2019, anson.hu...@nxp.com wrote: > Subject : [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property That subject line is not really informative. From Documentation: The ``summary phrase`` in the email's Subject should concisely describe the patch which

KMSAN: uninit-value in gre_parse_header

2019-06-23 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:088c01ea kmsan: fix comment, NFC git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=15efc16320 kernel config: https://syzkaller.appspot.com/x/.config?x=68044283f8b8640d dashboard link:

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-23 Thread Michael Ellerman
On Thu, 2019-06-13 at 08:24:46 UTC, Christoph Hellwig wrote: > With the strict dma mask checking introduced with the switch to > the generic DMA direct code common wifi chips on 32-bit powerbooks > stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds > to allow them to reliably

[tip:timers/core] timer_list: Guard procfs specific code

2019-06-23 Thread tip-bot for Nathan Huckleberry
Commit-ID: a9314773a91a1d3b36270085246a6715a326ff00 Gitweb: https://git.kernel.org/tip/a9314773a91a1d3b36270085246a6715a326ff00 Author: Nathan Huckleberry AuthorDate: Fri, 14 Jun 2019 11:16:04 -0700 Committer: Thomas Gleixner CommitDate: Sun, 23 Jun 2019 00:08:52 +0200 timer_list:

Re: [PATCH v4 3/5] net: macb: add support for c45 PHY

2019-06-23 Thread Russell King - ARM Linux admin
On Sun, Jun 23, 2019 at 10:23:17AM +0100, Parshuram Thombare wrote: > This patch modify MDIO read/write functions to support > communication with C45 PHY. Which Clause 45 PHY are you using? > > Signed-off-by: Parshuram Thombare > --- > drivers/net/ethernet/cadence/macb.h | 15 -- >

Re: [PATCH v4 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-23 Thread Russell King - ARM Linux admin
On Sun, Jun 23, 2019 at 10:23:01AM +0100, Parshuram Thombare wrote: > This patch add support for SGMII interface) and > 2.5Gbps MAC in Cadence ethernet controller driver. > > Signed-off-by: Parshuram Thombare > --- > drivers/net/ethernet/cadence/macb.h | 54 >

Re: [PATCH v4 1/5] net: macb: add phylink support

2019-06-23 Thread Russell King - ARM Linux admin
On Sun, Jun 23, 2019 at 10:17:37AM +0100, Parshuram Thombare wrote: > + switch (state->interface) { > + case PHY_INTERFACE_MODE_GMII: > + case PHY_INTERFACE_MODE_RGMII: > + if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) { > + phylink_set(mask,

Re: WARNING in debug_check_no_obj_freed

2019-06-23 Thread syzbot
syzbot has bisected this bug to: commit 99182beed858a1bde22f60046602b9b223225f73 Author: Daniel Borkmann Date: Tue Apr 2 21:17:19 2019 + Merge branch 'bpf-selftest-clang-fixes' bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12faf81aa0 start commit: bed3c0d8 Merge

Re: [PATCH 3/3] tools: memory-model: Improve data-race detection

2019-06-23 Thread Akira Yokosawa
Hi Paul and Alan, On 2019/06/22 8:54, Paul E. McKenney wrote: > On Fri, Jun 21, 2019 at 10:25:23AM -0400, Alan Stern wrote: >> On Fri, 21 Jun 2019, Andrea Parri wrote: >> >>> On Thu, Jun 20, 2019 at 11:55:58AM -0400, Alan Stern wrote: Herbert Xu recently reported a problem concerning RCU and

[PATCH v4 5/5] net: macb: parameter added to cadence ethernet controller DT binding

2019-06-23 Thread Parshuram Thombare
New parameters added to Cadence ethernet controller DT binding for USXGMII interface. Signed-off-by: Parshuram Thombare --- Documentation/devicetree/bindings/net/macb.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt

[PATCH v4 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-23 Thread Parshuram Thombare
This patch add support for SGMII interface) and 2.5Gbps MAC in Cadence ethernet controller driver. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 54 drivers/net/ethernet/cadence/macb_main.c | 80 +--- 2 files changed, 112

[PATCH v4 4/5] net: macb: add support for high speed interface

2019-06-23 Thread Parshuram Thombare
This patch add support for high speed USXGMII PCS and 10G speed in Cadence ethernet controller driver. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 41 + drivers/net/ethernet/cadence/macb_main.c | 194 +++ 2 files changed, 207

[PATCH v4 3/5] net: macb: add support for c45 PHY

2019-06-23 Thread Parshuram Thombare
This patch modify MDIO read/write functions to support communication with C45 PHY. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 15 -- drivers/net/ethernet/cadence/macb_main.c | 61 +++- 2 files changed, 61 insertions(+), 15

[PATCH v4 1/5] net: macb: add phylink support

2019-06-23 Thread Parshuram Thombare
This patch replace phylib API's by phylink API's. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/Kconfig | 2 +- drivers/net/ethernet/cadence/macb.h | 3 + drivers/net/ethernet/cadence/macb_main.c | 304 --- 3 files changed, 166

[PATCH v4 0/5] net: macb: cover letter

2019-06-23 Thread Parshuram Thombare
Hello ! This is 4th version of patch set containing following patches for Cadence ethernet controller driver. 1. 0001-net-macb-add-phylink-support.patch Replace phylib API's with phylink API's. 2. 0002-net-macb-add-support-for-sgmii-MAC-PHY-interface.patch This patch add support for SGMII

Re: [PATCH 1/2] Input: edt-ft5x06 - use get_unaligned_be16()

2019-06-23 Thread Andy Shevchenko
On Sun, Jun 23, 2019 at 9:31 AM Dmitry Torokhov wrote: > > Instead of doing conversion by hand, let's use the proper accessors. > The code looks fine to me, Reviewed-by: Andy Shevchenko I can test it later next week (Wednesday or so). > Signed-off-by: Dmitry Torokhov > --- >

Re: [PATCH 2/2] Input: edt-ft5x06 - simplify event reporting code

2019-06-23 Thread Andy Shevchenko
On Sun, Jun 23, 2019 at 9:31 AM Dmitry Torokhov wrote: > > Now that input_mt_report_slot_state() returns true if slot is active we no > longer need a temporary for the slot state. > - down = type != TOUCH_EVENT_UP; > > input_mt_slot(tsdata->input, id); > -

Re: [PATCH V7 2/3] PCI: dwc: Cleanup DBI,ATU read and write APIs

2019-06-23 Thread Jingoo Han
On 6/23/19, 1:52 AM, Vidya Sagar wrote: > > Cleanup DBI read and write APIs by removing "__" (underscore) from their > names as there are no no-underscore versions and the underscore versions > are already doing what no-underscore versions typically do. It also removes > passing dbi/dbi2 base

RE: [PATCH V1] scsi: ufs-bsg: complete ufs-bsg job only if no error

2019-06-23 Thread Avri Altman
Hi Bean, Thank you for fixing this. > From: Bean Huo > > In the case of UPIU/DME request execution failed in UFS device, > ufs_bsg_request() will complete this failed bsg job by calling > bsg_job_done(). Meanwhile, it returns this error status to blk-mq > layer, then trigger blk-mq complete

Re: [PATCH v4 2/2] arm64: dts: imx8mm-evk: Enable audio codec wm8524

2019-06-23 Thread Shawn Guo
On Tue, Jun 04, 2019 at 08:32:57PM +0800, daniel.bal...@nxp.com wrote: > From: Daniel Baluta > > i.MX8MM has one wm8524 audio codec connected with > SAI3 digital audio interface. > > This patch uses simple-card machine driver in order > to enable wm8524 codec. > > We need to set: > *

Re: [PATCH v1] Input: rotary-encoder - Add gpio as push button

2019-06-23 Thread Dmitry Torokhov
On Fri, Jun 14, 2019 at 04:51:58PM +0200, Maxime Ripard wrote: > Hi Mylene, > > On Fri, Jun 14, 2019 at 03:36:51PM +0200, Mylène Josserand wrote: > > Add the support of a gpio that can be defined as a push button. > > Thanks to that, it is possible to emit a keycode in case of a > > "push" event,

Re: [PATCH v2] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

2019-06-23 Thread Atish Patra
On 6/21/19 6:57 PM, Troy Benjegerdes wrote: On Jun 21, 2019, at 7:33 PM, Troy Benjegerdes wrote: On Jun 21, 2019, at 4:59 PM, Atish Patra wrote: On Fri, 2019-06-21 at 14:46 -0700, Atish Patra wrote: On Fri, 2019-06-21 at 14:18 -0500, Troy Benjegerdes wrote: Can you post the fsbl and

<    1   2   3   4   5   >