Re: [PATCH v1 1/6] mm: Adjust shuffle code to allow for future coalescing

2019-06-28 Thread Alexander Duyck
On Tue, Jun 25, 2019 at 12:56 AM David Hildenbrand wrote: > > On 20.06.19 00:33, Alexander Duyck wrote: > > From: Alexander Duyck > > > > This patch is meant to move the head/tail adding logic out of the shuffle > > code and into the __free_one_page function since ultimately that is where > > it

Re: [PATCH v2] Convert struct pid count to refcount_t

2019-06-28 Thread Kees Cook
On Fri, Jun 28, 2019 at 03:34:42PM -0400, Joel Fernandes (Google) wrote: > struct pid's count is an atomic_t field used as a refcount. Use > refcount_t for it which is basically atomic_t but does additional > checking to prevent use-after-free bugs. > > For memory ordering, the only change is with

Re: BUG: unable to handle kernel paging request in hrtimer_interrupt

2019-06-28 Thread syzbot
syzbot has bisected this bug to: commit e9db4ef6bf4ca9894bb324c76e01b8f1a16b2650 Author: John Fastabend Date: Sat Jun 30 13:17:47 2018 + bpf: sockhash fix omitted bucket lock in sock_close bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14436833a0 start commit: 29f

Re: [RFC PATCH RT 4/4] rcutorture: Avoid problematic critical section nesting

2019-06-28 Thread Scott Wood
On Thu, 2019-06-27 at 17:52 -0700, Paul E. McKenney wrote: > On Thu, Jun 27, 2019 at 05:46:27PM -0500, Scott Wood wrote: > > On Thu, 2019-06-27 at 13:50 -0700, Paul E. McKenney wrote: > > > If by IPI-to-self you mean the IRQ work trick, that isn't implemented > > > across all architectures yet, is

Re: [PATCH 8/8] sched,fair: flatten hierarchical runqueues

2019-06-28 Thread Rik van Riel
On Fri, 2019-06-28 at 12:26 +0200, Dietmar Eggemann wrote: > On 6/12/19 9:32 PM, Rik van Riel wrote: > > Flatten the hierarchical runqueues into just the per CPU rq.cfs > > runqueue. > > > > Iteration of the sched_entity hierarchy is rate limited to once per > > jiffy > > per sched_entity, which i

[PATCH v2] Convert struct pid count to refcount_t

2019-06-28 Thread Joel Fernandes (Google)
struct pid's count is an atomic_t field used as a refcount. Use refcount_t for it which is basically atomic_t but does additional checking to prevent use-after-free bugs. For memory ordering, the only change is with the following: - if ((atomic_read(&pid->count) == 1) || - atomic_

NFS oops

2019-06-28 Thread bob
Hello.  I know that NFS is undergoing continuing changes and updates and don't know if the oops I'm getting is already on someones todo list.  I run a database archive then  push to a nas box via nfs.  It looks like most of the data arrives, but then the file transfer fails to end. It init

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Joel Fernandes
On Fri, Jun 28, 2019 at 11:22:16AM -0700, Paul E. McKenney wrote: > On Fri, Jun 28, 2019 at 07:45:45PM +0200, Sebastian Andrzej Siewior wrote: > > On 2019-06-28 10:30:11 [-0700], Paul E. McKenney wrote: > > > > I believe the .blocked field remains set even though we are not any > > > > more in a >

Re: [PATCH] mm, vmscan: prevent useless kswapd loops

2019-06-28 Thread Shakeel Butt
On Fri, Jun 28, 2019 at 11:53 AM Yang Shi wrote: > > > > On 6/27/19 6:55 PM, Shakeel Butt wrote: > > On production we have noticed hard lockups on large machines running > > large jobs due to kswaps hoarding lru lock within isolate_lru_pages when > > sc->reclaim_idx is 0 which is a small zone. The

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Joel Fernandes
On Fri, Jun 28, 2019 at 11:52:19AM -0700, Paul E. McKenney wrote: > On Fri, Jun 28, 2019 at 08:40:26PM +0200, Sebastian Andrzej Siewior wrote: > > On 2019-06-28 08:30:50 [-0700], Paul E. McKenney wrote: > > > On Fri, Jun 28, 2019 at 03:54:33PM +0200, Peter Zijlstra wrote: > > > > On Thu, Jun 27, 20

[PATCH v4 1/4] iio: cros_ec: Add sign vector in core for backward compatibility

2019-06-28 Thread Gwendal Grignou
To allow cros_ec iio core library to be used with legacy device, add a vector to rotate sensor data if necessary: legacy devices are not reporting data in HTML5/Android sensor referential. Check the data is not rotated on recent chromebooks that use the HTML5 standard to present sensor data. Sign

[PATCH v4 4/4] iio: cros_ec_accel_legacy: Add support for veyron-minnie

2019-06-28 Thread Gwendal Grignou
Veyron minnie embedded controller presents 2 accelerometers using an older interface. Add function to query the data in cros_ec_accel. Verify accelerometers on veyron-minnie are presented and working. Signed-off-by: Gwendal Grignou --- drivers/iio/accel/cros_ec_accel_legacy.c | 40 +

[PATCH v4 2/4] iio: cros_ec_accel_legacy: Fix incorrect channel setting

2019-06-28 Thread Gwendal Grignou
INFO_SCALE is set both for each channel and all channels. iio is using all channel setting, so the error was not user visible. Signed-off-by: Gwendal Grignou --- drivers/iio/accel/cros_ec_accel_legacy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c

[PATCH v4 3/4] iio: cros_ec_accel_legacy: Use cros_ec_sensors_core

2019-06-28 Thread Gwendal Grignou
Remove duplicate code in cros-ec-accel-legacy, use cros-ec-sensors-core functions and structures when possible. On glimmer, check the 2 accelerometers are presented and working. Signed-off-by: Gwendal Grignou --- drivers/iio/accel/Kconfig| 4 +- drivers/iio/accel/cros_ec_accel

[PATCH v4 0/4] Support accelerometers for veyron_minnie

2019-06-28 Thread Gwendal Grignou
veyron_minnie - ASUS Chromebook Flip C100PA - embedded controller controls two accelerometers, one in the lid, one in the base. However, the EC firmware does not follow the new interface that cros_ec_accel driver use. Extend the legacy driver used on glimmer - Lenovo ThinkPad 11e Chromebook - to ve

Re: [RFC][Patch v10 0/2] mm: Support for page hinting

2019-06-28 Thread Nitesh Narayan Lal
On 6/28/19 2:25 PM, Alexander Duyck wrote: > On Tue, Jun 25, 2019 at 10:32 AM Nitesh Narayan Lal wrote: >> On 6/25/19 1:10 PM, Alexander Duyck wrote: >>> On Tue, Jun 25, 2019 at 7:49 AM Nitesh Narayan Lal >>> wrote: On 6/3/19 2:04 PM, Michael S. Tsirkin wrote: > On Mon, Jun 03, 2019 at

Re: [PATCH net-next v2 06/10] net: stmmac: Do not disable interrupts when cleaning TX

2019-06-28 Thread Willem de Bruijn
On Fri, Jun 28, 2019 at 3:30 AM Jose Abreu wrote: > > This is a performance killer and anyways the interrupts are being > disabled by RX NAPI so no need to disable them again. By the if ((status & handle_rx) && (chan < priv->plat->rx_queues_to_use)) { stmmac_disable_dma_i

Re: [PATCH v3 5/7] sched: SIS_CORE to disable idle core search

2019-06-28 Thread Parth Shah
On 6/27/19 6:59 AM, subhra mazumdar wrote: > Use SIS_CORE to disable idle core search. For some workloads > select_idle_core becomes a scalability bottleneck, removing it improves > throughput. Also there are workloads where disabling it can hurt latency, > so need to have an option. > > Signed

Re: [PATCH] spi: spi-bcm2835.c: Fix 3-wire mode

2019-06-28 Thread Lukas Wunner
On Fri, Jun 28, 2019 at 05:23:54PM +0200, Stefan Wahren wrote: > Am 28.06.19 um 14:30 schrieb Nuno Sá: > > As stated in > > https://www.raspberrypi.org/documentation/hardware/raspberrypi/spi/README.md, > > one of rx or tx buffer's must be null. However, if DMA is enabled, the > > driver sets the SP

Re: memory leak in pppoe_sendmsg

2019-06-28 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:c84afab0 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164241d9a0 kernel config: https://syzkaller.appspot.com/x/.config?x=1db8bd

Re: [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE

2019-06-28 Thread James Smart
On 6/28/2019 5:37 AM, Arnd Bergmann wrote: The lpfc_debug_dump_all_queues() function repeatedly calls into lpfc_debug_dump_qe(), which has a temporary 128 byte buffer. This was fine before the introduction of CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE because each instance could occupy the same stac

Re: [PATCH v2 2/2] iio: cros_ec : Extend legacy support to ARM device

2019-06-28 Thread Gwendal Grignou
On Sat, Jun 22, 2019 at 2:03 AM Jonathan Cameron wrote: > > On Thu, 20 Jun 2019 19:41:06 -0700 > Gwendal Grignou wrote: > > > Add support to ARM based devices, that lack LPC access code. > > Allow cros-ec-accel-legacy to use cros-ec-sensors-core, add specific > > command to capture sensor data. >

Re: [PATCH] mm, vmscan: prevent useless kswapd loops

2019-06-28 Thread Yang Shi
On 6/27/19 6:55 PM, Shakeel Butt wrote: On production we have noticed hard lockups on large machines running large jobs due to kswaps hoarding lru lock within isolate_lru_pages when sc->reclaim_idx is 0 which is a small zone. The lru was couple hundred GiBs and the condition (page_zonenum(page

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 08:40:26PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-06-28 08:30:50 [-0700], Paul E. McKenney wrote: > > On Fri, Jun 28, 2019 at 03:54:33PM +0200, Peter Zijlstra wrote: > > > On Thu, Jun 27, 2019 at 11:41:07AM -0700, Paul E. McKenney wrote: > > > > Or just don't do t

Re: [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE

2019-06-28 Thread Paul Walmsley
On Wed, 24 Apr 2019, damon wrote: > Use the number of addresses to define the relevant macros. > > Signed-off-by: damon This patch looks reasonable to me. But what's missing from the description is the motivation. Is this a prerequisite for another patch that you're planning to post? Or be

Re: [PATCH] tracing/snapshot: resize spare buffer if size changed

2019-06-28 Thread Steven Rostedt
On Tue, 25 Jun 2019 10:29:10 +0900 Eiichi Tsukata wrote: > Current snapshot implementation swaps two ring_buffers even though their > sizes are different from each other, that can cause an inconsistency > between the contents of buffer_size_kb file and the current buffer size. > > For example: >

Re: [PATCH net-next 02/12] net: hns3: enable DCB when TC num is one and pfc_en is non-zero

2019-06-28 Thread Willem de Bruijn
On Fri, Jun 28, 2019 at 7:53 AM Huazhong Tan wrote: > > From: Yunsheng Lin > > Currently when TC num is one, the DCB will be disabled no matter if > pfc_en is non-zero or not. > > This patch enables the DCB if pfc_en is non-zero, even when TC num > is one. > > Signed-off-by: Yunsheng Lin > Signe

Re: [PATCH v3 1/7] sched: limit cpu search in select_idle_cpu

2019-06-28 Thread Parth Shah
On 6/27/19 6:59 AM, subhra mazumdar wrote: > Put upper and lower limit on cpu search of select_idle_cpu. The lower limit > is amount of cpus in a core while upper limit is twice that. This ensures > for any architecture we will usually search beyond a core. The upper limit > also helps in keepin

Re: [PATCH] docs: format kernel-parameters -- as code

2019-06-28 Thread Stephen Kitt
On Fri, 28 Jun 2019 09:10:21 -0600, Jonathan Corbet wrote: > On Thu, 27 Jun 2019 15:59:38 +0200 > > The current ReStructuredText formatting results in "--", used to > > indicate the end of the kernel command-line parameters, appearing as > > an en-dash instead of two hyphens; this patch formats th

Re: [PATCH] mm: fix regression with deferred struct page init

2019-06-28 Thread Michal Hocko
On Fri 28-06-19 19:38:13, Juergen Gross wrote: > On 28.06.19 17:17, Michal Hocko wrote: > > On Thu 20-06-19 18:08:21, Juergen Gross wrote: > > > Commit 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time > > > instead of doing larger sections") is causing a regression on some > > > syste

Re: [PATCH] docs: format kernel-parameters -- as code

2019-06-28 Thread Jonathan Corbet
On Fri, 28 Jun 2019 20:38:41 +0200 Stephen Kitt wrote: > Right, looking further shows a large number of places where -- is handled > incorrectly. The following patch disables this “smart” handling wholesale; > I’ll follow up (in the next few days) with patches to use real em- and > en-dashes wher

Re: [PATCH V33 24/30] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2019-06-28 Thread Matthew Garrett
On Thu, Jun 27, 2019 at 4:27 PM Andy Lutomirski wrote: > They're really quite similar in my mind. Certainly some things in the > "integrity" category give absolutely trivial control over the kernel > (e.g. modules) while others make it quite challenging (ioperm), but > the end result is very simi

Re: [PATCH] perf/x86/intel: Mark expected switch fall-throughs

2019-06-28 Thread Nick Desaulniers
On Fri, Jun 28, 2019 at 6:31 AM Peter Zijlstra wrote: > > On Thu, Jun 27, 2019 at 09:12:50AM +0200, Peter Zijlstra wrote: > > > Josh came up with the following: > > > > + /* If the jump target is close, do a 2-byte nop: */ > > + ".skip -(%l[l_yes] - 1b <= 126), 0x66\n" > >

RE: [PATCH v6 18/19] x86: Add support for generic vDSO

2019-06-28 Thread Michael Kelley
From: Thomas Gleixner Sent: Sunday, June 23, 2019 5:25 PM > > I don't care whether this goes into 5.3 or later. If you can provide me > rebased self contained patches on top of > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/vdso > > I'm happy to pull them in on top. >

Re: [RFC PATCH 0/5] Add CONFIG symbol as module attribute

2019-06-28 Thread Luis Chamberlain
On Wed, Jun 26, 2019 at 9:51 PM Christoph Hellwig wrote: > > On Wed, Jun 26, 2019 at 03:21:08PM -0700, Luis Chamberlain wrote: > > On Tue, Feb 5, 2019 at 2:07 PM Luis Chamberlain wrote: > > > In lieu of no Luke Skywalker, if you will, for a large kconfig revamp > > > on this, I'm inclined to beli

Re: [PATCH] arm64: dts: meson-g12a: add missing dwc2 phy-names

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > The G12A USB2 OTG capable PHY uses a 8bit large UTMI bus, and the OTG > controller gets the PHY but width by probing the associated phy. > > By default it will use 16bit wide settings if a phy is not specified, > in our case we specified the phy, but not the phy-names. >

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Sebastian Andrzej Siewior
On 2019-06-28 08:30:50 [-0700], Paul E. McKenney wrote: > On Fri, Jun 28, 2019 at 03:54:33PM +0200, Peter Zijlstra wrote: > > On Thu, Jun 27, 2019 at 11:41:07AM -0700, Paul E. McKenney wrote: > > > Or just don't do the wakeup at all, if it comes to that. I don't know > > > of any way to determine

Re: [PATCH v2] mtd: spinand: Add initial support for Paragon PN26G0xA

2019-06-28 Thread Miquel Raynal
On Tue, 2019-06-18 at 17:08:05 UTC, Jeff Kletsky wrote: > From: Jeff Kletsky > > Add initial support for Paragon Technology > PN26G01Ax and PN26G02Ax SPI NAND > > Datasheets available at > http://www.xtxtech.com/upfile/2016082517274590.pdf > http://www.xtxtech.com/upfile/2016082517282329

[PATCH v4 0/5] vfs: clean up SETFLAGS and FSSETXATTR option processing

2019-06-28 Thread Darrick J. Wong
Hi all, The FS_IOC_SETFLAGS and FS_IOC_FSSETXATTR ioctls were promoted from ext4 and XFS, respectively, into the VFS. However, we didn't promote any of the parameter checking code from those filesystems, which lead to a mess where each filesystem open-codes whatever parameter checks they want and

Re: [PATCH v3 3/7] sched: rotate the cpu search window for better spread

2019-06-28 Thread Parth Shah
Hi Subhra, I ran your patch series on IBM POWER systems and this is what I have observed. On 6/27/19 6:59 AM, subhra mazumdar wrote: > Rotate the cpu search window for better spread of threads. This will ensure > an idle cpu will quickly be found if one exists. > > Signed-off-by: subhra mazumdar

Re: [PATCH v3] mtd: spinand: read return badly if the last page has bitflips

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 04:14:46 UTC, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read return

Re: [PATCH v2 14/27] mtd: nand: use kzalloc instead of kmalloc and memset

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 02:48:13 UTC, Fuqian Huang wrote: > Replace kmalloc followed by a memset with kzalloc. > > There is a recommendation to use zeroing allocator > rather than allocator followed by memset with 0 in > ./scripts/coccinelle/api/alloc/zalloc-simple.cocci > > Signed-off-by: Fuqian H

Re: [PATCH v2] mtd: rawnand: stm32_fmc2: increase DMA completion timeouts

2019-06-28 Thread Miquel Raynal
On Fri, 2019-06-28 at 09:18:06 UTC, Christophe Kerello wrote: > From: Amelie Delaunay > > When the system is overloaded, DMA data transfer completion occurs after > 100ms. Increase the timeouts to let it the time to complete. > > Signed-off-by: Amelie Delaunay > Signed-off-by: Christophe Kerell

[PATCH 2/2] vfs: don't allow writes to swap files

2019-06-28 Thread Darrick J. Wong
From: Darrick J. Wong Don't let userspace write to an active swap file because the kernel effectively has a long term lease on the storage and things could get seriously corrupted if we let this happen. Signed-off-by: Darrick J. Wong --- fs/attr.c | 16 fs/block_dev.c |

[PATCH v6 0/4] vfs: make immutable files actually immutable

2019-06-28 Thread Darrick J. Wong
Hi all, The chattr(1) manpage has this to say about the immutable bit that system administrators can set on files: "A file with the 'i' attribute cannot be modified: it cannot be deleted or renamed, no link can be created to this file, most of the file's metadata can not be modified, and the file

[PATCH v2 0/2] vfs: make active swap files unwritable

2019-06-28 Thread Darrick J. Wong
Hi all, I discovered that it's possible for userspace to write to active swap files and swap devices. While activated, the kernel effectively holds an irrevocable (except by swapoff) longterm lease on the storage associated with the swap device, so we need to shut down this vector for memory corr

[PATCH 1/2] mm: set S_SWAPFILE on blockdev swap devices

2019-06-28 Thread Darrick J. Wong
From: Darrick J. Wong Set S_SWAPFILE on block device inodes so that they have the same protections as a swap flie. Signed-off-by: Darrick J. Wong --- mm/swapfile.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/mm/swapfile.c b/mm/swapfi

[PATCH 5/5] vfs: only allow FSSETXATTR to set DAX flag on files and dirs

2019-06-28 Thread Darrick J. Wong
From: Darrick J. Wong The DAX flag only applies to files and directories, so don't let it get set for other types of files. Signed-off-by: Darrick J. Wong --- fs/inode.c |8 1 file changed, 8 insertions(+) diff --git a/fs/inode.c b/fs/inode.c index 670d5408d022..f08711b34341 100

[PATCH 3/5] vfs: teach vfs_ioc_fssetxattr_check to check project id info

2019-06-28 Thread Darrick J. Wong
From: Darrick J. Wong Standardize the project id checks for FSSETXATTR. Signed-off-by: Darrick J. Wong Reviewed-by: Jan Kara --- fs/ext4/ioctl.c| 27 --- fs/f2fs/file.c | 27 --- fs/inode.c | 13 + fs/xfs/xfs_io

[PATCH v4 2/2] Drivers: hv: Move Hyper-V clocksource code to new clocksource driver

2019-06-28 Thread Michael Kelley
Continue consolidating Hyper-V clock and timer code into an ISA independent Hyper-V clocksource driver. Move the existing clocksource code under drivers/hv and arch/x86 to the new clocksource driver while separating out the ISA dependencies. Update Hyper-V initialization to call initialization and

[PATCH v4 1/2] Drivers: hv: Create Hyper-V clocksource driver from existing clockevents code

2019-06-28 Thread Michael Kelley
Hyper-V clock/timer code and data structures are currently mixed in with other code in the ISA independent drivers/hv directory as well as the ISA dependent Hyper-V code under arch/x86. Consolidate this code and data structures into a Hyper-V clocksource driver to better follow the Linux model. In

[PATCH v4 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver

2019-06-28 Thread Michael Kelley
This patch series moves Hyper-V clock/timer code to a separate Hyper-V clocksource driver. Previously, Hyper-V clock/timer code and data structures were mixed in with other Hyper-V code in the ISA independent drivers/hv code as well as in ISA dependent code. The new Hyper-V clocksource driver is IS

Re: [RFC][Patch v10 0/2] mm: Support for page hinting

2019-06-28 Thread Alexander Duyck
On Tue, Jun 25, 2019 at 10:32 AM Nitesh Narayan Lal wrote: > > On 6/25/19 1:10 PM, Alexander Duyck wrote: > > On Tue, Jun 25, 2019 at 7:49 AM Nitesh Narayan Lal > > wrote: > >> > >> On 6/3/19 2:04 PM, Michael S. Tsirkin wrote: > >>> On Mon, Jun 03, 2019 at 01:03:04PM -0400, Nitesh Narayan Lal wr

Re: [Question] Should direct reclaim time be bounded?

2019-06-28 Thread Mike Kravetz
On 4/24/19 7:35 AM, Vlastimil Babka wrote: > On 4/23/19 6:39 PM, Mike Kravetz wrote: >>> That being said, I do not think __GFP_RETRY_MAYFAIL is wrong here. It >>> looks like there is something wrong in the reclaim going on. >> >> Ok, I will start digging into that. Just wanted to make sure before

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 02:05:37PM -0400, Joel Fernandes wrote: > On Fri, Jun 28, 2019 at 10:30:11AM -0700, Paul E. McKenney wrote: > > On Fri, Jun 28, 2019 at 12:45:59PM -0400, Joel Fernandes wrote: > > > On Fri, Jun 28, 2019 at 12:40:08PM -0400, Joel Fernandes wrote: > > > > On Thu, Jun 27, 2019

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 07:45:45PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-06-28 10:30:11 [-0700], Paul E. McKenney wrote: > > > I believe the .blocked field remains set even though we are not any more > > > in a > > > reader section because of deferred processing of the blocked lists th

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Sebastian Andrzej Siewior
On 2019-06-28 14:07:27 [-0400], Joel Fernandes wrote: > On Fri, Jun 28, 2019 at 07:45:45PM +0200, Sebastian Andrzej Siewior wrote: > > On 2019-06-28 10:30:11 [-0700], Paul E. McKenney wrote: > > > > I believe the .blocked field remains set even though we are not any > > > > more in a > > > > reade

Re: [bpf/tools] cd17d77705: kernel_selftests.bpf.test_sock_addr.sh.fail

2019-06-28 Thread Andrii Nakryiko
On Thu, Jun 27, 2019 at 7:38 PM Stanislav Fomichev wrote: > > On 06/27, Andrii Nakryiko wrote: > > On Thu, Jun 27, 2019 at 10:29 AM Stanislav Fomichev > > wrote: > > > > > > On 06/27, Stanislav Fomichev wrote: > > > > On 06/27, kernel test robot wrote: > > > > > FYI, we noticed the following com

Re: [RFC/RFT v2 00/14] arm64: g12a: add support for DVFS

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > The G12A/G12B Socs embeds a specific clock tree for each CPU cluster : > cpu_clk / cpub_clk > | \- cpu_clk_dyn > | | \- cpu_clk_premux0 > | ||- cpu_clk_postmux0 > | |||- cpu_clk_dyn0_div > | ||\- xtal/fclk_div2/fclk_d

Re: [RFC/RFT v2 12/14] arm64: dts: meson-g12a: enable DVFS on G12A boards

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > Enable DVFS for the U200, SEI520 and X96-Max Amlogic G12A based board > by setting the clock, OPP and supply for each CPU cores. > > The CPU cluster power supply can achieve 0.73V to 1.01V using a PWM > output clocked at 800KHz with an inverse duty-cycle. > > DVFS has bee

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Joel Fernandes
On Fri, Jun 28, 2019 at 07:45:45PM +0200, Sebastian Andrzej Siewior wrote: > On 2019-06-28 10:30:11 [-0700], Paul E. McKenney wrote: > > > I believe the .blocked field remains set even though we are not any more > > > in a > > > reader section because of deferred processing of the blocked lists th

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Joel Fernandes
On Fri, Jun 28, 2019 at 10:30:11AM -0700, Paul E. McKenney wrote: > On Fri, Jun 28, 2019 at 12:45:59PM -0400, Joel Fernandes wrote: > > On Fri, Jun 28, 2019 at 12:40:08PM -0400, Joel Fernandes wrote: > > > On Thu, Jun 27, 2019 at 11:41:07AM -0700, Paul E. McKenney wrote: > > > [snip] > > > > > > >

Re: [PATCH v3 4/4] kbuild: compile-test kernel headers to ensure they are self-contained

2019-06-28 Thread Sam Ravnborg
Hi Masahiro. On Fri, Jun 28, 2019 at 01:39:02AM +0900, Masahiro Yamada wrote: > The headers in include/ are globally used in the kernel source tree > to provide common APIs. They are included from external modules, too. > > It will be useful to make as many headers self-contained as possible > so

Re: [RFC/RFT v2 01/14] pinctrl: meson-g12a: add pwm_a on GPIOE_2 pinmux

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > Add the missing pinmux for the pwm_a function on the GPIOE_2 pin. > > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman

Re: [RFC/RFT v2 06/14] soc: amlogic: meson-clk-measure: add G12B second cluster cpu clk

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > Add the G12B second CPU cluster CPU and SYS_PLL measure IDs. > > These IDs returns 0Hz on G12A. > > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman

Re: [RFC/RFT v2 05/14] soc: amlogic: meson-clk-measure: protect measure with a mutex

2019-06-28 Thread Kevin Hilman
Neil Armstrong writes: > In order to protect clock measuring when multiple process asks for > a mesure, protect the main measure function with mutexes. > > Signed-off-by: Neil Armstrong Reviewed-by: Kevin Hilman

[PATCH v2 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- Changes: v2: Same as v1. .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/binding

[PATCH v2 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
This driver adds the initial support for the ON Semiconductor NOA1305 Ambient Light Sensor. Originally written by Sergei Miroshnichenko. Found here: https://github.com/EmcraftSystems/linux-upstream/commit/196d6cf897e632d2cb82d45484bd7a1bfdd5b6d9 Signed-off-by: Sergei M Signed-off-by: Martyn W

[PATCH 2/2] iio: light: noa1305: Add support for NOA1305

2019-06-28 Thread Martyn Welch
From: Martyn Welch This driver adds the initial support for the ON Semiconductor NOA1305 Ambient Light Sensor. Originally written by Sergei Miroshnichenko. Found here: https://github.com/EmcraftSystems/linux-upstream/commit/196d6cf897e632d2cb82d45484bd7a1bfdd5b6d9 Signed-off-by: Sergei M Si

[PATCH 1/2] dt-bindings: Add binding document for NOA1305

2019-06-28 Thread Martyn Welch
Document the ON Semiconductor NOA1305 ambient light sensor devicetree bindings. Signed-off-by: Martyn Welch --- .../bindings/iio/light/noa1305.yaml | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/noa1305.yaml d

Re: [PATCH] ARM: mm: only adjust sections of valid mm structures

2019-06-28 Thread Florian Fainelli
On 6/27/19 2:32 PM, Doug Berger wrote: > A timing hazard exists when an early fork/exec thread begins > exiting and sets its mm pointer to NULL while a separate core > tries to update the section information. > > This commit ensures that the mm pointer is not NULL before > setting its section para

Re: [RFC PATCH bpf-next v2 0/6] bpf: add BPF_MAP_DUMP command to

2019-06-28 Thread Brian Vazquez
> was it with kpti and retpoline mitigations? No, it wasn't. Will get back with new numbers.

Re: [RFC PATCH bpf-next v2 2/6] bpf: add BPF_MAP_DUMP command to access more than one entry per call

2019-06-28 Thread Brian Vazquez
> Please explain the api behavior and corner cases in the commit log > or in code comments. Ack, will prepare a new version adding those. > Would it make sense to return last key back into prev_key, > so that next map_dump command doesn't need to copy it from the > buffer? Actually that's a good

Re: [GIT PULL rcu/next + tools/memory-model] RCU and LKMM commits for 5.3

2019-06-28 Thread Ingo Molnar
* Paul E. McKenney wrote: > Hello, Ingo, > > This pull request contains the following changes: > > 1.RCU flavor consolidation cleanups and optmizations. > > http://lkml.kernel.org/r/20190530145204.ga28...@linux.ibm.com > > 2.Documentation updates. > > http://lkml.kernel

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Sebastian Andrzej Siewior
On 2019-06-28 10:30:11 [-0700], Paul E. McKenney wrote: > > I believe the .blocked field remains set even though we are not any more in > > a > > reader section because of deferred processing of the blocked lists that you > > mentioned yesterday. > > That can indeed happen. However, in current -

Re: [PATCH 06/13] xfs: remove XFS_TRANS_NOFS

2019-06-28 Thread Darrick J. Wong
On Fri, Jun 28, 2019 at 07:37:17AM +0200, Christoph Hellwig wrote: > On Thu, Jun 27, 2019 at 03:30:30PM -0700, Darrick J. Wong wrote: > > I think the wording of this is too indirect. The reason we need to set > > NOFS is because we could be doing writeback as part of reclaiming > > memory, which m

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 10:30:11AM -0700, Paul E. McKenney wrote: > On Fri, Jun 28, 2019 at 12:45:59PM -0400, Joel Fernandes wrote: > > On Fri, Jun 28, 2019 at 12:40:08PM -0400, Joel Fernandes wrote: > > > On Thu, Jun 27, 2019 at 11:41:07AM -0700, Paul E. McKenney wrote: > > > [snip] > > > > > > >

Re: [PATCH v2 bpf-next] RV32G eBPF JIT

2019-06-28 Thread Luke Nelson
On Thu, Jun 27, 2019 at 5:18 AM Jiong Wang wrote: > > #define BPF_ZEXT_REG(DST) > ((struct bpf_insn) { > .code = BPF_ALU | BPF_MOV | BPF_X > > So it can't be BPF_ALU64. It is safe to remove this chunk of code. > Thanks! I'll fix this in the next revision. - Luke

[PATCH v2 4/4] tracing: Add new testcases for hist trigger parsing errors

2019-06-28 Thread Tom Zanussi
Add a testcase ensuring that the tracing error_log correctly displays hist trigger parsing errors. Signed-off-by: Tom Zanussi Reviewed-by: Masami Hiramatsu --- .../test.d/trigger/trigger-hist-syntax-errors.tc | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 t

[PATCH v2 3/4] tracing: Add 'hist:' to hist trigger error log error string

2019-06-28 Thread Tom Zanussi
The 'hist:' prefix gets stripped from the command text during command processing, but should be added back when displaying the command during error processing. Not only because it's what should be displayed but also because not having it means the test cases fail because the caret is miscalculated

[PATCH v2 2/4] tracing: Add hist trigger error messages for sort specification

2019-06-28 Thread Tom Zanussi
Add error codes and messages for all the error paths leading to sort specification parsing errors. Signed-off-by: Tom Zanussi Reviewed-by: Masami Hiramatsu --- kernel/trace/trace_events_hist.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/kernel/trac

[PATCH v2 1/4] tracing: Simplify assignment parsing for hist triggers

2019-06-28 Thread Tom Zanussi
In the process of adding better error messages for sorting, I realized that strsep was being used incorrectly and some of the error paths I was expecting to be hit weren't and just fell through to the common invalid key error case. It also became obvious that for keyword assignments, it wasn't nec

[PATCH v2 0/4] tracing: Improve error messages for histogram sorting

2019-06-28 Thread Tom Zanussi
This is v2 of the histogram sorting error message patchset. The code is the same as v1 - this version only adds new Fixes:, Reviewed-by:, and Reported-by: tags. Text from original post: Hi, These patches add some improvements for histogram sorting, addressing some shortcomings pointed out by Ma

Re: [PATCH] mm: fix regression with deferred struct page init

2019-06-28 Thread Juergen Gross
On 28.06.19 17:17, Michal Hocko wrote: On Thu 20-06-19 18:08:21, Juergen Gross wrote: Commit 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time instead of doing larger sections") is causing a regression on some systems when the kernel is booted as Xen dom0. The system will just hang

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-28 Thread Steven Rostedt
On Fri, 28 Jun 2019 19:33:30 +0200 (CEST) Jiri Kosina wrote: > On Thu, 27 Jun 2019, Josh Poimboeuf wrote: > > > > How is that supposed to work? > > > > > > ftrace > > > prepare() > > >setrw() > > > setro() > > > patch <- FAIL > > > > /me dodges f

Re: [PATCH 2/2] Input: edt-ft5x06 - simplify event reporting code

2019-06-28 Thread Benoit Parrot
Dmitry Torokhov wrote on Sat [2019-Jun-22 23:31:53 -0700]: > Now that input_mt_report_slot_state() returns true if slot is active we no > longer need a temporary for the slot state. > > Signed-off-by: Dmitry Torokhov Appears to work fine in my test: Tested-by: Benoit Parrot > --- > drivers

Re: [PATCH 1/2] Input: edt-ft5x06 - use get_unaligned_be16()

2019-06-28 Thread Benoit Parrot
Dmitry Torokhov wrote on Sat [2019-Jun-22 23:31:52 -0700]: > Instead of doing conversion by hand, let's use the proper accessors. > > Signed-off-by: Dmitry Torokhov > --- > drivers/input/touchscreen/edt-ft5x06.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dri

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-28 Thread Jiri Kosina
On Thu, 27 Jun 2019, Josh Poimboeuf wrote: > > How is that supposed to work? > > > > ftrace > > prepare() > > setrw() > > setro() > > patch <- FAIL > > /me dodges frozen shark > > You are right of course. My brain has apparently already sh

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 12:45:59PM -0400, Joel Fernandes wrote: > On Fri, Jun 28, 2019 at 12:40:08PM -0400, Joel Fernandes wrote: > > On Thu, Jun 27, 2019 at 11:41:07AM -0700, Paul E. McKenney wrote: > > [snip] > > > > > > And we should document this somewhere for future sanity preservation > > > >

Re: [PATCH] netfilter: Fix remainder of pseudo-header protocol 0

2019-06-28 Thread Pablo Neira Ayuso
On Mon, Jun 24, 2019 at 11:17:38AM +0800, zhe...@windriver.com wrote: > From: He Zhe > > Since v5.1-rc1, some types of packets do not get unreachable reply with the > following iptables setting. Fox example, > > $ iptables -A INPUT -p icmp --icmp-type 8 -j REJECT > $ ping 127.0.0.1 -c 1 > PING 1

[PATCH 2/2] staging:kpc2000:Fix integer as null pointer warning

2019-06-28 Thread Harsh Jain
It fixes "Using plain integer as NULL pointer" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/staging/kpc2000/kpc_i2c/i2c_dr

[PATCH 0/2] staging:kpc2000:Fix integer as null pointer warning

2019-06-28 Thread Harsh Jain
It fixes sparse warning in kpc2000 driver. Harsh Jain (2): staging:kpc2000:Fix symbol not declared warning staging:kpc2000:Fix integer as null pointer warning drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.17.1

[PATCH 1/2] staging:kpc2000:Fix symbol not declared warning

2019-06-28 Thread Harsh Jain
It fixes "symbol was not declared. Should it be static?" sparse warning. Signed-off-by: Harsh Jain --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_i2c/i2c_driver.c b/drivers/staging/kpc2000/kpc_

Re: [PATCH 0/2] staging:kpc2000:Fix integer as null pointer warning

2019-06-28 Thread harsh jain
On Fri, Jun 28, 2019 at 10:31 PM Harsh Jain wrote: > > From: root Again sent with wrong user. Please ignore this series. Will send the updated one. > > It fixes sparse warning in kpc2000 driver. > > Harsh Jain (2): > staging:kpc2000:Fix symbol not declared warning > staging:kpc2000:Fix intege

[PATCH] kallsyms: exclude kasan local symbols on s390

2019-06-28 Thread Vasily Gorbik
gcc asan instrumentation emits the following sequence to store frame pc when the kernel is built with CONFIG_RELOCATABLE: debug/vsprintf.s: .section.data.rel.ro.local,"aw" .align 8 .LC3: .quad .LASANPC4826@GOTOFF .text .align 8 .type number, @fu

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-28 Thread Paul E. McKenney
On Fri, Jun 28, 2019 at 06:04:08PM +0200, Peter Zijlstra wrote: > On Fri, Jun 28, 2019 at 08:54:04AM -0700, Paul E. McKenney wrote: > > Thank you! Plus it looks like scheduler_ipi() takes an early exit if > > ->wake_list is empty, regardless of TIF_NEED_RESCHED, right? > > Yes, TIF_NEED_RESCHED i

Re: [PATCH] rbtree: avoid generating code twice for the cached versions

2019-06-28 Thread Davidlohr Bueso
On Thu, 27 Jun 2019, Michel Lespinasse wrote: As was already noted in rbtree.h, the logic to cache rb_first (or rb_last) can easily be implemented externally to the core rbtree api. Change the implementation to do just that. Previously the update of rb_leftmost was wired deeper into the implemn

Re: [RFC PATCH v2 02/12] powerpc/ptrace: drop unnecessary #ifdefs CONFIG_PPC64

2019-06-28 Thread Andreas Schwab
On Jun 28 2019, Christophe Leroy wrote: > Le 28/06/2019 à 18:36, Andreas Schwab a écrit : >> On Jun 28 2019, Christophe Leroy wrote: >> >>> diff --git a/arch/powerpc/include/uapi/asm/ptrace.h >>> b/arch/powerpc/include/uapi/asm/ptrace.h >>> index f5f1ccc740fc..37d7befbb8dc 100644 >>> --- a/arch

Re: [PATCH v3] Documentation:sh:convert register-banks.txt and new-machine.txt to rst format.

2019-06-28 Thread Mauro Carvalho Chehab
Em Fri, 28 Jun 2019 20:33:45 +0530 Vandana BN escreveu: > This patch converts new-machine.txt and register-banks.txt > to ReST format, No content change. > Added interfaces.rst to contain kernel-doc markups from index.rst > Added interfaces.rst,new-machine.rst and register-banks.rst to sh/index.r

Re: [PATCH v3 1/4] perf pmu: Support more complex PMU event aliasing

2019-06-28 Thread John Garry
On 28/06/2019 16:33, Andi Kleen wrote: + /* +* Match more complex aliases where the alias name is a comma-delimited +* list of tokens, orderly contained in the matching PMU name. +* +* Example: For alias "socket,pmuname" and PMU "socketX_pmunameY", we +

<    1   2   3   4   5   6   7   8   >