Re: [PATCH v2] Convert struct pid count to refcount_t

2019-07-01 Thread Jann Horn
On Fri, Jun 28, 2019 at 9:35 PM Joel Fernandes (Google) wrote: > struct pid's count is an atomic_t field used as a refcount. Use > refcount_t for it which is basically atomic_t but does additional > checking to prevent use-after-free bugs. [...] > struct pid > { > - atomic_t count; > +

Re: [PATCH net-next v2 00/10] net: stmmac: 10GbE using XGMAC

2019-07-01 Thread David Miller
From: Jose Abreu Date: Mon, 1 Jul 2019 10:19:55 + > From: David Miller > >> About the Kconfig change, maybe it just doesn't make sense to list all >> of the various speeds the chip supports... just a thought. > > What about: "STMicroelectronics Multi-Gigabit Ethernet driver" ? > > Or,

kernel BUG at include/linux/kvm_host.h:LINE!

2019-07-01 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:6fbc7275 Linux 5.2-rc7 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16d8d2cda0 kernel config: https://syzkaller.appspot.com/x/.config?x=f6451f0da3d42d53 dashboard link:

Re: [PATCH 2/2] MIPS: don't select ARCH_HAS_PTE_SPECIAL

2019-07-01 Thread Guenter Roeck
On Mon, Jul 01, 2019 at 05:18:18PM +0200, Christoph Hellwig wrote: > MIPS doesn't really have a proper pte_special implementation, just > stubs. It turns out they were not enough to make get_user_pages_fast > work, so drop the select. This means get_user_pages_fast won't > actually use the fast

Re: [PATCH 1/2] sh: stub out pud_page

2019-07-01 Thread Guenter Roeck
On Mon, Jul 01, 2019 at 05:18:17PM +0200, Christoph Hellwig wrote: > There wasn't any actual need to add a real pud_page, as pud_huge > always returns false on sh. Just stub it out to fix the sh3 > compile failure. > > Fixes: 937b4e1d6471 ("sh: add the missing pud_page definition") >

Re: [PATCH v3] Staging: most: fix coding style issues

2019-07-01 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Gabriel-Beauchamp/Staging-most-fix-coding-style-issues/20190701-203804 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__

Re: [PATCH] soc: ti: fix irq-ti-sci link error

2019-07-01 Thread santosh . shilimkar
On 6/17/19 6:01 AM, Arnd Bergmann wrote: The irqchip driver depends on the SoC specific driver, but we want to be able to compile-test it elsewhere: WARNING: unmet direct dependencies detected for TI_SCI_INTA_MSI_DOMAIN Depends on [n]: SOC_TI [=n] Selected by [y]: - TI_SCI_INTA_IRQCHIP

[PATCH] x86/ldt: Initialize the context lock for init_mm

2019-07-01 Thread Sebastian Andrzej Siewior
The mutex mm->context->lock for init_mm is not initialized for init_mm. This wasn't a problem because it remained unused. This changed however since commit 4fc19708b165c ("x86/alternatives: Initialize temporary mm for patching") Initialize the mutex for init_mm. Fixes: 4fc19708b165c

Re: [PATCH] ceph: fix end offset in truncate_inode_pages_range call

2019-07-01 Thread Jeff Layton
On Mon, 2019-07-01 at 18:16 +0100, Luis Henriques wrote: > Commit e450f4d1a5d6 ("ceph: pass inclusive lend parameter to > filemap_write_and_wait_range()") fixed the end offset parameter used to > call filemap_write_and_wait_range and invalidate_inode_pages2_range. > Unfortunately it missed

[PATCH] mm/z3fold: Fix z3fold_buddy_slots use after free

2019-07-01 Thread Henry Burns
Running z3fold stress testing with address sanitization showed zhdr->slots was being used after it was freed. z3fold_free(z3fold_pool, handle) free_handle(handle) kmem_cache_free(pool->c_handle, zhdr->slots) release_z3fold_page_locked_list(kref) __release_z3fold_page(zhdr, true)

Re: [Kernel BUG?] SMSW operation get success on UMIP KVM guest

2019-07-01 Thread Paolo Bonzini
On 01/07/19 16:53, Ricardo Neri wrote: >> >> (*) before the x86 people jump at me, this won't happen unless you >> explicitly pass an option to QEMU, such as "-cpu host,+umip". :) The >> incorrect emulation of SMSW when CR4.UMIP=1 is why. > Paolo, what do you mean by the incorrect emulation of

[PATCH v3] ALSA: hda: Fix widget_mutex incomplete protection

2019-07-01 Thread Evan Green
The widget_mutex was introduced to serialize callers to hda_widget_sysfs_{re}init. However, its protection of the sysfs widget array is incomplete. For example, it is acquired around the call to hda_widget_sysfs_reinit(), which actually creates the new array, but isn't still acquired when

Re: [PATCH v2] mdev: Send uevents around parent device registration

2019-07-01 Thread Alex Williamson
On Mon, 1 Jul 2019 22:43:10 +0530 Kirti Wankhede wrote: > On 7/1/2019 8:24 PM, Alex Williamson wrote: > > This allows udev to trigger rules when a parent device is registered > > or unregistered from mdev. > > > > Signed-off-by: Alex Williamson > > --- > > > > v2: Don't remove the dev_info(),

Re: [PATCH net v2] ipv4: don't set IPv6 only flags to IPv4 addresses

2019-07-01 Thread David Ahern
On 7/1/19 11:01 AM, Matteo Croce wrote: > Avoid the situation where an IPV6 only flag is applied to an IPv4 address: > > # ip addr add 192.0.2.1/24 dev dummy0 nodad home mngtmpaddr noprefixroute > # ip -4 addr show dev dummy0 > 2: dummy0: mtu 1500 qdisc noqueue state > UNKNOWN group

[PATCH] ceph: fix end offset in truncate_inode_pages_range call

2019-07-01 Thread Luis Henriques
Commit e450f4d1a5d6 ("ceph: pass inclusive lend parameter to filemap_write_and_wait_range()") fixed the end offset parameter used to call filemap_write_and_wait_range and invalidate_inode_pages2_range. Unfortunately it missed truncate_inode_pages_range, introducing a regression that is easily

Re: [PATCH v2] mdev: Send uevents around parent device registration

2019-07-01 Thread Kirti Wankhede
On 7/1/2019 8:24 PM, Alex Williamson wrote: > This allows udev to trigger rules when a parent device is registered > or unregistered from mdev. > > Signed-off-by: Alex Williamson > --- > > v2: Don't remove the dev_info(), Kirti requested they stay and > removing them is only tangential

Re: [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove()

2019-07-01 Thread Stefano Garzarella
On Mon, Jul 01, 2019 at 04:11:13PM +0100, Stefan Hajnoczi wrote: > On Fri, Jun 28, 2019 at 02:36:56PM +0200, Stefano Garzarella wrote: > > During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock > > before registering the driver", Stefan pointed out some possible issues > > in the

[PATCH net v2] ipv4: don't set IPv6 only flags to IPv4 addresses

2019-07-01 Thread Matteo Croce
Avoid the situation where an IPV6 only flag is applied to an IPv4 address: # ip addr add 192.0.2.1/24 dev dummy0 nodad home mngtmpaddr noprefixroute # ip -4 addr show dev dummy0 2: dummy0: mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000 inet 192.0.2.1/24 scope

[PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

2019-07-01 Thread Colin King
From: Colin Ian King The variable n_den is initialized however that value is never read as n_den is re-assigned a little later in the two paths of a following if-statement. Remove the redundant assignment. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

Re: [PATCH 03/10] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-01 Thread Rik van Riel
On Mon, 2019-07-01 at 12:29 -0400, Josef Bacik wrote: > On Fri, Jun 28, 2019 at 04:49:06PM -0400, Rik van Riel wrote: > > The runnable_load magic is used to quickly propagate information > > about > > runnable tasks up the hierarchy of runqueues. The runnable_load_avg > > is > > mostly used for

[GIT PULL] LED updates for 5.3-rc1

2019-07-01 Thread Jacek Anaszewski
Hi Linus, I'm sending early LED pull request for 5.3-rc1 since I will not have access to the Internet for most part of the next week. Please pull. This time we move lm3697 backlight support from MFD to LED subsystem and on top of that we add support for LED cell of LM36274 to the ti-lmu MFD

Re: [PATCH 3/4] net: dsa: vsc73xx: add support for parallel mode

2019-07-01 Thread Florian Fainelli
On 7/1/19 8:27 AM, Pawel Dembicki wrote: > This patch add platform part of vsc73xx driver. > It allows to use chip connected by PI interface. > > Signed-off-by: Pawel Dembicki > --- [snip] > + struct vsc73xx_platform *vsc_platform = vsc->priv; > + u32 offset; > + > + if

Re: [PATCH] vfs: move_mount: reject moving kernel internal mounts

2019-07-01 Thread Eric Biggers
On Sat, Jun 29, 2019 at 01:27:44PM -0700, Eric Biggers wrote: > > Reproducer: > > #include > > #define __NR_move_mount 429 > #define MOVE_MOUNT_F_EMPTY_PATH 0x0004 > > int main() > { > int fds[2]; > > pipe(fds); >

Re: [PATCH 1/4] net: dsa: Change DT bindings for Vitesse VSC73xx switches

2019-07-01 Thread Florian Fainelli
On 7/1/19 8:27 AM, Pawel Dembicki wrote: > This commit document changes after split vsc73xx driver into core and > spi part. The change of DT bindings is required for support the same > vsc73xx chip, which need PI bus to communicate with CPU. It also > introduce how to use vsc73xx platform driver.

[no subject]

2019-07-01 Thread UT-Bank ATM MANAGER Togo
Dear Friend, Can i trust you with investment money???looking someone from your region to help us receive it,reply for more details. Regards Mr.Koffi Edward Private email:

Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

2019-07-01 Thread Andi Kleen
> So if it is unlikely to have XSAVE but no FXSR I would suggest to add > "fpu__xstate_clear_all_cpu_caps()" to nofxsr and behave like "nofxsr > noxsave". Thanks for the analysis Sebastian. Makes sense. This would likely work, but I think I would rather just remove the option. -Andi

Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

2019-07-01 Thread Andi Kleen
> > The commit for this patch in mainline > (ccb18db2ab9d923df07e7495123fe5fb02329713) causes the kernel to hang on > boot when passing the "nofxsr" option: Thanks. Hmm, I'm not sure nofxsr ever worked on 64bit. Certainly SSE cannot be saved/restored in any other way during the context switch.

Re: Perf framework : Cluster based counter support

2019-07-01 Thread Mark Rutland
On Mon, Jul 01, 2019 at 09:09:33PM +0530, Mukesh Ojha wrote: > > On 6/28/2019 10:29 PM, Mark Rutland wrote: > > On Fri, Jun 28, 2019 at 10:23:10PM +0530, Mukesh Ojha wrote: > > > Hi All, > > Hi Mukesh, > > > > > Is it looks considerable to add cluster based event support to add in > > > current

Re: [PATCH] Revert "x86/build: Move _etext to actual end of .text"

2019-07-01 Thread Guenter Roeck
On Mon, Jul 1, 2019 at 8:52 AM Ross Zwisler wrote: > > This reverts commit 392bef709659abea614abfe53cf228e7a59876a4. > > Per the discussion here: > > https://lkml.org/lkml/2019/6/20/830 > > the above referenced commit breaks kernel compilation with old GCC > toolchains as well as current versions

Re: [PATCH 03/10] sched,fair: redefine runnable_load_avg as the sum of task_h_load

2019-07-01 Thread Josef Bacik
On Fri, Jun 28, 2019 at 04:49:06PM -0400, Rik van Riel wrote: > The runnable_load magic is used to quickly propagate information about > runnable tasks up the hierarchy of runqueues. The runnable_load_avg is > mostly used for the load balancing code, which only examines the value at > the root

[PATCH][next] iwlwifi: mvm: fix comparison of u32 variable with less than zero

2019-07-01 Thread Colin King
From: Colin Ian King The comparison of the u32 variable wgds_tbl_idx with less than zero is always going to be false because it is unsigned. Fix this by making wgds_tbl_idx a plain signed int. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 4fd445a2c855 ("iwlwifi: mvm: Add log

Re: [PATCH] fork: return proper negative error code

2019-07-01 Thread Al Viro
On Mon, Jul 01, 2019 at 04:48:08PM +0200, Christian Brauner wrote: > Make sure to return a proper negative error code from copy_process() > when anon_inode_getfile() fails with CLONE_PIDFD. Acked-by: Al Viro

Re: [PATCH v2 0/5] PM: PCI/ACPI: Hibernation handling fixes

2019-07-01 Thread Mika Westerberg
On Mon, Jul 01, 2019 at 12:42:14PM +0200, Rafael J. Wysocki wrote: > Hi All, > > This series of patches addresses a few issues related to the handling of > hibernation in the PCI bus type and the ACPI PM domain and ACPI LPSS driver. > > The v2 addresses Hans' concerns regarding the LPSS changes.

Re: [PATCH v5 net-next 6/6] net: ethernet: ti: cpsw: add XDP support

2019-07-01 Thread Jesper Dangaard Brouer
On Sun, 30 Jun 2019 20:23:48 +0300 Ivan Khoronzhuk wrote: > +static int cpsw_ndev_create_xdp_rxq(struct cpsw_priv *priv, int ch) > +{ > + struct cpsw_common *cpsw = priv->cpsw; > + int ret, new_pool = false; > + struct xdp_rxq_info *rxq; > + > + rxq = >xdp_rxq[ch]; > + > +

[GIT PULL] fixes for v5.2-rc8

2019-07-01 Thread Christian Brauner
/brauner/linux tags/for-linus-20190701 for you to fetch changes up to 28dd29c06d0dede4b32b2c559cff21955a830928: fork: return proper negative error code (2019-07-01 16:43:30 +0200) With Al's removal of ksys_close() from cleanup paths in copy_process() a bug was introduced. When

Re: [PATCH AUTOSEL 5.1 07/51] ASoC: soc-dpm: fixup DAI active unbalance

2019-07-01 Thread Mark Brown
On Wed, Jun 26, 2019 at 08:20:59PM -0400, Sasha Levin wrote: > On Wed, Jun 26, 2019 at 11:03:15AM +0100, Mark Brown wrote: > > On Tue, Jun 25, 2019 at 11:40:23PM -0400, Sasha Levin wrote: > > > [ Upstream commit f7c4842abfa1a219554a3ffd8c317e8fdd979bec ] > > > snd_soc_dai_link_event() is

Re: [PATCH v2 1/5] PM: ACPI/PCI: Resume all devices during hibernation

2019-07-01 Thread Mika Westerberg
On Mon, Jul 01, 2019 at 12:44:25PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Both the PCI bus type and the ACPI PM domain avoid resuming > runtime-suspended devices with DPM_FLAG_SMART_SUSPEND set during > hibernation (before creating the snapshot image of system memory), >

Re: [PATCH net] ipv4: don't set IPv6 only flags to IPv4 addresses

2019-07-01 Thread Matteo Croce
On Mon, Jul 1, 2019 at 6:10 PM Joe Perches wrote: > > On Mon, 2019-07-01 at 18:08 +0200, Matteo Croce wrote: > > Avoid the situation where an IPV6 only flag is applied to an IPv4 address: > [] > > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c > [] > > @@ -468,6 +473,9 @@ static int

Re: [PATCH 3/4] net: dsa: vsc73xx: add support for parallel mode

2019-07-01 Thread Andrew Lunn
On Mon, Jul 01, 2019 at 05:27:22PM +0200, Pawel Dembicki wrote: > +static int vsc73xx_platform_read(struct vsc73xx *vsc, u8 block, u8 subblock, > + u8 reg, u32 *val) > +{ > + struct vsc73xx_platform *vsc_platform = vsc->priv; > + u32 offset; > + > + if

Re: [PATCH net] ipv4: don't set IPv6 only flags to IPv4 addresses

2019-07-01 Thread Joe Perches
On Mon, 2019-07-01 at 18:08 +0200, Matteo Croce wrote: > Avoid the situation where an IPV6 only flag is applied to an IPv4 address: [] > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c [] > @@ -468,6 +473,9 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, > struct nlmsghdr *nlh, >

Re: [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management

2019-07-01 Thread Andrew F. Davis
On 7/1/19 11:35 AM, Nikolaus Voss wrote: > On Mon, 1 Jul 2019, Andrew F. Davis wrote: >> On 7/1/19 9:42 AM, Nikolaus Voss wrote: >>> Replace enum tas572x_type with struct tas5720_variant which aggregates >>> variant specific stuff and can be directly referenced from an id table. >>> >>>

[PATCH net] ipv4: don't set IPv6 only flags to IPv4 addresses

2019-07-01 Thread Matteo Croce
Avoid the situation where an IPV6 only flag is applied to an IPv4 address: # ip addr add 192.0.2.1/24 dev dummy0 nodad home mngtmpaddr noprefixroute # ip -4 addr show dev dummy0 2: dummy0: mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000 inet 192.0.2.1/24 scope

Re: RISC-V nommu support v2

2019-07-01 Thread Paul Walmsley
Hi Christoph, Probably best to feed the mm patches to Andrew. For the RISC-V patches, am running a bit behind this merge window. Combined with the end of the week holidays in the US, I doubt I'll make it to to the nommu series for v5.3. - Paul On Mon, 1 Jul 2019, Christoph Hellwig wrote:

Re: [Kernel BUG?] SMSW operation get success on UMIP KVM guest

2019-07-01 Thread Ricardo Neri
On Mon, Jul 01, 2019 at 08:57:28PM +0800, Li Wang wrote: > On Mon, Jul 1, 2019 at 8:02 PM Paolo Bonzini wrote: > > > On 01/07/19 09:50, Li Wang wrote: > > > Hello there, > > > > > > LTP/umip_basic_test get failed on KVM UMIP > > > system(kernel-v5.2-rc4.x86_64). The test is only trying to do > >

Re: [PATCH 2/4] net: dsa: vsc73xx: Split vsc73xx driver

2019-07-01 Thread Andrew Lunn
> @@ -495,12 +380,12 @@ static int vsc73xx_update_bits(struct vsc73xx *vsc, u8 > block, u8 subblock, > int ret; > > /* Same read-modify-write algorithm as e.g. regmap */ > - ret = vsc73xx_read(vsc, block, subblock, reg, ); > + ret = vsc->ops->read(vsc, block, subblock, reg,

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-07-01 Thread Paul E. McKenney
On Mon, Jul 01, 2019 at 04:00:53PM +0200, Peter Zijlstra wrote: > On Mon, Jul 01, 2019 at 05:23:05AM -0700, Paul E. McKenney wrote: > > On Mon, Jul 01, 2019 at 12:24:42PM +0200, Sebastian Andrzej Siewior wrote: > > > On 2019-07-01 11:42:15 [+0200], Peter Zijlstra wrote: > > > > I'm not sure if

Re: [PATCH v2 1/2] ALSA: hda: Fix widget_mutex incomplete protection

2019-07-01 Thread Evan Green
On Mon, Jul 1, 2019 at 7:09 AM Takashi Iwai wrote: > > On Wed, 26 Jun 2019 23:22:19 +0200, > Evan Green wrote: > > > > The widget_mutex was introduced to serialize callers to > > hda_widget_sysfs_{re}init. However, its protection of the sysfs widget array > > is incomplete. For example, it is

Re: [PATCH 1/4] net: dsa: Change DT bindings for Vitesse VSC73xx switches

2019-07-01 Thread Andrew Lunn
On Mon, Jul 01, 2019 at 05:27:20PM +0200, Pawel Dembicki wrote: > This commit document changes after split vsc73xx driver into core and > spi part. The change of DT bindings is required for support the same > vsc73xx chip, which need PI bus to communicate with CPU. It also SPI > introduce how to

Re: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds

2019-07-01 Thread Dinh Nguyen
On 6/27/19 9:07 AM, Ong, Hean Loong wrote: > Adding LED Triggers Timers for LED blinking support on ARM devices > > Signed-off-by: Ong, Hean Loong > --- > arch/arm64/configs/defconfig |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/configs/defconfig

Re: [PATCH 2/2] drivers: qcom: rpmh-rsc: fix read back of trigger register

2019-07-01 Thread Lina Iyer
Switching Andy's email address. On Mon, Jul 01 2019 at 09:32 -0600, Lina Iyer wrote: When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the

Re: [PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-01 Thread Lina Iyer
Switching Andy's email address. On Mon, Jul 01 2019 at 09:32 -0600, Lina Iyer wrote: From: "Raju P.L.S.S.S.N" tcs->lock was introduced to serialize access with in TCS group. But even without tcs->lock, drv->lock is serving the same purpose. So use a single drv->lock. Other optimizations

[PATCH] Revert "x86/build: Move _etext to actual end of .text"

2019-07-01 Thread Ross Zwisler
This reverts commit 392bef709659abea614abfe53cf228e7a59876a4. Per the discussion here: https://lkml.org/lkml/2019/6/20/830 the above referenced commit breaks kernel compilation with old GCC toolchains as well as current versions of the Gold linker. Revert it so we don't regress and lose the

Re: Adding some trees to linux-next?

2019-07-01 Thread Darrick J. Wong
On Tue, Jul 02, 2019 at 01:42:10AM +1000, Stephen Rothwell wrote: > Hi Darrick, > > On Mon, 1 Jul 2019 08:35:52 -0700 "Darrick J. Wong" > wrote: > > > > Could you add my iomap-for-next and vfs-for-next branches to linux-next, > > please? They can be found here: > > > >

Re: Adding some trees to linux-next?

2019-07-01 Thread Stephen Rothwell
Hi Darrick, On Mon, 1 Jul 2019 08:35:52 -0700 "Darrick J. Wong" wrote: > > Could you add my iomap-for-next and vfs-for-next branches to linux-next, > please? They can be found here: > > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git#iomap-for-next >

[PATCH v2] sched/fair: fix imbalance due to CPU affinity

2019-07-01 Thread Vincent Guittot
The load_balance() has a dedicated mecanism to detect when an imbalance is due to CPU affinity and must be handled at parent level. In this case, the imbalance field of the parent's sched_group is set. The description of sg_imbalanced() gives a typical example of two groups of 4 CPUs each and 4

Re: [PATCH] csky: Improve abiv1 mem ops performance with glibc codes

2019-07-01 Thread Arnd Bergmann
On Mon, Jul 1, 2019 at 5:26 PM Guo Ren wrote: > On Mon, Jul 1, 2019 at 10:52 PM Arnd Bergmann wrote: > > > > On Sat, Jun 29, 2019 at 7:36 AM wrote: > > > > > > From: Guo Ren > > > > > > These codes are copied from glibc/string directory, they are the generic > > > implementation for string

Re: [PATCH] media: venus: Update to bitrate based clock scaling

2019-07-01 Thread Stanimir Varbanov
Hi Aniket, On 6/26/19 11:23 AM, Aniket Masule wrote: > Introduced clock scaling using bitrate, current > calculations consider only the cycles per mb. > Also, clock scaling is now triggered before every > buffer being queued to the device. This helps in > deciding precise clock cycles required. >

Re: [PATCH] vfs: move_mount: reject moving kernel internal mounts

2019-07-01 Thread Eric Biggers
On Mon, Jul 01, 2019 at 02:08:48AM +0100, Al Viro wrote: > > Let's reorder that a bit: > /* The mountpoint must be in our namespace. */ > if (!check_mnt(p)) > goto out; > > /* The thing moved must be mounted... */ > if (!is_mounted(old_path->mnt)) >

Re: Adding some trees to linux-next?

2019-07-01 Thread Stephen Rothwell
Hi Darrick, On Mon, 1 Jul 2019 08:35:52 -0700 "Darrick J. Wong" wrote: > > Could you add my iomap-for-next and vfs-for-next branches to linux-next, > please? They can be found here: > > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git#iomap-for-next >

Re: remove asm-generic/ptrace.h v3

2019-07-01 Thread Arnd Bergmann
On Mon, Jun 24, 2019 at 9:23 AM Thomas Gleixner wrote: > > On Mon, 24 Jun 2019, Christoph Hellwig wrote: > > > > asm-generic/ptrace.h is a little weird in that it doesn't actually > > implement any functionality, but it provided multiple layers of macros > > that just implement trivial inline

Re: Perf framework : Cluster based counter support

2019-07-01 Thread Mukesh Ojha
On 6/28/2019 10:29 PM, Mark Rutland wrote: On Fri, Jun 28, 2019 at 10:23:10PM +0530, Mukesh Ojha wrote: Hi All, Hi Mukesh, Is it looks considerable to add cluster based event support to add in current perf event framework and later in userspace perf to support such events ? Could you

[PATCH] sched/fair: fix imbalance due to CPU affinity

2019-07-01 Thread Vincent Guittot
The load_balance() has a dedicated mecanism to detect when an imbalance is due to CPU affinity and must be handled at parent level. In this case, the imbalance field of the parent's sched_group is set. The description of sg_imbalanced() gives a typical example of two groups of 4 CPUs each and 4

Re: [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function

2019-07-01 Thread Dan Murphy
JJ On 7/1/19 10:26 AM, Jean-Jacques Hiblot wrote: The driver parses the device-tree to identify which LED should be handled. Since the information about the device node is known at this time, we can provide the LED core with it. It may be useful later. Signed-off-by: Jean-Jacques Hiblot ---

Re: [PATCH 1/2] leds: tlc591xx: simplify driver by using the managed led API

2019-07-01 Thread Dan Murphy
On 7/1/19 10:26 AM, Jean-Jacques Hiblot wrote: Use the managed API of the LED class (devm_led_classdev_register() instead of led_classdev_register()). This allows us to remove the code used to track-and-destroy the LED devices Signed-off-by: Jean-Jacques Hiblot ---

Adding some trees to linux-next?

2019-07-01 Thread Darrick J. Wong
Hi Stephen, Could you add my iomap-for-next and vfs-for-next branches to linux-next, please? They can be found here: git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git#iomap-for-next git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git#vfs-for-next I've decided that trying to munge all that

Re: [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management

2019-07-01 Thread Nikolaus Voss
On Mon, 1 Jul 2019, Andrew F. Davis wrote: On 7/1/19 9:42 AM, Nikolaus Voss wrote: Replace enum tas572x_type with struct tas5720_variant which aggregates variant specific stuff and can be directly referenced from an id table. Signed-off-by: Nikolaus Voss --- sound/soc/codecs/tas5720.c | 98

NO_HZ_IDLE causes consistently low cpu "iowait" time (and higher cpu "idle" time)

2019-07-01 Thread Alan Jenkins
Hi I tried running a simple test:     dd if=testfile iflag=direct bs=1M of=/dev/null With my default settings, `vmstat 10` shows something like 85% idle time to 15% iowait time. I have 4 CPUs, so this is much less than one CPU worth of iowait time. If I boot with "nohz=off", I see idle

[PATCH 1/2] drivers: qcom: rpmh-rsc: simplify TCS locking

2019-07-01 Thread Lina Iyer
From: "Raju P.L.S.S.S.N" tcs->lock was introduced to serialize access with in TCS group. But even without tcs->lock, drv->lock is serving the same purpose. So use a single drv->lock. Other optimizations include - - Remove locking around clear_bit() in IRQ handler. clear_bit() is atomic. -

[PATCH 2/2] drivers: qcom: rpmh-rsc: fix read back of trigger register

2019-07-01 Thread Lina Iyer
When triggering a TCS to send its contents, reading back the trigger value may return an incorrect value. That is because, writing the trigger may raise an interrupt which could be handled immediately and the trigger value could be reset in the interrupt handler. By doing a read back we may end up

Re: [PATCH] net: usb: asix: init MAC address buffers

2019-07-01 Thread Dan Williams
On Mon, 2019-07-01 at 06:45 +0700, Phong Tran wrote: > This is for fixing bug KMSAN: uninit-value in ax88772_bind > > Tested by > https://groups.google.com/d/msg/syzkaller-bugs/aFQurGotng4/cFe9nxMCCwAJ > > Reported-by: syzbot+8a3fc6674bbc3978e...@syzkaller.appspotmail.com > > syzbot found the

Re: [PATCH] media: venus: Update to bitrate based clock scaling

2019-07-01 Thread Stanimir Varbanov
Hi Aniket, On 6/26/19 11:23 AM, Aniket Masule wrote: > This patch introduces bitrate based clock scaling. Also, clock scaling is now > triggered before buffer being queued to the device. This checks for frequency > requirement throughout the session and updates clock with correct frequency >

[PATCH 1/4] net: dsa: Change DT bindings for Vitesse VSC73xx switches

2019-07-01 Thread Pawel Dembicki
This commit document changes after split vsc73xx driver into core and spi part. The change of DT bindings is required for support the same vsc73xx chip, which need PI bus to communicate with CPU. It also introduce how to use vsc73xx platform driver. Signed-off-by: Pawel Dembicki ---

[PATCH 4/4] net: dsa: vsc73xx: Assert reset if iCPU is enabled

2019-07-01 Thread Pawel Dembicki
Driver allow to use devices with disabled iCPU only. Some devices have pre-initialised iCPU by bootloader. That state make switch unmanaged. This patch force reset if device is in unmanaged state. In the result chip lost internal firmware from RAM and it can be managed. Signed-off-by: Pawel

[PATCH 2/4] net: dsa: vsc73xx: Split vsc73xx driver

2019-07-01 Thread Pawel Dembicki
This driver (currently) only takes control of the switch chip over SPI and configures it to route packages around when connected to a CPU port. But Vitesse chip support also parallel interface. This patch split driver into two parts: core and spi. It is required for add support to another

[PATCH 3/4] net: dsa: vsc73xx: add support for parallel mode

2019-07-01 Thread Pawel Dembicki
This patch add platform part of vsc73xx driver. It allows to use chip connected by PI interface. Signed-off-by: Pawel Dembicki --- drivers/net/dsa/Kconfig| 8 + drivers/net/dsa/Makefile | 1 + drivers/net/dsa/vitesse-vsc73xx-platform.c | 166

[PATCH] md/raid: Replace a seq_printf() call by seq_putc() in three functions

2019-07-01 Thread Markus Elfring
From: Markus Elfring Date: Mon, 1 Jul 2019 17:10:13 +0200 A single character (depending on a condition check) should be put into a sequence. Thus use the corresponding function “seq_putc”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH] csky: Improve abiv1 mem ops performance with glibc codes

2019-07-01 Thread Guo Ren
Hi Arnd, On Mon, Jul 1, 2019 at 10:52 PM Arnd Bergmann wrote: > > On Sat, Jun 29, 2019 at 7:36 AM wrote: > > > > From: Guo Ren > > > > These codes are copied from glibc/string directory, they are the generic > > implementation for string operations. We may further optimize them with > >

Re: [PATCH v2] mmc: sdhci-msm: fix mutex while in spinlock

2019-07-01 Thread Vinod Koul
On 01-07-19, 17:01, Jorge Ramirez-Ortiz wrote: > mutexes can sleep and therefore should not be taken while holding a > spinlock. move clk_get_rate (can sleep) outside the spinlock protected > region. Reviewed-by: Vinod Koul -- ~Vinod

[PATCH 1/2] leds: tlc591xx: simplify driver by using the managed led API

2019-07-01 Thread Jean-Jacques Hiblot
Use the managed API of the LED class (devm_led_classdev_register() instead of led_classdev_register()). This allows us to remove the code used to track-and-destroy the LED devices Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/leds-tlc591xx.c | 81 ++-- 1

[PATCH 0/2] leds: tlc591xx: switch to OF and managed API

2019-07-01 Thread Jean-Jacques Hiblot
This mini-series updates the tlc591xx driver to use the managed API. The driver is also modified to pass the DT node to the LED core layer. The goal is to be able to the generic led-backlight [0] driver on top of it. [0] https://lore.kernel.org/patchwork/project/lkml/list/?series=400524

[PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function

2019-07-01 Thread Jean-Jacques Hiblot
The driver parses the device-tree to identify which LED should be handled. Since the information about the device node is known at this time, we can provide the LED core with it. It may be useful later. Signed-off-by: Jean-Jacques Hiblot --- drivers/leds/leds-tlc591xx.c | 2 +- 1 file changed,

Re: [PATCH v3 2/2] arch: wire-up clone3() syscall

2019-07-01 Thread Christian Brauner
On Mon, Jul 01, 2019 at 05:14:51PM +0200, Arnd Bergmann wrote: > On Fri, Jun 21, 2019 at 5:30 PM Christian Brauner > wrote: > > On Fri, Jun 21, 2019 at 04:20:15PM +0200, Arnd Bergmann wrote: > > > On Fri, Jun 21, 2019 at 1:18 PM Christian Brauner > > > wrote: > > Hm, if you believe that this

Re: [PATCH] scsi: virtio_scsi: Use struct_size() helper

2019-07-01 Thread Stefan Hajnoczi
On Wed, Jun 19, 2019 at 02:28:33PM -0500, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct

Re: [UPDATE][PATCH 10/10] tools/power/x86: A tool to validate Intel Speed Select commands

2019-07-01 Thread Srinivas Pandruvada
On Mon, 2019-07-01 at 14:32 +0300, Andy Shevchenko wrote: > On Sun, Jun 30, 2019 at 8:14 PM Srinivas Pandruvada > wrote: > > > > The Intel(R) Speed select technologies contains four features. > > > > Performance profile:An non architectural mechanism that allows > > multiple > > optimized

[PATCH 1/2] sh: stub out pud_page

2019-07-01 Thread Christoph Hellwig
There wasn't any actual need to add a real pud_page, as pud_huge always returns false on sh. Just stub it out to fix the sh3 compile failure. Fixes: 937b4e1d6471 ("sh: add the missing pud_page definition") Reported-by: Guenter Roeck Signed-off-by: Christoph Hellwig ---

generic gup fixups

2019-07-01 Thread Christoph Hellwig
Hi Andrew, below two fixups for the generic GUP series, as reported by Guenter.

[PATCH 2/2] MIPS: don't select ARCH_HAS_PTE_SPECIAL

2019-07-01 Thread Christoph Hellwig
MIPS doesn't really have a proper pte_special implementation, just stubs. It turns out they were not enough to make get_user_pages_fast work, so drop the select. This means get_user_pages_fast won't actually use the fast path for non-hugepage mappings, so someone who actually knows about mips

Re: general protection fault in do_move_mount (2)

2019-07-01 Thread Eric Biggers
On Mon, Jul 01, 2019 at 04:59:04PM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote: > > > > Dmitry, any idea why syzbot found such a bizarre reproducer for this? > > This is actually reproducible by a simple single threaded program: > > > > #include > > > > #define __NR_move_mount

Re: [PATCH v3 2/2] arch: wire-up clone3() syscall

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 21, 2019 at 5:30 PM Christian Brauner wrote: > On Fri, Jun 21, 2019 at 04:20:15PM +0200, Arnd Bergmann wrote: > > On Fri, Jun 21, 2019 at 1:18 PM Christian Brauner > > wrote: > Hm, if you believe that this is fine and want to "vouch" for it by > whipping up a patch that replaces the

Re: [PATCH v2 0/3] vsock/virtio: several fixes in the .probe() and .remove()

2019-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2019 at 02:36:56PM +0200, Stefano Garzarella wrote: > During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock > before registering the driver", Stefan pointed out some possible issues > in the .probe() and .remove() callbacks of the virtio-vsock driver. > > This

Re: [PATCH 1/2] ARM: davinci: da830-evm: add missing regulator constraints for OHCI

2019-07-01 Thread Sekhar Nori
On 25/06/19 10:19 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We need to enable status changes for the fixed power supply for the USB > controller. > > Fixes: 274e4c336192 ("ARM: davinci: da830-evm: add a fixed regulator for > ohci-da8xx") > Cc: sta...@vger.kernel.org >

Re: [PATCH v2 1/3] vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock

2019-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2019 at 02:36:57PM +0200, Stefano Garzarella wrote: > Some callbacks used by the upper layers can run while we are in the > .remove(). A potential use-after-free can happen, because we free > the_virtio_vsock without knowing if the callbacks are over or not. > > To solve this

Re: [PATCH v2 3/3] vsock/virtio: fix flush of works during the .remove()

2019-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2019 at 02:36:59PM +0200, Stefano Garzarella wrote: > This patch moves the flush of works after vdev->config->del_vqs(vdev), > because we need to be sure that no workers run before to free the > 'vsock' object. > > Since we stopped the workers using the [tx|rx|event]_run flags, >

Re: [PATCH] ARM: davinci: da830-evm: fix GPIO lookup for OHCI

2019-07-01 Thread Sekhar Nori
On 25/06/19 8:46 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The fixed regulator driver doesn't specify any con_id for gpio lookup > so it must be NULL in the table entry. > > Fixes: 274e4c336192 ("ARM: davinci: da830-evm: add a fixed regulator for > ohci-da8xx") > Cc:

Re: [PATCH v2 3/3] vsock/virtio: fix flush of works during the .remove()

2019-07-01 Thread Stefan Hajnoczi
On Fri, Jun 28, 2019 at 02:36:59PM +0200, Stefano Garzarella wrote: > This patch moves the flush of works after vdev->config->del_vqs(vdev), > because we need to be sure that no workers run before to free the > 'vsock' object. > > Since we stopped the workers using the [tx|rx|event]_run flags, >

Re: [PATCH v2] mdev: Send uevents around parent device registration

2019-07-01 Thread Cornelia Huck
On Mon, 01 Jul 2019 08:54:44 -0600 Alex Williamson wrote: > This allows udev to trigger rules when a parent device is registered > or unregistered from mdev. > > Signed-off-by: Alex Williamson > --- > > v2: Don't remove the dev_info(), Kirti requested they stay and > removing them is only

[PATCH] staging: kpc2000: drop useless softdep statement

2019-07-01 Thread Jean Delvare
The i2c-dev module is for access to I2C buses from user-space. Kernel drivers do not care about its presence. Signed-off-by: Jean Delvare Cc: Matt Sickler Cc: Greg Kroah-Hartman --- drivers/staging/kpc2000/kpc_i2c/i2c_driver.c |1 - 1 file changed, 1 deletion(-) ---

Re: [PATCH] hinic: reduce rss_init stack usage

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 6:32 PM David Miller wrote: > > From: Arnd Bergmann > Date: Fri, 28 Jun 2019 12:31:44 +0200 > > > On 32-bit architectures, putting an array of 256 u32 values on the > > stack uses more space than the warning limit: > > > > drivers/net/ethernet/huawei/hinic/hinic_main.c:

Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency

2019-07-01 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 9:53 PM Paul Cercueil wrote: > Le jeu. 27 juin 2019 à 18:40, Miquel Raynal > a écrit : > > Miquel Raynal wrote on Mon, 17 Jun 2019 > > 14:16:59 +0200: > >> I personally have a preference for this one. > > > > Would you mind sending the above change? I forgot about it

[PATCH v2] mmc: sdhci-msm: fix mutex while in spinlock

2019-07-01 Thread Jorge Ramirez-Ortiz
mutexes can sleep and therefore should not be taken while holding a spinlock. move clk_get_rate (can sleep) outside the spinlock protected region. Fixes: 83736352e0ca ("mmc: sdhci-msm: Update DLL reset sequence") Cc: sta...@vger.kernel.org Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Bjorn

<    1   2   3   4   5   6   7   8   9   >